Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Hardcode84 committed rG00a756d3f6e9: [mlir] Remove invalid DeallocOpLowering pattern insertion (authored by Hardcode84).
[mlir] Remove invalid DeallocOpLowering pattern insertion
Mon, Aug 2, 1:29 AM
Hardcode84 closed D107238: [mlir] Remove invalid DeallocOpLowering pattern insertion.
Mon, Aug 2, 1:28 AM · Restricted Project

Sun, Aug 1

Hardcode84 requested review of D107238: [mlir] Remove invalid DeallocOpLowering pattern insertion.
Sun, Aug 1, 4:53 AM · Restricted Project
Hardcode84 committed rG7d855605830f: [mlir] Add populateGpuToLLVMConversionPatterns function (authored by Hardcode84).
[mlir] Add populateGpuToLLVMConversionPatterns function
Sun, Aug 1, 1:56 AM
Hardcode84 closed D107218: [mlir] Add populateGpuToLLVMConversionPatterns function.
Sun, Aug 1, 1:56 AM · Restricted Project

Sat, Jul 31

Hardcode84 updated the diff for D107218: [mlir] Add populateGpuToLLVMConversionPatterns function.

Update comment

Sat, Jul 31, 5:39 AM · Restricted Project
Hardcode84 added a reviewer for D107218: [mlir] Add populateGpuToLLVMConversionPatterns function: csigg.
Sat, Jul 31, 2:51 AM · Restricted Project
Hardcode84 requested review of D107218: [mlir] Add populateGpuToLLVMConversionPatterns function.
Sat, Jul 31, 2:50 AM · Restricted Project

Fri, Jul 30

Hardcode84 added a comment to D98930: [mlir] Rename gpu-to-llvm pass implementation file.

Why was populateGpuToLLVMConversionPatterns function removed?
If there are not objections I will send patch to add it back.

Fri, Jul 30, 10:23 AM · Restricted Project
Hardcode84 committed rG1e9799e204ff: [mlir][spirv] Fix crash in convert-gpu-to-spirv pass with memrefs with affine… (authored by Hardcode84).
[mlir][spirv] Fix crash in convert-gpu-to-spirv pass with memrefs with affine…
Fri, Jul 30, 2:51 AM
Hardcode84 closed D106988: [mlir][spirv] Fix crash in convert-gpu-to-spirv pass with memrefs with affine maps.
Fri, Jul 30, 2:51 AM · Restricted Project

Wed, Jul 28

Hardcode84 added a comment to D106988: [mlir][spirv] Fix crash in convert-gpu-to-spirv pass with memrefs with affine maps.

Also, is there any plans to actually support memrefs with dynamic offset and strides?

Wed, Jul 28, 1:53 PM · Restricted Project
Hardcode84 updated the diff for D106988: [mlir][spirv] Fix crash in convert-gpu-to-spirv pass with memrefs with affine maps.

Add comment to getElementPtr

Wed, Jul 28, 1:52 PM · Restricted Project
Hardcode84 requested review of D106988: [mlir][spirv] Fix crash in convert-gpu-to-spirv pass with memrefs with affine maps.
Wed, Jul 28, 12:40 PM · Restricted Project

Sat, Jul 24

Hardcode84 committed rGb7a464989955: [mlir] ConversionTarget legality callbacks refactoring (authored by Hardcode84).
[mlir] ConversionTarget legality callbacks refactoring
Sat, Jul 24, 5:00 AM
Hardcode84 closed D105496: [mlir] ConversionTarget legality callbacks refactoring.
Sat, Jul 24, 5:00 AM · Restricted Project

Wed, Jul 14

Hardcode84 committed rGa36e9ee09d2e: [mlir][SCF] populateSCFStructuralTypeConversionsAndLegality WhileOp support (authored by Hardcode84).
[mlir][SCF] populateSCFStructuralTypeConversionsAndLegality WhileOp support
Wed, Jul 14, 2:46 AM
Hardcode84 closed D105923: [mlir][SCF] populateSCFStructuralTypeConversionsAndLegality WhileOp support.
Wed, Jul 14, 2:46 AM · Restricted Project
Hardcode84 added a comment to D105496: [mlir] ConversionTarget legality callbacks refactoring.

@rriddle ping

Wed, Jul 14, 2:00 AM · Restricted Project
Hardcode84 updated the diff for D105923: [mlir][SCF] populateSCFStructuralTypeConversionsAndLegality WhileOp support.

Review comment and warning

Wed, Jul 14, 1:54 AM · Restricted Project

Tue, Jul 13

Hardcode84 added a reviewer for D105923: [mlir][SCF] populateSCFStructuralTypeConversionsAndLegality WhileOp support: ftynse.
Tue, Jul 13, 11:38 AM · Restricted Project
Hardcode84 requested review of D105923: [mlir][SCF] populateSCFStructuralTypeConversionsAndLegality WhileOp support.
Tue, Jul 13, 11:38 AM · Restricted Project
Hardcode84 added a comment to D105886: [mlir][memref] Propagate LoadOp/StoreOp to SubViewOp source where possible.

So, what useful information we are losing here? Subview dimensions? Is there any examples they can be usefull in this context?

Tue, Jul 13, 7:12 AM · Restricted Project
Hardcode84 added a comment to D105886: [mlir][memref] Propagate LoadOp/StoreOp to SubViewOp source where possible.

Actually, there is a FoldSubViewOpsPass, but is can generate additional ops, which can be undesirable during canonicalization. Here I specifically restricted it in such way it never generates additional ops.

Tue, Jul 13, 6:29 AM · Restricted Project
Hardcode84 added a comment to D105886: [mlir][memref] Propagate LoadOp/StoreOp to SubViewOp source where possible.

And what exactly wrong with making them canonicalizations?

Tue, Jul 13, 5:50 AM · Restricted Project
Hardcode84 added reviewers for D105886: [mlir][memref] Propagate LoadOp/StoreOp to SubViewOp source where possible: nicolasvasilache, pifon2a.
Tue, Jul 13, 4:11 AM · Restricted Project
Hardcode84 requested review of D105886: [mlir][memref] Propagate LoadOp/StoreOp to SubViewOp source where possible.
Tue, Jul 13, 4:08 AM · Restricted Project

Wed, Jul 7

Hardcode84 accepted D105558: [mlir][MemRef] Fix DimOp folding of OffsetSizeAndStrideInterface..

see comment

Wed, Jul 7, 5:00 PM · Restricted Project
Hardcode84 added a comment to D105558: [mlir][MemRef] Fix DimOp folding of OffsetSizeAndStrideInterface..

I am not sure this is a good solution. Requiring from OffsetSizeAndStrideOpInterface users to to do such index manipulation is very inconvenient and error-prone. Maybe better to separate isDynamicDim APIs into 2 sets isInputDynamicDim/isOutputDynamicDim which can do index translation under the hood?

Wed, Jul 7, 9:44 AM · Restricted Project

Tue, Jul 6

Hardcode84 added a reviewer for D105496: [mlir] ConversionTarget legality callbacks refactoring: rriddle.
Tue, Jul 6, 9:28 AM · Restricted Project
Hardcode84 requested review of D105496: [mlir] ConversionTarget legality callbacks refactoring.
Tue, Jul 6, 9:27 AM · Restricted Project

Jun 29 2021

Hardcode84 committed rG293064222a01: [mlir] Add MemoryEffects::Allocate to memref::CloneOp (authored by Hardcode84).
[mlir] Add MemoryEffects::Allocate to memref::CloneOp
Jun 29 2021, 3:40 AM
Hardcode84 closed D104973: [mlir] Add MemoryEffects::Allocate to memref::CloneOp.
Jun 29 2021, 3:40 AM · Restricted Project

Jun 26 2021

Hardcode84 added reviewers for D104973: [mlir] Add MemoryEffects::Allocate to memref::CloneOp: silvas, dfki-jugr, pifon2a.
Jun 26 2021, 3:10 AM · Restricted Project
Hardcode84 requested review of D104973: [mlir] Add MemoryEffects::Allocate to memref::CloneOp.
Jun 26 2021, 3:09 AM · Restricted Project

Jun 22 2021

Hardcode84 committed rG82c1fb575034: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst. (authored by Hardcode84).
[mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst.
Jun 22 2021, 6:01 AM
Hardcode84 closed D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..
Jun 22 2021, 6:01 AM · Restricted Project
Hardcode84 updated the diff for D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

rebase, move some tests from transforms/canonicalize, renames operand -> dynamicSize

Jun 22 2021, 2:59 AM · Restricted Project

Jun 18 2021

Hardcode84 added a comment to D104289: Implement an scf.for range folding optimization pass..

Is there any reason to make this separate pass instead of ForOp canonicalization? Also, diff looks incomplete

Jun 18 2021, 8:19 AM · Restricted Project
Hardcode84 added a comment to D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

someone?

Jun 18 2021, 6:34 AM · Restricted Project

Jun 15 2021

Hardcode84 added a comment to D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

Not sure who is the right person to review this

Jun 15 2021, 5:17 PM · Restricted Project
Hardcode84 added a reviewer for D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst.: mehdi_amini.
Jun 15 2021, 5:16 PM · Restricted Project
Hardcode84 updated the diff for D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

Do not use getOperand

Jun 15 2021, 5:14 PM · Restricted Project

Jun 14 2021

Hardcode84 updated the diff for D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

newline

Jun 14 2021, 12:47 PM · Restricted Project
Hardcode84 requested review of D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..
Jun 14 2021, 12:44 PM · Restricted Project

May 30 2021

Hardcode84 committed rGbb542f2a76d4: [mlir] StandardToLLVM: option to disable AllocOp lowering (authored by Hardcode84).
[mlir] StandardToLLVM: option to disable AllocOp lowering
May 30 2021, 7:58 AM
Hardcode84 closed D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.
May 30 2021, 7:58 AM · Restricted Project
Hardcode84 updated the diff for D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.

rebase, rerun tests

May 30 2021, 6:58 AM · Restricted Project

May 27 2021

Hardcode84 updated the diff for D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.

review comments

May 27 2021, 8:35 AM · Restricted Project
Hardcode84 requested review of D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.
May 27 2021, 3:52 AM · Restricted Project

May 26 2021

Hardcode84 committed rG91e0cb6598f4: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot… (authored by Hardcode84).
[mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot…
May 26 2021, 2:07 AM
Hardcode84 closed D102557: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot determine better.
May 26 2021, 2:07 AM · Restricted Project

May 22 2021

Hardcode84 committed rG0dd36f81b9f8: [mlir][linalg][nfc] Fix signed/unsigned comparison warning in header (authored by Hardcode84).
[mlir][linalg][nfc] Fix signed/unsigned comparison warning in header
May 22 2021, 7:24 AM
Hardcode84 closed D102968: [mlir][linalg][nfc] Fix signed/unsigned comparison warning in header.
May 22 2021, 7:24 AM · Restricted Project
Hardcode84 requested review of D102968: [mlir][linalg][nfc] Fix signed/unsigned comparison warning in header.
May 22 2021, 5:11 AM · Restricted Project
Hardcode84 committed rG4184018253e7: [mlir][SCF] Canonicalize nested ParallelOp's (authored by Hardcode84).
[mlir][SCF] Canonicalize nested ParallelOp's
May 22 2021, 4:01 AM
Hardcode84 closed D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 22 2021, 4:00 AM · Restricted Project
Hardcode84 committed rG9afbca746b6c: [mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public (authored by Hardcode84).
[mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public
May 22 2021, 2:58 AM
Hardcode84 closed D102932: [mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public.
May 22 2021, 2:58 AM · Restricted Project

May 21 2021

Hardcode84 requested review of D102932: [mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public.
May 21 2021, 9:25 AM · Restricted Project

May 20 2021

Hardcode84 updated the diff for D102799: [mlir][SCF] Canonicalize nested ParallelOps's.

check outer iter vars not used as bounds/steps for inner loop

May 20 2021, 11:26 AM · Restricted Project
Hardcode84 added a comment to D102799: [mlir][SCF] Canonicalize nested ParallelOps's.

Anyway, there is another issue, I should also add check that outer block iter vars not being used as inner loop bounds/steps

May 20 2021, 8:49 AM · Restricted Project
Hardcode84 added inline comments to D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 20 2021, 8:45 AM · Restricted Project
Hardcode84 added inline comments to D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 20 2021, 8:35 AM · Restricted Project

May 19 2021

Hardcode84 requested review of D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 19 2021, 12:10 PM · Restricted Project

May 15 2021

Hardcode84 added a reviewer for D102557: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot determine better: rriddle.
May 15 2021, 10:41 AM · Restricted Project
Hardcode84 requested review of D102557: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot determine better.
May 15 2021, 10:40 AM · Restricted Project

May 8 2021

Hardcode84 committed rGe2a77644817f: [mlir] Debug print pattern before and after matchAndRewrite call (authored by Hardcode84).
[mlir] Debug print pattern before and after matchAndRewrite call
May 8 2021, 3:14 AM
Hardcode84 closed D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
May 8 2021, 3:13 AM · Restricted Project

May 7 2021

Hardcode84 updated the diff for D101443: [mlir] Debug print pattern before and after matchAndRewrite call.

review comments

May 7 2021, 3:13 AM · Restricted Project

May 6 2021

Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
May 6 2021, 11:32 AM · Restricted Project
Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
May 6 2021, 4:09 AM · Restricted Project
Hardcode84 updated the diff for D101443: [mlir] Debug print pattern before and after matchAndRewrite call.

Renamed to setDebugName, moved to public, FnPattern handling

May 6 2021, 4:08 AM · Restricted Project

Apr 29 2021

Hardcode84 added a comment to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.

Actually, maybe just rename those methods to get/setDebugName() or setPrettyName(), make them public and say explicitly in doc that it should be used only for debugging purposes? So 'proper' pattern name or tags can be added later separately if needed.

Apr 29 2021, 2:41 PM · Restricted Project

Apr 28 2021

Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
Apr 28 2021, 11:01 AM · Restricted Project
Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
Apr 28 2021, 10:31 AM · Restricted Project
Hardcode84 requested review of D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
Apr 28 2021, 5:06 AM · Restricted Project

Apr 26 2021

Hardcode84 updated the diff for D101253: Intel SVML calling conventions.

clang-format

Apr 26 2021, 4:47 AM · Restricted Project

Apr 25 2021

Hardcode84 requested review of D101253: Intel SVML calling conventions.
Apr 25 2021, 6:53 AM · Restricted Project

Apr 23 2021

Hardcode84 committed rGf22d3813850f: [mlir] Canonicalize AllocOp's with only store and dealloc uses (authored by Hardcode84).
[mlir] Canonicalize AllocOp's with only store and dealloc uses
Apr 23 2021, 11:55 PM
Hardcode84 closed D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.
Apr 23 2021, 11:55 PM · Restricted Project
Hardcode84 updated the diff for D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

rebase, rewiew comments

Apr 23 2021, 3:49 PM · Restricted Project
Hardcode84 abandoned D101040: [mlir] Template helper for analyses with dependencies.
Apr 23 2021, 11:36 AM · Restricted Project
Hardcode84 added a comment to D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

ping

Apr 23 2021, 2:31 AM · Restricted Project

Apr 22 2021

Hardcode84 updated the diff for D101040: [mlir] Template helper for analyses with dependencies.

FIx copypaste in license header

Apr 22 2021, 3:01 AM · Restricted Project
Hardcode84 requested review of D101040: [mlir] Template helper for analyses with dependencies.
Apr 22 2021, 2:54 AM · Restricted Project

Apr 21 2021

Hardcode84 committed rG85740ee108f1: [mlir] Assume terminators in nested regions are always legal in… (authored by Hardcode84).
[mlir] Assume terminators in nested regions are always legal in…
Apr 21 2021, 1:56 AM
Hardcode84 closed D100832: [mlir] Assume terminators in nested regions are always legal in FuncBufferizePass.
Apr 21 2021, 1:56 AM · Restricted Project

Apr 20 2021

Hardcode84 committed rGcd94f18ec1ba: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can… (authored by Hardcode84).
[mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can…
Apr 20 2021, 9:19 AM
Hardcode84 closed D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.
Apr 20 2021, 9:19 AM · Restricted Project
Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

update docs

Apr 20 2021, 4:37 AM · Restricted Project
Hardcode84 added a reviewer for D100832: [mlir] Assume terminators in nested regions are always legal in FuncBufferizePass: silvas.
Apr 20 2021, 2:29 AM · Restricted Project
Hardcode84 requested review of D100832: [mlir] Assume terminators in nested regions are always legal in FuncBufferizePass.
Apr 20 2021, 2:27 AM · Restricted Project

Apr 16 2021

Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

fix code in docs

Apr 16 2021, 12:42 PM · Restricted Project
Hardcode84 updated the summary of D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.
Apr 16 2021, 12:40 PM · Restricted Project
Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

review comments, docs

Apr 16 2021, 12:39 PM · Restricted Project
Hardcode84 added a comment to D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

https://mlir.llvm.org/docs/PassManagement/#analysis-management
Docs probably also need to be updated and I will need some help with that. Should it go to separate review?

Apr 16 2021, 10:52 AM · Restricted Project
Hardcode84 added a comment to D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

@bondhugula ping

Apr 16 2021, 3:18 AM · Restricted Project

Apr 14 2021

Hardcode84 added inline comments to D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.
Apr 14 2021, 3:51 PM · Restricted Project
Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

MapVector, comments

Apr 14 2021, 3:47 PM · Restricted Project