Page MenuHomePhabricator
Feed Advanced Search

Feb 4 2019

Kader added a comment to D57537: Adjust cardinality of internal inliner thresholds.

@twoh Can you push this for me ? I don't have commit access yet.

Feb 4 2019, 9:27 AM · Restricted Project
Kader updated the summary of D57537: Adjust cardinality of internal inliner thresholds.
Feb 4 2019, 8:23 AM · Restricted Project

Jan 31 2019

Kader added reviewers for D57537: Adjust cardinality of internal inliner thresholds: david2050, twoh, modocache.
Jan 31 2019, 12:41 PM · Restricted Project
Kader updated the summary of D57537: Adjust cardinality of internal inliner thresholds.
Jan 31 2019, 12:40 PM · Restricted Project
Kader created D57537: Adjust cardinality of internal inliner thresholds.
Jan 31 2019, 12:35 PM · Restricted Project

Jan 14 2019

Kader added a comment to D56241: [Sema] expose a control flag for integer to pointer ext warning.

friendly ping

Jan 14 2019, 9:19 AM · Restricted Project
Kader accepted D56505: expand DIContext interface a bit.

LGTM

Jan 14 2019, 9:18 AM

Jan 9 2019

Kader added a comment to D56505: expand DIContext interface a bit.

LGTM :)

Jan 9 2019, 11:19 AM

Jan 4 2019

Kader added a comment to D56241: [Sema] expose a control flag for integer to pointer ext warning.

@lebedev.ri Thanks.
I think do not have commit access. What should be my next step ?

Jan 4 2019, 3:48 AM · Restricted Project

Jan 3 2019

Kader added inline comments to D56241: [Sema] expose a control flag for integer to pointer ext warning.
Jan 3 2019, 8:10 PM · Restricted Project
Kader updated the diff for D56241: [Sema] expose a control flag for integer to pointer ext warning.

remove typo

Jan 3 2019, 2:35 PM · Restricted Project
Kader updated the diff for D56241: [Sema] expose a control flag for integer to pointer ext warning.

address comments

Jan 3 2019, 2:33 PM · Restricted Project
Kader updated the diff for D56241: [Sema] expose a control flag for integer to pointer ext warning.

added missing test file

Jan 3 2019, 12:37 PM · Restricted Project
Kader added a comment to D56241: [Sema] expose a control flag for integer to pointer ext warning.

@lebedev.ri Thanks for the quick review ;

Perhaps there should be a test for this flag specifically?

I am not really familiar with this part of the code base, but it seems that the warnings is already tested in both test/Sema/Compare.c and test/SemaCXX/compare.cpp. I have none the less added a new test file for c_lang.

Jan 3 2019, 12:35 PM · Restricted Project
Kader updated the diff for D56241: [Sema] expose a control flag for integer to pointer ext warning.

Added test case for C_lang

Jan 3 2019, 12:31 PM · Restricted Project

Jan 2 2019

Kader updated the summary of D56241: [Sema] expose a control flag for integer to pointer ext warning.
Jan 2 2019, 8:19 PM · Restricted Project
Kader created D56241: [Sema] expose a control flag for integer to pointer ext warning.
Jan 2 2019, 8:15 PM · Restricted Project