Tue, Aug 20
Mon, Aug 19
Following Mitch's suggestion, modify the test to use a
PageSize - BlockDelta sized chunk, that in all likelihood will be
backed by a page-aligned block (dependent on the SizeClassMap but
works with our default).
Is this good from the reviewers perspective?
Wed, Aug 14
- Additional comments to the test function
- Moving the initialization of the static variables within the test function
Update the test.
Mon, Aug 12
We might have to discuss this.
I either compile Android binaries by compiling it with the Scudo sources, or I compile the platform with Scudo replacing jemalloc in Android.
Both work with -D_BIONIC=1 for the Bionic version, which can probably be replaced by BIONIC.
So I am not sure why compiling it on Android but not part of Bionic didn't work for you, I can give you the compilation command lines I used tomorrow.
Adding usmblks as well.
Android uses it for getNativeHeapSize, so StatMapped will do.
Fri, Aug 2
Wed, Jul 24
Jul 15 2019
BM_youtube/min_time:15.000/repeats:4/manual_time_mean 410274 us 615999 us 4 BM_youtube/min_time:15.000/repeats:4/manual_time_median 410246 us 616125 us 4 BM_youtube/min_time:15.000/repeats:4/manual_time_stddev 302 us 587 us 4
Jul 12 2019
Jul 11 2019
Jul 10 2019
It's OK with me. Part of the reason for splitting out the symbolizer was some memory overhead as well, which we probably want to look into.
Is COMPILER_RT_HAS_GWP_ASAN going to be true by default for Android? If so we probably should loop in the toolchain team so that there is no surprise on their next toolchain update.
Jul 9 2019
Addressing review comments:
- commenting the use of the #pragma nounroll
- using the platform specific types in mutex.h
Move the mutex state enum into linux.cc since it's only used there.
Jul 8 2019
- Adding constexpr for the number of yields & trys in the mutex class;
- Adding a test to ensure that scudo::getPageSizeCached is consitent with getpagesize;
Jul 3 2019
Jul 2 2019
Regarding Teresa's issue, it seems to boil down to the version of clang, and not inlining the __atomic_load_8 & co.
Looking at godbolt, it doesn't seem to happen until clang 6, while gcc did it since a while.
After attempting to conditionally add -latomic, and failing, I am resorting to adding -latomic unconditionally to the tests link flags, unless someone has a better idea.
Tentative fix for this is in https://reviews.llvm.org/D64086, if you could please let me know if that works for you.
Jun 27 2019
Jun 26 2019
Thank you Douglas!
Jun 25 2019
Remove unchanged files from CL.
Adding a testcase for a Class to the New tests.
Jun 24 2019
Changing some errno behaviors to be more consistent.
Renaming wrappers.inc to wrappers_c.inc and updated associated strings.
Jun 21 2019
Fixing a couple of errors that came up in testing.
Jun 20 2019
Jun 18 2019
Jun 17 2019
Removing a reinterpret_cast<void *>.
Jun 14 2019
Addressing review comments:
- renaming allocator.h to allocator_config.h
- adding FuchsiaConfig to the battery of tests (64-bit only)
Jun 13 2019
Tune some tests & Quarantine parameters.
Enabled the Quarantine for some tests, which wasn't used before.
Jun 12 2019
Jun 11 2019
Update the deleters to actually delete the pointer itself as well.
Jun 10 2019
Jun 7 2019
Always call initOnce, and rename it initOnceMaybe to reflect that
initialization might not necessarily occur if it already happened.
clang-format'ing the code.
Use an atomic_u8 for Initialized instead of a bool.
As discussed through comments, re-introduce a StaticSpinMutex to the
"once" initialization of the TSD registry, and remove its no-op
initLinkerInitialized in the various places it was used.
Also adds a test to exercise the path of "direct" initialization
via calling initLinkerInitialized directly on the registry.