Page MenuHomePhabricator
Feed Advanced Search

Today

cryptoad created D63435: [scudo][standalone] Fuchsia related changes.
Mon, Jun 17, 8:42 AM · Restricted Project, Restricted Project
cryptoad committed rGe4eadf174cb1: [scudo][standalone] Introduce the combined allocator (authored by cryptoad).
[scudo][standalone] Introduce the combined allocator
Mon, Jun 17, 8:21 AM
cryptoad committed rL363569: [scudo][standalone] Introduce the combined allocator.
[scudo][standalone] Introduce the combined allocator
Mon, Jun 17, 8:20 AM
cryptoad closed D63231: [scudo][standalone] Introduce the combined allocator.
Mon, Jun 17, 8:20 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Removing a reinterpret_cast<void *>.

Mon, Jun 17, 8:20 AM · Restricted Project, Restricted Project

Fri, Jun 14

cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Addressing review comments:

  • renaming allocator.h to allocator_config.h
  • adding FuchsiaConfig to the battery of tests (64-bit only)
Fri, Jun 14, 3:37 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D63231: [scudo][standalone] Introduce the combined allocator.
Fri, Jun 14, 3:33 PM · Restricted Project, Restricted Project

Thu, Jun 13

cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Tune some tests & Quarantine parameters.

Thu, Jun 13, 10:01 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Enabled the Quarantine for some tests, which wasn't used before.

Thu, Jun 13, 9:44 AM · Restricted Project, Restricted Project

Wed, Jun 12

cryptoad created D63231: [scudo][standalone] Introduce the combined allocator.
Wed, Jun 12, 3:30 PM · Restricted Project, Restricted Project

Tue, Jun 11

cryptoad committed rG624a24e15633: [scudo][standalone] Unmap memory in tests (authored by cryptoad).
[scudo][standalone] Unmap memory in tests
Tue, Jun 11, 12:48 PM
cryptoad committed rL363095: [scudo][standalone] Unmap memory in tests.
[scudo][standalone] Unmap memory in tests
Tue, Jun 11, 12:47 PM
cryptoad closed D63146: [scudo][standalone] Unmap memory in tests.
Tue, Jun 11, 12:47 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D63146: [scudo][standalone] Unmap memory in tests.

Update the deleters to actually delete the pointer itself as well.

Tue, Jun 11, 10:35 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D63146: [scudo][standalone] Unmap memory in tests.
Tue, Jun 11, 10:32 AM · Restricted Project, Restricted Project
cryptoad created D63146: [scudo][standalone] Unmap memory in tests.
Tue, Jun 11, 9:33 AM · Restricted Project, Restricted Project

Mon, Jun 10

cryptoad committed rG52bfd673d155: [scudo][standalone] Introduce the thread specific data structures (authored by cryptoad).
[scudo][standalone] Introduce the thread specific data structures
Mon, Jun 10, 9:49 AM
cryptoad committed rL362962: [scudo][standalone] Introduce the thread specific data structures.
[scudo][standalone] Introduce the thread specific data structures
Mon, Jun 10, 9:48 AM
cryptoad closed D62258: [scudo][standalone] Introduce the thread specific data structures.
Mon, Jun 10, 9:48 AM · Restricted Project, Restricted Project

Fri, Jun 7

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Always call initOnce, and rename it initOnceMaybe to reflect that
initialization might not necessarily occur if it already happened.

Fri, Jun 7, 2:01 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

clang-format'ing the code.

Fri, Jun 7, 1:24 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Use an atomic_u8 for Initialized instead of a bool.

Fri, Jun 7, 1:20 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Fri, Jun 7, 1:17 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

As discussed through comments, re-introduce a StaticSpinMutex to the
"once" initialization of the TSD registry, and remove its no-op
initLinkerInitialized in the various places it was used.
Also adds a test to exercise the path of "direct" initialization
via calling initLinkerInitialized directly on the registry.

Fri, Jun 7, 9:16 AM · Restricted Project, Restricted Project

Thu, Jun 6

cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Thu, Jun 6, 5:02 PM · Restricted Project, Restricted Project
cryptoad accepted D62929: [GWP-ASan] Integration with Scudo [5]..
Thu, Jun 6, 2:08 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Thu, Jun 6, 1:20 PM · Restricted Project, Restricted Project
cryptoad added a comment to D62258: [scudo][standalone] Introduce the thread specific data structures.

Ping pretty please! I think all the comments were addressed one way or another. The new structure doesn't "cycle" anymore.

Thu, Jun 6, 8:00 AM · Restricted Project, Restricted Project

Wed, Jun 5

cryptoad added a comment to D62929: [GWP-ASan] Integration with Scudo [5]..

I think it's good from the integration perspective.
The only potential concern I have is the specific use of the TLS variables in GWP-ASan which might not work everywhere here (eg: if a platform is using emutls as TLS as it uses malloc() internally).
Have you tested that locally with an Android emulator?

Wed, Jun 5, 2:09 PM · Restricted Project, Restricted Project

Mon, Jun 3

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Disable a test on 32-bit for now: we are running out of address space.
This will be fixed in a subsequent CL, but affects the tests of this one.

Mon, Jun 3, 10:32 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Change the Primary test again to be more forgiving to OOM.

Mon, Jun 3, 10:13 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Add a comment for MinimalInit.

Mon, Jun 3, 9:59 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

This, hopefully, detangles a bit the initialization process for
the registry. In order to do that, we get rid of the mutex in favor
of our own call_once type construct (losely inspired by
llvm::call_once). We move the initialization code into
initLinkerInitialized.

Mon, Jun 3, 9:47 AM · Restricted Project, Restricted Project

Wed, May 29

cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Wed, May 29, 3:13 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Wed, May 29, 11:52 AM · Restricted Project, Restricted Project

Fri, May 24

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Switching from a spin mutex to a blocking mutex for initOnce.

Fri, May 24, 2:07 PM · Restricted Project, Restricted Project
cryptoad added a comment to D62368: Add support for Hygon Dhyana processor.

Regarding the Scudo side of the patch: the code has to be able to compile with gcc as well, and not necessarily the latest version.
This won't compile on systems without a signature_HYGON_*.

Fri, May 24, 10:00 AM · Restricted Project, Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Addressing several of Matt's review points:

  • adding comments to obscure code snippets
  • calling initLinkerInitialized when needed
  • changing unique_ptr's get()-> to ->
  • simplifying some code constructs
Fri, May 24, 8:51 AM · Restricted Project, Restricted Project
cryptoad added a comment to D62258: [scudo][standalone] Introduce the thread specific data structures.

Matt, thank you for all the reviews you are doing. Very insightful points.

Fri, May 24, 8:50 AM · Restricted Project, Restricted Project

Wed, May 22

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Correct a test and some formatting.

Wed, May 22, 9:55 AM · Restricted Project, Restricted Project
cryptoad created D62258: [scudo][standalone] Introduce the thread specific data structures.
Wed, May 22, 8:19 AM · Restricted Project, Restricted Project

Mon, May 20

cryptoad committed rG52f013021673: [scudo][standalone] Introduce the Primary(s) and LocalCache (authored by cryptoad).
[scudo][standalone] Introduce the Primary(s) and LocalCache
Mon, May 20, 7:42 AM
cryptoad committed rL361159: [scudo][standalone] Introduce the Primary(s) and LocalCache.
[scudo][standalone] Introduce the Primary(s) and LocalCache
Mon, May 20, 7:37 AM
cryptoad committed rCRT361159: [scudo][standalone] Introduce the Primary(s) and LocalCache.
[scudo][standalone] Introduce the Primary(s) and LocalCache
Mon, May 20, 7:37 AM
cryptoad closed D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
Mon, May 20, 7:37 AM · Restricted Project, Restricted Project

May 17 2019

cryptoad updated the diff for D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

Correcting a typo (meaningul -> meaningful)

May 17 2019, 12:33 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

Adding a forgotten CHECK as well.

May 17 2019, 12:09 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

Correcting some code constructs as suggested by Matt:

  • using unique_ptr in tests;
  • accounting for a potential null TransferBatch in refill;
  • other corrections.
May 17 2019, 11:56 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 17 2019, 10:37 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 17 2019, 10:34 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 17 2019, 10:29 AM · Restricted Project, Restricted Project

May 16 2019

cryptoad updated the diff for D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

Simplify a lot of the functions prototypes by storing a pointer to the
size-class allocator in the cache, or getting the stats from the cache,
etc.

May 16 2019, 8:10 AM · Restricted Project, Restricted Project

May 15 2019

cryptoad closed D51146: [scudo] Update documentation with Scudo's "permissive" mode..
May 15 2019, 7:43 AM · Restricted Project
cryptoad added a comment to D61923: [GWP-ASan] Mutex implementation [2]..

I think the idea is that implementing our own spinlock is not much harder than having 3 platform-specific implementations (posix, window, fuchsia).
Also, scudo_standalone is doing the same ( @cryptoad, why? ).

As Mitch mentioned, we should move the implementation into a common directory. Why not do this now?

May 15 2019, 7:26 AM · Restricted Project, Restricted Project, Restricted Project

May 14 2019

cryptoad added inline comments to D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 14 2019, 2:08 PM · Restricted Project, Restricted Project
cryptoad added a comment to D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

This could use a review please!

May 14 2019, 9:35 AM · Restricted Project, Restricted Project

May 9 2019

cryptoad created D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 9 2019, 11:15 AM · Restricted Project, Restricted Project

May 8 2019

cryptoad committed rG6a85631d8713: [scudo][standalone] Introduce the chunk header (authored by cryptoad).
[scudo][standalone] Introduce the chunk header
May 8 2019, 2:54 PM
cryptoad committed rL360290: [scudo][standalone] Introduce the chunk header.
[scudo][standalone] Introduce the chunk header
May 8 2019, 2:54 PM
cryptoad committed rCRT360290: [scudo][standalone] Introduce the chunk header.
[scudo][standalone] Introduce the chunk header
May 8 2019, 2:54 PM
cryptoad closed D61654: [scudo][standalone] Introduce the chunk header.
May 8 2019, 2:54 PM · Restricted Project, Restricted Project
cryptoad requested review of D61654: [scudo][standalone] Introduce the chunk header.
May 8 2019, 9:41 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D61654: [scudo][standalone] Introduce the chunk header.

I had to backpedal on some of changes due to some errors uncovered
while testing on Fuchsia.

May 8 2019, 9:37 AM · Restricted Project, Restricted Project
cryptoad planned changes to D61654: [scudo][standalone] Introduce the chunk header.

Working out some kinks on Fuchsia. Will update once it's ironed out.

May 8 2019, 8:52 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D61654: [scudo][standalone] Introduce the chunk header.

Actually remove 2 unused masks.

May 8 2019, 8:09 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D61654: [scudo][standalone] Introduce the chunk header.

Rename AllocTypeMask to OriginMask.

May 8 2019, 7:58 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D61654: [scudo][standalone] Introduce the chunk header.

The HashAlgorithm global variable doesn't have to be atomic since
all alloc operations are stalled until init completes. Update things
accordingly (thanks Vitaly).

May 8 2019, 7:42 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D61654: [scudo][standalone] Introduce the chunk header.
May 8 2019, 7:41 AM · Restricted Project, Restricted Project

May 7 2019

cryptoad added inline comments to D61654: [scudo][standalone] Introduce the chunk header.
May 7 2019, 3:48 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D61654: [scudo][standalone] Introduce the chunk header.

Updated to use class enums, and put some structures that uses to
be in the scudo namespace into the scudo::Chunk one, as it
makes more sense.

May 7 2019, 3:41 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D61654: [scudo][standalone] Introduce the chunk header.
May 7 2019, 3:05 PM · Restricted Project, Restricted Project
cryptoad created D61654: [scudo][standalone] Introduce the chunk header.
May 7 2019, 1:54 PM · Restricted Project, Restricted Project
cryptoad committed rGab8c8da60928: [scudo][standalone] Introduce the Quarantine (authored by cryptoad).
[scudo][standalone] Introduce the Quarantine
May 7 2019, 8:40 AM
cryptoad committed rCRT360163: [scudo][standalone] Introduce the Quarantine.
[scudo][standalone] Introduce the Quarantine
May 7 2019, 8:40 AM
cryptoad committed rL360163: [scudo][standalone] Introduce the Quarantine.
[scudo][standalone] Introduce the Quarantine
May 7 2019, 8:40 AM
cryptoad closed D61385: [scudo][standalone] Introduce the Quarantine.
May 7 2019, 8:40 AM · Restricted Project, Restricted Project

May 6 2019

cryptoad updated the diff for D61385: [scudo][standalone] Introduce the Quarantine.

Addressing Matt's new comments:

  • changing another %d to %zd
  • changing the iterating loop to a range loop
  • clang-format'ing the source
May 6 2019, 12:15 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D61385: [scudo][standalone] Introduce the Quarantine.
May 6 2019, 12:14 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D61385: [scudo][standalone] Introduce the Quarantine.

Addressing Matt's comments:

  • changing some initializers to initLinkerInitialized. This also required implementing a no-op version of this function for StaticSpinMutex
  • changed a %d to %zd
May 6 2019, 11:47 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D61385: [scudo][standalone] Introduce the Quarantine.
May 6 2019, 11:44 AM · Restricted Project, Restricted Project

May 2 2019

cryptoad accepted D61450: [compiler-rt] Set the ZX_VMO_RESIZABLE option for zx_vmo_create.
May 2 2019, 10:11 AM · Restricted Project, Restricted Project

May 1 2019

cryptoad created D61385: [scudo][standalone] Introduce the Quarantine.
May 1 2019, 9:17 AM · Restricted Project, Restricted Project

Apr 30 2019

cryptoad committed rG21c31f5e7b30: [scudo][standalone] Add the memory reclaiming mechanism (authored by cryptoad).
[scudo][standalone] Add the memory reclaiming mechanism
Apr 30 2019, 7:58 AM
cryptoad committed rCRT359567: [scudo][standalone] Add the memory reclaiming mechanism.
[scudo][standalone] Add the memory reclaiming mechanism
Apr 30 2019, 7:54 AM
cryptoad committed rL359567: [scudo][standalone] Add the memory reclaiming mechanism.
[scudo][standalone] Add the memory reclaiming mechanism
Apr 30 2019, 7:54 AM
cryptoad closed D61214: [scudo][standalone] Add the memory reclaiming mechanism.
Apr 30 2019, 7:54 AM · Restricted Project, Restricted Project

Apr 29 2019

cryptoad added inline comments to D61214: [scudo][standalone] Add the memory reclaiming mechanism.
Apr 29 2019, 1:14 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D61214: [scudo][standalone] Add the memory reclaiming mechanism.

Addressing Vitaly's comments.

Apr 29 2019, 1:14 PM · Restricted Project, Restricted Project
cryptoad accepted D61162: [scudo][NFC] Remove unneeded template from scudo::CombinedAllocator.
Apr 29 2019, 8:39 AM · Restricted Project, Restricted Project

Apr 26 2019

cryptoad updated the diff for D61214: [scudo][standalone] Add the memory reclaiming mechanism.

Correct typo.

Apr 26 2019, 3:15 PM · Restricted Project, Restricted Project
cryptoad created D61214: [scudo][standalone] Add the memory reclaiming mechanism.
Apr 26 2019, 3:14 PM · Restricted Project, Restricted Project

Apr 25 2019

cryptoad committed rG3fad6a206f52: [scudo][standalone] Introduce the SizeClassMap (authored by cryptoad).
[scudo][standalone] Introduce the SizeClassMap
Apr 25 2019, 8:51 AM
cryptoad committed rL359199: [scudo][standalone] Introduce the SizeClassMap.
[scudo][standalone] Introduce the SizeClassMap
Apr 25 2019, 8:47 AM
cryptoad committed rCRT359199: [scudo][standalone] Introduce the SizeClassMap.
[scudo][standalone] Introduce the SizeClassMap
Apr 25 2019, 8:47 AM
cryptoad closed D61088: [scudo][standalone] Introduce the SizeClassMap.
Apr 25 2019, 8:47 AM · Restricted Project, Restricted Project

Apr 24 2019

cryptoad updated the diff for D61088: [scudo][standalone] Introduce the SizeClassMap.

Correct comment & a format string.

Apr 24 2019, 2:47 PM · Restricted Project, Restricted Project
cryptoad created D61088: [scudo][standalone] Introduce the SizeClassMap.
Apr 24 2019, 1:18 PM · Restricted Project, Restricted Project
cryptoad committed rG475585655db8: [scudo][standalone] Introduce the Secondary allocator (authored by cryptoad).
[scudo][standalone] Introduce the Secondary allocator
Apr 24 2019, 7:19 AM
cryptoad committed rL359097: [scudo][standalone] Introduce the Secondary allocator.
[scudo][standalone] Introduce the Secondary allocator
Apr 24 2019, 7:19 AM
cryptoad committed rCRT359097: [scudo][standalone] Introduce the Secondary allocator.
[scudo][standalone] Introduce the Secondary allocator
Apr 24 2019, 7:19 AM