Page MenuHomePhabricator
Feed Advanced Search

Today

martong updated the diff for D44100: [ASTImporter] Reorder fields after structure import is finished.
  • Further simplify by removing the last for loop
Fri, Jul 19, 10:43 AM · Restricted Project
martong updated the diff for D44100: [ASTImporter] Reorder fields after structure import is finished.
  • Rebase to master
  • Some refactor is done mostly because since D63603 ([ASTImporter] Propagate

error from ImportDeclContext) we may not imported successfully all decls of a
DC.

  • Made the code simpler and shorter by adding a local vector to hold the decls

of the "from" DC in the original order.

Fri, Jul 19, 6:17 AM · Restricted Project

Yesterday

martong added a comment to D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations.

Hi Gabor,
This looks fine, but could you please add a test showing how decl shadowing is handled? I.e. if we have Arg in one TU and both Arg and N::Arg in another TU.

Thu, Jul 18, 8:25 AM · Restricted Project
martong updated the diff for D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations.
  • Add test case ClassTemplSpecWithInequivalentShadowedTemplArg
Thu, Jul 18, 8:25 AM · Restricted Project
martong committed rG6d3bb71c8f80: [analyzer] Add CTU user docs (authored by martong).
[analyzer] Add CTU user docs
Thu, Jul 18, 7:05 AM
martong committed rL366439: [analyzer] Add CTU user docs.
[analyzer] Add CTU user docs
Thu, Jul 18, 7:04 AM
martong closed D64801: [analyzer] Add CTU user docs.
Thu, Jul 18, 7:04 AM · Restricted Project, Restricted Project
martong updated the diff for D64801: [analyzer] Add CTU user docs.
  • Add notes about macro expansion crash with CTU
Thu, Jul 18, 6:47 AM · Restricted Project, Restricted Project
martong accepted D64554: [CrossTU] Add a function to retrieve original source location..

LGTM.

Thu, Jul 18, 6:38 AM · Restricted Project, Restricted Project
martong added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Thu, Jul 18, 1:23 AM · Restricted Project, Restricted Project

Wed, Jul 17

martong added a comment to D64075: [ASTImporter] Fix structural eq of lambdas.

Jenkins looks okay: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31160/ .The build is red but the the previous run has the very same failing test case:
expression_command/weak_symbols/TestWeakSymbols.py

Wed, Jul 17, 9:23 AM · Restricted Project, Restricted Project
martong updated the diff for D64801: [analyzer] Add CTU user docs.
  • Address dkrupp's comments
Wed, Jul 17, 9:01 AM · Restricted Project, Restricted Project
martong committed rGae512b83d5fc: [ASTImporter] Fix structural eq of lambdas (authored by martong).
[ASTImporter] Fix structural eq of lambdas
Wed, Jul 17, 7:41 AM
martong committed rL366332: [ASTImporter] Fix structural eq of lambdas.
[ASTImporter] Fix structural eq of lambdas
Wed, Jul 17, 7:41 AM
martong closed D64075: [ASTImporter] Fix structural eq of lambdas.
Wed, Jul 17, 7:40 AM · Restricted Project, Restricted Project
martong added a comment to D64075: [ASTImporter] Fix structural eq of lambdas.

@shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ .

Wed, Jul 17, 7:35 AM · Restricted Project, Restricted Project
martong added a comment to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

Jenkins looks okay: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31157/ .The build is red but the the previous run has the very same failing test case:
expression_command/weak_symbols/TestWeakSymbols.py

Wed, Jul 17, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
martong committed rGaefcf5100aae: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src (authored by martong).
[ASTImporter] Fix LLDB lookup in transparent ctx and with ext src
Wed, Jul 17, 6:49 AM
martong committed rL366325: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
[ASTImporter] Fix LLDB lookup in transparent ctx and with ext src
Wed, Jul 17, 6:48 AM
martong closed D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
Wed, Jul 17, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
martong added a comment to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

Thank you guys for the review!

Wed, Jul 17, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
martong added inline comments to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
Wed, Jul 17, 3:05 AM · Restricted Project, Restricted Project, Restricted Project
martong updated the diff for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
  • Applied clang-format on lldb parts (this changed two lines)
  • Added a comment for predicate
  • Merged the test into TestCModules.py
Wed, Jul 17, 3:05 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 16

martong created D64801: [analyzer] Add CTU user docs.
Tue, Jul 16, 8:35 AM · Restricted Project, Restricted Project
martong added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Tue, Jul 16, 6:36 AM · Restricted Project, Restricted Project
martong added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Tue, Jul 16, 6:35 AM · Restricted Project, Restricted Project
martong added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Tue, Jul 16, 3:21 AM · Restricted Project, Restricted Project
martong added a comment to D64753: [CrossTU][NFCI] Refactor loadExternalAST function.

Thank you Endre, this patch is a great initiative.
However, I think we can do better encapsulation then just the reorganization of the functions:
We could encapsulate into a nested class NameASTUnitMap and the functions which operate on this (getCachedASTUnitForName,
loadFromASTFileCached).
We could do the same with NameFileMap, lazyInitCTUIndex, getASTFileNameForLookup.
And we could also encapsulate NumASTLoaded and its related function (checkThresholdReached). In this case perhaps we could use RAII to increase the counter.

Tue, Jul 16, 3:12 AM · Restricted Project
martong added inline comments to D64554: [CrossTU] Add a function to retrieve original source location..
Tue, Jul 16, 2:51 AM · Restricted Project, Restricted Project

Mon, Jul 15

martong added a comment to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

@martong Sorry for the delay, feel free to ping me in the future about these patches. I'll review them ASAP now that I'm back in office, so these delay's hopefully won't happen again.

I tried applying this patch and it seems it needs to be rebased. I would do it myself, but I'm not entirely sure how to rebase the changes to ASTNodeImporter::ImportDefinition. It seems we got rid of To->completeDefinition();, so not sure if the code that this patch adds is still in the right place.

Mon, Jul 15, 6:15 AM · Restricted Project, Restricted Project, Restricted Project
martong updated the diff for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
  • Rebase to master
Mon, Jul 15, 6:04 AM · Restricted Project, Restricted Project, Restricted Project
martong added a comment to D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..

Does it really matter if it is CXX11 or CXX14, in the child patch we use a CXX11 using directive. Anyway, CXX14 is more future proof.

Later there should follow the test with variable template that produces warnings again if not Lang_CXX14 is used.

Mon, Jul 15, 5:14 AM · Restricted Project, Restricted Project
martong accepted D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..

Does it really matter if it is CXX11 or CXX14, in the child patch we use a CXX11 using directive. Anyway, CXX14 is more future proof.

Mon, Jul 15, 3:01 AM · Restricted Project, Restricted Project
martong added a comment to D64628: [CrossTU] Test change only: improve ctu-main.c.

The mentioned commit has a test that reproduces the same problem, so this revision is not needed (abandon it?).

Mon, Jul 15, 2:56 AM · Restricted Project

Fri, Jul 12

martong accepted D64628: [CrossTU] Test change only: improve ctu-main.c.
Fri, Jul 12, 8:42 AM · Restricted Project
martong added a comment to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

@shafik @jingham This is a polite Ping.

Fri, Jul 12, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
martong added a comment to D64554: [CrossTU] Add a function to retrieve original source location..

This patch can be treated as part of a bigger change that is needed to improve macro expansion handliong at plist generation.

Fri, Jul 12, 2:15 AM · Restricted Project, Restricted Project
martong added a reviewer for D64554: [CrossTU] Add a function to retrieve original source location.: xazax.hun.
Fri, Jul 12, 2:12 AM · Restricted Project, Restricted Project
martong added a reviewer for D64554: [CrossTU] Add a function to retrieve original source location.: a_sidorin.
Fri, Jul 12, 1:49 AM · Restricted Project, Restricted Project

Wed, Jul 10

martong added a comment to D64494: [analyzer]Add user docs rst.

In any case, LGTM, if this really is a beginning of porting the already existing documentation to sphinx.

This is really the beginning of porting the existing docs to sphinx which is supposedly going to be done by @dkrupp. And I am planning to add new user manual documentation about CTU.

Wed, Jul 10, 12:23 PM · Restricted Project, Restricted Project
martong committed rGa23c5694fbb5: [analyzer]Add user docs rst (authored by martong).
[analyzer]Add user docs rst
Wed, Jul 10, 7:51 AM
martong committed rL365639: [analyzer]Add user docs rst.
[analyzer]Add user docs rst
Wed, Jul 10, 7:49 AM
martong closed D64494: [analyzer]Add user docs rst.
Wed, Jul 10, 7:49 AM · Restricted Project, Restricted Project
martong added a comment to D64494: [analyzer]Add user docs rst.

I guess this is a placeholder for the subpages of "User Manual" @ https://clang-analyzer.llvm.org, which will be ported in follow-up patches.

Wed, Jul 10, 7:46 AM · Restricted Project, Restricted Project
martong created D64494: [analyzer]Add user docs rst.
Wed, Jul 10, 7:27 AM · Restricted Project, Restricted Project
martong accepted D64477: [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..
Wed, Jul 10, 6:40 AM · Restricted Project, Restricted Project

Tue, Jul 9

martong added a comment to D64075: [ASTImporter] Fix structural eq of lambdas.

Hi Gabor,
The patch looks good, but it looks to me that it has a relation to https://reviews.llvm.org/D64078 that is kind of questionable to me. Let's delay landing this patch until the fix direction is clear.

Tue, Jul 9, 10:13 AM · Restricted Project, Restricted Project
martong updated the diff for D64075: [ASTImporter] Fix structural eq of lambdas.
  • Add test which crashes in baseline
Tue, Jul 9, 9:59 AM · Restricted Project, Restricted Project

Mon, Jul 8

martong committed rGe73805f80eab: [ASTImporter] Fix import of lambda in function param (authored by martong).
[ASTImporter] Fix import of lambda in function param
Mon, Jul 8, 5:50 AM
martong committed rL365315: [ASTImporter] Fix import of lambda in function param.
[ASTImporter] Fix import of lambda in function param
Mon, Jul 8, 5:49 AM
martong closed D64073: [ASTImporter] Fix import of lambda in function param.
Mon, Jul 8, 5:49 AM · Restricted Project, Restricted Project

Fri, Jul 5

martong added inline comments to D63640: [clang] Improve Serialization/Imporing of APValues.
Fri, Jul 5, 8:24 AM · Restricted Project
martong created D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations.
Fri, Jul 5, 4:11 AM · Restricted Project

Thu, Jul 4

martong committed rGe712295f11bb: [CTU] Add support for virtual functions (authored by martong).
[CTU] Add support for virtual functions
Thu, Jul 4, 4:40 AM
martong committed rL365133: [CTU] Add support for virtual functions.
[CTU] Add support for virtual functions
Thu, Jul 4, 4:39 AM
martong closed D63920: [CTU] Add support for virtual functions.
Thu, Jul 4, 4:38 AM · Restricted Project, Restricted Project
martong added a comment to D63920: [CTU] Add support for virtual functions.

Thanks for the review!

Thu, Jul 4, 2:57 AM · Restricted Project, Restricted Project
martong updated the diff for D63920: [CTU] Add support for virtual functions.
  • Remove ipa mode from the test
Thu, Jul 4, 2:52 AM · Restricted Project, Restricted Project
martong resigned from D62960: Add SVE opaque built-in types.
Thu, Jul 4, 2:36 AM · Restricted Project
martong added a comment to D62960: Add SVE opaque built-in types.

The ASTImporter and the test for it looks good to me, thanks!

Thu, Jul 4, 2:36 AM · Restricted Project
martong resigned from D52839: Inform AST's UnaryOperator of FENV_ACCESS.
Thu, Jul 4, 2:29 AM
martong added inline comments to D63640: [clang] Improve Serialization/Imporing of APValues.
Thu, Jul 4, 2:29 AM · Restricted Project

Wed, Jul 3

martong added inline comments to D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.
Wed, Jul 3, 7:39 AM · Restricted Project, Restricted Project
martong updated the diff for D64073: [ASTImporter] Fix import of lambda in function param.
  • 'the ' -> 'the '
  • Use std::distance()
Wed, Jul 3, 6:29 AM · Restricted Project, Restricted Project
martong added a comment to D64073: [ASTImporter] Fix import of lambda in function param.

Thanks for the review Alexei!

Wed, Jul 3, 6:29 AM · Restricted Project, Restricted Project
martong updated the diff for D64075: [ASTImporter] Fix structural eq of lambdas.
  • Add check for isLambda()
Wed, Jul 3, 6:18 AM · Restricted Project, Restricted Project
martong added inline comments to D64075: [ASTImporter] Fix structural eq of lambdas.
Wed, Jul 3, 6:18 AM · Restricted Project, Restricted Project
martong added a comment to D63920: [CTU] Add support for virtual functions.

Try to set analyzer option IPAMode to something different from its default value which is dynamic-bifurcate in the test file.

Ok I set it to ipa=inlining and then we receive the expected "UNKNOWN" warning.

Alright, what are testing here exactly? I think its fine to see how the new virtual functions are inlined in different inlining mode, but we should definitely have a RUN: line/test file with the default mode.

Wed, Jul 3, 5:52 AM · Restricted Project, Restricted Project
martong accepted D59798: [analyzer] Add analyzer option to limit the number of imported TUs.
Wed, Jul 3, 3:03 AM · Restricted Project, Restricted Project
martong added a comment to D63920: [CTU] Add support for virtual functions.

Try to set analyzer option IPAMode to something different from its default value which is dynamic-bifurcate in the test file.

Wed, Jul 3, 2:52 AM · Restricted Project, Restricted Project
martong updated the diff for D63920: [CTU] Add support for virtual functions.
  • Use -analyzer-config ipa=inlining in the test
Wed, Jul 3, 2:52 AM · Restricted Project, Restricted Project

Tue, Jul 2

martong added parent revisions for D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc: D64075: [ASTImporter] Fix structural eq of lambdas, D64073: [ASTImporter] Fix import of lambda in function param.
Tue, Jul 2, 6:52 AM · Restricted Project
martong added a child revision for D64073: [ASTImporter] Fix import of lambda in function param: D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc.
Tue, Jul 2, 6:52 AM · Restricted Project, Restricted Project
martong added a child revision for D64075: [ASTImporter] Fix structural eq of lambdas: D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc.
Tue, Jul 2, 6:52 AM · Restricted Project, Restricted Project
martong created D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc.
Tue, Jul 2, 6:51 AM · Restricted Project
martong created D64075: [ASTImporter] Fix structural eq of lambdas.
Tue, Jul 2, 6:26 AM · Restricted Project, Restricted Project
martong created D64073: [ASTImporter] Fix import of lambda in function param.
Tue, Jul 2, 6:20 AM · Restricted Project, Restricted Project
martong committed rG4f883f1c39f9: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr (authored by martong).
[ASTImporter] Structural eq: handle DependentScopeDeclRefExpr
Tue, Jul 2, 12:37 AM
martong committed rL364889: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.
[ASTImporter] Structural eq: handle DependentScopeDeclRefExpr
Tue, Jul 2, 12:36 AM
martong closed D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.
Tue, Jul 2, 12:36 AM · Restricted Project, Restricted Project

Mon, Jul 1

martong added a child revision for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src: D59692: [ASTImporter] Fix name conflict handling.
Mon, Jul 1, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
martong added a parent revision for D59692: [ASTImporter] Fix name conflict handling: D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
Mon, Jul 1, 9:49 AM · Restricted Project
martong added a comment to D62376: [ASTImporter] Mark erroneous nodes in shared st.

Jenkins had one unrelated failure at
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29812/
Test Result (1 failure / +1)
LLDB.Reproducer.TestGDBRemoteRepro.test

Mon, Jul 1, 9:32 AM · Restricted Project, Restricted Project
martong updated the diff for D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.
  • Handle ImplicitCastExpr. In Clang7 in the last two test cases we did not have any ImplicitCastExpr in the AST. With never Clang we have, so we must handle the cast expr too.
Mon, Jul 1, 9:31 AM · Restricted Project, Restricted Project
martong committed rG2afbfb6b2268: [ASTImporter] Mark erroneous nodes in shared st (authored by martong).
[ASTImporter] Mark erroneous nodes in shared st
Mon, Jul 1, 8:38 AM
martong added a comment to D62376: [ASTImporter] Mark erroneous nodes in shared st.

@shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic about the error handling only, so I'd expect to have regression only if we had testcases in lldb for erroneous cases, but apparently there are no such tests.

Mon, Jul 1, 8:37 AM · Restricted Project, Restricted Project
martong committed rL364785: [ASTImporter] Mark erroneous nodes in shared st.
[ASTImporter] Mark erroneous nodes in shared st
Mon, Jul 1, 8:37 AM
martong closed D62376: [ASTImporter] Mark erroneous nodes in shared st.
Mon, Jul 1, 8:37 AM · Restricted Project, Restricted Project
martong added a comment to D62375: [ASTImporter] Mark erroneous nodes in from ctx.

Jenkins is green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29809/

Mon, Jul 1, 8:29 AM · Restricted Project, Restricted Project
martong added a reviewer for D60463: [ASTImporter] Add check for correct import of source locations.: a_sidorin.
Mon, Jul 1, 7:29 AM · Restricted Project
martong added a reviewer for D60461: [ASTImporter] Import TemplateParameterLists in function templates.: a_sidorin.
Mon, Jul 1, 7:29 AM · Restricted Project
martong added a reviewer for D62484: [ASTImporter] Added visibility context check for EnumDecl.: a_sidorin.
Mon, Jul 1, 7:25 AM · Restricted Project, Restricted Project
martong committed rG1ad4b99d9482: [ASTImporter] Mark erroneous nodes in from ctx (authored by martong).
[ASTImporter] Mark erroneous nodes in from ctx
Mon, Jul 1, 7:21 AM
martong added a comment to D62375: [ASTImporter] Mark erroneous nodes in from ctx.

@shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic about the error handling only, so I'd expect to have regression only if we had testcases in lldb for erroneous cases, but apparently there are no such tests.

Mon, Jul 1, 7:21 AM · Restricted Project, Restricted Project
martong committed rL364771: [ASTImporter] Mark erroneous nodes in from ctx.
[ASTImporter] Mark erroneous nodes in from ctx
Mon, Jul 1, 7:20 AM
martong closed D62375: [ASTImporter] Mark erroneous nodes in from ctx.
Mon, Jul 1, 7:19 AM · Restricted Project, Restricted Project
martong added a comment to D63640: [clang] Improve Serialization/Imporing of APValues.
Mon, Jul 1, 7:18 AM · Restricted Project
martong added a comment to D63603: [ASTImporter] Propagate error from ImportDeclContext.

Jenkins is green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29802/

Mon, Jul 1, 6:31 AM · Restricted Project, Restricted Project
martong updated the diff for D62375: [ASTImporter] Mark erroneous nodes in from ctx.
  • Move ImportPathTy's funcitons in-class, add class comment
Mon, Jul 1, 6:30 AM · Restricted Project, Restricted Project
martong added a comment to D62375: [ASTImporter] Mark erroneous nodes in from ctx.

Thank you for the explanation. I got the idea of this patch anyway, but it will be definitely useful for anyone digging into the code. Should we make it a comment for ImportPathTy?

Ok, I have added the explanation to ImportPathTy as a class comment.

Mon, Jul 1, 6:30 AM · Restricted Project, Restricted Project