thanks for the review. can you please land it for me pls? Jorge Pinto Sousa <firstname.lastname@example.org>
Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
Aug 25 2023
Aug 24 2023
Jul 30 2023
Good, just verify that documentation for this check is still proper, and add entry in release notes about this change.
hi @PiotrZSL, thanks for the review :) can you please land it for me?
Jul 3 2023
while landing it, if someone feels that the release note can/should be reworded please feel free to do so.
Jul 2 2023
Thanks ^^ added the release note. Can someone please land it for me?
May 6 2023
have been sick, and could not advance much except I added the tests to replicate the issue. Any ideas on how to proceed here?
Apr 21 2023
hey :( I will try to investigate it a bit sometime next week ^^ thanks for pointing it out
kind ping ^^
Apr 18 2023
can someone land it for me pls? Jorge Pinto Sousa <email@example.com>
Apr 17 2023
@shafik does it look better now?
Apr 16 2023
cannot reproduce the build failure locally. if this looks fine can someone land it for me? or should we wait until we have a green build after rebase?
Apr 15 2023
- inline string to be checked
- removed FormatStyle Style = getLLVMStyle(); as llvm is the default style
As I dont have commit access if someone can land It for me:
Apr 14 2023
I see you uploaded this path without author attached, should I push this as "Jorge Pinto Sousa <firstname.lastname@example.org>" ?
- get rid of whitespace unrelated changes
Add more tests
Apr 13 2023
windows checks are failing, but looks like it is unrelated to this change
Apr 12 2023
@aaron.ballman should be ok now ^^
Rebased and fix wording of the release note
Thank you for letting us know -- what name and email address would you like us to use for patch attribution?
LGTM with a minor grammar change in the release note (feel free to take it or leave it as you see fit).
Also agree, imho this is better now and will be fine most of time
Does it look fine now ?
Apr 9 2023
- change AssertExpr->getSourceRange().getBegin() calls to AssertExpr->getBeginLoc()
- same for InnerCond->getSourceRange().getBegin()
- add a couple more tests
I dont have commit access, can someone land it for me?
Ah, there is -fcared-diagnostics-max-lines as a cc1 option: https://godbolt.org/z/Y4dW35v7M
Apr 8 2023
Just realized that in the case:
static_assert( true && false);
Added two test cases, and the release note.
I think the other Diag call should be changed as well:./a.cpp:4:15: error: static assertion failed static_assert(false); ^~~~~ ./a.cpp:6:1: error: static assertion failed due to requirement 'true && false' static_assert(true && false); ^ ~~~~~~~~~~~~~
Apr 7 2023
Apr 6 2023