Page MenuHomePhabricator
Feed Advanced Search

Sat, Aug 10

kristina committed rG3ab587df82c8: [modulemap] Add AArch64SVEACLETypes.def (authored by kristina).
[modulemap] Add AArch64SVEACLETypes.def
Sat, Aug 10, 1:25 AM
kristina committed rL368508: [modulemap] Add AArch64SVEACLETypes.def .
[modulemap] Add AArch64SVEACLETypes.def
Sat, Aug 10, 1:20 AM

Tue, Aug 6

kristina committed rG26e60f065318: [Attributor][modulemap] Revert r368064 but fix the build (authored by kristina).
[Attributor][modulemap] Revert r368064 but fix the build
Tue, Aug 6, 12:54 PM
kristina committed rL368076: [Attributor][modulemap] Revert r368064 but fix the build.
[Attributor][modulemap] Revert r368064 but fix the build
Tue, Aug 6, 12:52 PM
kristina closed D65821: [Attributor][modulemap] Revert r368064 but fix the build.
Tue, Aug 6, 12:52 PM · Restricted Project
kristina accepted D65821: [Attributor][modulemap] Revert r368064 but fix the build.

Thank you for taking the time to fix this properly, Modules+LTO linked successfully.

Tue, Aug 6, 12:44 PM · Restricted Project
kristina committed rG3a4d5ed232dc: [modulemap] exclude a non-module friendly header (authored by kristina).
[modulemap] exclude a non-module friendly header
Tue, Aug 6, 10:20 AM
kristina committed rL368064: [modulemap] exclude a non-module friendly header.
[modulemap] exclude a non-module friendly header
Tue, Aug 6, 10:19 AM

Sun, Aug 4

kristina added 2 commit(s) for D63378: [ORC] WIP Speculative compilation: rGf5c40cb9002a: Speculative Compilation, rL367756: Speculative Compilation.
Sun, Aug 4, 5:17 AM · Restricted Project, Restricted Project
kristina added an edge to rGf5c40cb9002a: Speculative Compilation: D63378: [ORC] WIP Speculative compilation.
Sun, Aug 4, 5:17 AM
kristina added an edge to rL367756: Speculative Compilation: D63378: [ORC] WIP Speculative compilation.
Sun, Aug 4, 5:17 AM

Jul 9 2019

kristina committed rG21b28fb8c5fe: Fix modular build issues caused by BitCodes.h (authored by kristina).
Fix modular build issues caused by BitCodes.h
Jul 9 2019, 8:54 PM
kristina committed rL365594: Fix modular build issues caused by BitCodes.h.
Fix modular build issues caused by BitCodes.h
Jul 9 2019, 8:52 PM
kristina closed D64469: Fixing modular build issues caused by BitCodes.h.
Jul 9 2019, 8:52 PM · Restricted Project
kristina updated the summary of D64469: Fixing modular build issues caused by BitCodes.h.
Jul 9 2019, 8:44 PM · Restricted Project
kristina created D64469: Fixing modular build issues caused by BitCodes.h.
Jul 9 2019, 8:36 PM · Restricted Project

Jun 4 2019

kristina committed rGc0eb8a982538: Add __FILE_NAME__ to ReleaseNotes. NFC (authored by kristina).
Add __FILE_NAME__ to ReleaseNotes. NFC
Jun 4 2019, 8:45 PM
kristina committed rL362581: Add __FILE_NAME__ to ReleaseNotes. NFC.
Add __FILE_NAME__ to ReleaseNotes. NFC
Jun 4 2019, 8:45 PM
kristina added reviewers for D62842: tvos_version_min and watchos_version_min flag: lhames, kledzik.

As trivial as it may seem, this is missing tests, even if it's for a few flags. Also please try to include context with your patches as it makes them much easier to review. If you have some sort of plan for actually bringing Mach-O LLD closer to ld64 feature-wise, I think llvm-dev may be a good place to actually outline your plan for this, which will give everyone a more clear picture of what future changes you have planned in mind.

Jun 4 2019, 1:07 PM · Restricted Project, lld
kristina added a comment to D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

Experienced the same, updated my test build configuration to always force CLANG_ENABLE_STATIC_ANALYZER to On when building with tests. Maybe it's worth adding a warning about when Clang tests are being built?

Jun 4 2019, 12:59 PM · Restricted Project
kristina added a reviewer for D62842: tvos_version_min and watchos_version_min flag: ruiu.
Jun 4 2019, 12:37 PM · Restricted Project, lld

May 28 2019

kristina added a comment to D61975: [CodeGen] Fix hashing for MO_ExternalSymbol MachineOperands..

Would it make sense to also add a test explicitly using llvm::hash_combine

Using llvm::hash_combine on what, exactly?

as well as a negative test where hash code comparison fails for a literal and the same literal in a StringRef every time

You mean something like ASSERT_NE(SymName1.data(), SymName2.data());?

May 28 2019, 11:48 AM · Restricted Project

May 25 2019

kristina added a comment to D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++.

I have a question about qsort.. If we provide own implementation of qsort and replace calls to libc's qsort to our qsort, we could fully inline cmp function then. Ideas?

May 25 2019, 2:47 AM · Restricted Project, Restricted Project
kristina added a comment to D61975: [CodeGen] Fix hashing for MO_ExternalSymbol MachineOperands..

Seems good. Would it make sense to also add a test explicitly using llvm::hash_combine, as well as a negative test where hash code comparison fails for a literal and the same literal in a StringRef every time (if it's possible to do reliably)? Just a random suggestion, probably overly paranoid.

May 25 2019, 2:25 AM · Restricted Project

May 16 2019

kristina committed rG5652063eff60: [Clang][Docs] Document __FILE_NAME__. NFC (authored by kristina).
[Clang][Docs] Document __FILE_NAME__. NFC
May 16 2019, 11:45 PM
kristina added 2 commit(s) for D61756: Add a __FILE_NAME__ macro.: rC360994: [Clang][Docs] Document __FILE_NAME__. NFC, rL360994: [Clang][Docs] Document __FILE_NAME__. NFC.
May 16 2019, 11:45 PM · Restricted Project
kristina added an edge to rC360994: [Clang][Docs] Document __FILE_NAME__. NFC: D61756: Add a __FILE_NAME__ macro..
May 16 2019, 11:45 PM
kristina added an edge to rL360994: [Clang][Docs] Document __FILE_NAME__. NFC: D61756: Add a __FILE_NAME__ macro..
May 16 2019, 11:45 PM
kristina committed rL360994: [Clang][Docs] Document __FILE_NAME__. NFC.
[Clang][Docs] Document __FILE_NAME__. NFC
May 16 2019, 11:44 PM
kristina committed rC360994: [Clang][Docs] Document __FILE_NAME__. NFC.
[Clang][Docs] Document __FILE_NAME__. NFC
May 16 2019, 11:44 PM
kristina added a comment to D54742: [CodeMetrics] Don't let extends of i1 be free..

My bad, I didn't check well enough, it seems an unrelated patch made certain tests crash due to asserts. Thanks to @craig.topper for pointing that out.

May 16 2019, 10:54 PM
kristina added a comment to D54742: [CodeMetrics] Don't let extends of i1 be free..

This seems to be causing multiple performance regressions across several bots in compile time and execution time tests.

May 16 2019, 8:56 PM
kristina added 1 commit(s) for D54742: [CodeMetrics] Don't let extends of i1 be free.: rL360970: [CodeMetrics] Don't let extends of i1 be free..
May 16 2019, 8:49 PM
kristina added an edge to rL360970: [CodeMetrics] Don't let extends of i1 be free.: D54742: [CodeMetrics] Don't let extends of i1 be free..
May 16 2019, 8:49 PM
kristina committed rGbd9748424165: Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro" (authored by kristina).
Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"
May 16 2019, 2:12 PM
kristina committed rL360938: Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro".
Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"
May 16 2019, 2:11 PM
kristina committed rC360938: Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro".
Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"
May 16 2019, 2:11 PM
kristina closed D61756: Add a __FILE_NAME__ macro..
May 16 2019, 2:11 PM · Restricted Project
kristina updated the diff for D61756: Add a __FILE_NAME__ macro..

Revised to use llvm::sys::path::filename to avoid issues on Windows hosts.

May 16 2019, 12:28 PM · Restricted Project

May 15 2019

kristina reopened D61756: Add a __FILE_NAME__ macro..

Reverted in rL360842 as Windows bots were failing.

May 15 2019, 8:42 PM · Restricted Project
kristina committed rG9d65624bf657: Revert r360833 until I can work out the issue with Win32 bots (authored by kristina).
Revert r360833 until I can work out the issue with Win32 bots
May 15 2019, 8:28 PM
kristina committed rL360842: Revert r360833 until I can work out the issue with Win32 bots.
Revert r360833 until I can work out the issue with Win32 bots
May 15 2019, 8:27 PM
kristina committed rC360842: Revert r360833 until I can work out the issue with Win32 bots.
Revert r360833 until I can work out the issue with Win32 bots
May 15 2019, 8:27 PM
kristina committed rG69e927662dc9: Fix assumption about Win32 paths in r360833 (authored by kristina).
Fix assumption about Win32 paths in r360833
May 15 2019, 7:44 PM
kristina committed rL360839: Fix assumption about Win32 paths in r360833.
Fix assumption about Win32 paths in r360833
May 15 2019, 7:44 PM
kristina committed rC360839: Fix assumption about Win32 paths in r360833.
Fix assumption about Win32 paths in r360833
May 15 2019, 7:44 PM
kristina committed rG3acc1d1be329: [Clang][PP] Add the __FILE_NAME__ builtin macro. (authored by kristina).
[Clang][PP] Add the __FILE_NAME__ builtin macro.
May 15 2019, 5:52 PM
kristina committed rC360833: [Clang][PP] Add the __FILE_NAME__ builtin macro..
[Clang][PP] Add the __FILE_NAME__ builtin macro.
May 15 2019, 5:50 PM
kristina committed rL360833: [Clang][PP] Add the __FILE_NAME__ builtin macro..
[Clang][PP] Add the __FILE_NAME__ builtin macro.
May 15 2019, 5:50 PM
kristina closed D61756: Add a __FILE_NAME__ macro..
May 15 2019, 5:50 PM · Restricted Project
kristina added a comment to D61756: Add a __FILE_NAME__ macro..

Landing this as discussed on IRC, will try to push it forward with WG14.

May 15 2019, 5:42 PM · Restricted Project
kristina added a comment to D61756: Add a __FILE_NAME__ macro..

@rsmith Ping.

May 15 2019, 3:28 PM · Restricted Project

May 10 2019

kristina added a comment to D61756: Add a __FILE_NAME__ macro..

Need @rsmith to bless this as it's introducing a nonstandard extension, however small it may be. The original diff did have a consensus on it, so I didn't really put up a formal RFC on cfe-dev.

May 10 2019, 4:38 PM · Restricted Project
kristina updated the diff for D61756: Add a __FILE_NAME__ macro..

Actually I got it wrong, the path is normalized to use regular slashes at that point, so there is no point in handling backslashes in paths at all even with Microsoft extensions.

May 10 2019, 3:55 PM · Restricted Project

May 9 2019

kristina updated the summary of D61756: Add a __FILE_NAME__ macro..
May 9 2019, 1:52 PM · Restricted Project
kristina updated the diff for D61756: Add a __FILE_NAME__ macro..

Fix style, remove unnecessary braces, add missing newline.

May 9 2019, 1:29 PM · Restricted Project
kristina added a reviewer for D61756: Add a __FILE_NAME__ macro.: dexonsmith.
May 9 2019, 1:24 PM · Restricted Project
kristina abandoned D17741: adds __FILE_BASENAME__ builtin macro.

Superseded by D61756

May 9 2019, 1:23 PM
kristina created D61756: Add a __FILE_NAME__ macro..
May 9 2019, 1:20 PM · Restricted Project

May 8 2019

kristina commandeered D17741: adds __FILE_BASENAME__ builtin macro.

Sorry, forgot about this, will make a new diff with just the macro for review later tonight.

May 8 2019, 9:30 AM

Apr 9 2019

kristina committed rGa1c44941f360: Update modulemaps for Analysis/VecFuncs.def. (authored by kristina).
Update modulemaps for Analysis/VecFuncs.def.
Apr 9 2019, 10:04 AM
kristina committed rL358021: Update modulemaps for Analysis/VecFuncs.def..
Update modulemaps for Analysis/VecFuncs.def.
Apr 9 2019, 10:04 AM

Apr 5 2019

kristina committed rG233a498cf0a7: [docs] Fix rst title in clang langext docs. NFCI (authored by kristina).
[docs] Fix rst title in clang langext docs. NFCI
Apr 5 2019, 11:27 AM
kristina committed rC357793: [docs] Fix rst title in clang langext docs. NFCI .
[docs] Fix rst title in clang langext docs. NFCI
Apr 5 2019, 11:27 AM
kristina committed rL357793: [docs] Fix rst title in clang langext docs. NFCI .
[docs] Fix rst title in clang langext docs. NFCI
Apr 5 2019, 11:27 AM

Mar 12 2019

kristina committed rG14179673e27b: [Docs] Add note about legacy PM to Ch4 of tutorial (authored by kristina).
[Docs] Add note about legacy PM to Ch4 of tutorial
Mar 12 2019, 8:45 AM
kristina committed rL355930: [Docs] Add note about legacy PM to Ch4 of tutorial.
[Docs] Add note about legacy PM to Ch4 of tutorial
Mar 12 2019, 8:45 AM
kristina closed D59258: [Docs] Add a note about legacy FunctionPassManager to the LLVM tutorial..
Mar 12 2019, 8:45 AM · Restricted Project
kristina added a comment to D59258: [Docs] Add a note about legacy FunctionPassManager to the LLVM tutorial..

I did, there are no references to any PassManager related material in the first three chapters.

Mar 12 2019, 8:37 AM · Restricted Project
kristina created D59258: [Docs] Add a note about legacy FunctionPassManager to the LLVM tutorial..
Mar 12 2019, 8:31 AM · Restricted Project
kristina added a comment to D59243: [format] \t => ' '.

Please make sure to specify Differential Revision: https://reviews.llvm.org/D59243 with Dxxxxx being the differential number in the URL when committing (on a separate line in the commit message) which will autmatically close the differential and link it to the commit which makes sure there are no stray/stale differentials. Alternatively manually link the diff to the commit (you can do that by simply quoting the commit as rL<SVN Rev> and then closing the differential manually.

Mar 12 2019, 3:03 AM · Restricted Project
kristina committed rG5b1e1c0537d0: Very minor typo. NFC (authored by kristina).
Very minor typo. NFC
Mar 12 2019, 12:11 AM
kristina committed rL355895: Very minor typo. NFC.
Very minor typo. NFC
Mar 12 2019, 12:07 AM
kristina closed D59241: [typo] we we => we.
Mar 12 2019, 12:07 AM · Restricted Project

Mar 11 2019

kristina accepted D59241: [typo] we we => we.

we were?

Mar 11 2019, 11:57 PM · Restricted Project

Mar 3 2019

kristina committed rG24659eb2e766: Remove large amount of empty lines mid-file. NFC (authored by kristina).
Remove large amount of empty lines mid-file. NFC
Mar 3 2019, 5:22 AM
kristina committed rL355286: Remove large amount of empty lines mid-file. NFC.
Remove large amount of empty lines mid-file. NFC
Mar 3 2019, 5:22 AM

Feb 28 2019

kristina added a comment to D17741: adds __FILE_BASENAME__ builtin macro.

If the author is still missing at the end of next week, any objections to me resubmitting a similar patch that just implements __FILE_NAME__ or __BASE_NAME__ (Need a few more opinions here I guess, personally I think __FILE_NAME__ makes more sense)?

Feb 28 2019, 9:12 AM

Feb 27 2019

Herald added a project to D56383: [XRay][tools] Use symbols instead of function id: Restricted Project.

Gentle ping for author, has this landed or still in the backlog? (If it's landed can you attach the commit and close it, please? Just trying to to avoid diffs on Phab going stale.)

Feb 27 2019, 4:35 AM · Restricted Project
kristina added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

What about using /*/ at the ignore pattern? This allows top-level files, and makes only new top-level *directories* require an ignore update. To my mind, that seems a bit more narrowly scoped and might be a bit less surprising. Thoughts?

Feb 27 2019, 4:33 AM

Feb 26 2019

kristina committed rG76eb4b02d93b: Update docs of memcpy/move/set wrt. align and len (authored by kristina).
Update docs of memcpy/move/set wrt. align and len
Feb 26 2019, 10:55 AM
kristina committed rL354911: Update docs of memcpy/move/set wrt. align and len.
Update docs of memcpy/move/set wrt. align and len
Feb 26 2019, 10:52 AM
kristina closed D57600: update docs of memcpy/memmove/memset re: alignment and len=0.
Feb 26 2019, 10:52 AM · Restricted Project

Feb 25 2019

kristina added a comment to D57600: update docs of memcpy/memmove/memset re: alignment and len=0.

@RalfJung Do you need someone to commit this? I can do it if you'd like.

Feb 25 2019, 1:36 PM · Restricted Project
kristina accepted D57600: update docs of memcpy/memmove/memset re: alignment and len=0.

Please make sure you have llvm-commits added as a subscriber when creating patches in the future (I'm not sure why Herald sometimes doesn't do it). The patch that changed this was rL322965, and I fixed one of the related regressions, and was meaning to update the docs but never did, so LGTM and I'm happy signing off on this.

Feb 25 2019, 9:31 AM · Restricted Project

Feb 24 2019

kristina committed rG103799c06028: Fix accidentally used hard tabs. NFC (authored by kristina).
Fix accidentally used hard tabs. NFC
Feb 24 2019, 10:09 AM
kristina committed rC354752: Fix accidentally used hard tabs. NFC.
Fix accidentally used hard tabs. NFC
Feb 24 2019, 10:06 AM
kristina committed rL354752: Fix accidentally used hard tabs. NFC.
Fix accidentally used hard tabs. NFC
Feb 24 2019, 10:06 AM
kristina committed rC354751: Wrap code for builtin_assume_aligned at 80 col.NFC.
Wrap code for builtin_assume_aligned at 80 col.NFC
Feb 24 2019, 9:58 AM
kristina committed rG716cbfb4640f: Wrap code for builtin_assume_aligned at 80 col.NFC (authored by kristina).
Wrap code for builtin_assume_aligned at 80 col.NFC
Feb 24 2019, 9:57 AM
kristina committed rL354751: Wrap code for builtin_assume_aligned at 80 col.NFC.
Wrap code for builtin_assume_aligned at 80 col.NFC
Feb 24 2019, 9:57 AM

Feb 16 2019

kristina added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

I still don't like it...It's different, unusual, and IMO surprising to have such a wildcard ignore.

We haven't tended to have lots of random accidental file additions before, and while someone may surely mess up again, I don't think it likely to be a common occurrence.

I'd much prefer simply the targeted ignore of "/build*", at least for starters.

Feb 16 2019, 6:46 PM
kristina committed rG440f8f0c2b45: [LLVMSupport]: Remove a severely outdated README. (authored by kristina).
[LLVMSupport]: Remove a severely outdated README.
Feb 16 2019, 5:52 PM
kristina committed rL354209: [LLVMSupport]: Remove a severely outdated README..
[LLVMSupport]: Remove a severely outdated README.
Feb 16 2019, 5:52 PM
kristina planned changes to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..
Feb 16 2019, 3:20 PM · Restricted Project
kristina added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

I'm in favor of this and I agree with @pcc's points and reasoning behind this.

Feb 16 2019, 3:14 PM

Feb 15 2019

kristina added a comment to D57429: [docs] Document ignoring build directory.

I actually like the D57400 approach more, it's much easier to keep a list of known top level projects as a whitelist. There are many names people could give to such a build directory (out or build or b) not to mention any other cruft one may have there. (ie. I build a libc as part of toolchain build).

Feb 15 2019, 2:37 AM · Restricted Project

Feb 6 2019

kristina added a comment to D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language.

The patch itself looks sound. However given that you have a specific use case in mind (TableGen files) could you provide supplementary coverage for that specific use case (unit tests for formatting td syntax using format::getLLVMStyle(format::FormatStyle::LK_TableGen)? I'm not entirely sure how useful this particular change is given that there's no linked patches related to your use case, I think adding those would help as well (possibly as a separate dependent patchset).

Feb 6 2019, 7:46 PM · Restricted Project, Restricted Project

Jan 29 2019

kristina added a comment to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.

FWIW, this also broke my bootstraps of mingw-w64 environments/toolchains. After building compiler-rt builtins, before having any libunwind/libcxx built, I previously regarded my toolchain as complete for building and testing C apps and libraries, but that fails now.

Would it be possible to add a third alternative, --unwindlib=none, to signal that while I'm using --rtlib=compiler-rt, I don't want to link to any unwinder? (In my case, I'm injecting libunwind in libc++.a so it only gets added when linking C++ code.) Or at least make it possible to only add this linker flag when linking C++? Alternatively I'll need to provide a dummy libunwind.a until the real one has been built.

Jan 29 2019, 12:27 AM

Jan 28 2019

kristina added a comment to D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=.

One more thing, shouldn't libunwind be only included for C++ (since it's the internal dependency of libc++abi)? There shouldn't be any need to include it for C.

Jan 28 2019, 9:06 PM