Page MenuHomePhabricator
Feed Advanced Search

Jun 1 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

formatting fixes

Jun 1 2021, 2:36 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

Doc1 => DocLHS; Doc2 => DocRHS; made raw_ostream argument in compareFiles and printDifferences; lowercase argument prompts;

Jun 1 2021, 12:09 PM · Restricted Project

May 24 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fix error handling in llvm-tapi-diff.cpp

May 24 2021, 10:06 AM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

removed import that was auto-added by text editor causing failure of tests.

May 24 2021, 9:27 AM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fixed heading on DiffEngine.cpp; made helper to collect single scalar values; ReturnedOutput => Output; made implementation details private for class variables; made helper to set order indicator for print functions; moved functions that did not need to be in header; removed unneeded conditional; removed unneeded scope; DiffVec => Values, TargValues, DocValues; addValToDiffVec => addDiffToTargetSlice; removed unnecessary this-> calls; removed typo in comment; fixed heading on llvm-tapi-diff.cpp; fixed error handling in llvm-tapi-diff.cpp

May 24 2021, 8:05 AM · Restricted Project

May 13 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fixed brackets for regex in test

May 13 2021, 12:39 PM · Restricted Project

May 12 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

use regex to try to fix windows failure.

May 12 2021, 2:50 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

update separators in tests

May 12 2021, 8:46 AM · Restricted Project

May 11 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

uploading patch again to trigger rebuild

May 11 2021, 4:46 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

rebased patch from main to fix patch apply issue, added new line for CMakeLists.txt

May 11 2021, 3:40 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

added new lines to test input files.

May 11 2021, 3:36 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

llvm.MachO.PlatformKind => llvm::MachO::PlatformKind in platform.cpp; removed 1 and 2 in favor of LHS and RHS in DiffEngine.cpp; refactored comments in DiffEngine.h; changed DiffOutput from class to struct; added llvm_unreachable in switch statements in DiffEngine.h; Added new lines at end of files.

May 11 2021, 3:30 PM · Restricted Project
spowell added a reviewer for D102250: [TextAPI] Reformat llvm_unreachable message: JDevlieghere.
May 11 2021, 9:24 AM · Restricted Project
spowell requested review of D102250: [TextAPI] Reformat llvm_unreachable message.
May 11 2021, 9:19 AM · Restricted Project

May 10 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

clang-format fixes and replaced macho.dylib for macho.yaml

May 10 2021, 3:25 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fixed patch upload for -U999999

May 10 2021, 12:13 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

updated header descriptions, updated error handling for convertFileToBinary and if a file cannot be cast as TapiUniversal.

May 10 2021, 12:08 PM · Restricted Project

May 7 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fixed issue with getOSAndEnvironmentName

May 7 2021, 3:46 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fixed issue with applying patch

May 7 2021, 2:51 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

resubmitted patch because of failure

May 7 2021, 2:39 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

changed getTargetTriple to getTargetTripleName; fixed header descriptions; fixed unreachable path; return const reference from getInterfaceFile; passing Target as const reference into getTargetTripleName; added llvm_unreachable to getOSAndEnvironmentName; NOT -> not in tests; removed unnecessary comparison in checkSymbolEquality; refactored typenames for addValToDiffVec template function; added Doxygen comments for DiffEngine.h; One and Two => LHS and RHS in llvm-tapi-diff; added WithColor; return llvm::Error or std::unique_ptr<Binary> for convertFileToBinary instead of only dumping error; used EXIT_FAILURE instead of returning 1;

May 7 2021, 2:32 PM · Restricted Project

May 4 2021

spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

uploaded with -U999999

May 4 2021, 2:12 PM · Restricted Project
spowell set the repository for D101835: [llvm] llvm-tapi-diff to rG LLVM Github Monorepo.
May 4 2021, 1:38 PM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fix clang-tidy warnings

May 4 2021, 11:06 AM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

fixed issue with ... at end of tbd files that caused malformed file for testing

May 4 2021, 8:56 AM · Restricted Project
spowell updated the diff for D101835: [llvm] llvm-tapi-diff.

clang-format fixes and included getOSAndEnvironmentName.

May 4 2021, 8:10 AM · Restricted Project
spowell requested review of D101835: [llvm] llvm-tapi-diff.
May 4 2021, 7:32 AM · Restricted Project

Feb 18 2021

spowell updated the diff for D96629: [llvm][TextAPI] add equality operator for InterfaceFile.

moved transform wrapper to TextStubHelpers, refactored inequality tests for both v3 and v4.

Feb 18 2021, 9:57 AM · Restricted Project

Feb 17 2021

spowell updated the diff for D96629: [llvm][TextAPI] add equality operator for InterfaceFile.

refactored tests to implement wrapper, removed single line {}, changed Document.insert to Document.emplace

Feb 17 2021, 1:01 PM · Restricted Project

Feb 16 2021

spowell updated the diff for D96629: [llvm][TextAPI] add equality operator for InterfaceFile.

updated std::lower_bound to llvm::lower_bound

Feb 16 2021, 1:38 PM · Restricted Project

Feb 12 2021

spowell added reviewers for D96629: [llvm][TextAPI] add equality operator for InterfaceFile: ributzka, cishida, steven_wu, zixuw.
Feb 12 2021, 1:19 PM · Restricted Project
spowell requested review of D96629: [llvm][TextAPI] add equality operator for InterfaceFile.
Feb 12 2021, 1:13 PM · Restricted Project