Page MenuHomePhabricator
Feed Advanced Search

May 5 2020

pratyai added a comment to D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store..

fix branch

May 5 2020, 2:39 AM · Restricted Project
pratyai updated the diff for D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store..
May 5 2020, 2:39 AM · Restricted Project
pratyai updated the diff for D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store..
May 5 2020, 2:39 AM · Restricted Project
pratyai added inline comments to D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store..
May 5 2020, 2:39 AM · Restricted Project

May 4 2020

pratyai added reviewers for D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store.: vitalybuka, kcc.
May 4 2020, 9:32 PM · Restricted Project
pratyai created D79392: [SanitizerCoverage] Replace the unconditional store with a load, then a conditional store..
May 4 2020, 9:32 PM · Restricted Project

Apr 24 2020

pratyai added a comment to D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..

I removed the test. After some consideration is not a good place, but even in sanitizer_common it's not very useful as it's hard to get new problems like this in future.

I'll put all the fuzzer related changes together in another diff.

What kind of changes?

Apr 24 2020, 11:57 PM · Restricted Project
pratyai updated the diff for D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 24 2020, 1:02 AM · Restricted Project
pratyai added inline comments to D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 24 2020, 12:29 AM · Restricted Project

Apr 23 2020

pratyai added a comment to D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..

Hmm, it seems I cannot do arc land (permission denied, 403). In that case, would you please land the diff? Thanks!

Apr 23 2020, 10:46 PM · Restricted Project
pratyai updated the diff for D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 23 2020, 1:00 PM · Restricted Project
pratyai added a comment to D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..

I'll take an attempt of landing it today if it's alright, since it's accepted. Was waiting in case the newly added test files were problematic. Thank!

Apr 23 2020, 1:00 PM · Restricted Project

Apr 16 2020

pratyai updated the diff for D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 16 2020, 9:06 PM · Restricted Project

Apr 15 2020

pratyai updated the diff for D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..

Added LinkTest.cpp and link.test, just to verify that the weak interfaces would allow to combine the -fsanitize-coverage=inline-bool-flag with -fsanitize=fuzzer without linker errors.

Apr 15 2020, 3:47 AM · Restricted Project
pratyai added a comment to D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..

could you try to add libfuzzer test?

Apr 15 2020, 2:41 AM · Restricted Project

Apr 14 2020

pratyai added a comment to D78114: [NFC, tsan] Update tsan tests expectation.

How exactly do you configure the project? And what is the platform.
For me tests pass as-is and fail with your patch.

Apr 14 2020, 11:57 PM · Restricted Project
pratyai added a reviewer for D78114: [NFC, tsan] Update tsan tests expectation: vitalybuka.
Apr 14 2020, 8:33 AM · Restricted Project
pratyai created D78114: [NFC, tsan] Update tsan tests expectation.
Apr 14 2020, 8:33 AM · Restricted Project
pratyai updated the diff for D77889: [SanitizerCoverage] The section name for inline-bool-flag was too long for darwin builds, so shortening it..
Apr 14 2020, 2:37 AM · Restricted Project

Apr 10 2020

pratyai updated the summary of D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 10 2020, 3:04 PM · Restricted Project
pratyai updated the summary of D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 10 2020, 3:04 PM · Restricted Project
pratyai updated the diff for D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 10 2020, 1:58 PM · Restricted Project
pratyai updated the summary of D77889: [SanitizerCoverage] The section name for inline-bool-flag was too long for darwin builds, so shortening it..
Apr 10 2020, 1:26 PM · Restricted Project
pratyai updated the diff for D77889: [SanitizerCoverage] The section name for inline-bool-flag was too long for darwin builds, so shortening it..
Apr 10 2020, 12:53 PM · Restricted Project
pratyai created D77889: [SanitizerCoverage] The section name for inline-bool-flag was too long for darwin builds, so shortening it..
Apr 10 2020, 11:11 AM · Restricted Project
pratyai added a comment to D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag.

It looks like this change breaks some macOS builds, e.g. http://green.lab.llvm.org/green/job/clang-stage1-RA/8593/

I’ve disabled it for x86_64-darwin as well (it was already unsupported for i386-darwin) in d6525eff5ebfa0ef1d6cd75cb9b40b1881e7a707

It would be great if you could take a look.

Apr 10 2020, 9:44 AM · Restricted Project
pratyai updated the diff for D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 10 2020, 9:26 AM · Restricted Project
pratyai updated the summary of D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 10 2020, 7:24 AM · Restricted Project

Apr 9 2020

pratyai updated the summary of D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 9 2020, 10:17 PM · Restricted Project
pratyai updated the summary of D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 9 2020, 10:17 PM · Restricted Project
pratyai updated the summary of D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 9 2020, 10:17 PM · Restricted Project
pratyai created D77857: [SanitizerCoverage] Add `__sanitizer_cov_bool_flag_init` as the weak interface functions..
Apr 9 2020, 10:17 PM · Restricted Project
pratyai added a comment to D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag.

I'll submit this a little bit later

Apr 9 2020, 3:13 AM · Restricted Project
pratyai updated the diff for D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.

Was unintentionally enabling the bool-flag coverage in SanitizerArgs.cpp before (line#383, if (Add & SanitizerKind::FuzzerNoLink) { CoverageFeatures |= ... }

Apr 9 2020, 1:36 AM · Restricted Project
pratyai updated the diff for D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.
Apr 9 2020, 1:03 AM · Restricted Project

Apr 8 2020

pratyai added inline comments to D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag.
Apr 8 2020, 10:40 PM · Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Adjusted the diff in the change (align 1 is dropped from the llvm instruction of the CHECK). The reason is that it does not get set until setAlignment is explicitly called (ref: https://llvm.org/doxygen/Instructions_8cpp_source.html#l01421). From https://llvm.org/docs/LangRef.html#global-variables

Apr 8 2020, 10:07 PM · Restricted Project, Restricted Project, Restricted Project
pratyai added inline comments to D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.
Apr 8 2020, 9:34 PM · Restricted Project
pratyai updated the diff for D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.
Apr 8 2020, 9:34 PM · Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

oops; forgot that dropping the alignment == 1 ? 1 : alignment / 8 bit off this diff wouldn't work with build.

Apr 8 2020, 9:02 PM · Restricted Project, Restricted Project, Restricted Project
pratyai added a comment to D77244: [part 1] sancov/inline-bool-flag instrumentation..

It looks like I broke the tests after the i8 -> i1 switch.

I think it's because of an existing bug. From https://llvm.org/docs/LangRef.html

i1:8:8 - i1 is 8-bit (byte) aligned

OTOH, in SanitizerCoverage.cpp, we have in CreateFunctionLocalArrayInSection():

Array->setAlignment(Align(Ty->isPointerTy()
                             ? DL->getPointerSize()
                             : Ty->getPrimitiveSizeInBits() / 8));

IIUC getPrimitiveSizeInBits() / 8 would be 1 / 8 => 0 for i1 type (it works for other int types which have multiple-of-8 bits.

PLMK if my assessment is correct, and if so if I should fix it in a separate patch, or just keep that in here.

I'll leave this patch "un-split" for now.

Thanks!

Looks like a bug.
Separate patch would be nice. If it goes before this one we can expect NOP.
However, if you don't have committer access, I am going to submit this for you, and I can split the patch myself.

Apr 8 2020, 8:30 PM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..
Apr 8 2020, 8:30 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2020

pratyai added a child revision for D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag: D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag.
Apr 7 2020, 8:07 AM · Restricted Project
pratyai added a parent revision for D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag: D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.
Apr 7 2020, 8:07 AM · Restricted Project
pratyai added a child revision for D77244: [part 1] sancov/inline-bool-flag instrumentation.: D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.
Apr 7 2020, 7:34 AM · Restricted Project, Restricted Project, Restricted Project
pratyai added a parent revision for D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag: D77244: [part 1] sancov/inline-bool-flag instrumentation..
Apr 7 2020, 7:34 AM · Restricted Project
pratyai created D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag.
Apr 7 2020, 4:49 AM · Restricted Project
pratyai updated the diff for D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.
Apr 7 2020, 4:49 AM · Restricted Project
pratyai created D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag.
Apr 7 2020, 4:49 AM · Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..
Apr 7 2020, 2:40 AM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2020

pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Dropped files from outside llvm/.../Instrumentation* as suggested.
The clang flags & compiler-rt tests will be added in future diffs.

Apr 3 2020, 2:38 PM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2020

pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Added the alignment for i1 as a special case.

Apr 2 2020, 7:01 AM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Added the alignment for i1 as a special case.

Apr 2 2020, 7:01 AM · Restricted Project, Restricted Project, Restricted Project
pratyai added a comment to D77244: [part 1] sancov/inline-bool-flag instrumentation..

It looks like I broke the tests after the i8 -> i1 switch.

Apr 2 2020, 4:18 AM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

fsanitize-coverage.c undo was incorrect the first time :(

Apr 2 2020, 3:13 AM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

And missed a space.
Sorry, I'm just not very familiar with this kind of test, and cannot spot the mistakes before going to the web UI.

Apr 2 2020, 3:13 AM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Did the same for fsanitize-coverage.c.

Apr 2 2020, 2:40 AM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Undid the arc lint on autocomplete.c.
arc lint does not seem to have an option --style, but it's just one line diff anyway.

Apr 2 2020, 2:40 AM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2020

pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..
  • Switched to Int1Ty.
  • Switched Atomic::NonAtomic (same as just dropping the two lines?)
  • C++ files were clang-formatted, but arc lint couldn't find clang-format-diff before. Now it seems to have formatted the lit tests.
  • Will split the patch later (i.e. remove all non-instrumentation stuff from this patch, then move flags & compiler-rt tests into two other patches).
Apr 1 2020, 10:18 PM · Restricted Project, Restricted Project, Restricted Project
pratyai updated subscribers of D77244: [part 1] sancov/inline-bool-flag instrumentation..
Apr 1 2020, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Still had a couple of lines of diff left :(

Apr 1 2020, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
pratyai updated the diff for D77244: [part 1] sancov/inline-bool-flag instrumentation..

Removed some unintentional diffs.

Apr 1 2020, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
pratyai created D77244: [part 1] sancov/inline-bool-flag instrumentation..
Apr 1 2020, 2:38 PM · Restricted Project, Restricted Project, Restricted Project