Page MenuHomePhabricator
Feed Advanced Search

Yesterday

jsji updated the summary of D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization.
Fri, Jul 30, 7:24 PM
jsji updated the diff for D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization.

Casting the result of distribution only.

Fri, Jul 30, 7:23 PM
jsji added a comment to D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization.

Casting the result is OK for me, if that is better for you.

Fri, Jul 30, 7:21 PM
jsji added a comment to D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization.

Did you consider just casting the range to the desired type?

template <typename T> static void init_data(T *A, unsigned N) {
  std::uniform_real_distribution<T> dist((T)-100, (T)100);
  std::mt19937 rng(12345);
  for (unsigned i = 0; i < N; i++)
    A[i] = dist(rng);
}
Fri, Jul 30, 6:46 PM
jsji added a reviewer for D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization: hubert.reinterpretcast.
Fri, Jul 30, 5:26 PM
jsji added a comment to D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization.

This is breaking out internal buildbot.

Fri, Jul 30, 5:12 PM
jsji retitled D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization from Fix clang build failure due to uniform_real_distribution to [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization.
Fri, Jul 30, 5:07 PM
jsji requested review of D107204: [test-suite] Fix clang build failure due to uniform_real_distribution in SLPVectorization.
Fri, Jul 30, 5:07 PM

Thu, Jul 29

jsji committed rGa09e93bfb820: [AIX] Include symbol alias in extract_symbols.py (authored by jsji).
[AIX] Include symbol alias in extract_symbols.py
Thu, Jul 29, 6:38 PM
jsji closed D107112: [AIX] Include symbol alias in extract_symbols.py.
Thu, Jul 29, 6:38 PM · Restricted Project
jsji requested review of D107112: [AIX] Include symbol alias in extract_symbols.py.
Thu, Jul 29, 3:10 PM · Restricted Project
jsji accepted D107077: [PowerPC] Fix return type of XL compat CAS.

LGTM. Thanks!

Thu, Jul 29, 7:34 AM · Restricted Project

Tue, Jul 27

jsji committed rGedbdf8e5b5aa: [AIX] Update fetch_and_add type (authored by jsji).
[AIX] Update fetch_and_add type
Tue, Jul 27, 3:14 PM
jsji closed D106920: [AIX] Update fetch_and_add type.
Tue, Jul 27, 3:13 PM · Restricted Project
jsji updated the diff for D106920: [AIX] Update fetch_and_add type.

Update tests.

Tue, Jul 27, 3:10 PM · Restricted Project
jsji updated the summary of D106920: [AIX] Update fetch_and_add type.
Tue, Jul 27, 3:01 PM · Restricted Project
jsji added a reviewer for D106920: [AIX] Update fetch_and_add type: Restricted Project.
Tue, Jul 27, 3:00 PM · Restricted Project
jsji updated the summary of D106920: [AIX] Update fetch_and_add type.
Tue, Jul 27, 3:00 PM · Restricted Project
jsji requested review of D106920: [AIX] Update fetch_and_add type.
Tue, Jul 27, 2:59 PM · Restricted Project
jsji committed rGe07f9342be71: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT (authored by jsji).
[libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT
Tue, Jul 27, 1:19 PM
jsji closed D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT.
Tue, Jul 27, 1:19 PM · Restricted Project
jsji added inline comments to D105527: libclang.so: Make SONAME independent from LLVM version.
Tue, Jul 27, 1:16 PM · Restricted Project
jsji requested review of D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT.
Tue, Jul 27, 1:12 PM · Restricted Project
jsji added inline comments to D105527: libclang.so: Make SONAME independent from LLVM version.
Tue, Jul 27, 12:19 PM · Restricted Project

Thu, Jul 22

jsji added inline comments to D106554: [ORC] Work around AIX build compiler: Replace lambda; NFC.
Thu, Jul 22, 8:37 PM · Restricted Project
jsji accepted D106554: [ORC] Work around AIX build compiler: Replace lambda; NFC.

LGTM to unblock the buildbots first. Thanks for the workaround.

Thu, Jul 22, 8:37 PM · Restricted Project
jsji accepted D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap.

that looks like a historical issue which exists for 13yrs

Hmm... OK.. Let us leave it as it is for now.

Thu, Jul 22, 7:52 AM · Restricted Project, Restricted Project

Wed, Jul 21

jsji added a comment to D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap.

Doesn't look like good enough to me, the code sequence generated is not clean enough.

Wed, Jul 21, 2:56 PM · Restricted Project, Restricted Project

Mon, Jul 19

jsji accepted D106234: [PowerPC] Fallback to base's implementation of shouldExpandAtomicCmpXchgInIR and shouldExpandAtomicCmpXchgInIR.
Mon, Jul 19, 9:00 AM · Restricted Project

Thu, Jul 15

jsji added a reviewer for D105854: [PowerPC] Inefficient register allocation of ACC registers results in many copies.: lkail.
Thu, Jul 15, 8:45 PM · Restricted Project

Wed, Jul 14

jsji added reviewers for D101759: [PowerPC] Scalar IBM MASS library conversion pass: qiucf, shchenz.
Wed, Jul 14, 2:47 PM · Restricted Project, Restricted Project, Restricted Project
jsji committed rGfe52296a3433: [AIX] Enable dollar sign as PC in inlineasm (authored by jsji).
[AIX] Enable dollar sign as PC in inlineasm
Wed, Jul 14, 6:54 AM
jsji closed D105956: [AIX] Enable dollar sign as PC in inlineasm.
Wed, Jul 14, 6:54 AM · Restricted Project

Tue, Jul 13

jsji committed rG64785ac12ef8: [AIX] Update testcase to use aix triple (authored by jsji).
[AIX] Update testcase to use aix triple
Tue, Jul 13, 8:33 PM
jsji updated the diff for D105956: [AIX] Enable dollar sign as PC in inlineasm.

Address comments.

Tue, Jul 13, 8:04 PM · Restricted Project
jsji requested review of D105956: [AIX] Enable dollar sign as PC in inlineasm.
Tue, Jul 13, 6:40 PM · Restricted Project

Mon, Jul 12

jsji committed rG2377eca93c03: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well (authored by jsji).
[PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well
Mon, Jul 12, 10:56 AM
jsji closed D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well.
Mon, Jul 12, 10:56 AM · Restricted Project
jsji committed rG28fb69e00a4d: [AIX] Emit version string in .file directive (authored by jsji).
[AIX] Emit version string in .file directive
Mon, Jul 12, 10:04 AM
jsji closed D105743: [AIX] Emit version string in .file directive.
Mon, Jul 12, 10:04 AM · Restricted Project

Sun, Jul 11

jsji added a comment to D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well.

@nemanjai 3 stage bootstrap ( LIT stage test in all stages, test-suite test in stage 3) with -mcpu=pwr7 -O3 + this patch passed on LE machines .

Awesome! Thank you so much for doing that Jinsong.
LGTM.

Sun, Jul 11, 8:34 PM · Restricted Project
jsji added inline comments to D105743: [AIX] Emit version string in .file directive.
Sun, Jul 11, 8:30 PM · Restricted Project

Sat, Jul 10

jsji added a comment to D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well.

@nemanjai 3 stage bootstrap ( LIT stage test in all stages, test-suite test in stage 3) with -mcpu=pwr7 -O3 + this patch passed on LE machines .

Sat, Jul 10, 6:50 PM · Restricted Project

Fri, Jul 9

jsji added a comment to D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well.

I have tested this patch with test suite + -mcpu=pwr7 on AIX.
Sure, if you insist on bootstrap testing, I can try that too.

Fri, Jul 9, 9:15 PM · Restricted Project
jsji updated the diff for D105743: [AIX] Emit version string in .file directive.

Fix typo.

Fri, Jul 9, 6:41 PM · Restricted Project
jsji requested review of D105743: [AIX] Emit version string in .file directive.
Fri, Jul 9, 3:06 PM · Restricted Project
jsji added inline comments to D105271: [PowerPC][ELF]make sure local variable space does not overlap with parameter save area.
Fri, Jul 9, 11:44 AM · Restricted Project
jsji added inline comments to D105271: [PowerPC][ELF]make sure local variable space does not overlap with parameter save area.
Fri, Jul 9, 11:42 AM · Restricted Project
jsji added a comment to D105271: [PowerPC][ELF]make sure local variable space does not overlap with parameter save area.
Fri, Jul 9, 11:38 AM · Restricted Project
jsji added inline comments to D105617: [PowerPC] Fix addi-load bias scheduling heuristics.
Fri, Jul 9, 11:34 AM · Restricted Project

Thu, Jul 8

jsji updated the diff for D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well.

Update test using script.

Thu, Jul 8, 7:12 AM · Restricted Project
jsji added inline comments to D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well.
Thu, Jul 8, 7:02 AM · Restricted Project

Wed, Jul 7

jsji committed rG31d10ea10ee1: [AIX] Don't pass no-integrated-as by default (authored by jsji).
[AIX] Don't pass no-integrated-as by default
Wed, Jul 7, 7:50 PM
jsji closed D105512: [AIX] Don't pass no-integrated-as by default.
Wed, Jul 7, 7:50 PM · Restricted Project
jsji requested review of D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well.
Wed, Jul 7, 2:59 PM · Restricted Project
jsji committed rG89f2d98b9870: [PowerPC] Add P7 RUN line for load and splat test (authored by jsji).
[PowerPC] Add P7 RUN line for load and splat test
Wed, Jul 7, 2:44 PM
jsji added inline comments to D105271: [PowerPC][ELF]make sure local variable space does not overlap with parameter save area.
Wed, Jul 7, 9:21 AM · Restricted Project
jsji accepted D103614: [PowerPC] Generate inlined quadword lock free atomic operations via AtomicExpand.

LGTM. Please hold a few days to see whether there are other comments. Thanks.

Wed, Jul 7, 8:32 AM · Restricted Project
jsji added inline comments to D105512: [AIX] Don't pass no-integrated-as by default.
Wed, Jul 7, 6:53 AM · Restricted Project

Tue, Jul 6

jsji requested review of D105512: [AIX] Don't pass no-integrated-as by default.
Tue, Jul 6, 1:58 PM · Restricted Project

Fri, Jul 2

jsji committed rG03e9dcfd41d4: [AIX] Use AsmParser to do inline asm parsing (authored by jsji).
[AIX] Use AsmParser to do inline asm parsing
Fri, Jul 2, 9:13 AM
jsji committed rGbf64210fd88f: [AIX] Add dummy XCOFF MCAsmParserExtension (authored by jsji).
[AIX] Add dummy XCOFF MCAsmParserExtension
Fri, Jul 2, 9:13 AM
jsji closed D105314: [AIX] Use AsmParser to do inline asm parsing.
Fri, Jul 2, 9:12 AM · Restricted Project
jsji closed D105259: [AIX] Add dummy XCOFF MCAsmParserExtension.
Fri, Jul 2, 9:12 AM · Restricted Project

Thu, Jul 1

jsji updated the diff for D105314: [AIX] Use AsmParser to do inline asm parsing.

To trigger premerget tests again.

Thu, Jul 1, 7:10 PM · Restricted Project
jsji added a comment to D105314: [AIX] Use AsmParser to do inline asm parsing.

Seems the X86 failures in the premerge tests need to be addressed. A little strange why that assertion only happens on X86 target.

Thu, Jul 1, 7:09 PM · Restricted Project
jsji requested review of D105314: [AIX] Use AsmParser to do inline asm parsing.
Thu, Jul 1, 1:30 PM · Restricted Project

Jun 30 2021

jsji requested review of D105259: [AIX] Add dummy XCOFF MCAsmParserExtension.
Jun 30 2021, 8:09 PM · Restricted Project
jsji added a reviewer for D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins: lkail.
Jun 30 2021, 3:14 PM · Restricted Project, Restricted Project
jsji added inline comments to D97184: [XCOFF] support DWARF for XCOFF for object output.
Jun 30 2021, 9:27 AM · Restricted Project
jsji accepted D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.

LGTM.

Jun 30 2021, 9:15 AM · Restricted Project
jsji accepted D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.

LGTM. Thanks.

Jun 30 2021, 7:12 AM · Restricted Project

Jun 28 2021

jsji accepted D104908: [AIX][compiler-rt] Deliver libatomic.a at top level library directory.

LGTM. Thanks.

Jun 28 2021, 10:24 AM · Restricted Project

Jun 27 2021

jsji committed rGeb237ffca821: [PowerPC] Add XL Compat fetch builtins (authored by jsji).
[PowerPC] Add XL Compat fetch builtins
Jun 27 2021, 7:53 PM
jsji closed D104991: [PowerPC] Add XL Compat fetch builtins.
Jun 27 2021, 7:53 PM · Restricted Project
jsji updated the summary of D104991: [PowerPC] Add XL Compat fetch builtins.
Jun 27 2021, 8:41 AM · Restricted Project
jsji requested review of D104991: [PowerPC] Add XL Compat fetch builtins.
Jun 27 2021, 8:40 AM · Restricted Project

Jun 24 2021

jsji committed rGf3ef4f5bff26: [PowerPC] Add XL compat __compare_and_swap builtins (authored by jsji).
[PowerPC] Add XL compat __compare_and_swap builtins
Jun 24 2021, 6:32 PM
jsji closed D104837: [PowerPC] Add XL compat __compare_and_swap builtins.
Jun 24 2021, 6:32 PM · Restricted Project
jsji added inline comments to D104837: [PowerPC] Add XL compat __compare_and_swap builtins.
Jun 24 2021, 6:09 PM · Restricted Project
jsji updated the diff for D104837: [PowerPC] Add XL compat __compare_and_swap builtins.

Address comments.

Jun 24 2021, 6:08 PM · Restricted Project
jsji updated the diff for D104837: [PowerPC] Add XL compat __compare_and_swap builtins.

Add {} to case.

Jun 24 2021, 2:39 PM · Restricted Project
jsji added reviewers for D104837: [PowerPC] Add XL compat __compare_and_swap builtins: shchenz, Whitney.
Jun 24 2021, 2:32 PM · Restricted Project
jsji added inline comments to D104855: [PowerPC] Change VSRpRC allocation order.
Jun 24 2021, 8:07 AM · Restricted Project

Jun 23 2021

jsji requested review of D104837: [PowerPC] Add XL compat __compare_and_swap builtins.
Jun 23 2021, 9:11 PM · Restricted Project
jsji committed rGc125af82a5ff: [DAGCombine] Check reassoc flags in aggressive fsub fusion (authored by jsji).
[DAGCombine] Check reassoc flags in aggressive fsub fusion
Jun 23 2021, 7:00 AM
jsji closed D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.
Jun 23 2021, 7:00 AM · Restricted Project
jsji added inline comments to D103614: [PowerPC] Generate inlined quadword lock free atomic operations via AtomicExpand.
Jun 23 2021, 6:21 AM · Restricted Project

Jun 22 2021

jsji added inline comments to D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX.
Jun 22 2021, 2:22 PM · Restricted Project
jsji accepted D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX.

LGTM.

Jun 22 2021, 12:35 PM · Restricted Project
jsji added inline comments to D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX.
Jun 22 2021, 11:31 AM · Restricted Project
jsji updated the diff for D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.

Rename to isContractableAndReassociableFMUL.

Jun 22 2021, 11:24 AM · Restricted Project
jsji added inline comments to D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.
Jun 22 2021, 11:12 AM · Restricted Project
jsji updated the diff for D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.

Address comments.

Jun 22 2021, 11:11 AM · Restricted Project
jsji updated the summary of D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.
Jun 22 2021, 10:06 AM · Restricted Project
jsji added inline comments to D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.
Jun 22 2021, 10:04 AM · Restricted Project
jsji updated the diff for D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.

Fix typo.

Jun 22 2021, 9:58 AM · Restricted Project
jsji added inline comments to D104247: [DAGCombine] reassoc flag shouldn't enable contract.
Jun 22 2021, 9:56 AM · Restricted Project
jsji requested review of D104723: [DAGCombine] Check reassoc flags in aggressive fsub fusion.
Jun 22 2021, 9:54 AM · Restricted Project
jsji added inline comments to D104247: [DAGCombine] reassoc flag shouldn't enable contract.
Jun 22 2021, 7:06 AM · Restricted Project