Page MenuHomePhabricator
Feed Advanced Search

Fri, Jun 14

jsji committed rGbbab7acedf40: [PowerPC][NFC] Comments update and remove some unused def (authored by jsji).
[PowerPC][NFC] Comments update and remove some unused def
Fri, Jun 14, 2:32 PM
jsji committed rL363461: [PowerPC][NFC] Comments update and remove some unused def.
[PowerPC][NFC] Comments update and remove some unused def
Fri, Jun 14, 2:30 PM
jsji committed rGc9e3dbb0a51c: [PowerPC][NFC] Format comments in P9InstrResrouce.td (authored by jsji).
[PowerPC][NFC] Format comments in P9InstrResrouce.td
Fri, Jun 14, 10:03 AM
jsji committed rL363423: [PowerPC][NFC] Format comments in P9InstrResrouce.td.
[PowerPC][NFC] Format comments in P9InstrResrouce.td
Fri, Jun 14, 10:03 AM

Thu, Jun 13

jsji committed rG1c88445840c5: [MachinePiepliner] Don't check boundary node in checkValidNodeOrder (authored by jsji).
[MachinePiepliner] Don't check boundary node in checkValidNodeOrder
Thu, Jun 13, 2:50 PM
jsji committed rL363329: [MachinePiepliner] Don't check boundary node in checkValidNodeOrder.
[MachinePiepliner] Don't check boundary node in checkValidNodeOrder
Thu, Jun 13, 2:50 PM
jsji closed D63282: [MachinePipeliner] Don't check boundary node in checkValidNodeOrder.
Thu, Jun 13, 2:49 PM · Restricted Project
jsji added a comment to D63282: [MachinePipeliner] Don't check boundary node in checkValidNodeOrder.

Thanks. Will update the comments in commit.

Thu, Jun 13, 2:06 PM · Restricted Project
jsji added 2 commit(s) for D63282: [MachinePipeliner] Don't check boundary node in checkValidNodeOrder: rL363105: [PowerPC][NFC]Remove sms-simple.ll test temporarily., rL363085: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Thu, Jun 13, 11:01 AM · Restricted Project
jsji added an edge to rL363105: [PowerPC][NFC]Remove sms-simple.ll test temporarily.: D63282: [MachinePipeliner] Don't check boundary node in checkValidNodeOrder.
Thu, Jun 13, 11:01 AM
jsji added an edge to rL363085: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner: D63282: [MachinePipeliner] Don't check boundary node in checkValidNodeOrder.
Thu, Jun 13, 11:01 AM
jsji accepted D61228: [PowerPC] Set the innermost hot loop to align 32 bytes.

LGTM, some comments /renaming can be done before committing. Thanks.

Thu, Jun 13, 10:52 AM · Restricted Project
jsji added a comment to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Thanks, yes, it looks like an issue exposed by power enablement. I have removed sms-simple.ll temporarily to unblock build bot. I will investigate and fix the root cause.

Thu, Jun 13, 10:16 AM · Restricted Project
jsji created D63282: [MachinePipeliner] Don't check boundary node in checkValidNodeOrder.
Thu, Jun 13, 10:08 AM · Restricted Project

Tue, Jun 11

jsji added a comment to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Hi,

This patch seems to fail under Asan at https://github.com/llvm-mirror/llvm/blob/28bea3dbfef348e53cf48f921e96a35b642b3950/lib/CodeGen/MachinePipeliner.cpp#L3736.

I verified that lower_bound() may return Indices.end() upon running the test CodeGen/PowerPC/sms-simple.ll.

Tue, Jun 11, 4:17 PM · Restricted Project
jsji committed rG898d48117430: [PowerPC][NFC]Remove sms-simple.ll test temporarily. (authored by jsji).
[PowerPC][NFC]Remove sms-simple.ll test temporarily.
Tue, Jun 11, 3:07 PM
jsji committed rL363105: [PowerPC][NFC]Remove sms-simple.ll test temporarily..
[PowerPC][NFC]Remove sms-simple.ll test temporarily.
Tue, Jun 11, 3:06 PM
jsji committed rGef2d6d99c0d3: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner (authored by jsji).
[PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner
Tue, Jun 11, 10:39 AM
jsji committed rL363085: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
[PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner
Tue, Jun 11, 10:38 AM
jsji closed D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Tue, Jun 11, 10:38 AM · Restricted Project
jsji added a comment to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Ping... Any further comments and feedback? @hfinkel . Thanks!

Tue, Jun 11, 8:36 AM · Restricted Project
jsji added reviewers for D61248: [NFC] Add the infrastructure to forward the scheduled state between MBB: javed.absar, MatzeB.
Tue, Jun 11, 7:06 AM · Restricted Project

Mon, Jun 10

jsji added inline comments to D62565: [PowerPC] Exploiting to use mtvsrdd instruction when save called-saved GPR register to VSR registers.
Mon, Jun 10, 2:49 PM · Restricted Project
jsji added a comment to D62993: [PowerPC] Emit scalar min/max instructions with unsafe fp math.

It is a great idea to exploit xsmindp/xsmaxdp! But looks like we make it more general than restricted to UnsafeFPMath?

Mon, Jun 10, 2:12 PM · Restricted Project
jsji committed rG9c7f93e9146a: [PowerPC][HTM]Fix $zero is not a GPRC register for builtin_ttest (authored by jsji).
[PowerPC][HTM]Fix $zero is not a GPRC register for builtin_ttest
Mon, Jun 10, 12:03 PM
jsji committed rL362974: [PowerPC][HTM]Fix $zero is not a GPRC register for builtin_ttest.
[PowerPC][HTM]Fix $zero is not a GPRC register for builtin_ttest
Mon, Jun 10, 12:03 PM
jsji closed D63079: [PowerPC][HTM] Fix $zero is not a GPRC register for builtin_ttest.
Mon, Jun 10, 12:03 PM · Restricted Project
jsji created D63079: [PowerPC][HTM] Fix $zero is not a GPRC register for builtin_ttest.
Mon, Jun 10, 8:35 AM · Restricted Project
jsji retitled D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others from Fixes PPC64 Tbegin disassembling to [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.
Mon, Jun 10, 7:46 AM · Restricted Project
jsji updated the diff for D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

This patch try to clean up TM related DAGs.

  1. Fixes the problem by remove explicit output of cr0, and put it as implicit def.
  2. Update int_ppc_tbegin pattern to accommodate the implicit def of cr0.
  3. Update the TCHECK operand and int_ppc_tcheck accordingly.
  4. Add some builtin test and disassembly tests.
Mon, Jun 10, 7:43 AM · Restricted Project
jsji commandeered D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Commandeer this Revision as discussed.

Mon, Jun 10, 7:40 AM · Restricted Project

Fri, Jun 7

jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

I had a quick look, and the problem is that after the fix,
TBEGIN doesn't have any outs now, hence no valid RC, so we can't EXTRACT_SUBREG from this DAG.

Fri, Jun 7, 10:19 AM · Restricted Project
jsji committed rG7aafdef62711: [MachineScheduler] checkResourceLimit boundary condition update (authored by jsji).
[MachineScheduler] checkResourceLimit boundary condition update
Fri, Jun 7, 7:52 AM
jsji committed rL362805: [MachineScheduler] checkResourceLimit boundary condition update.
[MachineScheduler] checkResourceLimit boundary condition update
Fri, Jun 7, 7:51 AM
jsji closed D62345: [MachineScheduler] checkResourceLimit boundary condition update.
Fri, Jun 7, 7:51 AM · Restricted Project
jsji updated the diff for D62345: [MachineScheduler] checkResourceLimit boundary condition update.

Thanks Javed! Rebased to ToT before committing.

Fri, Jun 7, 7:42 AM · Restricted Project
jsji accepted D62569: [PowerPC] [Clang] Port SSE2 intrinsics to PowerPC.

LGTM. Thanks for porting.

Fri, Jun 7, 7:16 AM · Restricted Project, Restricted Project
jsji accepted D61658: [PowerPC] Emit XXSEL for vec_sel and code that has the same pattern.
Fri, Jun 7, 7:10 AM · Restricted Project
jsji added a comment to D61658: [PowerPC] Emit XXSEL for vec_sel and code that has the same pattern.

LGTM. Thanks for fixing!

Fri, Jun 7, 7:10 AM · Restricted Project

Thu, Jun 6

jsji added a comment to D62345: [MachineScheduler] checkResourceLimit boundary condition update.

Ping.. Any more comments and feedback @javed.absar . Thanks.

Thu, Jun 6, 7:17 PM · Restricted Project

Tue, Jun 4

jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Sure, I will have a look when I am back from vacation.

Tue, Jun 4, 9:17 PM · Restricted Project
jsji added a comment to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Thanks for catching this.

Tue, Jun 4, 12:14 PM · Restricted Project
jsji updated the diff for D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Update return code for Zero count.

Tue, Jun 4, 12:13 PM · Restricted Project
jsji added inline comments to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Tue, Jun 4, 10:33 AM · Restricted Project
jsji updated the diff for D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Remove the assert(0).

Tue, Jun 4, 10:32 AM · Restricted Project
jsji committed rG3144d7a2daa3: [PowerPC] P9 Scheduling Model: dispatching rule fixes (authored by jsji).
[PowerPC] P9 Scheduling Model: dispatching rule fixes
Tue, Jun 4, 8:20 AM
jsji committed rL362509: [PowerPC] P9 Scheduling Model: dispatching rule fixes.
[PowerPC] P9 Scheduling Model: dispatching rule fixes
Tue, Jun 4, 8:19 AM
jsji closed D61873: [PowerPC] P9 Scheduling Model: dispatching rule fixes.
Tue, Jun 4, 8:19 AM · Restricted Project
jsji updated the diff for D61873: [PowerPC] P9 Scheduling Model: dispatching rule fixes.

Rebased to ToT.

Tue, Jun 4, 8:00 AM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Doesn't look like a correct pattern update to me.

Tue, Jun 4, 7:06 AM · Restricted Project
jsji added inline comments to rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power.
Tue, Jun 4, 6:54 AM

Mon, Jun 3

jsji added inline comments to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Mon, Jun 3, 8:21 PM · Restricted Project
jsji updated the diff for D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Update TII interface to pass down preheader, and find mtctr in preheader only.

Mon, Jun 3, 8:19 PM · Restricted Project
jsji added inline comments to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Mon, Jun 3, 12:37 PM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

TEST 'LLVM :: CodeGen/PowerPC/htm.ll' is still failing
llc -verify-machineinstrs -mcpu=pwr8 -mattr=+htm < llvm/test/CodeGen/PowerPC/htm.ll | llvm/build/bin/FileCheck llvm/test/CodeGen/PowerPC/htm.ll

Mon, Jun 3, 11:07 AM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Tests are still running on my computer

Mon, Jun 3, 8:45 AM · Restricted Project
jsji requested changes to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Testcase is failing... Have you run test before updating the revision?

Mon, Jun 3, 8:13 AM · Restricted Project

Fri, May 31

jsji committed rG18e7bf5c4dcb: [MachinePipeliner][NFC] Add some debug log and statistics (authored by jsji).
[MachinePipeliner][NFC] Add some debug log and statistics
Fri, May 31, 8:35 AM
jsji committed rL362233: [MachinePipeliner][NFC] Add some debug log and statistics.
[MachinePipeliner][NFC] Add some debug log and statistics
Fri, May 31, 8:32 AM
jsji closed D62165: [MachinePipeliner][NFC] Add some debug log and statistics.
Fri, May 31, 8:32 AM · Restricted Project

Thu, May 30

jsji accepted D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC.

LGTM. Thanks for fixing.

Thu, May 30, 8:44 PM · Restricted Project, Restricted Project
jsji added a comment to D62345: [MachineScheduler] checkResourceLimit boundary condition update.

Would this end up prioritising 'resourcelimited' too much? Looks like there can be performance differences between before and after this change - any numbers / thoughts on that?

Thu, May 30, 7:33 PM · Restricted Project
jsji requested changes to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Please make sure you build and test before updating patch. Thanks.

Thu, May 30, 2:21 PM · Restricted Project
jsji added inline comments to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Thu, May 30, 9:00 AM · Restricted Project

Wed, May 29

jsji updated the diff for D62345: [MachineScheduler] checkResourceLimit boundary condition update.

Fix comment & repeated computation. Performance run still ongoing.

Wed, May 29, 2:00 PM · Restricted Project
jsji added inline comments to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Wed, May 29, 1:26 PM · Restricted Project
jsji updated the diff for D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Use worklist instead, and fix comments.

Wed, May 29, 1:26 PM · Restricted Project
jsji requested changes to D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC.
******************** TEST 'Clang :: CodeGen/ppc-mm-malloc.c' FAILED ********************
Script:
--
: 'RUN: at line 9';   /home/buildslave/buildslave1a/clang-with-lto-ubuntu/build/stage1/bin/clang -S -emit-llvm /home/buildslave/buildslave1a/clang-with-lto-ubuntu/llvm.src/tools/clang/test/CodeGen/ppc-mm-malloc.c -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt | /home/buildslave/buildslave1a/clang-with-lto-ubuntu/build/stage1/bin/FileCheck /home/buildslave/buildslave1a/clang-with-lto-ubuntu/llvm.src/tools/clang/test/CodeGen/ppc-mm-malloc.c
--
Exit Code: 1
Wed, May 29, 6:47 AM · Restricted Project, Restricted Project
jsji reopened D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC.

This has been reverted in https://reviews.llvm.org/rL361930 .

Wed, May 29, 6:47 AM · Restricted Project, Restricted Project
jsji added a comment to rL361927: Inline a variable into debug section to fix unused variable warning..

Thanks Richard! @rtrieu

Wed, May 29, 6:40 AM

Tue, May 28

jsji added inline comments to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Tue, May 28, 9:20 PM · Restricted Project
jsji added a comment to rL361924: Inline value into debug statement to avoid unused variable warning..

Thanks Richard. @rtrieu !

Tue, May 28, 9:09 PM
jsji added a comment to D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.

Ping.. The machine independent part has been committed. Thanks. @bcahoon

Tue, May 28, 8:10 PM · Restricted Project
jsji committed rGf6cb3bcb4ccb: Support resource tracking with InstrSchedModel (authored by jsji).
Support resource tracking with InstrSchedModel
Tue, May 28, 8:01 PM
jsji committed rL361919: Support resource tracking with InstrSchedModel.
Support resource tracking with InstrSchedModel
Tue, May 28, 8:00 PM
jsji closed D62163: [MachinePipeliner] Support resource tracking with InstrSchedModel.
Tue, May 28, 8:00 PM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Thanks, almost good. A few more instructions and test maybe.

Tue, May 28, 7:38 PM · Restricted Project
jsji accepted D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC.

LGTM. Thanks for porting.

Tue, May 28, 7:33 PM · Restricted Project, Restricted Project

Fri, May 24

jsji added a comment to D62345: [MachineScheduler] checkResourceLimit boundary condition update.

Would this end up prioritising 'resourcelimited' too much? Looks like there can be performance differences between before and after this change - any numbers / thoughts on that?

Fri, May 24, 6:21 AM · Restricted Project

Thu, May 23

jsji created D62345: [MachineScheduler] checkResourceLimit boundary condition update.
Thu, May 23, 2:18 PM · Restricted Project
jsji added a comment to D61873: [PowerPC] P9 Scheduling Model: dispatching rule fixes.

Ping.. Anyone has comments and feedback? Thanks.

Thu, May 23, 9:31 AM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

BTW: You should create the patch with "full diff" when submitting to Phabricator. See https://llvm.org/docs/Phabricator.html

Thu, May 23, 9:30 AM · Restricted Project
jsji accepted D61930: [Power9] Add a specific heuristic to schedule the addi before the load.

LGTM.

Thu, May 23, 9:20 AM · Restricted Project
jsji updated subscribers of D62132: [RFC] Intrinsics for Hardware Loops.
Thu, May 23, 7:14 AM

Mon, May 20

jsji added a parent revision for D62165: [MachinePipeliner][NFC] Add some debug log and statistics: D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Mon, May 20, 2:58 PM · Restricted Project
jsji added a child revision for D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner: D62165: [MachinePipeliner][NFC] Add some debug log and statistics.
Mon, May 20, 2:58 PM · Restricted Project
jsji created D62165: [MachinePipeliner][NFC] Add some debug log and statistics.
Mon, May 20, 2:58 PM · Restricted Project
jsji added a parent revision for D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner: D62163: [MachinePipeliner] Support resource tracking with InstrSchedModel.
Mon, May 20, 2:55 PM · Restricted Project
jsji added a child revision for D62163: [MachinePipeliner] Support resource tracking with InstrSchedModel: D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Mon, May 20, 2:55 PM · Restricted Project
jsji created D62164: [PowerPC] Enable MachinePipeliner for P9 with -ppc-enable-pipeliner.
Mon, May 20, 2:55 PM · Restricted Project
jsji created D62163: [MachinePipeliner] Support resource tracking with InstrSchedModel.
Mon, May 20, 2:52 PM · Restricted Project
jsji added inline comments to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.
Mon, May 20, 11:57 AM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Is this ok ?
Did I pick the right file ?
How do I run these tests ?

Mon, May 20, 11:35 AM · Restricted Project
jsji updated subscribers of D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC.

Add more subscribers, reviews and comments are welcome and appreciated. Thanks.

Mon, May 20, 7:20 AM · Restricted Project, Restricted Project

May 16 2019

jsji requested changes to D61930: [Power9] Add a specific heuristic to schedule the addi before the load.

I think we should update the title or summary to indicate that this is P9 only.

May 16 2019, 3:00 PM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

You can have a look at llvm/test/MC/Disassembler/PowerPC

May 16 2019, 12:07 PM · Restricted Project

May 15 2019

jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

@catenacyber Can you please include a testcase for MC please?

May 15 2019, 2:26 PM · Restricted Project

May 14 2019

jsji updated subscribers of D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

Some more nit-picker, other than that, mostly good to me.

May 14 2019, 8:00 AM · Restricted Project

May 13 2019

jsji committed rGb7b3d866a402: [PowerPC][NFC] Fix typos in triples (authored by jsji).
[PowerPC][NFC] Fix typos in triples
May 13 2019, 8:11 PM
jsji committed rL360643: [PowerPC][NFC] Fix typos in triples.
[PowerPC][NFC] Fix typos in triples
May 13 2019, 8:11 PM