Page MenuHomePhabricator
Feed Advanced Search

Wed, Jul 1

HsiangKai added a comment to D81214: [RISCV] Add vector instructions for FPR64..

FPR32 version V instructions should be enough for CodeGen.

Wed, Jul 1, 9:42 AM · Restricted Project
HsiangKai abandoned D81214: [RISCV] Add vector instructions for FPR64..
Wed, Jul 1, 9:42 AM · Restricted Project

Tue, Jun 30

HsiangKai committed rGa7b0f391852b: [MVT] Add new MVT types for RISC-V vector. (authored by HsiangKai).
[MVT] Add new MVT types for RISC-V vector.
Tue, Jun 30, 10:20 AM
HsiangKai closed D81724: [MVT] Add new MVT types for RISC-V vector..
Tue, Jun 30, 10:20 AM · Restricted Project

Mon, Jun 29

HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..

Update patch with full context.

Mon, Jun 29, 10:32 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..

Correct instructions validation according to v0.9 spec.

Mon, Jun 29, 10:32 PM · Restricted Project, Restricted Project
HsiangKai removed a parent revision for D80802: [RISCV] Upgrade RVV MC to v0.9.: D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Mon, Jun 29, 10:32 PM · Restricted Project, Restricted Project
HsiangKai removed a child revision for D69987: [RISCV] Assemble/Disassemble v-ext instructions.: D80802: [RISCV] Upgrade RVV MC to v0.9..
Mon, Jun 29, 10:32 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..

Rebase on master.

Mon, Jun 29, 7:47 PM · Restricted Project, Restricted Project

Sat, Jun 27

HsiangKai committed rG66da87dcbaf9: [RISCV] Assemble/Disassemble v-ext instructions. (authored by HsiangKai).
[RISCV] Assemble/Disassemble v-ext instructions.
Sat, Jun 27, 11:27 PM
HsiangKai committed rGd698ff92a59c: [RISCV] Support experimental v extensions. (authored by HsiangKai).
[RISCV] Support experimental v extensions.
Sat, Jun 27, 11:27 PM
HsiangKai closed D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Sat, Jun 27, 11:27 PM · Restricted Project, Restricted Project
HsiangKai closed D81188: [RISCV] Support experimental v extensions..
Sat, Jun 27, 11:27 PM · Restricted Project

Thu, Jun 25

HsiangKai added a reviewer for D81724: [MVT] Add new MVT types for RISC-V vector.: fpallares.
Thu, Jun 25, 9:40 AM · Restricted Project
HsiangKai added a reviewer for D81214: [RISCV] Add vector instructions for FPR64.: fpallares.
Thu, Jun 25, 9:40 AM · Restricted Project
HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..

Simplify the logic of validateInstruction() in RISCVAsmParser.cpp.

Thu, Jun 25, 9:40 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..

Address @fpallares's comments.

Thu, Jun 25, 9:07 AM · Restricted Project, Restricted Project
HsiangKai added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Thu, Jun 25, 8:00 AM · Restricted Project, Restricted Project
HsiangKai added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Thu, Jun 25, 8:00 AM · Restricted Project, Restricted Project

Fri, Jun 19

HsiangKai updated the diff for D81724: [MVT] Add new MVT types for RISC-V vector..

Add nxv1f16.

Fri, Jun 19, 2:39 AM · Restricted Project

Thu, Jun 18

HsiangKai updated the diff for D81724: [MVT] Add new MVT types for RISC-V vector..

Remove redundant types.

Thu, Jun 18, 12:30 AM · Restricted Project

Fri, Jun 12

HsiangKai added a reviewer for D81724: [MVT] Add new MVT types for RISC-V vector.: craig.topper.
Fri, Jun 12, 8:38 AM · Restricted Project
HsiangKai updated the diff for D81724: [MVT] Add new MVT types for RISC-V vector..
Fri, Jun 12, 8:37 AM · Restricted Project
HsiangKai added inline comments to D81724: [MVT] Add new MVT types for RISC-V vector..
Fri, Jun 12, 8:37 AM · Restricted Project
HsiangKai created D81724: [MVT] Add new MVT types for RISC-V vector..
Fri, Jun 12, 2:40 AM · Restricted Project

Tue, Jun 9

HsiangKai abandoned D79543: [RISCV] Enable 'undisturbed' semantics in instruction definitions..

I need to think about is it necessary to describe 'undisturbed' semantics in instruction definitions. Do not review it now.

Tue, Jun 9, 11:57 PM · Restricted Project

Jun 4 2020

HsiangKai added a parent revision for D81214: [RISCV] Add vector instructions for FPR64.: D80802: [RISCV] Upgrade RVV MC to v0.9..
Jun 4 2020, 8:23 PM · Restricted Project
HsiangKai added a child revision for D80802: [RISCV] Upgrade RVV MC to v0.9.: D81214: [RISCV] Add vector instructions for FPR64..
Jun 4 2020, 8:23 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Jun 4 2020, 8:23 PM · Restricted Project, Restricted Project
HsiangKai created D81214: [RISCV] Add vector instructions for FPR64..
Jun 4 2020, 7:51 PM · Restricted Project
HsiangKai added a parent revision for D81188: [RISCV] Support experimental v extensions.: D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Jun 4 2020, 7:51 PM · Restricted Project
HsiangKai added a child revision for D69987: [RISCV] Assemble/Disassemble v-ext instructions.: D81188: [RISCV] Support experimental v extensions..
Jun 4 2020, 7:51 PM · Restricted Project, Restricted Project
HsiangKai added a parent revision for D81213: [RISCV] Support experimental v extension v0.9.: D80802: [RISCV] Upgrade RVV MC to v0.9..
Jun 4 2020, 7:51 PM · Restricted Project
HsiangKai added a child revision for D80802: [RISCV] Upgrade RVV MC to v0.9.: D81213: [RISCV] Support experimental v extension v0.9..
Jun 4 2020, 7:51 PM · Restricted Project, Restricted Project
HsiangKai created D81213: [RISCV] Support experimental v extension v0.9..
Jun 4 2020, 7:51 PM · Restricted Project
HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..

Address @evandro's comments.

Jun 4 2020, 7:51 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Remove redundant RVVConstraint.

Jun 4 2020, 7:51 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D81188: [RISCV] Support experimental v extensions..

Address @MaskRay's comments.

Jun 4 2020, 7:51 PM · Restricted Project
HsiangKai added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Jun 4 2020, 7:19 PM · Restricted Project, Restricted Project
HsiangKai added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Drive-by comment: the clang side change isn't tightly coupled with the LLVM side changes. It should be a separate patch.

Jun 4 2020, 12:42 PM · Restricted Project, Restricted Project
HsiangKai created D81188: [RISCV] Support experimental v extensions..
Jun 4 2020, 12:42 PM · Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Jun 4 2020, 12:42 PM · Restricted Project, Restricted Project
HsiangKai added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Ping.

Jun 4 2020, 7:38 AM · Restricted Project, Restricted Project

May 30 2020

HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..
May 30 2020, 3:09 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..
May 30 2020, 2:37 AM · Restricted Project, Restricted Project

May 29 2020

HsiangKai added a parent revision for D80802: [RISCV] Upgrade RVV MC to v0.9.: D69987: [RISCV] Assemble/Disassemble v-ext instructions..
May 29 2020, 8:06 AM · Restricted Project, Restricted Project
HsiangKai added a child revision for D69987: [RISCV] Assemble/Disassemble v-ext instructions.: D80802: [RISCV] Upgrade RVV MC to v0.9..
May 29 2020, 8:06 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D80802: [RISCV] Upgrade RVV MC to v0.9..
May 29 2020, 8:06 AM · Restricted Project, Restricted Project
HsiangKai created D80802: [RISCV] Upgrade RVV MC to v0.9..
May 29 2020, 8:06 AM · Restricted Project, Restricted Project

May 28 2020

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Apply clang-format.

May 28 2020, 5:57 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Check operands for widening and narrowing instructions.
  • Modify according to @fpallares's comments.
May 28 2020, 2:07 AM · Restricted Project, Restricted Project

May 22 2020

HsiangKai accepted D80352: [RISCV] Register null target streamer for RISC-V.

LGTM.

May 22 2020, 1:49 AM · Restricted Project

May 21 2020

HsiangKai added a comment to D80352: [RISCV] Register null target streamer for RISC-V.

Use clang-format to format your commit.

May 21 2020, 1:36 AM · Restricted Project

May 20 2020

HsiangKai updated the summary of D69987: [RISCV] Assemble/Disassemble v-ext instructions..
May 20 2020, 3:27 PM · Restricted Project, Restricted Project
HsiangKai added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
May 20 2020, 2:53 PM · Restricted Project, Restricted Project
HsiangKai added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Update to version 0.8-draft-20191213.

May 20 2020, 7:34 AM · Restricted Project, Restricted Project

May 19 2020

HsiangKai added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Is this patch ready to land? Are there any comments or suggestions I missed?

May 19 2020, 11:02 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Fix clang-tidy warnings.

May 19 2020, 11:02 PM · Restricted Project, Restricted Project
HsiangKai added inline comments to D79543: [RISCV] Enable 'undisturbed' semantics in instruction definitions..
May 19 2020, 2:40 AM · Restricted Project

May 7 2020

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Rebase on master.

May 7 2020, 10:15 AM · Restricted Project, Restricted Project

May 6 2020

HsiangKai added a parent revision for D79543: [RISCV] Enable 'undisturbed' semantics in instruction definitions.: D69987: [RISCV] Assemble/Disassemble v-ext instructions..
May 6 2020, 7:53 PM · Restricted Project
HsiangKai added a child revision for D69987: [RISCV] Assemble/Disassemble v-ext instructions.: D79543: [RISCV] Enable 'undisturbed' semantics in instruction definitions..
May 6 2020, 7:53 PM · Restricted Project, Restricted Project
HsiangKai created D79543: [RISCV] Enable 'undisturbed' semantics in instruction definitions..
May 6 2020, 7:53 PM · Restricted Project

Apr 23 2020

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Refine naming.
  • Some typo.
Apr 23 2020, 2:06 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Address @simoncook's comments.
  • Reorder instructions according to "V" specification.
  • Add pseudo instructions in "V" specification.
  • Add comments in RISCVInstrInfoV.td
  • "V" implies "F".
Apr 23 2020, 1:34 AM · Restricted Project, Restricted Project

Apr 18 2020

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Apr 18 2020, 9:09 AM · Restricted Project, Restricted Project

Apr 2 2020

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Fix clang-format errors.
  • Rename variables according to LLVM Coding Standards.
Apr 2 2020, 6:27 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Rebase on master branch.
  • Fix validInstruction() bugs.
  • Update test cases.
Apr 2 2020, 6:28 AM · Restricted Project, Restricted Project

Apr 1 2020

HsiangKai committed rG501522b5b2a1: [RISCV] Support RISC-V ELF attributes sections in llvm-readobj. (authored by HsiangKai).
[RISCV] Support RISC-V ELF attributes sections in llvm-readobj.
Apr 1 2020, 7:08 AM
HsiangKai closed D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Apr 1 2020, 7:08 AM · Restricted Project
HsiangKai updated the diff for D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Apr 1 2020, 5:30 AM · Restricted Project
HsiangKai updated the diff for D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Apr 1 2020, 2:16 AM · Restricted Project
HsiangKai updated the diff for D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.

Use reportError() to handle error messages.

Apr 1 2020, 12:30 AM · Restricted Project

Mar 31 2020

HsiangKai committed rG581ba35291a6: [RISCV] ELF attribute section for RISC-V. (authored by HsiangKai).
[RISCV] ELF attribute section for RISC-V.
Mar 31 2020, 1:37 AM
HsiangKai closed D74023: [RISCV] ELF attribute section for RISC-V.
Mar 31 2020, 1:37 AM · Restricted Project, Restricted Project

Mar 30 2020

HsiangKai added inline comments to D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Mar 30 2020, 8:46 PM · Restricted Project
HsiangKai updated the diff for D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Mar 30 2020, 7:00 AM · Restricted Project
HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.
Mar 30 2020, 4:50 AM · Restricted Project, Restricted Project
HsiangKai added inline comments to D74023: [RISCV] ELF attribute section for RISC-V.
Mar 30 2020, 4:50 AM · Restricted Project, Restricted Project
HsiangKai added a comment to D74023: [RISCV] ELF attribute section for RISC-V.

The code generally looks good. For unittests, I think we can either make llvm-readobj -A canonical or the unittests canonical. If we decide to place tests on one place, we should delete most tests on the other side.

My current preference is that we use more of unittests and leave the minimum to test/llvm-readobj/ELF/{ARM,RISCV}/

Mar 30 2020, 12:30 AM · Restricted Project, Restricted Project

Mar 28 2020

HsiangKai added a comment to D74023: [RISCV] ELF attribute section for RISC-V.

@MaskRay, do you have any other comments about this patch?

Mar 28 2020, 6:48 PM · Restricted Project, Restricted Project

Mar 26 2020

HsiangKai committed rG1a6b7318dddd: [NFC] Clang format for the ELF header and ARM build attributes. (authored by HsiangKai).
[NFC] Clang format for the ELF header and ARM build attributes.
Mar 26 2020, 7:03 PM
HsiangKai closed D76819: [NFC] Apply clang-format to the ELF header and ARM build attributes files..
Mar 26 2020, 7:02 PM · Restricted Project
HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.
Mar 26 2020, 4:50 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Mar 26 2020, 4:50 AM · Restricted Project
HsiangKai added inline comments to D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Mar 26 2020, 3:12 AM · Restricted Project
HsiangKai added inline comments to D74023: [RISCV] ELF attribute section for RISC-V.
Mar 26 2020, 2:07 AM · Restricted Project, Restricted Project

Mar 25 2020

HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.

Rebase on D76819.

Mar 25 2020, 7:30 PM · Restricted Project, Restricted Project
HsiangKai added a parent revision for D74023: [RISCV] ELF attribute section for RISC-V: D76819: [NFC] Apply clang-format to the ELF header and ARM build attributes files..
Mar 25 2020, 7:30 PM · Restricted Project, Restricted Project
HsiangKai added a child revision for D76819: [NFC] Apply clang-format to the ELF header and ARM build attributes files.: D74023: [RISCV] ELF attribute section for RISC-V.
Mar 25 2020, 7:30 PM · Restricted Project
HsiangKai added a comment to D74023: [RISCV] ELF attribute section for RISC-V.

I create a patch, D76819, to apply clang-format to the ELF header file and ARM build attributes files.

Mar 25 2020, 7:30 PM · Restricted Project, Restricted Project
HsiangKai created D76819: [NFC] Apply clang-format to the ELF header and ARM build attributes files..
Mar 25 2020, 6:59 PM · Restricted Project
HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.
Mar 25 2020, 5:21 PM · Restricted Project, Restricted Project
HsiangKai added a comment to D74023: [RISCV] ELF attribute section for RISC-V.

Harbormaster result:

Unit tests pass. 64040 tests passed, 0 failed and 650 were skipped.
clang-tidy fail. clang-tidy found 1 errors and 18 warnings. 0 of them are added as review comments why?.
clang-format fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch.

These errors are caused by formatting in ELF.h, ARMBuildAttributes.h, and ARMBuildAttrs.cpp. Although they are located in the same files this patch modified, they are not related to this patch. These errors could be ignored.

Mar 25 2020, 3:11 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.
Mar 25 2020, 9:09 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Mar 25 2020, 6:59 AM · Restricted Project
HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.

Fix Harbormaster test failures.

Mar 25 2020, 6:59 AM · Restricted Project, Restricted Project

Mar 24 2020

HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.

Rebase on master.

Mar 24 2020, 11:25 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj.
Mar 24 2020, 6:57 AM · Restricted Project
HsiangKai updated the diff for D74023: [RISCV] ELF attribute section for RISC-V.
Mar 24 2020, 6:57 AM · Restricted Project, Restricted Project