Fri, Jun 18
Wed, Jun 16
Thu, Jun 10
Wed, Jun 9
Remove broken-by-design force-ifcvt.ll test.
Tue, Jun 8
Wed, Jun 2
Not too deep into the YAML world, so just my two cents re the isLineBreak function.
May 24 2021
May 21 2021
Sadly don't have stdibc++11 available locally as well.. so can't verify, but looks good to me except for the push and pop macros.
May 14 2021
Incorporate review of the test and document the behavior in Passes.rst.
May 7 2021
Also, would it make sense to un-hide and document the flag now, given it actually is useful now?
Add test for the filtering with -dot-cfg and -dot-cfg-only. As far as I see it, the view variant is not really testable. Happy to be proved wrong, though. :)
Landed and added to release blockers for 12.0.1
May 6 2021
mhh... I'd just say the assert was wrong.
The BaseIndent is the maximum width of an option. e.g. --compilation-database=<string>.
printEnumValHelpStr does not deal with that part at all, only with the help string that comes after that (e.g. This is the first enum value\nwhich has a really long description\nthus it is multi-line.).
For nice formatting in the first line - and are prepended for the enum values in the first line and later BaseIndent + are used for the indent.
What the assert should have verified is only that BaseIndent >= FirstLineIndentedBy so that we can later have the indent: BaseIndent - FirstLineIndentedBy and be sure it's >=0.
(and that really should always be true..)
Feb 4 2021
Feb 3 2021
Jan 27 2021
Given the awful formatting in clang-format is merged in release/12.x, would be great to get this in, before 12.0.0 final.. :)
Jan 26 2021
Add print option info test for multiline value descriptions.
Jan 12 2021
Happy new year's ping :)
Dec 22 2020
Dec 18 2020
Fix naming to make clang-tidy happy.
Dec 17 2020
This is manually well formatted.. will try to make a new patch in the coming days to actually fix it in the support library.
Add lit test to ensure behaviour of the -Wno-error=unkown flag.
Quoting my questions from the other review, as it should be more appropriate to discuss this here:
I can reproduce the issue, but not sure what introduced this.
Oct 29 2020
Thanks, will land it later.
Add missing macro definitions.
Sep 21 2020
Sep 19 2020
Sep 18 2020
Okay, I requested commit access.
So the patch is fine with you from a clang-format perspective?
Fix the nit :)
Anyone with access may commit this now (ideally ofc someone with a final opinion on the clang-format part).
Sep 15 2020
All comments should be adressed now.
Unit test cleanups.
Sep 12 2020
Address review comments, copy the help text into docs and add some basic unit tests.
Sep 8 2020
Remove test entry form .clang-format :)
Incorporating review comments:
- renaming option to -Wno-error=unknown and adding warning in description
- emit warnings instead of fully ignoring the issues
Sep 7 2020
Thank you so far for the feedback!
maybe you can give further guidance on the comments on the comments :)
Sep 5 2020
I see the possible issue with the possible version mismatches and that is why I'd make people opt-in for this option, to still being able to format their files (e.g. if using out-dated built-in versions like in Visual Studio - I know you can specify your own binary) but the real formatting can be done with a pre-commit script or similar, where the new options are actually supported.