Page MenuHomePhabricator
Feed Advanced Search

Mon, Mar 29

wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

Updated this patch according to my previous comment. Would you mind taking another look, @fhahn and @nikic ? Thanks!

Mon, Mar 29, 6:33 PM · Restricted Project
wecing added a reviewer for D93927: [ArgPromotion] Copy !range metadata for loads.: nikic.
Mon, Mar 29, 6:32 PM · Restricted Project
wecing updated the diff for D93927: [ArgPromotion] Copy !range metadata for loads..

Conditionally copy most metadata info.

Mon, Mar 29, 6:30 PM · Restricted Project

Fri, Mar 26

wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

We were already transfering the AA metadata, which is also incorrect.

Fri, Mar 26, 5:45 PM · Restricted Project
wecing added a comment to rG4622648a069a: Revert "[ArgPromotion] Copy additional metadata for loads.".

LGTM

Fri, Mar 26, 1:37 PM
wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

Sorry about the inconveniences, @tejohnson. I am fine with rolling this back, but since I do not have write access to the repo, @fhahn, would you like to roll it back?

Fri, Mar 26, 1:31 PM · Restricted Project

Mar 12 2021

wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

Please use "Chenguang Wang" and w3cing[at]gmail.com. Thank you @fhahn!

Mar 12 2021, 3:46 PM · Restricted Project
wecing updated the diff for D93927: [ArgPromotion] Copy !range metadata for loads..
  • add test for !dereferenceable
  • check metadata objects after optimization
Mar 12 2021, 3:45 PM · Restricted Project

Mar 11 2021

wecing added inline comments to D93927: [ArgPromotion] Copy !range metadata for loads..
Mar 11 2021, 3:37 PM · Restricted Project
wecing updated the diff for D93927: [ArgPromotion] Copy !range metadata for loads..

update test cases:

Mar 11 2021, 3:36 PM · Restricted Project

Mar 10 2021

wecing updated the diff for D93927: [ArgPromotion] Copy !range metadata for loads..

Only copy seleted metadata.

Mar 10 2021, 10:02 PM · Restricted Project

Feb 12 2021

wecing added inline comments to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Feb 12 2021, 10:25 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
  • add wrapper method for caching
Feb 12 2021, 10:23 PM · Restricted Project

Feb 11 2021

wecing added inline comments to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Feb 11 2021, 3:23 PM · Restricted Project

Feb 5 2021

wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

diff against main branch

Feb 5 2021, 9:28 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Avoid redundant map indexing.

Feb 5 2021, 9:27 PM · Restricted Project
wecing added a comment to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

ping... PTAL, @jdoerfert

Feb 5 2021, 3:21 PM · Restricted Project
wecing added a comment to D93888: [GVN] If zext X == N or sext X == N, then X == trunc N..

@lebedev.ri do you think we could go with D93850?

Feb 5 2021, 3:18 PM · Restricted Project

Jan 25 2021

wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

ping.

Jan 25 2021, 9:55 PM · Restricted Project
wecing added a comment to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

ping.

Jan 25 2021, 9:55 PM · Restricted Project

Jan 15 2021

wecing added a comment to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Sorry about the commit spam.

Jan 15 2021, 9:43 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

update comment

Jan 15 2021, 9:37 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

remove unused cast

Jan 15 2021, 9:34 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

remove unused include

Jan 15 2021, 8:03 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

include all commits.

Jan 15 2021, 5:24 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Include more commits.

Jan 15 2021, 5:23 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Update implementation to use local cache and add unit tests.

Jan 15 2021, 5:20 PM · Restricted Project
wecing updated the summary of D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Jan 15 2021, 5:20 PM · Restricted Project

Jan 14 2021

wecing added reviewers for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint: spatel, jdoerfert.
Jan 14 2021, 5:05 PM · Restricted Project
wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

ping -- @fhahn , does the new change look reasonable to you?

Jan 14 2021, 5:00 PM · Restricted Project

Jan 7 2021

wecing updated the diff for D93927: [ArgPromotion] Copy !range metadata for loads..

Copy all metadata.

Jan 7 2021, 4:38 PM · Restricted Project
wecing abandoned D94276: copy all metadata.
Jan 7 2021, 4:37 PM · Restricted Project
wecing requested review of D94276: copy all metadata.
Jan 7 2021, 4:36 PM · Restricted Project

Jan 6 2021

wecing added a comment to D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.

Ping.

Jan 6 2021, 4:36 PM · Restricted Project
wecing added a comment to D93927: [ArgPromotion] Copy !range metadata for loads..

Ping.

Jan 6 2021, 4:35 PM · Restricted Project
wecing added a comment to D93888: [GVN] If zext X == N or sext X == N, then X == trunc N..

For NewGVN and IPSCCP PredicateInfo would have to handle it, and I'm pretty sure we want to avoid that.

@nikic Would you mind explaining why? If there is a good reason we cannot do this in NewGVN then D93850 might be the best we could do.

Jan 6 2021, 4:30 PM · Restricted Project

Dec 29 2020

wecing requested review of D93927: [ArgPromotion] Copy !range metadata for loads..
Dec 29 2020, 5:06 PM · Restricted Project

Dec 28 2020

wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

@lebedev.ri , I made another patch by changing only GVN -- please take a look at D93888. If it could be approved, I will close this PR ("diff"?).

Dec 28 2020, 11:33 PM · Restricted Project
wecing added a comment to D93888: [GVN] If zext X == N or sext X == N, then X == trunc N..

I am very confused why NewGVN doesn't seem to propagate switch condition values: https://godbolt.org/z/9a9P51. Some guidance on porting this to NewGVN would be appreciated!

Dec 28 2020, 11:30 PM · Restricted Project
wecing requested review of D93888: [GVN] If zext X == N or sext X == N, then X == trunc N..
Dec 28 2020, 11:26 PM · Restricted Project
wecing added a reviewer for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint: courbet.
Dec 28 2020, 3:22 PM · Restricted Project
wecing updated the summary of D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Dec 28 2020, 2:57 PM · Restricted Project
wecing updated the diff for D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Dec 28 2020, 2:48 PM · Restricted Project
wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

@lebedev.ri , here is what GVN does for the current output, and this is the new behavior. Note that the first one does

Dec 28 2020, 1:47 PM · Restricted Project
wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

@lebedev.ri , which "hook" did you mean?

Dec 28 2020, 11:57 AM · Restricted Project
wecing added inline comments to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..
Dec 28 2020, 11:32 AM · Restricted Project

Dec 27 2020

wecing added a comment to D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..

Here is a longer example showing the improvements of this change:

Dec 27 2020, 10:21 PM · Restricted Project
wecing added a reviewer for D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X).: spatel.
Dec 27 2020, 9:55 PM · Restricted Project
wecing requested review of D93850: [InstCombine] Rewrite (switch (zext X)) as (switch X)..
Dec 27 2020, 9:53 PM · Restricted Project

Dec 10 2014

wecing retitled D6594: Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint from to Fix for bug 8281 - Extremely slow assembling and disassembling of ptrtoint.
Dec 10 2014, 3:44 PM · Restricted Project