Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Rin added inline comments to D106561: [AArch64] Optimise min/max lowering in ISel.
Mon, Jul 26, 8:06 AM · Restricted Project
Rin updated the diff for D106561: [AArch64] Optimise min/max lowering in ISel.

Address review comments

Mon, Jul 26, 8:06 AM · Restricted Project
Rin added inline comments to D106561: [AArch64] Optimise min/max lowering in ISel.
Mon, Jul 26, 5:51 AM · Restricted Project
Rin added inline comments to D106561: [AArch64] Optimise min/max lowering in ISel.
Mon, Jul 26, 4:56 AM · Restricted Project

Thu, Jul 22

Rin updated the summary of D106561: [AArch64] Optimise min/max lowering in ISel.
Thu, Jul 22, 8:26 AM · Restricted Project
Rin requested review of D106561: [AArch64] Optimise min/max lowering in ISel.
Thu, Jul 22, 8:25 AM · Restricted Project

Thu, Jul 15

Rin committed rG831ee6b0c38b: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max (authored by Rin).
[AArch64][GlobalISel] Optimise lowering for some vector types for min/max
Thu, Jul 15, 3:35 AM
Rin closed D105696: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max.
Thu, Jul 15, 3:35 AM · Restricted Project

Tue, Jul 13

Rin updated the diff for D105696: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max.

Add FIXME comment

Tue, Jul 13, 7:39 AM · Restricted Project

Mon, Jul 12

Rin updated the diff for D105696: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max.

Make min-max.ll test global-isel

Mon, Jul 12, 7:03 AM · Restricted Project
Rin updated the diff for D105696: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max.

clang-format

Mon, Jul 12, 6:08 AM · Restricted Project
Rin updated the diff for D105696: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max.

Add optimisation for vXi16 and vXi8 vector types

Mon, Jul 12, 6:08 AM · Restricted Project

Fri, Jul 9

Rin updated the summary of D105696: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max.
Fri, Jul 9, 5:58 AM · Restricted Project
Rin requested review of D105696: [AArch64][GlobalISel] Optimise lowering for some vector types for min/max.
Fri, Jul 9, 5:56 AM · Restricted Project

Wed, Jul 7

Rin committed rG5888a194c104: [AArch64][GlobalISel] Lower vector types for min/max (authored by Rin).
[AArch64][GlobalISel] Lower vector types for min/max
Wed, Jul 7, 7:34 AM
Rin closed D105433: [AArch64][GlobalISel] Lower vector types for min/max.
Wed, Jul 7, 7:34 AM · Restricted Project
Rin updated the diff for D105433: [AArch64][GlobalISel] Lower vector types for min/max.

Address review comments

Wed, Jul 7, 1:28 AM · Restricted Project
Rin added inline comments to D105433: [AArch64][GlobalISel] Lower vector types for min/max.
Wed, Jul 7, 1:07 AM · Restricted Project

Mon, Jul 5

Rin added reviewers for D105433: [AArch64][GlobalISel] Lower vector types for min/max: aemerson, paquette.
Mon, Jul 5, 7:29 AM · Restricted Project
Rin updated the summary of D105433: [AArch64][GlobalISel] Lower vector types for min/max.
Mon, Jul 5, 7:11 AM · Restricted Project
Rin requested review of D105433: [AArch64][GlobalISel] Lower vector types for min/max.
Mon, Jul 5, 7:10 AM · Restricted Project

Thu, Jul 1

Rin committed rG71d5b0a75720: [AArch64][GlobalISel]Legalise some vector types for min/max (authored by Rin).
[AArch64][GlobalISel]Legalise some vector types for min/max
Thu, Jul 1, 8:53 AM
Rin closed D105200: [AArch64][GlobalISel]Legalise some vector types for min/max.
Thu, Jul 1, 8:52 AM · Restricted Project
Rin committed rGcf76569f6a61: [AArch64] Add test for min/max (authored by Rin).
[AArch64] Add test for min/max
Thu, Jul 1, 5:23 AM
Rin closed D104447: [AArch64] Add test for min/max.
Thu, Jul 1, 5:23 AM · Restricted Project
Rin updated the diff for D104447: [AArch64] Add test for min/max.

Fix tests

Thu, Jul 1, 4:26 AM · Restricted Project
Rin added a comment to D104447: [AArch64] Add test for min/max.

It's probably good to add them for all the types, even if just for consistency. So for umax/smax/smin too.

Thu, Jul 1, 4:11 AM · Restricted Project
Rin updated the diff for D104447: [AArch64] Add test for min/max.

Add v2i64 testcase

Thu, Jul 1, 3:50 AM · Restricted Project
Rin updated the diff for D105200: [AArch64][GlobalISel]Legalise some vector types for min/max.

Run the verifier

Thu, Jul 1, 2:07 AM · Restricted Project
Rin added a comment to D104447: [AArch64] Add test for min/max.

It would be good to keep the v2i64 case I think, it is very similar to v1i64.

Thu, Jul 1, 1:04 AM · Restricted Project

Wed, Jun 30

Rin added inline comments to D105200: [AArch64][GlobalISel]Legalise some vector types for min/max.
Wed, Jun 30, 9:50 AM · Restricted Project
Rin updated the summary of D105200: [AArch64][GlobalISel]Legalise some vector types for min/max.
Wed, Jun 30, 8:42 AM · Restricted Project
Rin requested review of D105200: [AArch64][GlobalISel]Legalise some vector types for min/max.
Wed, Jun 30, 8:41 AM · Restricted Project

Jun 17 2021

Rin updated the diff for D104447: [AArch64] Add test for min/max.

Remove v2i64 test case.

Jun 17 2021, 6:25 AM · Restricted Project
Rin updated the summary of D104447: [AArch64] Add test for min/max.
Jun 17 2021, 4:48 AM · Restricted Project
Rin requested review of D104447: [AArch64] Add test for min/max.
Jun 17 2021, 4:48 AM · Restricted Project

Jun 10 2021

Rin committed rGde79919e9ec9: [AArch64] Add cost tests for bitreverse (authored by Rin).
[AArch64] Add cost tests for bitreverse
Jun 10 2021, 7:20 AM
Rin closed D102755: [AArch64] Add cost tests for bitreverse.
Jun 10 2021, 7:20 AM · Restricted Project
Rin added inline comments to D102755: [AArch64] Add cost tests for bitreverse.
Jun 10 2021, 2:47 AM · Restricted Project
Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Address review comment

Jun 10 2021, 2:47 AM · Restricted Project

Jun 9 2021

Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Address nit comment

Jun 9 2021, 6:13 AM · Restricted Project
Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Remove unused typed from cost model table

Jun 9 2021, 5:52 AM · Restricted Project
Rin added inline comments to D102755: [AArch64] Add cost tests for bitreverse.
Jun 9 2021, 5:27 AM · Restricted Project
Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Address review comments

Jun 9 2021, 4:40 AM · Restricted Project
Rin added a comment to D102755: [AArch64] Add cost tests for bitreverse.

Hey @Rin,
I don't think you need bitreverse-cost-model.ll, you can use only bitreverse.ll.
Why some costs are not being changed in bitreverse.ll?

Jun 9 2021, 2:31 AM · Restricted Project

Jun 7 2021

Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Add adequate costs for bitreverse operations

Jun 7 2021, 4:50 AM · Restricted Project

Jun 2 2021

Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.
Jun 2 2021, 7:35 AM · Restricted Project
Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

Since this change LLVM :: Analysis/CostModel/AArch64/bitreverse.ll is failing.

https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/5/logs/FAIL__LLVM__bitreverse_ll

In case it's not just a forgotten test (didn't fail in buildkite which is odd), you can find the config used here https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/3/logs/stdio.

Jun 2 2021, 7:04 AM · Restricted Project
Rin committed rGff6fe93f2196: [AArch64][NFC] Fix failing cost-model test (authored by Rin).
[AArch64][NFC] Fix failing cost-model test
Jun 2 2021, 7:01 AM
Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

If it takes a while to fix, can we revert this in the meantime to get the bots back to green?

Jun 2 2021, 6:53 AM · Restricted Project
Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

Since this change LLVM :: Analysis/CostModel/AArch64/bitreverse.ll is failing.

https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/5/logs/FAIL__LLVM__bitreverse_ll

In case it's not just a forgotten test (didn't fail in buildkite which is odd), you can find the config used here https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/3/logs/stdio.

Jun 2 2021, 6:11 AM · Restricted Project
Rin committed rGe971099a9b9b: [AArch64] Optimise bitreverse lowering in ISel (authored by Rin).
[AArch64] Optimise bitreverse lowering in ISel
Jun 2 2021, 4:51 AM
Rin closed D103105: [AArch64] Optimise bitreverse lowering in ISel.
Jun 2 2021, 4:51 AM · Restricted Project

Jun 1 2021

Rin updated the diff for D103105: [AArch64] Optimise bitreverse lowering in ISel.

Address review comments

Jun 1 2021, 4:18 AM · Restricted Project
Rin added inline comments to D103105: [AArch64] Optimise bitreverse lowering in ISel.
Jun 1 2021, 12:53 AM · Restricted Project

May 26 2021

Rin added inline comments to D103105: [AArch64] Optimise bitreverse lowering in ISel.
May 26 2021, 5:57 AM · Restricted Project
Rin updated the diff for D103105: [AArch64] Optimise bitreverse lowering in ISel.

Add optimisation for v2i32 and v1i64 bitreverse lowering and respond to review comments

May 26 2021, 5:56 AM · Restricted Project
Rin added inline comments to D103105: [AArch64] Optimise bitreverse lowering in ISel.
May 26 2021, 3:44 AM · Restricted Project

May 25 2021

Rin updated the summary of D103105: [AArch64] Optimise bitreverse lowering in ISel.
May 25 2021, 11:27 AM · Restricted Project
Rin requested review of D103105: [AArch64] Optimise bitreverse lowering in ISel.
May 25 2021, 11:24 AM · Restricted Project

May 19 2021

Rin updated the summary of D102755: [AArch64] Add cost tests for bitreverse.
May 19 2021, 3:02 AM · Restricted Project
Rin requested review of D102755: [AArch64] Add cost tests for bitreverse.
May 19 2021, 2:54 AM · Restricted Project

May 17 2021

Rin committed rG50511df32edf: [AArch64] Lower bitreverse in ISel (authored by Rin).
[AArch64] Lower bitreverse in ISel
May 17 2021, 5:40 AM
Rin closed D102397: [AArch64] Lower bitreverse in ISel.
May 17 2021, 5:40 AM · Restricted Project, Restricted Project

May 14 2021

Rin updated the diff for D102397: [AArch64] Lower bitreverse in ISel.

Add AutoUpgrade test and move bitreverse lowering

May 14 2021, 9:37 AM · Restricted Project, Restricted Project
Rin updated the diff for D102397: [AArch64] Lower bitreverse in ISel.

Remove unnecessary comment and add more bitreverse tests

May 14 2021, 5:36 AM · Restricted Project, Restricted Project

May 13 2021

Rin added a reviewer for D102397: [AArch64] Lower bitreverse in ISel: SjoerdMeijer.
May 13 2021, 6:07 AM · Restricted Project, Restricted Project
Rin updated the summary of D102397: [AArch64] Lower bitreverse in ISel.
May 13 2021, 6:03 AM · Restricted Project, Restricted Project
Rin requested review of D102397: [AArch64] Lower bitreverse in ISel.
May 13 2021, 5:59 AM · Restricted Project, Restricted Project

Dec 18 2020

Rin added inline comments to D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the summary of D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.

Remove unnecessary comments

Dec 18 2020, 8:58 AM · Restricted Project, Restricted Project, Restricted Project
Rin retitled D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive from Add Fortran Specific Semantic Checks for Allocate Directive to [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 8:56 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the summary of D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 8:55 AM · Restricted Project, Restricted Project, Restricted Project
Rin requested review of D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 8:54 AM · Restricted Project, Restricted Project, Restricted Project
Rin commandeered D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:48 AM · Restricted Project, Restricted Project
Rin changed the edit policy for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:46 AM · Restricted Project, Restricted Project
Rin changed the edit policy for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:45 AM · Restricted Project, Restricted Project
Rin added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 3:53 AM · Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Remove unnecessary global variables and add variable check and test for ExecutableAllocateDirective case

Dec 18 2020, 3:45 AM · Restricted Project, Restricted Project

Dec 14 2020

Rin added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 14 2020, 9:53 AM · Restricted Project, Restricted Project

Dec 11 2020

Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Get rid of conflicts

Dec 11 2020, 8:40 AM · Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Get rid of conflicts

Dec 11 2020, 6:17 AM · Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Rebase with Parser for Allocate Directive patch

Dec 11 2020, 4:46 AM · Restricted Project, Restricted Project

Dec 10 2020

Rin committed rGc9e967af3fc7: [flang]Add Parser Support for Allocate Directive (authored by Rin).
[flang]Add Parser Support for Allocate Directive
Dec 10 2020, 8:25 AM
Rin closed D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 10 2020, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Add comment

Dec 10 2020, 4:37 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 10 2020, 2:10 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Add DeclarativeAllocateDirective as a list within the ExecutableAllocateDirective construct

Dec 8 2020, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 8 2020, 8:36 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 8 2020, 8:25 AM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2020

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 7 2020, 2:29 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Remove white spaces

Dec 7 2020, 2:29 AM · Restricted Project, Restricted Project, Restricted Project

Dec 3 2020

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 3 2020, 6:14 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 3 2020, 6:13 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Order Enter clase function in alphabetical order

Dec 1 2020, 4:22 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 1 2020, 2:37 AM · Restricted Project, Restricted Project, Restricted Project

Nov 26 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Remove unnecessary node

Nov 26 2020, 9:03 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2020

Rin updated the summary of D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Nov 25 2020, 3:22 AM · Restricted Project, Restricted Project
Rin updated the summary of D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Nov 25 2020, 3:14 AM · Restricted Project, Restricted Project