Page MenuHomePhabricator
Feed Advanced Search

Yesterday

eopXD updated the diff for D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.

Fix some clang-format.

Wed, Jun 23, 9:20 PM · Restricted Project

Tue, Jun 22

eopXD added a comment to D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.

Accidentally marked done, undone-ed it.
No bad intentions there.

Tue, Jun 22, 2:57 AM · Restricted Project
eopXD added a comment to D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.

Thank you @lebedev.ri and @xbolva00 for leaving comments.
I would follow up with benchmarks of the patch.

Tue, Jun 22, 2:40 AM · Restricted Project
eopXD updated the diff for D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.

Make testcase more precise to optimization this patch provides.

Tue, Jun 22, 2:27 AM · Restricted Project

Mon, Jun 21

eopXD added inline comments to D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.
Mon, Jun 21, 5:55 AM · Restricted Project
eopXD updated subscribers of D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.

Why is this beneficial?

Mon, Jun 21, 5:50 AM · Restricted Project
eopXD added reviewers for D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size: Whitney, fhahn, lebedev.ri.
Mon, Jun 21, 5:40 AM · Restricted Project
eopXD requested review of D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.
Mon, Jun 21, 5:38 AM · Restricted Project
eopXD added a comment to D104631: [LoopVersioning] add function to create versioned loop with plain runtime check.

User may need to create versioned loops of such structure and append more runtime checks conditions to the branch instruction.

Mon, Jun 21, 3:44 AM · Restricted Project
eopXD added reviewers for D104631: [LoopVersioning] add function to create versioned loop with plain runtime check: Whitney, fhahn, Ayal.
Mon, Jun 21, 3:43 AM · Restricted Project
eopXD requested review of D104631: [LoopVersioning] add function to create versioned loop with plain runtime check.
Mon, Jun 21, 3:41 AM · Restricted Project
eopXD added a reviewer for D104620: [LoopVersioning] Add utility to fetch the runtime check basic block: Whitney.
Mon, Jun 21, 1:42 AM · Restricted Project
eopXD added a comment to D104620: [LoopVersioning] Add utility to fetch the runtime check basic block.
Mon, Jun 21, 1:03 AM · Restricted Project
eopXD updated the diff for D104620: [LoopVersioning] Add utility to fetch the runtime check basic block.

Update the code.

Mon, Jun 21, 12:25 AM · Restricted Project
eopXD requested review of D104620: [LoopVersioning] Add utility to fetch the runtime check basic block.
Mon, Jun 21, 12:24 AM · Restricted Project

Sat, Jun 19

eopXD added reviewers for D104595: [NFC] [LoopIdiom] Let processLoopStridedStore able to take SCEV as Store Size: Whitney, qianzhen, fhahn.
Sat, Jun 19, 7:29 AM · Restricted Project
eopXD requested review of D104595: [NFC] [LoopIdiom] Let processLoopStridedStore able to take SCEV as Store Size.
Sat, Jun 19, 7:26 AM · Restricted Project

Sun, Jun 13

eopXD added a comment to D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass.

Following patches will utilize the LoopNest structure for more efficient optimization.

Would it be possible to provide some data on the efficiency improvements?

Hi @fhahn ,
For example, given a perfectly nested loop-pair and we have matched a store operation that we can hoist to the inner-loop's header as strided store operations,
we can further check on the outer-loop, see if the outer-loop SCEV maintains the continuous memory access and hoist the operation one more loop outwards.

Ah I see, so you are planning to add additional optimizations based on LoopNest? If so, I think it would also be good to share a patch that makes implements such an additional optimization so there's a clear path towards concrete improvements and it would also show why using LoopNest is needed/beneficial.

Sun, Jun 13, 5:55 AM · Restricted Project
eopXD updated the diff for D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass.

fix some clang-format

Sun, Jun 13, 2:38 AM · Restricted Project

Sat, Jun 12

eopXD updated the diff for D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass.

fix some clang-format

Sat, Jun 12, 9:14 AM · Restricted Project
eopXD added a comment to D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass.

Following patches will utilize the LoopNest structure for more efficient optimization.

Would it be possible to provide some data on the efficiency improvements?

Sat, Jun 12, 6:12 AM · Restricted Project
eopXD updated the summary of D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass.
Sat, Jun 12, 5:48 AM · Restricted Project
eopXD added a reviewer for D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass: Whitney.
Sat, Jun 12, 5:44 AM · Restricted Project
eopXD requested review of D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass.
Sat, Jun 12, 5:43 AM · Restricted Project

Fri, May 28

eopXD committed rGfa488ea864ab: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass (authored by eopXD).
[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass
Fri, May 28, 8:43 AM
eopXD closed D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
Fri, May 28, 8:43 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Remove declaration of LoopUnrollAndJam as a FunctionPass.

Fri, May 28, 8:33 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Rebase code to main.

Fri, May 28, 8:14 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Resolve merge conflict correctly. (previously caused build fail)

Fri, May 28, 7:43 AM · Restricted Project
eopXD updated the summary of D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 1:24 AM · Restricted Project
eopXD updated the summary of D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 1:23 AM · Restricted Project
eopXD added a comment to D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".

@lebedev.ri I apologize for the unclear descriptions.

Fri, May 28, 1:15 AM · Restricted Project
eopXD added a comment to D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".

Reverted the change in the origin diff: https://reviews.llvm.org/D102904

Fri, May 28, 1:09 AM · Restricted Project
eopXD added a reverting change for rG7952ddb21fb7: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: rGe96d6f4821bf: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 1:07 AM
eopXD committed rGe96d6f4821bf: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass" (authored by eopXD).
Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass"
Fri, May 28, 1:07 AM
eopXD added a reverting change for rGffc4d3e06855: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: rG7e06cf8f1ba2: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 1:07 AM
eopXD added a reverting change for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: rGe96d6f4821bf: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 1:07 AM · Restricted Project
eopXD committed rG7e06cf8f1ba2: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass" (authored by eopXD).
Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass"
Fri, May 28, 1:07 AM
eopXD closed D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 1:07 AM · Restricted Project
eopXD added a reverting change for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: rG7e06cf8f1ba2: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 1:06 AM · Restricted Project
eopXD added a reverting change for rG7952ddb21fb7: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 12:58 AM
eopXD added a reverting change for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 12:58 AM · Restricted Project
eopXD requested review of D103302: Revert "[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass".
Fri, May 28, 12:58 AM · Restricted Project
eopXD reopened D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
Fri, May 28, 12:27 AM · Restricted Project
eopXD committed rGffc4d3e06855: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass (authored by eopXD).
[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass
Fri, May 28, 12:26 AM
eopXD closed D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
Fri, May 28, 12:26 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Reverting my commit to investigate for build failure.

Fri, May 28, 12:25 AM · Restricted Project
eopXD reopened D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
Fri, May 28, 12:25 AM · Restricted Project
eopXD committed rG7952ddb21fb7: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass (authored by eopXD).
[LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass
Fri, May 28, 12:11 AM
eopXD closed D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
Fri, May 28, 12:11 AM · Restricted Project

Tue, May 25

eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

remove redundant header added.

Tue, May 25, 8:35 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

remove redundant dependencies.

Tue, May 25, 8:33 AM · Restricted Project
eopXD added a comment to D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

@Whitney : do we need these 3 new dependencies?

Tue, May 25, 7:54 AM · Restricted Project

May 24 2021

eopXD added a comment to D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

We can remove the LPMUpdater again if it's not needed/used?

May 24 2021, 9:00 PM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

address comments.

May 24 2021, 8:53 PM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

remove redundant LPMUpdater parameter.

May 24 2021, 7:43 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
  1. revert change for LPMUpdater::markLoopAsDeleted, remove the call also.
  2. iterate through Loops and record top-level loops for legacy LoopFlattenPass, a seperate for-loop is called because LoopFlatten may affect the range.
May 24 2021, 7:37 AM · Restricted Project
eopXD updated subscribers of D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

@Whitney : Can you please explain why should revisitCurrentLoop?

May 24 2021, 7:33 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

added LPMUpdater for loop removal,
updated LPMUpdater::markLoopAsDeleted, allow sub-loop to be deleted in LoopNestMode.

May 24 2021, 3:06 AM · Restricted Project
eopXD added a comment to D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

D99149 ended up needing to use the LPMUpdater as the loops may be removed. Does the same thing need to be done here? As loop flattening does inherently remove loops.

May 24 2021, 1:53 AM · Restricted Project

May 23 2021

eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Added new lines at end of file,
also removed the redundant header I added.

May 23 2021, 10:53 PM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

more recoveries from clang-format.

May 23 2021, 10:44 PM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

revert the changes caused by clang-format.

May 23 2021, 10:41 PM · Restricted Project

May 22 2021

eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

address comments.

May 22 2021, 12:48 AM · Restricted Project
eopXD abandoned D102965: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass.

Accidentally opened a new diff. Diff should be updated to https://reviews.llvm.org/D102904

May 22 2021, 12:42 AM · Restricted Project
eopXD requested review of D102965: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass.
May 22 2021, 12:41 AM · Restricted Project

May 21 2021

eopXD updated the summary of D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 21 2021, 11:28 AM · Restricted Project
eopXD added a reviewer for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: Whitney.
May 21 2021, 11:28 AM · Restricted Project
eopXD updated the summary of D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 21 2021, 2:50 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Reset update on files.

May 21 2021, 2:50 AM · Restricted Project
eopXD removed reviewers for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: andreadb, alexshap, shafik, rupprecht, jdoerfert, jhenderson, sstefan1, nicolasvasilache, herhut, rriddle, aartbik, sscalpone, ftynse, aaron.ballman, baziotis, int3, sjarus, gkm, Restricted Project, Restricted Project, Restricted Project.
May 21 2021, 2:43 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Apply clang-tidy.

May 21 2021, 2:41 AM · Restricted Project
eopXD retitled D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass from [LoopNest] Change LoopFlattenPass to LoopNest pass to [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 21 2021, 2:02 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Utilize LoopNest in Flatten, this shall eliminate repeating calls to FlattenLoopPair

May 21 2021, 1:35 AM · Restricted Project
eopXD updated the diff for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

Apply clang-format.

May 21 2021, 1:24 AM · Restricted Project
eopXD requested review of D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 21 2021, 12:53 AM · Restricted Project

May 1 2021

eopXD added a comment to D101691: [mlir] [affine] add canonicalization for affine.vector_load, vector_store.

Formats fixed, thanks for reviewing.
I don't have the access to commit to llvm, so may you help me to do it?

Done. (I fixed a minor whitespace issue in canonicalize.mlir at line #920 before committing.)

May 1 2021, 11:09 PM · Unknown Object (Project)
eopXD added a comment to D101691: [mlir] [affine] add canonicalization for affine.vector_load, vector_store.

Formats fixed, thanks for reviewing.
I don't have the access to commit to llvm, so may you help me to do it?

May 1 2021, 7:54 AM · Unknown Object (Project)
eopXD updated the diff for D101691: [mlir] [affine] add canonicalization for affine.vector_load, vector_store.

Fix format warnings.

May 1 2021, 7:51 AM · Unknown Object (Project)
eopXD edited reviewers for D101691: [mlir] [affine] add canonicalization for affine.vector_load, vector_store, added: bondhugula; removed: nicolasvasilache.
May 1 2021, 7:33 AM · Unknown Object (Project)
eopXD added a comment to D101691: [mlir] [affine] add canonicalization for affine.vector_load, vector_store.

I've also added canonicalizeMapAndOperands into SimplifyAffineOp, this will let maps be canonicalized, allowing the maps operations to be folded into the operand.

May 1 2021, 7:32 AM · Unknown Object (Project)
eopXD requested review of D101691: [mlir] [affine] add canonicalization for affine.vector_load, vector_store.
May 1 2021, 7:29 AM · Unknown Object (Project)

Apr 11 2021

eopXD updated the diff for D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

[mlir][affine] Fix unfolded bounding maps for affine.for

Apr 11 2021, 7:47 PM · Unknown Object (Project)
eopXD updated the diff for D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

Cherry-pick commit to upstream main.

Apr 11 2021, 7:43 PM · Unknown Object (Project)

Apr 7 2021

eopXD added a comment to D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

Hi @bondhugula,
I am trying to rebase with $ git rebase origin/main with the current HEAD on my patching commit.
Then I encountered merge conflicts of file:

Apr 7 2021, 11:17 AM · Unknown Object (Project)

Apr 5 2021

eopXD added a comment to D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

@bondhugula I am not able to commit this.
Please help me to commit, thank you.

Apr 5 2021, 7:10 PM · Unknown Object (Project)

Apr 2 2021

eopXD updated the summary of D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.
Apr 2 2021, 8:43 AM · Unknown Object (Project)

Mar 26 2021

eopXD added a comment to D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

Yes the comments are all done.
Thank you for the comments.

Mar 26 2021, 2:45 AM · Unknown Object (Project)

Mar 25 2021

eopXD updated the diff for D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

Adjust testcase to include lower bound composition,
also adjusted testcase to avoid numbered SSA.

Mar 25 2021, 9:13 PM · Unknown Object (Project)
eopXD added a reviewer for D99323: [mlir][affine] Fix unfolded bounding maps for affine.for: bondhugula.
Mar 25 2021, 4:09 AM · Unknown Object (Project)
eopXD updated the diff for D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

[mlir][affine][test] Check if affine.for has bounding maps composed

Mar 25 2021, 4:05 AM · Unknown Object (Project)
eopXD abandoned D99327: [mlir][affine][test] Check if affine.for has bounding maps composed.
Mar 25 2021, 3:25 AM · Unknown Object (Project)
eopXD requested review of D99327: [mlir][affine][test] Check if affine.for has bounding maps composed.
Mar 25 2021, 3:24 AM · Unknown Object (Project)
eopXD updated the diff for D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.

revert to 1st commit of this bug fix.

Mar 25 2021, 3:14 AM · Unknown Object (Project)
eopXD updated the diff for D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.
Mar 25 2021, 2:48 AM · Unknown Object (Project)
eopXD abandoned D99325: [mlir][affine][test] Check if affine.for has bounding maps composed.

This commit shall be added under https://reviews.llvm.org/D99323

Mar 25 2021, 2:39 AM · Unknown Object (Project)
eopXD requested review of D99325: [mlir][affine][test] Check if affine.for has bounding maps composed.
Mar 25 2021, 2:37 AM · Unknown Object (Project)
eopXD updated the summary of D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.
Mar 25 2021, 1:50 AM · Unknown Object (Project)
eopXD updated the summary of D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.
Mar 25 2021, 1:48 AM · Unknown Object (Project)
eopXD requested review of D99323: [mlir][affine] Fix unfolded bounding maps for affine.for.
Mar 25 2021, 1:46 AM · Restricted Project