Page MenuHomePhabricator
Feed Advanced Search

Mar 1 2022

gmh5225 added a comment to D102817: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 2.

Code below will cause a crash.

 void
 parse()
{
    throw std::exception("throw--------");
    return;
}
Mar 1 2022, 12:32 AM · Restricted Project, Restricted Project

Feb 23 2022

gmh5225 added a comment to D102817: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 2.
Feb 23 2022, 10:31 AM · Restricted Project, Restricted Project

Jan 1 2022

gmh5225 updated the diff for D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl"..

clang-foramt

Jan 1 2022, 7:50 AM · Restricted Project, Restricted Project, lld
gmh5225 updated the diff for D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl"..

Only fix ".voltbl"

Jan 1 2022, 6:36 AM · Restricted Project, Restricted Project, lld
gmh5225 added a comment to D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl"..

This would need a test case for it to be commitable.

I don’t want the linker to blindly change the characteristics bits for any section that have the bits set to zero - if this is needed for a specific section in some case, then please limit the workaround to exactly that section name and nothing else. It would be good to give more context about what tool that produces such faulty sections, and ideally that tool would be fixed too. If possible, it could be good to limit the workaround to mingw mode, if that’s where this occurs.

Also, when uploading diffs, please create the diffs with extra context (git diff -U999).

Jan 1 2022, 5:33 AM · Restricted Project, Restricted Project, lld
gmh5225 requested review of D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl"..
Jan 1 2022, 5:03 AM · Restricted Project, Restricted Project, lld

Dec 31 2021

gmh5225 added a comment to D116358: Make lld to support win-xp.

Apologies for deceiving, but I think we aren't and we shouldn't be supporting Windows XP in LLVM. The OS is deprecated since 2009 and Microsoft ended all support in 2014. We don't even support Windows 7 officially. I think most of Windows-specific bindings in llvm/lib/Support/Windows/ assume Windows 8+ APIs. @mstorsjo @hans @rnk do have a different opinion?

@gmh5225 Are you able to run ninja check-all in several configurations, with -DLLVM_ENABLE_PROJECTS="lld;llvm" and a combination of several of those? -DCMAKE_BUILD_TYPE=Release or -DCMAKE_BUILD_TYPE=Debug, -DLLVM_ENABLE_ASSERTIONS=ON or -DLLVM_ENABLE_ASSERTIONS=OFF, -DCMAKE_C_COMPILER=clang-cl.exe -DCMAKE_CXX_COMPILER=clang-cl.exe -DCMAKE_LINKER=lld-link.exe or -DCMAKE_C_COMPILER=cl.exe -DCMAKE_CXX_COMPILER=cl.exe -DCMAKE_LINKER=link.exe.

Dec 31 2021, 10:08 PM · Restricted Project, lld

Dec 29 2021

gmh5225 added a member for lld: gmh5225.
Dec 29 2021, 10:31 PM
gmh5225 added a reviewer for D116358: Make lld to support win-xp: lld.
Dec 29 2021, 9:56 PM · Restricted Project, lld
gmh5225 edited reviewers for D116358: Make lld to support win-xp, added: MaskRay; removed: 01169957911, 01alchemist.
Dec 29 2021, 9:54 PM · Restricted Project, lld
gmh5225 abandoned D116335: Make lld to support win-xp.
Dec 29 2021, 5:02 AM · Restricted Project, lld
gmh5225 updated the diff for D116358: Make lld to support win-xp.

dos2unix

Dec 29 2021, 4:52 AM · Restricted Project, lld
gmh5225 updated the diff for D116358: Make lld to support win-xp.

dos2unix

Dec 29 2021, 3:19 AM · Restricted Project, lld

Dec 28 2021

gmh5225 requested review of D116358: Make lld to support win-xp.
Dec 28 2021, 9:57 PM · Restricted Project, lld
gmh5225 updated the diff for D116335: Make lld to support win-xp.

Fix subsystem.test

Dec 28 2021, 9:44 PM · Restricted Project, lld
gmh5225 updated the diff for D116335: Make lld to support win-xp.

fix subsystem.test

Dec 28 2021, 9:36 PM · Restricted Project, lld
gmh5225 updated the diff for D116335: Make lld to support win-xp.

Fix test manifest

Dec 28 2021, 7:54 PM · Restricted Project, lld
gmh5225 updated the diff for D116335: Make lld to support win-xp.

Fix test and re-upload.

Dec 28 2021, 4:28 PM · Restricted Project, lld
gmh5225 updated the diff for D116335: Make lld to support win-xp.

Re-upload diff

Dec 28 2021, 9:40 AM · Restricted Project, lld
gmh5225 requested review of D116335: Make lld to support win-xp.
Dec 28 2021, 8:40 AM · Restricted Project, lld