Page MenuHomePhabricator
Feed Advanced Search

Today

hans added a comment to D60935: [IndVarSimplify] Fixup nowrap flags during LFTR when moving to post-inc (PR31181).

Based on https://bugs.llvm.org/show_bug.cgi?id=31181#c9 it sounds like Sanjoy was the closest to a solution back then. Can you take a look?

Wed, Apr 24, 6:35 AM · Restricted Project
hans committed rC359081: Add 'REQUIRES: shell' to verbose-output-quoting.c.
Add 'REQUIRES: shell' to verbose-output-quoting.c
Wed, Apr 24, 3:10 AM
hans committed rL359081: Add 'REQUIRES: shell' to verbose-output-quoting.c.
Add 'REQUIRES: shell' to verbose-output-quoting.c
Wed, Apr 24, 3:10 AM
hans committed rL359077: Fix unquoted spaces in args in clang --verbose output.
Fix unquoted spaces in args in clang --verbose output
Wed, Apr 24, 2:04 AM
hans committed rC359077: Fix unquoted spaces in args in clang --verbose output.
Fix unquoted spaces in args in clang --verbose output
Wed, Apr 24, 2:04 AM
hans closed D60997: Fix unquoted spaces in args in clang --verbose output.
Wed, Apr 24, 2:04 AM · Restricted Project
hans accepted D61029: clang-cl: List valid values for /std: in /? output.

lgtm

Wed, Apr 24, 1:50 AM · Restricted Project

Yesterday

hans accepted D60997: Fix unquoted spaces in args in clang --verbose output.

Thanks for fixing!

Tue, Apr 23, 2:48 AM · Restricted Project

Thu, Apr 18

hans accepted D60627: [MSVC] Use the correct casing of HostX64/HostX86.

Looks good to me.

Thu, Apr 18, 4:50 AM · Restricted Project, Restricted Project

Wed, Apr 17

hans added a comment to D60800: [MS] Emit S_HEAPALLOCSITE debug info.

I don't really know about the functionality here, just adding a few comments on the code itself.

Wed, Apr 17, 10:00 AM · Restricted Project, Restricted Project
hans committed rC358570: clang-cl: Parse /openmp:experimental.
clang-cl: Parse /openmp:experimental
Wed, Apr 17, 3:04 AM
hans committed rL358570: clang-cl: Parse /openmp:experimental.
clang-cl: Parse /openmp:experimental
Wed, Apr 17, 3:04 AM
hans accepted D60728: [clang] [test] Add a (xfailing) test for PR41027.

What's the value in checking in this xfail'ed test without an actual fix for the problem?

Raise awareness about the problem.

Wed, Apr 17, 12:30 AM

Tue, Apr 16

hans accepted D60774: llvm-undname: Tweak arena allocator.

lgtm

Tue, Apr 16, 6:47 AM · Restricted Project
hans added a comment to D60728: [clang] [test] Add a (xfailing) test for PR41027.

What's the value in checking in this xfail'ed test without an actual fix for the problem?

Tue, Apr 16, 6:27 AM
hans added inline comments to D60771: llvm-undname: Add a -raw-input flag to pass a raw buffer to microsoftDemangle.
Tue, Apr 16, 6:01 AM · Restricted Project
hans accepted D60771: llvm-undname: Add a -raw-input flag to pass a raw buffer to microsoftDemangle.

lgtm

Tue, Apr 16, 5:42 AM · Restricted Project
hans committed rL358483: Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink….
Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Tue, Apr 16, 5:12 AM
hans committed rC358483: Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink….
Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink…
Tue, Apr 16, 5:12 AM
hans added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

Re-committed in r358483.

Tue, Apr 16, 5:11 AM · Restricted Project
hans added a comment to D60586: [Clang] Conversion of a switch table to a bitmap is not profitable for -Os and -Oz compilation.

I've replied on the LLVM side of the patch, https://reviews.llvm.org/D60584

Tue, Apr 16, 4:57 AM · Restricted Project
hans added a comment to D60584: Conversion of a switch table to a bitmap is not profitable for -Os and -Oz compilation.

First I was confused because your message mentions jump tables, but this is only about the switch-to-lookup table transformation in SimplifyCFG. So there are no jump tables involved, this is just about whether packing the lookup table into a "bitmap" scalar is a good idea or not.

Tue, Apr 16, 4:57 AM
hans committed rL358480: Win snapshot: r358402.
Win snapshot: r358402
Tue, Apr 16, 1:31 AM
hans added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

What are you thinking is best here? I agree that lifetime.end shouldn't prohibit optimisations. Do you think it's best to fix asan and go with this as-is, or to try and prevent sinking if it will only sink a lifetime.time?

Tue, Apr 16, 1:02 AM · Restricted Project
hans committed rL358478: Asan use-after-scope: don't poison allocas if there were untraced lifetime….
Asan use-after-scope: don't poison allocas if there were untraced lifetime…
Tue, Apr 16, 12:53 AM
hans closed D60686: Asan use-after-scope: don't poison allocas if there were untraced lifetime intrinsics in the function (PR41481).
Tue, Apr 16, 12:53 AM · Restricted Project
hans added a comment to D60686: Asan use-after-scope: don't poison allocas if there were untraced lifetime intrinsics in the function (PR41481).

LGTM
Consider extending the test with another alloca which does not participate in any untraceable lifetimes, but has to be poisoned in entry block anyway.

Tue, Apr 16, 12:33 AM · Restricted Project

Mon, Apr 15

hans committed rC358402: clang-format vs plugin: Visual Studio 2019 support.
clang-format vs plugin: Visual Studio 2019 support
Mon, Apr 15, 6:00 AM
hans committed rL358402: clang-format vs plugin: Visual Studio 2019 support.
clang-format vs plugin: Visual Studio 2019 support
Mon, Apr 15, 6:00 AM
hans created D60686: Asan use-after-scope: don't poison allocas if there were untraced lifetime intrinsics in the function (PR41481).
Mon, Apr 15, 4:42 AM · Restricted Project
hans accepted D60631: [Support] Fix recursive response file expansion guard.

Looks good to me.

Mon, Apr 15, 1:46 AM · Restricted Project
hans accepted D60630: [Support] Add a test for recursive response file expansion.

Looks good to me.

Mon, Apr 15, 1:46 AM · Restricted Project

Fri, Apr 12

hans committed rL358281: Revert r358268 "[DebugInfo] DW_OP_deref_size in PrologEpilogInserter.".
Revert r358268 "[DebugInfo] DW_OP_deref_size in PrologEpilogInserter."
Fri, Apr 12, 5:54 AM
hans added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).
In D59936#1454346, @dlj wrote:

This revision causes tests to fail under ASAN. After some investigation (with Chandler's help), it looks like the safest course of action is to revert. We're following up with Hans separately.

Reverted as r357667.

Thanks, and sorry for the breakage.

For my own notes, the internal bug tracker entry is 129905821. The V8 team also saw asan errors from ICU due to this, tracked in https://bugs.chromium.org/p/v8/issues/detail?id=9086 I'll try to investigate there to keep this in the open.

Fri, Apr 12, 5:16 AM · Restricted Project
hans committed rL358267: Fix missing arguments in tutorial.
Fix missing arguments in tutorial
Fri, Apr 12, 1:23 AM
hans closed D60369: Fix missing arguments in tutorial.
Fri, Apr 12, 1:23 AM · Restricted Project

Thu, Apr 11

hans accepted D60437: Add MM register mapping from CodeView to MC register id.

Okay, let's not worry too much about the test case, the patch seems obviously good.

Thu, Apr 11, 7:42 AM · Restricted Project
hans added a comment to D60437: Add MM register mapping from CodeView to MC register id.

I'm not familiar with the CodeView stuff, rnk is the better person for that, but would it be possible to add a test that exercises this mapping? Or to put it another way, what does this fix that's currently broken, and is it possible to add a test for it?

I try to add such test case, but I don't find any existing test case for mapping codeveiw register to MC register.
@rnk
Do you know if there is any reference test case in llvm/test code?

You can try removing a bunch of the entries in RegMap and see which tests fail. They're all in llvm/tests/DebugInfo/COFF/
I don't think there's any test for the mapping itself, but the tests rely on it to work.

That's what my second question was about: what is currently not working that your patch is fixing, and can that be used to write a test?

Thank you for the suggestion. I disable the code of xmm0 - xmm7 mapping and there is no case failure in llvm/tests/DebugInfo/COFF/. However when I disable general register (rax -r15), some of the test cases (.e.g test/DebugInfo/COFF/types-basic.ll) fail. There is pretty much code for the failed test case which I'm investigating. To create a small test case, we may need to cause much pressure on register allocator for mm0 - mm7 with __m64 variable in c code. However I have not figured out how to created such case.
Nevertheless, does anybody know why the mm0-mm7 registers are not mapped. Is there any reasons on it?

Thu, Apr 11, 6:41 AM · Restricted Project
hans added a comment to D60295: [SelectionDAG] Change the jump table size unit from entry to target.

I also don't see exactly how the semantics of max-jump-table-size are changed with this patch? What am I missing? Can you upload it again with more context maybe?

Look at llvm/include/llvm/CodeGen/TargetLowering.h below.

Thu, Apr 11, 5:47 AM · Restricted Project
hans added a comment to D60437: Add MM register mapping from CodeView to MC register id.

I'm not familiar with the CodeView stuff, rnk is the better person for that, but would it be possible to add a test that exercises this mapping? Or to put it another way, what does this fix that's currently broken, and is it possible to add a test for it?

I try to add such test case, but I don't find any existing test case for mapping codeveiw register to MC register.
@rnk
Do you know if there is any reference test case in llvm/test code?

Thu, Apr 11, 2:26 AM · Restricted Project
hans committed rL358156: try to fix the sphinx build some more.
try to fix the sphinx build some more
Thu, Apr 11, 12:50 AM
hans committed rLLD358155: Fix two sphinx warnings.
Fix two sphinx warnings
Thu, Apr 11, 12:30 AM
hans committed rL358155: Fix two sphinx warnings.
Fix two sphinx warnings
Thu, Apr 11, 12:29 AM
hans committed rL358154: Try to fix the shpinx build.
Try to fix the shpinx build
Thu, Apr 11, 12:29 AM

Wed, Apr 10

hans committed rC358087: clang-cl: Fix parsing of the /F option (PR41405).
clang-cl: Fix parsing of the /F option (PR41405)
Wed, Apr 10, 7:28 AM
hans committed rL358087: clang-cl: Fix parsing of the /F option (PR41405).
clang-cl: Fix parsing of the /F option (PR41405)
Wed, Apr 10, 7:28 AM
hans accepted D60369: Fix missing arguments in tutorial.

Thanks! This matches the code in llvm/examples/Kaleidoscope/Chapter8/toy.cpp

Wed, Apr 10, 6:03 AM · Restricted Project
hans added a comment to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..

I don't feel like I have enough background on what you're trying to do to review this. It sounds related to clangd issues maybe?

Wed, Apr 10, 5:58 AM · Restricted Project
hans added a reviewer for D60437: Add MM register mapping from CodeView to MC register id: rnk.

I'm not familiar with the CodeView stuff, rnk is the better person for that, but would it be possible to add a test that exercises this mapping? Or to put it another way, what does this fix that's currently broken, and is it possible to add a test for it?

Wed, Apr 10, 5:53 AM · Restricted Project

Tue, Apr 9

hans added a comment to D54439: CMake: Make most target symbols hidden by default.

Looks good to me.

Are there any buildbots that will catch if someone forgets to put an LLVM_EXTERNAL_VISIBILITY somewhere that's needed?

I don't think so. At least on linux this would require building with -DLLVM_BUILD_LLVM_DYLIB=ON and -DLLVM_LINK_LLVM_DYLIB=ON and I don't see any bots doing this.

Tue, Apr 9, 12:04 AM · Restricted Project

Fri, Apr 5

hans added a comment to D60295: [SelectionDAG] Change the jump table size unit from entry to target.

This patch changes the semantics of the options min-jump-table-entries and max-jump-table-size to use the number of different targets instead of the number of entries in a jump table. Thus, the are now renamed to min-jump-table-cases and max-jump-table-cases, respectively.

Fri, Apr 5, 7:58 AM · Restricted Project
hans accepted D54439: CMake: Make most target symbols hidden by default.

Looks good to me.

Fri, Apr 5, 2:45 AM · Restricted Project
hans committed rL357746: Update my gpg key.
Update my gpg key
Fri, Apr 5, 12:42 AM

Thu, Apr 4

hans added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).
In D59936#1454346, @dlj wrote:

This revision causes tests to fail under ASAN. After some investigation (with Chandler's help), it looks like the safest course of action is to revert. We're following up with Hans separately.

Reverted as r357667.

Thu, Apr 4, 12:52 AM · Restricted Project

Wed, Apr 3

hans committed rCXX357569: Revert "[libc++] Correctly handle Objective-C++ ARC qualifiers in std….
Revert "[libc++] Correctly handle Objective-C++ ARC qualifiers in std…
Wed, Apr 3, 3:06 AM
hans committed rL357569: Revert "[libc++] Correctly handle Objective-C++ ARC qualifiers in std….
Revert "[libc++] Correctly handle Objective-C++ ARC qualifiers in std…
Wed, Apr 3, 3:06 AM
hans added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

For the lifetime intrinsics, I don't think this really matters. As you say, it's good to do lifetime.end as soon as possible, so sinking them in general doesn't make sense, but I also don't think this matters much here because they can't be sunk very far, i.e. I don't see how this sinking could actually extend the lifetime.

Ok, yes I don't know, when I saw it it just worried me that perhaps intrinsics like lifetime.end was the "arbitrary" reason that we didn't allow to sink zero-use instructions before.

Wed, Apr 3, 2:19 AM · Restricted Project
hans added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

When looking at some code changes for my out-of-tree target with this commit I noticed a change that I thought I'd ask if you think
is good or not.

With this change we now seem to sink e.g. calls to @llvm.lifetime.end? It returns void, and thus has 0 uses, and as far as I understand
such calls were not sinked before? Is this on purpose and is that good? In general I guess it's good to do lifetime.end at soon as possible?

(And I suppose there are also a whole bunch of other intrinsics that also return void that can be sinked now, I've no idea if that
can cause problems somewhere?)

Wed, Apr 3, 1:29 AM · Restricted Project
hans added a comment to D59795: [DAGCombine] Improve Lifetime node chains..

This was reverted together with r357309 in r357563 as it caused
https://bugs.llvm.org/show_bug.cgi?id=41352

Wed, Apr 3, 12:47 AM · Restricted Project
hans committed rL357563: Revert r357256 "[DAGCombine] Improve Lifetime node chains.".
Revert r357256 "[DAGCombine] Improve Lifetime node chains."
Wed, Apr 3, 12:40 AM

Tue, Apr 2

hans committed rL357464: Win snapshot: r357435.
Win snapshot: r357435
Tue, Apr 2, 3:30 AM
hans committed rCRT357462: Fix tests after r357452.
Fix tests after r357452
Tue, Apr 2, 3:05 AM
hans committed rL357462: Fix tests after r357452.
Fix tests after r357452
Tue, Apr 2, 3:05 AM
hans committed rC357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without….
SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without…
Tue, Apr 2, 1:00 AM
hans committed rL357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without….
SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without…
Tue, Apr 2, 1:00 AM
hans closed D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).
Tue, Apr 2, 1:00 AM · Restricted Project
hans added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

Looks like a good improvement to me.

Tue, Apr 2, 12:59 AM · Restricted Project

Fri, Mar 29

hans committed rC357255: clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252).
clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)
Fri, Mar 29, 7:03 AM
hans committed rL357255: clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252).
clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)
Fri, Mar 29, 7:03 AM
hans committed rL357252: Switch lowering: exploit unreachable fall-through when lowering case range….
Switch lowering: exploit unreachable fall-through when lowering case range…
Fri, Mar 29, 6:39 AM
hans added a reviewer for D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259): bkramer.

Maybe Ben wants to take a look?

Fri, Mar 29, 2:13 AM · Restricted Project

Thu, Mar 28

hans updated the diff for D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

Checking that the instructions have the same number of uses. This passes a clang bootstrap build.

Thu, Mar 28, 9:30 AM · Restricted Project
hans added inline comments to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).
Thu, Mar 28, 8:22 AM · Restricted Project
hans created D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).
Thu, Mar 28, 7:56 AM · Restricted Project

Wed, Mar 27

hans committed rL357067: Re-commit r355490 "[CodeGen] Omit range checks from jump tables when lowering….
Re-commit r355490 "[CodeGen] Omit range checks from jump tables when lowering…
Wed, Mar 27, 7:10 AM

Mar 25 2019

hans committed rL356879: 8.0.0: Add ubuntu-14.04 binary.
8.0.0: Add ubuntu-14.04 binary
Mar 25 2019, 3:13 AM
hans committed rL356877: 8.0.0: powerpc64le binary.
8.0.0: powerpc64le binary
Mar 25 2019, 2:45 AM
hans committed rL356875: Fix the build with GCC 4.8 after r356783.
Fix the build with GCC 4.8 after r356783
Mar 25 2019, 2:27 AM

Mar 21 2019

hans committed rL356660: 8.0.0: Add AArch64 and ARMv7 binaries.
8.0.0: Add AArch64 and ARMv7 binaries
Mar 21 2019, 5:35 AM
hans committed rL356650: 8.0.0: Add Ubuntu and SLES binaries.
8.0.0: Add Ubuntu and SLES binaries
Mar 21 2019, 1:45 AM

Mar 20 2019

hans committed rL356544: Update links etc. for the 8.0.0 release.
Update links etc. for the 8.0.0 release
Mar 20 2019, 3:51 AM
hans committed rL356539: Check in the 8.0.0 release.
Check in the 8.0.0 release
Mar 20 2019, 2:14 AM

Mar 18 2019

hans added inline comments to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
Mar 18 2019, 2:49 AM · Restricted Project

Mar 15 2019

hans committed rL356240: Re-generate DiagnosticsReference.rst (PR41080).
Re-generate DiagnosticsReference.rst (PR41080)
Mar 15 2019, 1:45 AM

Mar 14 2019

hans committed rL356139: gn build: Merge r356080.
gn build: Merge r356080
Mar 14 2019, 5:23 AM
hans committed rL356128: gn build: Merge r356082.
gn build: Merge r356082
Mar 14 2019, 3:09 AM

Mar 13 2019

hans committed rL356034: ReleaseNotes: Changes to the JIT APIs; by Lang Hames.
ReleaseNotes: Changes to the JIT APIs; by Lang Hames
Mar 13 2019, 1:55 AM
hans committed rL356033: ReleaseNotes: fix sorting, spotted by Eugene Zelenko.
ReleaseNotes: fix sorting, spotted by Eugene Zelenko
Mar 13 2019, 1:48 AM

Mar 12 2019

hans committed rL355916: ReleaseNotes: SystemZ, by Ulrich Weigand..
ReleaseNotes: SystemZ, by Ulrich Weigand.
Mar 12 2019, 5:51 AM
hans committed rL355898: Merging r355743:.
Merging r355743:
Mar 12 2019, 1:28 AM
hans added a comment to D59201: [RegAllocHints] Avoid compile time regression.
In D59201#1424675, @dim wrote:

@hans it's really late but if you're going to spin 8.0.0 rc5, it would be nice if this one gets merged too, after it's been committed. Or if not, I'll probably merge into the FreeBSD version of clang anyway, since we hit this issue first. :)

Mar 12 2019, 1:16 AM

Mar 8 2019

hans added a comment to D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute..

LGTM, and I think this is safe enough to take for Clang 8.

Mar 8 2019, 10:11 AM · Restricted Project
hans committed rL355682: clang-cl : Parse all /d2 options.
clang-cl : Parse all /d2 options
Mar 8 2019, 2:00 AM
hans committed rC355682: clang-cl : Parse all /d2 options.
clang-cl : Parse all /d2 options
Mar 8 2019, 2:00 AM
hans committed rL355677: Merging r355489:.
Merging r355489:
Mar 8 2019, 1:27 AM
hans committed rL355675: Merging r352119:.
Merging r352119:
Mar 8 2019, 1:25 AM
hans committed rL355674: Merging r355491:.
Merging r355491:
Mar 8 2019, 1:15 AM
hans committed rL355673: Merging r354937:.
Merging r354937:
Mar 8 2019, 1:08 AM
hans committed rC355670: Add another test for r354937 that came up in PR40890.
Add another test for r354937 that came up in PR40890
Mar 8 2019, 1:00 AM
hans committed rL355670: Add another test for r354937 that came up in PR40890.
Add another test for r354937 that came up in PR40890
Mar 8 2019, 1:00 AM