Page MenuHomePhabricator
Feed Advanced Search

Apr 9 2021

naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
  • big-endian flag fix for GCC and Intel.
Apr 9 2021, 9:07 PM

Apr 7 2021

naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..

Was still missing earlier commits.

Apr 7 2021, 10:21 PM
naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..

Trying to send commits again.

Apr 7 2021, 9:57 PM
naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
  • Use GLOB in speccpu2017_run_specpp
  • Move common definitions and flags used by specpp into SpecCPU2017.cmake
  • Re-use speccpu2017_prepare_rundir
  • Number of minor fixes
  • Number of updates to comments
Apr 7 2021, 9:50 PM

Apr 5 2021

naromero77 added inline comments to D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
Apr 5 2021, 3:18 PM

Mar 30 2021

naromero77 added reviewers for D99640: [test-suite] SPEC2017 CPU pop2 floating point test.: Meinersbur, sameeranjoshi, rovka, fhahn.
Mar 30 2021, 10:54 PM
naromero77 requested review of D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
Mar 30 2021, 10:51 PM
naromero77 added a comment to D99619: [test-suite] Use forward-parsing when searching for numbers..

LGTM

Mar 30 2021, 9:11 PM
naromero77 added a comment to D99619: [test-suite] Use forward-parsing when searching for numbers..

Confirming that all tests are passing with clang/clang++.

Mar 30 2021, 9:11 PM
naromero77 accepted D99619: [test-suite] Use forward-parsing when searching for numbers..
Mar 30 2021, 2:36 PM
naromero77 added a comment to D99619: [test-suite] Use forward-parsing when searching for numbers..

Ran the entire test suite with GCC 10.2.0. For the record, there was one failure:

Mar 30 2021, 2:36 PM

Mar 12 2021

naromero77 committed rT01f5ea4052f0: [test-suite] SPEC2017 CPU CAM4 portability updates. (authored by naromero77).
[test-suite] SPEC2017 CPU CAM4 portability updates.
Mar 12 2021, 8:43 PM
naromero77 closed D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..
Mar 12 2021, 8:43 PM
naromero77 updated the diff for D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..

Trying again to send the patch.

Mar 12 2021, 11:30 AM
naromero77 updated the diff for D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..
  • Use standard convention for feature-test variables.
  • Only add CMake Utility Modules that are actually used.
Mar 12 2021, 11:28 AM

Mar 10 2021

naromero77 added reviewers for D98374: [test-suite] SPEC2017 CPU CAM4 portability updates.: jdoerfert, Meinersbur, fhahn, sameeranjoshi, rovka, homerdin.
Mar 10 2021, 3:01 PM
naromero77 requested review of D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..
Mar 10 2021, 2:59 PM

Mar 9 2021

naromero77 accepted D98260: [test-suite][SPEC2000] Use -fcommon instead of -zmultidef..

LGTM

Mar 9 2021, 11:59 AM
naromero77 added a comment to D98260: [test-suite][SPEC2000] Use -fcommon instead of -zmultidef..

Is there any negative impact to macOS X?

Mar 9 2021, 11:22 AM

Mar 2 2021

naromero77 committed rTeac0ed543746: [test-suite] Update .arcconfig to match LLVM. (authored by naromero77).
[test-suite] Update .arcconfig to match LLVM.
Mar 2 2021, 9:22 AM
naromero77 closed D97754: [test-suite] Update .arcconfig to match LLVM..
Mar 2 2021, 9:22 AM

Mar 1 2021

naromero77 committed rTa0411da701de: [test-suite] SPEC2017 CPU CAM4 floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU CAM4 floating point tests.
Mar 1 2021, 9:58 PM
naromero77 closed D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 9:58 PM
naromero77 updated the diff for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
  • Remove extraneous space.
Mar 1 2021, 9:33 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 9:30 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 9:29 PM
naromero77 added reviewers for D97754: [test-suite] Update .arcconfig to match LLVM.: jdoerfert, Meinersbur, fhahn, sameeranjoshi, rovka.
Mar 1 2021, 9:19 PM
naromero77 requested review of D97754: [test-suite] Update .arcconfig to match LLVM..
Mar 1 2021, 9:17 PM
naromero77 updated the diff for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
  • Use plain vanilla diff instead of specdiff.
  • Use target_compile_definitions instead.
  • Fix typo and clarify comment.
  • Remove redundant explicit dependencies.
Mar 1 2021, 8:26 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 2:45 PM

Feb 25 2021

naromero77 added reviewers for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests.: Meinersbur, sameeranjoshi, rovka, fhahn.
Feb 25 2021, 9:37 PM
naromero77 requested review of D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Feb 25 2021, 9:34 PM

Feb 24 2021

naromero77 committed rT37a356505b2a: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja. (authored by naromero77).
[test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.
Feb 24 2021, 11:59 AM
naromero77 closed D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 24 2021, 11:59 AM

Feb 23 2021

naromero77 updated the summary of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 23 2021, 8:13 PM
naromero77 updated the diff for D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
  • Get rid of redudant warning in top-level CMakeLists when Ninja is not used.
  • Improve line wrapping.
Feb 23 2021, 8:07 PM
naromero77 added inline comments to D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 23 2021, 9:05 AM

Feb 22 2021

naromero77 committed rT0b0305c689d9: [test-suite] Raise minimum required CMake version to match LLVM. (authored by naromero77).
[test-suite] Raise minimum required CMake version to match LLVM.
Feb 22 2021, 10:56 PM
naromero77 closed D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 10:56 PM
naromero77 updated the summary of D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 10:41 PM
naromero77 retitled D97248: [test-suite] Raise minimum required CMake version to match LLVM. from [test-suite] Raise minimum required CMake version to match llvm-project. to [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 10:40 PM
naromero77 added reviewers for D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.: Meinersbur, jdoerfert, sameeranjoshi, rovka, fhahn.
Feb 22 2021, 8:48 PM
naromero77 updated the summary of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 22 2021, 8:48 PM
naromero77 requested review of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 22 2021, 8:46 PM
naromero77 added reviewers for D97248: [test-suite] Raise minimum required CMake version to match LLVM.: jdoerfert, Meinersbur, rovka, sameeranjoshi, fhahn.
Feb 22 2021, 7:57 PM
naromero77 requested review of D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 7:54 PM

Feb 19 2021

naromero77 committed rT0e6fde52a15c: [test-suite] SPEC2017 CPU ROMS floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU ROMS floating point tests.
Feb 19 2021, 9:28 AM
naromero77 closed D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 19 2021, 9:28 AM

Feb 18 2021

naromero77 updated the diff for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
  • Improved warning message for CMAKE_GENERATOR.
Feb 18 2021, 8:49 PM

Feb 17 2021

naromero77 updated the summary of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 17 2021, 9:26 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

LLVM required cmake 3.13.4, I think we can bump the version for llvm-test-suite as well.

Feb 17 2021, 9:19 PM
naromero77 updated the diff for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
  • Run ROMS test out of run directory.
  • Revert "Helper macro for managing intermediate dependencies on Fortran modules."
  • Add warning about CMAKE_GENERATORS that are not Ninja.
  • Fix comment to reflect ROMS test.
  • Intermediate target dependencies are not needed when using Ninja.
Feb 17 2021, 9:17 PM

Feb 16 2021

naromero77 committed rT553e5905b7bc: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests. (authored by naromero77).
[test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests.
Feb 16 2021, 8:52 PM
naromero77 closed D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Feb 16 2021, 8:52 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

As far as I know, cmake detect module dependency itself, which would make speccpu2017_add_mod unnecessary.

I applied the patch locally and change the compilation part to just speccpu2017_add_executable() and it still compiles.

Feb 16 2021, 2:31 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

As far as I know, cmake detect module dependency itself, which would make speccpu2017_add_mod unnecessary.

It is not really clear from the CMake docs that it can figure out complex module dependencies without intermediary targets. Searching online, it looks like many Fortran-centric projects have come up with different solutions.

Feb 16 2021, 2:18 PM
naromero77 added reviewers for D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, rovka, fhahn.
Feb 16 2021, 1:15 PM
naromero77 updated subscribers of D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Feb 16 2021, 1:13 PM
naromero77 requested review of D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Feb 16 2021, 1:12 PM

Feb 15 2021

naromero77 added reviewers for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, fhahn, rovka.
Feb 15 2021, 9:54 PM
naromero77 retitled D96746: [test-suite] SPEC2017 CPU ROMS floating point tests. from Helper macro for managing intermediate dependencies on Fortran modules. to [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 15 2021, 9:49 PM
naromero77 updated subscribers of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 15 2021, 9:43 PM
naromero77 requested review of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 15 2021, 9:42 PM

Feb 10 2021

naromero77 added a comment to D96432: SPEC2006: Pronounce endianness flags both ways.

Thanks for catching this.

Feb 10 2021, 10:16 AM

Feb 9 2021

naromero77 committed rTefb2e01b23f0: [test-suite] SPEC2017 CPU Fotonik3d floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU Fotonik3d floating point tests.
Feb 9 2021, 8:46 PM
naromero77 closed D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 9 2021, 8:46 PM
naromero77 updated the diff for D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
  • Run specxz from tools bin.
Feb 9 2021, 3:06 PM

Feb 8 2021

naromero77 added inline comments to D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 8 2021, 9:20 AM

Feb 5 2021

naromero77 updated the diff for D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
  • Add missing TEST_SUITE_FORTRAN conditional.
  • Combine into a single verify_output.
Feb 5 2021, 9:27 PM
naromero77 added inline comments to D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 5 2021, 3:17 PM

Feb 4 2021

naromero77 added reviewers for D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, rovka, aemerson, tra, kristof.beyls, lenary, fhahn, cmatthews.
Feb 4 2021, 9:27 PM
naromero77 updated subscribers of D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 4 2021, 9:22 PM
naromero77 requested review of D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 4 2021, 9:20 PM

Feb 3 2021

naromero77 added inline comments to D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Feb 3 2021, 8:26 PM
naromero77 committed rT3a39afc9019c: [test-suite] SPEC2017 CPU CactuBSSN floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU CactuBSSN floating point tests.
Feb 3 2021, 8:22 PM
naromero77 closed D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Feb 3 2021, 8:22 PM
naromero77 updated the diff for D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..

With respect to origin/main.

Feb 3 2021, 12:41 PM
naromero77 updated the diff for D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
  • Use cleaner and more modern CMake.
Feb 3 2021, 12:38 PM

Feb 1 2021

naromero77 added a comment to D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..

Is someone available to review this patch?

Feb 1 2021, 10:41 AM

Jan 28 2021

naromero77 added reviewers for D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, rovka, aemerson, tra, kristof.beyls, lenary.
Jan 28 2021, 10:44 AM
naromero77 updated subscribers of D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Jan 28 2021, 10:40 AM
naromero77 requested review of D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Jan 28 2021, 10:39 AM

Jan 25 2021

naromero77 accepted D94945: ClangBuilder: Enable fortran in test-suite.
Jan 25 2021, 9:25 AM
naromero77 added a comment to D94945: ClangBuilder: Enable fortran in test-suite.

Thanks for adding Flang to the test suite.

Jan 25 2021, 8:29 AM

Jan 22 2021

naromero77 accepted D95276: [External][SPEC2000] Add -Wl,-zmultidef linker option..
Jan 22 2021, 9:02 PM
naromero77 added a comment to D95276: [External][SPEC2000] Add -Wl,-zmultidef linker option..

LGTM

Jan 22 2021, 9:02 PM
naromero77 committed rT1cae3ccc1db9: [test-suite] SPEC2017 CPU Bwaves floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU Bwaves floating point tests.
Jan 22 2021, 11:03 AM
naromero77 closed D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
Jan 22 2021, 11:03 AM
naromero77 updated the diff for D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..

Use origin/main as reference.

Jan 22 2021, 10:28 AM
naromero77 updated the diff for D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
  • Fix indentation.
Jan 22 2021, 10:19 AM

Jan 21 2021

naromero77 added reviewers for D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests.: Meinersbur, sameeranjoshi, rovka, jdoerfert, lenary, kristof.beyls, tra, aemerson.
Jan 21 2021, 2:48 PM
naromero77 updated subscribers of D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
Jan 21 2021, 2:43 PM
naromero77 requested review of D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
Jan 21 2021, 2:42 PM
naromero77 added a comment to D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 21 2021, 2:07 PM
naromero77 committed rTb94f8db9da9b: [test-suite] SPEC2017 CPU Exchange2 integer tests. (authored by naromero77).
[test-suite] SPEC2017 CPU Exchange2 integer tests.
Jan 21 2021, 2:04 PM
naromero77 closed D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 21 2021, 2:04 PM

Jan 20 2021

naromero77 added a comment to D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..

I am not sure why

arc diff --update D{id}
Jan 20 2021, 2:04 PM
naromero77 updated the diff for D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
  • Restore numerical order of SPEC tests and fix style issues.
Jan 20 2021, 1:52 PM

Jan 19 2021

naromero77 added reviewers for D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests.: Meinersbur, jdoerfert, aemerson, tra, kristof.beyls, lenary.
Jan 19 2021, 10:21 PM
naromero77 updated subscribers of D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 19 2021, 10:18 PM