Page MenuHomePhabricator
Feed Advanced Search

Jan 19 2021

naromero77 requested review of D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 19 2021, 10:16 PM
naromero77 abandoned D95020: [CMake] Delete unneeded find_package(TCL) and find_package(OpenMP).

will re-submit patch. arcanist did something wrong due to change from master to main.

Jan 19 2021, 9:42 PM
naromero77 requested review of D95020: [CMake] Delete unneeded find_package(TCL) and find_package(OpenMP).
Jan 19 2021, 9:39 PM

Jan 6 2021

naromero77 closed D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 3:28 PM
naromero77 added a comment to D93778: [test-suite] Support Fortran tests in CMake infrastructure..

Committed as https://github.com/llvm/llvm-test-suite/commit/f6ee2f66b936e94f03abd687567d2f9c8feb2e71

Jan 6 2021, 3:26 PM
naromero77 added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 12:36 PM
naromero77 updated the diff for D93778: [test-suite] Support Fortran tests in CMake infrastructure..
  • Use CMake enable_language instead.
  • Fix style on conditionals.
  • Cleaner implementation of Fortran unit test example.
Jan 6 2021, 12:31 PM
naromero77 added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 10:39 AM
naromero77 added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 10:38 AM

Dec 23 2020

naromero77 added reviewers for D93778: [test-suite] Support Fortran tests in CMake infrastructure.: Meinersbur, jdoerfert, pmccormick, sscalpone.
Dec 23 2020, 1:38 PM
naromero77 updated subscribers of D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Dec 23 2020, 1:36 PM
naromero77 requested review of D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Dec 23 2020, 1:34 PM

Dec 16 2020

naromero77 closed D93155: [test-suite] 7zip CMake fix..
Dec 16 2020, 9:23 PM
naromero77 added a comment to D93155: [test-suite] 7zip CMake fix..

Committed as https://github.com/llvm/llvm-test-suite/commit/b2fbd488cb0135f68422740e19eff9eff4c5a7f0

Dec 16 2020, 9:23 PM
naromero77 closed D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
Dec 16 2020, 9:21 PM
naromero77 added a comment to D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..

Committed as https://github.com/llvm/llvm-test-suite/commit/7c17aa10cd598129896b9501b73cb583c8bcdeb5

Dec 16 2020, 9:21 PM
naromero77 closed D93136: [test-suite] ClamAV CMake fix..
Dec 16 2020, 8:45 PM
naromero77 added a comment to D93136: [test-suite] ClamAV CMake fix..

Committed as https://github.com/llvm/llvm-test-suite/commit/cbcc0f45e76a704e9796c973ee770dceec9067f4

Dec 16 2020, 8:45 PM

Dec 15 2020

naromero77 updated the diff for D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
  • Place attribute before the definition and avoid ifdef.
Dec 15 2020, 9:41 PM
naromero77 updated the diff for D93136: [test-suite] ClamAV CMake fix..
  • Use find_package instead.
Dec 15 2020, 9:03 PM
naromero77 added a comment to D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..

OK, let's do that instead. Best to avoid ifdefs. Will update patch soon.

Dec 15 2020, 12:39 PM

Dec 14 2020

naromero77 retitled D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions. from Support GCC compilation of Microbenchmark MemFunctions. to [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
Dec 14 2020, 10:28 PM
naromero77 added reviewers for D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions.: jdoerfert, Meinersbur, courbet.
Dec 14 2020, 10:26 PM
naromero77 updated subscribers of D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
Dec 14 2020, 10:24 PM
naromero77 requested review of D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
Dec 14 2020, 10:21 PM
naromero77 added a comment to D93136: [test-suite] ClamAV CMake fix..

The CMake documentation says to use FindIntl for the gettext libintl libraries
https://cmake.org/cmake/help/latest/module/FindIntl.html#module:FindIntl

Dec 14 2020, 10:05 PM

Dec 11 2020

naromero77 added reviewers for D93155: [test-suite] 7zip CMake fix.: MatzeB, t.p.northover, arichardson, Meinersbur.
Dec 11 2020, 10:13 PM
naromero77 updated subscribers of D93155: [test-suite] 7zip CMake fix..
Dec 11 2020, 10:09 PM
naromero77 requested review of D93155: [test-suite] 7zip CMake fix..
Dec 11 2020, 10:07 PM
naromero77 added a reviewer for D93136: [test-suite] ClamAV CMake fix.: Meinersbur.
Dec 11 2020, 12:41 PM
naromero77 added reviewers for D93136: [test-suite] ClamAV CMake fix.: MatzeB, atanasyan.
Dec 11 2020, 12:26 PM
naromero77 updated subscribers of D93136: [test-suite] ClamAV CMake fix..
Dec 11 2020, 11:41 AM
naromero77 requested review of D93136: [test-suite] ClamAV CMake fix..
Dec 11 2020, 11:33 AM

Nov 12 2020

naromero77 retitled D91400: Updates to ALCF Theta Buildbot from Build with fewer tasks and concurrent builds. to Updates to ALCF Theta Buildbot.
Nov 12 2020, 10:04 PM · Restricted Project
naromero77 requested review of D91400: Updates to ALCF Theta Buildbot.
Nov 12 2020, 10:02 PM · Restricted Project

Nov 6 2020

naromero77 requested review of D90986: Worker for Theta supercomputer at ALCF with Flang builder.
Nov 6 2020, 3:55 PM · Restricted Project

Sep 24 2020

naromero77 added a comment to D84334: [flang] Version information in flang/f18.
Sep 24 2020, 10:44 AM · Restricted Project, Restricted Project

Jul 24 2020

naromero77 added a comment to D84334: [flang] Version information in flang/f18.

I am assuming that f18 will have a MAJOR version number matching the LLVM release? Does classic flang do that as well? Both compilers will probably co-exist for a while and it would be desirable to make them distinguishable to build systems as CMake.

Jul 24 2020, 12:50 PM · Restricted Project, Restricted Project

Jul 21 2020

naromero77 accepted D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC.

Tested with Gfortran and PGI. Looks good

Jul 21 2020, 6:03 PM · Restricted Project, Restricted Project
naromero77 added a comment to D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC.

Thanks Alexis, give me a day or two to get back to you.

Jul 21 2020, 2:09 PM · Restricted Project, Restricted Project