Page MenuHomePhabricator
Feed Advanced Search

Fri, Jun 11

naromero77 updated the diff for D104150: [test-suite] NIST Fortran Compiler Validation Suite..
  • More robust way to get rid of fort.* files.
  • More compact code that achieves the same result.
  • Remove driver_parse script.
Fri, Jun 11, 10:11 PM
naromero77 added a comment to D104150: [test-suite] NIST Fortran Compiler Validation Suite..

Could you delete unused driver_parse and driver_run?

Fri, Jun 11, 9:44 PM
naromero77 added reviewers for D104150: [test-suite] NIST Fortran Compiler Validation Suite.: Meinersbur, jdoerfert, sameeranjoshi, rovka, sscalpone, pmccormick.
Fri, Jun 11, 1:38 PM
naromero77 requested review of D104150: [test-suite] NIST Fortran Compiler Validation Suite..
Fri, Jun 11, 1:35 PM

Tue, Jun 1

naromero77 committed rT2d54fa140396: [test-suite] Decouple Fortran tests from C/C++ tests. (authored by naromero77).
[test-suite] Decouple Fortran tests from C/C++ tests.
Tue, Jun 1, 9:11 PM
naromero77 closed D103354: [test-suite] Decouple Fortran tests from C/C++ tests..
Tue, Jun 1, 9:11 PM
naromero77 updated the diff for D103354: [test-suite] Decouple Fortran tests from C/C++ tests..
  • Move hello test to its own subdirectory on UnitTests
  • include Fortran helper moduler in top-level CMakeLists.txt to permit selection of individual UnitTests.
  • Additional CMakeLists.txt needed at this intermediate level.
  • Update comment in Fortran subdirectory CMakeLists.
Tue, Jun 1, 12:13 PM

Fri, May 28

naromero77 added reviewers for D103354: [test-suite] Decouple Fortran tests from C/C++ tests.: jdoerfert, Meinersbur, rovka, pmccormick, sameeranjoshi, sscalpone.
Fri, May 28, 11:16 PM
naromero77 requested review of D103354: [test-suite] Decouple Fortran tests from C/C++ tests..
Fri, May 28, 11:12 PM

Wed, May 26

naromero77 committed rG5f8810d7b463: [flang][docs] Initial documentation for the Fortran LLVM Test Suite. (authored by naromero77).
[flang][docs] Initial documentation for the Fortran LLVM Test Suite.
Wed, May 26, 2:00 PM
naromero77 closed D102877: [flang][docs] Initial documentation for the Fortran LLVM Test Suite..
Wed, May 26, 2:00 PM · Restricted Project
naromero77 added inline comments to D102877: [flang][docs] Initial documentation for the Fortran LLVM Test Suite..
Wed, May 26, 1:57 PM · Restricted Project
naromero77 updated the diff for D102877: [flang][docs] Initial documentation for the Fortran LLVM Test Suite..
  • Fix typos and other grammatical issues.
Wed, May 26, 1:56 PM · Restricted Project

Thu, May 20

naromero77 added reviewers for D102877: [flang][docs] Initial documentation for the Fortran LLVM Test Suite.: awarzynski, sameeranjoshi, rovka, Meinersbur, jdoerfert, pmccormick, AlexisPerry.
Thu, May 20, 2:44 PM · Restricted Project
naromero77 requested review of D102877: [flang][docs] Initial documentation for the Fortran LLVM Test Suite..
Thu, May 20, 2:41 PM · Restricted Project

May 5 2021

naromero77 committed rTfb038dea9c4b: [test-suite] SPEC2017 CPU wrf floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU wrf floating point tests.
May 5 2021, 8:19 AM
naromero77 closed D101789: [test-suite] SPEC2017 CPU wrf floating point tests..
May 5 2021, 8:19 AM

May 4 2021

naromero77 updated the diff for D101789: [test-suite] SPEC2017 CPU wrf floating point tests..
  • Remove extraneous tab characters which messed up indentation.
  • Move comments before macro definition and update description.
  • CMAKE_CURRENT_BINARY_DIR did not need to be added as an included directory.
  • Adjust name of target object library to lowercase and append BENCHMARK_SUITE_TYPE
May 4 2021, 9:13 PM
naromero77 committed rT078712d3a0a1: [test-suite] Update SPEC2017 CPU cam4 floating point tests to use specpp… (authored by naromero77).
[test-suite] Update SPEC2017 CPU cam4 floating point tests to use specpp…
May 4 2021, 8:38 PM
naromero77 closed D101846: [test-suite] Update SPEC2017 CPU cam4 floating point tests to use specpp instead..
May 4 2021, 8:38 PM
naromero77 added reviewers for D101846: [test-suite] Update SPEC2017 CPU cam4 floating point tests to use specpp instead.: Meinersbur, fhahn, sameeranjoshi, rovka.
May 4 2021, 10:53 AM
naromero77 requested review of D101846: [test-suite] Update SPEC2017 CPU cam4 floating point tests to use specpp instead..
May 4 2021, 10:51 AM

May 3 2021

naromero77 added reviewers for D101789: [test-suite] SPEC2017 CPU wrf floating point tests.: Meinersbur, jdoerfert, fhahn, rovka, sameeranjoshi.
May 3 2021, 3:16 PM
naromero77 requested review of D101789: [test-suite] SPEC2017 CPU wrf floating point tests..
May 3 2021, 3:14 PM

Apr 30 2021

naromero77 committed rTd1e1b2f1a164: [test-suite] New SPEC2017 macro and enhancements to run_specpp macro (authored by naromero77).
[test-suite] New SPEC2017 macro and enhancements to run_specpp macro
Apr 30 2021, 2:00 PM
naromero77 closed D101597: [test-suite] New SPEC2017 macro and enhancements to run_specpp macro.
Apr 30 2021, 2:00 PM
naromero77 updated the diff for D101597: [test-suite] New SPEC2017 macro and enhancements to run_specpp macro.
  • Remove SPECPP from variable names.
  • Improve description of speccpu2017_run_specpp
Apr 30 2021, 1:25 PM
naromero77 added inline comments to D101597: [test-suite] New SPEC2017 macro and enhancements to run_specpp macro.
Apr 30 2021, 9:07 AM

Apr 29 2021

naromero77 added reviewers for D101597: [test-suite] New SPEC2017 macro and enhancements to run_specpp macro: Meinersbur, jdoerfert, rovka, fhahn, sameeranjoshi.
Apr 29 2021, 10:23 PM
naromero77 requested review of D101597: [test-suite] New SPEC2017 macro and enhancements to run_specpp macro.
Apr 29 2021, 10:19 PM

Apr 22 2021

naromero77 committed rT6601a28a0314: [test-suite] SPEC2017 CPU pop2 floating point test. (authored by naromero77).
[test-suite] SPEC2017 CPU pop2 floating point test.
Apr 22 2021, 7:44 AM
naromero77 closed D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
Apr 22 2021, 7:44 AM

Apr 21 2021

naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
  • Use a single shared variable for definitions that are used by specpp and regular cmake add_definitions function.
  • speccpu2017_run_specpp now takes two mandatory lists. one for files and the other for compiler definitions.
  • Add missing '>' to generator expression.
  • Glob pop2 source Fortran90 files that are passed into specpp in the pop2 test specific CMakeLists.txt.
Apr 21 2021, 11:15 PM

Apr 9 2021

naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
  • big-endian flag fix for GCC and Intel.
Apr 9 2021, 9:07 PM

Apr 7 2021

naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..

Was still missing earlier commits.

Apr 7 2021, 10:21 PM
naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..

Trying to send commits again.

Apr 7 2021, 9:57 PM
naromero77 updated the diff for D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
  • Use GLOB in speccpu2017_run_specpp
  • Move common definitions and flags used by specpp into SpecCPU2017.cmake
  • Re-use speccpu2017_prepare_rundir
  • Number of minor fixes
  • Number of updates to comments
Apr 7 2021, 9:50 PM

Apr 5 2021

naromero77 added inline comments to D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
Apr 5 2021, 3:18 PM

Mar 30 2021

naromero77 added reviewers for D99640: [test-suite] SPEC2017 CPU pop2 floating point test.: Meinersbur, sameeranjoshi, rovka, fhahn.
Mar 30 2021, 10:54 PM
naromero77 requested review of D99640: [test-suite] SPEC2017 CPU pop2 floating point test..
Mar 30 2021, 10:51 PM
naromero77 added a comment to D99619: [test-suite] Use forward-parsing when searching for numbers..

LGTM

Mar 30 2021, 9:11 PM
naromero77 added a comment to D99619: [test-suite] Use forward-parsing when searching for numbers..

Confirming that all tests are passing with clang/clang++.

Mar 30 2021, 9:11 PM
naromero77 accepted D99619: [test-suite] Use forward-parsing when searching for numbers..
Mar 30 2021, 2:36 PM
naromero77 added a comment to D99619: [test-suite] Use forward-parsing when searching for numbers..

Ran the entire test suite with GCC 10.2.0. For the record, there was one failure:

Mar 30 2021, 2:36 PM

Mar 12 2021

naromero77 committed rT01f5ea4052f0: [test-suite] SPEC2017 CPU CAM4 portability updates. (authored by naromero77).
[test-suite] SPEC2017 CPU CAM4 portability updates.
Mar 12 2021, 8:43 PM
naromero77 closed D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..
Mar 12 2021, 8:43 PM
naromero77 updated the diff for D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..

Trying again to send the patch.

Mar 12 2021, 11:30 AM
naromero77 updated the diff for D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..
  • Use standard convention for feature-test variables.
  • Only add CMake Utility Modules that are actually used.
Mar 12 2021, 11:28 AM

Mar 10 2021

naromero77 added reviewers for D98374: [test-suite] SPEC2017 CPU CAM4 portability updates.: jdoerfert, Meinersbur, fhahn, sameeranjoshi, rovka, homerdin.
Mar 10 2021, 3:01 PM
naromero77 requested review of D98374: [test-suite] SPEC2017 CPU CAM4 portability updates..
Mar 10 2021, 2:59 PM

Mar 9 2021

naromero77 accepted D98260: [test-suite][SPEC2000] Use -fcommon instead of -zmultidef..

LGTM

Mar 9 2021, 11:59 AM
naromero77 added a comment to D98260: [test-suite][SPEC2000] Use -fcommon instead of -zmultidef..

Is there any negative impact to macOS X?

Mar 9 2021, 11:22 AM

Mar 2 2021

naromero77 committed rTeac0ed543746: [test-suite] Update .arcconfig to match LLVM. (authored by naromero77).
[test-suite] Update .arcconfig to match LLVM.
Mar 2 2021, 9:22 AM
naromero77 closed D97754: [test-suite] Update .arcconfig to match LLVM..
Mar 2 2021, 9:22 AM

Mar 1 2021

naromero77 committed rTa0411da701de: [test-suite] SPEC2017 CPU CAM4 floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU CAM4 floating point tests.
Mar 1 2021, 9:58 PM
naromero77 closed D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 9:58 PM
naromero77 updated the diff for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
  • Remove extraneous space.
Mar 1 2021, 9:33 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 9:30 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 9:29 PM
naromero77 added reviewers for D97754: [test-suite] Update .arcconfig to match LLVM.: jdoerfert, Meinersbur, fhahn, sameeranjoshi, rovka.
Mar 1 2021, 9:19 PM
naromero77 requested review of D97754: [test-suite] Update .arcconfig to match LLVM..
Mar 1 2021, 9:17 PM
naromero77 updated the diff for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
  • Use plain vanilla diff instead of specdiff.
  • Use target_compile_definitions instead.
  • Fix typo and clarify comment.
  • Remove redundant explicit dependencies.
Mar 1 2021, 8:26 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mar 1 2021, 2:45 PM

Feb 25 2021

naromero77 added reviewers for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests.: Meinersbur, sameeranjoshi, rovka, fhahn.
Feb 25 2021, 9:37 PM
naromero77 requested review of D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Feb 25 2021, 9:34 PM

Feb 24 2021

naromero77 committed rT37a356505b2a: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja. (authored by naromero77).
[test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.
Feb 24 2021, 11:59 AM
naromero77 closed D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 24 2021, 11:59 AM

Feb 23 2021

naromero77 updated the summary of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 23 2021, 8:13 PM
naromero77 updated the diff for D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
  • Get rid of redudant warning in top-level CMakeLists when Ninja is not used.
  • Improve line wrapping.
Feb 23 2021, 8:07 PM
naromero77 added inline comments to D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 23 2021, 9:05 AM

Feb 22 2021

naromero77 committed rT0b0305c689d9: [test-suite] Raise minimum required CMake version to match LLVM. (authored by naromero77).
[test-suite] Raise minimum required CMake version to match LLVM.
Feb 22 2021, 10:56 PM
naromero77 closed D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 10:56 PM
naromero77 updated the summary of D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 10:41 PM
naromero77 retitled D97248: [test-suite] Raise minimum required CMake version to match LLVM. from [test-suite] Raise minimum required CMake version to match llvm-project. to [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 10:40 PM
naromero77 added reviewers for D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.: Meinersbur, jdoerfert, sameeranjoshi, rovka, fhahn.
Feb 22 2021, 8:48 PM
naromero77 updated the summary of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 22 2021, 8:48 PM
naromero77 requested review of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Feb 22 2021, 8:46 PM
naromero77 added reviewers for D97248: [test-suite] Raise minimum required CMake version to match LLVM.: jdoerfert, Meinersbur, rovka, sameeranjoshi, fhahn.
Feb 22 2021, 7:57 PM
naromero77 requested review of D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Feb 22 2021, 7:54 PM

Feb 19 2021

naromero77 committed rT0e6fde52a15c: [test-suite] SPEC2017 CPU ROMS floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU ROMS floating point tests.
Feb 19 2021, 9:28 AM
naromero77 closed D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 19 2021, 9:28 AM

Feb 18 2021

naromero77 updated the diff for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
  • Improved warning message for CMAKE_GENERATOR.
Feb 18 2021, 8:49 PM

Feb 17 2021

naromero77 updated the summary of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 17 2021, 9:26 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

LLVM required cmake 3.13.4, I think we can bump the version for llvm-test-suite as well.

Feb 17 2021, 9:19 PM
naromero77 updated the diff for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
  • Run ROMS test out of run directory.
  • Revert "Helper macro for managing intermediate dependencies on Fortran modules."
  • Add warning about CMAKE_GENERATORS that are not Ninja.
  • Fix comment to reflect ROMS test.
  • Intermediate target dependencies are not needed when using Ninja.
Feb 17 2021, 9:17 PM

Feb 16 2021

naromero77 committed rT553e5905b7bc: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests. (authored by naromero77).
[test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests.
Feb 16 2021, 8:52 PM
naromero77 closed D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Feb 16 2021, 8:52 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

As far as I know, cmake detect module dependency itself, which would make speccpu2017_add_mod unnecessary.

I applied the patch locally and change the compilation part to just speccpu2017_add_executable() and it still compiles.

Feb 16 2021, 2:31 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

As far as I know, cmake detect module dependency itself, which would make speccpu2017_add_mod unnecessary.

It is not really clear from the CMake docs that it can figure out complex module dependencies without intermediary targets. Searching online, it looks like many Fortran-centric projects have come up with different solutions.

Feb 16 2021, 2:18 PM
naromero77 added reviewers for D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, rovka, fhahn.
Feb 16 2021, 1:15 PM
naromero77 updated subscribers of D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Feb 16 2021, 1:13 PM
naromero77 requested review of D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Feb 16 2021, 1:12 PM

Feb 15 2021

naromero77 added reviewers for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, fhahn, rovka.
Feb 15 2021, 9:54 PM
naromero77 retitled D96746: [test-suite] SPEC2017 CPU ROMS floating point tests. from Helper macro for managing intermediate dependencies on Fortran modules. to [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 15 2021, 9:49 PM
naromero77 updated subscribers of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 15 2021, 9:43 PM
naromero77 requested review of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Feb 15 2021, 9:42 PM

Feb 10 2021

naromero77 added a comment to D96432: SPEC2006: Pronounce endianness flags both ways.

Thanks for catching this.

Feb 10 2021, 10:16 AM

Feb 9 2021

naromero77 committed rTefb2e01b23f0: [test-suite] SPEC2017 CPU Fotonik3d floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU Fotonik3d floating point tests.
Feb 9 2021, 8:46 PM
naromero77 closed D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 9 2021, 8:46 PM
naromero77 updated the diff for D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
  • Run specxz from tools bin.
Feb 9 2021, 3:06 PM