Page MenuHomePhabricator
Feed Advanced Search

Tue, Mar 2

naromero77 committed rTeac0ed543746: [test-suite] Update .arcconfig to match LLVM. (authored by naromero77).
[test-suite] Update .arcconfig to match LLVM.
Tue, Mar 2, 9:22 AM
naromero77 closed D97754: [test-suite] Update .arcconfig to match LLVM..
Tue, Mar 2, 9:22 AM

Mon, Mar 1

naromero77 committed rTa0411da701de: [test-suite] SPEC2017 CPU CAM4 floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU CAM4 floating point tests.
Mon, Mar 1, 9:58 PM
naromero77 closed D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mon, Mar 1, 9:58 PM
naromero77 updated the diff for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
  • Remove extraneous space.
Mon, Mar 1, 9:33 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mon, Mar 1, 9:30 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mon, Mar 1, 9:29 PM
naromero77 added reviewers for D97754: [test-suite] Update .arcconfig to match LLVM.: jdoerfert, Meinersbur, fhahn, sameeranjoshi, rovka.
Mon, Mar 1, 9:19 PM
naromero77 requested review of D97754: [test-suite] Update .arcconfig to match LLVM..
Mon, Mar 1, 9:17 PM
naromero77 updated the diff for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
  • Use plain vanilla diff instead of specdiff.
  • Use target_compile_definitions instead.
  • Fix typo and clarify comment.
  • Remove redundant explicit dependencies.
Mon, Mar 1, 8:26 PM
naromero77 added inline comments to D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Mon, Mar 1, 2:45 PM

Thu, Feb 25

naromero77 added reviewers for D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests.: Meinersbur, sameeranjoshi, rovka, fhahn.
Thu, Feb 25, 9:37 PM
naromero77 requested review of D97527: [test-suite] SPEC2017 CPU CAM4 floating point tests..
Thu, Feb 25, 9:34 PM

Wed, Feb 24

naromero77 committed rT37a356505b2a: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja. (authored by naromero77).
[test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.
Wed, Feb 24, 11:59 AM
naromero77 closed D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Wed, Feb 24, 11:59 AM

Tue, Feb 23

naromero77 updated the summary of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Tue, Feb 23, 8:13 PM
naromero77 updated the diff for D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
  • Get rid of redudant warning in top-level CMakeLists when Ninja is not used.
  • Improve line wrapping.
Tue, Feb 23, 8:07 PM
naromero77 added inline comments to D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Tue, Feb 23, 9:05 AM

Mon, Feb 22

naromero77 committed rT0b0305c689d9: [test-suite] Raise minimum required CMake version to match LLVM. (authored by naromero77).
[test-suite] Raise minimum required CMake version to match LLVM.
Mon, Feb 22, 10:56 PM
naromero77 closed D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Mon, Feb 22, 10:56 PM
naromero77 updated the summary of D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Mon, Feb 22, 10:41 PM
naromero77 retitled D97248: [test-suite] Raise minimum required CMake version to match LLVM. from [test-suite] Raise minimum required CMake version to match llvm-project. to [test-suite] Raise minimum required CMake version to match LLVM..
Mon, Feb 22, 10:40 PM
naromero77 added reviewers for D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.: Meinersbur, jdoerfert, sameeranjoshi, rovka, fhahn.
Mon, Feb 22, 8:48 PM
naromero77 updated the summary of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Mon, Feb 22, 8:48 PM
naromero77 requested review of D97250: [test-suite] Robust warnings for Fortran Test Suite tests that require Ninja..
Mon, Feb 22, 8:46 PM
naromero77 added reviewers for D97248: [test-suite] Raise minimum required CMake version to match LLVM.: jdoerfert, Meinersbur, rovka, sameeranjoshi, fhahn.
Mon, Feb 22, 7:57 PM
naromero77 requested review of D97248: [test-suite] Raise minimum required CMake version to match LLVM..
Mon, Feb 22, 7:54 PM

Fri, Feb 19

naromero77 committed rT0e6fde52a15c: [test-suite] SPEC2017 CPU ROMS floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU ROMS floating point tests.
Fri, Feb 19, 9:28 AM
naromero77 closed D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Fri, Feb 19, 9:28 AM

Thu, Feb 18

naromero77 updated the diff for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
  • Improved warning message for CMAKE_GENERATOR.
Thu, Feb 18, 8:49 PM

Wed, Feb 17

naromero77 updated the summary of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Wed, Feb 17, 9:26 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

LLVM required cmake 3.13.4, I think we can bump the version for llvm-test-suite as well.

Wed, Feb 17, 9:19 PM
naromero77 updated the diff for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
  • Run ROMS test out of run directory.
  • Revert "Helper macro for managing intermediate dependencies on Fortran modules."
  • Add warning about CMAKE_GENERATORS that are not Ninja.
  • Fix comment to reflect ROMS test.
  • Intermediate target dependencies are not needed when using Ninja.
Wed, Feb 17, 9:17 PM

Tue, Feb 16

naromero77 committed rT553e5905b7bc: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests. (authored by naromero77).
[test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests.
Tue, Feb 16, 8:52 PM
naromero77 closed D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Tue, Feb 16, 8:52 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

As far as I know, cmake detect module dependency itself, which would make speccpu2017_add_mod unnecessary.

I applied the patch locally and change the compilation part to just speccpu2017_add_executable() and it still compiles.

Tue, Feb 16, 2:31 PM
naromero77 added a comment to D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..

As far as I know, cmake detect module dependency itself, which would make speccpu2017_add_mod unnecessary.

It is not really clear from the CMake docs that it can figure out complex module dependencies without intermediary targets. Searching online, it looks like many Fortran-centric projects have come up with different solutions.

Tue, Feb 16, 2:18 PM
naromero77 added reviewers for D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, rovka, fhahn.
Tue, Feb 16, 1:15 PM
naromero77 updated subscribers of D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Tue, Feb 16, 1:13 PM
naromero77 requested review of D96813: [test-suite] Fix runtime-error of SPEC2017 CPU CactuBSSN floating point tests..
Tue, Feb 16, 1:12 PM

Mon, Feb 15

naromero77 added reviewers for D96746: [test-suite] SPEC2017 CPU ROMS floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, fhahn, rovka.
Mon, Feb 15, 9:54 PM
naromero77 retitled D96746: [test-suite] SPEC2017 CPU ROMS floating point tests. from Helper macro for managing intermediate dependencies on Fortran modules. to [test-suite] SPEC2017 CPU ROMS floating point tests..
Mon, Feb 15, 9:49 PM
naromero77 updated subscribers of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Mon, Feb 15, 9:43 PM
naromero77 requested review of D96746: [test-suite] SPEC2017 CPU ROMS floating point tests..
Mon, Feb 15, 9:42 PM

Wed, Feb 10

naromero77 added a comment to D96432: SPEC2006: Pronounce endianness flags both ways.

Thanks for catching this.

Wed, Feb 10, 10:16 AM

Tue, Feb 9

naromero77 committed rTefb2e01b23f0: [test-suite] SPEC2017 CPU Fotonik3d floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU Fotonik3d floating point tests.
Tue, Feb 9, 8:46 PM
naromero77 closed D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Tue, Feb 9, 8:46 PM
naromero77 updated the diff for D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
  • Run specxz from tools bin.
Tue, Feb 9, 3:06 PM

Mon, Feb 8

naromero77 added inline comments to D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Mon, Feb 8, 9:20 AM

Fri, Feb 5

naromero77 updated the diff for D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
  • Add missing TEST_SUITE_FORTRAN conditional.
  • Combine into a single verify_output.
Fri, Feb 5, 9:27 PM
naromero77 added inline comments to D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Fri, Feb 5, 3:17 PM

Feb 4 2021

naromero77 added reviewers for D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, rovka, aemerson, tra, kristof.beyls, lenary, fhahn, cmatthews.
Feb 4 2021, 9:27 PM
naromero77 updated subscribers of D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 4 2021, 9:22 PM
naromero77 requested review of D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests..
Feb 4 2021, 9:20 PM

Feb 3 2021

naromero77 added inline comments to D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Feb 3 2021, 8:26 PM
naromero77 committed rT3a39afc9019c: [test-suite] SPEC2017 CPU CactuBSSN floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU CactuBSSN floating point tests.
Feb 3 2021, 8:22 PM
naromero77 closed D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Feb 3 2021, 8:22 PM
naromero77 updated the diff for D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..

With respect to origin/main.

Feb 3 2021, 12:41 PM
naromero77 updated the diff for D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
  • Use cleaner and more modern CMake.
Feb 3 2021, 12:38 PM

Feb 1 2021

naromero77 added a comment to D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..

Is someone available to review this patch?

Feb 1 2021, 10:41 AM

Jan 28 2021

naromero77 added reviewers for D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests.: Meinersbur, jdoerfert, sameeranjoshi, rovka, aemerson, tra, kristof.beyls, lenary.
Jan 28 2021, 10:44 AM
naromero77 updated subscribers of D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Jan 28 2021, 10:40 AM
naromero77 requested review of D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests..
Jan 28 2021, 10:39 AM

Jan 25 2021

naromero77 accepted D94945: ClangBuilder: Enable fortran in test-suite.
Jan 25 2021, 9:25 AM
naromero77 added a comment to D94945: ClangBuilder: Enable fortran in test-suite.

Thanks for adding Flang to the test suite.

Jan 25 2021, 8:29 AM

Jan 22 2021

naromero77 accepted D95276: [External][SPEC2000] Add -Wl,-zmultidef linker option..
Jan 22 2021, 9:02 PM
naromero77 added a comment to D95276: [External][SPEC2000] Add -Wl,-zmultidef linker option..

LGTM

Jan 22 2021, 9:02 PM
naromero77 committed rT1cae3ccc1db9: [test-suite] SPEC2017 CPU Bwaves floating point tests. (authored by naromero77).
[test-suite] SPEC2017 CPU Bwaves floating point tests.
Jan 22 2021, 11:03 AM
naromero77 closed D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
Jan 22 2021, 11:03 AM
naromero77 updated the diff for D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..

Use origin/main as reference.

Jan 22 2021, 10:28 AM
naromero77 updated the diff for D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
  • Fix indentation.
Jan 22 2021, 10:19 AM

Jan 21 2021

naromero77 added reviewers for D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests.: Meinersbur, sameeranjoshi, rovka, jdoerfert, lenary, kristof.beyls, tra, aemerson.
Jan 21 2021, 2:48 PM
naromero77 updated subscribers of D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
Jan 21 2021, 2:43 PM
naromero77 requested review of D95173: [test-suite] SPEC2017 CPU Bwaves floating point tests..
Jan 21 2021, 2:42 PM
naromero77 added a comment to D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 21 2021, 2:07 PM
naromero77 committed rTb94f8db9da9b: [test-suite] SPEC2017 CPU Exchange2 integer tests. (authored by naromero77).
[test-suite] SPEC2017 CPU Exchange2 integer tests.
Jan 21 2021, 2:04 PM
naromero77 closed D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 21 2021, 2:04 PM

Jan 20 2021

naromero77 added a comment to D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..

I am not sure why

arc diff --update D{id}
Jan 20 2021, 2:04 PM
naromero77 updated the diff for D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
  • Restore numerical order of SPEC tests and fix style issues.
Jan 20 2021, 1:52 PM

Jan 19 2021

naromero77 added reviewers for D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests.: Meinersbur, jdoerfert, aemerson, tra, kristof.beyls, lenary.
Jan 19 2021, 10:21 PM
naromero77 updated subscribers of D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 19 2021, 10:18 PM
naromero77 requested review of D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests..
Jan 19 2021, 10:16 PM
naromero77 abandoned D95020: [CMake] Delete unneeded find_package(TCL) and find_package(OpenMP).

will re-submit patch. arcanist did something wrong due to change from master to main.

Jan 19 2021, 9:42 PM
naromero77 requested review of D95020: [CMake] Delete unneeded find_package(TCL) and find_package(OpenMP).
Jan 19 2021, 9:39 PM

Jan 6 2021

naromero77 closed D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 3:28 PM
naromero77 added a comment to D93778: [test-suite] Support Fortran tests in CMake infrastructure..

Committed as https://github.com/llvm/llvm-test-suite/commit/f6ee2f66b936e94f03abd687567d2f9c8feb2e71

Jan 6 2021, 3:26 PM
naromero77 added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 12:36 PM
naromero77 updated the diff for D93778: [test-suite] Support Fortran tests in CMake infrastructure..
  • Use CMake enable_language instead.
  • Fix style on conditionals.
  • Cleaner implementation of Fortran unit test example.
Jan 6 2021, 12:31 PM
naromero77 added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 10:39 AM
naromero77 added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Jan 6 2021, 10:38 AM

Dec 23 2020

naromero77 added reviewers for D93778: [test-suite] Support Fortran tests in CMake infrastructure.: Meinersbur, jdoerfert, pmccormick, sscalpone.
Dec 23 2020, 1:38 PM
naromero77 updated subscribers of D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Dec 23 2020, 1:36 PM
naromero77 requested review of D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Dec 23 2020, 1:34 PM

Dec 16 2020

naromero77 closed D93155: [test-suite] 7zip CMake fix..
Dec 16 2020, 9:23 PM
naromero77 added a comment to D93155: [test-suite] 7zip CMake fix..

Committed as https://github.com/llvm/llvm-test-suite/commit/b2fbd488cb0135f68422740e19eff9eff4c5a7f0

Dec 16 2020, 9:23 PM
naromero77 closed D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
Dec 16 2020, 9:21 PM
naromero77 added a comment to D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..

Committed as https://github.com/llvm/llvm-test-suite/commit/7c17aa10cd598129896b9501b73cb583c8bcdeb5

Dec 16 2020, 9:21 PM
naromero77 closed D93136: [test-suite] ClamAV CMake fix..
Dec 16 2020, 8:45 PM
naromero77 added a comment to D93136: [test-suite] ClamAV CMake fix..

Committed as https://github.com/llvm/llvm-test-suite/commit/cbcc0f45e76a704e9796c973ee770dceec9067f4

Dec 16 2020, 8:45 PM

Dec 15 2020

naromero77 updated the diff for D93279: [test-suite] Support GCC compilation of Microbenchmark MemFunctions..
  • Place attribute before the definition and avoid ifdef.
Dec 15 2020, 9:41 PM