In D138323#4072561, @nhaehnle wrote:

Yes, that's indeed an issue for what you're trying to do. IMHO it is also an issue for the maintainability of these backends as they are today. So I'd say we should try to separate the state-machine generation code from the printing code. It could be moved to CodeGenTarget, though I think it'd be better to keep things slightly more modular and instead split up the current DecoderEmitter into parts:

• A Decoder class contains all the state-machine description. Think of it as an "intermediate representation for a decoder/disassembler": it contains the data describing the decoder, but essentially no logic.
• A separate createDecoder function creates a Decoder given a CodeGenTarget
• The emitDecoder function writes out the generated C++ for a given Decoder object

Does that make sense to you?

Thank you for the feedback!
Its my first time with LLVM so your critique is very valuable for me.

Thanks for the feedback so far!

Removes the PrinterInterface. New language printer should simply inherit from PrinterLLVM.

In D138323#3948239, @0x59616e wrote:

Wouldn't this break the 'open-close principle' and 'Interface segregation principle' ?

To test the output after the refactor I used the following simple scripts:

There is now an implementation open for review: https://reviews.llvm.org/D138323

In D136808#3888821, @myhsu wrote:

In D136808#3888064, @0x59616e wrote:

Thanks for this patch !

It is difficult to see the changes you made. Could you separate this into two patches -- the first one contains the all the changes except the functional change; the second one contains the functional change you made.

Add diff of Printer implementation.

Adds the decoder split up/refactor as single diff. separated from the Printer implementation.