Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 9

woodruffw added a comment to D113460: [llvm-dwarfdump] Add support for filtering by DIE tags.

I was thinking of something simpler/less invasive (no need to add a new data structure to collect all the DIEs, etc).

ie: What if "filterByName" functions were renamed to "filter" and each took an extra argument, Tags, & did all the same stufff but also checked Tags?

Tue, Nov 9, 6:09 PM · Restricted Project
woodruffw updated the diff for D113460: [llvm-dwarfdump] Add support for filtering by DIE tags.

Rewrote to use just a single filter function.

Tue, Nov 9, 4:39 PM · Restricted Project
woodruffw added a comment to D113460: [llvm-dwarfdump] Add support for filtering by DIE tags.

Any particular motivation/need for this?

Tue, Nov 9, 7:08 AM · Restricted Project

Mon, Nov 8

woodruffw added a comment to D113460: [llvm-dwarfdump] Add support for filtering by DIE tags.

I'll add a test as well, just wanted to get an initial version up for feedback.

Mon, Nov 8, 10:02 PM · Restricted Project
woodruffw requested review of D113460: [llvm-dwarfdump] Add support for filtering by DIE tags.
Mon, Nov 8, 9:58 PM · Restricted Project

Oct 25 2021

woodruffw added a comment to D112463: [LangRef] Remove incorrect vector alignment rules.

Not sure whether that behavior is intended, but it is indeed the current behavior.

Oct 25 2021, 9:37 AM · Restricted Project

Oct 11 2021

woodruffw added inline comments to D108962: [docs] [NFC] Clarify the datalayout documentation.
Oct 11 2021, 11:46 AM · Restricted Project
woodruffw updated the diff for D108962: [docs] [NFC] Clarify the datalayout documentation.

Fixed awkward language.

Oct 11 2021, 11:46 AM · Restricted Project

Oct 9 2021

woodruffw added a comment to D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].

I don't see any particular issue with refactoring this way, but I'm wondering why you need to be able to dump the AST in order to track changes to the file and values?

Oct 9 2021, 9:00 PM · Restricted Project
woodruffw added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Moved the new test to llvm/test/Other/bcanalyzer-dump-blockinfo-option.txt per @tejohnson's suggestion.

Oct 9 2021, 8:57 PM · Restricted Project
woodruffw updated the diff for D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Oct 9 2021, 8:56 PM · Restricted Project
woodruffw added inline comments to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Oct 9 2021, 2:17 PM · Restricted Project
woodruffw updated the diff for D108441: [clang] Fix JSON AST output when a filter is used.

Resolve conflicts.

Oct 9 2021, 2:11 PM · Restricted Project
woodruffw added inline comments to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Oct 9 2021, 1:55 PM · Restricted Project
woodruffw updated the diff for D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Avoid llvm-stress in test, more detailed checks.

Oct 9 2021, 1:54 PM · Restricted Project

Oct 8 2021

woodruffw added a comment to D109655: [BitcodeReader] fix a logic error in vector type element validation.

Thanks! I don't have commit access so I'll need someone else to do the merge :-)

Oct 8 2021, 8:46 PM · Restricted Project

Oct 3 2021

woodruffw added a reviewer for D108962: [docs] [NFC] Clarify the datalayout documentation: Restricted Project.
Oct 3 2021, 7:57 PM · Restricted Project
woodruffw added a comment to D109655: [BitcodeReader] fix a logic error in vector type element validation.

Gentle ping for review.

Oct 3 2021, 7:53 PM · Restricted Project
woodruffw added inline comments to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Oct 3 2021, 7:52 PM · Restricted Project
woodruffw updated the diff for D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Added a test; made some small fixes to the --help output and file comments.

Oct 3 2021, 7:52 PM · Restricted Project

Sep 29 2021

woodruffw added a comment to D108441: [clang] Fix JSON AST output when a filter is used.

Another gentle ping for review.

Sep 29 2021, 1:23 PM · Restricted Project
woodruffw added inline comments to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Sep 29 2021, 1:21 PM · Restricted Project

Sep 25 2021

woodruffw added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Gentle ping for review on this!

Sep 25 2021, 5:38 PM · Restricted Project

Sep 14 2021

woodruffw updated the diff for D108441: [clang] Fix JSON AST output when a filter is used.

Increase the context for the patch.

Sep 14 2021, 5:15 PM · Restricted Project
woodruffw updated the diff for D109655: [BitcodeReader] fix a logic error in vector type element validation.

Increase the context for the patch.

Sep 14 2021, 5:13 PM · Restricted Project
woodruffw added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Thanks! I've updated the diff to include context.

Sep 14 2021, 11:41 AM · Restricted Project
woodruffw updated the diff for D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Added context to the patch.

Sep 14 2021, 11:40 AM · Restricted Project
woodruffw added a comment to D108962: [docs] [NFC] Clarify the datalayout documentation.

Another gentle ping for review.

Sep 14 2021, 10:54 AM · Restricted Project

Sep 11 2021

woodruffw requested review of D109655: [BitcodeReader] fix a logic error in vector type element validation.
Sep 11 2021, 11:51 PM · Restricted Project

Sep 8 2021

woodruffw added a comment to D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].

Another gentle ping for review.

Sep 8 2021, 11:17 AM · Restricted Project
woodruffw added a comment to D108441: [clang] Fix JSON AST output when a filter is used.

Another gentle ping for review.

Sep 8 2021, 11:17 AM · Restricted Project

Sep 7 2021

woodruffw added a comment to D108962: [docs] [NFC] Clarify the datalayout documentation.

Ping for review on this.

Sep 7 2021, 11:39 AM · Restricted Project
woodruffw added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Another ping for review.

Sep 7 2021, 11:38 AM · Restricted Project

Aug 30 2021

woodruffw updated the diff for D108962: [docs] [NFC] Clarify the datalayout documentation.

Mark <pref> as optional in all of the alignment specs, since the DataLayout parser treats it as optional.

Aug 30 2021, 8:53 PM · Restricted Project
woodruffw updated the diff for D108962: [docs] [NFC] Clarify the datalayout documentation.

Also clarify that <pref> is optional in pointer alignment specifications.

Aug 30 2021, 8:39 PM · Restricted Project
woodruffw requested review of D108962: [docs] [NFC] Clarify the datalayout documentation.
Aug 30 2021, 6:07 PM · Restricted Project
woodruffw added a comment to D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].

Gentle ping for review on this.

Aug 30 2021, 7:45 AM · Restricted Project
woodruffw added a comment to D108441: [clang] Fix JSON AST output when a filter is used.

Gentle ping for review on this!

Aug 30 2021, 7:45 AM · Restricted Project

Aug 21 2021

woodruffw updated the diff for D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].

Fix the header guards, again.

Aug 21 2021, 1:30 PM · Restricted Project
woodruffw retitled D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC] from [Bitstream] Improve the dumpability of bitstream/bitcode headers to [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].
Aug 21 2021, 1:22 PM · Restricted Project

Aug 20 2021

woodruffw updated the diff for D108441: [clang] Fix JSON AST output when a filter is used.

Updated the AST dump tests for JSON to refute the presence of the Dumping prefix.

Aug 20 2021, 8:08 PM · Restricted Project
woodruffw updated the diff for D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].

Fix the header guard style.

Aug 20 2021, 6:19 PM · Restricted Project
woodruffw added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Another gentle ping for review here. Please let me know if there's anything else I can do.

Aug 20 2021, 12:59 PM · Restricted Project

Aug 19 2021

woodruffw requested review of D108441: [clang] Fix JSON AST output when a filter is used.
Aug 19 2021, 8:15 PM · Restricted Project
woodruffw updated the diff for D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].

Fixed namespaces.

Aug 19 2021, 7:53 PM · Restricted Project
woodruffw retitled D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC] from Improve the dumpability of bitstream/bitcode headers to [Bitstream] Improve the dumpability of bitstream/bitcode headers.
Aug 19 2021, 7:21 PM · Restricted Project
woodruffw requested review of D108438: [Bitstream] Improve the dumpability of bitstream/bitcode headers [NFC].
Aug 19 2021, 7:20 PM · Restricted Project

Aug 12 2021

woodruffw added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Gentle ping for review on this!

Aug 12 2021, 3:09 PM · Restricted Project

Aug 5 2021

woodruffw updated the diff for D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Fixed the diff tests.

Aug 5 2021, 11:10 AM · Restricted Project

Aug 4 2021

woodruffw added a comment to D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.

Sorry for the churn; rebased the commit so that it sits on the latest main instead of an old one.

Aug 4 2021, 10:25 PM · Restricted Project
woodruffw updated the diff for D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Aug 4 2021, 10:23 PM · Restricted Project
woodruffw requested review of D107536: [BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO.
Aug 4 2021, 10:15 PM · Restricted Project

Jun 28 2019

woodruffw added a comment to D63697: clang-format: Fix error return when using inplace with stdin.

Yep, I'll add one in a bit.

Jun 28 2019, 6:28 PM · Restricted Project, Restricted Project

Jun 23 2019

woodruffw created D63697: clang-format: Fix error return when using inplace with stdin.
Jun 23 2019, 6:47 PM · Restricted Project, Restricted Project