Page MenuHomePhabricator
Feed Advanced Search

Tue, May 24

Jake-Egan added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

@arphaman Thanks for the quick action. The tests pass on a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/1493, so that's probably why there was trouble reproducing. I think we could revert 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9.

Tue, May 24, 5:46 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

Hi, these tests fail on AIX, could you take a look please?

Tue, May 24, 12:20 PM · Restricted Project, Restricted Project

Tue, May 17

Jake-Egan committed rG5caa7038a4ca: [NFC][AIX] Reenable mri1.test (authored by Jake-Egan).
[NFC][AIX] Reenable mri1.test
Tue, May 17, 7:27 AM · Restricted Project, Restricted Project
Jake-Egan closed D125772: [NFC][AIX] Reenable mri1.test.
Tue, May 17, 7:27 AM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D125772: [NFC][AIX] Reenable mri1.test.
Tue, May 17, 6:25 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D125772: [NFC][AIX] Reenable mri1.test.
Tue, May 17, 6:23 AM · Restricted Project, Restricted Project

Mon, May 16

Jake-Egan added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

@bd1976llvm
Thanks, the test is passing now.

Mon, May 16, 5:34 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

Hi, this test is failing on AIX because the default archive format is big archive. So when this test checks for !<arch> it sees <bigaf> instead.
https://lab.llvm.org/buildbot/#/builders/214/builds/1314/steps/6/logs/FAIL__LLVM__mri-create-overwrite_test

Mon, May 16, 8:18 AM · Restricted Project, Restricted Project

Thu, May 12

Jake-Egan added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

check-all is green on AIX.

Thu, May 12, 8:07 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio

I applied your patch here and it seems to fix the original error, but there is a new one:

/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:69:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(D);
  ^~~~~~~~~~~~~~~~ ~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:70:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(BD);
  ^~~~~~~~~~~~~~~~ ~~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:71:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyDerivedType>(BD);
  ^~~~~~~~~~~~~~~~~~~ ~~

This commit went in last night it looks like to fix that: 52328dafda13711653fd15aa4db34db350471a1f

Thu, May 12, 2:06 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio

Thu, May 12, 1:59 PM · Restricted Project, Restricted Project

Wed, May 11

Jake-Egan added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Hi, this patch causes a test failure on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1221/steps/6/logs/FAIL__Clang__noinline_cu

Wed, May 11, 6:12 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 10

Jake-Egan added a comment to D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

4 of the tests fail on AIX also: https://lab.llvm.org/buildbot/#/builders/214/builds/1207

Tue, May 10, 1:46 PM · Restricted Project, Restricted Project, Restricted Project

Wed, May 4

Jake-Egan added inline comments to D124555: [libcxx][AIX][z/OS] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.
Wed, May 4, 10:36 AM · Restricted Project, Restricted Project

Apr 26 2022

Jake-Egan updated the diff for D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.

Simplify '.a' extension check

Apr 26 2022, 10:46 AM · Restricted Project, Restricted Project
Jake-Egan added inline comments to D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.
Apr 26 2022, 10:43 AM · Restricted Project, Restricted Project
Jake-Egan added inline comments to D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.
Apr 26 2022, 10:20 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.

-addressed comments
-added call to AIXDumpExtractor that I forgot to add earlier..

Apr 26 2022, 10:17 AM · Restricted Project, Restricted Project

Apr 25 2022

Jake-Egan added a comment to D124250: [Serialization] write expr dependence bits as a single integer.

Thanks @sammccall, the test is passing now.

Apr 25 2022, 10:04 AM · Restricted Project, Restricted Project
Jake-Egan added a comment to D124250: [Serialization] write expr dependence bits as a single integer.

Hi, this broke a test on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/903/steps/6/logs/FAIL__Clang__pch-with-module_m

Apr 25 2022, 7:59 AM · Restricted Project, Restricted Project

Apr 23 2022

Jake-Egan added a comment to D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.

It's something unique to AIX that we add shared objects to archives for our usual shared library implementation. I'm guessing with this implementation of the patch, we'll end up dumping all symbols together regardless of what archive member they belong to?

(Perhaps that's an acceptable limitation for the moment, since in the libc++ build we will only typically have the one shared object)

Apr 23 2022, 12:31 PM · Restricted Project, Restricted Project

Apr 22 2022

Jake-Egan updated the diff for D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.

Removed -X32_64 flag

Apr 22 2022, 9:10 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.

Added 32 bit abilist and fixed a typo.

Apr 22 2022, 8:23 AM · Restricted Project, Restricted Project

Apr 21 2022

Jake-Egan added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

@aaron.ballman Here are all the errors. Thanks!

Apr 21 2022, 12:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Jake-Egan added a comment to D122316: Guard visibility variables on AIX.

LGTM as an interm fix. We'll revert and replace this once we have a fix in Google Benchmark.

Apologies if I missed it, has the google/benchmarks PR been submitted? Thanks!

Apr 21 2022, 7:52 AM · Restricted Project
Jake-Egan added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Hi, we also have a failure on AIX with test-suite call to undeclared library function '%0' with type %1; ISO C99 and later https://lab.llvm.org/buildbot/#/builders/214/builds/825/steps/9/logs/stdio

Apr 21 2022, 7:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the summary of D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.
Apr 21 2022, 6:30 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D124165: [libcxx][AIX] Enable ABI list checking for XCOFF.
Apr 21 2022, 6:29 AM · Restricted Project, Restricted Project

Apr 19 2022

Jake-Egan added a comment to D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..

Hi, unfortunately there's a build failure on AIX: https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. Could you take a look?

Apr 19 2022, 5:53 PM · Restricted Project, Restricted Project

Apr 5 2022

Jake-Egan committed rGf9e0bc37dbf7: Specify --format for tests to workaround AIX big archive write operation (authored by Jake-Egan).
Specify --format for tests to workaround AIX big archive write operation
Apr 5 2022, 11:37 AM · Restricted Project, Restricted Project
Jake-Egan closed D123063: Specify --format for tests to workaround AIX big archive write operation.
Apr 5 2022, 11:36 AM · Restricted Project, Restricted Project

Apr 4 2022

Jake-Egan updated the summary of D123063: Specify --format for tests to workaround AIX big archive write operation.
Apr 4 2022, 12:44 PM · Restricted Project, Restricted Project
Jake-Egan requested review of D123063: Specify --format for tests to workaround AIX big archive write operation.
Apr 4 2022, 12:42 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D122949: [AIX] XFAIL tests because of no big archive writer operation support.

The patch D122746 XFAILed the archive writer tests in llvm/test/Object and llvm/test/tools/llvm-ar, but it missed the 5 tests in this patch. There aren't any other tests that need to be dealt with at the moment. I agree UNSUPPORTED probably makes more sense, but I was trying to be consistent with the other patch.

I considered this when reviewing, but I actually think XFAIL is better, because there are reasonably near term plans to implement the functionality. Marking as UNSUPPORTED would mean the tests won't start XPASSing at that point, meaning they may never be run for the new format, even though they should be.

That being said, for tests not testing the archiver, but rather testing a different tool, you should instead use the explicit --format option, so that they continue working on AIX. Note that this is what the original patch did.

Apr 4 2022, 10:48 AM · Restricted Project, Restricted Project

Apr 2 2022

Jake-Egan added a comment to D122949: [AIX] XFAIL tests because of no big archive writer operation support.

The patch D122746 XFAILed the archive writer tests in llvm/test/Object and llvm/test/tools/llvm-ar, but it missed the 5 tests in this patch. There aren't any other tests that need to be dealt with at the moment. I agree UNSUPPORTED probably makes more sense, but I was trying to be consistent with the other patch.

Apr 2 2022, 5:50 AM · Restricted Project, Restricted Project

Apr 1 2022

Jake-Egan committed rG3db9fd51b515: [AIX] XFAIL tests because of no big archive writer operation support (authored by Jake-Egan).
[AIX] XFAIL tests because of no big archive writer operation support
Apr 1 2022, 7:40 PM · Restricted Project, Restricted Project
Jake-Egan closed D122949: [AIX] XFAIL tests because of no big archive writer operation support.
Apr 1 2022, 7:40 PM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D122949: [AIX] XFAIL tests because of no big archive writer operation support.
Apr 1 2022, 6:39 PM · Restricted Project, Restricted Project
Jake-Egan requested review of D122949: [AIX] XFAIL tests because of no big archive writer operation support.
Apr 1 2022, 6:37 PM · Restricted Project, Restricted Project

Mar 28 2022

Jake-Egan committed rGf5a9b5cc1265: [NFC][tests][AIX] XFAIL test for lack of visibility support (authored by Jake-Egan).
[NFC][tests][AIX] XFAIL test for lack of visibility support
Mar 28 2022, 6:44 AM · Restricted Project, Restricted Project
Jake-Egan closed D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support.
Mar 28 2022, 6:44 AM · Restricted Project, Restricted Project
Jake-Egan retitled D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support from [AIX] XFAIL test for lack of visibility support to [NFC][tests][AIX] XFAIL test for lack of visibility support.
Mar 28 2022, 6:40 AM · Restricted Project, Restricted Project

Mar 25 2022

Jake-Egan updated the diff for D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support.

Updated the comment.

Mar 25 2022, 7:16 PM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support.
Mar 25 2022, 7:14 PM · Restricted Project, Restricted Project
Jake-Egan requested review of D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support.
Mar 25 2022, 7:10 PM · Restricted Project, Restricted Project

Mar 24 2022

Jake-Egan added a comment to D122247: [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct.

Hi @Jake-Egan, not sure I understand. This change was checked in 22 Mar 13:55:47 but the changes tested in this build are from 23 Mar.
Is the test still failing?

Mar 24 2022, 10:37 AM · Restricted Project, Restricted Project

Mar 23 2022

Jake-Egan added a comment to D122247: [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct.

Hi, this change causes a LIT failure on AIX.

Mar 23 2022, 9:28 PM · Restricted Project, Restricted Project
Jake-Egan committed rTd785c299bdb9: Guard visibility variables on AIX (authored by Jake-Egan).
Guard visibility variables on AIX
Mar 23 2022, 1:11 PM · Restricted Project
Jake-Egan closed D122316: Guard visibility variables on AIX.
Mar 23 2022, 1:11 PM · Restricted Project
Jake-Egan requested review of D122316: Guard visibility variables on AIX.
Mar 23 2022, 11:58 AM · Restricted Project
Jake-Egan planned changes to D122316: Guard visibility variables on AIX.
Mar 23 2022, 8:20 AM · Restricted Project
Jake-Egan added a comment to D121343: Update benchmarks.

This patch adds visibility options, which isn't supported on AIX and causes build failure.
https://lab.llvm.org/buildbot/#/builders/214/builds/370/steps/9/logs/stdio

Mar 23 2022, 8:15 AM · Restricted Project
Jake-Egan updated the summary of D122316: Guard visibility variables on AIX.
Mar 23 2022, 7:53 AM · Restricted Project
Jake-Egan requested review of D122316: Guard visibility variables on AIX.
Mar 23 2022, 7:50 AM · Restricted Project

Mar 16 2022

Jake-Egan committed rGc7dc9dbaff3a: [VE] Remove output to /dev/stdout (authored by Jake-Egan).
[VE] Remove output to /dev/stdout
Mar 16 2022, 8:42 AM · Restricted Project
Jake-Egan closed D121799: [VE] Remove output to /dev/stdout.
Mar 16 2022, 8:42 AM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D121799: [VE] Remove output to /dev/stdout.
Mar 16 2022, 6:42 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D121799: [VE] Remove output to /dev/stdout.
Mar 16 2022, 6:39 AM · Restricted Project, Restricted Project

Mar 15 2022

Jake-Egan committed rGd1873d395d57: [NFC][AIX] Disable precompiled module file test on AIX (authored by Jake-Egan).
[NFC][AIX] Disable precompiled module file test on AIX
Mar 15 2022, 12:16 PM · Restricted Project
Jake-Egan closed D121709: [NFC][AIX] Disable precompiled module file test on AIX.
Mar 15 2022, 12:16 PM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D121709: [NFC][AIX] Disable precompiled module file test on AIX.
Mar 15 2022, 8:48 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D121709: [NFC][AIX] Disable precompiled module file test on AIX.
Mar 15 2022, 8:45 AM · Restricted Project, Restricted Project

Mar 3 2022

Jake-Egan committed rG3e8771917729: [libc++] Fix initialization of __fill_ (authored by Jake-Egan).
[libc++] Fix initialization of __fill_
Mar 3 2022, 6:29 AM · Restricted Project
Jake-Egan closed D120751: [libc++] Fix initialization of __fill_.
Mar 3 2022, 6:28 AM · Restricted Project, Restricted Project

Mar 2 2022

Jake-Egan updated the diff for D120751: [libc++] Fix initialization of __fill_.

Rebase to hopefully fix format check

Mar 2 2022, 12:59 PM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D120751: [libc++] Fix initialization of __fill_.
Mar 2 2022, 6:40 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D120751: [libc++] Fix initialization of __fill_.

Thanks for the review. I removed the flag and new test. I modified the existing test for fill(char_type) to test the initialization of the fill character on the first call. This test was passing because it called fill() first in the assert. Calling fill() first is already tested in fill.pass.cpp

Mar 2 2022, 6:39 AM · Restricted Project, Restricted Project

Mar 1 2022

Jake-Egan updated the diff for D120751: [libc++] Fix initialization of __fill_.

Fix indentation.

Mar 1 2022, 10:48 AM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D120751: [libc++] Fix initialization of __fill_.
Mar 1 2022, 10:18 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D120751: [libc++] Fix initialization of __fill_.
Mar 1 2022, 10:13 AM · Restricted Project, Restricted Project

Feb 15 2022

Jake-Egan planned changes to D119441: [libc++] Fix locale name construction.
Feb 15 2022, 12:00 PM · Restricted Project, Restricted Project

Feb 10 2022

Jake-Egan updated the summary of D119441: [libc++] Fix locale name construction.
Feb 10 2022, 7:30 AM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D119441: [libc++] Fix locale name construction.
Feb 10 2022, 7:22 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D119441: [libc++] Fix locale name construction.
Feb 10 2022, 7:20 AM · Restricted Project, Restricted Project

Feb 1 2022

Jake-Egan committed rG87387c403b47: [AIX] Bump DWARF versions to 3 because XCOFF64 requires DWARF64 (authored by Jake-Egan).
[AIX] Bump DWARF versions to 3 because XCOFF64 requires DWARF64
Feb 1 2022, 8:18 AM
Jake-Egan closed D114110: [AIX] Bump DWARF versions to 3 because XCOFF64 requires DWARF64.
Feb 1 2022, 8:18 AM · Restricted Project

Jan 31 2022

Jake-Egan retitled D114110: [AIX] Bump DWARF versions to 3 because XCOFF64 requires DWARF64 from [AIX] Mark tests using DWARF version less than 3 as unsupported because XCOFF64 requires DWARF64 to [AIX] Bump DWARF versions to 3 because XCOFF64 requires DWARF64.
Jan 31 2022, 12:11 PM · Restricted Project
Jake-Egan updated the diff for D114110: [AIX] Bump DWARF versions to 3 because XCOFF64 requires DWARF64.

Updated patch to bump dwarf versions instead.

Jan 31 2022, 12:09 PM · Restricted Project

Jan 28 2022

Jake-Egan committed rG6f4f745668ec: [clang][deps] Adapt test to be compatible when the assembler is called by… (authored by Jake-Egan).
[clang][deps] Adapt test to be compatible when the assembler is called by…
Jan 28 2022, 8:40 AM
Jake-Egan closed D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default.
Jan 28 2022, 8:40 AM · Restricted Project
Jake-Egan accepted D118477: [NFC][AIX]Disable new pcm tests on AIX.

LGTM.

Jan 28 2022, 8:10 AM · Restricted Project

Jan 27 2022

Jake-Egan updated the diff for D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default.

Fixed diff.

Jan 27 2022, 12:52 PM · Restricted Project
Jake-Egan updated the diff for D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default.

Updated patch to use a more accurate check.

Jan 27 2022, 12:46 PM · Restricted Project

Jan 25 2022

Jake-Egan added inline comments to D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default.
Jan 25 2022, 9:57 AM · Restricted Project
Jake-Egan updated the summary of D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default.
Jan 25 2022, 8:18 AM · Restricted Project
Jake-Egan requested review of D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default.
Jan 25 2022, 8:15 AM · Restricted Project

Jan 21 2022

Jake-Egan committed rGf24fe96f469b: [ifs] Use a tmp file instead of "-" (authored by Jake-Egan).
[ifs] Use a tmp file instead of "-"
Jan 21 2022, 8:24 AM
Jake-Egan closed D117587: [ifs] Use a tmp file instead of "-".
Jan 21 2022, 8:24 AM · Restricted Project

Jan 19 2022

Jake-Egan added inline comments to D117587: [ifs] Use a tmp file instead of "-".
Jan 19 2022, 8:24 AM · Restricted Project
Jake-Egan updated the diff for D117587: [ifs] Use a tmp file instead of "-".

Removed the unncessary pipe.

Jan 19 2022, 8:23 AM · Restricted Project

Jan 18 2022

Jake-Egan added a reviewer for D117587: [ifs] Use a tmp file instead of "-": hubert.reinterpretcast.
Jan 18 2022, 10:42 AM · Restricted Project
Jake-Egan retitled D117587: [ifs] Use a tmp file instead of "-" from [ifs] Use a tmp file instead of - to [ifs] Use a tmp file instead of "-".
Jan 18 2022, 10:40 AM · Restricted Project
Jake-Egan requested review of D117587: [ifs] Use a tmp file instead of "-".
Jan 18 2022, 10:39 AM · Restricted Project

Jan 17 2022

Jake-Egan committed rG6f0977519d12: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString (authored by Jake-Egan).
[AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString
Jan 17 2022, 8:24 AM
Jake-Egan closed D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString.
Jan 17 2022, 8:24 AM · Restricted Project

Jan 14 2022

Jake-Egan updated the summary of D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString.
Jan 14 2022, 7:16 AM · Restricted Project
Jake-Egan requested review of D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString.
Jan 14 2022, 7:11 AM · Restricted Project

Jan 9 2022

Jake-Egan committed rGfbf52caf58b3: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support (authored by Jake-Egan).
[AIX] Disable tests that fail because of no 64-bit XCOFF object file support
Jan 9 2022, 9:27 AM
Jake-Egan closed D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Jan 9 2022, 9:26 AM · Restricted Project, Restricted Project

Jan 6 2022

Jake-Egan updated the summary of D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Jan 6 2022, 10:30 AM · Restricted Project, Restricted Project