@arphaman Thanks for the quick action. The tests pass on a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/1493, so that's probably why there was trouble reproducing. I think we could revert 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9.

Hi, these tests fail on AIX, could you take a look please?

@bd1976llvm
Thanks, the test is passing now.

Hi, this test is failing on AIX because the default archive format is big archive. So when this test checks for !<arch> it sees <bigaf> instead.
https://lab.llvm.org/buildbot/#/builders/214/builds/1314/steps/6/logs/FAIL__LLVM__mri-create-overwrite_test

check-all is green on AIX.

In D125482#3510072, @bzcheeseman wrote:

In D125482#3510066, @Jake-Egan wrote:

Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio

I applied your patch here and it seems to fix the original error, but there is a new one:

/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:69:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(D);
  ^~~~~~~~~~~~~~~~ ~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:70:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(BD);
  ^~~~~~~~~~~~~~~~ ~~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:71:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyDerivedType>(BD);
  ^~~~~~~~~~~~~~~~~~~ ~~

This commit went in last night it looks like to fix that: 52328dafda13711653fd15aa4db34db350471a1f

Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio

Hi, this patch causes a test failure on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1221/steps/6/logs/FAIL__Clang__noinline_cu

4 of the tests fail on AIX also: https://lab.llvm.org/buildbot/#/builders/214/builds/1207

Simplify '.a' extension check

-addressed comments
-added call to AIXDumpExtractor that I forgot to add earlier..

Thanks @sammccall, the test is passing now.

Hi, this broke a test on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/903/steps/6/logs/FAIL__Clang__pch-with-module_m

In D124165#3464783, @daltenty wrote:

It's something unique to AIX that we add shared objects to archives for our usual shared library implementation. I'm guessing with this implementation of the patch, we'll end up dumping all symbols together regardless of what archive member they belong to?

(Perhaps that's an acceptable limitation for the moment, since in the libc++ build we will only typically have the one shared object)

Removed -X32_64 flag

Added 32 bit abilist and fixed a typo.

@aaron.ballman Here are all the errors. Thanks!

In D122316#3457227, @mtrofin wrote:

In D122316#3403326, @daltenty wrote:

LGTM as an interm fix. We'll revert and replace this once we have a fix in Google Benchmark.

Apologies if I missed it, has the google/benchmarks PR been submitted? Thanks!

Hi, we also have a failure on AIX with test-suite call to undeclared library function '%0' with type %1; ISO C99 and later https://lab.llvm.org/buildbot/#/builders/214/builds/825/steps/9/logs/stdio

Hi, unfortunately there's a build failure on AIX: https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. Could you take a look?

In D122949#3425633, @jhenderson wrote:

In D122949#3424498, @Jake-Egan wrote:

The patch D122746 XFAILed the archive writer tests in llvm/test/Object and llvm/test/tools/llvm-ar, but it missed the 5 tests in this patch. There aren't any other tests that need to be dealt with at the moment. I agree UNSUPPORTED probably makes more sense, but I was trying to be consistent with the other patch.

I considered this when reviewing, but I actually think XFAIL is better, because there are reasonably near term plans to implement the functionality. Marking as UNSUPPORTED would mean the tests won't start XPASSing at that point, meaning they may never be run for the new format, even though they should be.

That being said, for tests not testing the archiver, but rather testing a different tool, you should instead use the explicit --format option, so that they continue working on AIX. Note that this is what the original patch did.

The patch D122746 XFAILed the archive writer tests in llvm/test/Object and llvm/test/tools/llvm-ar, but it missed the 5 tests in this patch. There aren't any other tests that need to be dealt with at the moment. I agree UNSUPPORTED probably makes more sense, but I was trying to be consistent with the other patch.

Updated the comment.

In D122247#3405670, @mikerice wrote:

In D122247#3404533, @Jake-Egan wrote:

Hi, this change causes a LIT failure on AIX.

https://lab.llvm.org/buildbot/#/builders/214/builds/374/steps/6/logs/FAIL__Clang__index-source_m

Hi @Jake-Egan, not sure I understand. This change was checked in 22 Mar 13:55:47 but the changes tested in this build are from 23 Mar.
Is the test still failing?

Hi, this change causes a LIT failure on AIX.

This patch adds visibility options, which isn't supported on AIX and causes build failure.
https://lab.llvm.org/buildbot/#/builders/214/builds/370/steps/9/logs/stdio

Rebase to hopefully fix format check

Thanks for the review. I removed the flag and new test. I modified the existing test for fill(char_type) to test the initialization of the fill character on the first call. This test was passing because it called fill() first in the assert. Calling fill() first is already tested in fill.pass.cpp

Fix indentation.

Updated patch to bump dwarf versions instead.

LGTM.

Fixed diff.

Updated patch to use a more accurate check.

Removed the unncessary pipe.