Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Feed Advanced Search

Wed, Sep 20

Jake-Egan updated the diff for D149660: [libc++][AIX] Add OS version to target triple.

rebase

Wed, Sep 20, 6:37 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 13

Jake-Egan added a comment to D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`.

@jansvoboda11 Actually, we could give you access to an AIX machine to debug this. Would that work for you?

Wed, Sep 13, 12:26 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`.

@jansvoboda11 Thanks for taking care of the other tests. I'm not sure how this could be reproduced not on AIX. I'll have to investigate.

Wed, Sep 13, 6:38 AM · Restricted Project, Restricted Project

Fri, Sep 8

Jake-Egan committed rG8a79af676d30: [libc++][AIX] Remove hardcode fail from format test (authored by Jake-Egan).
[libc++][AIX] Remove hardcode fail from format test
Fri, Sep 8, 10:40 AM · Restricted Project, Restricted Project
Jake-Egan closed D150273: [libc++][AIX] Remove hardcode fail from format test.
Fri, Sep 8, 10:40 AM · Restricted Project, Restricted Project

Wed, Sep 6

Jake-Egan updated the diff for D149660: [libc++][AIX] Add OS version to target triple.

Added a comment and rebase

Wed, Sep 6, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the diff for D150273: [libc++][AIX] Remove hardcode fail from format test.

Restore patch (lost part of the patch when rebasing)

Wed, Sep 6, 7:18 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D150273: [libc++][AIX] Remove hardcode fail from format test.

rebase

Wed, Sep 6, 7:16 AM · Restricted Project, Restricted Project

Thu, Aug 31

Jake-Egan added a comment to D149660: [libc++][AIX] Add OS version to target triple.

It looks like this PR isn't configured right to run the libc++ CI

Thu, Aug 31, 8:00 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2023

Jake-Egan committed rG86337beca2e6: [AIX][ClangRepl] Disable new tests on AIX (authored by Jake-Egan).
[AIX][ClangRepl] Disable new tests on AIX
Aug 30 2023, 6:36 PM · Restricted Project, Restricted Project
Jake-Egan closed D159213: [AIX][ClangRepl] Disable new tests on AIX.
Aug 30 2023, 6:36 PM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D149660: [libc++][AIX] Add OS version to target triple.

rebase

Aug 30 2023, 12:22 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the summary of D159213: [AIX][ClangRepl] Disable new tests on AIX.
Aug 30 2023, 9:23 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D159213: [AIX][ClangRepl] Disable new tests on AIX.
Aug 30 2023, 9:15 AM · Restricted Project, Restricted Project

Aug 29 2023

Jake-Egan added a comment to D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`.

Sorry for the late response @jansvoboda11, when lookupModuleFile is called, the file build/tools/clang/test/Index/Core/Output/index-with-module.m.tmp.mcp/A03A61VI43WA/ModA-21USRMHJNU3PG.pcm doesn't exist. So it seems there's some issue with the creation of the file.

Aug 29 2023, 7:59 PM · Restricted Project, Restricted Project
Jake-Egan added inline comments to D149660: [libc++][AIX] Add OS version to target triple.
Aug 29 2023, 9:03 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the diff for D149660: [libc++][AIX] Add OS version to target triple.

Get full AIX version

Aug 29 2023, 8:50 AM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2023

Jake-Egan accepted D156921: [Orc][rtlib] Build orc runtime support for ppc64 only under Linux.

LGTM, thanks

Aug 2 2023, 12:53 PM · Restricted Project, Restricted Project

Jul 20 2023

Jake-Egan committed rG311abf5fc07a: Implement -frecord-command-line for XCOFF integrated assembler path (authored by Jake-Egan).
Implement -frecord-command-line for XCOFF integrated assembler path
Jul 20 2023, 6:46 AM · Restricted Project, Restricted Project
Jake-Egan closed D154921: Implement -frecord-command-line for XCOFF integrated assembler path.
Jul 20 2023, 6:46 AM · Restricted Project, Restricted Project

Jul 19 2023

Jake-Egan committed rG0680ca7f8c38: [InstrProf][NFC] Ignore -Wcast-qual after D153911 to fix build failure on AIX (authored by Jake-Egan).
[InstrProf][NFC] Ignore -Wcast-qual after D153911 to fix build failure on AIX
Jul 19 2023, 10:53 AM · Restricted Project, Restricted Project

Jul 18 2023

Jake-Egan committed rGd2884a234a4a: [NFC][XCOFF] Remove curly braces from single line if statement (authored by Jake-Egan).
[NFC][XCOFF] Remove curly braces from single line if statement
Jul 18 2023, 8:36 PM · Restricted Project, Restricted Project
Jake-Egan retitled D154921: Implement -frecord-command-line for XCOFF integrated assembler path from Support -frecord-command-line for XCOFF integrated assembler path to Implement -frecord-command-line for XCOFF integrated assembler path.
Jul 18 2023, 8:23 PM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D154921: Implement -frecord-command-line for XCOFF integrated assembler path.

Thanks for the reviews. Just made some small changes:

  • Changed the write order of the info section to match XCOFF convention
  • Use advanceFileOffset now that it has landed
Jul 18 2023, 8:08 PM · Restricted Project, Restricted Project
Jake-Egan committed rGecbc812e0cca: [NFC][XCOFF] Use common function to calculate file offset (authored by Jake-Egan).
[NFC][XCOFF] Use common function to calculate file offset
Jul 18 2023, 7:09 PM · Restricted Project, Restricted Project
Jake-Egan closed D155199: [NFC][XCOFF] Use common function to calculate file offset.
Jul 18 2023, 7:09 PM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D155199: [NFC][XCOFF] Use common function to calculate file offset.

rerun CI

Jul 18 2023, 12:14 PM · Restricted Project, Restricted Project

Jul 17 2023

Jake-Egan updated the diff for D155199: [NFC][XCOFF] Use common function to calculate file offset.

-Return the new RawPointer
-Added a TODO

Jul 17 2023, 9:12 PM · Restricted Project, Restricted Project

Jul 13 2023

Jake-Egan updated the diff for D154921: Implement -frecord-command-line for XCOFF integrated assembler path.

Update patch

Jul 13 2023, 9:07 PM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D155199: [NFC][XCOFF] Use common function to calculate file offset.

Update patch

Jul 13 2023, 7:10 PM · Restricted Project, Restricted Project
Jake-Egan added inline comments to D154921: Implement -frecord-command-line for XCOFF integrated assembler path.
Jul 13 2023, 9:11 AM · Restricted Project, Restricted Project
Jake-Egan added reviewers for D155199: [NFC][XCOFF] Use common function to calculate file offset: scott.linder, sfertile, stephenpeckham, hubert.reinterpretcast.
Jul 13 2023, 9:06 AM · Restricted Project, Restricted Project
Jake-Egan added inline comments to D154921: Implement -frecord-command-line for XCOFF integrated assembler path.
Jul 13 2023, 9:05 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D154921: Implement -frecord-command-line for XCOFF integrated assembler path.

Addressed comments

Jul 13 2023, 8:59 AM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D155199: [NFC][XCOFF] Use common function to calculate file offset.
Jul 13 2023, 6:41 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D155199: [NFC][XCOFF] Use common function to calculate file offset.
Jul 13 2023, 6:38 AM · Restricted Project, Restricted Project

Jul 11 2023

Jake-Egan updated the diff for D154921: Implement -frecord-command-line for XCOFF integrated assembler path.

Remove old comment

Jul 11 2023, 7:56 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D154921: Implement -frecord-command-line for XCOFF integrated assembler path.

Fix endianness of the padding.

Jul 11 2023, 7:54 AM · Restricted Project, Restricted Project

Jul 10 2023

Jake-Egan retitled D154921: Implement -frecord-command-line for XCOFF integrated assembler path from Support -frecord-command-line on XCOFF integrated assembler path to Support -frecord-command-line for XCOFF integrated assembler path.
Jul 10 2023, 10:50 PM · Restricted Project, Restricted Project
Jake-Egan requested review of D154921: Implement -frecord-command-line for XCOFF integrated assembler path.
Jul 10 2023, 10:45 PM · Restricted Project, Restricted Project
Jake-Egan committed rGbbd0d123d3aa: Implement -frecord-command-line for XCOFF (authored by Jake-Egan).
Implement -frecord-command-line for XCOFF
Jul 10 2023, 9:47 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan closed D153600: Implement -frecord-command-line for XCOFF.
Jul 10 2023, 9:47 AM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2023

Jake-Egan committed rG643b7bcdb404: [libc++] Fix simple cases of locale name construction (authored by Jake-Egan).
[libc++] Fix simple cases of locale name construction
Jul 8 2023, 7:04 PM · Restricted Project, Restricted Project
Jake-Egan closed D119441: [libc++] Fix simple cases of locale name construction.
Jul 8 2023, 7:03 PM · Restricted Project, Restricted Project

Jul 6 2023

Jake-Egan updated the diff for D119441: [libc++] Fix simple cases of locale name construction.

Remove whitespace

Jul 6 2023, 10:21 AM · Restricted Project, Restricted Project

Jul 5 2023

Jake-Egan added inline comments to D153600: Implement -frecord-command-line for XCOFF.
Jul 5 2023, 8:12 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the diff for D153600: Implement -frecord-command-line for XCOFF.

Address comments

Jul 5 2023, 8:09 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan added a comment to D143241: [Clang] Reset FP options before function instantiations.

Hi, the following assertion is getting tripped on AIX:

Jul 5 2023, 7:04 PM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D119441: [libc++] Fix simple cases of locale name construction.

Thanks @ldionne

Jul 5 2023, 6:04 PM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D153600: Implement -frecord-command-line for XCOFF.

Rerun CI

Jul 5 2023, 8:56 AM · Restricted Project, Restricted Project, Restricted Project

Jul 4 2023

Jake-Egan updated the diff for D153600: Implement -frecord-command-line for XCOFF.

Fix formatting

Jul 4 2023, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the diff for D153600: Implement -frecord-command-line for XCOFF.

Updated to use both a newline and null byte to separate command lines.

Jul 4 2023, 12:31 PM · Restricted Project, Restricted Project, Restricted Project

Jul 3 2023

Jake-Egan updated the diff for D153600: Implement -frecord-command-line for XCOFF.

Thanks for the review @stephenpeckham, I updated the patch with the requested changes.

Jul 3 2023, 6:47 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the diff for D153600: Implement -frecord-command-line for XCOFF.

Fix formatting

Jul 3 2023, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan added inline comments to D153600: Implement -frecord-command-line for XCOFF.
Jul 3 2023, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan added inline comments to D153600: Implement -frecord-command-line for XCOFF.
Jul 3 2023, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the diff for D153600: Implement -frecord-command-line for XCOFF.

Thanks for the review @scott.linder. I applied the changes you requested with some differences.

Jul 3 2023, 9:26 AM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2023

Jake-Egan committed rG5456f16303d9: [AIX][tests] Disable test for missing DWARF section (authored by Jake-Egan).
[AIX][tests] Disable test for missing DWARF section
Jun 27 2023, 5:55 PM · Restricted Project, Restricted Project
Jake-Egan committed rGbc3e71a945cd: [llvm-exegesis][NFC] Fix unused function 'IsMovRegToReg' warning (authored by Jake-Egan).
[llvm-exegesis][NFC] Fix unused function 'IsMovRegToReg' warning
Jun 27 2023, 10:02 AM · Restricted Project, Restricted Project

Jun 26 2023

Jake-Egan added a comment to D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class.

I'm not sure if it's this commit or one of the other llvm-exegesis commits you pushed, but there's a build failure on AIX now:

/scratch/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/tools/llvm-exegesis/lib/X86/Target.cpp:49:33: error: unused variable 'VAddressSpaceCeiling' [-Werror,-Wunused-const-variable]
static constexpr const intptr_t VAddressSpaceCeiling = 0x0000800000000000;

https://lab.llvm.org/buildbot/#/builders/214/builds/8173/steps/5/logs/stdio

Jun 26 2023, 5:46 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D153595: [llvm-addr2line] Replace checkFileExists with getOrCreateModuleInfo.

@sepavloff Thanks, that should address it

Jun 26 2023, 10:42 AM · Restricted Project, Restricted Project
Jake-Egan added a comment to D151567: [Support] Report EISDIR when opening a directory.

The test LLVM :: tools/llvm-symbolizer/input-file-err.test fails because it expects "Is a directory" as an error message, but we currently get "The file was not recognized as a valid object file" on AIX.
https://lab.llvm.org/buildbot/#/builders/214/builds/8134/steps/6/logs/FAIL__LLVM__input-file-err_test

Jun 26 2023, 10:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Jake-Egan committed rG64ca650cf9f1: [AIX][tests] XFAIL input-file-err.test (authored by Jake-Egan).
[AIX][tests] XFAIL input-file-err.test
Jun 26 2023, 10:27 AM · Restricted Project, Restricted Project
Jake-Egan added a comment to D153595: [llvm-addr2line] Replace checkFileExists with getOrCreateModuleInfo.

Hi, on AIX we're getting the error: "The file was not recognized as a valid object file instead of the expected error"

Jun 26 2023, 6:43 AM · Restricted Project, Restricted Project

Jun 22 2023

Jake-Egan added a reviewer for D153600: Implement -frecord-command-line for XCOFF: scott.linder.
Jun 22 2023, 6:09 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the summary of D153600: Implement -frecord-command-line for XCOFF.
Jun 22 2023, 5:58 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the summary of D153600: Implement -frecord-command-line for XCOFF.
Jun 22 2023, 5:55 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan added reviewers for D153600: Implement -frecord-command-line for XCOFF: nicolerabjohn, hubert.reinterpretcast, sfertile, stephenpeckham, rzurob.
Jun 22 2023, 5:54 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the summary of D153600: Implement -frecord-command-line for XCOFF.
Jun 22 2023, 5:48 PM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan requested review of D153600: Implement -frecord-command-line for XCOFF.
Jun 22 2023, 5:46 PM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2023

Jake-Egan committed rG985daceac9cb: [AIX][tests] Temporarily disable test index-with-module.m (authored by Jake-Egan).
[AIX][tests] Temporarily disable test index-with-module.m
Jun 15 2023, 10:24 PM · Restricted Project, Restricted Project
Jake-Egan committed rGf4b58f8d22bc: [AIX] Disable test for missing DWARF section (authored by Jake-Egan).
[AIX] Disable test for missing DWARF section
Jun 15 2023, 9:35 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`.

Hi, there's a test failure on AIX, could you take a look please?

Jun 15 2023, 1:52 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D152709: [lit] Avoid os.path.realpath in lit.py due to MAX_PATH limitations on Windows.

This caused a failure on AIX
https://lab.llvm.org/buildbot/#/builders/214/builds/7990/steps/6/logs/FAIL__lit___use-llvm-tool_py

Jun 15 2023, 6:53 AM · Restricted Project, Restricted Project

Jun 5 2023

Jake-Egan added a comment to D119441: [libc++] Fix simple cases of locale name construction.

Ping

Jun 5 2023, 8:46 AM · Restricted Project, Restricted Project

May 19 2023

Jake-Egan planned changes to D149660: [libc++][AIX] Add OS version to target triple.
May 19 2023, 6:35 AM · Restricted Project, Restricted Project, Restricted Project

May 15 2023

Jake-Egan added a reverting change for rG25dc215ddaa6: [AIX][tests] XFAIL -ftime-trace test for now: rG8097d01260fc: Revert "[AIX][tests] XFAIL -ftime-trace test for now".
May 15 2023, 10:51 AM · Restricted Project, Restricted Project
Jake-Egan committed rG8097d01260fc: Revert "[AIX][tests] XFAIL -ftime-trace test for now" (authored by Jake-Egan).
Revert "[AIX][tests] XFAIL -ftime-trace test for now"
May 15 2023, 10:50 AM · Restricted Project, Restricted Project
Jake-Egan added a comment to D119441: [libc++] Fix simple cases of locale name construction.

I see several comments off @ldionne and @hubert.reinterpretcast not marked as done. Are they done?

May 15 2023, 6:35 AM · Restricted Project, Restricted Project

May 14 2023

Jake-Egan added a comment to D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir.

Hi, this fails on AIX. It looks like it still produces the /tmp/lit-tmp-*/[ab]-*.json format. Can you take a look please?

May 14 2023, 10:45 PM · Restricted Project, Restricted Project
Jake-Egan committed rG25dc215ddaa6: [AIX][tests] XFAIL -ftime-trace test for now (authored by Jake-Egan).
[AIX][tests] XFAIL -ftime-trace test for now
May 14 2023, 10:41 PM · Restricted Project, Restricted Project

May 10 2023

Jake-Egan requested review of D150273: [libc++][AIX] Remove hardcode fail from format test.
May 10 2023, 7:55 AM · Restricted Project, Restricted Project

May 9 2023

Jake-Egan updated the diff for D119441: [libc++] Fix simple cases of locale name construction.
May 9 2023, 6:19 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D119441: [libc++] Fix simple cases of locale name construction.
May 9 2023, 6:09 AM · Restricted Project, Restricted Project

May 8 2023

Jake-Egan updated the diff for D119441: [libc++] Fix simple cases of locale name construction.
  • Trigger CI
May 8 2023, 12:12 PM · Restricted Project, Restricted Project
Jake-Egan added a comment to D119441: [libc++] Fix simple cases of locale name construction.

Ping

May 8 2023, 12:11 PM · Restricted Project, Restricted Project
Jake-Egan committed rG7ad7b3275f70: [AIX] Adjust support of format function tests (authored by Jake-Egan).
[AIX] Adjust support of format function tests
May 8 2023, 10:41 AM · Restricted Project, Restricted Project
Jake-Egan closed D149078: [AIX] Adjust support of format function tests.
May 8 2023, 10:41 AM · Restricted Project, Restricted Project
Jake-Egan committed rGefd0b42171e9: [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test (authored by Jake-Egan).
[libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test
May 8 2023, 7:54 AM · Restricted Project, Restricted Project
Jake-Egan closed D149255: [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test.
May 8 2023, 7:54 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D149078: [AIX] Adjust support of format function tests.
  • Trigger CI
May 8 2023, 6:31 AM · Restricted Project, Restricted Project

May 4 2023

Jake-Egan updated the diff for D149078: [AIX] Adjust support of format function tests.
  • Trigger CI
May 4 2023, 10:15 AM · Restricted Project, Restricted Project

May 3 2023

Jake-Egan added a comment to D148916: [Support][Parallel] Initialize threadIndex and add assertion checking its usage..

My mistake, I confirmed locally that it's D149173. Thanks

May 3 2023, 10:48 AM · Restricted Project, Restricted Project
Jake-Egan added a comment to D148916: [Support][Parallel] Initialize threadIndex and add assertion checking its usage..

It looks like this caused a failure on AIX, could you take a look please?

May 3 2023, 6:30 AM · Restricted Project, Restricted Project

May 2 2023

Jake-Egan added reviewers for D149660: [libc++][AIX] Add OS version to target triple: Restricted Project, Restricted Project, Restricted Project.
May 2 2023, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the summary of D149660: [libc++][AIX] Add OS version to target triple.
May 2 2023, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan requested review of D149660: [libc++][AIX] Add OS version to target triple.
May 2 2023, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
Jake-Egan updated the diff for D149078: [AIX] Adjust support of format function tests.
  • Trigger CI
May 2 2023, 6:18 AM · Restricted Project, Restricted Project

May 1 2023

Jake-Egan added a comment to D149078: [AIX] Adjust support of format function tests.

Since I don't have access to a system with a 16-bit wchar_t it would be great if you could look at fixing the tests too.

May 1 2023, 7:11 AM · Restricted Project, Restricted Project
Jake-Egan requested review of D149255: [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test.
May 1 2023, 6:40 AM · Restricted Project, Restricted Project