Page MenuHomePhabricator
Feed Advanced Search

Tue, Sep 6

phisiart retitled D133260: [DO NOT SUBMIT] [mlir][dataflow] Let ConstantValue::dialect also participate in comparison. from [mlir][dataflow] Let ConstantValue::dialect also participate in comparison. to [DO NOT SUBMIT] [mlir][dataflow] Let ConstantValue::dialect also participate in comparison..
Tue, Sep 6, 9:55 AM · Restricted Project, Restricted Project

Mon, Sep 5

phisiart updated the diff for D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..

Initialize ConstantValue::dialect with nullptr.

Mon, Sep 5, 9:43 PM · Restricted Project, Restricted Project

Sat, Sep 3

phisiart updated the diff for D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..

Update the definition of ConstantValue into { Optional<Attribute> constant; Dialect *dialect; }.

Sat, Sep 3, 11:31 PM · Restricted Project, Restricted Project
phisiart added a comment to D133260: [DO NOT SUBMIT] [mlir][dataflow] Let ConstantValue::dialect also participate in comparison..

In this case, the actual values differ (1 vs 2) so they won't fold

Sat, Sep 3, 2:14 PM · Restricted Project, Restricted Project
phisiart added a comment to D133260: [DO NOT SUBMIT] [mlir][dataflow] Let ConstantValue::dialect also participate in comparison..

If two ConstantValues have the same constant but different dialects, then they are still unequal because they would materialize into different ops.

This isn't true. Most dialects upstream (and many downstream) use arith.constant.

This patch will unnecessarily impede hybrid dialect IRs from behaving nicely in SCCP

Sat, Sep 3, 2:04 PM · Restricted Project, Restricted Project
phisiart added a comment to D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..

It doesn't make sense to me that the fold result of a math.absi should differ from that of an arith.addi if their attributes are the same but their dialects are different (both dialects use arith.constant).

Sat, Sep 3, 2:01 PM · Restricted Project, Restricted Project
phisiart added a comment to D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..

Created https://reviews.llvm.org/D133260 for letting dialect participate in equality comparison. Will rebase this patch on top of that one.

Sat, Sep 3, 1:36 PM · Restricted Project, Restricted Project
phisiart added a reviewer for D133260: [DO NOT SUBMIT] [mlir][dataflow] Let ConstantValue::dialect also participate in comparison.: Mogball.
Sat, Sep 3, 1:35 PM · Restricted Project, Restricted Project
phisiart requested review of D133260: [DO NOT SUBMIT] [mlir][dataflow] Let ConstantValue::dialect also participate in comparison..
Sat, Sep 3, 1:34 PM · Restricted Project, Restricted Project
phisiart retitled D132800: [mlir][dataflow] Remove Lattice::isUninitialized(). from Remove Lattice::isUninitialized(). to [mlir][dataflow] Remove Lattice::isUninitialized()..
Sat, Sep 3, 1:30 PM · Restricted Project, Restricted Project
phisiart added a comment to D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..

Ugh that's true. Integer range inference (the test pass) is broken then. At least I wouldn't have the Impl struct and just have Optional<Attribute> with a Dialect * hanging around as metadata

Sat, Sep 3, 1:23 PM · Restricted Project, Restricted Project
phisiart added inline comments to D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..
Sat, Sep 3, 1:25 AM · Restricted Project, Restricted Project
phisiart requested review of D133250: [DO NOT SUBMIT] Remove ConstantValue::dialect..
Sat, Sep 3, 1:23 AM · Restricted Project, Restricted Project

Sat, Aug 27

phisiart updated the diff for D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..

Reformat.

Sat, Aug 27, 11:06 PM · Restricted Project, Restricted Project
phisiart added a reviewer for D132800: [mlir][dataflow] Remove Lattice::isUninitialized().: Mogball.
Sat, Aug 27, 3:18 PM · Restricted Project, Restricted Project
phisiart updated the summary of D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..
Sat, Aug 27, 3:18 PM · Restricted Project, Restricted Project
phisiart requested review of D132800: [mlir][dataflow] Remove Lattice::isUninitialized()..
Sat, Aug 27, 3:05 PM · Restricted Project, Restricted Project
phisiart removed a reviewer for D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState().: jsetoain.
Sat, Aug 27, 2:02 PM · Restricted Project, Restricted Project
phisiart added inline comments to D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..
Sat, Aug 27, 2:02 PM · Restricted Project, Restricted Project
phisiart updated the diff for D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..

Remove setValue() - join() should be enough for a monotonic framework.

Sat, Aug 27, 1:57 PM · Restricted Project, Restricted Project

Aug 24 2022

phisiart updated the diff for D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..

Reformat.

Aug 24 2022, 9:16 AM · Restricted Project, Restricted Project
phisiart updated the diff for D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..

Rebase.

Aug 24 2022, 1:46 AM · Restricted Project, Restricted Project

Aug 18 2022

phisiart added a comment to D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..

Can you take a look at the failures?

ConstantPropagationAnalysis.cpp:42:5: error: use of undeclared identifier 'markAllPessimisticFixpoint'
    markAllPessimisticFixpoint(results);
Aug 18 2022, 6:35 PM · Restricted Project, Restricted Project
phisiart updated the diff for D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..

Rename NonConstant to UnknownConstant.

Aug 18 2022, 6:21 PM · Restricted Project, Restricted Project

Aug 17 2022

phisiart updated the summary of D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..
Aug 17 2022, 6:47 PM · Restricted Project, Restricted Project
phisiart retitled D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState(). from Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState(). to [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..
Aug 17 2022, 5:42 PM · Restricted Project, Restricted Project
phisiart requested review of D132086: [mlir][dataflow] Consolidate AbstractSparseLattice::markPessimisticFixpoint() and AbstractDenseLattice::reset() into Abstract{Sparse,Dense}DataFlowAnalysis::setToEntryState()..
Aug 17 2022, 5:40 PM · Restricted Project, Restricted Project

Aug 11 2022

phisiart added a reviewer for D131746: [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize().: Mogball.
Aug 11 2022, 7:37 PM · Restricted Project, Restricted Project
phisiart retitled D131746: [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize(). from Remove the unused AnalysisState::defaultInitialize(). to [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize()..
Aug 11 2022, 7:36 PM · Restricted Project, Restricted Project
phisiart requested review of D131746: [mlir][dataflow] Remove the unused AnalysisState::defaultInitialize()..
Aug 11 2022, 7:35 PM · Restricted Project, Restricted Project
phisiart added a reviewer for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API: Mogball.
Aug 11 2022, 5:11 PM · Restricted Project, Restricted Project
phisiart added a comment to D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.

I am added as reviewer due to the trigger word "sparse" ;-), but this changes looks acceptable (perhap make it a bit more clear that is does change semantics beyond just removing the function in the title)

Aug 11 2022, 4:55 PM · Restricted Project, Restricted Project
phisiart retitled D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API from Remove isAtFixpoint(). to [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.
Aug 11 2022, 4:53 PM · Restricted Project, Restricted Project
phisiart updated the diff for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.

Also remove isAtFixpoint() from dense analysis.

Aug 11 2022, 4:31 PM · Restricted Project, Restricted Project
phisiart removed a reviewer for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API: aartbik.
Aug 11 2022, 2:16 AM · Restricted Project, Restricted Project
phisiart removed a reviewer for D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API: aartbik.
Aug 11 2022, 2:16 AM · Restricted Project, Restricted Project
phisiart requested review of D131660: [mlir][dataflow] Remove Abstract{Sparse,Dense}Lattice::isAtFixpoint() and an ineffective optimization to simplify public API.
Aug 11 2022, 1:58 AM · Restricted Project, Restricted Project
phisiart added a comment to D128868: [mlir][dataflow] (WIP) Overhaul analysis state management to support composability.

I think update() is better than manually calling propagateIfChanged() because it reduces the chance of misuse without requiring more code.

Aug 11 2022, 1:25 AM · Restricted Project, Restricted Project

Jun 24 2022

phisiart accepted D127173: [mlir] An implementation of dense data-flow analysis.
Jun 24 2022, 1:59 AM · Restricted Project, Restricted Project
phisiart added inline comments to D127139: [mlir] An implementation of sparse data-flow analysis.
Jun 24 2022, 1:09 AM · Restricted Project, Restricted Project
phisiart accepted D127139: [mlir] An implementation of sparse data-flow analysis.
Jun 24 2022, 12:47 AM · Restricted Project, Restricted Project

Jun 23 2022

phisiart accepted D127064: [mlir] Add Dead Code Analysis.
Jun 23 2022, 10:24 PM · Restricted Project, Restricted Project

Jun 13 2022

phisiart accepted D126751: [mlir] Add a generic data-flow analysis framework.
Jun 13 2022, 3:03 PM · Restricted Project, Restricted Project

Jun 9 2022

phisiart added inline comments to D126751: [mlir] Add a generic data-flow analysis framework.
Jun 9 2022, 12:58 AM · Restricted Project, Restricted Project

Jun 7 2022

phisiart added a comment to D126751: [mlir] Add a generic data-flow analysis framework.

Sorry for the delay, I'll leave some more comments tomorrow.

Jun 7 2022, 9:58 PM · Restricted Project, Restricted Project

Jun 2 2022

phisiart requested changes to D126751: [mlir] Add a generic data-flow analysis framework.
Jun 2 2022, 4:52 PM · Restricted Project, Restricted Project