LGTM with my limited knowledge of lld. Approving it as this is an extremely useful feature to have, and I want it to make progress after almost a year of staging.

It seems that there's no universal solution for overriding a symbol in a LIB by a symbol in another LIB...simply implementing the missing drivers with the LLD_IMPLEMENT_SHALLOW_DRIVER macro

Thanks for your work @aganea. I abstain from giving review from lld's implementation side but thing looks good on the ROCm.cpp unit test. (BTW, do you aim to create that unit test as a demo and then to remove it later? Or else i'd expect to see the "Inputs" folder mocked up in certain way.) Although I did notice a fair amount of test breakages on windows. If you are still actively working on it, I'm willing to approve it once you fix the test failures. Also I plan to give this a test by pulling this diff locally assuming the base of this diff wouldn't cause too much conflicts with our tip of clone.

@aganea If you'd be willing to pick this CL again within one/two month-ish timeline, that's great. I can help with testing since I'm a developer from ROCm side. Hopefully we can wrap this whole thing up by the end of this quarter. On the other hand, if this CL may not be your top priority to work on, and just want to let you know that I'd be willing to take over and finish the rest of work of it. But I have close to zero knowledge of the internals of LLD so may need your pointers and code reviews to make sure I'm on the right track.

But if others feel that we should have library-fication beforehand, I can clean this & add tests and make it ready for review.

May I ask what the state of this CL is @aganea? I bumped into this and think it is still quite useful so we should still shoot for landing it.

Close as submmited fb182028361504569ff6322bfa12b12e1ab74e30

Remove accidental change to clang-format

Added createLowerToCFGPass for scf.for lowering

LGTM

Landed in eedd8fe62e3896251d5fc60009af5659d990aaf9

Update CL header to include [mlir][rocdl]

Looks like this commit forget to update rocm unit tests.

Pushed to trunk revision: 2abad3433f9f48cb0a103726a9af1ad79603d23d

I'm pretty sure the build failure has nothing to do with this CL. I will wait till tomorrow to push it upstream if there's no further feedback to it. Thanks.

Resolve review feedbacks

Rebase and remove blank line at EOF

Fix clang-tidy warning by removing unecessary local varaible

Adjust instruction sequences, remove redundant curly braces

Adding addresspace check

In D81276#2080453, @nicolasvasilache wrote:

Could you please elaborate on your plans for this revision going forward?
@ThomasRaoux, @mravishankar and I are looking into directly using the vector dialect to target GPUs and this looks like this is going in a similar direction.

Address review feedbacks

Fix unit test typo

Misc update to align with local branch

Drop irrelevant file

LGTM

Good job, mostly minor issues, except the one related with the difference between mlir-rocm-runner and mlir-cuda-runner. Giving an accept to unblock future development, but we need to figure out the best way to resolve the differences between runner wrapper interfaces.

The CL has landed.

Inline printIntrinsic function

Fix lint error