Page MenuHomePhabricator
Feed Advanced Search

Wed, Aug 14

modocache accepted D66230: [coroutine] Fixes "cannot move instruction since its users are not dominated by CoroBegin" problem..

Thanks for looking into this, @GorNishanov! LGTM aside from a tiny nit-pick.

Wed, Aug 14, 12:25 PM · Restricted Project

Tue, Aug 13

modocache added a comment to D44672: [CodeGen] Disable UBSan for coroutine functions.

Thank you!

Tue, Aug 13, 5:04 AM · Restricted Project, Restricted Project
modocache committed rGf8d6836f7a69: [CodeGen] Disable UBSan for coroutine functions (authored by modocache).
[CodeGen] Disable UBSan for coroutine functions
Tue, Aug 13, 5:04 AM
modocache committed rL368675: [CodeGen] Disable UBSan for coroutine functions.
[CodeGen] Disable UBSan for coroutine functions
Tue, Aug 13, 5:03 AM
modocache closed D44672: [CodeGen] Disable UBSan for coroutine functions.
Tue, Aug 13, 5:03 AM · Restricted Project, Restricted Project

Sun, Aug 11

modocache added inline comments to D65149: [Format] Add test demonstrating PR42722.
Sun, Aug 11, 10:03 AM · Restricted Project

Fri, Aug 9

modocache updated the diff for D44672: [CodeGen] Disable UBSan for coroutine functions.

Thanks for the review, @vsk! Sorry it took me so long to update this diff.

Fri, Aug 9, 5:51 AM · Restricted Project, Restricted Project

Thu, Aug 8

modocache added inline comments to D65043: [Format] Add C++20 standard to style options.
Thu, Aug 8, 9:04 AM · Restricted Project
modocache updated the diff for D65043: [Format] Add C++20 standard to style options.

Thanks for the review, @Quuxplusone! I addressed your test comments, but the 'co_yield' test is something I think I'll need to deal with separately.

Thu, Aug 8, 9:01 AM · Restricted Project

Wed, Aug 7

modocache added a comment to D65043: [Format] Add C++20 standard to style options.

Friendly ping! @sammccall is this what you had in mind?

Wed, Aug 7, 10:17 AM · Restricted Project

Mon, Aug 5

modocache updated the diff for D65043: [Format] Add C++20 standard to style options.

Thanks for the reviews, @sammccall, @Quuxplusone, and @MyDeveloperDay. I added C++14 and C++17 options. In an earlier comment I mentioned splitting this work up into a series of commits, but it ended up being a smaller set of changes than I thought, so I'll just update this diff with all of the changes. What do you all think?

Mon, Aug 5, 7:23 AM · Restricted Project

Fri, Jul 26

modocache added inline comments to D65043: [Format] Add C++20 standard to style options.
Fri, Jul 26, 7:44 AM · Restricted Project
modocache added a comment to D65149: [Format] Add test demonstrating PR42722.

Sure thing! Just to be clear: this test doesn't fail, it passes. My intention was to commit this, then commit a patch that improved the indentation behavior, which would also include a change to the test that demonstrated the new behavior. But, as per your suggestion, I'll wait for the fix before committing this. Thanks!

Fri, Jul 26, 7:44 AM · Restricted Project

Jul 24 2019

modocache added a comment to D65043: [Format] Add C++20 standard to style options.

It sounds like currently they're very different, and you're proposing to make them basically the same. I think that's a good thing.

Jul 24 2019, 10:05 AM · Restricted Project

Jul 23 2019

modocache added a comment to D65183: [Format] Make it easy to add new format::FormatStyle::LanguageStandard. NFCI.

LGTM, but I don't actively work in this codebase so I really can't say. I'll wait to hear from some other more active clang-format reviewers.

Jul 23 2019, 8:40 PM · Restricted Project, Restricted Project
modocache added a reviewer for D65043: [Format] Add C++20 standard to style options: MyDeveloperDay.
Jul 23 2019, 6:58 PM · Restricted Project
modocache added a comment to D65043: [Format] Add C++20 standard to style options.

Friendly ping! I'm wondering, from the clang-format maintainers' point of view, whether a diff like this and https://reviews.llvm.org/D65044 make sense to add? I do think that it is useful for users to specify whether they wish to use C++11 or C++20 constructs, but I'm not an expert.

Jul 23 2019, 10:39 AM · Restricted Project
modocache created D65149: [Format] Add test demonstrating PR42722.
Jul 23 2019, 7:24 AM · Restricted Project

Jul 22 2019

modocache added inline comments to rL366765: [Statepoints] Fix a bug in statepoint lowering for functions w/no-realign-stack.
Jul 22 2019, 9:53 PM
modocache updated subscribers of rL366765: [Statepoints] Fix a bug in statepoint lowering for functions w/no-realign-stack.
Jul 22 2019, 9:53 PM
modocache added a comment to D55966: Ensure coro split pass only spills variables dominated by CoroBegin.

Noted, I'll try to work on this issue in early August, at the latest. In the meantime feel free to claim that bug report and submit a patch. Unfortunately unless someone develops a patch and immediately requests it be merged into the LLVM 9.0.0 release branch, I don't think it'll be in 9.0.0.

Jul 22 2019, 2:18 PM · Restricted Project

Jul 20 2019

modocache created D65044: [Format] Add option to enable coroutines keywords.
Jul 20 2019, 5:37 PM · Restricted Project
modocache created D65043: [Format] Add C++20 standard to style options.
Jul 20 2019, 5:35 PM · Restricted Project

Jul 2 2019

modocache updated subscribers of rL364999: [lld] Use -o /dev/null in test when output is not needed..

Thanks to @ruiu for fixing this in rL365001 :)

Jul 2 2019, 10:57 PM
modocache added a comment to rL364999: [lld] Use -o /dev/null in test when output is not needed..

I'm not sure this is correct.

Jul 2 2019, 10:16 PM

Jun 21 2019

modocache requested changes to D46628: [ELF] Add --strip-debug-non-line option.
Jun 21 2019, 2:53 PM · Restricted Project
modocache added a comment to D46628: [ELF] Add --strip-debug-non-line option.

Excellent, thank you! One of the comments on this diff mentioned using llvm-dwarfdump --verify to test whether the debug info generated by this option is valid. Have you tried doing so? Could you add a test case to this patch?

Jun 21 2019, 2:53 PM · Restricted Project

Jun 18 2019

modocache added a comment to D60495: Load balancing for LTO.

Hello! Would anyone be willing to review this patch? Is there anything that could be tweaked, maybe putting this behavior behind an option, that would make the change more amenable to any reviewers?

Jun 18 2019, 10:07 AM · Restricted Project

Jun 15 2019

modocache added inline comments to D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda.
Jun 15 2019, 1:10 PM · Restricted Project, Restricted Project

Jun 2 2019

modocache added a comment to D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda.

Great, thanks for the review!

Jun 2 2019, 5:48 PM · Restricted Project, Restricted Project
modocache committed rG38f11825d18e: [coroutines][PR41909] Don't build dependent coroutine statements for generic… (authored by modocache).
[coroutines][PR41909] Don't build dependent coroutine statements for generic…
Jun 2 2019, 5:47 PM
modocache committed rL362348: [coroutines][PR41909] Don't build dependent coroutine statements for generic….
[coroutines][PR41909] Don't build dependent coroutine statements for generic…
Jun 2 2019, 5:47 PM
modocache closed D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda.
Jun 2 2019, 5:47 PM · Restricted Project, Restricted Project

May 28 2019

modocache created D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda.
May 28 2019, 2:00 PM · Restricted Project, Restricted Project
modocache added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

@rsmith, what do you think of the patch as-is?

May 28 2019, 10:14 AM · Restricted Project

May 21 2019

modocache updated the diff for D58920: [Modules][PR39287] Consolidate multiple std's.

Hmm... alright, I'm not really sure how I could implement a test that fails without this, but I added a check in the FindExistingResult destructor.

May 21 2019, 8:19 AM · Restricted Project

May 16 2019

modocache created D62035: [AST] const-ify ObjC inherited class search.
May 16 2019, 2:47 PM · Restricted Project

May 15 2019

modocache updated the summary of D58920: [Modules][PR39287] Consolidate multiple std's.
May 15 2019, 6:23 PM · Restricted Project
modocache updated the diff for D58920: [Modules][PR39287] Consolidate multiple std's.

Oops, sent the patch from the wrong repository.

May 15 2019, 6:20 PM · Restricted Project
modocache updated the diff for D58920: [Modules][PR39287] Consolidate multiple std's.

Thanks for the help, @rsmith! Your suggestions were spot-on. (It took me a little while to figure out why, even using the LazyDeclPtr directly, I was still triggering deserialization. It turns out dump() causes deserialization too -- whoops!)

May 15 2019, 6:17 PM · Restricted Project

May 13 2019

modocache added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

Thanks @rsmith for the guidance here! I appreciate it very much. One snag I ran into after following your suggestion, though, is that when I modify ASTDeclReader::findExisting to return Sema's existing implicit std namespace, I run into an assertion later on, when the decl chain is being marked as incomplete. That is, the following patch (debug output included):

May 13 2019, 10:47 AM · Restricted Project

Apr 2 2019

modocache committed rG1c44ed8b7611: [Transforms] Redundant getValueOperand (NFC) (authored by modocache).
[Transforms] Redundant getValueOperand (NFC)
Apr 2 2019, 8:00 AM
modocache committed rL357479: [Transforms] Redundant getValueOperand (NFC).
[Transforms] Redundant getValueOperand (NFC)
Apr 2 2019, 7:56 AM

Mar 26 2019

modocache committed rGb66754a29ed7: Revert "[coroutines] Add std::experimental::task<T> type" (authored by modocache).
Revert "[coroutines] Add std::experimental::task<T> type"
Mar 26 2019, 12:52 PM
modocache committed rCXX357023: Revert "[coroutines] Add std::experimental::task<T> type".
Revert "[coroutines] Add std::experimental::task<T> type"
Mar 26 2019, 12:49 PM
modocache committed rL357023: Revert "[coroutines] Add std::experimental::task<T> type".
Revert "[coroutines] Add std::experimental::task<T> type"
Mar 26 2019, 12:49 PM
modocache added a comment to rL357010: [coroutines] Add std::experimental::task<T> type.

Apologies, I forgot to include in the commit message:

Mar 26 2019, 10:52 AM
modocache closed D46140: [coroutines] Add std::experimental::task<T> type.

Committed in rL357010. Apologies, I forgot to include the differential revision in the commit message so this diff wasn't closed automatically as a result. I'll comment on rL357010 with the missing information.

Mar 26 2019, 10:50 AM
modocache committed rG57839425aa48: [coroutines] Add std::experimental::task<T> type (authored by modocache).
[coroutines] Add std::experimental::task<T> type
Mar 26 2019, 10:47 AM
modocache committed rL357010: [coroutines] Add std::experimental::task<T> type.
[coroutines] Add std::experimental::task<T> type
Mar 26 2019, 10:47 AM
modocache committed rCXX357010: [coroutines] Add std::experimental::task<T> type.
[coroutines] Add std::experimental::task<T> type
Mar 26 2019, 10:47 AM

Mar 25 2019

modocache abandoned D59755: gitignore: Ignore in-tree Swift builds.

Right, that makes sense @jordan_rose. I'll submit this to swift-llvm, then.

Mar 25 2019, 10:13 AM · Restricted Project
modocache updated the summary of D59765: [Lex] Warn about invisible Hangul whitespace.
Mar 25 2019, 6:42 AM · Restricted Project
modocache updated the diff for D59765: [Lex] Warn about invisible Hangul whitespace.

Remove unneeded change to test identifier 'xx'.

Mar 25 2019, 6:42 AM · Restricted Project
modocache created D59765: [Lex] Warn about invisible Hangul whitespace.
Mar 25 2019, 6:38 AM · Restricted Project

Mar 24 2019

modocache created D59755: gitignore: Ignore in-tree Swift builds.
Mar 24 2019, 6:34 PM · Restricted Project
modocache committed rGb15c35aff878: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block" (authored by modocache).
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 24 2019, 5:53 PM
modocache committed rL356865: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 24 2019, 5:52 PM
modocache committed rC356865: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 24 2019, 5:52 PM
modocache closed D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Mar 24 2019, 5:51 PM · Restricted Project
modocache added a comment to D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".

Thank you for the review!

Mar 24 2019, 5:51 PM · Restricted Project
modocache added inline comments to D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Mar 24 2019, 4:06 PM · Restricted Project
modocache added reviewers for D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block": bricci, riccibruno, jbulow.
Mar 24 2019, 2:23 PM · Restricted Project
modocache created D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Mar 24 2019, 2:22 PM · Restricted Project

Mar 22 2019

modocache committed rGe8b3d63dd5bb: Revert "[coroutines][PR40978] Emit error for co_yield within catch block" (authored by modocache).
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 22 2019, 9:09 AM
modocache committed rL356774: Revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 22 2019, 9:09 AM
modocache committed rC356774: Revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 22 2019, 9:09 AM
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Reverted in rC356296. I'll rework this change along with a test confirming https://bugs.llvm.org/show_bug.cgi?id=41171 doesn't occur. Apologies!

Mar 22 2019, 9:08 AM · Restricted Project
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Sorry for the late response, I'm looking now. Should I revert this for now?

Mar 22 2019, 9:02 AM · Restricted Project
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

I'm pushing a revert. Sorry for the trouble!

Mar 22 2019, 9:02 AM · Restricted Project

Mar 18 2019

modocache added a comment to D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Friendly ping, @sylvestre.ledru! I'm also experiencing this build error. It looks like other diffs have been submitted to fix this, such as https://reviews.llvm.org/D59162, but it was abandoned in favor of this patch. It'd be great if you could commit this one.

Mar 18 2019, 11:46 AM · Restricted Project

Mar 15 2019

modocache committed rG9db9b1a17501: [coroutines][PR40978] Emit error for co_yield within catch block (authored by modocache).
[coroutines][PR40978] Emit error for co_yield within catch block
Mar 15 2019, 1:26 PM
modocache committed rL356296: [coroutines][PR40978] Emit error for co_yield within catch block.
[coroutines][PR40978] Emit error for co_yield within catch block
Mar 15 2019, 1:26 PM
modocache committed rC356296: [coroutines][PR40978] Emit error for co_yield within catch block.
[coroutines][PR40978] Emit error for co_yield within catch block
Mar 15 2019, 1:25 PM
modocache closed D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 15 2019, 1:25 PM · Restricted Project
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Great, thanks for the reviews, everyone!

Mar 15 2019, 1:25 PM · Restricted Project
modocache added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

I realize this isn't the correct solution, but would any would-be reviewers like to comment on the problem? Whether it's here or on the Bugzilla report https://bugs.llvm.org/show_bug.cgi?id=39287, as a newcomer to Clang modules I could use some help understanding whether this sort of behavior is expected, or if there are known workarounds. Any and all comments appreciated!

Mar 15 2019, 9:55 AM · Restricted Project

Mar 14 2019

modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

OK, I've responded to all your review comments -- thank you! Please give this another look when you get a chance. I would like to emit note diagnostics pointing to the catch blocks, but I've left that as a FIXME for now.

Mar 14 2019, 3:12 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Remove unused function parameter.

Mar 14 2019, 2:20 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Thank you for the reviews! This revision fixes the nested try/catch behavior. I still need to modify this such that semantic analysis continues for the rest of the function body.

Mar 14 2019, 1:49 PM · Restricted Project

Mar 11 2019

modocache committed rGd7b68132d8f2: [coroutines][PR40979] Ignore unreachable uses across suspend points (authored by modocache).
[coroutines][PR40979] Ignore unreachable uses across suspend points
Mar 11 2019, 11:32 AM
modocache committed rL355852: [coroutines][PR40979] Ignore unreachable uses across suspend points.
[coroutines][PR40979] Ignore unreachable uses across suspend points
Mar 11 2019, 11:32 AM
modocache closed D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Mar 11 2019, 11:32 AM · Restricted Project
modocache updated the diff for D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.

Thanks @GorNishanov! I moved the call into splitCoroutine. I'll land this now.

Mar 11 2019, 11:17 AM · Restricted Project
modocache committed rG4349dc76fa08: [Utils] Extract EliminateUnreachableBlocks (NFC) (authored by modocache).
[Utils] Extract EliminateUnreachableBlocks (NFC)
Mar 11 2019, 10:54 AM
modocache committed rL355846: [Utils] Extract EliminateUnreachableBlocks (NFC).
[Utils] Extract EliminateUnreachableBlocks (NFC)
Mar 11 2019, 10:54 AM
modocache closed D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).
Mar 11 2019, 10:53 AM · Restricted Project
modocache updated the diff for D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).

Oops! Thanks for pointing that out @davide -- I had meant to pass them through to the DeleteDeadBlocks but forgot. Should be good now!

Mar 11 2019, 6:53 AM · Restricted Project

Mar 8 2019

modocache added a comment to D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).

Friendly ping! I thought this might be easier to review if I split it up from https://reviews.llvm.org/D59068, which fixes a bug in coroutines and has already been accepted. This diff is an NFC but is necessary to land the bug fix.

Mar 8 2019, 9:27 AM · Restricted Project

Mar 7 2019

modocache committed rG4e467043fbb5: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC) (authored by modocache).
[CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC)
Mar 7 2019, 12:44 PM
modocache committed rL355634: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
[CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC)
Mar 7 2019, 12:44 PM
modocache closed D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
Mar 7 2019, 12:44 PM · Restricted Project
modocache added a comment to D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).

Thanks for the review!

Mar 7 2019, 12:44 PM · Restricted Project
modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 7 2019, 12:03 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Add test case for executing a lambda using co_yield within a catch block.

Mar 7 2019, 11:51 AM · Restricted Project
modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 7 2019, 11:48 AM · Restricted Project

Mar 6 2019

modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 6 2019, 11:16 PM · Restricted Project
modocache created D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 6 2019, 10:19 PM · Restricted Project
modocache updated the summary of D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Mar 6 2019, 6:52 PM · Restricted Project
modocache created D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).
Mar 6 2019, 6:52 PM · Restricted Project