Page MenuHomePhabricator
Feed Advanced Search

Fri, Aug 16

rupprecht added a comment to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….

Reverted in r369167

Fri, Aug 16, 4:31 PM
rupprecht committed rGd0797ece4641: Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle… (authored by rupprecht).
Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle…
Fri, Aug 16, 4:13 PM
rupprecht committed rL369167: Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle….
Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle…
Fri, Aug 16, 4:13 PM
rupprecht accepted D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
Fri, Aug 16, 4:13 PM · Restricted Project
rupprecht added inline comments to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….
Fri, Aug 16, 3:54 PM
rupprecht added inline comments to D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3].
Fri, Aug 16, 1:56 PM · Restricted Project
rupprecht added a reviewer for D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections: MaskRay.

I can't reproduce the test case -- it seems llvm-readelf already prints the NT_GNU_BUILD_ID when I follow the test steps.

Fri, Aug 16, 12:20 PM · Restricted Project
rupprecht accepted D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
Fri, Aug 16, 11:25 AM · Restricted Project
rupprecht added inline comments to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….
Fri, Aug 16, 10:32 AM
rupprecht added a comment to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….

We're seeing some compilation timeouts that bisect to the patch (5-10s -> >900s). I'm working on a repro.

Fri, Aug 16, 7:29 AM

Thu, Aug 15

rupprecht added inline comments to D65191: [llvm-objdump] Implement highlighting.
Thu, Aug 15, 4:09 PM · Restricted Project
rupprecht added inline comments to D66283: [llvm-objcopy][MachO] Implement --add-section.
Thu, Aug 15, 2:55 PM · Restricted Project
rupprecht added a comment to D66282: [llvm-objcopy][MachO] Implement --remove-section.

LGTM, no concerns from me once the test is updated

Thu, Aug 15, 2:33 PM · Restricted Project
rupprecht added inline comments to D66281: [llvm-objcopy][MachO] Implement --strip-all.
Thu, Aug 15, 2:28 PM · Restricted Project
rupprecht added inline comments to D66280: [llvm-objcopy][MachO] Support indirect symbol table.
Thu, Aug 15, 2:05 PM · Restricted Project
rupprecht added a comment to D66310: Fix nm on GCC 5.1 after the C++14 move.

Sounds like you get to claim this as a fix for https://bugs.llvm.org/show_bug.cgi?id=24115 too :)

Thu, Aug 15, 1:56 PM · Restricted Project
rupprecht added inline comments to D65541: [llvm-objcopy][MachO] Implement --only-section.
Thu, Aug 15, 12:33 PM · Restricted Project
rupprecht accepted D65367: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 2].

I don't see anything major left, but please wait for James to take another look

Thu, Aug 15, 11:48 AM · Restricted Project
rupprecht accepted D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1].
Thu, Aug 15, 11:19 AM · Restricted Project
rupprecht added inline comments to D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
Thu, Aug 15, 11:13 AM · Restricted Project
rupprecht accepted D66307: Add LLVMLibC proposal to docs/index.rst..

lg, thanks!

Thu, Aug 15, 11:05 AM · Restricted Project
rupprecht accepted D65189: [MC] Support returning marked up ranges in the disassembly.
Thu, Aug 15, 10:54 AM · Restricted Project
rupprecht accepted D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Thu, Aug 15, 10:54 AM · Restricted Project
rupprecht added inline comments to D66307: Add LLVMLibC proposal to docs/index.rst..
Thu, Aug 15, 10:48 AM · Restricted Project
rupprecht added a comment to D66305: [docs] Convert remaining command guide entries from md to rst..

Note that despite being a plain translation from md to rst, git doesn't think these are close enough and shows them as deletion+addition instead of moves.

Thu, Aug 15, 10:19 AM · Restricted Project
rupprecht created D66305: [docs] Convert remaining command guide entries from md to rst..
Thu, Aug 15, 10:18 AM · Restricted Project
rupprecht added a comment to D64939: Add a proposal for a libc project under the LLVM umbrella..

Did you build these docs locally? (Honestly asking -- I'm wondering if there's something about my local setup that's overly strict, I see doc errors too frequently). I'm getting errors running ninja docs-llvm-html:

Thu, Aug 15, 10:12 AM · Restricted Project

Wed, Aug 14

rupprecht committed rG1737f71322e3: [docs] Fix sphinx doc generation errors (authored by rupprecht).
[docs] Fix sphinx doc generation errors
Wed, Aug 14, 3:18 PM
rupprecht committed rL368932: [docs] Fix sphinx doc generation errors.
[docs] Fix sphinx doc generation errors
Wed, Aug 14, 3:17 PM
rupprecht closed D66183: [docs] Fix sphinx doc generation errors.
Wed, Aug 14, 3:17 PM · Restricted Project
rupprecht added inline comments to D66120: [Attributor] Use liveness during the creation of AAReturnedValues.
Wed, Aug 14, 3:17 PM · Restricted Project
rupprecht committed rG4ee1376dc626: [lldb][NFC] Remove unused function (authored by rupprecht).
[lldb][NFC] Remove unused function
Wed, Aug 14, 12:34 PM
rupprecht committed rL368904: [lldb][NFC] Remove unused function.
[lldb][NFC] Remove unused function
Wed, Aug 14, 12:34 PM

Tue, Aug 13

rupprecht created D66183: [docs] Fix sphinx doc generation errors.
Tue, Aug 13, 3:52 PM · Restricted Project
rupprecht added a comment to D65438: [docs] Add cmake to Software requirements.

Did you run ninja docs-llvm-html (or equivalent if not using ninja) when submitting? I'm still seeing this error in trunk.

Tue, Aug 13, 2:59 PM · Restricted Project
rupprecht committed rG39bce250d25b: [util] Allow callsigns when running git llvm revert (authored by rupprecht).
[util] Allow callsigns when running git llvm revert
Tue, Aug 13, 10:22 AM
rupprecht committed rL368726: [util] Allow callsigns when running git llvm revert.
[util] Allow callsigns when running git llvm revert
Tue, Aug 13, 10:19 AM
rupprecht committed rG7859641626f8: [lld][test] Update test to print ELF note description data (authored by rupprecht).
[lld][test] Update test to print ELF note description data
Tue, Aug 13, 9:11 AM
rupprecht committed rL368710: [lld][test] Update test to print ELF note description data.
[lld][test] Update test to print ELF note description data
Tue, Aug 13, 9:10 AM
rupprecht committed rG63ac3e5cbe03: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors (authored by rupprecht).
[llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors
Tue, Aug 13, 7:40 AM
rupprecht committed rL368698: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
[llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors
Tue, Aug 13, 7:38 AM
rupprecht closed D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Tue, Aug 13, 7:37 AM · Restricted Project

Mon, Aug 12

rupprecht accepted D66075: [llvm-readobj][MachO] Fix section type printing.
Mon, Aug 12, 10:35 PM · Restricted Project
rupprecht added inline comments to D65189: [MC] Support returning marked up ranges in the disassembly.
Mon, Aug 12, 4:42 PM · Restricted Project
rupprecht added inline comments to D65367: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 2].
Mon, Aug 12, 3:03 PM · Restricted Project
rupprecht added inline comments to D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1].
Mon, Aug 12, 2:27 PM · Restricted Project
rupprecht added inline comments to D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.
Mon, Aug 12, 12:49 PM · Restricted Project
rupprecht accepted D65991: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file.
Mon, Aug 12, 12:13 PM · Restricted Project
rupprecht retitled D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors from [llvm-readelf] Implement NT_FILE core file parsing to [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Mon, Aug 12, 12:09 PM · Restricted Project
rupprecht added a comment to D66075: [llvm-readobj][MachO] Fix section type printing.

The change looks fine to me, although I wasn't able to quickly find the list of section types anywhere to check against. Could you provide me some documentation?

This was already committed to LLVM years ago in rL178679 (+echristo, the committer), but mistakenly removed in rL235863 due to being an unused variable, instead of the right fix, which is clearly the Attributes->Types typo fixed here

Mon, Aug 12, 12:06 PM · Restricted Project
rupprecht added a reviewer for D66075: [llvm-readobj][MachO] Fix section type printing: echristo.
Mon, Aug 12, 12:01 PM · Restricted Project
rupprecht updated the diff for D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
  • Use const for CoreNote param
Mon, Aug 12, 8:45 AM · Restricted Project
rupprecht committed rGe011a5b4edf8: [llvm-ar][NFC] Fix buildbot (authored by rupprecht).
[llvm-ar][NFC] Fix buildbot
Mon, Aug 12, 7:24 AM
rupprecht committed rL368578: [llvm-ar][NFC] Fix buildbot.
[llvm-ar][NFC] Fix buildbot
Mon, Aug 12, 7:21 AM
rupprecht committed rGf927b34a148b: [llvm-readobj] Downgrade 'PT_DYNAMIC segment offset + size exceeds the size of… (authored by rupprecht).
[llvm-readobj] Downgrade 'PT_DYNAMIC segment offset + size exceeds the size of…
Mon, Aug 12, 7:07 AM
rupprecht committed rL368576: [llvm-readobj] Downgrade 'PT_DYNAMIC segment offset + size exceeds the size of….
[llvm-readobj] Downgrade 'PT_DYNAMIC segment offset + size exceeds the size of…
Mon, Aug 12, 7:07 AM
rupprecht closed D66036: [llvm-readobj] Downgrade 'PT_DYNAMIC segment offset + size exceeds the size of the file' from an error to a warning.
Mon, Aug 12, 7:07 AM · Restricted Project

Fri, Aug 9

rupprecht accepted D65891: [llvm-objcopy] Allow 'protected' visibility to be set when using add-symbol.
Fri, Aug 9, 5:38 PM · Restricted Project
rupprecht updated the diff for D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
  • Use DataExtractor instead of custom logic + remove some now unnecessary template use
Fri, Aug 9, 5:02 PM · Restricted Project
rupprecht created D66036: [llvm-readobj] Downgrade 'PT_DYNAMIC segment offset + size exceeds the size of the file' from an error to a warning.
Fri, Aug 9, 3:41 PM · Restricted Project
rupprecht added inline comments to D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Fri, Aug 9, 1:25 PM · Restricted Project
rupprecht updated the diff for D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
  • Split up type/description printing
  • Add printing for unknown note types
  • Clarify comment about generating section data
Fri, Aug 9, 1:25 PM · Restricted Project
rupprecht accepted D66015: [llvm-strings] Improve testing of llvm-strings.

Just one test that needs fixing, LGTM otherwise:

Fri, Aug 9, 8:54 AM · Restricted Project
rupprecht added a comment to D65893: [llvm-objcopy] Allow the visibility of the start, end and size symbols created by --binary to be specified with --binary-symbol-visibility.

Can you explain more about the use case? Not sure I understand the symbol preemption scenario.

Fri, Aug 9, 8:33 AM · Restricted Project

Wed, Aug 7

rupprecht committed rG80a8ae2dfea6: [llvm-readobj][test] Add baseline tests for FreeBSD/AMD/AMDGPU note printing (authored by rupprecht).
[llvm-readobj][test] Add baseline tests for FreeBSD/AMD/AMDGPU note printing
Wed, Aug 7, 3:22 PM
rupprecht committed rL368221: [llvm-readobj][test] Add baseline tests for FreeBSD/AMD/AMDGPU note printing.
[llvm-readobj][test] Add baseline tests for FreeBSD/AMD/AMDGPU note printing
Wed, Aug 7, 3:22 PM
rupprecht updated the diff for D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
  • Restore ET_CORE check
Wed, Aug 7, 1:54 PM · Restricted Project
rupprecht added inline comments to D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Wed, Aug 7, 12:25 PM · Restricted Project
rupprecht requested changes to D65774: Removing redundant-move warnings generated by gcc9x..

Agree with all these comments -- I'm no expert on when and when not to std::move, but this is undoing changes I've made to fix buildbots on different compilers.

Wed, Aug 7, 12:02 PM · Restricted Project
rupprecht accepted D65787: [llvm-strip] Support --strip-sections with the llvm-strip command..

@jakehehrlich/@rupprecht, are you aware of any reason why we SHOULDN'T have this in llvm-strip? It seems odd to have it in llvm-objcopy when the original source was eu-strip!

Wed, Aug 7, 11:49 AM · Restricted Project
rupprecht accepted D65743: [llvm-ar] Accept file paths with windows format slashes.

I think it'd be good to also write a test that verifies the internal representation is always forward slashes on windows by running FileCheck directly on the thin archive instead of using llvm-ar t to look at it (e.g. see thin-archive.test). Or do we already have a test for that?

Wed, Aug 7, 11:45 AM · Restricted Project
rupprecht added inline comments to D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Wed, Aug 7, 11:16 AM · Restricted Project
rupprecht updated the diff for D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
  • Remove ET_CORE check
  • null -> NUL
  • Use more consistent error messages
  • Check for no more lines in test output
  • Other misc cleanup
Wed, Aug 7, 11:16 AM · Restricted Project
rupprecht accepted D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Wed, Aug 7, 10:26 AM · Restricted Project
rupprecht accepted D65189: [MC] Support returning marked up ranges in the disassembly.
Wed, Aug 7, 10:05 AM · Restricted Project

Tue, Aug 6

rupprecht created D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Tue, Aug 6, 3:39 PM · Restricted Project
rupprecht added a comment to D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.

(Also just want to say the print*RelocatableStackSizes methods look much better now, thanks for cleaning that up!)

Tue, Aug 6, 9:25 AM · Restricted Project
rupprecht added a comment to D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.

Sorry, I had some draft comments yesterday but had to leave early, here are post-commit comments now:

Tue, Aug 6, 9:16 AM · Restricted Project

Mon, Aug 5

rupprecht committed rG9008d8c5ff92: [llvm-readobj][test] Add llvm-readobj style test cases for r367878 (authored by rupprecht).
[llvm-readobj][test] Add llvm-readobj style test cases for r367878
Mon, Aug 5, 9:30 AM
rupprecht committed rL367884: [llvm-readobj][test] Add llvm-readobj style test cases for r367878.
[llvm-readobj][test] Add llvm-readobj style test cases for r367878
Mon, Aug 5, 9:30 AM
rupprecht committed rGd884fbde2a82: [llvm-readelf] Fix core note descriptions (authored by rupprecht).
[llvm-readelf] Fix core note descriptions
Mon, Aug 5, 8:45 AM
rupprecht committed rL367878: [llvm-readelf] Fix core note descriptions.
[llvm-readelf] Fix core note descriptions
Mon, Aug 5, 8:45 AM
rupprecht closed D65608: [llvm-readelf] Fix core note descriptions.
Mon, Aug 5, 8:45 AM · Restricted Project

Fri, Aug 2

rupprecht updated the diff for D65608: [llvm-readelf] Fix core note descriptions.
  • Rearrange NT_ constants in ELFDumper to match ordering in libObject header
Fri, Aug 2, 1:57 PM · Restricted Project
rupprecht updated the diff for D65608: [llvm-readelf] Fix core note descriptions.
  • Sort enums by value and separate groups by whitespace
Fri, Aug 2, 10:19 AM · Restricted Project

Thu, Aug 1

rupprecht added a comment to D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.

Left the question about whether --stack-sizes should be include in --all open. This is still a discussion point.

Thu, Aug 1, 2:56 PM · Restricted Project
rupprecht created D65608: [llvm-readelf] Fix core note descriptions.
Thu, Aug 1, 2:39 PM · Restricted Project
rupprecht accepted D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unit tests.
Thu, Aug 1, 9:52 AM · Restricted Project

Wed, Jul 31

rupprecht accepted D65540: [llvm-objcopy][MachO] Fix method names. NFC..
Wed, Jul 31, 4:39 PM · Restricted Project
rupprecht added inline comments to D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unit tests.
Wed, Jul 31, 10:40 AM · Restricted Project

Tue, Jul 30

rupprecht added a comment to D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.

I'm not familiar with the .stack_sizes functionality in general, but it seems useful & could have saved me countless hours of debugging (large stack frames => stack overflows in recursive parsers) if I knew more about how it worked.

Tue, Jul 30, 3:38 PM · Restricted Project
rupprecht added inline comments to D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1].
Tue, Jul 30, 2:23 PM · Restricted Project
rupprecht added a comment to D65255: [yaml2obj] Move core yaml2obj code into lib and include for use in unit tests.

git clang-format does not understand moved files it turns out, so it formatted things that I didn't touch. I figure if this is going to happen it might as well be now, though. I can change this back though.

Tue, Jul 30, 11:53 AM · Restricted Project

Mon, Jul 29

rupprecht committed rGab356d87be7a: [driver][test] Use /dev/null in as-options.s instead (authored by rupprecht).
[driver][test] Use /dev/null in as-options.s instead
Mon, Jul 29, 1:10 PM
rupprecht committed rL367256: [driver][test] Use /dev/null in as-options.s instead.
[driver][test] Use /dev/null in as-options.s instead
Mon, Jul 29, 1:09 PM
rupprecht committed rG8e9516f2aa49: [driver][test] Update as-options.s to not write to a readonly tree (authored by rupprecht).
[driver][test] Update as-options.s to not write to a readonly tree
Mon, Jul 29, 12:58 PM
rupprecht committed rL367253: [driver][test] Update as-options.s to not write to a readonly tree.
[driver][test] Update as-options.s to not write to a readonly tree
Mon, Jul 29, 12:58 PM
rupprecht committed rG6a253d378bc0: [lldb] Qualify includes of Properties[Enum].inc files. NFC (authored by rupprecht).
[lldb] Qualify includes of Properties[Enum].inc files. NFC
Mon, Jul 29, 10:24 AM
rupprecht committed rL367241: [lldb] Qualify includes of Properties[Enum].inc files. NFC.
[lldb] Qualify includes of Properties[Enum].inc files. NFC
Mon, Jul 29, 10:24 AM
rupprecht added a comment to D65397: Qualify includes of Properties[Enum].inc files. NFC.

Committed this for you as r367241, including a rebase past r367238 (which I really hope I didn't mess up -- ninja check-lldb passed, at least).

Mon, Jul 29, 10:23 AM · Restricted Project, Restricted Project