Page MenuHomePhabricator
Feed Advanced Search

Fri, Jun 21

rupprecht accepted D63327: [docs][llvm-nm] Improve symbol code documentation.
Fri, Jun 21, 5:50 PM · Restricted Project
rupprecht accepted D62718: [llvm-objcopy] Change handling of output file permissions.

(ditto that Ray should take another look, but looks mostly fine to me)

Fri, Jun 21, 5:47 PM · Restricted Project
rupprecht accepted D63583: [Support] Add fs::getUmask() function and change fs::setPermissions.
Fri, Jun 21, 5:37 PM · Restricted Project
rupprecht abandoned D63292: [docs] Workaround old recommonmark version on buildbots.

Switching these docs to rst seems (unfortunately) better, abandoning this attempt.

Fri, Jun 21, 4:42 PM · Restricted Project

Thu, Jun 20

rupprecht committed rG73986707bd57: [CodeGen][test] Use FileCheck variable matchers for better test support (authored by rupprecht).
[CodeGen][test] Use FileCheck variable matchers for better test support
Thu, Jun 20, 3:34 PM
rupprecht committed rL363996: [CodeGen][test] Use FileCheck variable matchers for better test support.
[CodeGen][test] Use FileCheck variable matchers for better test support
Thu, Jun 20, 3:34 PM
rupprecht closed D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.
Thu, Jun 20, 3:34 PM · Restricted Project
rupprecht added a comment to D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.

Sounds good, changed to use variable matching instead. This passes w/ either -fno-discard-value-names or -fdiscard-value-names used.

Thu, Jun 20, 3:14 PM · Restricted Project
rupprecht updated the diff for D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.
  • Use filecheck variable matching instead of an explicit -fno-discard-value-names option
Thu, Jun 20, 3:11 PM · Restricted Project
rupprecht created D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.
Thu, Jun 20, 2:29 PM · Restricted Project
rupprecht committed rG02508decf4ad: [DAGCombiner][NFC] Remove unused var (authored by rupprecht).
[DAGCombiner][NFC] Remove unused var
Thu, Jun 20, 10:30 AM
rupprecht committed rL363954: [DAGCombiner][NFC] Remove unused var.
[DAGCombiner][NFC] Remove unused var
Thu, Jun 20, 10:30 AM

Wed, Jun 19

rupprecht committed rGf5d0d2d0410f: [test] Fix TargetParserTest runtime. (authored by rupprecht).
[test] Fix TargetParserTest runtime.
Wed, Jun 19, 11:02 AM
rupprecht committed rL363851: [test] Fix TargetParserTest runtime..
[test] Fix TargetParserTest runtime.
Wed, Jun 19, 11:02 AM
rupprecht committed rGff384a2d1c07: [clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart (authored by rupprecht).
[clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart
Wed, Jun 19, 10:41 AM
rupprecht committed rL363848: [clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart.
[clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart
Wed, Jun 19, 10:40 AM

Tue, Jun 18

rupprecht committed rG4053d95cd853: Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same… (authored by rupprecht).
Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same…
Tue, Jun 18, 3:19 PM
rupprecht committed rL363747: Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same….
Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same…
Tue, Jun 18, 3:18 PM
rupprecht committed rG33e85ad95679: Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas (authored by rupprecht).
Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas
Tue, Jun 18, 11:39 AM
rupprecht committed rL363718: Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas.
Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas
Tue, Jun 18, 11:38 AM
rupprecht accepted D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Tue, Jun 18, 11:23 AM · Restricted Project

Mon, Jun 17

rupprecht accepted D62838: [Object] add isExecutableObject member function.

LGTM just with the naming nit from James (header_t&->const HeaderType&)

Mon, Jun 17, 11:51 AM · Restricted Project
rupprecht accepted D63122: [llvm-strip] Error when using stdin twice .
Mon, Jun 17, 11:41 AM · Restricted Project
rupprecht added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Mon, Jun 17, 11:05 AM · Restricted Project
rupprecht added inline comments to D63327: [docs][llvm-nm] Improve symbol code documentation.
Mon, Jun 17, 10:44 AM · Restricted Project
rupprecht added a comment to D62838: [Object] add isExecutableObject member function.

(just the one comment, then lgtm)

Mon, Jun 17, 10:33 AM · Restricted Project
rupprecht added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Mon, Jun 17, 10:29 AM · Restricted Project
rupprecht added a comment to D63394: [yaml2obj][ELF] Suport STT_LOOS, STT_HIOS, STT_LOPROC and STT_HIPROC..

I'm totally fine with not commit this. But it seems just a small convenience from a tooling perspective (no need for the semantics of the symbol type) when you need the value but not in an OS or processor specific way and STT_LOOS looks better than "10"?

I may have been a bit hasty rejecting this. My concern is that I have already seen instances in LLVM where people possibly not well-versed in ELF try to use these as actual types in testing and in tools consuming these values, which can lead to confusion or worse, bogus output (e.g. llvm-readelf claiming that a symbol's type is STT_LOOS). @grimar, do you have any thoughts?

Mon, Jun 17, 9:56 AM · Restricted Project

Fri, Jun 14

rupprecht added inline comments to D62838: [Object] add isExecutableObject member function.
Fri, Jun 14, 11:45 AM · Restricted Project

Thu, Jun 13

rupprecht added a comment to D63211: [docs] Fix local docs build.

I replied to your llvm-dev thread. I think we should apply something like D63292, upgrade the buildbots, and then apply this change when reverting D63292.

Thu, Jun 13, 1:53 PM · Restricted Project
rupprecht created D63292: [docs] Workaround old recommonmark version on buildbots.
Thu, Jun 13, 11:44 AM · Restricted Project
rupprecht committed rG4244dd5e3f9e: [docs] Fix TableGen/LangRef typos (authored by rupprecht).
[docs] Fix TableGen/LangRef typos
Thu, Jun 13, 11:40 AM
rupprecht committed rL363294: [docs] Fix TableGen/LangRef typos.
[docs] Fix TableGen/LangRef typos
Thu, Jun 13, 11:40 AM

Wed, Jun 12

rupprecht accepted D62583: [llvm-objcopy] Implement IHEX reader.
Wed, Jun 12, 3:27 PM · Restricted Project
rupprecht added inline comments to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.
Wed, Jun 12, 3:13 PM
rupprecht added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Wed, Jun 12, 2:09 PM · Restricted Project
rupprecht added a comment to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..

Sure, committed as r363198

Wed, Jun 12, 1:16 PM · Restricted Project
rupprecht committed rG565f1e2298ce: [llvm-readobj] Fix output interleaving issue caused by using multiple streams… (authored by rupprecht).
[llvm-readobj] Fix output interleaving issue caused by using multiple streams…
Wed, Jun 12, 1:15 PM
rupprecht committed rL363198: [llvm-readobj] Fix output interleaving issue caused by using multiple streams….
[llvm-readobj] Fix output interleaving issue caused by using multiple streams…
Wed, Jun 12, 1:14 PM
rupprecht closed D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Wed, Jun 12, 1:14 PM · Restricted Project
rupprecht added inline comments to D62838: [Object] add isExecutableObject member function.
Wed, Jun 12, 1:00 PM · Restricted Project
rupprecht accepted D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Wed, Jun 12, 12:01 PM · Restricted Project
rupprecht accepted D63195: [docs][llvm-symbolizer] Fix --functions syntax highlighting.
Wed, Jun 12, 11:54 AM · Restricted Project
rupprecht accepted D63197: [llvm-ar][test] Add to MRI test coverage .
Wed, Jun 12, 11:52 AM · Restricted Project
rupprecht committed rG146a154e610b: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test (authored by rupprecht).
[llvm-ar][test] Relax lit directory assumptions in thin-archive.test
Wed, Jun 12, 11:39 AM
rupprecht committed rL363189: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test.
[llvm-ar][test] Relax lit directory assumptions in thin-archive.test
Wed, Jun 12, 11:39 AM
rupprecht closed D62930: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test.
Wed, Jun 12, 11:38 AM · Restricted Project
rupprecht added a comment to D63211: [docs] Fix local docs build.

Looks like I'm on 1.7.5, from last year (http://www.sphinx-doc.org/en/master/changes.html#release-1-7-5-released-may-29-2018). Not sure how to check the bot version.

Wed, Jun 12, 9:24 AM · Restricted Project
rupprecht added a comment to D63211: [docs] Fix local docs build.

I intentionally added .html because I noticed the link on llvm.org is broken: http://llvm.org/docs/CommandGuide/llvm-addr2line.html links to http://llvm.org/docs/CommandGuide/llvm-symbolizer, which does not exist (http://llvm.org/docs/CommandGuide/llvm-symbolizer.html does).

Wed, Jun 12, 8:33 AM · Restricted Project

Tue, Jun 11

rupprecht added inline comments to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Tue, Jun 11, 5:25 PM · Restricted Project
rupprecht added inline comments to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Tue, Jun 11, 3:35 PM · Restricted Project
rupprecht committed rG4c3722aea81a: [docs] Add "GNU binutils Replacements" section to command guide (authored by rupprecht).
[docs] Add "GNU binutils Replacements" section to command guide
Tue, Jun 11, 2:13 PM
rupprecht committed rL363100: [docs] Add "GNU binutils Replacements" section to command guide.
[docs] Add "GNU binutils Replacements" section to command guide
Tue, Jun 11, 2:12 PM
rupprecht closed D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Tue, Jun 11, 2:12 PM · Restricted Project
rupprecht added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Tue, Jun 11, 2:06 PM · Restricted Project
rupprecht added inline comments to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Tue, Jun 11, 12:18 PM · Restricted Project

Mon, Jun 10

rupprecht accepted D62973: [llvm-objcopy] Changed command line parsing errors.

Thanks for splitting up the patch! I should have requested that earlier.

Mon, Jun 10, 1:41 PM · Restricted Project
rupprecht added inline comments to D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Mon, Jun 10, 1:05 PM · Restricted Project
rupprecht updated the diff for D63014: [docs] Add "GNU binutils Replacements" section to command guide.
  • Clarify llvm-readelf compatibility
Mon, Jun 10, 1:04 PM · Restricted Project
rupprecht accepted D63090: [objcopy] Error when --preserve-dates is specified with standard streams.
Mon, Jun 10, 12:58 PM · Restricted Project
rupprecht retitled D63014: [docs] Add "GNU binutils Replacements" section to command guide from [docs] Add "GNU Replacements" section to command guide to [docs] Add "GNU binutils Replacements" section to command guide.
Mon, Jun 10, 11:43 AM · Restricted Project
rupprecht committed rGf8f9d65f85b6: [llvm-objcopy] Fix SHT_GROUP ordering. (authored by rupprecht).
[llvm-objcopy] Fix SHT_GROUP ordering.
Mon, Jun 10, 11:33 AM
rupprecht committed rL362973: [llvm-objcopy] Fix SHT_GROUP ordering..
[llvm-objcopy] Fix SHT_GROUP ordering.
Mon, Jun 10, 11:33 AM
rupprecht closed D62620: [llvm-objcopy] Fix SHT_GROUP ordering..
Mon, Jun 10, 11:33 AM · Restricted Project
rupprecht committed rG13d16b94c6b7: [docs] Add 'git llvm revert' to getting started guide (authored by rupprecht).
[docs] Add 'git llvm revert' to getting started guide
Mon, Jun 10, 9:59 AM
rupprecht committed rL362966: [docs] Add 'git llvm revert' to getting started guide.
[docs] Add 'git llvm revert' to getting started guide
Mon, Jun 10, 9:59 AM
rupprecht closed D63023: [docs] Add 'git llvm revert' to getting started guide.
Mon, Jun 10, 9:59 AM · Restricted Project

Fri, Jun 7

rupprecht committed rG7dd813fea1d4: [llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of… (authored by rupprecht).
[llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of…
Fri, Jun 7, 2:49 PM
rupprecht committed rL362847: [llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of….
[llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of…
Fri, Jun 7, 2:49 PM
rupprecht closed D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.
Fri, Jun 7, 2:48 PM · Restricted Project
rupprecht added a reviewer for D60974: Clang IFSO driver action.: rupprecht.

Can you upload this patch with context? Either use arc or upload w/ -U99999

Fri, Jun 7, 1:28 PM · Restricted Project, Restricted Project
rupprecht created D63023: [docs] Add 'git llvm revert' to getting started guide.
Fri, Jun 7, 12:59 PM · Restricted Project
rupprecht created D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Fri, Jun 7, 10:59 AM · Restricted Project
rupprecht added a comment to D63011: [docs]Move llvm-readobj from "Developer Tools" to "Basic Commands".

I actually wonder if we should split out all the binary utilities to a separate section. We should try to advertise the replacement-ness of all the tools we have.

That's probably not a bad shout, though we'd have to figure out exactly what we mean by "binary utilities" as I suspect everybody has a slightly different interpretation of this. Maybe a section labelled "GNU replacements"

SGTM. There's a definitive list of that here: https://www.gnu.org/software/binutils/

Fri, Jun 7, 10:08 AM · Restricted Project
rupprecht added a comment to D63011: [docs]Move llvm-readobj from "Developer Tools" to "Basic Commands".

Thanks @MaskRay.

Since llvm-objdump and llvm-nm are in the "Basic Commands" list, and llvm-readobj is used in various test directories: CodeGen/DebugInfo/MC/LTO/..., I think it qualifies as a Basic Command :)

I think the distinction is "tools in LLVM used by people" versus "tools used by LLVM developers (mostly for testing/debugging)".

Are you saying LLVM developers aren't people? :p

Fri, Jun 7, 9:46 AM · Restricted Project
rupprecht added inline comments to D62838: [Object] add isExecutableObject member function.
Fri, Jun 7, 9:41 AM · Restricted Project

Thu, Jun 6

rupprecht planned changes to D62278: [obj2yaml] Support dumping program headers..

Ack -- those suggestions sound good, I'll revive this patch when I have a proposal for smarter program headers.

Thu, Jun 6, 4:47 PM · Restricted Project
rupprecht added inline comments to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.
Thu, Jun 6, 4:39 PM
rupprecht added a comment to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

In that case why not strip the symbol table all togethor?

GNU strip does this. In a really simple test -- build a dummy "int main() { return 0; }" executable, then run strip/llvm-strip --strip-unneeded -- GNU strip removes .symtab and .strtab, whereas llvm-strip does not. The .symtab/.strtab sections are trivial (only containing the null symbol), so we should do the final step and remove it. (Both leave in .shstrtab though).

Thu, Jun 6, 4:36 PM
rupprecht committed rG0629e1252ff6: Revert [ELF] Simplify the condition to create .interp (authored by rupprecht).
Revert [ELF] Simplify the condition to create .interp
Thu, Jun 6, 4:21 PM
rupprecht committed rL362755: Revert [ELF] Simplify the condition to create .interp.
Revert [ELF] Simplify the condition to create .interp
Thu, Jun 6, 4:20 PM
rupprecht accepted D62973: [llvm-objcopy] Changed command line parsing errors.

I'm good with this after these two comments:

Thu, Jun 6, 3:37 PM · Restricted Project
rupprecht added inline comments to D62718: [llvm-objcopy] Change handling of output file permissions.
Thu, Jun 6, 3:31 PM · Restricted Project
rupprecht accepted D62718: [llvm-objcopy] Change handling of output file permissions.

Just a couple nits, but I think this is ready to commit now. It can be updated whenever D62838 lands. Thanks for all the iterations!

Thu, Jun 6, 2:37 PM · Restricted Project
rupprecht added inline comments to D62973: [llvm-objcopy] Changed command line parsing errors.
Thu, Jun 6, 2:28 PM · Restricted Project
rupprecht accepted D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

Also not a Mach-O expert, but I looked through it and what I can understand looks fine (+ it passes existing tests). More tests in a future patch are always welcome though.

Thu, Jun 6, 1:20 PM · Restricted Project
rupprecht added inline comments to D62973: [llvm-objcopy] Changed command line parsing errors.
Thu, Jun 6, 1:07 PM · Restricted Project
rupprecht added inline comments to D62583: [llvm-objcopy] Implement IHEX reader.
Thu, Jun 6, 11:40 AM · Restricted Project
rupprecht accepted D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol.

LGTM except for MaskRay's comment about the unnecessary if check

Thu, Jun 6, 10:32 AM · Restricted Project
rupprecht accepted D62955: [llvm-nm] Additional lit tests for command line options.
Thu, Jun 6, 10:26 AM
rupprecht added inline comments to D62718: [llvm-objcopy] Change handling of output file permissions.
Thu, Jun 6, 10:26 AM · Restricted Project
rupprecht added inline comments to D62838: [Object] add isExecutableObject member function.
Thu, Jun 6, 9:52 AM · Restricted Project

Wed, Jun 5

rupprecht added inline comments to D62620: [llvm-objcopy] Fix SHT_GROUP ordering..
Wed, Jun 5, 6:05 PM · Restricted Project
rupprecht added a comment to D62919: [llvm-ar] Create thin archives with MRI scripts.

(LGTM other than the comment about Thin being global tho)

Wed, Jun 5, 3:55 PM · Restricted Project
rupprecht added a comment to D62919: [llvm-ar] Create thin archives with MRI scripts.

I guess there are no rules for MRI script compatibility -- but I wonder how much work we want to invest in improving MRI support beyond supporting people migrating from GNU ar (even there, MRI support is only added to support people migrating from a different librarian program...). This seems like a minor change to allow, but I just wanted to say that before you go crazy adding things :)

Wed, Jun 5, 3:55 PM · Restricted Project
rupprecht added a comment to D62718: [llvm-objcopy] Change handling of output file permissions.

Context isn't available in some of the regions; can you reupload the patch w/ context?

Wed, Jun 5, 3:27 PM · Restricted Project
rupprecht created D62930: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test.
Wed, Jun 5, 1:17 PM · Restricted Project

Tue, Jun 4

rupprecht accepted D62848: [llvm-objdump] - Disassemble non-executable sections if specifically requested..
Tue, Jun 4, 4:51 PM
rupprecht accepted D62851: [llvm-objdump/llvm-readobj/obj2yaml/yaml2obj] Support DT_PPC_GOT and DT_PPC_OPT.
Tue, Jun 4, 4:51 PM · Restricted Project
rupprecht added a comment to D62718: [llvm-objcopy] Change handling of output file permissions.

Looks like GNU objcopy creates files w/ "w+" (i.e. 0666 w/ umask automatically applied) [1], and then does a chmod w/ umask explicitly applied when making it executable [2]:

Tue, Jun 4, 4:44 PM · Restricted Project