Page MenuHomePhabricator
Feed Advanced Search

Yesterday

loralb requested review of D125971: [RISCV] Ensure the forwarded AVL register is alive.
Thu, May 19, 6:56 AM · Restricted Project, Restricted Project

Apr 8 2022

loralb updated the diff for D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
  • Address review comment
Apr 8 2022, 3:10 AM · Restricted Project, Restricted Project

Apr 6 2022

loralb updated the diff for D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
  • Address some of the review comments
Apr 6 2022, 2:38 AM · Restricted Project, Restricted Project
loralb added inline comments to D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
Apr 6 2022, 2:13 AM · Restricted Project, Restricted Project
loralb updated the summary of D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
Apr 6 2022, 2:10 AM · Restricted Project, Restricted Project

Apr 5 2022

loralb updated the diff for D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
  • Update tests
Apr 5 2022, 5:57 AM · Restricted Project, Restricted Project
loralb updated the diff for D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
  • Address review comments
Apr 5 2022, 5:33 AM · Restricted Project, Restricted Project
loralb requested review of D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
Apr 5 2022, 3:01 AM · Restricted Project, Restricted Project

Mar 30 2022

loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
  • Use isAllOnesValue() instead of isOneValue()
Mar 30 2022, 6:04 AM · Restricted Project, Restricted Project, Restricted Project
loralb added inline comments to D109584: [VP] Implementing expansion pass for VP load and store..
Mar 30 2022, 5:50 AM · Restricted Project, Restricted Project, Restricted Project
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
  • Use getSplatValue() instead of PatternMatch in isAllTrueMask()
  • Update tests
Mar 30 2022, 2:53 AM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

loralb updated the diff for D120564: [VP] IR expansion pass for VP strided load and store.
  • Add fixed vectors tests
Mar 29 2022, 5:23 AM · Restricted Project, Restricted Project
loralb updated the diff for D120664: [VP] IR expansion pass for VP gather and scatter.
  • Use DataLayout to determine the alignment (if there is not one already)
  • Add fixed vectors tests
Mar 29 2022, 3:51 AM · Restricted Project, Restricted Project

Mar 28 2022

loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
  • Improve isAllTrueMask() (for scalable vectors only)
  • Add and update tests
Mar 28 2022, 8:04 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

loralb updated the diff for D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
  • Use poison instead of undef in tests
Mar 16 2022, 3:24 AM · Restricted Project, Restricted Project
loralb requested review of D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
Mar 16 2022, 3:08 AM · Restricted Project, Restricted Project
loralb updated the diff for D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
  • Address review comment
Mar 16 2022, 2:06 AM · Restricted Project, Restricted Project

Mar 11 2022

loralb added a comment to D114884: [VP] Strided loads/stores.

Thanks!

Mar 11 2022, 3:54 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2022

loralb added a comment to D114884: [VP] Strided loads/stores.

I do not have commit access, could anyone commit this for me please?

Mar 8 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
loralb added inline comments to D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
Mar 8 2022, 10:56 AM · Restricted Project, Restricted Project
loralb updated the diff for D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
  • Apply suggestions in the comments
Mar 8 2022, 10:55 AM · Restricted Project, Restricted Project
loralb updated the diff for D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
  • Remove unnecessary custom legalization of narrow scalar types
  • Do not add new RISCVISD nodes, use existing intrinsics instead
Mar 8 2022, 10:51 AM · Restricted Project, Restricted Project

Mar 7 2022

loralb requested review of D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
Mar 7 2022, 7:08 AM · Restricted Project, Restricted Project
loralb requested review of D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
Mar 7 2022, 7:01 AM · Restricted Project, Restricted Project
loralb updated the diff for D114884: [VP] Strided loads/stores.
  • Update documentation
  • Align with recent changes to vp_load and vp_store
Mar 7 2022, 6:50 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2022

loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
  • Address comments
Mar 1 2022, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
loralb updated the diff for D120564: [VP] IR expansion pass for VP strided load and store.
Mar 1 2022, 3:03 AM · Restricted Project, Restricted Project
loralb updated the diff for D114884: [VP] Strided loads/stores.
  • Changed the pointer operand type to match the scalar elements type of the data/return operand
Mar 1 2022, 1:52 AM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

loralb requested review of D120664: [VP] IR expansion pass for VP gather and scatter.
Feb 28 2022, 8:57 AM · Restricted Project, Restricted Project
loralb added inline comments to D109584: [VP] Implementing expansion pass for VP load and store..
Feb 28 2022, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
  • Remove VP gather/scatter references (to be added in a follow-up patch)
  • Following the discussion in the comments, remove expandPredicationInUnfoldedLoadStore() function (to be added in a follow-up patch)
  • Apply suggestions in comments
  • Add tests
Feb 28 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
loralb commandeered D109584: [VP] Implementing expansion pass for VP load and store..
Feb 28 2022, 8:39 AM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2022

loralb added a comment to D109584: [VP] Implementing expansion pass for VP load and store..

hello @hussainjk @bmahjour, are you still working on this? Otherwise, I may take it over on your behalf.

Feb 25 2022, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
loralb added inline comments to D114884: [VP] Strided loads/stores.
Feb 25 2022, 6:42 AM · Restricted Project, Restricted Project, Restricted Project
loralb requested review of D120564: [VP] IR expansion pass for VP strided load and store.
Feb 25 2022, 6:16 AM · Restricted Project, Restricted Project

Feb 18 2022

loralb updated the diff for D114884: [VP] Strided loads/stores.
  • Mention that the align parameter attribute can be provided for the base pointer operands
Feb 18 2022, 9:16 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2021

loralb updated the diff for D114884: [VP] Strided loads/stores.
  • use explicit return type in Intrinsic::getDeclaration() for experimental_vp_strided_load
    • get first argument type from first operand in Intrinsic::getDeclaration() for experimental_vp_strided_store
Dec 15 2021, 6:36 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2021

loralb updated the diff for D114884: [VP] Strided loads/stores.
  • ensure default alignment behaviour reflects changes in D114423
    • align MemoryLocation retrieval for VPStridedLoad to VPLoad (see D115036)
Dec 14 2021, 8:40 AM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2021

loralb added a comment to D115027: [VP] [NFC] Fix vp_store signature and vp_gather examples.

Thanks everybody! I do not have commit access, can anyone commit this for me?

Dec 13 2021, 9:05 AM · Restricted Project

Dec 3 2021

loralb added inline comments to D114884: [VP] Strided loads/stores.
Dec 3 2021, 12:57 AM · Restricted Project, Restricted Project, Restricted Project
loralb updated the diff for D114884: [VP] Strided loads/stores.

ChangeLog:

  • add documentation for the new intrinsics
  • use MemoryLocation::UnknownSize
  • use SmallVectorImpl<SDValue> in functions signatures
Dec 3 2021, 12:52 AM · Restricted Project, Restricted Project, Restricted Project
loralb requested review of D115027: [VP] [NFC] Fix vp_store signature and vp_gather examples.
Dec 3 2021, 12:50 AM · Restricted Project

Dec 1 2021

loralb requested review of D114884: [VP] Strided loads/stores.
Dec 1 2021, 8:45 AM · Restricted Project, Restricted Project, Restricted Project