Page MenuHomePhabricator
Feed Advanced Search

Tue, Dec 1

emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

How do things go wrong on Darwin? I was under the impression that this was implemented in LLVM as strictly inline code, no runtime support required.

Tue, Dec 1, 8:45 AM · Restricted Project, Restricted Project

Mon, Nov 30

emaste added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

One thing that FreeBSD should do, is to upgrade to the protocol version 1 (stored in r_version), like Linux, NetBSD and OpenBSD.

Mon, Nov 30, 2:43 PM
emaste added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.
Mon, Nov 30, 2:21 PM
emaste added a comment to D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

Link to Linux info:
https://sourceware.org/gdb/wiki/LinkerInterface

Mon, Nov 30, 1:52 PM
emaste updated subscribers of D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld.

I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand.

Mon, Nov 30, 7:49 AM
emaste added a comment to D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress().

No objection, but maybe add a comment explaining the status of this implementation? Does/will NetBSD do the same?

Mon, Nov 30, 7:40 AM
emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

Can we add a test that the feature can be enabled on an OS other than Linux / Windows / Darwin?

Mon, Nov 30, 6:26 AM · Restricted Project, Restricted Project
emaste abandoned D92100: [clang] do not limit -fstack-clash-protection to Linux.

Abandon in favour of D92245

Mon, Nov 30, 6:25 AM
emaste added a comment to D92100: [clang] do not limit -fstack-clash-protection to Linux.

Perhaps

if (EffectiveTriple.isOSWindows() || EffectiveTriple.isOSDarwin())
  return;

here too

Mon, Nov 30, 6:23 AM

Wed, Nov 25

emaste added inline comments to D92100: [clang] do not limit -fstack-clash-protection to Linux.
Wed, Nov 25, 1:16 PM
emaste updated the diff for D92100: [clang] do not limit -fstack-clash-protection to Linux.
  • add comment suggested by @rnk
  • combine Linux and FreeBSD FileCheck
Wed, Nov 25, 1:14 PM
emaste added inline comments to D92100: [clang] do not limit -fstack-clash-protection to Linux.
Wed, Nov 25, 7:28 AM
emaste requested review of D92100: [clang] do not limit -fstack-clash-protection to Linux.
Wed, Nov 25, 7:25 AM

Tue, Nov 24

emaste added inline comments to D68720: Support -fstack-clash-protection for x86.
Tue, Nov 24, 5:34 PM · Restricted Project, Restricted Project

Thu, Nov 19

emaste accepted D91810: [lldb] Prevent 'process connect' from using local-only plugins.

Looks ok to me

Thu, Nov 19, 11:20 AM · Restricted Project

Wed, Nov 18

emaste added inline comments to D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Wed, Nov 18, 7:56 AM · Restricted Project

Tue, Nov 17

emaste added inline comments to D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Tue, Nov 17, 8:16 PM · Restricted Project

Tue, Nov 10

emaste added a comment to D91165: [libc++] Fix two fr_FR locale tests on FreeBSD.

I'm not sure if we need to add a runtime check?

Tue, Nov 10, 12:15 PM · Restricted Project
emaste accepted D91165: [libc++] Fix two fr_FR locale tests on FreeBSD.

This is fine with me; have we always done that?

Tue, Nov 10, 7:59 AM · Restricted Project

Mon, Nov 9

emaste added a comment to D91065: [lldb] [test] Rename '.categories' to 'categories'.

No objection from me but I haven't been sufficiently involved in lldb's tests to approve.

Mon, Nov 9, 7:59 AM · Restricted Project
emaste accepted D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes.

Agree that even if refactoring is needed correcting these makes sense.

Mon, Nov 9, 7:56 AM · Restricted Project

Sun, Nov 8

emaste accepted D91026: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'.
Sun, Nov 8, 6:18 AM · Restricted Project

Sat, Nov 7

emaste accepted D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP.
Sat, Nov 7, 1:11 PM · Restricted Project
emaste accepted D91012: [llvm] [Support] Fix segv if argv0 is null in getMainExecutable().
Sat, Nov 7, 1:09 PM · Restricted Project, Restricted Project
emaste added a comment to D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin.

In theory Obj-C is available on other systems

Sat, Nov 7, 1:09 PM · Restricted Project

Thu, Nov 5

emaste added a comment to D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests.

How does Windows fit into this? Other than that Q, LGTM.

Thu, Nov 5, 2:54 PM
emaste accepted D90862: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD.
Thu, Nov 5, 10:56 AM · Restricted Project
emaste added a comment to D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching.

Does Linux fetch each time also?
I agree it's probably not worth the effort.

Thu, Nov 5, 10:55 AM · Restricted Project
emaste added inline comments to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.
Thu, Nov 5, 6:40 AM · Restricted Project
emaste accepted D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

What do you suggest? Is it fine to go with my results for as long as I work on it? I can update it to match CI/buildbot results later.

Thu, Nov 5, 6:35 AM · Restricted Project

Wed, Nov 4

emaste added a comment to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

When running locally with this change applied I get:

Wed, Nov 4, 12:42 PM · Restricted Project
emaste added a comment to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

I added comments in the now-dereferenced bugs linking back to this review - most of them were submitted by me, and I'll double check and close them once this lands.

Wed, Nov 4, 10:04 AM · Restricted Project

Nov 2 2020

emaste accepted D90620: [lldb] [Process/FreeBSDRemote] Remove GetSharedLibraryInfoAddress override.
Nov 2 2020, 9:21 AM · Restricted Project

Oct 30 2020

emaste added a comment to D90454: [lldb] [Host/{free,net}bsd] Fix process matching by name.

There is TestProcessAttach.py that has an @expectedFailureNetBSD but no FreeBSD annotation, as well as TestCompletion.py, but I don't see these in the failing list.

Oct 30 2020, 7:02 AM · Restricted Project
emaste updated subscribers of D44964: Change order of libclang_rt.profile link for freebsd.
Oct 30 2020, 6:56 AM
emaste added a comment to D46791: Make -gsplit-dwarf generally available.

running clang -target x86_64-unknown-freebsd13.0 -split-dwarf foo.c indeed produces a foo.dwo and foo.o w/o invoking objcopy

Oct 30 2020, 6:56 AM

Oct 21 2020

emaste accepted D89859: Remove .svn from exclude list as we moved to git.
Oct 21 2020, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
emaste added a comment to D89859: Remove .svn from exclude list as we moved to git.

LGTM

Oct 21 2020, 7:00 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2020

emaste accepted D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support.
Oct 15 2020, 6:36 AM · Restricted Project
emaste added a comment to D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support.

Looks fine to me

Oct 15 2020, 6:36 AM · Restricted Project

Oct 13 2020

emaste added a comment to D89248: [lldb] [test/Register] Add read/write tests for multithreaded process.

Looks reasonable to me and currently fails (as expected) on FreeBSD.

Oct 13 2020, 11:31 AM · Restricted Project
emaste added inline comments to D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Oct 13 2020, 11:04 AM · Restricted Project
emaste added a comment to D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.

Looks OK

Oct 13 2020, 9:45 AM · Restricted Project
emaste added a comment to D88820: [libc++] Fix aligned_alloc tests FreeBSD.

fine with me

Oct 13 2020, 9:41 AM · Restricted Project
emaste added a comment to D88818: [libc++] Add missing XFAIL to tests that need __atomic_* libcalls.

fine with me

Oct 13 2020, 9:41 AM · Restricted Project

Sep 30 2020

emaste committed rGf794160c6cb7: [lldb] Fix FreeBSD Arm Process Plugin build (authored by emaste).
[lldb] Fix FreeBSD Arm Process Plugin build
Sep 30 2020, 6:25 AM
emaste closed D88453: [lldb] Fix FreeBSD Arm Process Plugin build..
Sep 30 2020, 6:25 AM · Restricted Project

Aug 28 2020

emaste added inline comments to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.
Aug 28 2020, 11:56 AM · Restricted Project, Restricted Project

Aug 26 2020

emaste added a comment to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.

It looks like this conflicts with OpenSSL's compiler version check

Aug 26 2020, 12:28 PM · Restricted Project

Aug 25 2020

emaste added inline comments to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.
Aug 25 2020, 6:12 PM · Restricted Project, Restricted Project

Aug 22 2020

emaste updated subscribers of D86397: Move special va_list handling to kmp_os.h.
Aug 22 2020, 7:26 AM · Restricted Project
emaste added a comment to D77333: OpenMP: Support FreeBSD on AArch64..

See D86397

Aug 22 2020, 7:25 AM · Restricted Project

Aug 18 2020

emaste added a comment to D86163: Default to disabling the libunwind frameheader cache.

Ah if you use _LIBUNWIND_USE_FRAME_HEADER_CACHE instead (i.e., a _ between FRAME and HEADER) it will match the workaround committed to FreeBSD.

Aug 18 2020, 1:30 PM · Restricted Project, Restricted Project
emaste updated subscribers of D86163: Default to disabling the libunwind frameheader cache.
Aug 18 2020, 1:28 PM · Restricted Project, Restricted Project
emaste added a comment to D86163: Default to disabling the libunwind frameheader cache.

Looks reasonable to me.

Aug 18 2020, 1:23 PM · Restricted Project, Restricted Project

Jul 27 2020

emaste accepted D84510: [msan] Compile the libatomic.c test with a C compiler.

LGTM

Jul 27 2020, 7:17 AM · Restricted Project

Jul 24 2020

emaste accepted D84541: [asan] Mark the strstr test as UNSUPPORTED on FreeBSD.

LGTM, we acquired our strstr from musl

Jul 24 2020, 11:13 AM · Restricted Project

Jul 12 2020

emaste accepted D83645: Bump the default target CPU for i386-freebsd to i686.

Fine with me

Jul 12 2020, 12:50 PM · Restricted Project

Jul 3 2020

emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project
emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project
emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project

Jun 29 2020

emaste added a comment to D82786: [llvm-ar] Unsupport test on FreeBSD.

Sorry- the review is fine as-is. There is some nuance here, but it is better to just mark this unsupported for now (as you've done) and we (FreeBSD) can revisit later when all supported versions do not allow reading dirfds.

Jun 29 2020, 3:18 PM · Restricted Project

Jun 25 2020

emaste added a comment to D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().

some nitpick comments. I'm not familiar with z/OS's APIs here so not qualified to fully review the change in getMainExecutable but seems reasonable

Jun 25 2020, 6:53 AM · Restricted Project

Jun 12 2020

emaste added a comment to D77333: OpenMP: Support FreeBSD on AArch64..

LGTM

Jun 12 2020, 11:28 AM · Restricted Project

May 30 2020

emaste added a comment to D80871: [Object] Add DF_1_PIE.

LGTM

May 30 2020, 1:46 PM · Restricted Project
emaste added a comment to D80872: [ELF] Set DF_1_PIE for -pie.

This LGTM.
I'm now adding support in FreeBSD, e.g. https://reviews.freebsd.org/rS361657

May 30 2020, 1:14 PM · Restricted Project
emaste added inline comments to D80872: [ELF] Set DF_1_PIE for -pie.
May 30 2020, 12:11 PM · Restricted Project

May 7 2020

emaste committed rG21e5e1724b75: getMainExecutable: Fix hand-rolled AT_EXECPATH for older FreeBSD (authored by emaste).
getMainExecutable: Fix hand-rolled AT_EXECPATH for older FreeBSD
May 7 2020, 2:10 PM
emaste closed D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.
May 7 2020, 2:10 PM · Restricted Project
emaste added a comment to D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.

I will commit this shortly (and then merge the change into FreeBSD's copy).

May 7 2020, 1:35 PM · Restricted Project

May 2 2020

emaste accepted D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.
May 2 2020, 1:14 PM · Restricted Project

Apr 20 2020

emaste accepted D77776: [Driver] Default to libc++ on FreeBSD.

Looks ok to me

Apr 20 2020, 11:53 AM · Restricted Project
emaste added a comment to D77776: [Driver] Default to libc++ on FreeBSD.
  • Limit the scope to -stdlib
In D77776#1972543, @dim wrote:

the lowest supported version, which is currently 10

Where is this defined? Does someone build LLVM master on FreeBSD < 11.3?

Apr 20 2020, 11:53 AM · Restricted Project

Apr 2 2020

emaste committed rG55e32e92cda7: [lldb] update eArgTypeScriptLang description to mention lua (authored by emaste).
[lldb] update eArgTypeScriptLang description to mention lua
Apr 2 2020, 7:01 AM
emaste closed D77241: update eArgTypeScriptLang description to mention lua.
Apr 2 2020, 7:01 AM · Restricted Project

Apr 1 2020

emaste committed rGaf1b7d06d9e4: Correct copy-pasteo in lua script language description (authored by emaste).
Correct copy-pasteo in lua script language description
Apr 1 2020, 9:14 PM
emaste updated the diff for D77241: update eArgTypeScriptLang description to mention lua.

reword

Apr 1 2020, 5:26 PM · Restricted Project
emaste created D77241: update eArgTypeScriptLang description to mention lua.
Apr 1 2020, 1:41 PM · Restricted Project

Mar 21 2020

emaste added a comment to D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__.

Ping.

Mar 21 2020, 12:48 PM

Feb 7 2020

emaste added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 7 2020, 6:12 AM · Restricted Project, Restricted Project

Feb 6 2020

emaste added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 5:41 AM · Restricted Project, Restricted Project
emaste added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

It will be nice to include in the description what systems were not supported by hard coding 560, if such information can be obtained relatively easily.

Feb 6 2020, 5:41 AM · Restricted Project, Restricted Project

Dec 16 2019

emaste added inline comments to D71554: [llvm-ranlib] Handle -D and -U command line flag.
Dec 16 2019, 9:29 AM · Restricted Project, Restricted Project

Nov 18 2019

emaste committed rGb462cdff05b8: Avoid duplicate exe_path definition on recent FreeBSD (authored by emaste).
Avoid duplicate exe_path definition on recent FreeBSD
Nov 18 2019, 5:54 AM

Nov 17 2019

emaste added a comment to D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..

Should have a test added

Nov 17 2019, 10:15 AM · Restricted Project

Nov 15 2019

emaste added a comment to D70157: Align branches within 32-Byte boundary(NOP padding).

I think the default policy discussion might be better had on llvm-dev than a Phab review.

Nov 15 2019, 12:28 PM · Restricted Project, Restricted Project
emaste committed rGcb1761465a0d: clang: enable unwind tables on FreeBSD !amd64 (authored by emaste).
clang: enable unwind tables on FreeBSD !amd64
Nov 15 2019, 7:43 AM
emaste closed D70110: [Driver][FreeBSD] Enable unwind tables on !amd64.
Nov 15 2019, 7:42 AM · Restricted Project
emaste added a comment to D70157: Align branches within 32-Byte boundary(NOP padding).

Shall we default to -mbranches-within-32B-boundaries if the specified -march= or -mtune= may be affected by the erratum?

Nov 15 2019, 6:40 AM · Restricted Project, Restricted Project

Nov 14 2019

emaste updated subscribers of D70157: Align branches within 32-Byte boundary(NOP padding).
Nov 14 2019, 10:06 AM · Restricted Project, Restricted Project
emaste committed rGa0a38b81ea91: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath (authored by emaste).
On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath
Nov 14 2019, 6:54 AM
emaste closed D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.
Nov 14 2019, 6:54 AM · Restricted Project

Nov 13 2019

emaste updated subscribers of D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.
Nov 13 2019, 2:21 PM · Restricted Project
emaste updated the diff for D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.

Use elf_aux_info() if we can

Nov 13 2019, 2:14 PM · Restricted Project
emaste added a comment to D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.

See https://bugs.freebsd.org/241932

Nov 13 2019, 12:02 PM · Restricted Project
emaste created D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.
Nov 13 2019, 11:50 AM · Restricted Project

Nov 8 2019

emaste added a comment to D70011: lld patch for Linker Script UTF-8 BOM encoding capability .

Out of curiosity what workflow leads to BOMs in linker scripts?

Nov 8 2019, 9:12 AM · Restricted Project, lld

Oct 23 2019

emaste added a comment to D69004: Use portable flag with nm in extract_symbols.py.

I was under the impression that -P was supported on FreeBSD.

Oct 23 2019, 3:47 PM · Restricted Project
emaste added a comment to D69004: Use portable flag with nm in extract_symbols.py.

Is this using the system nm? ELF Tool Chain nm does not (currently) support the -P flag.

Oct 23 2019, 2:14 PM · Restricted Project

Oct 18 2019

emaste accepted D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 12:59 PM · Restricted Project