Should have a test added
Fri, Nov 15
I think the default policy discussion might be better had on llvm-dev than a Phab review.
Shall we default to -mbranches-within-32B-boundaries if the specified -march= or -mtune= may be affected by the erratum?
Thu, Nov 14
Wed, Nov 13
Use elf_aux_info() if we can
Fri, Nov 8
Out of curiosity what workflow leads to BOMs in linker scripts?
Wed, Oct 23
I was under the impression that -P was supported on FreeBSD.
Is this using the system nm? ELF Tool Chain nm does not (currently) support the -P flag.
Oct 18 2019
OK with me
Oct 2 2019
For reference libcxxrt comes from here: https://github.com/libcxxrt/libcxxrt
Sep 27 2019
Sep 24 2019
Please also exclude FreeBSD from these changes, since we care a lot about backwards compatibility, and specifically about alignment requirements. (We have run into many issues in our ports collection where upstream assumes everything is 16-byte aligned on i386, which is *NOT* ABI compliant.)
Sep 9 2019
This is fine with me as a little simplification and avoid an extra syscall.
error = vn_fullpath(req->td, vp, &retbuf, &freebuf); vrele(vp); if (error) return (error); error = SYSCTL_OUT(req, retbuf, strlen(retbuf) + 1);
and in vn_fullpath:
buf = malloc(MAXPATHLEN, M_TEMP, M_WAITOK);
Sep 7 2019
LGTM from the FreeBSD perspective.
Sep 3 2019
- also change __addtf3 return type
Correct typo, update tests
Aug 29 2019
Aug 26 2019
Aug 14 2019
And moved to CodeGen in rL339397
Jul 30 2019
My understanding is that many developers use makefile/ninja generation systems such as cmake rather than hand-write the file themselves. As such would this get much use unless it was integrated into these generators? May be worth approaching them to see if they have any requirements/observations about the option?
Jul 29 2019
Jul 23 2019
OK, I will try to check if it still applies cleanly and commit soon
Jul 22 2019
Jun 4 2019
I've created D62862 which is independent of X86/AArch64.
May 27 2019
May 7 2019
Apr 24 2019
I'm using this change: https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21
In FreeBSD 12 and later we use Clang, lld, and ELF Tool Chain. (We still have gas and objdump from the outdated binutils 2.17.50.)
Will you upstream this commit (I can abandon this one)? I created this revision because I was learning clangDriver... I had a vague and probably incorrect impression that some folks said kgdb or dtrace or whatever might not support DWARF 3 or 4.
Apr 15 2019
LGTM. I much prefer only - short and -- long options, except for lld where unfortunately there's a precedent of accepting both.
Mar 18 2019
We are using a special CET SDV for CET enabling. We have been enabling CET in Fedora piece by piece by adding -fcf-protection to CFLAGS.
H.J. have enable the CET in GNU-toolchain and rebuild/rewrite the related libs/linux-kernal, his team are testing it for at last one year.
Mar 7 2019
@xiangzhangllvm, a question for you not directly related to the patch but I suspect you might be best suited to find an answer: how do we test CET support today? We started trying to add CET to FreeBSD some time ago but have no way to test any work that we do.
How does lld handle the non-executable stack flag? From a developer point of view, the CET processing is supposed to be very similar.
Feb 21 2019
Feb 7 2019
Did -z ifunc-noplt work well for FreeBSD kernel? If it works well, maybe we should merge it to the mainline lld tree?
Feb 6 2019
Feb 5 2019
The description is certainly not right. IE can be used from dlopen'd objects without problems as long as there is still reserved space around and the data is not initialized non-trivially or the dynamic linker is willing to fix up all threads. The point of the flag is to allow the dynamic linker to make a quick decision without having to scan the relocation table first. A classic user of this was libGL. It also applies to many platforms, not just i386. As such, please update the description before any commit.
Feb 4 2019
Feb 3 2019
FreeBSD patch adding initial exec TLS mode for dynamically loaded shared objects: https://reviews.freebsd.org/D19072. Can we revisit this lld patch?
Jan 7 2019
There is a list of 140-150 unsafe (LLD_UNSAFE) packages with LLD.
Dec 21 2018
I think the arch-change (switching from a whitelist to a MIPS blacklist) is reasonable. What is the motivation for dropping DT_HASH, just binary size reduction?
Dec 18 2018
Dec 6 2018
Can I go ahead with this version as a starting point?
Dec 3 2018
- fix warnings from mandoc -Tlint and/or igor
- remove options that should not be listed
Nov 27 2018
This is fine for me (from FreeBSD's perspective), but I suspect some people (on operating systems without ifuncs in libc) may be surprised by having a(n empty) .rela.plt in all of their statically linked binaries.
I have an interim copy in FreeBSD and am updating it based on the feedback here; I'll update this review shortly.
Nov 26 2018
Additional comment that wasn't submitted while reviews.llvm.org was down on Friday: I started working on this as it's needed for us to switch from GNU objdump to llvm-objdump in FreeBSD (FreeBSD PR229046).
Nov 25 2018
I think this is reasonable.
Perhaps someone else can review?
Nov 24 2018
lgtm, but seems that some hidden/alias options are not listed here (I could help add them). I am not expert in this area, so I will leave the decision to @kristina
Nov 23 2018
Nov 22 2018
Nov 21 2018
Confirmed this fixes my bug.