Page MenuHomePhabricator
Feed Advanced Search

Yesterday

qcolombet committed rG2ec71ea7c74d: [RegisterCoalescer] Fix the creation of subranges when rematerialization is used (authored by qcolombet).
[RegisterCoalescer] Fix the creation of subranges when rematerialization is used
Thu, Dec 5, 4:35 PM

Wed, Dec 4

qcolombet accepted D71038: [GlobalISel] Localizer: Allow targets not to run the pass conditionally.
Wed, Dec 4, 5:29 PM · Restricted Project

Tue, Dec 3

qcolombet accepted D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.

LGTM.
One nit below.

Tue, Dec 3, 9:00 AM · Restricted Project

Mon, Dec 2

qcolombet added inline comments to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..
Mon, Dec 2, 5:35 PM · Restricted Project
qcolombet added inline comments to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Mon, Dec 2, 5:26 PM · Restricted Project
qcolombet added inline comments to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Mon, Dec 2, 4:48 PM · Restricted Project
qcolombet accepted D70565: [MCRegInfo] Add forward sub and super register iterators. (NFC).
Mon, Dec 2, 1:57 PM · Restricted Project
qcolombet added a comment to D69936: [IPRA][ARM] Spill extra registers at -Oz.

Looks reasonable (haven't looked at the ARM part.)
The change in shrink wrapping doesn't look correct to me though. Is that particular change require?

Mon, Dec 2, 1:57 PM · Restricted Project

Thu, Nov 21

qcolombet accepted D70558: [MIBundles] Move analyzeVirtReg out of MIBundleOperands iterator (NFC)..

LGTM

Thu, Nov 21, 12:59 PM · Restricted Project

Fri, Nov 15

qcolombet committed rG98ceac498167: [GISel][CombinerHelper] Use uses() instead of operands() when traversing use… (authored by qcolombet).
[GISel][CombinerHelper] Use uses() instead of operands() when traversing use…
Fri, Nov 15, 1:57 PM
qcolombet committed rG304abde0779b: [GISel][CombinerHelper] Add support for scalar type for the result of shuffle… (authored by qcolombet).
[GISel][CombinerHelper] Add support for scalar type for the result of shuffle…
Fri, Nov 15, 1:57 PM

Wed, Nov 13

qcolombet committed rGde94cda81bde: [LiveInterval] Allow updating subranges with slightly out-dated IR (authored by qcolombet).
[LiveInterval] Allow updating subranges with slightly out-dated IR
Wed, Nov 13, 11:24 AM

Nov 6 2019

qcolombet committed rG52af7aedfe5d: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with… (authored by qcolombet).
[GISel][ArtifactCombiner] Relax the constraint to combine unmerge with…
Nov 6 2019, 11:33 AM
qcolombet closed D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.
Nov 6 2019, 11:32 AM · Restricted Project

Nov 4 2019

qcolombet added a comment to D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.

Are you planning on fixing the regression in the near future? If so splitting the patches this way seems fine

Nov 4 2019, 11:26 AM · Restricted Project
qcolombet added a comment to D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.

@arsenm ping^2 on the AMDGPU test changes.

Nov 4 2019, 9:03 AM · Restricted Project

Nov 1 2019

qcolombet accepted D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement..

LGTM, thanks!

Nov 1 2019, 9:39 AM · Restricted Project
qcolombet added a comment to D69653: [GlobalISel] Match table opt: fix a bug in matching num of operands.

Thanks for the test case!

Nov 1 2019, 9:29 AM · Restricted Project

Oct 31 2019

qcolombet accepted D69653: [GlobalISel] Match table opt: fix a bug in matching num of operands.

For the test case, couldn't you add a isVariadic instruction with different patterns in one of the TableGen test?

Oct 31 2019, 1:54 PM · Restricted Project
qcolombet added inline comments to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Oct 31 2019, 10:29 AM · Restricted Project
qcolombet added a comment to D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement..

Looks sensible to me.

Oct 31 2019, 10:20 AM · Restricted Project

Oct 30 2019

qcolombet committed rGf0eeb3c7a713: [GISel][CombinerHelper] Combine shuffle_vector scalar to build_vector (authored by qcolombet).
[GISel][CombinerHelper] Combine shuffle_vector scalar to build_vector
Oct 30 2019, 6:41 PM

Oct 29 2019

qcolombet added a comment to D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.

@arsenm ping on the AMDGPU test changes.

Oct 29 2019, 11:13 AM · Restricted Project

Oct 28 2019

qcolombet added a comment to D69219: [SelectionDAG] Enable lowering unordered atomics loads w/LoadSDNode (and stores w/StoreSDNode) by default.

Thanks Philip for double checking.

Oct 28 2019, 3:01 PM · Restricted Project
qcolombet requested changes to D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Oct 28 2019, 12:56 PM · Restricted Project
qcolombet accepted D69219: [SelectionDAG] Enable lowering unordered atomics loads w/LoadSDNode (and stores w/StoreSDNode) by default.
Oct 28 2019, 11:56 AM · Restricted Project
qcolombet accepted D69515: [LiveIntervalUnion] Expose extraction of last index in map for external users.
Oct 28 2019, 8:54 AM · Restricted Project

Oct 25 2019

qcolombet accepted D69449: TableGen: Use enum names in composeSubRegIndices table.
Oct 25 2019, 2:56 PM · Restricted Project

Oct 24 2019

qcolombet added a comment to D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.

I found a latent bug that has now more chances to trigger with the relaxations that this patch brings.
I've updated the patch to fix the bug, but I have now a bunch of "regressions" on AMDGPU test cases because the fix is too conservative.
Is this still okay to land?

Oct 24 2019, 10:37 PM · Restricted Project
qcolombet added inline comments to D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.
Oct 24 2019, 10:37 PM · Restricted Project
qcolombet updated the diff for D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.
  • Fix a latent bug
  • Update AMDGPU tests
Oct 24 2019, 10:18 PM · Restricted Project

Oct 23 2019

qcolombet updated the diff for D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.
  • Remove ADJUSTxxx operations in the tests
Oct 23 2019, 8:23 AM · Restricted Project

Oct 22 2019

qcolombet added inline comments to D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.
Oct 22 2019, 8:09 AM · Restricted Project

Oct 21 2019

qcolombet created D69288: [GISel][ArtifactCombiner] Relax the constraint to combine unmerge with concat_vectors.
Oct 21 2019, 5:29 PM · Restricted Project
qcolombet added a comment to D69149: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors.

Thanks for the quick review @arsenm!

Oct 21 2019, 2:04 PM · Restricted Project
qcolombet committed rG6f0ae81512c1: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors (authored by qcolombet).
[GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors
Oct 21 2019, 1:46 PM
qcolombet closed D69149: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors.
Oct 21 2019, 1:46 PM · Restricted Project
qcolombet committed rL375452: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors.
[GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors
Oct 21 2019, 1:46 PM

Oct 18 2019

qcolombet accepted D68149: LiveIntervals: Fix handleMoveUp with subreg def moving across a def.

LGTM.

Oct 18 2019, 2:41 PM
qcolombet committed rG9f9151d49410: [GISel][CallLowering] Make isIncomingArgumentHandler a pure virtual method (authored by qcolombet).
[GISel][CallLowering] Make isIncomingArgumentHandler a pure virtual method
Oct 18 2019, 1:17 PM
qcolombet committed rL375277: [GISel][CallLowering] Make isIncomingArgumentHandler a pure virtual method.
[GISel][CallLowering] Make isIncomingArgumentHandler a pure virtual method
Oct 18 2019, 1:17 PM
qcolombet closed D69187: [GISel][CallLowering] Make isIncomingArgumentHandler a pure virtual method.
Oct 18 2019, 1:17 PM · Restricted Project
qcolombet created D69187: [GISel][CallLowering] Make isIncomingArgumentHandler a pure virtual method.
Oct 18 2019, 11:25 AM · Restricted Project

Oct 17 2019

qcolombet updated the diff for D69149: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors.
  • Replace some unsigned into Register
Oct 17 2019, 4:40 PM · Restricted Project
qcolombet added inline comments to D69149: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors.
Oct 17 2019, 4:40 PM · Restricted Project
qcolombet abandoned D59339: [GISel][Legalizer][WIP][RFC] Retry legalization for failing instrs when artifacts are around.

This was just a patch to illustrate a possible direction.

Oct 17 2019, 4:31 PM · Restricted Project
qcolombet created D69149: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors.
Oct 17 2019, 4:12 PM · Restricted Project

Oct 16 2019

qcolombet committed rGc319afc903d8: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) =>… (authored by qcolombet).
[GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) =>…
Oct 16 2019, 5:39 PM
qcolombet closed D69071: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) => build_vector.
Oct 16 2019, 5:38 PM · Restricted Project
qcolombet committed rL375066: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) =>….
[GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) =>…
Oct 16 2019, 5:38 PM
qcolombet updated the diff for D69071: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) => build_vector.
  • Remove asserts already covered by the verifier
  • Put .getType calls into a variable.
Oct 16 2019, 4:48 PM · Restricted Project
qcolombet updated the diff for D69071: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) => build_vector.
  • Replace check with an assertion
  • Update comments with pre-conditions
Oct 16 2019, 3:36 PM · Restricted Project
qcolombet added inline comments to D69071: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) => build_vector.
Oct 16 2019, 3:36 PM · Restricted Project
qcolombet updated the diff for D69071: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) => build_vector.
  • Use ArrayRef instead of const SmallVectorImpl&
  • Add tests with pointer types.
Oct 16 2019, 2:57 PM · Restricted Project
qcolombet added inline comments to D69071: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) => build_vector.
Oct 16 2019, 2:47 PM · Restricted Project
qcolombet created D69071: [GISel][CombinerHelper] Add concat_vectors(build_vector, build_vector) => build_vector.
Oct 16 2019, 2:29 PM · Restricted Project

Oct 11 2019

qcolombet committed rG49036dd3aef9: [GISel][UnitTest] Fix a bunch of tests that were not doing anything (authored by qcolombet).
[GISel][UnitTest] Fix a bunch of tests that were not doing anything
Oct 11 2019, 2:04 PM
qcolombet committed rL374595: [GISel][UnitTest] Fix a bunch of tests that were not doing anything.
[GISel][UnitTest] Fix a bunch of tests that were not doing anything
Oct 11 2019, 2:04 PM
qcolombet committed rG9c36ec594173: [GISel][CallLowering] Enable vector support in argument lowering (authored by qcolombet).
[GISel][CallLowering] Enable vector support in argument lowering
Oct 11 2019, 1:25 PM
qcolombet committed rG7720f1149867: [MachineIRBuilder] Fix an assertion failure with buildMerge (authored by qcolombet).
[MachineIRBuilder] Fix an assertion failure with buildMerge
Oct 11 2019, 1:24 PM
qcolombet committed rL374589: [GISel][CallLowering] Enable vector support in argument lowering.
[GISel][CallLowering] Enable vector support in argument lowering
Oct 11 2019, 1:24 PM
qcolombet committed rL374588: [MachineIRBuilder] Fix an assertion failure with buildMerge.
[MachineIRBuilder] Fix an assertion failure with buildMerge
Oct 11 2019, 1:24 PM

Oct 7 2019

qcolombet accepted D68582: GlobalISel: Add target pre-isel instructions.
Oct 7 2019, 10:30 AM

Sep 19 2019

qcolombet accepted D67684: MachineScheduler: Fix missing dependency with multiple subreg defs.

LGTM

Sep 19 2019, 4:22 PM

Sep 17 2019

qcolombet accepted D67464: MachineScheduler: Fix assert from not checking subregs.

Hi Matt,

Sep 17 2019, 11:02 AM

Sep 12 2019

qcolombet accepted D67505: LiveIntervals: Remove assertion.

LGTM

Sep 12 2019, 10:26 AM

Sep 11 2019

qcolombet accepted D67448: LiveIntervals: Split live intervals on multiple dead defs.

LGTM

Sep 11 2019, 9:26 AM

Sep 6 2019

qcolombet added a comment to D67303: [AArch64][GlobalISel] Enable the localizer for optimized builds.

The swifterror test change in this patch is one example. Live ranges over function calls can be problematic if under register pressure, which can cause additional moves, if not spills. There are others of course

Sep 6 2019, 3:37 PM · Restricted Project
qcolombet accepted D67303: [AArch64][GlobalISel] Enable the localizer for optimized builds.

Hi Amara,

Sep 6 2019, 2:51 PM · Restricted Project
qcolombet requested changes to D67257: New statepoint spilling mechanism.

I don't think this patch is correct in the sense that having statepoints depend on GreedyRegAlloc is a non-starter.
Indeed, that means that now any configuration that doesn't use greedy reg alloc (like fast or basic reg alloc) will generate incorrect code with respect to state point spilling.

Sep 6 2019, 11:19 AM · Restricted Project

Sep 4 2019

qcolombet accepted D54368: RegAllocFast: Record internal state based on register units.

Suggestion of a small refactoring below.

Sep 4 2019, 12:31 PM · Restricted Project
qcolombet added inline comments to D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE.
Sep 4 2019, 11:59 AM · Restricted Project
qcolombet committed rL370944: Add myself.
Add myself
Sep 4 2019, 10:58 AM

Aug 20 2019

qcolombet accepted D66438: [llvm-extract] Update the help message for group extraction feature.
Aug 20 2019, 12:45 PM · Restricted Project

Aug 19 2019

qcolombet added a comment to D66438: [llvm-extract] Update the help message for group extraction feature.

Hi Jinsong,

Aug 19 2019, 3:47 PM · Restricted Project
qcolombet accepted D66444: [BlockExtractor] Avoid assert with wrong line format.
Aug 19 2019, 3:47 PM · Restricted Project

Aug 16 2019

qcolombet accepted D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Aug 16 2019, 4:22 PM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Aug 16 2019, 4:22 PM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Aug 16 2019, 12:25 PM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Aug 16 2019, 10:49 AM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Aug 16 2019, 10:49 AM · Restricted Project

Aug 13 2019

qcolombet added a comment to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.

LGTM with a test case.

Aug 13 2019, 10:00 AM · Restricted Project
qcolombet added a comment to D63731: [AMDGPU] Prevent VGPR copies from moving across the EXEC mask definitions.

LGTM for the generic part.

Aug 13 2019, 9:58 AM · Restricted Project

Aug 1 2019

qcolombet added inline comments to D63731: [AMDGPU] Prevent VGPR copies from moving across the EXEC mask definitions.
Aug 1 2019, 7:02 AM · Restricted Project
qcolombet accepted D65466: CodeGen: Allow virtual registers in bundles.
Aug 1 2019, 2:05 AM

Jul 19 2019

qcolombet accepted D64503: LiveIntervals: Fix handleMove asserting on BUNDLE.
Jul 19 2019, 12:05 PM

Jul 8 2019

qcolombet accepted D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.
Jul 8 2019, 11:05 AM
qcolombet added a comment to D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.

It was added by D46315

Jul 8 2019, 11:05 AM
qcolombet added a comment to D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.

Remove loop entirely. Ultimately determineCalleeSaves adds everything from MCRegAliasIterator anyway

Jul 8 2019, 10:48 AM
qcolombet added inline comments to D64354: [AArch64][GlobalISel] Optimize conditional branches followed by unconditional branches.
Jul 8 2019, 9:59 AM · Restricted Project
qcolombet added inline comments to D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.
Jul 8 2019, 8:22 AM

Jul 5 2019

qcolombet committed rG0ffe0db6fab4: [RegisterCoalescer] Fix an overzealous assert (authored by qcolombet).
[RegisterCoalescer] Fix an overzealous assert
Jul 5 2019, 5:36 PM
qcolombet committed rL365256: [RegisterCoalescer] Fix an overzealous assert.
[RegisterCoalescer] Fix an overzealous assert
Jul 5 2019, 5:34 PM
qcolombet accepted D64266: RegUsageInfoCollector: Skip AMDGPU entry point functions.

Let's go with that for now with one caveat. Does the code build without ANDGPU?
I.e., does the callingconv enum get generated?

Jul 5 2019, 3:44 PM

Jul 3 2019

qcolombet accepted D64108: [GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for selectArithImmed.
Jul 3 2019, 9:42 AM · Restricted Project

Jul 2 2019

qcolombet requested changes to D64108: [GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for selectArithImmed.

General direction LGTM but there's a bug in the current patch unless I am mistaken.

Jul 2 2019, 4:08 PM · Restricted Project

Jun 19 2019

qcolombet added a comment to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

I second Daniel's comment, this is RegBankSelect's job to do this choice and the Legalizer shouldn't need to know about f64 vs. s64.

Jun 19 2019, 2:18 PM · Restricted Project
qcolombet accepted D63496: [WIP] CodeGen: Prototype class for registers.

Maybe adding an MCRegister that's nearly identical might be a future improvement? That way it could enforce MCRegister->Register is OK, but Register->MCRegister is not

Jun 19 2019, 10:49 AM

Jun 18 2019

qcolombet added a comment to D63496: [WIP] CodeGen: Prototype class for registers.

Thanks for doing this Matt, this is a long due clean-up.
I haven't looked carefully at all the changes, but the general direction LGTM.

Jun 18 2019, 11:58 AM

Jun 17 2019

qcolombet added a comment to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

Those rules work when there's a load/store for every type but they run into unable-to-legalize if that's not the case.

Jun 17 2019, 2:34 PM · Restricted Project