In D95987#2543866, @zequanwu wrote:For the example you provided, I am not sure if it's a bug or not. Segment at 3:45 (count = 0), RegionEntry corresponds to the error path of the ? operator, which means error path is not executed. So, the 0 count looks reasonable. If we mark line 3 as executed regardless of which path is chosen, we may lost the information of path choices.
I just realized that this also applies to C++ ? operator. In the following case, if we always mark line 5 as executed, we don't know which branch is chosen (But when generating html report by llvm-cov, we will see that the not executed branch is marked with red color).
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Fri, Feb 5
Fri, Feb 5
pirama added a comment to D95987: [llvm-cov] Reset ExecutionCount only if first line segment is start of a new region..
Wed, Feb 3
Wed, Feb 3
pirama updated subscribers of D95987: [llvm-cov] Reset ExecutionCount only if first line segment is start of a new region..
Thanks for the patch Zequan. This fixes the C++ test case that prompted this issue.
Nov 10 2020
Nov 10 2020
pirama committed rG8262e94a6da7: [ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt. (authored by pirama).
[ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt.
Nov 10 2020, 1:40 PM · Restricted Project
pirama updated the diff for D91192: [ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt..
Added CHECK line for TCRETURNri
Nov 10 2020, 12:47 PM · Restricted Project
pirama requested review of D91192: [ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt..
Nov 10 2020, 11:33 AM · Restricted Project
Nov 10 2020, 11:27 AM · Restricted Project
Apr 13 2020
Apr 13 2020
In D78033#1978612, @beanz wrote:I think this has some unintended consequences. If your tool wants to use libLLVM and libClang you really need libClang to be linked against libLLVM, otherwise you're actually just hiding the problem.
Apr 13 2020, 11:57 PM · Restricted Project
Apr 13 2020, 10:11 AM · Restricted Project
Mar 20 2020
Mar 20 2020
pirama committed rGfe5599eac6a5: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs (authored by pirama).
[llvm-ar] Use target triple to deduce archive kind for bitcode inputs
Mar 20 2020, 1:35 PM · Restricted Project
pirama added a comment to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Merged. Thanks for the review @MaskRay.
Mar 20 2020, 1:34 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Cleanup based on review comments.
Mar 20 2020, 12:28 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Use isOSDarwin() instead of isOSBinFormatMachO()
Mar 20 2020, 11:23 AM · Restricted Project
pirama added inline comments to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Mar 20 2020, 10:52 AM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Treat any bitode with non-Darwin triple as GNU.
Test cleanup.
Mar 20 2020, 10:49 AM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Use K_GNU for all ELF targets.
Mar 20 2020, 10:49 AM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Simplify test.
Mar 20 2020, 10:17 AM · Restricted Project
pirama committed rGedcfb47ff6d5: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal… (authored by pirama).
[DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal…
pirama closed D76312: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal type.
Mar 20 2020, 9:45 AM · Restricted Project
Mar 19 2020
Mar 19 2020
pirama added a comment to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Mar 19 2020, 9:54 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Apply clang-format.
Mar 19 2020, 9:54 PM · Restricted Project
pirama added a comment to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
In D76461#1932516, @MaskRay wrote:https://llvm.org/doxygen/classllvm_1_1object_1_1Archive.html#ab288378fa8bfa0678dd25e36b5198a87. I think this regresses behavior for those other hosts.
*BSD may need the __.SYMDEF format.
Have you considered passing an explicit --format= via something like ARFLAGS?
Mar 19 2020, 6:41 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Handle bitcode inputs with BSD target triple.
Mar 19 2020, 6:39 PM · Restricted Project
Mar 19 2020, 4:27 PM · Restricted Project
Mar 18 2020
Mar 18 2020
pirama updated the diff for D76312: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal type.
Cleanup test.
Mar 18 2020, 3:46 PM · Restricted Project
Mar 17 2020
Mar 17 2020
pirama created D76312: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal type.
Mar 17 2020, 12:23 PM · Restricted Project
Dec 2 2019
Dec 2 2019
pirama updated subscribers of D64045: [InstrProfiling] Put instrumentation into comdat group with function.
Dec 2 2019, 5:07 PM · Restricted Project
Nov 19 2019
Nov 19 2019
In D65550#1752082, @vsk wrote:Thanks Nick & Eli, '-fno-integrated-as' does the trick, as does changing the makefile. If the effect of this patch on the asm writer is intentional/correct, we can just push for a project change instead of fiddling with the compiler.
Nov 19 2019, 2:24 PM · Restricted Project
Oct 7 2019
Oct 7 2019
pirama closed D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Oct 7 2019, 3:33 AM · Restricted Project
Sep 11 2019
Sep 11 2019
pirama committed rG8b46544641ef: [IRMover] Don't map globals if their types are the same (authored by pirama).
[IRMover] Don't map globals if their types are the same
[IRMover] Don't map globals if their types are the same
Sep 11 2019, 11:35 AM · Restricted Project
Sep 11 2019, 11:06 AM · Restricted Project
- Do not have a declaration as a prevailing symbol in llvm-lto2's arguments
- Fix comments in test
Sep 11 2019, 11:06 AM · Restricted Project
In D66814#1666487, @tejohnson wrote:In D66814#1666457, @pirama wrote:(note the summary description of the patch needs to be adjusted similarly, it still refers to the summary).
Sep 11 2019, 11:06 AM · Restricted Project
@tejohnson Did my reply about shared metadata clarify your question?
Sep 11 2019, 10:00 AM · Restricted Project
Sep 9 2019
Sep 9 2019
pirama committed rGff49a52cf3dd: [Driver] Handle default case in refactored addOpenMPRuntime (authored by pirama).
[Driver] Handle default case in refactored addOpenMPRuntime
[Driver] Handle default case in refactored addOpenMPRuntime
Check for OMPRT_Unknown instead of a default case.
[Driver] Add -static-openmp driver option
[Driver] Add -static-openmp driver option
Sep 6 2019
Sep 6 2019
Test -static, -static-openmp interaction. Added these only for iomp5 to avoid test-case explosion.
I'll update this review addressing @joerg's reply to cfe-commits:
Needs testing for the -static interaction?
In D67200#1660147, @srhines wrote:Looks really nice. I am sure the NDK developers will be happy to see support for static OpenMP. Do you want to add the public NDK github issue link in the commit message?
Mention NDK issue https://github.com/android-ndk/ndk/issues/1028.
Sep 5 2019
Sep 5 2019
Does this regress from existing behavior for unused argument warnings? Currently, -static-libstdc++ -nostdlib issues an unused argument warning for -static-libstdc++, while AFAICT -static=c++stdlib -nostdlib doesn't.
Sep 5 2019, 9:49 PM · Restricted Project
Change parameter name.
Supported this flag for NetBSD and FreeBSD as well.
Sep 4 2019
Sep 4 2019
Request commit access for pirama
Sep 4 2019, 2:06 PM · Restricted Project
Update/clean-up comments in the test.
Sep 4 2019, 2:04 PM · Restricted Project
Aug 28 2019
Aug 28 2019
pirama committed rG19205abaaa3e: [ValueMapper] NFC: Remove dead code to pause metadata mapping (authored by pirama).
[ValueMapper] NFC: Remove dead code to pause metadata mapping
[ValueMapper] NFC: Remove dead code to pause metadata mapping
Aug 28 2019, 10:42 AM · Restricted Project
Aug 27 2019
Aug 27 2019
Aug 27 2019, 8:42 PM · Restricted Project
Aug 27 2019, 7:14 PM · Restricted Project
Aug 27 2019, 2:28 PM · Restricted Project
Fix typo reffers -> refers
Aug 27 2019, 2:28 PM · Restricted Project
Aug 27 2019, 11:15 AM · Restricted Project
Aug 8 2019
Aug 8 2019
pirama committed rG0cb2a33dfd3e: [AArch64] Do not emit '#' before immediates in inline asm (authored by pirama).
[AArch64] Do not emit '#' before immediates in inline asm
[AArch64] Do not emit '#' before immediates in inline asm
Aug 8 2019, 10:50 AM · Restricted Project
Aug 6 2019
Aug 6 2019
Avoid extra variable
Aug 6 2019, 2:00 PM · Restricted Project
Thanks Peter. I'll wait for another day for further comments, and if none, will submit this tomorrow morning (pacific time).
Aug 6 2019, 9:16 AM · Restricted Project
Aug 5 2019
Aug 5 2019
In D65550#1610801, @efriedma wrote:This only affects inline asm, it looks like, not general instructions? (I looked briefly, and it looks like instructions go through AArch64InstPrinter::printOperand instead.)
I don't think this would cause any issues off the top of my head, but you might want to run something like an Android build to confirm that.
Aug 5 2019, 3:38 PM · Restricted Project
Aug 1 2019
Aug 1 2019
Thanks for the workaround @peter.smith. I suggested it to the NDK developer as well. The immediate need for this change is gone, but I agree that this is useful for the various reasons you outlined.
Aug 1 2019, 10:05 AM · Restricted Project
Jul 31 2019
Jul 31 2019
Jul 31 2019, 5:45 PM · Restricted Project
Jul 25 2019
Jul 25 2019
pirama committed rG6caa8da072d6: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX (authored by pirama).
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
Apply clang-format
Call strlen(gcov_prefix) only if its not null.
Remove stray new line.
Refactored the loop to call getenv just once.
LGTM for Android.
Jul 24 2019
Jul 24 2019
Jul 1 2019
Jul 1 2019
pirama added inline comments to D63889: Check possible warnings on global initializers for reachability.
Jul 1 2019, 10:30 AM · Restricted Project
Jun 25 2019
Jun 25 2019
pirama committed rG7803eac24f3e: [llvm-shlib] Do not use version script when building with MinGW (authored by pirama).
[llvm-shlib] Do not use version script when building with MinGW
[llvm-shlib] Do not use version script when building with MinGW
Jun 25 2019, 12:35 PM · Restricted Project
pirama retitled D63743: [llvm-shlib] Do not use version script when building with MinGW from [llvm-shlib] Do not use version script when building with MinGW and LLD to [llvm-shlib] Do not use version script when building with MinGW.
Jun 25 2019, 11:01 AM · Restricted Project
pirama updated the diff for D63743: [llvm-shlib] Do not use version script when building with MinGW.
Skip version script for all MinGW builds, not just when using lld.
Jun 25 2019, 11:01 AM · Restricted Project
Jun 24 2019
Jun 24 2019
In D63743#1556912, @mstorsjo wrote:I'd suggest skipping the lld condition, the version script adds no value here.
For ELF, version scripts do two things, select what symbols to export using glob pattetns, and set symbol versions on them.
As COFF doesn't have symbol versions, all it does on mingw with GNU ld, is filtering symbols, to export *. So it adds no value there.
Jun 24 2019, 10:40 PM · Restricted Project
Jun 24 2019, 3:56 PM · Restricted Project
Mar 27 2019
Mar 27 2019
Mar 27 2019, 4:44 PM · Restricted Project
Feb 20 2019
Feb 20 2019
Feb 13 2019
Feb 13 2019
Herald added a project to D56720: [MemorySSA] Add caching results of reaching LiveOnEntry MemoryDef to ClobberWalker: Restricted Project.
Feb 13 2019, 4:51 PM · Restricted Project
Feb 12 2019
Feb 12 2019
Jan 11 2019
Jan 11 2019
pirama committed rL350951: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion.
[Legalizer] Use correct ValueType of SELECT_CC node during Float promotion
Jan 10 2019
Jan 10 2019
Dec 18 2018
Dec 18 2018