Page MenuHomePhabricator
Feed Advanced Search

Today

bd1976llvm added a comment to D101890: [LLD] Improve --strip-all help text.

Can you file a bug for this?

Fri, May 7, 8:42 AM · Restricted Project

Yesterday

bd1976llvm updated subscribers of D101890: [LLD] Improve --strip-all help text.

@tstellar this is a very safe change and we did have a customer confused by this option. Would it be possible to put this change onto the 12 release branch? Thanks.

Thu, May 6, 4:40 AM · Restricted Project

Wed, May 5

bd1976llvm added inline comments to D101890: [LLD] Improve --strip-all help text.
Wed, May 5, 10:48 AM · Restricted Project
bd1976llvm updated the diff for D101890: [LLD] Improve --strip-all help text.

Conform to mandoc style.

Wed, May 5, 10:48 AM · Restricted Project
bd1976llvm updated the diff for D101890: [LLD] Improve --strip-all help text.

Thank @peter.smith. I have added the man page update.

Wed, May 5, 7:58 AM · Restricted Project
bd1976llvm requested review of D101890: [LLD] Improve --strip-all help text.
Wed, May 5, 3:52 AM · Restricted Project

Wed, Apr 21

bd1976llvm added a comment to D100944: [CodeGen][ELF] Emit separate unique sections for different flags.

Hi. Can you add some background information to the description. I assume the discussion on https://reviews.llvm.org/D93948 is relevant. Is there an associated bug?

Wed, Apr 21, 8:23 AM · Restricted Project

Mar 24 2021

bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

@compnerd, @smeenai do you have any further comments?

Mar 24 2021, 6:58 AM · Restricted Project

Mar 22 2021

bd1976llvm added a reviewer for D93203: [PS4] handle dllimport/export w.r.t vtables/rtti: mstorsjo.
Mar 22 2021, 4:48 AM · Restricted Project

Mar 15 2021

bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

ping.

Mar 15 2021, 6:24 PM · Restricted Project

Mar 12 2021

bd1976llvm updated the summary of D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.
Mar 12 2021, 3:04 AM · Restricted Project

Mar 8 2021

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Sorry for the delay here. This looks good; thank you!

Mar 8 2021, 3:52 PM · Restricted Project

Feb 17 2021

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

ping :)

Feb 17 2021, 5:59 AM · Restricted Project
bd1976llvm added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Feb 17 2021, 5:59 AM
bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

ping!

Feb 17 2021, 5:57 AM · Restricted Project
bd1976llvm added a comment to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.
Feb 17 2021, 5:56 AM · Restricted Project, Restricted Project

Feb 8 2021

bd1976llvm updated the summary of D95949: Remove unused CHECK of dllexport declaration.
Feb 8 2021, 8:58 AM
bd1976llvm updated the summary of D95949: Remove unused CHECK of dllexport declaration.
Feb 8 2021, 8:39 AM

Feb 3 2021

bd1976llvm requested review of D95949: Remove unused CHECK of dllexport declaration.
Feb 3 2021, 5:59 AM

Feb 1 2021

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

@mstorsjo are you happy with this now?

Feb 1 2021, 6:07 PM · Restricted Project
bd1976llvm updated the diff for D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Added the cmake defines from https://reviews.llvm.org/D90021 for the libcxxabi build.

Feb 1 2021, 6:06 PM · Restricted Project
bd1976llvm added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Feb 1 2021, 5:53 PM

Jan 29 2021

bd1976llvm added a comment to D83069: [LIT] error if directly named test won't be run indirectly.

Hi @bd1976llvm

I've just realized in many projects I'm involved in testsuites are managed by cmake and lit is only ever invoked on single testcase. Without passing --no-indirectly-run-check tests fail but when using an old lit I get an error if using this option. Can we allow to turn off the feature via environment variable or configuration?

Thanks in advance.

Jan 29 2021, 8:22 AM · Restricted Project

Jan 22 2021

bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

I have added this patch to https://reviews.llvm.org/D88124 along with some end to end tests to show the scei vendor windows-itanium behaviour. From the 'wi-test/test/dll_vtable_missing/test.py' test you can see that the link error given by the scei vendor variant is more consistent than the standard windows-itanium. Both variants should be equivalent in terms of runtime behaviour.

Jan 22 2021, 5:10 PM · Restricted Project
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Added the patch from https://reviews.llvm.org/D93203 and the scei vendor variant of windows itanium to the relevant tests.

Jan 22 2021, 3:42 PM
bd1976llvm added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Jan 22 2021, 3:40 PM
bd1976llvm added a reviewer for D93203: [PS4] handle dllimport/export w.r.t vtables/rtti: smeenai.
Jan 22 2021, 7:52 AM · Restricted Project
bd1976llvm updated the diff for D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

Thanks for the suggestions. I have reworded the comments so that they are hopefully much clearer.

Jan 22 2021, 7:46 AM · Restricted Project
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

rebased build script and some minor improvements.

Jan 22 2021, 4:01 AM
bd1976llvm added a comment to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Thanks for your comments. I tried to do a rebase right up to the head of main - but it proved very difficult to resolve all the problems this caused. Instead I have rebased to your https://github.com/llvm/llvm-project/commit/8a73aa8c4c3ee82e7d650c6a957937713a4a9ab4

Jan 22 2021, 3:58 AM

Jan 7 2021

bd1976llvm added a comment to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

@mstorsjo I'm looking at this again after the winter break. Do you have any further comments?

Jan 7 2021, 3:59 AM

Dec 14 2020

bd1976llvm added inline comments to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.
Dec 14 2020, 6:15 PM · Restricted Project
bd1976llvm requested review of D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.
Dec 14 2020, 3:59 AM · Restricted Project

Dec 9 2020

bd1976llvm updated the diff for D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Removed COMDAT limitation text.

Dec 9 2020, 5:46 PM · Restricted Project

Dec 7 2020

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

@compnerd @smeenai are you basically happy with this doc now?

Dec 7 2020, 5:18 PM · Restricted Project

Nov 26 2020

bd1976llvm added inline comments to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.
Nov 26 2020, 3:59 AM · Restricted Project, Restricted Project
bd1976llvm updated the diff for D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Addressed review comments.

Nov 26 2020, 3:59 AM · Restricted Project, Restricted Project

Nov 25 2020

bd1976llvm added inline comments to D89518: [windows-itanium] Add Windows Itanium How-To Guide.
Nov 25 2020, 9:08 AM · Restricted Project
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Added type_info tests.

Nov 25 2020, 8:46 AM

Nov 24 2020

bd1976llvm updated the diff for D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Updated comment to state that "semantic compatibility" is the goal.

Nov 24 2020, 5:00 PM · Restricted Project, Restricted Project
bd1976llvm added a comment to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Thanks for the comments. I have updated the diff.

Nov 24 2020, 4:56 PM · Restricted Project, Restricted Project

Nov 20 2020

bd1976llvm updated the diff for D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.

Fixed spelling errors.

Nov 20 2020, 2:23 PM · Restricted Project
bd1976llvm updated the diff for D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.

Improved comment.

Nov 20 2020, 2:20 PM · Restricted Project

Nov 19 2020

bd1976llvm added a comment to D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.

Im not sure if renaming the check prefix is actually helpful, but sure. This does seem like somewhat unfortunate. For the dllexport case, you really want dso_local. define dso_local global and declare dso_local global are preferable in this case as that guarantees a local definition, which is always the case for an exported symbol. You definitely do not want declare extern dso_local global. A few of the changes here are actually changing the IRGen from the desired state, is that intentional?

Nov 19 2020, 3:14 PM · Restricted Project
bd1976llvm requested review of D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.
Nov 19 2020, 3:26 AM · Restricted Project

Nov 18 2020

bd1976llvm added a comment to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Let me know if you think that more tests need adding. I have added support for LIT based run tests to the build recipe (https://reviews.llvm.org/D88124) I can use this to add any run tests that might be useful for this review.

Nov 18 2020, 5:18 AM · Restricted Project, Restricted Project
bd1976llvm added inline comments to D89518: [windows-itanium] Add Windows Itanium How-To Guide.
Nov 18 2020, 5:12 AM · Restricted Project

Nov 17 2020

bd1976llvm added inline comments to D89518: [windows-itanium] Add Windows Itanium How-To Guide.
Nov 17 2020, 3:59 AM · Restricted Project
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Added LIT based tests.

Nov 17 2020, 3:54 AM

Nov 13 2020

bd1976llvm requested review of D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

I think this needs a re-review as I have deviated from the original simple approach.

Nov 13 2020, 3:19 AM · Restricted Project, Restricted Project

Nov 11 2020

bd1976llvm added a comment to D88348: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures.

Will this land soon? We are eagerly anticipating its arrival :)

Nov 11 2020, 6:00 AM · Restricted Project, lld
bd1976llvm updated the diff for D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Updated the diff following helpful review comments.

Nov 11 2020, 5:58 AM · Restricted Project
bd1976llvm added inline comments to D89518: [windows-itanium] Add Windows Itanium How-To Guide.
Nov 11 2020, 5:53 AM · Restricted Project

Nov 5 2020

bd1976llvm updated the diff for D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Add tests and prevent SemaTemplate and ItaniumCXXABI code paths from executing for PS4 (for now).

Nov 5 2020, 4:12 PM · Restricted Project, Restricted Project

Nov 2 2020

bd1976llvm added inline comments to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.
Nov 2 2020, 4:15 PM · Restricted Project, Restricted Project
bd1976llvm updated the diff for D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Addressed review comments.

Nov 2 2020, 4:14 PM · Restricted Project, Restricted Project
bd1976llvm added inline comments to D90442: [PS4] Support dllimport/export attributes.
Nov 2 2020, 3:48 AM · Restricted Project, Restricted Project
bd1976llvm updated the diff for D90442: [PS4] Support dllimport/export attributes.

Fixed indentation.

Nov 2 2020, 3:45 AM · Restricted Project, Restricted Project

Oct 29 2020

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Hi @mstorsjo - I have been a bit short of time recently; but, I am going to look into everything that you have pointed out here. I should be able to make a reply by Monday.

Oct 29 2020, 8:41 PM · Restricted Project
bd1976llvm requested review of D90442: [PS4] Support dllimport/export attributes.
Oct 29 2020, 8:31 PM · Restricted Project, Restricted Project
bd1976llvm added a comment to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.
In D90299#2362895, @rnk wrote:

I agree, the name could be improved. For prior art, see /Zc:dllexportInlines-, which disables some (but not all) of the dllexport/import semantics in clang-cl.

What we are really talking about here is what should be done when importing or exporting C++ constructs with vague linkage (inline functions, templates). That's what all the affected code has in common. Clang doesn't often use the terminology of vague linkage, so maybe it would be better to use the name comdat somehow.

How about TargetInfo::shouldDLLImportComdatSymbols? You could add in "export" (shouldDLLImportExportComdatSymbols), but GCC also exports comdat things sometimes, and in the cases where this predicate controls export behavior, it's pretty clear that it needs to be done to support the side which would import the symbol (explicit template instantiations).

Oct 29 2020, 8:03 PM · Restricted Project, Restricted Project
bd1976llvm added inline comments to D89970: Add the ability to map DLL storage class to visibility.
Oct 29 2020, 8:01 PM · Restricted Project
bd1976llvm updated the diff for D89970: Add the ability to map DLL storage class to visibility.

Addressed the review comments and made some minor improvements.

Oct 29 2020, 8:00 PM · Restricted Project
bd1976llvm added a reviewer for D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4: smeenai.
Oct 29 2020, 1:08 AM · Restricted Project, Restricted Project

Oct 28 2020

bd1976llvm requested review of D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.
Oct 28 2020, 4:46 AM · Restricted Project, Restricted Project

Oct 23 2020

bd1976llvm updated the diff for D89970: Add the ability to map DLL storage class to visibility.

addressed review comments and made some other improvements:

Oct 23 2020, 6:01 PM · Restricted Project
bd1976llvm added inline comments to D89970: Add the ability to map DLL storage class to visibility.
Oct 23 2020, 5:59 PM · Restricted Project

Oct 22 2020

bd1976llvm requested review of D89970: Add the ability to map DLL storage class to visibility.
Oct 22 2020, 9:34 AM · Restricted Project
bd1976llvm added inline comments to D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 22 2020, 9:15 AM · Restricted Project, lld
bd1976llvm added inline comments to D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 22 2020, 8:39 AM · Restricted Project, lld

Oct 20 2020

bd1976llvm added inline comments to D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 20 2020, 2:54 PM · Restricted Project, lld
bd1976llvm added a comment to D88877: [ELF] Drop --whole-archive before processing dependent libraries..

Hmm, that starts looking like a discussion for the mailing list, but I guess that all interested people are already here and the conversation will be better preserved for further references if being linked to the review.

Unfortunately, sometimes that is not that simple as it sounds. In our case, the users who need autolinking are different from a unit that provides tools to adjust command lines. There is no option to add anything at the very end.

Thanks for supplying this detail. To me this sounds like you need to file a bug against the tools unit? I want to evaluate your proposal on it's own merits rather accepting it to work around problems caused by other tools.

And for the tool unit folks that looks like an issue in the linker. Why should they work around problems caused by the linker? Why not fix them in the source? After all, build systems are many and reasoning for fixing them is vague. Closing "--whole-archive" range is more like tidiness, which was not that strictly required before (or without) the autolinking feature.

Oct 20 2020, 2:46 PM · Restricted Project, lld
bd1976llvm added a comment to D89099: [lld][ELF] Rewrite ICF-folded references rather than tombstoning them.

Apologies that I haven't had much time to look into this. I tried this style of patching with Sony's proprietary debugger and the user experience w.r.t. source locations and setting breakpoints was degraded. When I find time I will try to determine what is theoretically best here and whether the degradation in the debugging experience that I saw is an artefact of our proprietary debuggers implementation or if it points to something important. We should try with other consumers as well.

Oct 20 2020, 10:41 AM · Restricted Project

Oct 19 2020

bd1976llvm added a comment to D83069: [LIT] error if directly named test won't be run indirectly.

LGTM but I'm not familiar with lit to tell whether there would be a more idiomatic way to write this. I also agree with the assumption that invoking lit with a large number of tests arguments rather than a directory is unlikely.

Oct 19 2020, 4:44 PM · Restricted Project
bd1976llvm updated the diff for D83069: [LIT] error if directly named test won't be run indirectly.

Removed check for error message not being emitted.

Oct 19 2020, 4:42 PM · Restricted Project
bd1976llvm added inline comments to D83069: [LIT] error if directly named test won't be run indirectly.
Oct 19 2020, 4:41 PM · Restricted Project
bd1976llvm updated the summary of D83069: [LIT] error if directly named test won't be run indirectly.
Oct 19 2020, 4:51 AM · Restricted Project
bd1976llvm retitled D83069: [LIT] error if directly named test won't be run indirectly from [lit] warn if explicitly specified test won't be run indirectly to [LIT] error if directly named test won't be run indirectly.
Oct 19 2020, 4:45 AM · Restricted Project

Oct 15 2020

bd1976llvm requested review of D89518: [windows-itanium] Add Windows Itanium How-To Guide.
Oct 15 2020, 5:33 PM · Restricted Project
bd1976llvm added a comment to D88877: [ELF] Drop --whole-archive before processing dependent libraries..

Firstly, is this a real problem?

The problem is real. We have a report from our customer, so the issue is already observed in the wild.

In the RFC thread http://lists.llvm.org/pipermail/llvm-dev/2019-March/131105.html Rui said:

Then they can specify --no-whole-archive on the end of the command line, no?

Unfortunately, sometimes that is not that simple as it sounds. In our case, the users who need autolinking are different from a unit that provides tools to adjust command lines. There is no option to add anything at the very end.

Oct 15 2020, 10:10 AM · Restricted Project, lld

Oct 14 2020

bd1976llvm added a comment to D88877: [ELF] Drop --whole-archive before processing dependent libraries..
  • Simplified the comment.

Even if that was not decided in the discussion, I am pretty sure that --whole-archive cannot be used with dependent libraries, at least as the feature is implemented currently. The whole idea of the feature is that you can place #pragma comment(lib,...) in each and every source file which depends on the library. This results in multiple references to the library from many input object files, and if --whole-archive is active, this leads the linker to fail with the "duplicate symbol" error.

Oct 14 2020, 6:11 PM · Restricted Project, lld

Oct 13 2020

bd1976llvm updated the diff for D83069: [LIT] error if directly named test won't be run indirectly.

Improvements:

  • Error rather than warn - lit tests are regression tests!
  • Add option to supress check (there is no performance cost if this option is specified).
  • Standardized on the terms "direct" and "indirect" in comments and diagnostics.
  • Added missing test file.
Oct 13 2020, 11:01 AM · Restricted Project

Oct 9 2020

bd1976llvm added a comment to D89099: [lld][ELF] Rewrite ICF-folded references rather than tombstoning them.

I plan to investigate this further after the weekend; but, I wanted to say that the current scheme is known to be compatible with gdb and with Sony's proprietary debugger and yields a reasonable, if not ideal, debugging experience.

Oct 9 2020, 12:05 PM · Restricted Project

Sep 28 2020

bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Use lld's mingw autolinking feature. Add a testcase that will fail without this.

Sep 28 2020, 5:12 PM
bd1976llvm added a comment to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Sep 28 2020, 5:09 PM

Sep 24 2020

bd1976llvm added a comment to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Hi mstorsjo, thanks for looking at this. Please add anyone else to this review that might be interested.

Sep 24 2020, 5:44 PM
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

CMAKE improvements.

Sep 24 2020, 5:08 PM

Sep 23 2020

bd1976llvm updated the summary of D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Sep 23 2020, 7:54 AM
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Removed the code patch and --patch functionality. These are not needed given that this review *is* a patch and having a patch in a patch is confusing.

Sep 23 2020, 7:50 AM
bd1976llvm added a comment to D83069: [LIT] error if directly named test won't be run indirectly.

ping!

Sep 23 2020, 5:40 AM · Restricted Project

Sep 22 2020

bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Sep 22 2020, 5:34 PM
bd1976llvm requested review of D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Sep 22 2020, 5:21 PM

Sep 16 2020

bd1976llvm added a comment to D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals.

@hans, I think that we should put this change onto the release branch for llvm11.

I'm not familiar with the details of this patch, can you explain why we should merge it to llvm11?

We're very late in the release process, so unless it's fixing some major problem, I would be hesitant to merge.

Sep 16 2020, 7:28 AM · Restricted Project

Sep 15 2020

bd1976llvm updated subscribers of D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals.

@hans, I think that we should put this change onto the release branch for llvm11.

Sep 15 2020, 1:28 AM · Restricted Project

Aug 28 2020

bd1976llvm requested review of D86828: [windows-itanium] make dllimport/export handling closer to MS behavior.
Aug 28 2020, 6:35 PM · Restricted Project

Aug 27 2020

bd1976llvm added a comment to D83069: [LIT] error if directly named test won't be run indirectly.

ping!

Aug 27 2020, 3:49 AM · Restricted Project

Aug 25 2020

bd1976llvm added a comment to D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals.

tl;dr This is a longstanding GNU ld bug introduced in binutils 2.26

% cat a.c
__attribute__((visibility("protected"))) void * foo (void) { return (void *)foo; }
% gcc -fpic a.c -shared -fuse-ld=bfd # relocation R_X86_64_PC32 against protected symbol `foo' can not be used when making a shared object

clang does not behave worse than GCC+GNU ld, so there is no regression on our side.

Aug 25 2020, 1:37 PM · Restricted Project
bd1976llvm added a comment to D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals.

I think this introduces an old issue when lowering the instruction.

Aug 25 2020, 8:48 AM · Restricted Project

Aug 14 2020

bd1976llvm added a comment to D83069: [LIT] error if directly named test won't be run indirectly.

ping!

Aug 14 2020, 3:55 AM · Restricted Project

Aug 12 2020

bd1976llvm added a comment to D85782: [X86][ELF] Prefer lowering MC_GlobalAddress operands to .Lfoo$local only for STV_DEFAULT globals.

GNU now recommends -fvisiblity=hidden (https://gcc.gnu.org/wiki/Visibility) so my understanding is that there will be very few STV_DEFAULT symbols.

I am not very sure this is now recommended but is indeed a non-rare configuration we should care about.

Agreed. Recommended is probably too strong.

Aug 12 2020, 9:05 AM · Restricted Project