Page MenuHomePhabricator
Feed Advanced Search

Today

dim added inline comments to D70143: Check result of emitStrLen before passing it to CreateGEP.
Wed, Nov 13, 6:53 AM · Restricted Project, Restricted Project

Yesterday

dim added a comment to D56398: Add new EINTEGRITY errno.

cem == dim?

Tue, Nov 12, 2:03 PM
dim added a comment to D70143: Check result of emitStrLen before passing it to CreateGEP.

This should have a llvm ir test in llvm/test/transforms/instcombine i think, not a clang test.

Tue, Nov 12, 2:03 PM · Restricted Project, Restricted Project
dim created D70143: Check result of emitStrLen before passing it to CreateGEP.
Tue, Nov 12, 1:34 PM · Restricted Project, Restricted Project
dim accepted D70110: [Driver][FreeBSD] Enable unwind tables on !amd64.

LGTM

Tue, Nov 12, 10:09 AM · Restricted Project

Fri, Nov 8

dim added a comment to D56398: Add new EINTEGRITY errno.

Another attempt to grab your attention :)

Fri, Nov 8, 10:35 AM

Tue, Oct 29

dim added a comment to D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3).

Hm, I would really say that __isnan and the other __ prefixed functions are Linuxisms, or more accurately, glibc-isms. They also don't exist on e.g. macOS:

Tue, Oct 29, 10:17 AM · Restricted Project
dim added a comment to D56398: Add new EINTEGRITY errno.

Ping :)

Tue, Oct 29, 6:06 AM

Mon, Oct 21

dim added a comment to D56398: Add new EINTEGRITY errno.

N.B., EOWNERDEAD and ENOTRECOVERABLE are already defined on lines 158 and line 170, respectively.

Mon, Oct 21, 12:39 PM
dim updated the diff for D56398: Add new EINTEGRITY errno.

Get rid of the ELAST trickery, which is hard to maintain, and does not
appear to serve any purpose. There is no mention of ELAST in the C or
C++ standards, as far as I know.

Mon, Oct 21, 11:43 AM
dim added a comment to D56398: Add new EINTEGRITY errno.

Now that I'm reading this header again, why do we even bother to define ELAST at all? On Linux, there is no such thing, while on BSDs and macOS, it is already provided by the regular errno.h.

Mon, Oct 21, 11:33 AM

Sat, Oct 19

dim committed rGd5367db95c42: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD (authored by dim).
Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
Sat, Oct 19, 3:59 AM
dim committed rL375340: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
Sat, Oct 19, 3:59 AM
dim closed D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Sat, Oct 19, 3:58 AM · Restricted Project

Fri, Oct 18

dim updated the diff for D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.

Rewrite the __FreeBSD_version condition to be more straightforward.

Fri, Oct 18, 12:49 PM · Restricted Project
dim added inline comments to D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Fri, Oct 18, 12:40 PM · Restricted Project
dim created D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Fri, Oct 18, 8:47 AM · Restricted Project
dim abandoned D47987: Provide only one declaration of __throw_runtime_error.

Obsoleted by D58425 (and rCXX354515).

Fri, Oct 18, 2:52 AM

Oct 10 2019

dim committed rGa42942e0ecd6: Fix process launch failure on FreeBSD after r365761 (authored by dim).
Fix process launch failure on FreeBSD after r365761
Oct 10 2019, 1:27 PM
dim closed D68723: Fix process launch failure on FreeBSD after r365761.
Oct 10 2019, 1:27 PM · Restricted Project
dim committed rL374444: Fix process launch failure on FreeBSD after r365761.
Fix process launch failure on FreeBSD after r365761
Oct 10 2019, 1:26 PM
dim updated the diff for D68723: Fix process launch failure on FreeBSD after r365761.

Convert m_(monitor|operation)_thread to llvm::Optional<>.

Oct 10 2019, 12:30 PM · Restricted Project

Oct 9 2019

dim created D68723: Fix process launch failure on FreeBSD after r365761.
Oct 9 2019, 1:10 PM · Restricted Project
dim added a comment to D68723: Fix process launch failure on FreeBSD after r365761.
Oct 9 2019, 1:10 PM · Restricted Project
dim added a comment to rL365761: [LLDB] Fix FreeBSD build..

@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:

Expected<T> must be checked before access or destruction.
Expected<T> value was in success state. (Note: Expected<T> values in success mode must still be checked prior to being destroyed).
Oct 9 2019, 11:54 AM
dim updated subscribers of rL365761: [LLDB] Fix FreeBSD build..

@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:

Oct 9 2019, 11:54 AM

Oct 8 2019

dim closed D68045: [builtins] Unbreak build on FreeBSD armv7 after D60351.

For some reason this didn't get closed by Phabricator. Committed in rCRT374070.

Oct 8 2019, 9:58 AM · Restricted Project, Restricted Project
dim added a comment to rL372886: [DAGCombiner] add one-use restriction to vector transform with cheap extract.

@spatel, you mentioned this should be in 9.0.1, with "A noticeable perf regression for x86 vector code made it into the 9.0 release". Does it have a lot of influence on compile-time performance, or run-time performance? (I'd like to pull this one into FreeBSD's clang 9.0.)

Oct 8 2019, 12:29 AM

Oct 2 2019

dim updated subscribers of D68269: [libc++abi] Do not define new/delete by default.

Pinging vendors for awareness of the change: @phosek @danalbert @dim

This is going in soon and will require a change in how you build libc++abi if you need new/delete definitions to be provided in libc++abi.so, namely to use -DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=ON when you configure CMake for libc++abi.

The upshot of this change is that by default, we won't get both definitions in libc++ and libc++abi, thus unbreaking the default configuration.

Oct 2 2019, 2:34 PM · Restricted Project

Sep 26 2019

dim added a comment to D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.

LGTM from a FreeBSD point of view. :)

Sep 26 2019, 10:28 AM · Restricted Project

Sep 25 2019

dim added a comment to D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper.

This works for me, and also for the original test case from https://bugs.freebsd.org/240764.

Sep 25 2019, 2:20 AM · Restricted Project

Sep 18 2019

dim committed rGab8b456ce5d8: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim).
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 2:05 PM
dim committed rGf88e75525d25: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim).
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:58 PM
dim committed rL372261: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:57 PM
dim closed D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 18 2019, 1:57 PM · Restricted Project, Restricted Project
dim committed rL372260: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:57 PM
dim closed D67118: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 18 2019, 1:57 PM · Restricted Project

Sep 10 2019

dim added a comment to rL363529: Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also….

Third time's the charm.

Sep 10 2019, 12:37 PM

Sep 7 2019

dim committed rG5bd4a4806aaf: Remove ::gets for FreeBSD 13 and later (authored by dim).
Remove ::gets for FreeBSD 13 and later
Sep 7 2019, 3:18 PM
dim committed rL371324: Remove ::gets for FreeBSD 13 and later.
Remove ::gets for FreeBSD 13 and later
Sep 7 2019, 3:17 PM
dim closed D67316: Remove ::gets for FreeBSD 13 and later.
Sep 7 2019, 3:17 PM · Restricted Project
dim updated the diff for D67316: Remove ::gets for FreeBSD 13 and later.

Add _LIBCPP_C_HAS_NO_GETS macro to <__config>, and use that in <cstdio>.

Sep 7 2019, 8:20 AM · Restricted Project
dim created D67316: Remove ::gets for FreeBSD 13 and later.
Sep 7 2019, 5:13 AM · Restricted Project

Sep 4 2019

dim accepted D35034: compiler-rt: use fp_t instead of long double, for consistency.

Still OK with me :)

Sep 4 2019, 10:59 PM · Restricted Project

Sep 3 2019

dim created D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 3 2019, 11:17 AM · Restricted Project, Restricted Project
dim created D67118: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 3 2019, 11:15 AM · Restricted Project
dim accepted D66760: clang: default to DWARF 4 for FreeBSD 12.0 and later.

LGTM

Sep 3 2019, 9:06 AM · Restricted Project

Aug 30 2019

dim committed rL370542: Request commit access for dim.
Request commit access for dim
Aug 30 2019, 3:37 PM
dim committed rL370541: Remove mixed newlines, set svn:eol-style and svn:mime-type to prevent further….
Remove mixed newlines, set svn:eol-style and svn:mime-type to prevent further…
Aug 30 2019, 3:32 PM

Aug 28 2019

dim accepted D66758: compiler-rt: all FreeBSD CPU archs except i386 use 64-bit time_t.
Aug 28 2019, 12:10 PM · Restricted Project

Aug 22 2019

dim accepted D66582: [Sanitizer] checks ASLR on FreeBSD.

LGTM. Maybe nice to merge it to 9.0 after a day or two.

Aug 22 2019, 10:50 AM · Restricted Project, Restricted Project

Aug 10 2019

dim committed rGc09d88863284: Add support for FreeBSD's LD_32_LIBRARY_PATH (authored by dim).
Add support for FreeBSD's LD_32_LIBRARY_PATH
Aug 10 2019, 12:08 PM
dim committed rL368516: Add support for FreeBSD's LD_32_LIBRARY_PATH.
Add support for FreeBSD's LD_32_LIBRARY_PATH
Aug 10 2019, 12:07 PM
dim closed D65772: Add support for FreeBSD's LD_32_LIBRARY_PATH.
Aug 10 2019, 12:07 PM · Restricted Project, Restricted Project

Aug 5 2019

dim created D65772: Add support for FreeBSD's LD_32_LIBRARY_PATH.
Aug 5 2019, 1:21 PM · Restricted Project, Restricted Project

Jul 28 2019

dim added inline comments to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 28 2019, 3:00 AM · Restricted Project, Restricted Project

Jul 24 2019

dim added a comment to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

Is any test was broken?

Jul 24 2019, 11:11 PM · Restricted Project, Restricted Project
dim added a comment to D55596: Reimplement Thread Static Data ASan routines with TLS.
In D55596#1599456, @dim wrote:

This broke ASAN on FreeBSD (same for the MSAN change). When loading static thread_local struct tsd_key key this is done using __tls_get_addr. The interceptor for __tls_get_addr then calls GetCurrentThread which calls AsanTSDGet which again calls __tls_get_addr.
If I remove the || SANITIZER_FREEBSD it works fine (at least on FreeBSD 11.2).

Yes indeed, this is https://bugs.llvm.org/show_bug.cgi?id=40761. I'm unsure what a good solution direction is.

I just spent some time debugging and it seems like https://reviews.llvm.org/D55596 works.

Jul 24 2019, 10:51 AM · Restricted Project, Restricted Project
dim added a comment to D55596: Reimplement Thread Static Data ASan routines with TLS.

This broke ASAN on FreeBSD (same for the MSAN change). When loading static thread_local struct tsd_key key this is done using __tls_get_addr. The interceptor for __tls_get_addr then calls GetCurrentThread which calls AsanTSDGet which again calls __tls_get_addr.
If I remove the || SANITIZER_FREEBSD it works fine (at least on FreeBSD 11.2).

Jul 24 2019, 9:51 AM · Restricted Project, Restricted Project

Jul 9 2019

dim committed rG19a71f6bdf2d: Merging r360861, with an additional change to also add the PPC64_OPD1 and… (authored by dim).
Merging r360861, with an additional change to also add the PPC64_OPD1 and…
Jul 9 2019, 12:26 PM
dim committed rL365542: Merging r360861, with an additional change to also add the PPC64_OPD1.
Merging r360861, with an additional change to also add the PPC64_OPD1
Jul 9 2019, 12:25 PM
dim committed rG635f8ffdbd7b: Revert merge of r360861: (authored by dim).
Revert merge of r360861:
Jul 9 2019, 12:18 PM
dim committed rL365539: Revert merge of r360861:.
Revert merge of r360861:
Jul 9 2019, 12:18 PM

Jun 23 2019

dim added a comment to D63686: [LFTR] Fix post-inc pointer IV with truncated exit count (PR41998).

FWIW, the original test case with pre-increment is fixed by this, e.g.:

Jun 23 2019, 2:23 PM · Restricted Project

Jun 15 2019

dim abandoned D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

No longer needed after rC362328 and follow-ups.

Jun 15 2019, 2:07 PM · Restricted Project

Jun 4 2019

dim created D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.
Jun 4 2019, 12:48 PM · Restricted Project

May 13 2019

dim added a comment to D60748: Fix i386 struct and union parameter alignment.

In fact, it is probably better to turn the OS check around, e.g. *only* increase the alignment for Linux, and nowhere else.

May 13 2019, 4:01 AM · Restricted Project
dim updated subscribers of D60748: Fix i386 struct and union parameter alignment.

Please also exclude FreeBSD from these changes, since we care a lot about backwards compatibility, and specifically about alignment requirements. (We have run into many issues in our ports collection where upstream assumes everything is 16-byte aligned on i386, which is *NOT* ABI compliant.)

May 13 2019, 3:57 AM · Restricted Project

May 6 2019

dim added a comment to D60427: [ARM] Glue register copies to tail calls..

@efriedma any more work to be done on this? :)

May 6 2019, 11:07 AM · Restricted Project
dim committed rG181aff63fb14: Add non-SSE wrapper for __kmp_{load,store}_mxcsr (authored by dim).
Add non-SSE wrapper for __kmp_{load,store}_mxcsr
May 6 2019, 10:58 AM
dim committed rL360062: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
Add non-SSE wrapper for __kmp_{load,store}_mxcsr
May 6 2019, 10:58 AM
dim committed rOMP360062: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
Add non-SSE wrapper for __kmp_{load,store}_mxcsr
May 6 2019, 10:58 AM
dim closed D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
May 6 2019, 10:57 AM · Restricted Project

May 4 2019

dim added a comment to D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.

So does this look better now?

May 4 2019, 5:58 AM · Restricted Project

May 1 2019

dim updated the diff for D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.

Address review comments:

  • Assign zero to pointed-to value in __kmp_store_mxcsr()
  • Use SSE specific stuff in KMP_OS_UNIX part only
May 1 2019, 12:53 PM · Restricted Project
dim committed rG147ce2334c96: Enable OpenMP build for 32-bit FreeBSD (authored by dim).
Enable OpenMP build for 32-bit FreeBSD
May 1 2019, 12:33 PM
dim committed rL359716: Enable OpenMP build for 32-bit FreeBSD.
Enable OpenMP build for 32-bit FreeBSD
May 1 2019, 12:32 PM
dim committed rOMP359716: Enable OpenMP build for 32-bit FreeBSD.
Enable OpenMP build for 32-bit FreeBSD
May 1 2019, 12:32 PM
dim closed D60917: Enable OpenMP build for 32-bit FreeBSD.
May 1 2019, 12:32 PM · Restricted Project
dim added a comment to D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.

Does the code that uses __kmp_load_mxcsr expect the pointed-to value to be initialized?

May 1 2019, 6:54 AM · Restricted Project
dim added a comment to D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.

Ping :)

May 1 2019, 4:09 AM · Restricted Project

Apr 22 2019

dim committed rG87e7f895bb2c: Use correct way to test for MIPS arch after rOMP355687 (authored by dim).
Use correct way to test for MIPS arch after rOMP355687
Apr 22 2019, 12:21 PM
dim committed rL358911: Use correct way to test for MIPS arch after rOMP355687.
Use correct way to test for MIPS arch after rOMP355687
Apr 22 2019, 12:19 PM
dim committed rOMP358911: Use correct way to test for MIPS arch after rOMP355687.
Use correct way to test for MIPS arch after rOMP355687
Apr 22 2019, 12:18 PM
dim closed D60938: Use correct way to test for MIPS arch after rOMP355687.
Apr 22 2019, 12:18 PM · Restricted Project

Apr 20 2019

dim created D60938: Use correct way to test for MIPS arch after rOMP355687.
Apr 20 2019, 1:00 PM · Restricted Project

Apr 19 2019

dim created D60917: Enable OpenMP build for 32-bit FreeBSD.
Apr 19 2019, 1:34 PM · Restricted Project
dim created D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
Apr 19 2019, 1:28 PM · Restricted Project

Apr 9 2019

dim added a comment to D60427: [ARM] Glue register copies to tail calls..

I can confirm this fixes both the minimized test case from https://bugs.llvm.org/show_bug.cgi?id=41417, and the full original test case from https://bugs.freebsd.org/237074.

Apr 9 2019, 2:15 PM · Restricted Project

Apr 5 2019

dim committed rG8f2d1eb9e887: After rL357618, quote ${CMAKE_THREAD_LIBS_INIT} so CMake does not complain when… (authored by dim).
After rL357618, quote ${CMAKE_THREAD_LIBS_INIT} so CMake does not complain when…
Apr 5 2019, 3:19 PM
dim committed rOMP357828: After rL357618, quote ${CMAKE_THREAD_LIBS_INIT} so CMake does not.
After rL357618, quote ${CMAKE_THREAD_LIBS_INIT} so CMake does not
Apr 5 2019, 3:19 PM
dim committed rL357828: After rL357618, quote ${CMAKE_THREAD_LIBS_INIT} so CMake does not.
After rL357618, quote ${CMAKE_THREAD_LIBS_INIT} so CMake does not
Apr 5 2019, 3:19 PM

Apr 3 2019

dim committed rOMP357618: Ensure correct pthread flags and libraries are used.
Ensure correct pthread flags and libraries are used
Apr 3 2019, 11:54 AM
dim committed rG956168c8029b: Ensure correct pthread flags and libraries are used (authored by dim).
Ensure correct pthread flags and libraries are used
Apr 3 2019, 11:14 AM
dim committed rL357618: Ensure correct pthread flags and libraries are used.
Ensure correct pthread flags and libraries are used
Apr 3 2019, 11:10 AM
dim closed D59451: Fix gettid warnings and one test on FreeBSD.
Apr 3 2019, 11:10 AM · Restricted Project, Restricted Project

Apr 2 2019

dim updated the diff for D59451: Fix gettid warnings and one test on FreeBSD.
  • Only set OPENMP_TEST_COMPILER_OPENMP_FLAGS once.
  • For standalone builds, call find_package(Threads) and use the result unconditionally.
  • Fix else -> else().
Apr 2 2019, 12:34 PM · Restricted Project, Restricted Project

Apr 1 2019

dim added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

So, any thoughts on the current state of the review?

Apr 1 2019, 10:41 AM · Restricted Project, Restricted Project

Mar 25 2019

dim committed rGa70da7f29f9d: Fix interoperability test compilation on FreeBSD (authored by dim).
Fix interoperability test compilation on FreeBSD
Mar 25 2019, 11:37 AM
dim committed rGdab9ed87c6c5: Fix gettid warnings on FreeBSD (authored by dim).
Fix gettid warnings on FreeBSD
Mar 25 2019, 11:37 AM