Page MenuHomePhabricator
Feed Advanced Search

Oct 9 2020

bogser01 updated the diff for D88314: Added llvm-string-referencing check.

Rebase diff

Oct 9 2020, 3:55 PM · Restricted Project
bogser01 added a comment to D88314: Added llvm-string-referencing check.

@aaron.ballman Thank you for picking up this review! Running the check over the entire LLVM causes ~74K warnings across 430 files. As to the false positive rate it's tricky to measure. Based on previous analysis on flang codebase, I would say roughly 50% of the fixes would cause compiler errors when applied.

Oct 9 2020, 3:30 PM · Restricted Project
bogser01 updated the diff for D88314: Added llvm-string-referencing check.

Added documentation & Nit fixes

Oct 9 2020, 8:54 AM · Restricted Project

Oct 7 2020

bogser01 added reviewers for D88314: Added llvm-string-referencing check: aaron.ballman, gribozavr.
Oct 7 2020, 5:42 AM · Restricted Project

Oct 2 2020

bogser01 added a comment to D88314: Added llvm-string-referencing check.

@alexfh does this look alright?

Oct 2 2020, 6:53 AM · Restricted Project
bogser01 updated the diff for D88314: Added llvm-string-referencing check.

Remove conflict markers 2

Oct 2 2020, 6:11 AM · Restricted Project
bogser01 updated the diff for D88314: Added llvm-string-referencing check.

Removed residual conflict markers

Oct 2 2020, 6:08 AM · Restricted Project

Oct 1 2020

bogser01 updated the diff for D88314: Added llvm-string-referencing check.

Fixed unit test 2

Oct 1 2020, 8:09 AM · Restricted Project
bogser01 updated the diff for D88314: Added llvm-string-referencing check.

Fixed failing unit test

Oct 1 2020, 6:37 AM · Restricted Project

Sep 25 2020

bogser01 added a reviewer for D88314: Added llvm-string-referencing check: alexfh.
Sep 25 2020, 9:30 AM · Restricted Project
bogser01 requested review of D88314: Added llvm-string-referencing check.
Sep 25 2020, 9:09 AM · Restricted Project
bogser01 updated the diff for D88311: Added llvm-string-referencing check.

Changed upstream

Sep 25 2020, 8:46 AM · Restricted Project
bogser01 requested review of D88311: Added llvm-string-referencing check.
Sep 25 2020, 8:35 AM · Restricted Project

Aug 4 2020

bogser01 requested review of D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions.
Aug 4 2020, 9:37 AM · Restricted Project, Restricted Project