Jul 11 2019
Jul 10 2019
LGTM, Thank you!
Jul 9 2019
Jul 8 2019
undo some behavior change
Reverted debug logging
Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has remained unreviewed for two weeks.
is the patch description still correct?
Sanitizers use sh scripts which can be checked out and executed on most linux dev workstations.
Changes to these scripts are effective immediately.
Reverted with r365359
Jul 3 2019
I reviewed the code and mostly came up with surface formatting issues. Functionally I think it looks good and the only way to really find out if it works is to ship it. :) So, I think we should fix the surface issues and try to move forward with that.
What is the idea here? Just a refactoring to get rid of recursive calls? Or are you going to use the histogram for some other purposes?
(the patch is lacking description, but perhaps it's just a temporary hack an not something that is subject for submitting?)
Added comment into description, I hope to upload the patch which is going to use new function today.
Jul 2 2019
Use size instead of getNumElements
Fix compilation warnings