Page MenuHomePhabricator
Feed Advanced Search

Jul 11 2019

vitalybuka committed rGf55aad0356fd: CodeGen: Suppress c++ warnings in test (authored by vitalybuka).
CodeGen: Suppress c++ warnings in test
Jul 11 2019, 3:00 PM
vitalybuka committed rL365835: CodeGen: Suppress c++ warnings in test.
CodeGen: Suppress c++ warnings in test
Jul 11 2019, 3:00 PM
vitalybuka added a parent revision for D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF: D63967: Handle IntToPtr in isBytewiseValue.
Jul 11 2019, 2:14 PM · Restricted Project, Restricted Project
vitalybuka added a child revision for D63967: Handle IntToPtr in isBytewiseValue: D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF.
Jul 11 2019, 2:14 PM · Restricted Project, Restricted Project
vitalybuka created D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF.
Jul 11 2019, 2:13 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D63967: Handle IntToPtr in isBytewiseValue.
Jul 11 2019, 2:08 PM · Restricted Project, Restricted Project
vitalybuka committed rG07bfa5b87027: CodeGen, NFC: Test for auto-init for 32bit pointers (authored by vitalybuka).
CodeGen, NFC: Test for auto-init for 32bit pointers
Jul 11 2019, 1:54 PM
vitalybuka committed rL365822: CodeGen, NFC: Test for auto-init for 32bit pointers.
CodeGen, NFC: Test for auto-init for 32bit pointers
Jul 11 2019, 1:52 PM

Jul 10 2019

vitalybuka updated the summary of D63967: Handle IntToPtr in isBytewiseValue.
Jul 10 2019, 6:48 PM · Restricted Project, Restricted Project
vitalybuka added reviewers for D63967: Handle IntToPtr in isBytewiseValue: glider, jfb.
Jul 10 2019, 6:35 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D63967: Handle IntToPtr in isBytewiseValue.
Jul 10 2019, 6:19 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D63967: Handle IntToPtr in isBytewiseValue.
Jul 10 2019, 6:16 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 10 2019, 4:06 PM · Restricted Project
vitalybuka updated the summary of D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 10 2019, 4:03 PM · Restricted Project
vitalybuka updated the summary of D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 10 2019, 4:03 PM · Restricted Project
vitalybuka updated the summary of D63967: Handle IntToPtr in isBytewiseValue.
Jul 10 2019, 4:03 PM · Restricted Project, Restricted Project
vitalybuka committed rG329d15b5df5c: Add IsBytewiseValue unit test (authored by vitalybuka).
Add IsBytewiseValue unit test
Jul 10 2019, 3:57 PM
vitalybuka committed rGd03bd1db5949: NFC: Pass DataLayout into isBytewiseValue (authored by vitalybuka).
NFC: Pass DataLayout into isBytewiseValue
Jul 10 2019, 3:57 PM
vitalybuka committed rL365710: Add IsBytewiseValue unit test.
Add IsBytewiseValue unit test
Jul 10 2019, 3:57 PM
vitalybuka closed D63966: Add IsBytewiseValue unit test.
Jul 10 2019, 3:57 PM · Restricted Project
vitalybuka committed rGe72676657f3e: NFC: Convert large lambda into method (authored by vitalybuka).
NFC: Convert large lambda into method
Jul 10 2019, 3:57 PM
vitalybuka committed rL365709: NFC: Pass DataLayout into isBytewiseValue.
NFC: Pass DataLayout into isBytewiseValue
Jul 10 2019, 3:57 PM
vitalybuka closed D63940: NFC: Pass DataLayout into isBytewiseValue.
Jul 10 2019, 3:57 PM · Restricted Project, Restricted Project
vitalybuka committed rL365708: NFC: Convert large lambda into method.
NFC: Convert large lambda into method
Jul 10 2019, 3:56 PM
vitalybuka closed D63854: NFC: Convert large lambda into method.
Jul 10 2019, 3:56 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka retitled D63940: NFC: Pass DataLayout into isBytewiseValue from [NFC] Pass DataLayout into isBytewiseValue to NFC: Pass DataLayout into isBytewiseValue.
Jul 10 2019, 3:49 PM · Restricted Project, Restricted Project
vitalybuka committed rGe26398849dcc: GodeGen, NFC: Add test to track emitStoresForConstant behavior (authored by vitalybuka).
GodeGen, NFC: Add test to track emitStoresForConstant behavior
Jul 10 2019, 3:48 PM
vitalybuka committed rL365706: GodeGen, NFC: Add test to track emitStoresForConstant behavior.
GodeGen, NFC: Add test to track emitStoresForConstant behavior
Jul 10 2019, 3:47 PM
vitalybuka retitled D63854: NFC: Convert large lambda into method from [NFC] Convert large lambda into method to NFC: Convert large lambda into method.
Jul 10 2019, 3:47 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka closed D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior.
Jul 10 2019, 3:47 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior.
Jul 10 2019, 3:35 PM · Restricted Project, Restricted Project
vitalybuka accepted D64057: Add NetBSD LSan support.

LGTM, Thank you!

Jul 10 2019, 1:28 PM · Restricted Project

Jul 9 2019

vitalybuka added inline comments to D64057: Add NetBSD LSan support.
Jul 9 2019, 3:04 PM · Restricted Project
vitalybuka edited reviewers for D62875: [GWP-ASan] Add public-facing documentation [6]., added: morehouse, vlad.tsyrklevich; removed: vitalybuka.
Jul 9 2019, 2:11 PM · Restricted Project, Restricted Project
vitalybuka accepted D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272.
Jul 9 2019, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 9 2019, 3:11 AM · Restricted Project
vitalybuka added inline comments to D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 9 2019, 2:42 AM · Restricted Project
vitalybuka updated the diff for D64382: Use getMostFrequentByte to decide if should used memset+stores.

rebase

Jul 9 2019, 2:13 AM · Restricted Project
vitalybuka added a parent revision for D64392: CodeGen: Use memset for bytewise values with any size: D64387: CodeGen: Do not memset if following stores will overwrite entire variable.
Jul 9 2019, 1:47 AM · Restricted Project
vitalybuka added a child revision for D64387: CodeGen: Do not memset if following stores will overwrite entire variable: D64392: CodeGen: Use memset for bytewise values with any size.
Jul 9 2019, 1:47 AM · Restricted Project
vitalybuka created D64392: CodeGen: Use memset for bytewise values with any size.
Jul 9 2019, 1:47 AM · Restricted Project

Jul 8 2019

vitalybuka added a parent revision for D64387: CodeGen: Do not memset if following stores will overwrite entire variable: D64386: CodeGen: Use memset in initializers for non-zeros.
Jul 8 2019, 10:57 PM · Restricted Project
vitalybuka added a child revision for D64386: CodeGen: Use memset in initializers for non-zeros: D64387: CodeGen: Do not memset if following stores will overwrite entire variable.
Jul 8 2019, 10:57 PM · Restricted Project
vitalybuka created D64387: CodeGen: Do not memset if following stores will overwrite entire variable.
Jul 8 2019, 10:57 PM · Restricted Project
vitalybuka updated the diff for D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior.

add test

Jul 8 2019, 10:37 PM · Restricted Project, Restricted Project
vitalybuka added a parent revision for D64386: CodeGen: Use memset in initializers for non-zeros: D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 8 2019, 10:12 PM · Restricted Project
vitalybuka added a child revision for D64382: Use getMostFrequentByte to decide if should used memset+stores: D64386: CodeGen: Use memset in initializers for non-zeros.
Jul 8 2019, 10:12 PM · Restricted Project
vitalybuka created D64386: CodeGen: Use memset in initializers for non-zeros.
Jul 8 2019, 10:08 PM · Restricted Project
vitalybuka updated the diff for D64382: Use getMostFrequentByte to decide if should used memset+stores.

undo some behavior change

Jul 8 2019, 9:32 PM · Restricted Project
vitalybuka updated the diff for D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior.

format

Jul 8 2019, 9:31 PM · Restricted Project, Restricted Project
vitalybuka retitled D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior from GodeGen: Add test to track emitStoresForConstant behavior to GodeGen, NFC: Add test to track emitStoresForConstant behavior.
Jul 8 2019, 9:31 PM · Restricted Project, Restricted Project
vitalybuka added a child revision for D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior: D63854: NFC: Convert large lambda into method.
Jul 8 2019, 9:31 PM · Restricted Project, Restricted Project
vitalybuka added a parent revision for D63854: NFC: Convert large lambda into method: D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior.
Jul 8 2019, 9:31 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka created D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior.
Jul 8 2019, 9:27 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D64382: Use getMostFrequentByte to decide if should used memset+stores.

Reverted debug logging

Jul 8 2019, 8:19 PM · Restricted Project
vitalybuka updated the summary of D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 8 2019, 8:06 PM · Restricted Project
vitalybuka planned changes to D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 8 2019, 5:23 PM · Restricted Project
vitalybuka added a parent revision for D64382: Use getMostFrequentByte to decide if should used memset+stores: D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 8 2019, 5:23 PM · Restricted Project
vitalybuka added a child revision for D64111: Add getMostFrequentByte and use for isBytewiseValue implementation: D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 8 2019, 5:23 PM · Restricted Project
vitalybuka created D64382: Use getMostFrequentByte to decide if should used memset+stores.
Jul 8 2019, 5:23 PM · Restricted Project
vitalybuka added inline comments to D63877: Avoid infinite loop with asan interception.
Jul 8 2019, 2:54 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D63877: Avoid infinite loop with asan interception.
Jul 8 2019, 2:54 PM · Restricted Project, Restricted Project
vitalybuka accepted D63887: [ThinLTO] only emit used or referenced CFI records to index.
Jul 8 2019, 2:41 PM · Restricted Project
vitalybuka accepted D64171: Factor out resolveFrameOffsetReference..
Jul 8 2019, 2:31 PM · Restricted Project
vitalybuka accepted D63601: [Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris.
Jul 8 2019, 1:54 PM · Restricted Project, Restricted Project
vitalybuka accepted D63602: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris.
In D63602#1570884, @ro wrote:

Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has remained unreviewed for two weeks.

Jul 8 2019, 1:49 PM · Restricted Project, Restricted Project
vitalybuka committed rL365385: Remove extraRecipients for sanitizer-x86_64-linux-gn.
Remove extraRecipients for sanitizer-x86_64-linux-gn
Jul 8 2019, 1:36 PM
vitalybuka closed D64363: Remove extraRecipients for sanitizer-x86_64-linux-gn.
Jul 8 2019, 1:36 PM · Restricted Project
vitalybuka created D64363: Remove extraRecipients for sanitizer-x86_64-linux-gn.
Jul 8 2019, 12:52 PM · Restricted Project
vitalybuka updated the summary of D64363: Remove extraRecipients for sanitizer-x86_64-linux-gn.
Jul 8 2019, 12:52 PM · Restricted Project
vitalybuka added inline comments to D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.
Jul 8 2019, 12:48 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D64057: Add NetBSD LSan support.
Jul 8 2019, 11:29 AM · Restricted Project
vitalybuka added a comment to D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272.

is the patch description still correct?

Jul 8 2019, 11:12 AM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.

Sanitizers use sh scripts which can be checked out and executed on most linux dev workstations.
http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/sanitizers/
Changes to these scripts are effective immediately.

Jul 8 2019, 11:11 AM · Restricted Project, Restricted Project
vitalybuka committed rG29949a65b662: Update gn files (authored by vitalybuka).
Update gn files
Jul 8 2019, 10:51 AM
vitalybuka committed rL365361: Update gn files.
Update gn files
Jul 8 2019, 10:50 AM
vitalybuka committed rGa9d5c186e224: Revert "[libc++] Take 2: Do not cleverly link against libc++abi just because it… (authored by vitalybuka).
Revert "[libc++] Take 2: Do not cleverly link against libc++abi just because it…
Jul 8 2019, 10:49 AM
vitalybuka added a reverting change for rG945b9ec06933: [libc++] Take 2: Do not cleverly link against libc++abi just because it happens…: rGa9d5c186e224: Revert "[libc++] Take 2: Do not cleverly link against libc++abi just because it….
Jul 8 2019, 10:49 AM
vitalybuka committed rL365359: Revert "[libc++] Take 2: Do not cleverly link against libc++abi just because it….
Revert "[libc++] Take 2: Do not cleverly link against libc++abi just because it…
Jul 8 2019, 10:48 AM
vitalybuka reopened D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.

Reverted with r365359

Jul 8 2019, 10:48 AM · Restricted Project, Restricted Project
vitalybuka accepted D64169: ARM MTE stack sanitizer..
Jul 8 2019, 10:37 AM · Restricted Project, Restricted Project
vitalybuka committed rGb636c263896f: Update gn files (authored by vitalybuka).
Update gn files
Jul 8 2019, 10:20 AM
vitalybuka committed rL365354: Update gn files.
Update gn files
Jul 8 2019, 10:20 AM

Jul 3 2019

vitalybuka added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.
In D62927#1568926, @rnk wrote:

I reviewed the code and mostly came up with surface formatting issues. Functionally I think it looks good and the only way to really find out if it works is to ship it. :) So, I think we should fix the surface issues and try to move forward with that.

Jul 3 2019, 12:33 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 3 2019, 10:36 AM · Restricted Project
vitalybuka added a comment to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.

What is the idea here? Just a refactoring to get rid of recursive calls? Or are you going to use the histogram for some other purposes?
(the patch is lacking description, but perhaps it's just a temporary hack an not something that is subject for submitting?)

Added comment into description, I hope to upload the patch which is going to use new function today.

Jul 3 2019, 10:04 AM · Restricted Project
vitalybuka updated the summary of D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 3 2019, 9:59 AM · Restricted Project
vitalybuka updated the summary of D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 3 2019, 9:59 AM · Restricted Project
vitalybuka updated the summary of D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 3 2019, 9:59 AM · Restricted Project

Jul 2 2019

vitalybuka added inline comments to D64052: Return Undef from isBytewiseValue for empty arrays or structs.
Jul 2 2019, 5:22 PM · Restricted Project
vitalybuka updated the diff for D64052: Return Undef from isBytewiseValue for empty arrays or structs.

Use size instead of getNumElements

Jul 2 2019, 5:17 PM · Restricted Project
vitalybuka updated the diff for D63966: Add IsBytewiseValue unit test.

More tests

Jul 2 2019, 5:17 PM · Restricted Project
vitalybuka updated the diff for D63966: Add IsBytewiseValue unit test.

More tests

Jul 2 2019, 4:51 PM · Restricted Project
vitalybuka added reviewers for D64111: Add getMostFrequentByte and use for isBytewiseValue implementation: pcc, eugenis.
Jul 2 2019, 4:28 PM · Restricted Project
vitalybuka updated the diff for D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.

Fix compilation warnings

Jul 2 2019, 4:28 PM · Restricted Project
vitalybuka added a parent revision for D64111: Add getMostFrequentByte and use for isBytewiseValue implementation: D64052: Return Undef from isBytewiseValue for empty arrays or structs.
Jul 2 2019, 4:17 PM · Restricted Project
vitalybuka added a child revision for D64052: Return Undef from isBytewiseValue for empty arrays or structs: D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 2 2019, 4:17 PM · Restricted Project
vitalybuka created D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 2 2019, 4:16 PM · Restricted Project
vitalybuka added inline comments to D63877: Avoid infinite loop with asan interception.
Jul 2 2019, 3:19 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D63966: Add IsBytewiseValue unit test.

More tests

Jul 2 2019, 3:10 PM · Restricted Project