Page MenuHomePhabricator
Feed Advanced Search

Today

vitalybuka closed D66620: [sanitizer] Update symbolizer/scripts.
Thu, Aug 22, 5:58 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D66620: [sanitizer] Update symbolizer/scripts.
Thu, Aug 22, 5:58 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D66620: [sanitizer] Update symbolizer/scripts.
Thu, Aug 22, 5:58 PM · Restricted Project, Restricted Project
vitalybuka accepted D66620: [sanitizer] Update symbolizer/scripts.
Thu, Aug 22, 3:33 PM · Restricted Project, Restricted Project

Yesterday

vitalybuka added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).

Compilation fails with this patch
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22936/steps/bootstrap%20clang/logs/stdio

Wed, Aug 21, 1:21 AM · Restricted Project, Restricted Project

Tue, Aug 20

vitalybuka requested changes to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

I've started to fix this but realized that it's more than a quick fix

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_allocator_combined.h b/compiler-rt/lib/sanitizer_common/sanitizer_allocator_combined.h
index c11d1f83fb54..47b4aba488bd 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_allocator_combined.h
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_allocator_combined.h
@@ -159,7 +159,7 @@ class CombinedAllocator {
   void TestOnlyUnmap() { primary_.TestOnlyUnmap(); }
Tue, Aug 20, 10:14 PM · Restricted Project
vitalybuka committed rG93a3cbc74682: Revert r369472 and r369441 (authored by vitalybuka).
Revert r369472 and r369441
Tue, Aug 20, 10:06 PM
vitalybuka reopened D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

check-sanitizer does not work
reverted with r369495

Tue, Aug 20, 10:06 PM · Restricted Project
vitalybuka committed rL369495: Revert r369472 and r369441.
Revert r369472 and r369441
Tue, Aug 20, 10:05 PM
vitalybuka committed rG5d84a67ce04e: Fix 'fall through' annotation (authored by vitalybuka).
Fix 'fall through' annotation
Tue, Aug 20, 9:06 PM
vitalybuka committed rL369490: Fix 'fall through' annotation.
Fix 'fall through' annotation
Tue, Aug 20, 9:06 PM
vitalybuka accepted D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

Thanks! LGTM

Tue, Aug 20, 12:54 PM · Restricted Project
vitalybuka added a comment to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

Almost LGTM

Tue, Aug 20, 10:45 AM · Restricted Project

Mon, Aug 19

vitalybuka added a comment to D66457: MemTag: unchecked load/store optimization..

LGTM

Mon, Aug 19, 6:47 PM · Restricted Project
vitalybuka accepted D66311: [GWP-ASan] Fix typos..
Mon, Aug 19, 4:10 PM · Restricted Project, Restricted Project
vitalybuka accepted D66317: Refactor isPointerOffset (NFC)..
Mon, Aug 19, 1:40 PM · Restricted Project
vitalybuka added a comment to rL366708: Revert "Reland [ELF] Loose a condition for relocation with a symbol".

We are still interested in gold compatibility, I think.

Mon, Aug 19, 12:54 PM
vitalybuka updated subscribers of rL366708: Revert "Reland [ELF] Loose a condition for relocation with a symbol".

@pcc, @eugenis Maybe we should just switch bots to use LLD?

Mon, Aug 19, 10:51 AM

Fri, Aug 16

vitalybuka accepted D66375: Add sanitizer-aarch64-linux-mte builder..
Fri, Aug 16, 5:14 PM · Restricted Project
vitalybuka accepted D66375: Add sanitizer-aarch64-linux-mte builder..
Fri, Aug 16, 5:14 PM · Restricted Project

Wed, Aug 14

vitalybuka committed rG8f6a84d6c32f: gn build: Merge r368918 (authored by vitalybuka).
gn build: Merge r368918
Wed, Aug 14, 6:39 PM
vitalybuka committed rL368951: gn build: Merge r368918.
gn build: Merge r368918
Wed, Aug 14, 6:38 PM
vitalybuka added a comment to D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect..

LGTM as-is with few questions and suggestions

Wed, Aug 14, 12:46 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect..
Wed, Aug 14, 12:46 PM · Restricted Project, Restricted Project

Tue, Aug 13

vitalybuka accepted D66165: Move isPointerOffset function to ValueTracking..

It's does not change code, but looks like it can be improved in followup patches

Tue, Aug 13, 7:50 PM · Restricted Project

Thu, Aug 8

vitalybuka accepted D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Thu, Aug 8, 10:47 AM · Restricted Project
vitalybuka updated the diff for D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.

Fix https://godbolt.org/z/-PinQP

Thu, Aug 8, 10:29 AM · Restricted Project, Restricted Project

Tue, Aug 6

vitalybuka accepted D65495: [asan_symbolize] Fix bug where the frame counter was not incremented..
Tue, Aug 6, 12:58 PM · Restricted Project, Restricted Project
vitalybuka accepted D65770: hwasan: Instrument globals..
Tue, Aug 6, 11:51 AM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Tue, Aug 6, 11:13 AM · Restricted Project
vitalybuka accepted D65642: Enable memtag sanitizer in all AArch64 toolchains .
Tue, Aug 6, 10:47 AM · Restricted Project
vitalybuka added inline comments to D65642: Enable memtag sanitizer in all AArch64 toolchains .
Tue, Aug 6, 2:09 AM · Restricted Project
vitalybuka committed rGac9ee01fcbfa: [compiler-rt] Implement getrandom interception (authored by vitalybuka).
[compiler-rt] Implement getrandom interception
Tue, Aug 6, 1:44 AM
vitalybuka committed rL367999: [compiler-rt] Implement getrandom interception.
[compiler-rt] Implement getrandom interception
Tue, Aug 6, 1:43 AM
vitalybuka closed D65551: [compiler-rt] Implement getrandom interception.
Tue, Aug 6, 1:43 AM · Restricted Project, Restricted Project
vitalybuka updated the summary of D65551: [compiler-rt] Implement getrandom interception.
Tue, Aug 6, 1:29 AM · Restricted Project, Restricted Project

Mon, Aug 5

vitalybuka added inline comments to D65770: hwasan: Instrument globals..
Mon, Aug 5, 2:29 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D65770: hwasan: Instrument globals..
Mon, Aug 5, 2:15 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D65551: [compiler-rt] Implement getrandom interception.
Mon, Aug 5, 1:43 PM · Restricted Project, Restricted Project
vitalybuka accepted D65769: llvm-symbolizer: Untag addresses in object files by default..
Mon, Aug 5, 1:39 PM · Restricted Project
vitalybuka added a reviewer for D65508: [AArch64] Make the memtag sanitizer require the memtag extension: pcc.
Mon, Aug 5, 12:45 PM · Restricted Project

Fri, Aug 2

vitalybuka requested changes to D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect..
Fri, Aug 2, 12:24 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.
Fri, Aug 2, 12:24 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D65551: [compiler-rt] Implement getrandom interception.

Can you please add some trivial test under compiler-rt/test/sanitizer_common ? You can't check sanitization there, just check that does not crash and return reasonable results

Fri, Aug 2, 11:29 AM · Restricted Project, Restricted Project
vitalybuka accepted D65055: [sanitizer_common][tests] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/SanitizerCommon.PthreadDestructorIterations on Solaris.
Fri, Aug 2, 11:21 AM · Restricted Project, Restricted Project
vitalybuka accepted D65660: [scudo][standalone] Minor corrections.
Fri, Aug 2, 11:19 AM · Restricted Project, Restricted Project

Thu, Aug 1

vitalybuka committed rG74296c99b38f: Fix flaky test caused by PR42868 (authored by vitalybuka).
Fix flaky test caused by PR42868
Thu, Aug 1, 7:29 PM
vitalybuka committed rL367642: Fix flaky test caused by PR42868.
Fix flaky test caused by PR42868
Thu, Aug 1, 7:28 PM

Tue, Jul 30

vitalybuka added inline comments to D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect..
Tue, Jul 30, 4:53 PM · Restricted Project, Restricted Project
vitalybuka added a reviewer for D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect.: vitalybuka.
Tue, Jul 30, 4:02 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect..
Tue, Jul 30, 3:57 PM · Restricted Project, Restricted Project

Mon, Jul 29

vitalybuka accepted D65056: [ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc on Solaris.
In D65056#1603902, @ro wrote:

Ping? It's been a week now. Is there some policy not to xfail the test which as documented in the bug cannot pass on Solaris?

Mon, Jul 29, 12:07 PM · Restricted Project, Restricted Project
vitalybuka committed rG9dfed83eaa9f: gn build: Merge r367071 (authored by vitalybuka).
gn build: Merge r367071
Mon, Jul 29, 10:50 AM
vitalybuka committed rL367245: gn build: Merge r367071.
gn build: Merge r367071
Mon, Jul 29, 10:50 AM

Wed, Jul 24

vitalybuka added a comment to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

Is any test was broken?

Wed, Jul 24, 5:19 PM · Restricted Project, Restricted Project
vitalybuka accepted D65252: [sanitizer_common] Allow customization of StartSymbolizerSubprocess.
Wed, Jul 24, 5:06 PM · Restricted Project, Restricted Project

Jul 22 2019

vitalybuka accepted D64664: [scudo][standalone] Optimization pass.

Set of smaller patches may help you to bisect in case of regressions.

Jul 22 2019, 11:39 AM · Restricted Project, Restricted Project
vitalybuka accepted D65031: WholeProgramDevirt: Teach the pass to respect the global's alignment..
Jul 22 2019, 11:35 AM · Restricted Project
vitalybuka accepted D65033: LowerTypeTests: Teach the pass to respect global alignments..
Jul 22 2019, 11:30 AM · Restricted Project

Jul 20 2019

vitalybuka updated the diff for D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.

fix LTO on kernel

Jul 20 2019, 1:03 AM · Restricted Project, Restricted Project

Jul 17 2019

vitalybuka accepted D64896: Make DT a transitive dependency of LI..
Jul 17 2019, 4:30 PM · Restricted Project

Jul 16 2019

vitalybuka accepted D63877: Avoid infinite loop with asan interception.
Jul 16 2019, 2:20 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.
Jul 16 2019, 1:56 PM · Restricted Project, Restricted Project

Jul 15 2019

vitalybuka updated the diff for D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.

Rebase only

Jul 15 2019, 1:28 PM · Restricted Project, Restricted Project
vitalybuka accepted D64169: ARM MTE stack sanitizer..
Jul 15 2019, 12:46 PM · Restricted Project, Restricted Project

Jul 12 2019

vitalybuka added a comment to D64675: WIP: Disable optimization in emitStoresForConstant.
In D64675#1584016, @jfb wrote:

I would keep single stores because it's pretty silly codegen to copy from a global for that.

I would also verify that -O0 isn't affected too badly by this change.

Jul 12 2019, 5:00 PM · Restricted Project
vitalybuka updated the diff for D64675: WIP: Disable optimization in emitStoresForConstant.

Remove single store

Jul 12 2019, 4:28 PM · Restricted Project
vitalybuka edited parent revisions for D64675: WIP: Disable optimization in emitStoresForConstant, added: 1; removed: 1.
Jul 12 2019, 4:25 PM · Restricted Project
vitalybuka removed a child revision for D64052: Return Undef from isBytewiseValue for empty arrays or structs: D64675: WIP: Disable optimization in emitStoresForConstant.
Jul 12 2019, 4:25 PM · Restricted Project
vitalybuka added a child revision for D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF: D64675: WIP: Disable optimization in emitStoresForConstant.
Jul 12 2019, 4:25 PM · Restricted Project, Restricted Project
vitalybuka added a parent revision for D64675: WIP: Disable optimization in emitStoresForConstant: D64052: Return Undef from isBytewiseValue for empty arrays or structs.
Jul 12 2019, 4:22 PM · Restricted Project
vitalybuka added a child revision for D64052: Return Undef from isBytewiseValue for empty arrays or structs: D64675: WIP: Disable optimization in emitStoresForConstant.
Jul 12 2019, 4:22 PM · Restricted Project
vitalybuka created D64675: WIP: Disable optimization in emitStoresForConstant.
Jul 12 2019, 4:01 PM · Restricted Project
vitalybuka committed rGb1bff76e22bd: isBytewiseValue checks ConstantVector element by element (authored by vitalybuka).
isBytewiseValue checks ConstantVector element by element
Jul 12 2019, 3:38 PM
vitalybuka committed rL365971: isBytewiseValue checks ConstantVector element by element.
isBytewiseValue checks ConstantVector element by element
Jul 12 2019, 3:37 PM
vitalybuka closed D64031: isBytewiseValue checks ConstantVector element by element.
Jul 12 2019, 3:37 PM · Restricted Project
vitalybuka added inline comments to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 12 2019, 3:22 PM · Restricted Project
vitalybuka added inline comments to D64663: Extend function attributes bitset size from 64 to 96..
Jul 12 2019, 1:35 PM · Restricted Project
vitalybuka added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

compiler now crashes on this file from CTMark https://reviews.llvm.org/F9549420

Jul 12 2019, 1:28 PM · Restricted Project
vitalybuka added inline comments to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 12 2019, 1:19 PM · Restricted Project
Herald added a project to D51751: Merge clang's isRepeatedBytePattern with LLVM's isBytewiseValue: Restricted Project.
Jul 12 2019, 10:32 AM · Restricted Project
vitalybuka added a reviewer for D64031: isBytewiseValue checks ConstantVector element by element: jfb.
Jul 12 2019, 10:31 AM · Restricted Project
vitalybuka committed rGc2ac925d6e15: CodeGet: Init 32bit pointers with 0xFFFFFFFF (authored by vitalybuka).
CodeGet: Init 32bit pointers with 0xFFFFFFFF
Jul 12 2019, 10:22 AM
vitalybuka committed rL365921: CodeGet: Init 32bit pointers with 0xFFFFFFFF.
CodeGet: Init 32bit pointers with 0xFFFFFFFF
Jul 12 2019, 10:22 AM
vitalybuka closed D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF.
Jul 12 2019, 10:21 AM · Restricted Project, Restricted Project

Jul 11 2019

vitalybuka committed rG52096ee9a96e: Return Undef from isBytewiseValue for empty arrays or structs (authored by vitalybuka).
Return Undef from isBytewiseValue for empty arrays or structs
Jul 11 2019, 7:24 PM
vitalybuka committed rL365864: Return Undef from isBytewiseValue for empty arrays or structs.
Return Undef from isBytewiseValue for empty arrays or structs
Jul 11 2019, 7:23 PM
vitalybuka closed D64052: Return Undef from isBytewiseValue for empty arrays or structs.
Jul 11 2019, 7:23 PM · Restricted Project
vitalybuka updated the diff for D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF.

undo unrelated line

Jul 11 2019, 7:17 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF.

0xFFFFFFFF

Jul 11 2019, 7:14 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF.
In D64597#1581654, @jfb wrote:
In D64597#1581605, @pcc wrote:

The problem with 0xaaaaaaaa on 32-bit is that it is likely to be a valid address.

When I discussed this with JF I proposed a pointer initialization of 0xffffffff which he agreed to. This value is very likely to trap when accessed (due to accesses likely wrapping to zero) and also has the benefit of being the same pattern as for floats.

Indeed.

Jul 11 2019, 7:14 PM · Restricted Project, Restricted Project
vitalybuka retitled D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF from CodeGet: Init 32bit pointers with 0xAAAAAAAA to CodeGet: Init 32bit pointers with 0xFFFFFFFF.
Jul 11 2019, 7:11 PM · Restricted Project, Restricted Project
vitalybuka updated subscribers of rG669ad5ff1502: Codegen, NFC: 32bit test in auto-var-init.cpp.

Hi @jfb
Here I've added 32bit test and landed it without review as it's simple and does not change existing tests, I thought. Unfortunately later I realized that I've killed some alignment checks.
I don't think that they are important here. If you disagree, I can make something to return them.

Jul 11 2019, 6:59 PM
vitalybuka added 1 auditor(s) for rG669ad5ff1502: Codegen, NFC: 32bit test in auto-var-init.cpp: jfb.
Jul 11 2019, 6:58 PM
vitalybuka committed rGc559e63798e6: Handle IntToPtr in isBytewiseValue (authored by vitalybuka).
Handle IntToPtr in isBytewiseValue
Jul 11 2019, 6:44 PM
vitalybuka committed rL365858: Handle IntToPtr in isBytewiseValue.
Handle IntToPtr in isBytewiseValue
Jul 11 2019, 6:44 PM
vitalybuka closed D63967: Handle IntToPtr in isBytewiseValue.
Jul 11 2019, 6:44 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D64031: isBytewiseValue checks ConstantVector element by element.

This seems correct. Any idea why it has not been done this way from the start?

Jul 11 2019, 6:39 PM · Restricted Project
vitalybuka committed rG669ad5ff1502: Codegen, NFC: 32bit test in auto-var-init.cpp (authored by vitalybuka).
Codegen, NFC: 32bit test in auto-var-init.cpp
Jul 11 2019, 6:37 PM
vitalybuka committed rL365857: Codegen, NFC: 32bit test in auto-var-init.cpp.
Codegen, NFC: 32bit test in auto-var-init.cpp
Jul 11 2019, 6:36 PM