Page MenuHomePhabricator
Feed Advanced Search

Mon, Feb 17

broadwaylamb added a comment to D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

@ldionne would you have some time to verify this?

Mon, Feb 17, 6:34 AM · Restricted Project
broadwaylamb committed rG35367e06b846: Revert "[CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux. (authored by broadwaylamb).
Revert "[CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.
Mon, Feb 17, 5:12 AM
broadwaylamb added a reverting change for rG801627ee490e: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake: rG35367e06b846: Revert "[CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux..
Mon, Feb 17, 5:12 AM
broadwaylamb added a comment to D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake.

Reverted this because it broke our buildbot: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4704/steps/build-llvm-project/logs/stdio.

Mon, Feb 17, 5:12 AM · Restricted Project
broadwaylamb committed rG801627ee490e: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake (authored by broadwaylamb).
[CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake
Mon, Feb 17, 4:27 AM
broadwaylamb closed D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake.
Mon, Feb 17, 4:27 AM · Restricted Project

Fri, Feb 14

broadwaylamb added a comment to D72501: [libcxx] Support Python 3.8 in the test suite.

@broadwaylamb, I've requested backporting this to 10.x: https://bugs.llvm.org/show_bug.cgi?id=44905. However, i wasn't able to find to find you on Bugzilla and CC you. Could you confirm whether it's fine to backport, please?

Fri, Feb 14, 2:33 AM · Restricted Project

Wed, Feb 12

broadwaylamb committed rG377a1c80e989: [libcxx] Don't assume cwd name in std::filesystem tests (authored by broadwaylamb).
[libcxx] Don't assume cwd name in std::filesystem tests
Wed, Feb 12, 5:09 AM
broadwaylamb closed D74348: [libcxx] Don't assume cwd name in std::filesystem tests.
Wed, Feb 12, 5:09 AM · Restricted Project

Tue, Feb 11

broadwaylamb added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

@mgorny Thank you. I've been able to reproduce it on my Ubuntu installation.

Tue, Feb 11, 1:35 AM · Restricted Project

Mon, Feb 10

broadwaylamb added a comment to D74348: [libcxx] Don't assume cwd name in std::filesystem tests.

Thanks @ldionne, do I need to wait for anyone else’s approval or I can commit this?

Mon, Feb 10, 12:45 PM · Restricted Project
broadwaylamb updated the summary of D74348: [libcxx] Don't assume cwd name in std::filesystem tests.
Mon, Feb 10, 11:32 AM · Restricted Project
broadwaylamb updated the diff for D74348: [libcxx] Don't assume cwd name in std::filesystem tests.

Replace cwd.filename() with curdir

Mon, Feb 10, 11:32 AM · Restricted Project
broadwaylamb created D74348: [libcxx] Don't assume cwd name in std::filesystem tests.
Mon, Feb 10, 11:04 AM · Restricted Project
broadwaylamb created D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake.
Mon, Feb 10, 10:29 AM · Restricted Project
broadwaylamb added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

@mgorny I still can't reproduce the issue. What Linux distro are you using and how did you install your LLVM toolchain?

Mon, Feb 10, 8:01 AM · Restricted Project
broadwaylamb added a comment to D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

@ldionne could you please take a look?

Mon, Feb 10, 6:54 AM · Restricted Project

Mon, Feb 3

broadwaylamb added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

Anyway, reverted from 10.x in 3573526c0286c9461f0459be1a4592b2214594e7.

Please don't push directly to the release branch without checking with me. Also, commits should go to master first, before being cherry-picked to any release branches.

I've cherry-picked the revert to master in 1a7e688b0b5a986fbbbce62ff1506a5991b0fce0

Please see http://lists.llvm.org/pipermail/llvm-dev/2020-January/138295.html for more info about the branch.

Mon, Feb 3, 2:27 AM · Restricted Project

Fri, Jan 31

broadwaylamb committed rG3573526c0286: Revert "[libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH" (authored by broadwaylamb).
Revert "[libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH"
Fri, Jan 31, 3:41 AM
broadwaylamb added a reverting change for rG41f4dfd63ea0: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH: rG3573526c0286: Revert "[libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH".
Fri, Jan 31, 3:41 AM
broadwaylamb added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

Anyway, reverted from 10.x in 3573526c0286c9461f0459be1a4592b2214594e7.

Fri, Jan 31, 3:40 AM · Restricted Project
broadwaylamb added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

Could you please show me how you're building libc++? I'm having trouble reproducing the issue.

Fri, Jan 31, 3:31 AM · Restricted Project
broadwaylamb added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

That said, can we revert this from 10.x branch, please?

Fri, Jan 31, 3:13 AM · Restricted Project

Thu, Jan 30

broadwaylamb planned changes to D72687: [libcxx] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

I'm going to update this to be consistent with D71894.

Thu, Jan 30, 4:30 AM · Restricted Project
broadwaylamb updated the diff for D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

Move the new CMake options from libcxxabi/CMakeLists.txt to libcxxabi/test/CMakeLists.txt.

Thu, Jan 30, 4:21 AM · Restricted Project
broadwaylamb planned changes to D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file.

It's weird to mix Clang and libc++ test options because they test fundamentally different things. But I don't mind about this patch since it doesn't touch libc++ directly.

Thu, Jan 30, 2:32 AM · Restricted Project
broadwaylamb added inline comments to D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Thu, Jan 30, 2:23 AM · Restricted Project
broadwaylamb added a comment to D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

This commit broke testing when LIBCXX_ENABLE_STATIC is OFF. This includes the configuration in Apple's CMake cache.

Thu, Jan 30, 2:15 AM · Restricted Project
broadwaylamb updated the diff for D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

Set LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX to ON if LIBCXX_ENABLE_SHARED is not defined

Thu, Jan 30, 2:14 AM · Restricted Project

Tue, Jan 28

broadwaylamb accepted D73578: Execute libc++abi tests on Armv7 devboard by llvm-clang-win-x-armv7l builder..

LGTM

Tue, Jan 28, 1:45 PM · Restricted Project

Fri, Jan 24

broadwaylamb added a comment to D73351: [libcxx] Define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR using feature test macro.

Also, I'm fairly confident at this point that either no bots are testing libcxx against top-of-tree clang, or nobody is paying attention to the bots that do.

Fri, Jan 24, 7:44 AM · Restricted Project
broadwaylamb added a reviewer for D72980: Add test for spaceship operator to __config: CaseyCarter.
Fri, Jan 24, 7:37 AM · Restricted Project, Restricted Project
broadwaylamb added a comment to D72980: Add test for spaceship operator to __config.

I've also been experiencing these test failures and I'm very much interested in this getting landed.

Fri, Jan 24, 7:35 AM · Restricted Project, Restricted Project
broadwaylamb abandoned D73351: [libcxx] Define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR using feature test macro.
Fri, Jan 24, 7:35 AM · Restricted Project
broadwaylamb created D73351: [libcxx] Define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR using feature test macro.
Fri, Jan 24, 7:08 AM · Restricted Project

Jan 23 2020

broadwaylamb committed rGe464b31c1565: Revert "[tablegen] Emit string literals instead of char arrays" (authored by broadwaylamb).
Revert "[tablegen] Emit string literals instead of char arrays"
Jan 23 2020, 7:25 AM
broadwaylamb added a reverting change for rGce23515f5ab0: [tablegen] Emit string literals instead of char arrays: rGe464b31c1565: Revert "[tablegen] Emit string literals instead of char arrays".
Jan 23 2020, 7:25 AM
broadwaylamb added a comment to D73044: {tablegen] Emit string literals instead of char arrays.

Sorry, I had to revert this commit in e464b31c1565204e3be114d043bcbf4de61fe2e9, because it broke some Windows builds:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13870

Jan 23 2020, 7:24 AM · Restricted Project

Jan 21 2020

broadwaylamb committed rG7b8dc8c57697: [libcxx] Support Python 3.8 in the test suite (authored by broadwaylamb).
[libcxx] Support Python 3.8 in the test suite
Jan 21 2020, 9:29 AM
broadwaylamb closed D72501: [libcxx] Support Python 3.8 in the test suite.
Jan 21 2020, 9:29 AM · Restricted Project
broadwaylamb added inline comments to D72501: [libcxx] Support Python 3.8 in the test suite.
Jan 21 2020, 7:16 AM · Restricted Project
broadwaylamb added a comment to D72501: [libcxx] Support Python 3.8 in the test suite.

Could anyone verify this patch, please?

Jan 21 2020, 4:11 AM · Restricted Project
broadwaylamb added a reviewer for D72501: [libcxx] Support Python 3.8 in the test suite: ldionne.
Jan 21 2020, 4:11 AM · Restricted Project

Jan 17 2020

broadwaylamb committed rG383ff4eac1db: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake… (authored by broadwaylamb).
[CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake…
Jan 17 2020, 2:34 PM
broadwaylamb committed rG049c437c40c4: [libcxx] Introduce LinuxRemoteTI for remote testing (authored by broadwaylamb).
[libcxx] Introduce LinuxRemoteTI for remote testing
Jan 17 2020, 2:34 PM
broadwaylamb closed D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache.
Jan 17 2020, 2:33 PM · Restricted Project
broadwaylamb closed D72847: [libcxx] Introduce LinuxRemoteTI for remote testing.
Jan 17 2020, 2:33 PM · Restricted Project
broadwaylamb abandoned D72720: [libcxx] Allow manually specifying locales for use in tests via CMake.

Closing this in favor of D72847

Jan 17 2020, 6:40 AM · Restricted Project
broadwaylamb added a comment to D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file.

I think it is optimal to pass this parameter directly in the builder configuration only for libcxx as '-DLLVM_LIT_ARGS="--param enable_filesystem=False"'.

Jan 17 2020, 6:11 AM · Restricted Project

Jan 16 2020

broadwaylamb added a child revision for D72847: [libcxx] Introduce LinuxRemoteTI for remote testing: D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache.
Jan 16 2020, 7:50 AM · Restricted Project
broadwaylamb created D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache.
Jan 16 2020, 7:50 AM · Restricted Project
broadwaylamb added a comment to D72720: [libcxx] Allow manually specifying locales for use in tests via CMake.

My long term plan for this was to have a set of "remote" TargetInfo objects that mirror/wrap these "local" ones, and have the SSHExecutor sub them in as appropriate, but this seems like a pragmatic compromise.

Jan 16 2020, 7:40 AM · Restricted Project
broadwaylamb created D72847: [libcxx] Introduce LinuxRemoteTI for remote testing.
Jan 16 2020, 7:40 AM · Restricted Project

Jan 14 2020

broadwaylamb created D72720: [libcxx] Allow manually specifying locales for use in tests via CMake.
Jan 14 2020, 10:13 AM · Restricted Project
broadwaylamb created D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file.
Jan 14 2020, 9:45 AM · Restricted Project
broadwaylamb updated the diff for D72687: [libcxx] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

Fix a typo

Jan 14 2020, 2:19 AM · Restricted Project
broadwaylamb created D72687: [libcxx] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Jan 14 2020, 2:13 AM · Restricted Project

Jan 10 2020

broadwaylamb added a comment to D66644: [llvm-config] Support MSVS layout.

Could anyone verify this patch?

Jan 10 2020, 5:47 AM · Restricted Project
broadwaylamb added reviewers for D66644: [llvm-config] Support MSVS layout: jordan_rose, filcab, pcc.
Jan 10 2020, 5:47 AM · Restricted Project
broadwaylamb abandoned D66648: [compiler-rt] Respect CMAKE_C_FLAGS when building builtins in-tree.
Jan 10 2020, 5:36 AM · Restricted Project, Restricted Project
broadwaylamb created D72501: [libcxx] Support Python 3.8 in the test suite.
Jan 10 2020, 4:55 AM · Restricted Project
broadwaylamb committed rGe44dedd3631c: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file (authored by broadwaylamb).
[CMake] Support running libc++abi tests in CrossWinToARMLinux cache file
Jan 10 2020, 2:00 AM
broadwaylamb committed rG41f4dfd63ea0: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH (authored by broadwaylamb).
[libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH
Jan 10 2020, 2:00 AM
broadwaylamb closed D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file.
Jan 10 2020, 2:00 AM · Restricted Project
broadwaylamb closed D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.
Jan 10 2020, 2:00 AM · Restricted Project

Jan 9 2020

broadwaylamb updated the summary of D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file.
Jan 9 2020, 8:30 AM · Restricted Project
broadwaylamb created D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file.
Jan 9 2020, 8:30 AM · Restricted Project
broadwaylamb updated the summary of D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file.
Jan 9 2020, 8:30 AM · Restricted Project
broadwaylamb committed rGfb76c7934dce: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared… (authored by broadwaylamb).
[libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared…
Jan 9 2020, 8:03 AM
broadwaylamb closed D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Jan 9 2020, 8:02 AM · Restricted Project
broadwaylamb added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

@jroelofs would you mind reviewing this one too, please?

Jan 9 2020, 7:34 AM · Restricted Project
broadwaylamb added a comment to D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.

Could anyone please verify this patch?

Jan 9 2020, 6:56 AM · Restricted Project

Dec 26 2019

broadwaylamb committed rGe308a0ca15a5: [libcxx] Fix a typo in config.py (authored by broadwaylamb).
[libcxx] Fix a typo in config.py
Dec 26 2019, 7:55 AM
broadwaylamb closed D71890: [libcxx] Fix a typo in config.py.
Dec 26 2019, 7:54 AM · Restricted Project
broadwaylamb added inline comments to D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Dec 26 2019, 3:37 AM · Restricted Project
broadwaylamb retitled D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present from libcxxabi WIP to [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Dec 26 2019, 3:28 AM · Restricted Project
broadwaylamb created D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Dec 26 2019, 2:55 AM · Restricted Project
broadwaylamb abandoned D71889: libcxxabi WIP.
Dec 26 2019, 1:37 AM · Restricted Project
broadwaylamb created D71890: [libcxx] Fix a typo in config.py.
Dec 26 2019, 1:36 AM · Restricted Project
broadwaylamb removed a reviewer for D71889: libcxxabi WIP: EricWF.
Dec 26 2019, 1:36 AM · Restricted Project
broadwaylamb created D71889: libcxxabi WIP.
Dec 26 2019, 1:36 AM · Restricted Project

Dec 17 2019

broadwaylamb added a comment to D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file. .

LGTM

Dec 17 2019, 3:00 PM · Restricted Project

Dec 10 2019

broadwaylamb added a comment to D68275: [libcxx] [test] Query the target platform, not the host one.

@ldionne huge thanks for your time!

Dec 10 2019, 6:18 PM · Restricted Project
broadwaylamb committed rG57fc8ecdbaa7: Reland "Enable `-funwind-tables` flag when building libunwind" (authored by broadwaylamb).
Reland "Enable `-funwind-tables` flag when building libunwind"
Dec 10 2019, 5:33 PM
broadwaylamb closed D71117: Reland "Enable `-funwind-tables` flag when building libunwind".
Dec 10 2019, 5:32 PM · Restricted Project
broadwaylamb added a comment to D71117: Reland "Enable `-funwind-tables` flag when building libunwind".

Since the original patch has been approved and the bug because of which this has been reverted is fixed, I'm going to commit this.

Dec 10 2019, 5:32 PM · Restricted Project
broadwaylamb committed rG44c167ace998: [libcxx] Replace func_name with __name__ for compatibility with Python 3 (authored by broadwaylamb).
[libcxx] Replace func_name with __name__ for compatibility with Python 3
Dec 10 2019, 3:39 PM
broadwaylamb closed D71136: [libcxx] Replace func_name with __name__ for compatibility with Python 3.
Dec 10 2019, 3:38 PM · Restricted Project

Dec 8 2019

broadwaylamb added a comment to D71117: Reland "Enable `-funwind-tables` flag when building libunwind".

@mstorsjo thanks for verifying!

Dec 8 2019, 2:14 PM · Restricted Project

Dec 6 2019

broadwaylamb added reviewers for D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH: vvereschaka, eastig.
Dec 6 2019, 2:25 PM · Restricted Project
broadwaylamb added reviewers for D71136: [libcxx] Replace func_name with __name__ for compatibility with Python 3: vvereschaka, evgeny777.
Dec 6 2019, 11:37 AM · Restricted Project
broadwaylamb updated the summary of D71136: [libcxx] Replace func_name with __name__ for compatibility with Python 3.
Dec 6 2019, 11:28 AM · Restricted Project
broadwaylamb updated the diff for D71136: [libcxx] Replace func_name with __name__ for compatibility with Python 3.

Replace one more func_name

Dec 6 2019, 11:28 AM · Restricted Project
broadwaylamb created D71136: [libcxx] Replace func_name with __name__ for compatibility with Python 3.
Dec 6 2019, 11:27 AM · Restricted Project
broadwaylamb updated the summary of D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.
Dec 6 2019, 10:41 AM · Restricted Project
broadwaylamb updated the diff for D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

Remove unrelated change

Dec 6 2019, 10:41 AM · Restricted Project
broadwaylamb created D71117: Reland "Enable `-funwind-tables` flag when building libunwind".
Dec 6 2019, 6:48 AM · Restricted Project

Dec 3 2019

broadwaylamb committed rGb3fdf33ba6aa: Enable `-funwind-tables` flag when building libunwind (authored by broadwaylamb).
Enable `-funwind-tables` flag when building libunwind
Dec 3 2019, 1:58 PM
broadwaylamb closed D70815: Enable `-funwind-tables` flag when building libunwind.
Dec 3 2019, 1:58 PM · Restricted Project
broadwaylamb added a comment to D70815: Enable `-funwind-tables` flag when building libunwind.

Since no one seems to object, I'm gonna commit this. If it breaks anything, I'll revert as soon as possible.

Dec 3 2019, 12:43 PM · Restricted Project