Page MenuHomePhabricator
Feed Advanced Search

Thu, Aug 15

george.burgess.iv accepted D66033: [MemorySSA] Rename uses when inserting memory uses..

lgtm with a few nits. Thanks!

Thu, Aug 15, 5:18 PM · Restricted Project

Mon, Aug 5

george.burgess.iv committed rGa5c25c5d469f: [Sema] attempt to appease buildbots after r367940 (authored by george.burgess.iv).
[Sema] attempt to appease buildbots after r367940
Mon, Aug 5, 4:24 PM
george.burgess.iv committed rGf708f0a2430f: [Sema] Add -Wpointer-compare (authored by george.burgess.iv).
[Sema] Add -Wpointer-compare
Mon, Aug 5, 3:18 PM

Thu, Aug 1

george.burgess.iv accepted D65568: [AliasAnalysis] Initialize a member variable that may be used by unit test..

Thanks!

Thu, Aug 1, 10:48 AM · Restricted Project

Tue, Jul 30

george.burgess.iv accepted D65338: [MemorySSA] Extend allowed behavior for simplified instructions..

Thanks!

Tue, Jul 30, 11:31 AM · Restricted Project
george.burgess.iv added inline comments to D65338: [MemorySSA] Extend allowed behavior for simplified instructions..
Tue, Jul 30, 11:08 AM · Restricted Project

Mon, Jul 29

george.burgess.iv added a comment to D65338: [MemorySSA] Extend allowed behavior for simplified instructions..

Thanks for this! Two nits and a question

Mon, Jul 29, 10:15 PM · Restricted Project

Thu, Jul 25

george.burgess.iv committed rG9d045a5c1e6b: [Sema] add -Walloca to flag uses of `alloca` (authored by george.burgess.iv).
[Sema] add -Walloca to flag uses of `alloca`
Thu, Jul 25, 3:28 PM

Wed, Jul 24

george.burgess.iv committed rGcd16fadb9ccd: [BasicAA] Temporarily disable two tests (authored by george.burgess.iv).
[BasicAA] Temporarily disable two tests
Wed, Jul 24, 11:55 PM

Tue, Jul 23

george.burgess.iv added inline comments to D64883: Add new warning -Walloca for use of builtin alloca function.
Tue, Jul 23, 10:25 AM · Restricted Project, Restricted Project

Mon, Jul 22

george.burgess.iv added inline comments to D64883: Add new warning -Walloca for use of builtin alloca function.
Mon, Jul 22, 6:12 PM · Restricted Project, Restricted Project
george.burgess.iv added inline comments to D64883: Add new warning -Walloca for use of builtin alloca function.
Mon, Jul 22, 12:51 PM · Restricted Project, Restricted Project

Jul 19 2019

george.burgess.iv added a comment to D65019: [ARM] push LR before __gnu_mcount_nc.

Thanks for this!

Jul 19 2019, 3:09 PM · Restricted Project, Restricted Project

Jul 17 2019

george.burgess.iv added a comment to D64883: Add new warning -Walloca for use of builtin alloca function.

Thanks for this!

Jul 17 2019, 2:24 PM · Restricted Project, Restricted Project

Jul 16 2019

george.burgess.iv committed rGfdeed837edf3: Fix a typo in target features (authored by george.burgess.iv).
Fix a typo in target features
Jul 16 2019, 3:33 PM
george.burgess.iv added a comment to D64781: Silence backend complaints on x86 Android.

SGTM. Thanks for the review!

Jul 16 2019, 3:32 PM · Restricted Project

Jul 15 2019

george.burgess.iv created D64781: Silence backend complaints on x86 Android.
Jul 15 2019, 5:26 PM · Restricted Project

Jul 11 2019

george.burgess.iv accepted D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

Thanks! If it's easy to come up with a small regression test (like David mentioned on the bug, reverse_iteration may be a great help), please do so and commit it with this. Otherwise, LGTM as-is.

Jul 11 2019, 4:29 PM · Restricted Project

Jul 10 2019

george.burgess.iv accepted D64541: rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the....

LGTM with one change -- thanks!

Jul 10 2019, 4:25 PM · Restricted Project

Jun 24 2019

george.burgess.iv accepted D63680: [LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map..

thanks for this!

Jun 24 2019, 2:15 PM · Restricted Project

Jun 21 2019

george.burgess.iv committed rG67d1f8ae6d94: clang-format a block; NFC (authored by george.burgess.iv).
clang-format a block; NFC
Jun 21 2019, 1:52 PM

Jun 20 2019

george.burgess.iv added a comment to D63623: [clang-tidy] new check: bugprone-posix-return.

just a few drive-by nits/comments from me. as usual, not super familiar with clang-tidy, so i won't be able to stamp this.

Jun 20 2019, 2:10 PM · Restricted Project, Restricted Project
george.burgess.iv accepted D63582: [LICM & MSSA] Limit unsafe sinking and hoisting..

LGTM

Jun 20 2019, 1:49 PM · Restricted Project
george.burgess.iv added a comment to D63582: [LICM & MSSA] Limit unsafe sinking and hoisting..

Thanks for this!

Jun 20 2019, 1:01 PM · Restricted Project

Jun 17 2019

george.burgess.iv accepted D63354: [MemorySSA] Cleanup trivial phis..

Thanks!

Jun 17 2019, 7:16 PM · Restricted Project
george.burgess.iv accepted D63147: [MemorySSA] Add additional verification for phis..

Thanks!

Jun 17 2019, 7:09 PM · Restricted Project
george.burgess.iv accepted D63443: [MemorySSA] Use GraphDiff info when computing IDF..

Thanks!

Jun 17 2019, 7:08 PM · Restricted Project

Jun 14 2019

george.burgess.iv accepted D63355: [MemorySSA] Don't use template when the clone is a simplified instruction..

just two stylistic nits; lgtm afterward. thanks for this!

Jun 14 2019, 8:37 PM · Restricted Project
george.burgess.iv accepted D63353: [MemorySSA] Add all MemoryPhis before filling their values..

Thanks!

Jun 14 2019, 8:24 PM · Restricted Project

Jun 13 2019

george.burgess.iv committed rG2c074bb39e25: [Targets] Move soft-float-abi filtering to `initFeatureMap` (authored by george.burgess.iv).
[Targets] Move soft-float-abi filtering to `initFeatureMap`
Jun 13 2019, 5:35 PM
george.burgess.iv added a comment to D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`.

ping :)

Jun 13 2019, 4:22 PM · Restricted Project, Restricted Project
george.burgess.iv added a comment to D62821: Workaround for PR41575: don't allow inlining of clear_cache on some platforms.

ping :)

Jun 13 2019, 4:21 PM · Restricted Project

Jun 11 2019

george.burgess.iv added a comment to D63147: [MemorySSA] Add additional verification for phis..

Thanks for adding this!

Jun 11 2019, 3:42 PM · Restricted Project

Jun 10 2019

george.burgess.iv accepted D63033: [MemorySSA] When applying updates, clean unnecessary Phis..

Please also add a test before committing if doing so is reasonably possible. If the test is super convoluted, I'm OK with this as-is.

Jun 10 2019, 1:58 PM · Restricted Project

Jun 6 2019

george.burgess.iv accepted D62791: [CFLGraph] Add support for unary fneg instruction..

Fair enough; thanks again!

Jun 6 2019, 10:39 AM · Restricted Project

Jun 5 2019

george.burgess.iv committed rG5b2a85d0ded2: android: add a close-on-exec check on pipe() (authored by george.burgess.iv).
android: add a close-on-exec check on pipe()
Jun 5 2019, 10:19 PM
george.burgess.iv committed rG3da331b45621: android: add a close-on-exec check on pipe2() (authored by george.burgess.iv).
android: add a close-on-exec check on pipe2()
Jun 5 2019, 10:19 PM

Jun 3 2019

george.burgess.iv added a comment to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..

Will submit once gribozavr indicates that they're happy with the new test names. Thanks again for working on this!

Jun 3 2019, 7:32 PM · Restricted Project, Restricted Project, Restricted Project
george.burgess.iv created D62821: Workaround for PR41575: don't allow inlining of clear_cache on some platforms.
Jun 3 2019, 12:56 PM · Restricted Project
george.burgess.iv committed rGc24a2f4ad921: CFLAA: reflow comments; NFC (authored by george.burgess.iv).
CFLAA: reflow comments; NFC
Jun 3 2019, 12:55 PM
george.burgess.iv added a comment to D62791: [CFLGraph] Add support for unary fneg instruction..

Thanks you both! LGTM with a test, assuming that adding the test is straightforward.

Jun 3 2019, 12:00 PM · Restricted Project
george.burgess.iv accepted D62790: [CFLGraph] Add FAdd to visitConstantExpr..

Thanks for this!

Jun 3 2019, 11:48 AM · Restricted Project

May 23 2019

george.burgess.iv added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

Thanks for the feedback!

May 23 2019, 1:14 PM
george.burgess.iv updated the diff for D38479: Make -mgeneral-regs-only more like GCC's.

Addressed feedback, modulo the constant foldable comment thread.

May 23 2019, 1:14 PM

May 22 2019

george.burgess.iv committed rG3d68a38be8d2: Remove unnecessary const&s; NFC (authored by george.burgess.iv).
Remove unnecessary const&s; NFC
May 22 2019, 7:51 PM
george.burgess.iv updated the diff for D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`.

Address comments -- thanks!

May 22 2019, 7:36 PM · Restricted Project, Restricted Project
george.burgess.iv added a comment to D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`.

neonfp isn't passed as a feature in the first place; there's a separate API setFPMath which is used for that. We translate it into a target feature for the sake of the backend. So I'm not sure what you're proposing.

May 22 2019, 7:36 PM · Restricted Project, Restricted Project

May 20 2019

george.burgess.iv updated the diff for D38479: Make -mgeneral-regs-only more like GCC's.

Rebased

May 20 2019, 7:40 PM

May 19 2019

george.burgess.iv added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

I'm happy to give rebasing it a shot later this week. My recollection of the prior state of this patch was that we wanted some backend work done to double-check that no illegal ops get generated by optimizations and such, since these checks are purely done in the frontend. I don't foresee myself having time in the near future to make that happen, so is that something that we want to continue to block this patch on? If so, then someone else is probably going to need to do that piece. Otherwise, I think people were happy enough with this patch as-is?

May 19 2019, 8:28 PM

May 16 2019

george.burgess.iv added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 16 2019, 1:37 PM · Restricted Project, Restricted Project, Restricted Project

May 15 2019

george.burgess.iv added a comment to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..

Thanks for this!

May 15 2019, 3:58 PM · Restricted Project, Restricted Project, Restricted Project

May 9 2019

george.burgess.iv created D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`.
May 9 2019, 12:15 PM · Restricted Project, Restricted Project

May 6 2019

george.burgess.iv accepted D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

just letting George mark it as accepted when he's happy too

May 6 2019, 4:54 PM · Restricted Project

May 2 2019

george.burgess.iv accepted D61410: [MemorySSA] Check that block is reachable when adding phis..

Thanks!

May 2 2019, 4:04 PM · Restricted Project
george.burgess.iv accepted D61471: [MemorySSA] Refactor removing multiple trivial phis [NFC]..

LGTM after two nits; thanks!

May 2 2019, 3:42 PM · Restricted Project

May 1 2019

george.burgess.iv added inline comments to D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..
May 1 2019, 5:56 PM · Restricted Project
george.burgess.iv added a comment to D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

MSSA bits LGTM modulo a few nits. Feel free to commit when Chandler is happy.

May 1 2019, 3:29 PM · Restricted Project

Apr 22 2019

george.burgess.iv added a comment to D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

I don't mean to interrupt the ongoing discussion; just wanted to send a few nits about the MSSA-specific bits. Thanks!

Apr 22 2019, 3:48 PM · Restricted Project

Apr 18 2019

george.burgess.iv accepted D60747: Remove EnableEarlyCSEMemSSA option.

This sounds like people are fine with me doing this...

Apr 18 2019, 1:52 PM · Restricted Project

Apr 16 2019

george.burgess.iv added a comment to D60747: Remove EnableEarlyCSEMemSSA option.

I can't find any users of this flag, so I'm in favor of s/EnableEarlyCSEMemSSA/true/ if that simplifies things.

Apr 16 2019, 4:06 PM · Restricted Project

Apr 12 2019

george.burgess.iv accepted D60634: [MemorySSA] Add previous def to cache when found, even if trivial..

Thanks!

Apr 12 2019, 2:38 PM · Restricted Project

Apr 11 2019

george.burgess.iv accepted D60479: [MemorySSA] Small fix for the clobber limit..

LGTM after a nit is addressed. Thanks!

Apr 11 2019, 2:00 PM · Restricted Project

Mar 29 2019

george.burgess.iv accepted D59966: [MemorySSA] Don't optimize incomplete phis..

LGTM modulo one nit; thanks again!

Mar 29 2019, 12:20 PM · Restricted Project
george.burgess.iv accepted D59569: [MemorySSA] Limit clobber walks..

Thanks again!

Mar 29 2019, 11:31 AM · Restricted Project
george.burgess.iv added a comment to D59966: [MemorySSA] Don't optimize incomplete phis..

Thanks for this!

Mar 29 2019, 11:31 AM · Restricted Project
george.burgess.iv committed rG5456beb94480: Various fixes and additions to creduce-clang-crash.py (authored by george.burgess.iv).
Various fixes and additions to creduce-clang-crash.py
Mar 29 2019, 10:50 AM

Mar 26 2019

george.burgess.iv added a comment to D59725: Additions to creduce script.

Only a few more nits on my side, and this LGTM. WDYT, arichardson?

Mar 26 2019, 6:24 PM · Restricted Project, Restricted Project
george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

(Forgot to refresh before pressing 'Submit', so maybe efriedma's comment answers all of the questions in mine ;) )

Mar 26 2019, 1:41 PM · Restricted Project
george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

We have warnings like -Wdivision-by-zero that take reachability into account: https://godbolt.org/z/3PD-eF. I don't immediately know how it's all done (e.g. in batch because CFG construction is expensive? ...), but looking there for inspiration may be useful.

Mar 26 2019, 1:38 PM · Restricted Project

Mar 25 2019

george.burgess.iv added inline comments to D59725: Additions to creduce script.
Mar 25 2019, 4:15 PM · Restricted Project, Restricted Project
george.burgess.iv added a comment to D59725: Additions to creduce script.

Thanks for this!

Mar 25 2019, 12:00 PM · Restricted Project, Restricted Project

Mar 24 2019

george.burgess.iv added a comment to D59569: [MemorySSA] Limit clobber walks..

Thanks for this!

Mar 24 2019, 11:31 AM · Restricted Project

Mar 20 2019

george.burgess.iv committed rGae84e9ab4908: [MSSA] Delete move ctor; remove dynamic never-moved verification (authored by george.burgess.iv).
[MSSA] Delete move ctor; remove dynamic never-moved verification
Mar 20 2019, 8:12 PM
george.burgess.iv added a comment to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

The reason is that MemorySSA has to be moveable

Mar 20 2019, 7:41 PM · Restricted Project
george.burgess.iv added inline comments to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..
Mar 20 2019, 7:19 PM · Restricted Project
george.burgess.iv committed rGeda3d11d1407: creduce-clang-crash.py: preprocess file + reduce commandline (authored by george.burgess.iv).
creduce-clang-crash.py: preprocess file + reduce commandline
Mar 20 2019, 6:03 PM
george.burgess.iv accepted D59440: add steps to preprocess file and reduce command line args.

LGTM; thanks again!

Mar 20 2019, 4:53 PM · Restricted Project
george.burgess.iv added a comment to D59440: add steps to preprocess file and reduce command line args.

Just a few style nits for you, and this LGTM. I assume rnk and serge-sans-paille are content, so I'm happy to check this in for you once these are addressed.

Mar 20 2019, 3:43 PM · Restricted Project
george.burgess.iv added a comment to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

MSSA bits LGTM (to reiterate, as do the CFLAA bits). Leaving the rest of the patch to the other reviewers

Mar 20 2019, 11:20 AM · Restricted Project
george.burgess.iv accepted D59564: [LICM & MemorySSA] Don't sink/hoist stores in the presence of ordered loads..

LGTM; thanks!

Mar 20 2019, 11:11 AM · Restricted Project

Mar 19 2019

george.burgess.iv added a comment to D59564: [LICM & MemorySSA] Don't sink/hoist stores in the presence of ordered loads..

Thanks for this!

Mar 19 2019, 5:30 PM · Restricted Project
george.burgess.iv added a comment to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

Overall approach LGTM for this selective caching behavior.

Mar 19 2019, 1:52 PM · Restricted Project

Mar 14 2019

george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

This LGTM; feel free to submit after Aaron stamps this.

Mar 14 2019, 1:35 PM · Restricted Project

Mar 12 2019

george.burgess.iv committed rG87565fe7346c: Add a creduce script for clang crashes (authored by george.burgess.iv).
Add a creduce script for clang crashes
Mar 12 2019, 10:50 AM
george.burgess.iv accepted D59118: creduce script for clang crashes.

I think that addresses all of the concerns people have put forward; given rnk's comment about one more round of fixes, this LGTM. Will check this in for you shortly.

Mar 12 2019, 10:32 AM · Restricted Project

Mar 11 2019

george.burgess.iv added a comment to D59118: creduce script for clang crashes.

I think we should do one more round of fixes, we can commit that for you, and then move on to the next steps

Mar 11 2019, 4:48 PM · Restricted Project

Mar 8 2019

george.burgess.iv committed rG4ea679f1f478: [CFLAnders] Fix typo in comment; NFC (authored by george.burgess.iv).
[CFLAnders] Fix typo in comment; NFC
Mar 8 2019, 11:30 AM

Mar 7 2019

george.burgess.iv accepted D58756: Fix typo in comment for function "static void initializeWorkList" in "/lib/Analysis/CFLAndersAliasAnalysis.cpp".

LGTM; thanks again!

Mar 7 2019, 5:52 PM · Restricted Project
george.burgess.iv added a comment to D59118: creduce script for clang crashes.

Thanks for this! Functionally, this looks good. My comments are mostly just simplicity/readability nitpicks.

Mar 7 2019, 5:23 PM · Restricted Project
george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

Looks solid to me overall; just a few nits.

Mar 7 2019, 5:07 PM · Restricted Project

Mar 5 2019

george.burgess.iv added a comment to D58756: Fix typo in comment for function "static void initializeWorkList" in "/lib/Analysis/CFLAndersAliasAnalysis.cpp".

I think @george.burgess.iv is the right person because he appears a lot in git blame :)

Mar 5 2019, 3:05 PM · Restricted Project

Mar 1 2019

george.burgess.iv added a comment to D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics.

Thanks for working on this!

Mar 1 2019, 11:40 AM · Restricted Project

Feb 27 2019

george.burgess.iv accepted D58652: [MemorySSA] Make insertDef insert corresponding phi nodes..

Thanks again!

Feb 27 2019, 12:09 PM · Restricted Project

Feb 26 2019

george.burgess.iv added inline comments to D58652: [MemorySSA] Make insertDef insert corresponding phi nodes..
Feb 26 2019, 2:58 PM · Restricted Project
george.burgess.iv added a comment to D58652: [MemorySSA] Make insertDef insert corresponding phi nodes..

Thanks for this!

Feb 26 2019, 10:55 AM · Restricted Project

Feb 20 2019

george.burgess.iv added a comment to D58047: [LLD][ELF][ARM] Synthesise missing .ARM.exidx sections..

Thank you all for helping with this!

Feb 20 2019, 11:31 AM

Feb 15 2019

george.burgess.iv accepted D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE..

Thanks again!

Feb 15 2019, 2:25 PM · Restricted Project
george.burgess.iv added a reviewer for D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE.: davide.
Feb 15 2019, 1:57 PM · Restricted Project
george.burgess.iv added a comment to D58248: [EarlyCSE & MSSA] Cap the clobbering calls in EarlyCSE..

Thanks for doing this! Just two nits for you :)

Feb 15 2019, 11:54 AM · Restricted Project

Feb 11 2019

george.burgess.iv accepted D57968: [LICM] Cap the clobbering calls in LICM..

Deferring to Chandler's LGTM for the approach + first patch; changes since then LGTM.

Feb 11 2019, 5:32 PM · Restricted Project