In D137762#3969770, @owenpan wrote:

@gedare do you need us to commit this patch on your behalf (using "Gedare Bloom <gedare@rtems.org>")?

I have changed the code as recommended by @owenpan with new unit tests passing, and reverting the modifications to existing unit tests. Someone else may janitor the EXPECT_EQ blocks separately.

• fixup: use simpler logic for handling rparens
• Revert "fixup: port other EXPECT_EQ to verifyFormat"

• FormatTest: restore Input variable to one test

• fixup: unit test formatting

• fixup: replace EXPECT_EQ with verifyFormat
• fixup: port other EXPECT_EQ to verifyFormat

I've added unit tests and confirmed (1) the new tests fail on current main and (2) all unit tests pass with this revision applied.

[100%] Running lit suite /llvm-project/clang/test/Unit

• fixup typo in unit test

Refactor horrible to read logic

add unit tests for BlockIndent

Address review comments

Run tests and fix bad breaks. Fix comment style.

Another test case for function pointers is here:

A test case from the GitHub Issue https://github.com/llvm/llvm-project/issues/57250 is attached here:

Add a fix to enable breaking for continuation after a )(

Allow line breaks in a continuation with BlockIndent after )(