Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 19 2023

asudarsa added a comment to D142047: [opt] Fix static code analysis concerns.
In D142047#4066455, @aeubanks wrote:
In D142047#4066443, @asudarsa wrote:
In D142047#4066364, @aeubanks wrote:

lgtm

do you need me to push this for you?

Yes please. That will be great.

Thanks again

do you have a name/email you'd like to use in the git commit?

Jan 19 2023, 11:33 AM · Restricted Project, Restricted Project
asudarsa added a comment to D142047: [opt] Fix static code analysis concerns.
In D142047#4066364, @aeubanks wrote:

lgtm

do you need me to push this for you?

Jan 19 2023, 10:23 AM · Restricted Project, Restricted Project
asudarsa updated the diff for D142047: [opt] Fix static code analysis concerns.

Based on reviewer's comments, two more code-sites had this issue and have been fixed. Thanks

Jan 19 2023, 10:06 AM · Restricted Project, Restricted Project
asudarsa added inline comments to D142047: [opt] Fix static code analysis concerns.
Jan 19 2023, 7:31 AM · Restricted Project, Restricted Project
asudarsa updated the diff for D142047: [opt] Fix static code analysis concerns.

Thanks a lot for your review. I have updated the review based on your comment. Hope this works.

Jan 19 2023, 7:30 AM · Restricted Project, Restricted Project

Jan 18 2023

asudarsa added a reviewer for D142047: [opt] Fix static code analysis concerns: aeubanks.
Jan 18 2023, 5:01 PM · Restricted Project, Restricted Project
asudarsa retitled D142047: [opt] Fix static code analysis concerns from [NewPMDriver] Fix static code analysis concerns to [opt] Fix static code analysis concerns.
Jan 18 2023, 11:29 AM · Restricted Project, Restricted Project
asudarsa retitled D142047: [opt] Fix static code analysis concerns from [analyzer] Fix static code analysis concerns to [NewPMDriver] Fix static code analysis concerns.
Jan 18 2023, 11:28 AM · Restricted Project, Restricted Project
asudarsa updated the summary of D142047: [opt] Fix static code analysis concerns.
Jan 18 2023, 11:11 AM · Restricted Project, Restricted Project
asudarsa requested review of D142047: [opt] Fix static code analysis concerns.
Jan 18 2023, 11:10 AM · Restricted Project, Restricted Project