Page MenuHomePhabricator
Feed Advanced Search

Mon, Jan 20

ikudrin added a comment to D72695: [MachO] Add a test for detecting reserved unit length..

Thank you! I'll fix that. For some reason, I did not receive the notification from the build bot.

Mon, Jan 20, 11:19 PM · Restricted Project, lld
hctim added a comment to D72695: [MachO] Add a test for detecting reserved unit length..

This test broke the UBSan buildbot here. I've rolled it back for now, but to reproduce the issue should be as simple as adding -DLLVM_USE_SANITIZER=Undefined and running ninja check-lld or make check-lld depending on which tool you use :)

Mon, Jan 20, 10:43 PM · Restricted Project, lld

Thu, Jan 16

tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.
  • Bug fixes
  • clang format
Thu, Jan 16, 5:56 PM · Restricted Project, lld

Wed, Jan 15

rnk added a comment to D70557: [lld][COFF] Add support for /map.

A couple of nits, but I think it looks pretty good, thanks!

Wed, Jan 15, 12:05 PM · Restricted Project, lld
saudi added reviewers for D70557: [lld][COFF] Add support for /map: amccarth, mstorsjo.
Wed, Jan 15, 6:39 AM · Restricted Project, lld
ikudrin closed D72695: [MachO] Add a test for detecting reserved unit length..
Wed, Jan 15, 2:00 AM · Restricted Project, lld

Tue, Jan 14

dblaikie accepted D72695: [MachO] Add a test for detecting reserved unit length..
Tue, Jan 14, 8:22 AM · Restricted Project, lld
ikudrin added a comment to D71546: [MachO] Fix detecting malformed DWARF..

Was this fixing an existing buildbot/test failure? (if not, it should probably have a test? If it did fix an existing failure - could you mention what that failure was?)

Tue, Jan 14, 5:26 AM · Restricted Project, lld
ikudrin created D72695: [MachO] Add a test for detecting reserved unit length..
Tue, Jan 14, 5:16 AM · Restricted Project, lld

Mon, Jan 13

kiszk updated the diff for D72339: [lld] NFC: fix trivial typos in comments.

rebase with master

Mon, Jan 13, 8:49 PM · Restricted Project, lld

Thu, Jan 9

sidneym closed D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Thu, Jan 9, 7:53 AM · Restricted Project, lld

Wed, Jan 8

MaskRay accepted D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Wed, Jan 8, 11:55 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Address testcase issues.

Wed, Jan 8, 11:36 AM · Restricted Project, lld
kiszk retitled D72339: [lld] NFC: fix trivial typos in comments from [lld] fix trivial typos in comments to [lld] NFC: fix trivial typos in comments.
Wed, Jan 8, 2:56 AM · Restricted Project, lld

Tue, Jan 7

MaskRay added inline comments to D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Tue, Jan 7, 2:45 PM · Restricted Project, lld
Eugene.Zelenko added a reviewer for D72339: [lld] NFC: fix trivial typos in comments: ruiu.
Tue, Jan 7, 10:05 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Move hasStaticTlsModel from R_GOT case to the suggested R_GOTPLT case.

Tue, Jan 7, 8:02 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Add config->hasStaticTlsModel in R_GOT case.

Tue, Jan 7, 7:42 AM · Restricted Project, lld

Mon, Jan 6

sidneym added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

  • Does Hexagon have a binutils port or an alternative linker?

The binutils port was never made public. The internal linker can be downloaded with a click-thu license agreement, the same one needed to get to the ABI spec. That linker is a branch of mclinker.

Like @ruiu argued before, a click-thu license agreement may be unacceptable in many environments. I am also concerned whether a click-thru license agreement is considered 100% GPLv3 conformance.

All hexagon work on binutils/gcc was done during the GPLv2 timeframe. The downloadable linker I'm referring to is a branch from the old mclinker project.

Mon, Jan 6, 4:03 PM · Restricted Project, lld
MaskRay added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

  • Does Hexagon have a binutils port or an alternative linker?

The binutils port was never made public. The internal linker can be downloaded with a click-thu license agreement, the same one needed to get to the ABI spec. That linker is a branch of mclinker.

Mon, Jan 6, 3:22 PM · Restricted Project, lld
sidneym added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

  • Does Hexagon have a binutils port or an alternative linker?

The binutils port was never made public. The internal linker can be downloaded with a click-thu license agreement, the same one needed to get to the ABI spec. That linker is a branch of mclinker.

  • Is -pie and -shared used a lot on Hexagon?

-pie isn't but shared is.

  • How is Hexagon's dynamic loader ld.so implemented? Is the source code available?

The code isn't yet available from Qualcomm but we have a port of MUSL and I don't think much more than adding the #defines to reloc.h and the files dlsym.s/tlsdesc.s was done. Nothing weird for hexagon.

  • How is TLS going to be used on Hexagon?

There isn't anything out of the ordinary in how it is used and it is necessary for C++11 support.

  • Is text relocations acceptable?

No. The reason I needed to add the -z notext in the -shared test was because technically the wrong relocations were being used. I did that so that I could condense the IE patch into a single file testcase.

  • Is it really impossible to use a PC-relative GOT address load on Hexagon? R_GOT on EM_386 has severe limitations. EM_X86_64 fixed these issues. (I don't want to see newer architectures behave like it.)

The R_HEX_IE_GOT... are used for shared/pic code. As far as I know the R_HEX_IE_32_6_X/16_X.. are used only when building static code. The ABI has examples for both of these IE static and IE for PIC.

I shall also mention that this is unfortunate.

bool canRelax = config->emachine != EM_ARM &&
                config->emachine != EM_RISCV;

RISC-V TLS has several problems. Its design/implementation was copied from ARM/MIPS. The two architectures really do not provide the best reference for TLS implementations. The RISC-V TLS implementation has several defects. I've reported a few bugs on the binutils bugzilla.

Mon, Jan 6, 2:16 PM · Restricted Project, lld
MaskRay added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

Mon, Jan 6, 11:55 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Update Check names.

Mon, Jan 6, 10:44 AM · Restricted Project, lld
MaskRay closed D72196: [lld] Fix trivial typos in comments.
Mon, Jan 6, 10:26 AM · Restricted Project, lld
MaskRay accepted D72196: [lld] Fix trivial typos in comments.
Mon, Jan 6, 10:25 AM · Restricted Project, lld
Mordante closed D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Mon, Jan 6, 8:38 AM · Restricted Project, lld
saudi added a comment to D70557: [lld][COFF] Add support for /map.

Ping!

Mon, Jan 6, 8:34 AM · Restricted Project, lld
MaskRay accepted D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Mon, Jan 6, 12:26 AM · Restricted Project, lld

Sun, Jan 5

kiszk added a comment to D72196: [lld] Fix trivial typos in comments.

I do not have commit rights to the repository. Could someone commit this change if it is OK?
Kazuaki Ishizaki <ishizaki@jp.ibm.com>

Sun, Jan 5, 11:30 PM · Restricted Project, lld
ruiu accepted D72196: [lld] Fix trivial typos in comments.

LGTM

Sun, Jan 5, 10:34 PM · Restricted Project, lld
nicolasvasilache accepted D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

LGTM

Sun, Jan 5, 12:44 PM · Restricted Project, lld
Mordante updated the diff for D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

Rebased on master. This adds one new fix and removes the ones done by others.

Sun, Jan 5, 5:43 AM · Restricted Project, lld

Sat, Jan 4

Mordante added a comment to D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

For mlir, only mlir/lib/Dialect/Linalg/Utils/Utils.cpp:117:8 needs a fix. I've fixed others in eeef50b1fee91dbe993187324003d2665ceae331.

Sat, Jan 4, 12:52 PM · Restricted Project, lld
MaskRay added a comment to D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

Sat, Jan 4, 12:33 PM · Restricted Project, lld
rriddle accepted D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

MLIR looks fine to me.

Sat, Jan 4, 11:38 AM · Restricted Project, lld
Harbormaster failed remote builds in B43293: Diff 236192 for D72210: [NFC] Fixes -Wrange-loop-analysis warnings!
Sat, Jan 4, 11:30 AM · Restricted Project, lld
merge_guards_bot added a comment to D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

Build artifacts: diff.json, console-log.txt

Sat, Jan 4, 11:30 AM · Restricted Project, lld
Mordante created D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Sat, Jan 4, 11:29 AM · Restricted Project, lld
Eugene.Zelenko added a reviewer for D72196: [lld] Fix trivial typos in comments: ruiu.
Sat, Jan 4, 7:41 AM · Restricted Project, lld

Fri, Jan 3

MaskRay added inline comments to D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Fri, Jan 3, 5:07 PM · Restricted Project, lld
penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

yaml2obj is capable of producing binary .rdata section (which would host CET bit) from hex, but not individual debug directories that would go into it. Looks like all the tests dealing wit debug directories are using pre-built binaries - codeview tests are a good example).

Fri, Jan 3, 4:47 PM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

merge ie and iegot relocations
put the testcase into just a single file.

Fri, Jan 3, 1:39 PM · Restricted Project, lld

Thu, Jan 2

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

LLVM Release Schedule: 10.0.0: Jan 15, 2020: branch, then rc1

Thu, Jan 2, 8:16 PM · Restricted Project, Restricted Project, lld

Wed, Jan 1

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Wed, Jan 1, 6:34 AM · Restricted Project, Restricted Project, lld

Fri, Dec 27

dblaikie added a comment to D71546: [MachO] Fix detecting malformed DWARF..

Was this fixing an existing buildbot/test failure? (if not, it should probably have a test? If it did fix an existing failure - could you mention what that failure was?)

Fri, Dec 27, 2:37 PM · Restricted Project, lld

Thu, Dec 26

lygstate added a comment to D71887: fixes musl default stack size to small..

stack-size 2MB is the default stack size of glibc.

Thu, Dec 26, 1:36 AM · lld, Restricted Project
lygstate created D71887: fixes musl default stack size to small..
Thu, Dec 26, 1:27 AM · lld, Restricted Project

Dec 20 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

@MaskRay I will mail you off-list with one question.

Dec 20 2019, 3:38 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Dec 20 2019, 3:38 PM · Restricted Project, Restricted Project, lld

Dec 17 2019

ikudrin closed D71546: [MachO] Fix detecting malformed DWARF..
Dec 17 2019, 12:09 AM · Restricted Project, lld

Dec 16 2019

probinson accepted D71546: [MachO] Fix detecting malformed DWARF..

LGTM

Dec 16 2019, 6:52 AM · Restricted Project, lld
ikudrin created D71546: [MachO] Fix detecting malformed DWARF..
Dec 16 2019, 6:35 AM · Restricted Project, lld

Dec 13 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Stating it from a different side. If you do not care about GNU ld drop-in replacement property for Linux it's not our business, but we do care about this in NetBSD and we restrict this to our project only (from ELF targets). If you do not care about NetBSD, you shall not care how and whether we use LLD. We try hard to not interfere with Linux looking for a consensus.

Dec 13 2019, 5:16 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

@joerg works on the ELF loader and we just need to wait for him. We wrote our temporary patch, but it was not ideal as the long term solution.

Dec 13 2019, 2:59 PM · Restricted Project, Restricted Project, lld
MaskRay added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.

This seems to be a very serious limitation. I have difficult to understand how such limitation could exist at all, but I think this should be straightforward to fix.

Yes, it is a serious limitation, and no, it's not straightforward to fix. The loader has making a lot of assumptions, especially what PT_LOAD segments to expect and in which order. I've previously made a patch that allowed third segment but it was rejected as apparently 'not doing it the right way'. Almost a year has passed, and I am entirely powerless to fix it.

Dec 13 2019, 2:05 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

We attempted to patch internally LLD rebasing our code for the buildbot purposes but LLD without being used rots quickly, see: https://reviews.llvm.org/D58892

Dec 13 2019, 2:07 AM · Restricted Project, Restricted Project, lld

Dec 12 2019

saudi added a comment to D70557: [lld][COFF] Add support for /map.

Ping! :)

Dec 12 2019, 9:09 AM · Restricted Project, lld
jhenderson added a comment to D70606: LLD: CET shadow stack support on Windows.

On this topic, yaml2obj has COFF support, although I don't know if that's sufficient for your use case here.

yaml2obj does not yet have CET flag support. What is the preferred path in this situation? We can add it, but it would be only used in this test.

I'd prefer enhancing yaml2obj tool so that it can emit the extended characteristics field if it is not too hard.

Dec 12 2019, 2:07 AM · Restricted Project, lld

Dec 11 2019

ruiu added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

lld is not that Linux-centric as you implied in your comment. We have code for FreeBSD, OpenBSD, AMDGPU and Fuchsia (which isn't even a POSIX system), and adding code for NetBSD is OK and is appreciated. However, the thing we've been trying to avoid is to hard-code a platform-specific knowledge such as library paths to the linker. Combined with the fact that lld doesn't provide a way to enable/disable targets at build-time, all ld.lld executables (sometimes installed as /usr/bin/ld) work the same way no matter where they are run on. That helps those who do cross compilation a lot. That is a very appreciated property of our linker, and I don't think I want make an exception for NetBSD. Even on NetBSD, lld should behave the same as running on other kind of hosts.

Dec 11 2019, 11:57 PM · Restricted Project, Restricted Project, lld
ruiu added a comment to D70606: LLD: CET shadow stack support on Windows.

Could you tell me about how you generated has_cet.exe? I wonder if there's a way to create an executable in the test instead of submitting a binary file to the repository.

It is a dummy executable (along the lines of int main() {return 0;}) built with Visual Studio 2019. This was inspired by the existing llvm-readobj PDB test which checks has_pdb.exe.

On this topic, yaml2obj has COFF support, although I don't know if that's sufficient for your use case here.

yaml2obj does not yet have CET flag support. What is the preferred path in this situation? We can add it, but it would be only used in this test.

Dec 11 2019, 7:15 PM · Restricted Project, lld
penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Could you tell me about how you generated has_cet.exe? I wonder if there's a way to create an executable in the test instead of submitting a binary file to the repository.

Dec 11 2019, 10:04 AM · Restricted Project, lld
jhenderson added a comment to D70606: LLD: CET shadow stack support on Windows.

Could you tell me about how you generated has_cet.exe? I wonder if there's a way to create an executable in the test instead of submitting a binary file to the repository.

Dec 11 2019, 3:03 AM · Restricted Project, lld
Herald added a reviewer for D70606: LLD: CET shadow stack support on Windows: jhenderson.

Could you tell me about how you generated has_cet.exe? I wonder if there's a way to create an executable in the test instead of submitting a binary file to the repository.

Dec 11 2019, 12:31 AM · Restricted Project, lld

Dec 6 2019

MaskRay added inline comments to D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Dec 6 2019, 12:52 PM · Restricted Project, lld
sidneym created D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Dec 6 2019, 12:34 PM · Restricted Project, lld

Dec 3 2019

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Can you help me merge this? I don't have commit access.

Dec 3 2019, 1:58 PM · Restricted Project, lld
blackhole12 added a comment to D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

After further testing, this actually doesn't work, but only if you are loading an associated PDB file. I have no idea what's going on, because I don't understand the internals of TypeServerSource, but it's throwing an assertion error at DebugTypes.cpp:191

Dec 3 2019, 9:18 AM · lld, Restricted Project

Dec 2 2019

blackhole12 updated the diff for D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

Update with full context

Dec 2 2019, 10:43 PM · lld, Restricted Project
MaskRay added a comment to D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

@blackhole12 https://llvm.org/docs/GettingStarted.html#sending-patches

Dec 2 2019, 10:12 PM · lld, Restricted Project
blackhole12 updated the diff for D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link().

Moved the clear commands to where @ruiu suggested. I was unable to upload a full context diff because the web interface refuses to work properly.

Dec 2 2019, 10:03 PM · lld, Restricted Project
MaskRay updated subscribers of D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).
Dec 2 2019, 1:30 PM · Restricted Project, Restricted Project, lld
MaskRay added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

If we could get this patch merged, we could build and link the whole LLVM with lld on NetBSD and it would increase the productivity of the bot (better build times). Right now we need to maintain hacks to link at most with 2/3 cores, while 5/6 ones are idling doing nothing due to enormous RAM consumption of GNU ld.

Dec 2 2019, 1:15 PM · Restricted Project, Restricted Project, lld

Nov 30 2019

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Nov 30 2019, 6:13 AM · Restricted Project, Restricted Project, lld

Nov 29 2019

saudi added inline comments to D70557: [lld][COFF] Add support for /map.
Nov 29 2019, 11:11 AM · Restricted Project, lld
saudi updated the diff for D70557: [lld][COFF] Add support for /map.

I changed the code quite a bit.

  • Better match the map file format (added "entry point" line, separate list for static symbols, made header addresses relative to the section instead of absolute)
  • Optimized (parallel sort of symbols etc...), added timers for feedback with /time option
  • Applied fixes previously asked by Rui Ueyama (renaming mapFileMS to mapFile, ...)
Nov 29 2019, 10:49 AM · Restricted Project, lld

Nov 28 2019

amilendra created D70831: [LLD][Doxygen]Add doxygen-lld build target.
Nov 28 2019, 10:02 AM · Restricted Project, lld

Nov 27 2019

ruiu added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 27 2019, 7:41 PM · Restricted Project, lld
penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Thank you!

Nov 27 2019, 4:35 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Incorporate review feedback

Nov 27 2019, 4:26 PM · Restricted Project, lld

Nov 26 2019

ruiu accepted D70606: LLD: CET shadow stack support on Windows.

LGTM with these fixes.

Nov 26 2019, 8:23 PM · Restricted Project, lld
penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 26 2019, 1:44 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Remove unused MinGW flag

Nov 26 2019, 12:43 PM · Restricted Project, lld

Nov 25 2019

mstorsjo added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 25 2019, 11:02 PM · Restricted Project, lld
ruiu added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 25 2019, 6:36 PM · Restricted Project, lld
penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 25 2019, 6:10 PM · Restricted Project, lld

Nov 24 2019

ruiu added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 24 2019, 4:59 PM · Restricted Project, lld

Nov 22 2019

mstorsjo added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 22 2019, 3:01 PM · Restricted Project, lld
penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 22 2019, 2:43 PM · Restricted Project, lld
mstorsjo added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 22 2019, 2:15 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Full(er) patch for the same change.

Nov 22 2019, 2:06 PM · Restricted Project, lld
craig.topper added a comment to D70606: LLD: CET shadow stack support on Windows.

Can you reupload the patch with full context. Using -U999999 on your diff command

Nov 22 2019, 10:52 AM · Restricted Project, lld
penzn created D70606: LLD: CET shadow stack support on Windows.
Nov 22 2019, 10:43 AM · Restricted Project, lld
blackhole12 abandoned D70287: [LLD][COMMON] Fix Incorrect Stream in LLD ErrorHandler.

Addressed by https://reviews.llvm.org/D70292

Nov 22 2019, 2:42 AM · Restricted Project, lld
thopre abandoned D70507: Fix PR44093: use of stale error stream when linking.

James Knight has submitted a very similar change to fix the problem.

Nov 22 2019, 2:10 AM · Restricted Project, lld

Nov 21 2019

ruiu added a comment to D70507: Fix PR44093: use of stale error stream when linking.

James Knight has submitted a very similar change to fix the problem.

Nov 21 2019, 8:33 PM · Restricted Project, lld
ruiu added a comment to D70557: [lld][COFF] Add support for /map.

Thank you for the patch. Overall, I think it is a good thing to add link.exe-compatible /map file output to lld.

Nov 21 2019, 8:33 PM · Restricted Project, lld
saudi created D70557: [lld][COFF] Add support for /map.
Nov 21 2019, 12:22 PM · Restricted Project, lld
thopre updated the summary of D70507: Fix PR44093: use of stale error stream when linking.
Nov 21 2019, 3:11 AM · Restricted Project, lld
thopre updated the diff for D70507: Fix PR44093: use of stale error stream when linking.

Remove enableColors and replace calls to it by the underlying enable_colors()

Nov 21 2019, 3:11 AM · Restricted Project, lld

Nov 20 2019

ruiu added inline comments to D70507: Fix PR44093: use of stale error stream when linking.
Nov 20 2019, 3:58 PM · Restricted Project, lld