Page MenuHomePhabricator
Feed Advanced Search

Today

aganea closed D70378: [LLD][COFF] Cover usage of LLD as a library.
Thu, Sep 24, 12:09 PM · Restricted Project, lld, Restricted Project
avl added inline comments to D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..
Thu, Sep 24, 1:26 AM · debug-info, lld, Restricted Project

Yesterday

rnk accepted D70378: [LLD][COFF] Cover usage of LLD as a library.

Looks good to me, I didn't review very in depth, but I see the test case that we need. :)

Wed, Sep 23, 4:17 PM · Restricted Project, lld, Restricted Project
ayermolo added inline comments to D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..
Wed, Sep 23, 2:58 PM · debug-info, lld, Restricted Project

Tue, Sep 22

mgorny added a comment to D85278: [lld] Support building shared libLLD.so.

Ping.

Tue, Sep 22, 2:48 PM · lld

Mon, Sep 21

amccarth accepted D70378: [LLD][COFF] Cover usage of LLD as a library.

LGTM.

Mon, Sep 21, 8:37 AM · Restricted Project, lld, Restricted Project

Sun, Sep 20

MaskRay added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

@rnk @amccarth Do you have more comments? ☺️

Sun, Sep 20, 10:38 AM · Restricted Project, lld, Restricted Project

Fri, Sep 18

MaskRay added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Pushed this one now.

Just FTR, keep in mind that if LLD is configured this way, most existing ELF tests will fail, as they don't pass any explicit -m parameter. Not sure if it's worth adding such an option to all of them, or just require building with the option in the default state if one wants to work on LLD and actually run tests.

Fri, Sep 18, 10:24 AM · Restricted Project, lld

Thu, Sep 17

avl added a comment to D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..

@ayermolo Hi Alexander, I rebased on latest but did not check whether current size/performance numbers match with reported previously.

Thu, Sep 17, 4:42 AM · debug-info, lld, Restricted Project
avl updated the diff for D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..

rebased.

Thu, Sep 17, 4:21 AM · debug-info, lld, Restricted Project

Tue, Sep 15

ayermolo added a comment to D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..

@avl Would it be possible to rebase this on latest, or is this diff abandoned?

Tue, Sep 15, 4:31 PM · debug-info, lld, Restricted Project

Mon, Sep 14

mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Pushed this one now.

Mon, Sep 14, 11:32 PM · Restricted Project, lld
mstorsjo closed D87418: [LLD] Allow configuring default ld.lld backend.
Mon, Sep 14, 11:13 PM · Restricted Project, lld
MaskRay accepted D87418: [LLD] Allow configuring default ld.lld backend.

LGTM.

Mon, Sep 14, 1:46 PM · Restricted Project, lld
mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Ping @MaskRay

Mon, Sep 14, 12:13 PM · Restricted Project, lld

Fri, Sep 11

mati865 updated the diff for D87418: [LLD] Allow configuring default ld.lld backend.

Updated the diff.

Fri, Sep 11, 3:54 AM · Restricted Project, lld

Thu, Sep 10

MaskRay added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 2:41 PM · Restricted Project, lld
mati865 added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

How widespread are these build systems that parse help output? (Given that it took until now to discover them, I'd venture "not very".)

Thu, Sep 10, 2:39 PM · Restricted Project, lld
MaskRay added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 2:03 PM · Restricted Project, lld
mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.
In D87418#2266652, @pcc wrote:

How widespread are these build systems that parse help output? (Given that it took until now to discover them, I'd venture "not very".) Maybe it would be better to fix them to explicitly pass -m and/or do something that doesn't rely on parsing help output (e.g. just try the flag and see whether it fails).

Thu, Sep 10, 1:45 PM · Restricted Project, lld
pcc added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

How widespread are these build systems that parse help output? (Given that it took until now to discover them, I'd venture "not very".) Maybe it would be better to fix them to explicitly pass -m and/or do something that doesn't rely on parsing help output (e.g. just try the flag and see whether it fails).

Thu, Sep 10, 1:35 PM · Restricted Project, lld
MaskRay added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 1:12 PM · Restricted Project, lld
mati865 updated the diff for D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 12:12 PM · Restricted Project, lld
mati865 added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Thanks for the explanation.

Thu, Sep 10, 12:11 PM · Restricted Project, lld
mati865 updated the diff for D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 12:11 PM · Restricted Project, lld
mstorsjo added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 11:50 AM · Restricted Project, lld
mati865 added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 9:39 AM · Restricted Project, lld
MaskRay added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 9:19 AM · Restricted Project, lld
mati865 updated the diff for D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 7:52 AM · Restricted Project, lld
mstorsjo added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 3:38 AM · Restricted Project, lld
mati865 added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 3:10 AM · Restricted Project, lld

Wed, Sep 9

mstorsjo added reviewers for D87418: [LLD] Allow configuring default ld.lld backend: MaskRay, amccarth, rnk, mstorsjo.

As a concept, this looks sensible to me, similar to how llvm can be configured with a default triple or how clang can have cmake-configurable built-in defaults for linker/stdlib.

Wed, Sep 9, 9:01 PM · Restricted Project, lld
mati865 updated the summary of D87418: [LLD] Allow configuring default ld.lld backend.
Wed, Sep 9, 2:58 PM · Restricted Project, lld
mati865 added a reviewer for D87418: [LLD] Allow configuring default ld.lld backend: lld.
Wed, Sep 9, 2:57 PM · Restricted Project, lld
mati865 requested review of D87418: [LLD] Allow configuring default ld.lld backend.
Wed, Sep 9, 2:56 PM · Restricted Project, lld

Wed, Sep 2

aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

@MaskRay Thank you!

Wed, Sep 2, 9:42 AM · Restricted Project, lld, Restricted Project
MaskRay accepted D70378: [LLD][COFF] Cover usage of LLD as a library.

Looks great!

Wed, Sep 2, 9:40 AM · Restricted Project, lld, Restricted Project
aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Ping! @MaskRay any further comments?

Wed, Sep 2, 7:50 AM · Restricted Project, lld, Restricted Project

Mon, Aug 31

eqqlyz added a watcher for lld: eqqlyz.
Mon, Aug 31, 7:08 PM

Wed, Aug 26

aganea added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Wed, Aug 26, 6:19 AM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Address comments.
Added a CrashRecoveryTest.

Wed, Aug 26, 6:19 AM · Restricted Project, lld, Restricted Project

Tue, Aug 25

mstorsjo closed D86512: [LLD][MinGW] Handle allow-multiple-definition flag.
Tue, Aug 25, 11:38 PM · lld, Restricted Project
mstorsjo closed D86509: [LLD][MinGW] Cleanup Options.td file.
Tue, Aug 25, 11:38 PM · lld, Restricted Project
MaskRay added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Tue, Aug 25, 1:35 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Rebase.
Address @MaskRay's suggestions.
Made safeLldLink a public API and made it possible to provide user-defined stdout/stderr streams.

Tue, Aug 25, 12:26 PM · Restricted Project, lld, Restricted Project

Aug 25 2020

mstorsjo accepted D86512: [LLD][MinGW] Handle allow-multiple-definition flag.

LGTM

Aug 25 2020, 12:17 PM · lld, Restricted Project
mstorsjo accepted D86509: [LLD][MinGW] Cleanup Options.td file.

LGTM

Aug 25 2020, 12:15 PM · lld, Restricted Project
mati865 requested review of D86512: [LLD][MinGW] Handle allow-multiple-definition flag.
Aug 25 2020, 1:42 AM · lld, Restricted Project
mati865 requested review of D86509: [LLD][MinGW] Cleanup Options.td file.
Aug 25 2020, 12:40 AM · lld, Restricted Project

Aug 24 2020

aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

@MaskRay Thanks will do - I still have one last issue I don't understand, maybe you can help?

Aug 24 2020, 12:48 PM · Restricted Project, lld, Restricted Project
MaskRay added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 24 2020, 12:24 PM · Restricted Project, lld, Restricted Project
aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Just fwiw, a smaller patch on the same topic was just committed a few days ago, from D86401. This looks like a bigger and more complete fix for the same issue - but before completing it, pay attention to pick up/remove the fix from D86401 (I see that the same vector already gets cleared by this patch as well).

Aug 24 2020, 12:13 PM · Restricted Project, lld, Restricted Project
mstorsjo added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Just fwiw, a smaller patch on the same topic was just committed a few days ago, from D86401. This looks like a bigger and more complete fix for the same issue - but before completing it, pay attention to pick up/remove the fix from D86401 (I see that the same vector already gets cleared by this patch as well).

Aug 24 2020, 11:49 AM · Restricted Project, lld, Restricted Project
blackhole12 added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 24 2020, 8:45 AM · Restricted Project, lld, Restricted Project
aganea added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 24 2020, 7:58 AM · Restricted Project, lld, Restricted Project

Aug 21 2020

blackhole12 accepted D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 21 2020, 4:31 PM · Restricted Project, lld, Restricted Project
MaskRay added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 21 2020, 3:53 PM · Restricted Project, lld, Restricted Project
aganea added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 21 2020, 3:29 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

As suggested.

Aug 21 2020, 3:28 PM · Restricted Project, lld, Restricted Project

Aug 19 2020

MaskRay added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Mostly looks good. Thanks for working on it!

Aug 19 2020, 3:43 PM · Restricted Project, lld, Restricted Project
aganea updated subscribers of D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 19 2020, 2:44 PM · Restricted Project, lld, Restricted Project
aganea added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Thanks for the feedback @MaskRay @grimar!

Aug 19 2020, 2:42 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

As suggested,

  • Set LLD_IN_TEST=2 (still enabled for COFF only)
  • Remove stdout & stderr for all iterations but the last one.
Aug 19 2020, 2:37 PM · Restricted Project, lld, Restricted Project

Aug 17 2020

grimar added inline comments to D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 17 2020, 2:42 AM · Restricted Project, lld, Restricted Project

Aug 14 2020

MaskRay added reviewers for D70378: [LLD][COFF] Cover usage of LLD as a library: grimar, psmith.
Aug 14 2020, 4:02 PM · Restricted Project, lld, Restricted Project
MaskRay added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Thanks for working on this. I think making lldMain "reentrancy safe" is useful.

Aug 14 2020, 3:43 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Fix clang-(format|tidy)

Aug 14 2020, 3:32 PM · Restricted Project, lld, Restricted Project
aganea updated the summary of D70378: [LLD][COFF] Cover usage of LLD as a library.
Aug 14 2020, 2:54 PM · Restricted Project, lld, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Add support for testing LLD as a library, by running the driver several times in a row when LLD_IN_TEST is defined. The value of LLD_IN_TEST tells how many times LLD should loop (3 times right now).

Aug 14 2020, 2:51 PM · Restricted Project, lld, Restricted Project

Aug 10 2020

int3 closed D81413: [lld-macho] improve handling of -platform_version.
Aug 10 2020, 6:48 PM · Restricted Project, lld
gkm added inline comments to D81413: [lld-macho] improve handling of -platform_version.
Aug 10 2020, 2:47 PM · Restricted Project, lld
gkm updated the diff for D81413: [lld-macho] improve handling of -platform_version.

Add dash to a couple of multi-word platform names

Aug 10 2020, 2:46 PM · Restricted Project, lld
int3 accepted D81413: [lld-macho] improve handling of -platform_version.

lgtm!

Aug 10 2020, 9:58 AM · Restricted Project, lld
gkm updated the diff for D81413: [lld-macho] improve handling of -platform_version.

respond to review feedback

Aug 10 2020, 7:49 AM · Restricted Project, lld

Aug 9 2020

tschuett added a comment to D81413: [lld-macho] improve handling of -platform_version.

Here is v530:
https://opensource.apple.com/tarballs/ld64/ld64-530.tar.gz

Aug 9 2020, 10:43 PM · Restricted Project, lld
gkm added inline comments to D81413: [lld-macho] improve handling of -platform_version.
Aug 9 2020, 9:49 PM · Restricted Project, lld
int3 added inline comments to D81413: [lld-macho] improve handling of -platform_version.
Aug 9 2020, 8:01 AM · Restricted Project, lld

Aug 8 2020

gkm added a comment to D81413: [lld-macho] improve handling of -platform_version.

@tschuett, see D85594 for DriverKit platform addition

Aug 8 2020, 6:25 PM · Restricted Project, lld
tschuett added a comment to D81413: [lld-macho] improve handling of -platform_version.

You can add DriverKit here:
https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/TextAPI/MachO/Platform.h#L33
and here:
https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/BinaryFormat/MachO.h#L499

Aug 8 2020, 9:24 AM · Restricted Project, lld
gkm retitled D81413: [lld-macho] improve handling of -platform_version from lld: improve handling of `-platform_version` to [lld-macho] improve handling of -platform_version.
Aug 8 2020, 9:21 AM · Restricted Project, lld
gkm updated the diff for D81413: [lld-macho] improve handling of -platform_version.

Finish, fix & expand tests

Aug 8 2020, 9:14 AM · Restricted Project, lld
gkm commandeered D81413: [lld-macho] improve handling of -platform_version.
Aug 8 2020, 9:06 AM · Restricted Project, lld

Aug 5 2020

compnerd closed D82252: MachO: support `-syslibroot`.
Aug 5 2020, 8:42 AM · Restricted Project, Restricted Project, lld
mgorny requested review of D85278: [lld] Support building shared libLLD.so.
Aug 5 2020, 12:08 AM · lld

Aug 4 2020

compnerd added inline comments to D82252: MachO: support `-syslibroot`.
Aug 4 2020, 1:28 PM · Restricted Project, Restricted Project, lld
int3 accepted D82252: MachO: support `-syslibroot`.

lgtm modulo those two questions. Thanks!

Aug 4 2020, 10:04 AM · Restricted Project, Restricted Project, lld
compnerd updated the diff for D82252: MachO: support `-syslibroot`.
Aug 4 2020, 9:41 AM · Restricted Project, Restricted Project, lld

Aug 3 2020

compnerd added inline comments to D82252: MachO: support `-syslibroot`.
Aug 3 2020, 5:41 PM · Restricted Project, Restricted Project, lld
int3 added a comment to D82252: MachO: support `-syslibroot`.

search-paths.test needs to be updated too

Aug 3 2020, 11:29 AM · Restricted Project, Restricted Project, lld
int3 added inline comments to D82252: MachO: support `-syslibroot`.
Aug 3 2020, 8:57 AM · Restricted Project, Restricted Project, lld

Aug 1 2020

int3 added a comment to D82252: MachO: support `-syslibroot`.

Oh yeah, don't forget to remove the HelpHidden tag from syslibroot's definition in Options.td

Aug 1 2020, 1:53 PM · Restricted Project, Restricted Project, lld
compnerd requested review of D82252: MachO: support `-syslibroot`.
Aug 1 2020, 9:41 AM · Restricted Project, Restricted Project, lld
compnerd planned changes to D82252: MachO: support `-syslibroot`.
Aug 1 2020, 9:41 AM · Restricted Project, Restricted Project, lld
compnerd updated the diff for D82252: MachO: support `-syslibroot`.

Address review feedback

Aug 1 2020, 9:37 AM · Restricted Project, Restricted Project, lld
compnerd added inline comments to D82252: MachO: support `-syslibroot`.
Aug 1 2020, 9:37 AM · Restricted Project, Restricted Project, lld

Jul 29 2020

dyung abandoned D84885: Make test use a smaller file.

Thanks for the fix!

Jul 29 2020, 3:43 PM · Restricted Project, lld
MaskRay added a comment to D84885: Make test use a smaller file.

Thanks for reporting this issue! That patch fell out of my radar when it was committed. I would slightly change the code construct the test file used. Fixed in ed7bde0e4b40cbf8a7c833fd8240c957fcda176e

Jul 29 2020, 1:04 PM · Restricted Project, lld
dyung requested review of D84885: Make test use a smaller file.
Jul 29 2020, 12:30 PM · Restricted Project, lld

Jul 28 2020

xiangzhangllvm abandoned D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD.
Jul 28 2020, 6:11 PM · Restricted Project, lld
MaskRay requested changes to D78328: [lld] Infer the driver mode from the target..

We went with D78837. This can be closed.

Jul 28 2020, 12:00 AM · Restricted Project, lld