Page MenuHomePhabricator
Feed All Stories

May 18 2019

winksaville added a comment to D62040: [docs] Add new document on building distributions.

I'm trying to test the distribution commands from lines 65-67, I first do the cmake:

$ cd ~/prgs/llvm/llvm-project
$ mkdir build
$ cd build
$ cmake -G Ninja -C ../clang/cmake/caches/DistributionExample.cmake ../llvm
loading initial cache file ../clang/cmake/caches/DistributionExample.cmake
-- The C compiler identification is GNU 8.3.0
-- The CXX compiler identification is GNU 8.3.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
...
-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Configuring done
-- Generating done
-- Build files have been written to: /home/wink/prgs/llvm/llvm-project/build
May 18 2019, 12:50 PM · Restricted Project
hintonda updated the diff for D62091: [CommandLine] Reduce size of Option class.
  • Reduce initial vector/set size to the expected value.
May 18 2019, 12:43 PM · Restricted Project
hintonda updated the summary of D62091: [CommandLine] Reduce size of Option class.
May 18 2019, 12:38 PM · Restricted Project
hintonda retitled D62091: [CommandLine] Reduce size of Option class from [CommandLine] Reduce size of Option class by moving more members into bit field to [CommandLine] Reduce size of Option class.
May 18 2019, 12:38 PM · Restricted Project
lebedev.ri created D62102: [AArch64] Bit-extract with shifted mask - shr+and (UBFX).
May 18 2019, 12:37 PM · Restricted Project
mstorsjo added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

This broke compilation of libtiff for arm, see https://bugs.llvm.org/show_bug.cgi?id=41931 for details.

May 18 2019, 12:32 PM · Restricted Project
hintonda added inline comments to D62091: [CommandLine] Reduce size of Option class.
May 18 2019, 12:19 PM · Restricted Project
hintonda added inline comments to D62091: [CommandLine] Reduce size of Option class.
May 18 2019, 11:58 AM · Restricted Project
beanz added inline comments to D62091: [CommandLine] Reduce size of Option class.
May 18 2019, 11:16 AM · Restricted Project
beanz added inline comments to D62091: [CommandLine] Reduce size of Option class.
May 18 2019, 11:04 AM · Restricted Project
beanz accepted D62091: [CommandLine] Reduce size of Option class.
May 18 2019, 10:58 AM · Restricted Project
beanz added a comment to D62091: [CommandLine] Reduce size of Option class.

The main thing is to make sure that if you have proper integer sized members they are properly aligned and packed, which this seems to do well.

May 18 2019, 10:58 AM · Restricted Project
lebedev.ri committed rG13ac317e4cf9: [NFC][AArch64] Autogenerate bitfield-insert.ll, selectcc-to-shiftand.ll tests (authored by lebedev.ri).
[NFC][AArch64] Autogenerate bitfield-insert.ll, selectcc-to-shiftand.ll tests
May 18 2019, 10:44 AM
lebedevri committed rL361105: [NFC][AArch64] Autogenerate bitfield-insert.ll, selectcc-to-shiftand.ll tests.
[NFC][AArch64] Autogenerate bitfield-insert.ll, selectcc-to-shiftand.ll tests
May 18 2019, 10:44 AM
hctim added a comment to rL361073: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should….

Any chance this could've caused the build breakage starting at http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/14855 ?

May 18 2019, 10:43 AM
al3xtjames added a comment to D61838: [Sema] Suppress additional warnings for C's zero initializer.

Thanks for reviewing! I don't have commit access, so I can't commit this patch myself.

May 18 2019, 10:20 AM · Restricted Project, Restricted Project
thakis added a comment to rL361073: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should….

Any chance this could've caused the build breakage starting at http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/14855 ?

May 18 2019, 10:13 AM
GitHub <noreply@github.com> committed rG73892314806e: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
May 18 2019, 10:04 AM
dylanmckay committed rGe638a8916605: [AVR] Fix 'symbol_relocations.s' MC test (authored by dylanmckay).
[AVR] Fix 'symbol_relocations.s' MC test
May 18 2019, 9:40 AM
dylanmckay committed rL361104: [AVR] Fix 'symbol_relocations.s' MC test.
[AVR] Fix 'symbol_relocations.s' MC test
May 18 2019, 9:40 AM
kees updated the summary of D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.
May 18 2019, 9:40 AM · Restricted Project
kees updated the diff for D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

Rebased to latest LLVM

May 18 2019, 9:24 AM · Restricted Project
aykevl added a comment to D60047: [CaptureTracking] Don't let comparisons against null escape inbounds pointers.

I've updated the code, but there are a few things I'm not so sure about:

May 18 2019, 9:09 AM · Restricted Project
aykevl updated the diff for D60047: [CaptureTracking] Don't let comparisons against null escape inbounds pointers.
  • replace some types with auto
  • update comment for getelementptr inbounds
May 18 2019, 8:57 AM · Restricted Project
rampitec accepted D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.

LGTM

May 18 2019, 8:56 AM · Restricted Project
arsenm added a comment to D61607: Introduce Value::stripPointerCastsSameRepresentation.

To me (someone from outside LLVM), the "keep bit pattern" argument looks confusing. Pointer casts do not necessarily change the bit pattern? In fact, it seems to me that most pointer casts preserve the bit pattern but change the meaning of the pointer (example: address space 1 on AVR which points into flash instead of RAM - no bits are changed with an addrspacecast).

May 18 2019, 8:42 AM · Restricted Project
arsenm created D62101: NewGVN: Handle addrspacecast.
May 18 2019, 8:24 AM
hintonda added a comment to D62091: [CommandLine] Reduce size of Option class.

This is pretty cool. Since these are usually allocated as globals, this is saving pages of dirtied memory.

One implementation thought. What if we group the 16-bit fields together and make them uint16_t then use a uint16_t as the bitfield type for the remaining 15 bits. The performance of the 16-bit fields should be better if they are aligned (not that cl::opt perf really matters).

May 18 2019, 8:19 AM · Restricted Project
aykevl added a comment to D61607: Introduce Value::stripPointerCastsSameRepresentation.

To me (someone from outside LLVM), the "keep bit pattern" argument looks confusing. Pointer casts do not necessarily change the bit pattern? In fact, it seems to me that most pointer casts preserve the bit pattern but change the meaning of the pointer (example: address space 1 on AVR which points into flash instead of RAM - no bits are changed with an addrspacecast). Names like stripTrivialPointerCasts and stripAddressSpaceAndPointerCasts look much more obvious to me. Or did I miss the real intent of the change here?
In other words, I would suggest renaming stripPointerCastsSameBitPattern to stripTrivialPointerCasts.

May 18 2019, 8:09 AM · Restricted Project
arsenm committed rGb04f3258dd6a: GVN: Handle addrspacecast (authored by arsenm).
GVN: Handle addrspacecast
May 18 2019, 7:34 AM
arsenm committed rL361103: GVN: Handle addrspacecast.
GVN: Handle addrspacecast
May 18 2019, 7:33 AM
dtemirbulatov added a comment to D61795: [SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec()..

Looks good to me either.

May 18 2019, 7:01 AM · Restricted Project
Hahnfeld added a comment to D60223: [OpenMP][libomptarget] Enable requires flags for target libraries..

In this patch __tgt_rtl_init_requires does nothing. Do we really want to add the prototype now? If yes, are we sure that we won't need to pass more information in the future? Once we add it, the runtime library must maintain compatibility.

May 18 2019, 6:52 AM · Restricted Project
lebedev.ri committed rGd1be3c446ef8: [NFC][AArch64] Add some ubfx tests with immediates (authored by lebedev.ri).
[NFC][AArch64] Add some ubfx tests with immediates
May 18 2019, 6:48 AM
lebedevri committed rL361102: [NFC][AArch64] Add some ubfx tests with immediates.
[NFC][AArch64] Add some ubfx tests with immediates
May 18 2019, 6:48 AM
lebedev.ri created D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.
May 18 2019, 6:28 AM · Restricted Project
lebedev.ri committed rG98092f37d0dd: UpdateTestChecks: fix AMDGPU handling (authored by lebedev.ri).
UpdateTestChecks: fix AMDGPU handling
May 18 2019, 5:58 AM
lebedev.ri committed rG822b9c971be6: UpdateTestChecks: arm64-eabi handlind (authored by lebedev.ri).
UpdateTestChecks: arm64-eabi handlind
May 18 2019, 5:58 AM
lebedevri committed rL361101: UpdateTestChecks: fix AMDGPU handling.
UpdateTestChecks: fix AMDGPU handling
May 18 2019, 5:57 AM
Diffusion closed D62099: UpdateTestChecks: fix AMDGPU handling.
May 18 2019, 5:57 AM · Restricted Project
lebedevri committed rL361100: UpdateTestChecks: arm64-eabi handlind.
UpdateTestChecks: arm64-eabi handlind
May 18 2019, 5:57 AM
Diffusion closed D62097: UpdateTestChecks: arm64-eabi.
May 18 2019, 5:57 AM · Restricted Project
RKSimon added inline comments to D62024: [InstCombine] fold shuffles of insert_subvectors.
May 18 2019, 5:56 AM · Restricted Project
RKSimon added a reviewer for D62003: Add TargetLoweringInfo hook for explicitly setting the ABI calling convention endianess: efriedma.
May 18 2019, 5:56 AM · Restricted Project
lebedev.ri added a comment to D62097: UpdateTestChecks: arm64-eabi.

LGTM

May 18 2019, 5:56 AM · Restricted Project
lebedev.ri added inline comments to D62099: UpdateTestChecks: fix AMDGPU handling.
May 18 2019, 5:48 AM · Restricted Project
RKSimon added a comment to D61795: [SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec()..

I have no problems with this @ABataev @dtemirbulatov any comments?

May 18 2019, 5:41 AM · Restricted Project
Szelethus requested changes to D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass..

The more I think about this, the more I think it would be great to see this tested :)

May 18 2019, 5:34 AM · Restricted Project, Restricted Project
Flakebi updated the diff for D44077: Clear the stack protector after checking it.

The ssp is now set to zero in the SDAG variant and when a stack guard check function is used. I am not familiar with the selection DAG so please correct me if it can be improved.
I also added a test as requested.

May 18 2019, 5:33 AM · Restricted Project
Kristof Umann <kristof.umann@ericsson.com> committed rGf40c18b628f3: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType (authored by Kristof Umann <kristof.umann@ericsson.com>).
[analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType
May 18 2019, 5:33 AM
Szelethus committed rC361099: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType.
[analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType
May 18 2019, 5:33 AM
Szelethus committed rL361099: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType.
[analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType
May 18 2019, 5:32 AM
Szelethus closed D61570: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType.
May 18 2019, 5:32 AM · Restricted Project, Restricted Project
RKSimon committed rG30aa42e1451f: ScalarExprEmitter::EmitCompoundAssign - fix uninitialized variable warning. (authored by RKSimon).
ScalarExprEmitter::EmitCompoundAssign - fix uninitialized variable warning.
May 18 2019, 5:17 AM
RKSimon committed rL361098: ScalarExprEmitter::EmitCompoundAssign - fix uninitialized variable warning..
ScalarExprEmitter::EmitCompoundAssign - fix uninitialized variable warning.
May 18 2019, 5:17 AM
RKSimon committed rC361098: ScalarExprEmitter::EmitCompoundAssign - fix uninitialized variable warning..
ScalarExprEmitter::EmitCompoundAssign - fix uninitialized variable warning.
May 18 2019, 5:17 AM
arsenm accepted D62099: UpdateTestChecks: fix AMDGPU handling.
May 18 2019, 5:16 AM · Restricted Project
Szelethus added a comment to D62093: [analyzer] List checkers in 3 categories: released, alpha, developer.

Let's come to a consensus on this, and followup patches, but as soon as that's done, this REALLY NEEDS to be documented in the release notes.

May 18 2019, 5:02 AM · Restricted Project, Restricted Project
RKSimon added reviewers for D62099: UpdateTestChecks: fix AMDGPU handling: MaskRay, arsenm.
May 18 2019, 4:44 AM · Restricted Project
RKSimon committed rG3e95568dcf81: MIGChecker - assert we have a non-null LocationContext. NFCI. (authored by RKSimon).
MIGChecker - assert we have a non-null LocationContext. NFCI.
May 18 2019, 4:41 AM
RKSimon committed rL361097: MIGChecker - assert we have a non-null LocationContext. NFCI..
MIGChecker - assert we have a non-null LocationContext. NFCI.
May 18 2019, 4:41 AM
RKSimon committed rC361097: MIGChecker - assert we have a non-null LocationContext. NFCI..
MIGChecker - assert we have a non-null LocationContext. NFCI.
May 18 2019, 4:40 AM
RKSimon committed rG4c146ab8c464: ASTNodeImporter - fix uninitialized variable warnings. NFCI. (authored by RKSimon).
ASTNodeImporter - fix uninitialized variable warnings. NFCI.
May 18 2019, 4:32 AM
RKSimon committed rC361096: ASTNodeImporter - fix uninitialized variable warnings. NFCI..
ASTNodeImporter - fix uninitialized variable warnings. NFCI.
May 18 2019, 4:31 AM
RKSimon committed rL361096: ASTNodeImporter - fix uninitialized variable warnings. NFCI..
ASTNodeImporter - fix uninitialized variable warnings. NFCI.
May 18 2019, 4:30 AM
RKSimon committed rG2b45a70fd6d1: MemCmpExpansion::getCompareLoadPairs - assert we find a comparison diff. NFCI. (authored by RKSimon).
MemCmpExpansion::getCompareLoadPairs - assert we find a comparison diff. NFCI.
May 18 2019, 4:30 AM
RKSimon committed rL361095: MemCmpExpansion::getCompareLoadPairs - assert we find a comparison diff. NFCI..
MemCmpExpansion::getCompareLoadPairs - assert we find a comparison diff. NFCI.
May 18 2019, 4:29 AM
RKSimon accepted D62097: UpdateTestChecks: arm64-eabi.

LGTM

May 18 2019, 3:56 AM · Restricted Project
critson added inline comments to D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.
May 18 2019, 3:48 AM · Restricted Project
critson updated the diff for D62058: [AMDGPU] gfx1010 Avoid SMEM WAR hazard for some s_waitcnt values.

Integrate all cases into switch statement.

May 18 2019, 3:43 AM · Restricted Project
MaskRay added inline comments to D61996: [llvm-objdump][test] Improve testing of some switches #2.
May 18 2019, 3:17 AM · Restricted Project
lebedev.ri added a child revision for D62097: UpdateTestChecks: arm64-eabi: D62099: UpdateTestChecks: fix AMDGPU handling.
May 18 2019, 2:58 AM · Restricted Project
lebedev.ri added a parent revision for D62099: UpdateTestChecks: fix AMDGPU handling: D62097: UpdateTestChecks: arm64-eabi.
May 18 2019, 2:58 AM · Restricted Project
lebedev.ri created D62099: UpdateTestChecks: fix AMDGPU handling.
May 18 2019, 2:57 AM · Restricted Project
MaskRay updated the diff for D62098: [ELF] Fix getRelocTargetVA formulae of R_TLS and R_NEG_TLS.

Reword

May 18 2019, 2:45 AM · Restricted Project
lebedev.ri updated the diff for D62097: UpdateTestChecks: arm64-eabi.

Upload correct diff this time

May 18 2019, 2:33 AM · Restricted Project
MaskRay created D62098: [ELF] Fix getRelocTargetVA formulae of R_TLS and R_NEG_TLS.
May 18 2019, 2:29 AM · Restricted Project
lebedev.ri created D62097: UpdateTestChecks: arm64-eabi.
May 18 2019, 2:25 AM · Restricted Project
chandlerc accepted D58260: [INLINER] allow inlining of blockaddresses if sole uses are callbrs.

LGTM

May 18 2019, 2:06 AM · Restricted Project
sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

@beanz Great doc, thanks! I will see what I could use for Debian/Ubuntu packages (as we have a lot users and packages organized in a specific way, it isn't always easy to make huge changes)

May 18 2019, 1:33 AM · Restricted Project
mgorny created D62096: [lldb] [lit] Driver/TestConvenienceVariables.test requires Python.
May 18 2019, 12:27 AM · Restricted Project

May 17 2019

hliao committed rG63621832da65: Suppress false-positive GCC -Wreturn-type warning. (authored by hliao).
Suppress false-positive GCC -Wreturn-type warning.
May 17 2019, 11:34 PM
hliao committed rL361094: Suppress false-positive GCC -Wreturn-type warning..
Suppress false-positive GCC -Wreturn-type warning.
May 17 2019, 11:34 PM
hliao committed rLLD361094: Suppress false-positive GCC -Wreturn-type warning..
Suppress false-positive GCC -Wreturn-type warning.
May 17 2019, 11:34 PM
EricWF accepted D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

Actually, looking again. This is good.

May 17 2019, 10:42 PM · Restricted Project
EricWF added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

I'll commit this is the morning.

May 17 2019, 10:42 PM · Restricted Project
EricWF requested changes to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

I have some concerns. Please don't commit this.

May 17 2019, 10:34 PM · Restricted Project
EricWF updated the diff for D62095: Cleanup debug mode boilerplate in containers..

More cleanup.

May 17 2019, 9:44 PM
mstorsjo committed rG5fab538e2a97: [MinGW] Set the right updated option help for the updated pdb option. NFC (authored by mstorsjo).
[MinGW] Set the right updated option help for the updated pdb option. NFC
May 17 2019, 9:19 PM
mstorsjo committed rL361093: [MinGW] Set the right updated option help for the updated pdb option. NFC.
[MinGW] Set the right updated option help for the updated pdb option. NFC
May 17 2019, 9:18 PM
mstorsjo committed rLLD361093: [MinGW] Set the right updated option help for the updated pdb option. NFC.
[MinGW] Set the right updated option help for the updated pdb option. NFC
May 17 2019, 9:18 PM
MaskRay abandoned D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used.

Abandon in favor of D62055

May 17 2019, 8:34 PM · Restricted Project
lhames committed rG82c3f3dae0e0: [docs] Fix some RST errors. (authored by lhames).
[docs] Fix some RST errors.
May 17 2019, 8:21 PM
hintonda updated the diff for D62091: [CommandLine] Reduce size of Option class.
  • Remove unneeded bit fields.
May 17 2019, 8:21 PM · Restricted Project
lhames committed rL361092: [docs] Fix some RST errors..
[docs] Fix some RST errors.
May 17 2019, 8:20 PM
EricWF created D62095: Cleanup debug mode boilerplate in containers..
May 17 2019, 8:20 PM
mtrent committed rG07c96ebd9442: Update llvm-nm -s to use a multi-var option (authored by mtrent).
Update llvm-nm -s to use a multi-var option
May 17 2019, 8:16 PM
mtrent committed rL361091: Update llvm-nm -s to use a multi-var option.
Update llvm-nm -s to use a multi-var option
May 17 2019, 8:14 PM
mtrent closed D62070: Update llvm-nm -s to use a multi-var option.
May 17 2019, 8:14 PM · Restricted Project
MaskRay committed rGed2ad77ccb00: [ARM][AArch64] Revert Android Bionic PT_TLS overaligning hack (authored by MaskRay).
[ARM][AArch64] Revert Android Bionic PT_TLS overaligning hack
May 17 2019, 8:14 PM