Page MenuHomePhabricator
Feed All Stories

Today

GitHub <noreply@github.com> committed rG55c7ddb00863: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
Sun, May 19, 10:57 AM
hintonda updated the diff for D62105: [CommandLine] Remove SubCommands SmallPtrSet from the Option class..
  • Add comments, fix auto usage, and minor refactoring.
Sun, May 19, 10:51 AM · Restricted Project
MaskRay created D62107: [ELF] Copy IsPreemptible in replaceSymbol().
Sun, May 19, 9:08 AM · Restricted Project
fhahn added a comment to D60839: [ScheduleDAGInstrs] Compute topological ordering on demand..

I've verified this does not change CodeGen for the test-suite + various external suites. Slightly positive impact on compile-time (-0.1 % geomean speedup for test-suite + SPEC & co, with -O1 on X86)

Sun, May 19, 9:01 AM · Restricted Project
fhahn added inline comments to D60839: [ScheduleDAGInstrs] Compute topological ordering on demand..
Sun, May 19, 9:00 AM · Restricted Project
fhahn updated the diff for D60839: [ScheduleDAGInstrs] Compute topological ordering on demand..

Remove unused MarkDirty.

Sun, May 19, 9:00 AM · Restricted Project
arsenm accepted D61492: AMDGPU: Prepare for explicit absolute relocations in code generation.

LGTM with nit

Sun, May 19, 9:00 AM · Restricted Project
Rakete1111 committed rGe47ae69fa73a: Fix buildbot: Use correct Consume*() for braces. (authored by Rakete1111).
Fix buildbot: Use correct Consume*() for braces.
Sun, May 19, 8:28 AM
Rakete1111 committed rC361120: Fix buildbot: Use correct Consume*() for braces..
Fix buildbot: Use correct Consume*() for braces.
Sun, May 19, 8:28 AM
Rakete1111 committed rL361120: Fix buildbot: Use correct Consume*() for braces..
Fix buildbot: Use correct Consume*() for braces.
Sun, May 19, 8:28 AM
Rakete1111 committed rGf53d1727107e: Added a better diagnostic when using the delete operator with lambdas (authored by Rakete1111).
Added a better diagnostic when using the delete operator with lambdas
Sun, May 19, 8:08 AM
Rakete1111 committed rC361119: Added a better diagnostic when using the delete operator with lambdas.
Added a better diagnostic when using the delete operator with lambdas
Sun, May 19, 8:05 AM
Rakete1111 committed rL361119: Added a better diagnostic when using the delete operator with lambdas.
Added a better diagnostic when using the delete operator with lambdas
Sun, May 19, 8:05 AM
Rakete1111 closed D36357: Added a better diagnostic when using the delete operator with lambdas.
Sun, May 19, 8:05 AM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG0e603ba6f182: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
Sun, May 19, 8:02 AM
spatel accepted D62077: [InstSimplify] Teach fsub -0.0, (fneg X) ==> X about unary fneg.

LGTM

Sun, May 19, 7:43 AM · Restricted Project
spatel committed rG9ef99b4b118b: [InstSimplify] fold fcmp (maxnum, X, C1), C2 (authored by spatel).
[InstSimplify] fold fcmp (maxnum, X, C1), C2
Sun, May 19, 7:24 AM
spatel committed rL361118: [InstSimplify] fold fcmp (maxnum, X, C1), C2.
[InstSimplify] fold fcmp (maxnum, X, C1), C2
Sun, May 19, 7:24 AM
jmolloy added inline comments to D60982: [SimplifyCFG] Use lookup tables when they are more space efficient or a huge speed win..
Sun, May 19, 7:10 AM · Restricted Project
stephenkelly committed rGad3314b14659: Add a Visit overload for DynTypedNode to ASTNodeTraverser (authored by stephenkelly).
Add a Visit overload for DynTypedNode to ASTNodeTraverser
Sun, May 19, 6:05 AM
steveire committed rL361117: Add a Visit overload for DynTypedNode to ASTNodeTraverser.
Add a Visit overload for DynTypedNode to ASTNodeTraverser
Sun, May 19, 6:05 AM
steveire committed rC361117: Add a Visit overload for DynTypedNode to ASTNodeTraverser.
Add a Visit overload for DynTypedNode to ASTNodeTraverser
Sun, May 19, 6:05 AM
GitHub <noreply@github.com> committed rGbf998e7e5ec2: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
Sun, May 19, 5:22 AM
shawnl added inline comments to D60982: [SimplifyCFG] Use lookup tables when they are more space efficient or a huge speed win..
Sun, May 19, 5:16 AM · Restricted Project
dsprenkels updated the diff for D60365: [AVR] Fix codegen for rotate instructions.
  • Use the temporary registers r1 and r0, instead of scavenging spare registers.
    • And update the test case.
  • Add the definition const unsigned ZERO_REGISTER = AVR::R1 for future use.
Sun, May 19, 3:05 AM · Restricted Project
dylanmckay committed rG83338b1059aa: [AVR] Automatically link CRT and libgcc from the system avr-gcc (authored by dylanmckay).
[AVR] Automatically link CRT and libgcc from the system avr-gcc
Sun, May 19, 2:54 AM
dylanmckay committed rC361116: [AVR] Automatically link CRT and libgcc from the system avr-gcc.
[AVR] Automatically link CRT and libgcc from the system avr-gcc
Sun, May 19, 2:54 AM
dylanmckay committed rL361116: [AVR] Automatically link CRT and libgcc from the system avr-gcc.
[AVR] Automatically link CRT and libgcc from the system avr-gcc
Sun, May 19, 2:54 AM
dylanmckay closed D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.
Sun, May 19, 2:54 AM · Restricted Project
void added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

We (Fuchsia) would like to see this landed as well so we can start using this in our kernel.

Sun, May 19, 2:46 AM
mgorny committed rGf8fccb14de2e: [lldb] [lit] Skip more tests when Python is unavailable (authored by mgorny).
[lldb] [lit] Skip more tests when Python is unavailable
Sun, May 19, 2:27 AM
mgorny committed rL361115: [lldb] [lit] Skip more tests when Python is unavailable.
[lldb] [lit] Skip more tests when Python is unavailable
Sun, May 19, 2:25 AM
mgorny committed rLLDB361115: [lldb] [lit] Skip more tests when Python is unavailable.
[lldb] [lit] Skip more tests when Python is unavailable
Sun, May 19, 2:25 AM
MaskRay updated the diff for D62106: [X86] Support -fno-plt __tls_get_addr calls.

.

Sun, May 19, 2:12 AM · Restricted Project
MaskRay updated the diff for D62106: [X86] Support -fno-plt __tls_get_addr calls.

Fix markdown in the description...

Sun, May 19, 2:11 AM · Restricted Project
MaskRay created D62106: [X86] Support -fno-plt __tls_get_addr calls.
Sun, May 19, 2:11 AM · Restricted Project
sebpop updated the diff for D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

Addressed comments from @vitalybuka: factored up the 3 versions and added more tests.
Passes with no new fails ninja check-all on an AArch64 Graviton A1 instance.

Sun, May 19, 1:19 AM · Restricted Project
mmpozulp added a comment to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

BTW, I think STB_GNU_UNIQUE is a misfeature (no clear specification, only (complex) implementation is in glibc, interaction with STB_WEAK/STB_GLOBAL is unclear..).. this feature will highlight the problem :)

Sun, May 19, 12:30 AM · Restricted Project

Yesterday

mgorny committed rG6f356784be7a: [lldb] [lit] Driver/TestConvenienceVariables.test requires Python (authored by mgorny).
[lldb] [lit] Driver/TestConvenienceVariables.test requires Python
Sat, May 18, 11:06 PM
mgorny committed rLLDB361114: [lldb] [lit] Driver/TestConvenienceVariables.test requires Python.
[lldb] [lit] Driver/TestConvenienceVariables.test requires Python
Sat, May 18, 11:06 PM
mgorny committed rL361114: [lldb] [lit] Driver/TestConvenienceVariables.test requires Python.
[lldb] [lit] Driver/TestConvenienceVariables.test requires Python
Sat, May 18, 11:06 PM
mgorny closed D62096: [lldb] [lit] Driver/TestConvenienceVariables.test requires Python.
Sat, May 18, 11:06 PM · Restricted Project
hintonda retitled D62105: [CommandLine] Remove SubCommands SmallPtrSet from the Option class. from [CommandLine} Remove SubCommands SmallPtrSet from the Option class. to [CommandLine] Remove SubCommands SmallPtrSet from the Option class..
Sat, May 18, 10:10 PM · Restricted Project
hintonda added a comment to D62105: [CommandLine] Remove SubCommands SmallPtrSet from the Option class..

The Option class started at 184 bytes, this change, along with D62091, gets it down to 88 types, and reduces bin/opt by over 90k.

Sat, May 18, 10:10 PM · Restricted Project
hintonda created D62105: [CommandLine] Remove SubCommands SmallPtrSet from the Option class..
Sat, May 18, 10:01 PM · Restricted Project
arsenm added a comment to D61607: Introduce an option to stripPointerCasts to force the same bit pattern.

Yes I know it can change the bit pattern. And if it is only about the bit pattern, the name is fine. However, it seems to me that the only difference between stripPointerCastsSameBitPattern and stripPointerCasts is the AS, which may or may not be relevant to the bit pattern. This is confusing: it isn't clear to me from the name stripPointerCastsSameBitPattern whether it may strip any addrspacecast that has the same bit pattern.

Sat, May 18, 9:37 PM · Restricted Project
MaskRay committed rGcb4b3e5cb489: [clangd] Respect WarningsAsErrors configuration for clang-tidy (authored by MaskRay).
[clangd] Respect WarningsAsErrors configuration for clang-tidy
Sat, May 18, 9:17 PM
MaskRay committed rCTE361113: [clangd] Respect WarningsAsErrors configuration for clang-tidy.
[clangd] Respect WarningsAsErrors configuration for clang-tidy
Sat, May 18, 9:16 PM
MaskRay committed rL361113: [clangd] Respect WarningsAsErrors configuration for clang-tidy.
[clangd] Respect WarningsAsErrors configuration for clang-tidy
Sat, May 18, 9:16 PM
MaskRay closed D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy.
Sat, May 18, 9:16 PM · Restricted Project, Restricted Project
MaskRay committed rGc2aded501776: [clangd] Respect clang-tidy suppression comments (authored by MaskRay).
[clangd] Respect clang-tidy suppression comments
Sat, May 18, 9:05 PM
MaskRay committed rL361112: [clangd] Respect clang-tidy suppression comments.
[clangd] Respect clang-tidy suppression comments
Sat, May 18, 9:05 PM
MaskRay committed rCTE361112: [clangd] Respect clang-tidy suppression comments.
[clangd] Respect clang-tidy suppression comments
Sat, May 18, 9:05 PM
MaskRay closed D60953: [clangd] Respect clang-tidy suppression comments.
Sat, May 18, 9:05 PM · Restricted Project, Restricted Project
MaskRay updated subscribers of D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Sat, May 18, 8:48 PM · lld, Restricted Project
MaskRay updated subscribers of D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Sat, May 18, 8:43 PM · lld, Restricted Project
phosek committed rCRT361111: Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Use CMAKE_C_COMPILER_ARG1 in compiler invocation
Sat, May 18, 8:33 PM
GitHub <noreply@github.com> committed rG566116406cdc: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
Sat, May 18, 8:33 PM
phosek committed rGcd78209a3510: Use CMAKE_C_COMPILER_ARG1 in compiler invocation (authored by phosek).
Use CMAKE_C_COMPILER_ARG1 in compiler invocation
Sat, May 18, 8:33 PM
phosek committed rL361111: Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Use CMAKE_C_COMPILER_ARG1 in compiler invocation
Sat, May 18, 8:27 PM
phosek closed D62104: [crt] Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Sat, May 18, 8:27 PM · Restricted Project, Restricted Project
thakis accepted D62104: [crt] Use CMAKE_C_COMPILER_ARG1 in compiler invocation.

As said on IRC, a nicer fix would be to make clang-x86_64-debian-fast and friends use use CMAKE_C_COMPILER_LAUNCHER / CMAKE_CXX_COMPILER_LAUNCHER for ccache instead of setting CC / CXX – but it's also good to make the pre-cmake-3.4 way of configuring this work.

Sat, May 18, 8:27 PM · Restricted Project, Restricted Project
phosek created D62104: [crt] Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Sat, May 18, 8:20 PM · Restricted Project, Restricted Project
MaskRay added a comment to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

BTW, I think STB_GNU_UNIQUE is a misfeature (no clear specification, only (complex) implementation is in glibc, interaction with STB_WEAK/STB_GLOBAL is unclear..).. this feature will highlight the problem :)

Sat, May 18, 8:06 PM · Restricted Project
aykevl added a comment to D61607: Introduce an option to stripPointerCasts to force the same bit pattern.

Yes I know it can change the bit pattern. And if it is only about the bit pattern, the name is fine. However, it seems to me that the only difference between stripPointerCastsSameBitPattern and stripPointerCasts is the AS, which may or may not be relevant to the bit pattern. This is confusing: it isn't clear to me from the name stripPointerCastsSameBitPattern whether it may strip any addrspacecast that has the same bit pattern.

Sat, May 18, 7:54 PM · Restricted Project
dtemirbulatov committed rG2ff72f665417: [SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec(). (authored by dtemirbulatov).
[SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec().
Sat, May 18, 6:29 PM
dinar committed rL361110: [SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec()..
[SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec().
Sat, May 18, 6:28 PM
Diffusion closed D61795: [SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec()..
Sat, May 18, 6:28 PM · Restricted Project
ctopper committed rC361109: [X86] Remove semicolons at the end of intrinsics implemented as macros so they….
[X86] Remove semicolons at the end of intrinsics implemented as macros so they…
Sat, May 18, 6:01 PM
craig.topper committed rG3d7ecc46183d: [X86] Remove semicolons at the end of intrinsics implemented as macros so they… (authored by craig.topper).
[X86] Remove semicolons at the end of intrinsics implemented as macros so they…
Sat, May 18, 6:01 PM
craig.topper committed rG3164b50af7a4: [X86] Remove combineShift function. Just dispatch directly to the handler for… (authored by craig.topper).
[X86] Remove combineShift function. Just dispatch directly to the handler for…
Sat, May 18, 6:01 PM
ctopper committed rL361109: [X86] Remove semicolons at the end of intrinsics implemented as macros so they….
[X86] Remove semicolons at the end of intrinsics implemented as macros so they…
Sat, May 18, 6:01 PM
ctopper committed rL361108: [X86] Remove combineShift function. Just dispatch directly to the handler for….
[X86] Remove combineShift function. Just dispatch directly to the handler for…
Sat, May 18, 5:59 PM
mmpozulp added inline comments to D62054: [llvm-objdump] Make --disassemble-functions imply -d.
Sat, May 18, 5:53 PM · Restricted Project
mmpozulp updated the diff for D62054: [llvm-objdump] Make --disassemble-functions imply -d.

Incorporate feedback from @jhenderson.

Sat, May 18, 5:45 PM · Restricted Project
vporpo added a comment to D61795: [SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec()..

Thanks for the review. Please commit the change.

Sat, May 18, 5:31 PM · Restricted Project
MaskRay added inline comments to D61117: Fix Bug 41353 - unique symbols printed as D instead of u.
Sat, May 18, 5:26 PM · Restricted Project
GitHub <noreply@github.com> committed rG4c5a064f5edc: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
Sat, May 18, 5:25 PM
mmpozulp updated the diff for D61117: Fix Bug 41353 - unique symbols printed as D instead of u.

Squish tests together into one file and use more descriptive section/symbol names. Thanks @jhenderson :)

Sat, May 18, 5:20 PM · Restricted Project
asmith updated the diff for D61687: Update Python tests for lldb-server on Windows.
Sat, May 18, 5:03 PM · Restricted Project
al3xtjames updated the diff for D61838: [Sema] Suppress additional warnings for C's zero initializer.

Switched to using Expr::IgnoreImplicit() instead of manually checking for an ImplicitCastExpression.

Sat, May 18, 5:01 PM · Restricted Project
dtemirbulatov accepted D61795: [SLP] Refactoring of EdgeInfo and UserTreeIdx in buildTree_rec()..

LGTM.

Sat, May 18, 4:41 PM · Restricted Project
rsmith added inline comments to D61838: [Sema] Suppress additional warnings for C's zero initializer.
Sat, May 18, 3:55 PM · Restricted Project
whitequark abandoned D26501: [LICM] Retain load instruction invariant metadata when hoisting.
Sat, May 18, 3:45 PM · Restricted Project
lebedev.ri added a comment to D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.

Looks like AMDGPU changes are neutral too.
And now that i think about it, the AArch64 regression should be solvable (hidable) by an inverse transform.
Should i look into that before or after this patch?

Sat, May 18, 3:45 PM · Restricted Project
whitequark accepted D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.

LGTM

Sat, May 18, 3:45 PM · Restricted Project
arsenm added inline comments to D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.
Sat, May 18, 3:29 PM · Restricted Project
arsenm added inline comments to D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.
Sat, May 18, 3:29 PM · Restricted Project
lebedev.ri updated subscribers of D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.

Looked at changes:

  • I'll leave x86 vector stuff for later. since i actually wanted to look into reverse trasnform, and looked into this only for consistency.
  • I don't know what to do with AArch64 regression. I can hide it with shouldFoldConstantShiftPairToMask(), but it is there regardless (tests added). Thoughts?
  • That leaves AMDGPU?
Sat, May 18, 3:18 PM · Restricted Project
JDevlieghere accepted D62096: [lldb] [lit] Driver/TestConvenienceVariables.test requires Python.
Sat, May 18, 3:13 PM · Restricted Project
phosek abandoned D62039: [GWP-ASan] Add missing dependency on C++ headers.

No longer needed since D62048 has landed.

Sat, May 18, 2:40 PM · Restricted Project, Restricted Project
Daniel added inline comments to D61432: Non-8-bit bytes showcase.
Sat, May 18, 2:20 PM · Restricted Project
lebedev.ri abandoned D62102: [AArch64] Bit-extract with shifted mask - shr+and (UBFX).

Hmm, this isn't it..
Something much more fine-grained missing.

Sat, May 18, 2:15 PM · Restricted Project
hintonda committed rG4b105f53082b: [CommandLine] Reduce size of Option class (authored by hintonda).
[CommandLine] Reduce size of Option class
Sat, May 18, 1:44 PM
dhinton committed rL361107: [CommandLine] Reduce size of Option class.
[CommandLine] Reduce size of Option class
Sat, May 18, 1:44 PM
Diffusion closed D62091: [CommandLine] Reduce size of Option class.
Sat, May 18, 1:44 PM · Restricted Project
zoecarver created D62103: Update shared_ptr tests to match the standard.
Sat, May 18, 1:31 PM
lebedev.ri committed rG1a5d623ded8e: [NFC][AArch64] Autogenerate fcopysign.ll test (authored by lebedev.ri).
[NFC][AArch64] Autogenerate fcopysign.ll test
Sat, May 18, 1:25 PM
lebedevri committed rL361106: [NFC][AArch64] Autogenerate fcopysign.ll test.
[NFC][AArch64] Autogenerate fcopysign.ll test
Sat, May 18, 1:25 PM
lebedev.ri retitled D62102: [AArch64] Bit-extract with shifted mask - shr+and (UBFX) from [AArch64] Bit-extract with shifted mask (UBFX) to [AArch64] Bit-extract with shifted mask - shr+and (UBFX).
Sat, May 18, 12:58 PM · Restricted Project