Page MenuHomePhabricator
Feed All Stories

Today

hokein updated the diff for D63126: [clangd] Implement "prepareRename".

Update the patch, and add tests.

Mon, Jul 22, 6:47 AM · Restricted Project
arsenm added inline comments to D65088: [AMDGPU][RFC] New llvm.amdgcn.ballot intrinsic.
Mon, Jul 22, 6:46 AM · Restricted Project
hokein accepted D65073: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp.

looks good.

Mon, Jul 22, 6:46 AM · Restricted Project
dmgreen accepted D65080: [ARM][LowOverheadLoops] Revert remaining pseudos.

Looks good to me.

Mon, Jul 22, 6:46 AM
fhahn added inline comments to D63459: Loop Cache Analysis.
Mon, Jul 22, 6:46 AM · Restricted Project
labath created D65089: SymbolVendor: Move compile unit handling into the SymbolFile class.
Mon, Jul 22, 6:46 AM
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Ping

Mon, Jul 22, 6:38 AM · Restricted Project
hokein abandoned D65067: [clangd] Fix auto expand not work on "const au^to s = 123;".

as discussed, this is an issue of selection tree (selection tree should give the AutoTypeLoc on const aut^o).

Mon, Jul 22, 6:38 AM · Restricted Project
foad created D65088: [AMDGPU][RFC] New llvm.amdgcn.ballot intrinsic.
Mon, Jul 22, 6:38 AM · Restricted Project
arsenm committed rG4668ea40722b: AMDGPU/GlobalISel: Fix broken tests (authored by arsenm).
AMDGPU/GlobalISel: Fix broken tests
Mon, Jul 22, 6:34 AM
arsenm committed rL366688: AMDGPU/GlobalISel: Fix broken tests.
AMDGPU/GlobalISel: Fix broken tests
Mon, Jul 22, 6:33 AM
grimar planned changes to D64913: [yaml2obj] - Add a support for defining null sections in YAMLs..
Mon, Jul 22, 6:30 AM
samparker accepted D65066: [ARM] Disable MVE fptosi and friends.

Do you see a way that we can make this more efficient in the future..? If so, could we add a comment somewhere because looking at these code sequences, I hope this doesn't come up often!

Mon, Jul 22, 6:30 AM · Restricted Project
RKSimon added a comment to D61371: [benchmark] Fix win32 link on case-sensitive fs.

@lebedev.ri I think you can commandeer this

Mon, Jul 22, 6:30 AM · Restricted Project
grimar updated the diff for D65087: [yaml2elf] - Treat the SHT_NULL section as kind of regular section..
  • A minor simplification.
Mon, Jul 22, 6:30 AM
aaron.ballman committed rG5418be85e854: Update documentation for all CERT checks that correspond to a recommendation. (authored by aaron.ballman).
Update documentation for all CERT checks that correspond to a recommendation.
Mon, Jul 22, 6:25 AM
grimar created D65087: [yaml2elf] - Treat the SHT_NULL section as kind of regular section..
Mon, Jul 22, 6:25 AM
aaronballman committed rL366687: Update documentation for all CERT checks that correspond to a recommendation..
Update documentation for all CERT checks that correspond to a recommendation.
Mon, Jul 22, 6:22 AM
SjoerdMeijer added reviewers for D64744: #pragma clang loop vectorize_predicate(enable|disable): Meinersbur, dmgreen, rscottmanley, aaron.ballman.
Mon, Jul 22, 6:18 AM · Restricted Project
vpykhtin added a comment to D65081: AMDGPU: Start redefining atomic PatFrags.

I'm not sure I can follow all the consequences of this change, but as for tablegen usage it looks good.

Mon, Jul 22, 6:18 AM
arsenm created D65086: AMDGPU/GlobalISel: RegBankSelect struct buffer load/store.
Mon, Jul 22, 6:18 AM
lebedev.ri requested changes to D61371: [benchmark] Fix win32 link on case-sensitive fs.

Submitted
https://github.com/google/benchmark/pull/840
yesterday, it just landed.
Please update README.llvm in these bundled copies to reflect this cherry-pick.
(BTW, there is one more copy, in test-suite, not sure if that matters)

Mon, Jul 22, 6:18 AM · Restricted Project
kren1 added a comment to D62456: [LLVM-C] Improve Bindings to The Internalize Pass.

Is there a plan to commit this? I would like to add the OCaml binding for it ...

Mon, Jul 22, 6:12 AM · Restricted Project
arsenm created D65085: AMDGPU/GlobalISel: Fix flat load/store of pointer types.
Mon, Jul 22, 6:11 AM
arsenm created D65084: AMDGPU/GlobalISel: Remove manual store select code.
Mon, Jul 22, 6:10 AM
arsenm created D65083: AMDGPU/GlobalISel: Select local atomic cmpxchg.
Mon, Jul 22, 6:09 AM
NikolaPrica committed rG0166cff09b1b: Reland [ELF] Loose a condition for relocation with a symbol (authored by NikolaPrica).
Reland [ELF] Loose a condition for relocation with a symbol
Mon, Jul 22, 6:08 AM
NikolaPrica committed rL366686: Reland [ELF] Loose a condition for relocation with a symbol.
Reland [ELF] Loose a condition for relocation with a symbol
Mon, Jul 22, 6:08 AM
arsenm created D65082: AMDGPU/GlobalISel: Allow selection of DS atomicrmw.
Mon, Jul 22, 6:08 AM
arsenm committed rG937d0ee5d8da: AMDGPU/GlobalISel: Remove unnecessary code (authored by arsenm).
AMDGPU/GlobalISel: Remove unnecessary code
Mon, Jul 22, 6:08 AM
arsenm committed rL366685: AMDGPU/GlobalISel: Remove unnecessary code.
AMDGPU/GlobalISel: Remove unnecessary code
Mon, Jul 22, 6:08 AM
arsenm created D65081: AMDGPU: Start redefining atomic PatFrags.
Mon, Jul 22, 6:07 AM
RKSimon added a comment to D65047: [DAGCombine] matchBinOpReduction - add partial reduction matching.

@spatel are you OK with this ?

Mon, Jul 22, 6:07 AM · Restricted Project
SjoerdMeijer added a comment to D64744: #pragma clang loop vectorize_predicate(enable|disable).

Is it intentional that this review has no reviewers listed (like, is this a work in progress you don't expect review on yet)?

Mon, Jul 22, 6:07 AM · Restricted Project
samparker created D65080: [ARM][LowOverheadLoops] Revert remaining pseudos.
Mon, Jul 22, 6:02 AM
hliao added a comment to D64946: [AMDGPU] Fix trivial PHI into SI_END_CF..

when we insert that copy, if we still follow the current logic of phi-elim, that COPY is already inserted after its use (that CF_END).

Mon, Jul 22, 6:02 AM · Restricted Project
Petar.Avramovic added a comment to D65079: [GlobalISel][AArch64] Fix narrowScalar for G_ICMP.

@brzycki
I don't have necessary toolchain for full build, but from error report it is most likely __int128 compare. I made small test that triggers same assert. Does it work now?

Mon, Jul 22, 6:02 AM · Restricted Project
Petar.Avramovic created D65079: [GlobalISel][AArch64] Fix narrowScalar for G_ICMP.
Mon, Jul 22, 5:59 AM · Restricted Project
heijink retitled D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM. from Adds support for formatting NS_CLOSED_ENUM alongside NS_ENUM. to Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..
Mon, Jul 22, 5:59 AM · Restricted Project
dmgreen committed rG8876a312a819: [ARM] Fix for MVE VPT block pass (authored by dmgreen).
[ARM] Fix for MVE VPT block pass
Mon, Jul 22, 5:54 AM
cdevadas committed rG8c5e6fa6575a: Updated the signature for some stack related intrinsics (CLANG) (authored by cdevadas).
Updated the signature for some stack related intrinsics (CLANG)
Mon, Jul 22, 5:54 AM
dmgreen committed rL366684: [ARM] Fix for MVE VPT block pass.
[ARM] Fix for MVE VPT block pass
Mon, Jul 22, 5:54 AM
dmgreen closed D65049: [ARM] Fix for MVE VPT block pass.
Mon, Jul 22, 5:54 AM · Restricted Project
aaron.ballman added a comment to D64744: #pragma clang loop vectorize_predicate(enable|disable).

Is it intentional that this review has no reviewers listed (like, is this a work in progress you don't expect review on yet)?

Mon, Jul 22, 5:54 AM · Restricted Project
heijink updated the diff for D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

Also added support for formatting CF_CLOSED_ENUM.

Mon, Jul 22, 5:54 AM · Restricted Project
cdevadas committed rL366683: Updated the signature for some stack related intrinsics (CLANG).
Updated the signature for some stack related intrinsics (CLANG)
Mon, Jul 22, 5:50 AM
cdevadas closed D64563: Updated the signature for some stack related intrinsics (CLANG).
Mon, Jul 22, 5:50 AM · Restricted Project, Restricted Project
aaron.ballman committed rG1f5712ebb5d4: Revert the change to the [[nodiscard]] feature test macro value. (authored by aaron.ballman).
Revert the change to the [[nodiscard]] feature test macro value.
Mon, Jul 22, 5:50 AM
aaronballman committed rL366682: Revert the change to the [[nodiscard]] feature test macro value..
Revert the change to the [[nodiscard]] feature test macro value.
Mon, Jul 22, 5:49 AM
arsenm created D65078: GlobalISel: Add G_ATOMICRMW_{FADD|FSUB}.
Mon, Jul 22, 5:49 AM
arsenm created D65077: AMDGPU: Correct FP atomic patterns.
Mon, Jul 22, 5:47 AM
RKSimon committed rGb3d719e1cf02: [X86] EltsFromConsecutiveLoads - support common source loads (REAPPLIED) (authored by RKSimon).
[X86] EltsFromConsecutiveLoads - support common source loads (REAPPLIED)
Mon, Jul 22, 5:47 AM
arsenm committed rG8d372008b132: AMDGPU/GlobalISel: Fix tests without asserts (authored by arsenm).
AMDGPU/GlobalISel: Fix tests without asserts
Mon, Jul 22, 5:47 AM
RKSimon committed rL366681: [X86] EltsFromConsecutiveLoads - support common source loads (REAPPLIED).
[X86] EltsFromConsecutiveLoads - support common source loads (REAPPLIED)
Mon, Jul 22, 5:47 AM
balazske added inline comments to D65064: [CrossTU] Add a function to retrieve original source location..
Mon, Jul 22, 5:47 AM · Restricted Project
cdevadas committed rG006cf8c03d77: Added address-space mangling for stack related intrinsics (authored by cdevadas).
Added address-space mangling for stack related intrinsics
Mon, Jul 22, 5:47 AM
arsenm created D65076: AMDGPU: Don't use SDNodeXForm for DS offset output.
Mon, Jul 22, 5:46 AM
arsenm committed rL366680: AMDGPU/GlobalISel: Fix tests without asserts.
AMDGPU/GlobalISel: Fix tests without asserts
Mon, Jul 22, 5:46 AM
cdevadas committed rL366679: Added address-space mangling for stack related intrinsics.
Added address-space mangling for stack related intrinsics
Mon, Jul 22, 5:46 AM
cdevadas closed D64561: Add address-space mangling for stack related intrinsics.
Mon, Jul 22, 5:46 AM · Restricted Project
arsenm created D65075: TableGen/AMDGPU: Avoid emitting "true" predicates .
Mon, Jul 22, 5:46 AM
balazske updated the diff for D65064: [CrossTU] Add a function to retrieve original source location..

Removed ASTImporter from "callback" function.

Mon, Jul 22, 5:46 AM · Restricted Project
arsenm created D65074: AMDGPU: Don't assert on v4f16 arguments to shader calling conventions.
Mon, Jul 22, 5:46 AM
RKSimon committed rGbdb92955200d: [X86][SSE] Add EltsFromConsecutiveLoads test case identified in rL366501 (authored by RKSimon).
[X86][SSE] Add EltsFromConsecutiveLoads test case identified in rL366501
Mon, Jul 22, 5:19 AM
RKSimon committed rL366678: [X86][SSE] Add EltsFromConsecutiveLoads test case identified in rL366501.
[X86][SSE] Add EltsFromConsecutiveLoads test case identified in rL366501
Mon, Jul 22, 5:19 AM
sammccall created D65073: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp.
Mon, Jul 22, 5:11 AM · Restricted Project
RKSimon added a comment to rL366501: Revert [X86] EltsFromConsecutiveLoads - support common source loads.

Thanks - reduced test case:

@h = local_unnamed_addr global i8 0, align 1
define i32 @load_partial_illegal_type() {
  %1 = load <2 x i8>, <2 x i8>* bitcast (i8* @h to <2 x i8>*), align 1
  %2 = shufflevector <2 x i8> %1, <2 x i8> undef, <4 x i32> <i32 0, i32 1, i32 undef, i32 undef>
  %3 = insertelement <4 x i8> %2, i8 2, i32 2
  %4 = bitcast <4 x i8> %3 to i32
  ret i32 %4
}
Mon, Jul 22, 5:06 AM
gchatelet updated the diff for D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
  • Add more division tests
Mon, Jul 22, 5:06 AM · Restricted Project
grimar committed rG13a364e1cc9a: [yaml2obj] - Change how we handle implicit sections. (authored by grimar).
[yaml2obj] - Change how we handle implicit sections.
Mon, Jul 22, 5:03 AM
grimar committed rL366677: [yaml2obj] - Change how we handle implicit sections..
[yaml2obj] - Change how we handle implicit sections.
Mon, Jul 22, 5:03 AM
grimar closed D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 5:03 AM · Restricted Project
SjoerdMeijer accepted D65059: [ARM] Better OR's for MVE compares.

LGTM

Mon, Jul 22, 5:03 AM · Restricted Project
dmgreen added inline comments to D65059: [ARM] Better OR's for MVE compares.
Mon, Jul 22, 4:57 AM · Restricted Project
arsenm added inline comments to D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics.
Mon, Jul 22, 4:57 AM
dmgreen created D65072: [ARM] Rewrite how VCMP are lowered, using a single node.
Mon, Jul 22, 4:57 AM · Restricted Project
dmgreen added a parent revision for D65072: [ARM] Rewrite how VCMP are lowered, using a single node: D65066: [ARM] Disable MVE fptosi and friends.
Mon, Jul 22, 4:57 AM · Restricted Project
dmgreen added a child revision for D65066: [ARM] Disable MVE fptosi and friends: D65072: [ARM] Rewrite how VCMP are lowered, using a single node.
Mon, Jul 22, 4:57 AM · Restricted Project
MaskRay committed rG5d4bc1293cc9: [ARM][test] Improve tests (authored by MaskRay).
[ARM][test] Improve tests
Mon, Jul 22, 4:41 AM
grimar added inline comments to D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
Mon, Jul 22, 4:40 AM
grimar updated the diff for D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
  • Addressed review comments.
Mon, Jul 22, 4:40 AM
MaskRay committed rL366676: [ARM][test] Improve tests.
[ARM][test] Improve tests
Mon, Jul 22, 4:37 AM
jhenderson accepted D64999: [yaml2obj] - Change how we handle implicit sections..

LGTM.

Mon, Jul 22, 4:36 AM · Restricted Project
sammccall committed rG1df6be211e4c: [clangd] Set buffer name for main file. NFCI (authored by sammccall).
[clangd] Set buffer name for main file. NFCI
Mon, Jul 22, 4:15 AM
nhaehnle added inline comments to D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics.
Mon, Jul 22, 4:14 AM
sammccall committed rL366675: [clangd] Set buffer name for main file. NFCI.
[clangd] Set buffer name for main file. NFCI
Mon, Jul 22, 4:11 AM
ilya-biryukov added inline comments to D64863: [clangd] Ignore diags from builtin files.
Mon, Jul 22, 4:11 AM · Restricted Project
MaskRay accepted D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 4:08 AM · Restricted Project
samparker updated the diff for D64616: [ARM][LowOverheadLoops] Fix branch target codegen.
  • renamed the nodes and the search function.
  • added support for other setcc opcodes, other than EQ and NE.
Mon, Jul 22, 4:01 AM
grimar updated the diff for D64999: [yaml2obj] - Change how we handle implicit sections..
  • Addressed review comments.
Mon, Jul 22, 3:45 AM · Restricted Project
rovka added inline comments to D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list.
Mon, Jul 22, 3:45 AM · Restricted Project
arsenm added inline comments to D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics.
Mon, Jul 22, 3:45 AM
jhenderson added a comment to D64281: [Object] Create MutableObject class for doing Object Mutations [Part 1].

Don't forget to update the review summary, following your changes to this patch. It still refers to "UpdatableList" which is obviously out of date. Also don't forget to use the "Update related revisions" option to show the dependency this change has on other reviews.

Don't forget this bit.

Mon, Jul 22, 3:29 AM · Restricted Project
lewis-revill added inline comments to D54296: [RISCV] Lower inline asm constraint A for RISC-V.
Mon, Jul 22, 3:28 AM · Restricted Project
peter.smith added a comment to D65000: [ARM] Set default alignment to 64bits.

Thanks for the update. Will be worth adding some reviewers from Apple to see if this change should be IsAAPCS only. I've no more further comments myself besides a small nit on style.

Mon, Jul 22, 3:26 AM · Restricted Project
ostannard committed rL366669: [IPRA][ARM] Make use of the "returned" parameter attribute.
[IPRA][ARM] Make use of the "returned" parameter attribute
Mon, Jul 22, 3:25 AM
SjoerdMeijer updated the diff for D64744: #pragma clang loop vectorize_predicate(enable|disable).
  • Moved the codegen test to a separate file
  • Added a langref description for this new metadata node.
Mon, Jul 22, 3:21 AM · Restricted Project
kren1 created D65071: [LLVM-C][Ocaml] Add MergeFunctions and DCE pass.
Mon, Jul 22, 3:18 AM · Restricted Project
timcorringham added a comment to D64557: Add llvm.loop.licm.disable metadata.

Some cases can be undone by rematerialization, but not all, and it can involve a lot of effort which increases compile time. The metadata is a pragmatic approach which helps in some cases.

Mon, Jul 22, 3:10 AM · Restricted Project
dnsampaio added a comment to D65000: [ARM] Set default alignment to 64bits.

Set android-abi default to 128. Added tests for android and not-android.

Mon, Jul 22, 3:10 AM · Restricted Project
ilya-biryukov committed rGaf5d3b02fbc6: [clangd] Log input code of failed highlighting tests. NFC (authored by ilya-biryukov).
[clangd] Log input code of failed highlighting tests. NFC
Mon, Jul 22, 3:07 AM