Page MenuHomePhabricator
Feed All Stories

Today

Amir committed rGcb75faf40cb1: [X86][BOLT] Use getOperandType to determine memory access size (authored by Amir).
[X86][BOLT] Use getOperandType to determine memory access size
Thu, Jun 30, 12:26 AM · Restricted Project, Restricted Project
Amir closed D126116: [X86][BOLT] Use getOperandType to determine memory access size.
Thu, Jun 30, 12:25 AM · Restricted Project, Restricted Project
yamt added a comment to D81689: [WebAssembly] New-style command support.

there are use cases for a command to export non-main functions.
eg. malloc/free stuff mentioned in https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/doc/memory_tune.md
this change broke them.

One consideration is that that wamr API doesn't seem compatible with closest thing we have to a spec, which states "Command instances may assume that they will be called from the environment at most once. Command instances may assume that none of their exports are accessed outside the duration of that call.". It's debatable how authoritative that spec is, but the big picture is that there's not currently much clarity on the relationship between LLVM and engines.

  • if "outside the duration of that call" mean it's ok to access exports during the call of _start, the wamr api seems compatible to me. (those malloc/free exports are used during the execution of _start, as far as i understand.)

I'm referring to the "will be called from the environment at most once" part.
If I understand correctly, these malloc/free exports are used to make
additional calls into the instance.

Thu, Jun 30, 12:25 AM · Restricted Project, Restricted Project
nikic committed rG10c531cd5bf0: [SCCP] Simplify CFG in SCCP as well (authored by nikic).
[SCCP] Simplify CFG in SCCP as well
Thu, Jun 30, 12:25 AM · Restricted Project, Restricted Project
nikic closed D128796: [SCCP] Simplify CFG in SCCP as well.
Thu, Jun 30, 12:25 AM · Restricted Project, Restricted Project
jsilvanus added a reviewer for D128808: [AMDGPU] SIMachineScheduler: Add support for several MachineScheduler features: Restricted Project.
Thu, Jun 30, 12:24 AM · Restricted Project, Restricted Project
labath added a comment to D128541: [WIP][lldb][windows] Handle OutputDebugString from debuggee.

I think this should be enabled by default, but none of the logging categories for LLDB_LOG has default active.

Thu, Jun 30, 12:22 AM · Restricted Project, Restricted Project
Mogball added inline comments to D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Thu, Jun 30, 12:13 AM · Restricted Project, Restricted Project, Restricted Project
namhyung requested review of D128883: [yaml2obj] Add optional ProgramHeader.Content.
Thu, Jun 30, 12:12 AM · Restricted Project, Restricted Project
Mogball added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

I'm glad the DenseSets are gone, but my three-ish biggest gripes are:

Thu, Jun 30, 12:11 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D128704: [clang-extdef-mapping] Directly process .ast files.

Clean-ups and error handling.

Thu, Jun 30, 12:05 AM · Restricted Project, Restricted Project
clementval committed rG1e55ec6666fa: [flang] SELECT CASE constructs with character selectors that require a temp (authored by clementval).
[flang] SELECT CASE constructs with character selectors that require a temp
Thu, Jun 30, 12:05 AM · Restricted Project, Restricted Project
clementval closed D128852: [flang] SELECT CASE constructs with character selectors that require a temp.
Thu, Jun 30, 12:04 AM · Restricted Project, Restricted Project
clementval committed rGac1bda21c902: [flang] Fix error message in test (authored by clementval).
[flang] Fix error message in test
Thu, Jun 30, 12:03 AM · Restricted Project, Restricted Project
sgatev committed rG8207c2a66030: [clang][dataflow] Handle `for` statements without conditions (authored by sgatev).
[clang][dataflow] Handle `for` statements without conditions
Thu, Jun 30, 12:02 AM · Restricted Project, Restricted Project
sgatev closed D128833: [clang][dataflow] Handle `for` statements without conditions.
Thu, Jun 30, 12:01 AM · Restricted Project, Restricted Project

Yesterday

pengfei added inline comments to D128571: [X86] Support `_Float16` on SSE2 and up.
Wed, Jun 29, 11:55 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D128571: [X86] Support `_Float16` on SSE2 and up.
Wed, Jun 29, 11:52 PM · Restricted Project, Restricted Project, Restricted Project
CarlosAlbertoEnciso added inline comments to D125778: [llvm-dva] 03 - Logical elements.
Wed, Jun 29, 11:48 PM · Restricted Project, Restricted Project, debug-info
Lewuathe updated the diff for D127476: [mlir][complex] Convert complex.abs to libm.

Enhance docs to clarify the usage of FuncResolver.

Wed, Jun 29, 11:39 PM · Restricted Project, Restricted Project
Lewuathe added inline comments to D127476: [mlir][complex] Convert complex.abs to libm.
Wed, Jun 29, 11:38 PM · Restricted Project, Restricted Project
clementval committed rG6c487002045b: [flang][NFC] Revert message to not implemented yet (authored by clementval).
[flang][NFC] Revert message to not implemented yet
Wed, Jun 29, 11:36 PM · Restricted Project, Restricted Project
critson added a comment to D128800: [AMDGPU] Fix liveness for loops in si-optimize-exec-masking-pre-ra.

@arsenm I hope you don't mind, I merged your tests (and some fixes) from D128110 and D128315 into a new review D128882. We can proceed with the merged review, or I am happy to contribute to reviewing on your existing patch sets.

Wed, Jun 29, 11:35 PM · Restricted Project, Restricted Project
critson requested review of D128882: [AMDGPU] Additional liveness tests for si-optimize-exec-masking-pre-ra.
Wed, Jun 29, 11:32 PM · Restricted Project, Restricted Project
critson committed rGd0f664161575: [AMDGPU] Fix liveness for loops in si-optimize-exec-masking-pre-ra (authored by critson).
[AMDGPU] Fix liveness for loops in si-optimize-exec-masking-pre-ra
Wed, Jun 29, 11:30 PM · Restricted Project, Restricted Project
critson closed D128800: [AMDGPU] Fix liveness for loops in si-optimize-exec-masking-pre-ra.
Wed, Jun 29, 11:29 PM · Restricted Project, Restricted Project
Mogball added a comment to D128866: [mlir] Swap integer range inference to the new framework.

The details can be hidden, but then the analysis would not be composable because... it would be hidden.

Wed, Jun 29, 11:24 PM · Restricted Project, Restricted Project
StephenFan requested review of D128881: [RISCV] Avoid unnecessary stack align.
Wed, Jun 29, 11:19 PM · Restricted Project, Restricted Project
gpetters94 requested review of D128880: Bugfix for grouped convolution op.
Wed, Jun 29, 11:15 PM · Restricted Project, Restricted Project
pengfei updated the diff for D128571: [X86] Support `_Float16` on SSE2 and up.

Address review comments. Thanks @MaskRay !

Wed, Jun 29, 11:14 PM · Restricted Project, Restricted Project, Restricted Project
mwyman updated the diff for D128556: Make Objective-C++ match Objective-C's behavior on implicit ivar access when `self` is shadowed.

Change to use a unit test on the semantic lookup code, rather than a codegen test; I realized the name lookup behavior could be more directly checked by inspecting the internal references in the generated AST to ensure the found "self" is the implicit parameter "self".

Wed, Jun 29, 11:06 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D128571: [X86] Support `_Float16` on SSE2 and up.
Wed, Jun 29, 11:01 PM · Restricted Project, Restricted Project, Restricted Project
mgorny requested review of D128879: [lldb] [llgs] Fix `?` packet response for running threads.
Wed, Jun 29, 11:01 PM · Restricted Project
MaskRay requested changes to D128571: [X86] Support `_Float16` on SSE2 and up.
Wed, Jun 29, 10:59 PM · Restricted Project, Restricted Project, Restricted Project
congzhe updated the diff for D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation.
Wed, Jun 29, 10:49 PM · Restricted Project, Restricted Project, Restricted Project
mgorny requested review of D128878: [lldb] [llgs] Remove not-really-used m_inferior_prev_state.
Wed, Jun 29, 10:40 PM · Restricted Project
congzhe added a comment to rGb941857b40ed: [LoopInterchange] New cost model for loop interchange.

Notice that the assert is hit also when using -passes='print<loop-cache-cost>' instead of running loop-interchange.
So I do not think the problem is in this patch, but rather that perhaps LoopCacheAnalysis is broken in some way?

Thanks for letting me know! Looking into it now.

Will post a patch for loop cache analysis to fix it.

Wed, Jun 29, 10:38 PM · Restricted Project, Restricted Project
NimishMishra added inline comments to D123930: [flang][OpenMP] Lowering support for default clause.
Wed, Jun 29, 10:37 PM · Restricted Project, Restricted Project, Restricted Project
congzhe added a comment to D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation.

Regarding Michael's question that whether SE.getNoopOrAnyExtend() is signed extension or unsigned extension: it is actually well handled in ScalarEvolution::getAnyExtendExpr() where it could do either signed or unsigned extension depending on the actual SCEV type of the value we want to extend. I'm wondering if it answers your question? @Meinersbur

Wed, Jun 29, 10:34 PM · Restricted Project, Restricted Project, Restricted Project
congzhe updated the summary of D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation.
Wed, Jun 29, 10:30 PM · Restricted Project, Restricted Project, Restricted Project
congzhe requested review of D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation.
Wed, Jun 29, 10:27 PM · Restricted Project, Restricted Project, Restricted Project
vadikp-intel updated the diff for D128403: [OpenMP] add 4 custom APIs supporting MSVC OMP codegen.

clang-formatted

Wed, Jun 29, 10:21 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D128465: Zstandard as a second compression method to LLVM.
Wed, Jun 29, 10:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kito-cheng added reviewers for D128875: [RISCV] Precommit testcase to show wrong result of make-compressible optimization: craigblackmore, asb, craig.topper, luismarques, lewis-revill.
Wed, Jun 29, 10:20 PM · Restricted Project, Restricted Project
kito-cheng added reviewers for D128876: [RISCV] Fix wrong register rename for store value during make-compressible optimization: craig.topper, asb, lewis-revill, luismarques, craigblackmore.
Wed, Jun 29, 10:20 PM · Restricted Project, Restricted Project
shchenz added a comment to D128647: [InstructionSimplify] handle denormal constant input for fcmp.

Could you please help to have another look?

Wed, Jun 29, 10:19 PM · Restricted Project, Restricted Project
shchenz updated the diff for D128647: [InstructionSimplify] handle denormal constant input for fcmp.

address comments

Wed, Jun 29, 10:18 PM · Restricted Project, Restricted Project
kito-cheng requested review of D128876: [RISCV] Fix wrong register rename for store value during make-compressible optimization.
Wed, Jun 29, 10:18 PM · Restricted Project, Restricted Project
kito-cheng requested review of D128875: [RISCV] Precommit testcase to show wrong result of make-compressible optimization.
Wed, Jun 29, 10:17 PM · Restricted Project, Restricted Project
Herald added a reviewer for D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668: NoQ.
Wed, Jun 29, 10:11 PM · Restricted Project, Restricted Project
MaskRay committed rG3f17dc89d3f2: [flang][test] Remove RUN COMMAND/EXPECTED OUTPUT/INPUT markers from other… (authored by MaskRay).
[flang][test] Remove RUN COMMAND/EXPECTED OUTPUT/INPUT markers from other…
Wed, Jun 29, 10:11 PM · Restricted Project, Restricted Project
MaskRay committed rGd5d420bb3bcc: [flang][test] Remove RUN LINES?/EXPECTED OUTPUT.*/INPUT markers from test/Driver (authored by MaskRay).
[flang][test] Remove RUN LINES?/EXPECTED OUTPUT.*/INPUT markers from test/Driver
Wed, Jun 29, 10:08 PM · Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thanks Alexey for the review.
This is to address Alexey's comments,

Wed, Jun 29, 10:01 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay committed rG67854f9ed0cd: Use value_or instead of getValueOr. NFC (authored by MaskRay).
Use value_or instead of getValueOr. NFC
Wed, Jun 29, 9:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vadikp-intel updated the diff for D128403: [OpenMP] add 4 custom APIs supporting MSVC OMP codegen.

fixed a build problem

Wed, Jun 29, 9:54 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D128612: RISC-V big-endian support implementation.
Wed, Jun 29, 9:54 PM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
Walter Erquinigo <wallace@fb.com> committed rGa3ec54c66075: [lldb] Fix unused variable warning in TraceHTR (NFC) (authored by kevcadieux).
[lldb] Fix unused variable warning in TraceHTR (NFC)
Wed, Jun 29, 9:41 PM · Restricted Project
Walter Erquinigo <wallace@fb.com> closed D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).
Wed, Jun 29, 9:41 PM · Restricted Project, Restricted Project
BertalanD closed D128093: [lld-macho] Initial support for Linker Optimization Hints.

Made a mistake in the commit message, so it wasn't auto-closed. It has been committed as a3f67f0920ea.

Wed, Jun 29, 9:41 PM · Restricted Project, Restricted Project, Restricted Project
gbenyei added a comment to D128612: RISC-V big-endian support implementation.

lld/ELF change should be dropped from this change. Don't use config->endianness.
I feel sad that for little-endian users who don't use big-endian, every write now is slightly slower due to a check ;-)

Hi, I'm not sure I get it. How will we have a fully functional toolchain, if I don't implement the lld/ELF part?
In LLVM, unlike in GCC, target related decisions happen in runtime. I think it's a high level design decision. While I can understand the pain of LE developers getting a slightly slower linker due to endianness checking, I sure will feel the pain of a BE developer not having a linker...

Please explain why I shouldn't use config->endianness?

See PPC64.cpp. See D96188 how I added aarch64_be support. A set of representative tests should be picked with be tests.
If llvm-project consensus is that we will add big-endian support, I can handle lld/ELF part. I am mostly concerned with this scenarios that some RISC-V folks click LGTM, and the change lands with no test in some areas, or the code somewhat breaks local convention.

Many of the changes in this patch probably should be split. llvm-objcopy and JIT changes definitely needs appropriate tests and the suitable domain reviewers.

Wed, Jun 29, 9:38 PM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
Esme added inline comments to D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..
Wed, Jun 29, 9:30 PM · Restricted Project, Restricted Project
BertalanD committed rGa3f67f0920ea: [lld-macho] Initial support for Linker Optimization Hints (authored by BertalanD).
[lld-macho] Initial support for Linker Optimization Hints
Wed, Jun 29, 9:30 PM · Restricted Project, Restricted Project
Esme updated the diff for D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..

Addressed comments.

Wed, Jun 29, 9:28 PM · Restricted Project, Restricted Project
wallace added a comment to D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).

i can do it right now

Wed, Jun 29, 9:27 PM · Restricted Project, Restricted Project
vadikp-intel added a comment to D128403: [OpenMP] add 4 custom APIs supporting MSVC OMP codegen.
Wed, Jun 29, 9:27 PM · Restricted Project, Restricted Project
mgorny added a comment to D128638: [lldb] [llgs] Add base nonstop fork/vfork tests.

Not sure if this is related to this patch but TestGdbRemote_vContThreads.py is still timing out on the macOS bot:

https://green.lab.llvm.org/green/job/lldb-cmake/44958/console

Wed, Jun 29, 9:25 PM · Restricted Project, Restricted Project
vadikp-intel updated the diff for D128403: [OpenMP] add 4 custom APIs supporting MSVC OMP codegen.

Addressed review comments

Wed, Jun 29, 9:25 PM · Restricted Project, Restricted Project
kevcadieux added a comment to D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).

thanks!

Wed, Jun 29, 9:25 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Addressed of all Jeff's comments.

Wed, Jun 29, 9:23 PM · Restricted Project, Restricted Project, Restricted Project
wallace accepted D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).

thanks!

Wed, Jun 29, 9:20 PM · Restricted Project, Restricted Project
kevcadieux added reviewers for D128874: [lldb] Fix unused variable warning in TraceHTR (NFC): wallace, stella.stamenova.
Wed, Jun 29, 9:04 PM · Restricted Project, Restricted Project
krzysz00 added a comment to D128866: [mlir] Swap integer range inference to the new framework.

So, overall comments - especially since it looks like all the details are basically fine ... wouldn't it still be a good idea to have a wrapper around IntRangeAnalysis that hides the fact that it's a dataflow analysis? Or are we abandoning that wrapper here?

Wed, Jun 29, 9:04 PM · Restricted Project, Restricted Project
kevcadieux requested review of D128874: [lldb] Fix unused variable warning in TraceHTR (NFC).
Wed, Jun 29, 9:03 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D114336: [Polly] Generalize the pattern matching to the case of tensor contractions..
void foo(int n, double C[1024][1024], double A[1024][64][64], double B[64][1024][64]) {
for (int i = 0; i < 1024; i++)
    for (int j = 0; j < 1024; j++)
      for (int l = 0; l < 64; l++)
        for (int w = 0; w < 64; ++w)
           if (w != 0)
             C[i][j] += A[i][l][w] * B[w][j][l];
}

ScopBuilder generates the following memory accesses:

{ Stmt3[i0, i1, i2, i3] -> MemRef2[o0, o1] : o0 = i0 and o1 = i1 }
{ Stmt3[i0, i1, i2, i3] -> MemRef2[o0, o1] : o0 = i0 and o1 = i1 }
{ Stmt3[i0, i1, i2, i3] -> MemRef1[o0, o1, o2] : o0 = 1 + i3 and o1 = i1 and o2 = i2 }
{ Stmt3[i0, i1, i2, i3] -> MemRef0[o0, o1, o2] : o0 = i0 and o1 = i2 and o2 = 1 + i3 }

In the context of the previous discussion, I meant that memory accesses are modified in comparison to the previous considered case.

Where does it come from?

If we look at the domain for the i3 variable, we see that the value 0 from the domain of w-loop is excluded and the loop bounds are modified to start from 0. Memory accesses correspond to this.

Wed, Jun 29, 9:01 PM · Restricted Project, Restricted Project
MaskRay committed rGfd6b9074ca02: [MC] Skip lower-case integer suffixes (authored by ksaunders).
[MC] Skip lower-case integer suffixes
Wed, Jun 29, 8:55 PM · Restricted Project, Restricted Project
MaskRay closed D128871: [MC] Skip lower-case integer suffixes.
Wed, Jun 29, 8:55 PM · Restricted Project, Restricted Project
brooksmoses added a comment to D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285.

We're seeing a number of LLDB test failures from this change. If I'm understanding correctly, that's working by design because we're building the test code with a version of LLVM that's from a revision that's not quite as recent as the LLDB code we're testing.

Wed, Jun 29, 8:48 PM · Restricted Project, Restricted Project
namhyung added a comment to D128705: [llvm-objdump] Create fake sections for a ELF core file.

it seems obj2yaml doesn't show size info in the phdr and because of that yaml2obj sets them to 0. So there's no output... I think it should be fixed first.

Wed, Jun 29, 8:47 PM · Restricted Project, Restricted Project
prehistoric-penguin requested review of D128873: Minor change: eliminate loop.
Wed, Jun 29, 8:44 PM · Restricted Project, Restricted Project
ChuanqiXu committed rG7a567c60f2c8: [Coroutines] Add REQUIRES clause to skip unsupported targets (authored by ChuanqiXu).
[Coroutines] Add REQUIRES clause to skip unsupported targets
Wed, Jun 29, 8:38 PM · Restricted Project, Restricted Project
phosek committed rG75113f3539df: [Driver] Always use --as-needed with libunwind (authored by phosek).
[Driver] Always use --as-needed with libunwind
Wed, Jun 29, 8:34 PM · Restricted Project, Restricted Project
critson added a comment to D128800: [AMDGPU] Fix liveness for loops in si-optimize-exec-masking-pre-ra.

I think D128315 D128110 would also avoid this. I assumed cndmask in a different block was not useful, but presumably you found this in the wild?

Wed, Jun 29, 8:26 PM · Restricted Project, Restricted Project
ksaunders added a comment to D128871: [MC] Skip lower-case integer suffixes.

I do not have push permissions, so please push it on my behalf as Keegan Saunders <keegan@undefinedbehaviour.org>. Thank you.

Wed, Jun 29, 8:24 PM · Restricted Project, Restricted Project
Sockke updated the diff for D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.

Added release notes.

Wed, Jun 29, 8:22 PM · Restricted Project, Restricted Project
pengfei requested review of D128872: [compiler-rt] Enable the new ABI of `_Float16` for Darwin on X86.
Wed, Jun 29, 8:20 PM · Restricted Project, Restricted Project
ChuanqiXu committed rG0b5ead659023: [WebAssembly] Don't set musttail for coroutines when tail-call is not (authored by ChuanqiXu).
[WebAssembly] Don't set musttail for coroutines when tail-call is not
Wed, Jun 29, 8:19 PM · Restricted Project, Restricted Project
ChuanqiXu closed D128794: [WebAssembly] Don't set musttail for coroutines is tail call is not enabled.
Wed, Jun 29, 8:19 PM · Restricted Project, Restricted Project
ChuanqiXu updated the diff for D128794: [WebAssembly] Don't set musttail for coroutines is tail call is not enabled.

Address comments.

Wed, Jun 29, 8:18 PM · Restricted Project, Restricted Project
LuoYuanke committed rGfa8656d28d79: [greedyalloc] Return early when there is no register to allocate. (authored by LuoYuanke).
[greedyalloc] Return early when there is no register to allocate.
Wed, Jun 29, 8:12 PM · Restricted Project, Restricted Project
LuoYuanke closed D128804: [greedyalloc] Return early when there is no register to allocate..
Wed, Jun 29, 8:12 PM · Restricted Project, Restricted Project
vitalybuka committed rZORGcb9141e3459c: [msan] Don't run origins for stage3 after stage2 error (authored by vitalybuka).
[msan] Don't run origins for stage3 after stage2 error
Wed, Jun 29, 8:09 PM · Restricted Project
MaskRay added a comment to D128871: [MC] Skip lower-case integer suffixes.

If you provide name <email>, I can push this for you if you don't have push permission.

Wed, Jun 29, 8:00 PM · Restricted Project, Restricted Project
MaskRay accepted D128871: [MC] Skip lower-case integer suffixes.

Thanks. I changed the subject of this patch. You may call arc amend to amend your local commit message or change it manually.

Wed, Jun 29, 7:59 PM · Restricted Project, Restricted Project
MaskRay retitled D128871: [MC] Skip lower-case integer suffixes from [MC] Skip lower-cased integer suffices to [MC] Skip lower-case integer suffixes.
Wed, Jun 29, 7:58 PM · Restricted Project, Restricted Project
pengfei updated the diff for D128571: [X86] Support `_Float16` on SSE2 and up.

Exclude the ABI change on Darwin platform. Will enable it by a followup.

Wed, Jun 29, 7:54 PM · Restricted Project, Restricted Project, Restricted Project
Miss_Grape added a comment to D128806: [RISCV] Fix wrong position of prologue_end.
Wed, Jun 29, 7:48 PM · Restricted Project, Restricted Project
MaskRay added a comment to D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths.

The description seems unclear to me. Is a riscv64-unknown-linux-gnu GCC installation selected while the requested target triple is riscv64-unknown-elf?
This could be an instance of https://discourse.llvm.org/t/rfc-fix-loose-behaviors-of-clang-target/60272 ([RFC] Fix loose behaviors of Clang –target=) and the right fix may be somewhere upper level.

Wed, Jun 29, 7:46 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D128806: [RISCV] Fix wrong position of prologue_end.

Isn't the problem just that spill/restoreCalleeSavedRegisters need to set FrameSetup/Destroy on their stores/loads (which is also a problem with the generic implementation that we used to use before implementing -msave-restore)?

I think we may remove debug-location instead of adding FrameSetup flags for spill/restoreCalleeSavedRegisters, Because dwarf information is added for debugging convenience, At this stage, people should not care when debugging

Wed, Jun 29, 7:45 PM · Restricted Project, Restricted Project
Chenbing.Zheng updated the diff for D128790: [InstCombine] improve fold for icmp_eq_and to icmp_ult.

address comment

Wed, Jun 29, 7:45 PM · Restricted Project, Restricted Project
MaskRay requested changes to D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths.
Wed, Jun 29, 7:45 PM · Restricted Project, Restricted Project