Page MenuHomePhabricator
Feed All Stories

Today

NoQ added a comment to D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2.

We already have a similar simplification facility in SValBuilder created to solve the similar problem with iterator checkers. It fires up when it knows that the values it works with are limited to roughly 1/4 of their type's range and therefore none of the individual operations over them can potentially overflow (cf. D35109). It's currently off by default because performance was not properly evaluated and none of the on-by-default checkers rely on it. This is currently the intended approach to such issues. It was decided that constructing a custom solver for "non-overflowing but still bounded" arithmetic was not the right thing to do, mostly because it absolutely doesn't correspond to the actual run-time behavior of the program that we're supposed to be modeling.

Sun, Sep 27, 1:43 PM · Restricted Project
tdeo requested review of D88383: [clangd] Add a tweak for filling in enumerators of a switch statement..
Sun, Sep 27, 12:49 PM · Restricted Project, Restricted Project
xbolva00 committed rG155ac333945d: [BuildLibCalls] Add noalias for strcat and stpcpy (authored by xbolva00).
[BuildLibCalls] Add noalias for strcat and stpcpy
Sun, Sep 27, 12:39 PM
xbolva00 closed D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.
Sun, Sep 27, 12:39 PM · Restricted Project
jhuber6 committed rG0103df7903b3: [OpenMP] Add Missing _static Director for OpenMP Documentation (authored by jhuber6).
[OpenMP] Add Missing _static Director for OpenMP Documentation
Sun, Sep 27, 12:37 PM
nikic committed rG01bde7310bb9: [CVP] Remove unnecessary block splits in tests (NFC) (authored by nikic).
[CVP] Remove unnecessary block splits in tests (NFC)
Sun, Sep 27, 11:57 AM
dmgreen added a comment to D84679: [VPlan] Disconnect VPValue and VPUser..

I experimented a bit more and came up with another alternative: allow VPValue to model 3 different things: 1) concrete VPValues, 2) sub VPValues and 3) virtual VPValue: D88380

Managing those 3 in VPValue directly simplifies things further down a bit and I put up 2 more follow-on patches that turn VPReciepBase into a VPValue (D88379) and then also a VPUser (D88378). The last one also contains a unit test that looks upwards & downwards along the def-use chains. Note that we should probably move most/all remaining recipes to be VPValues and manage operands as VPUser before the last 2 patches.

Overall this probably results in a simpler structure overall. If we want, we could then also fold VPUser into VPRecipeBase.

Sun, Sep 27, 11:55 AM · Restricted Project
dmgreen requested review of D88382: [VPlan] Turn VPReductionRecipe into a VPValue.
Sun, Sep 27, 11:53 AM · Restricted Project
mehdi_amini accepted D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

Awesome, thanks!

Sun, Sep 27, 11:47 AM · Restricted Project
nikic committed rGfe79061be2b2: [LVI][CVP] Use block value when simplifying icmps (authored by nikic).
[LVI][CVP] Use block value when simplifying icmps
Sun, Sep 27, 11:33 AM
nikic closed D69686: [LVI][CVP] Use block value when simplifying icmps.
Sun, Sep 27, 11:33 AM · Restricted Project
RKSimon added a comment to D87912: [X86] Use shuffle to widen truncate of 128-bit and smaller vectors.

I'm not convinced this should be necessary - although it does seem to show some missed opportunities in truncateVectorWithPACK because we bail if the destination vector size < 64 bits - fixing that would avoid many of ISD::TRUCATION cases in ReplaceNodeResults

Sun, Sep 27, 11:32 AM · Restricted Project
Mordante added inline comments to D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels.
Sun, Sep 27, 11:28 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS.
Sun, Sep 27, 11:18 AM · Restricted Project
MaskRay committed rG50bd71e1d727: [NewPM] Port ConstraintElimination to the new pass manager (authored by MaskRay).
[NewPM] Port ConstraintElimination to the new pass manager
Sun, Sep 27, 11:12 AM
MaskRay closed D88365: Port ConstraintElimination to the new pass manager.
Sun, Sep 27, 11:12 AM · Restricted Project
MaskRay added inline comments to D88365: Port ConstraintElimination to the new pass manager.
Sun, Sep 27, 11:07 AM · Restricted Project
RKSimon added a reviewer for D87976: Support the division-by-constant strength reduction for more integer types: nhaehnle.

Adding @nhaehnle who tried something similar at D24822

Sun, Sep 27, 10:48 AM · Restricted Project
CarolineConcatto added a reviewer for D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`: awarzynski.
Sun, Sep 27, 10:41 AM · Restricted Project
CarolineConcatto updated the diff for D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`.

Fix typos

Sun, Sep 27, 10:40 AM · Restricted Project
Saleniece added a comment to rG7b782062b4d5: [InstCombine] Simplify code. NFCI..

saleniece

Sun, Sep 27, 10:40 AM
CarolineConcatto requested review of D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`.
Sun, Sep 27, 10:33 AM · Restricted Project
Saleniece added a comment to D85987: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on.

whats is its can anyone explain why I receiving it

Sun, Sep 27, 10:31 AM · Restricted Project
jdoerfert added a comment to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Please upload with full context

Sun, Sep 27, 10:27 AM · Restricted Project
Mordante updated the diff for D87561: [Sema] List conversion validate character array.

Addresses the review comments.
Adds an extra test case to test whether the proper overload is called. The proper overload is a bit of a surprise so when the expected behaviour changes the overload test can be adjusted.

Sun, Sep 27, 10:26 AM · Restricted Project
jdoerfert added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

Needs a rebase.

Sun, Sep 27, 10:23 AM · Restricted Project
jdoerfert added a comment to D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

In what situation do we generate mustprogress function attributes now? I was expecting them in clang/test/CodeGen/attr-mustprogress.cpp but did not see any.

Sun, Sep 27, 10:19 AM · Restricted Project
jdoerfert added inline comments to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Sun, Sep 27, 10:15 AM · Restricted Project
bkramer committed rG7b782062b4d5: [InstCombine] Simplify code. NFCI. (authored by bkramer).
[InstCombine] Simplify code. NFCI.
Sun, Sep 27, 10:12 AM
jdoerfert accepted D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.

LGTM

Sun, Sep 27, 10:06 AM · Restricted Project
jdoerfert added reviewers for D82703: [InstCombine] convert assumes to operand bundles: spatel, lebedev.ri, xbolva00, efriedma, fhahn.
Sun, Sep 27, 10:05 AM · Restricted Project
nikic committed rG4f6e11948c37: [CVP] Make srem test more robust (NFC) (authored by nikic).
[CVP] Make srem test more robust (NFC)
Sun, Sep 27, 9:57 AM
jdoerfert added a comment to D88353: [BasicAA] Integrate MaxObjSize for NoAlias.

We need new tests specifically for this. Using the maxobjsize attribute especially

Sun, Sep 27, 9:54 AM · Restricted Project
jdoerfert accepted D87984: [BuildLibCalls] Add noundef to the returned pointers of allocators and argument of free.

LGTM. I think this is the right way to handle this. the size can be partially undef (="non-deterministic & variable") but everything else better is not.

Sun, Sep 27, 9:49 AM · Restricted Project
Mordante added inline comments to D87561: [Sema] List conversion validate character array.
Sun, Sep 27, 9:47 AM · Restricted Project
mehdi_amini added inline comments to D88376: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax.
Sun, Sep 27, 9:44 AM · Restricted Project
fhahn added a comment to D84679: [VPlan] Disconnect VPValue and VPUser..

Thanks for sharing. As mentioned earlier, the main reason at the moment is to ensure a step-by-step transition and once all recipes are migrated the common class can be hoisted to VPRecipeBase. I hope the explanation makes sense.

Like I said I'm happy that we are moving towards the ability to do this better. It will be good to see VPlan being able to start to make some real improvements! If we are happy enough with this way of doing things, at least currently, then I can go and make some more sensibly sized patches :)

Sun, Sep 27, 9:33 AM · Restricted Project
fhahn updated the summary of D88380: [VPlan] Extend VPValue to also model sub- & 'virtual' values..
Sun, Sep 27, 9:28 AM · Restricted Project
nikic added inline comments to D69686: [LVI][CVP] Use block value when simplifying icmps.
Sun, Sep 27, 9:25 AM · Restricted Project
nikic committed rG709d03f8af4d: [LVI] Clarify getValueAt/getValueInBlock doc comments (NFC) (authored by nikic).
[LVI] Clarify getValueAt/getValueInBlock doc comments (NFC)
Sun, Sep 27, 9:24 AM
aaron.ballman updated the diff for D88333: Better diagnostics for anonymous bit-fields with attributes or an initializer.

I've updated the patch to continue to reject attributes on anonymous bit-fields, but with a better diagnostic. In addition, I changed how we handle anonymous bit-fields with an initializer (based on discussion on the Core reflector) -- instead of rejecting the construct as a semantic issue, I reject it at the parser level with a similar diagnostic (I went with "in-class initializer" because that's used by other parser diagnostics, but I'm fine with either formulation).

Sun, Sep 27, 9:20 AM
fhahn requested review of D88380: [VPlan] Extend VPValue to also model sub- & 'virtual' values..
Sun, Sep 27, 9:16 AM · Restricted Project
fhahn requested review of D88379: [VPlan] Make VPRecipeBase a VPValue (WIP)..
Sun, Sep 27, 9:16 AM · Restricted Project
fhahn requested review of D88378: [VPlan] Make VPUser a subclass of VPValue again (WIP)..
Sun, Sep 27, 9:15 AM · Restricted Project
nikic committed rG9b959b59dfaf: [LVI] Require context instruction in external API (NFCI) (authored by nikic).
[LVI] Require context instruction in external API (NFCI)
Sun, Sep 27, 9:07 AM
nikic committed rGc8abf1c12dc3: [CVP] Pass context instruction when narrowing div/rem (authored by nikic).
[CVP] Pass context instruction when narrowing div/rem
Sun, Sep 27, 8:52 AM
RKSimon committed rG2d7a12f4ecfb: [X86] Add some basic i128 udiv test coverage (authored by RKSimon).
[X86] Add some basic i128 udiv test coverage
Sun, Sep 27, 8:07 AM
RKSimon committed rGd9499c88d19b: [X86] Regenerate i128 sdiv tests and add i686 coverage. (authored by RKSimon).
[X86] Regenerate i128 sdiv tests and add i686 coverage.
Sun, Sep 27, 8:07 AM
Paul-C-Anagnostopoulos closed D88237: [TableGen] Add/edit Doxygen comments to match "TableGen Backend Developer's Guide".
Sun, Sep 27, 7:42 AM · Restricted Project
fhahn added a comment to D69686: [LVI][CVP] Use block value when simplifying icmps.

LGTM as long as this is not too expensive in terms of compile-time, thanks!

Sun, Sep 27, 7:24 AM · Restricted Project
spatel committed rG816b0a9c9f46: [CostModel] add cl option to check size and latency costs; NFC (authored by spatel).
[CostModel] add cl option to check size and latency costs; NFC
Sun, Sep 27, 6:56 AM
yaxunl requested review of D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler.
Sun, Sep 27, 6:53 AM
spatel committed rG645c53a9d923: [ValueTracking] enhance isKnownNeverInfinity to understand sitofp (authored by spatel).
[ValueTracking] enhance isKnownNeverInfinity to understand sitofp
Sun, Sep 27, 6:03 AM
spatel committed rG71f25ac8ca5d: [InstSimplify] add tests for fcmp with casted op; NFC (authored by spatel).
[InstSimplify] add tests for fcmp with casted op; NFC
Sun, Sep 27, 6:03 AM
aaron.ballman added inline comments to D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels.
Sun, Sep 27, 6:03 AM · Restricted Project
Ayal added inline comments to D87679: [LV] Unroll factor is expected to be > 0.
Sun, Sep 27, 6:00 AM · Restricted Project
aaron.ballman committed rGde55ebe3bbc7: Typo fix; NFC (authored by aaron.ballman).
Typo fix; NFC
Sun, Sep 27, 5:31 AM
nagisa added inline comments to D87976: Support the division-by-constant strength reduction for more integer types.
Sun, Sep 27, 5:04 AM · Restricted Project
kiranktp requested review of D88376: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax.
Sun, Sep 27, 4:58 AM · Restricted Project
avl committed rGababcd2ab491: [llvm-objcopy][NFC] refactor error handling. part 2. (authored by avl).
[llvm-objcopy][NFC] refactor error handling. part 2.
Sun, Sep 27, 4:22 AM
avl closed D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Sun, Sep 27, 4:22 AM · Restricted Project
fhahn accepted D87679: [LV] Unroll factor is expected to be > 0.

LGTM, thanks. Suggestion inline, but quite subjective, so feel free to ignore.

Sun, Sep 27, 4:02 AM · Restricted Project
teemperor added a comment to D88123: Add the ability to write 'target stop-hooks' in Python.

This also doesn't work on my macOS system:

FAIL: LLDB (/Users/teemperor/1llvm/rel/bin/clang-x86_64) :: test_stop_hooks_scripted_return_false (TestStopHookScripted.TestStopHooks)
======================================================================
FAIL: test_stop_hooks_scripted_return_false (TestStopHookScripted.TestStopHooks)
   Test that the returning False from a stop hook works
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/teemperor/1llvm/llvm-project/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py", line 54, in test_stop_hooks_scripted_return_false
    self.do_test_auto_continue(True)
  File "/Users/teemperor/1llvm/llvm-project/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py", line 91, in do_test_auto_continue
    self.assertEqual("main", func_name, "Didn't stop at the expected function.")
AssertionError: 'main' != 'step_out_of_me'
- main+ step_out_of_me : Didn't stop at the expected function.
Config=x86_64-/Users/teemperor/1llvm/rel/bin/clang
----------------------------------------------------------------------
Sun, Sep 27, 3:39 AM · Restricted Project
teemperor committed rGe779427757f2: Fix MIPS and MIPS64 ABI to use ConstString in their register info arrays. (authored by tatsuo).
Fix MIPS and MIPS64 ABI to use ConstString in their register info arrays.
Sun, Sep 27, 3:37 AM
teemperor closed D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..
Sun, Sep 27, 3:37 AM · Restricted Project
teemperor added a comment to D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..

Done. Thanks for the patch!

Sun, Sep 27, 3:36 AM · Restricted Project
foad updated the diff for D87502: [DAGCombiner] Use known bits to fold extract_vector_elt with const index.

Rebase after D88225.

Sun, Sep 27, 3:36 AM · Restricted Project
tatsuo added a comment to D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..

@teemperor Thanks for the quick review and context!
I don't have commit access, that'd be great if you could merge it in.

Sun, Sep 27, 3:35 AM · Restricted Project
fhahn added inline comments to D88353: [BasicAA] Integrate MaxObjSize for NoAlias.
Sun, Sep 27, 3:25 AM · Restricted Project
teemperor accepted D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..

To clarify the description a bit: RegInfoBasedABI::GetRegisterInfoByName is comparing the name/alt_name by doing a const char * pointer value comparison. That only works if both strings that are compared are coming from a ConstString. Since b0060c3a7868ef026d95d0cf8a076791ef74f474 GetRegisterInfoByName is checking with an assert that both C strings came from a ConstString (which is failing as these ABI implementation changed here are lacking the ConstString'ification code).

Sun, Sep 27, 3:14 AM · Restricted Project
fhahn accepted D88365: Port ConstraintElimination to the new pass manager.

Thanks for adding NPM support! Not sure if all tests should be also updated to add NPM run-lines.

Sun, Sep 27, 3:06 AM · Restricted Project
tatsuo requested review of D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..
Sun, Sep 27, 2:57 AM · Restricted Project
ChuanqiXu updated the diff for D87596: [Coroutines] Reuse storage for local variables with non-overlapping lifetimes.

rename wouldOptimize to ReuseFrameSlot.

Sun, Sep 27, 2:54 AM · Restricted Project
davezarzycki added a comment to D88123: Add the ability to write 'target stop-hooks' in Python.

Hi Jim, this change broke my Fedora 33 Linux (x86) box. Do you think we can get a quick fix or revert this?

Sun, Sep 27, 2:48 AM · Restricted Project
shchenz updated the diff for D88373: [PowerPC] implement target hook getTgtMemIntrinsic.

code format fix

Sun, Sep 27, 1:56 AM · Restricted Project
aemerson committed rG5811d723998a: [AArch64][GlobalISel] Promote scalar G_SHL constant shift amounts to s64. (authored by aemerson).
[AArch64][GlobalISel] Promote scalar G_SHL constant shift amounts to s64.
Sun, Sep 27, 1:53 AM
shchenz requested review of D88374: [PowerPC] add more builtins to PPCTargetLowering::getTgtMemIntrinsic.
Sun, Sep 27, 1:52 AM · Restricted Project
nikic committed rGf229bf2e1246: [Legalize][X86] Improve nnan fmin/fmax vector reduction (authored by nikic).
[Legalize][X86] Improve nnan fmin/fmax vector reduction
Sun, Sep 27, 1:50 AM
nikic closed D87586: [X86] Improve nnan fmin/fmax vector reduction.
Sun, Sep 27, 1:50 AM · Restricted Project
aemerson committed rG7156938be264: [AArch64][GlobalISel] Use the look-through constant helper for the shift s32… (authored by aemerson).
[AArch64][GlobalISel] Use the look-through constant helper for the shift s32…
Sun, Sep 27, 1:33 AM
nikic added inline comments to D88360: [ValueTracking] Fix analyses to update CxtI to be phi's incoming edges' terminators.
Sun, Sep 27, 1:19 AM · Restricted Project
shchenz requested review of D88373: [PowerPC] implement target hook getTgtMemIntrinsic.
Sun, Sep 27, 1:19 AM · Restricted Project
MaskRay committed rG82420b4e49ff: [DivRemPairs] Use DenseMapBase::find instead of operator[]. NFC (authored by MaskRay).
[DivRemPairs] Use DenseMapBase::find instead of operator[]. NFC
Sun, Sep 27, 1:13 AM
nikic edited reviewers for D87976: Support the division-by-constant strength reduction for more integer types, added: efriedma; removed: eli.friedman.
Sun, Sep 27, 1:08 AM · Restricted Project
craig.topper committed rGd78c4d9d00c1: [X86] Add more test cases to inline-asm-flag-output.ll. NFC (authored by craig.topper).
[X86] Add more test cases to inline-asm-flag-output.ll. NFC
Sun, Sep 27, 12:56 AM

Yesterday

achieveartificialintelligence abandoned D85190: remove STLExtras.h.
Sat, Sep 26, 11:03 PM · Restricted Project
sunshaoce <llvm@foxmail.com> closed D88141: Update Kaleidoscope tutorial and remove useless header.
Sat, Sep 26, 10:41 PM · Restricted Project
sunshaoce <llvm@foxmail.com> committed rGba950ad0a510: Update Kaleidoscope: Change headers (authored by sunshaoce <llvm@foxmail.com>).
Update Kaleidoscope: Change headers
Sat, Sep 26, 10:41 PM
craig.topper added a comment to D87883: [X86] Add support for calling SimplifyDemandedBits on the input of PDEP with a constant mask..

Ping

Sat, Sep 26, 10:16 PM · Restricted Project
lattner accepted D88237: [TableGen] Add/edit Doxygen comments to match "TableGen Backend Developer's Guide".

nice

Sat, Sep 26, 10:09 PM · Restricted Project
lattner accepted D88322: [TableGen] Improve the messages in the PseudoLoweringEmitter backend.
Sat, Sep 26, 10:08 PM · Restricted Project
craig.topper updated the summary of D88063: [SelectionDAG] Make sure FMF are propagated when getSetcc canonicalizes FP constants to RHS..
Sat, Sep 26, 9:43 PM · Restricted Project
craig.topper updated the diff for D88063: [SelectionDAG] Make sure FMF are propagated when getSetcc canonicalizes FP constants to RHS..

Use the FlagInserter mechanism in SelectionDAGBuilder::visitFCmp.
Remove Flags from getSetcc which was previously added for SelectionDAGBuilder.

Sat, Sep 26, 9:38 PM · Restricted Project
MaskRay added inline comments to D88365: Port ConstraintElimination to the new pass manager.
Sat, Sep 26, 9:17 PM · Restricted Project
junparser added inline comments to D87596: [Coroutines] Reuse storage for local variables with non-overlapping lifetimes.
Sat, Sep 26, 9:13 PM · Restricted Project
kiranktp accepted D88326: [mlir][openacc] Remove detach and delete operands from acc.data.

LGTM

Sat, Sep 26, 9:09 PM · Restricted Project
craig.topper added inline comments to D87976: Support the division-by-constant strength reduction for more integer types.
Sat, Sep 26, 8:59 PM · Restricted Project
craig.topper added inline comments to D87976: Support the division-by-constant strength reduction for more integer types.
Sat, Sep 26, 8:57 PM · Restricted Project
dcaballe accepted D88362: Implement callee/caller type checking for llvm.call.

Thanks, LGTM! Please, give some time for @ftynse to have a look.

Sat, Sep 26, 8:52 PM · Restricted Project
hubert.reinterpretcast requested changes to D88310: [CMake][AIX] Limit tools in external project build.
Sat, Sep 26, 8:34 PM · Restricted Project