Feed All Stories

Today

craig.topper created D54513: [X86] Allow pmulh to be formed from narrow vXi16 vectors under -x86-experimental-vector-widening-legalization.
Wed, Nov 14, 12:24 AM
ruiu accepted D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.

Makes sense. LGTM.

Wed, Nov 14, 12:24 AM
abeserminji added a comment to D52010: RegAllocFast: Rewrite and improve.

From what I found in rL336328, I believe that the idea was to mark registers as implicit-def which would prevent such an error.
One of the comments say:

Wed, Nov 14, 12:20 AM
mstorsjo added inline comments to D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.
Wed, Nov 14, 12:10 AM
yonghong-song added a comment to D53329: Generate DIFile with main program if source is not available.

@dblaikie I got a standalone reproducible test now.

Wed, Nov 14, 12:08 AM · debug-info
ruiu accepted D54206: [COFF] RelocPtr is now a ulittle32_t pointer in LLVM.

LGTM

Wed, Nov 14, 12:06 AM
ruiu added inline comments to D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.
Wed, Nov 14, 12:00 AM

Yesterday

mstorsjo updated the diff for D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.

Added a testcase based on @pcc's suggestion.

Tue, Nov 13, 11:54 PM
mkazantsev accepted D54223: [SimpleLoopUnswitch] adding cost multiplier to cap exponential unswitch with.

LGTM

Tue, Nov 13, 11:54 PM
ctopper committed rL346834: [X86] Add -x86-experimental-vector-widening command lines to pmulh.ll.
[X86] Add -x86-experimental-vector-widening command lines to pmulh.ll
Tue, Nov 13, 11:54 PM
mstorsjo added inline comments to D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.
Tue, Nov 13, 11:52 PM
kristina added an edge to rL346763: [libcxx] GNU/Hurd uses BSD-based interfaces, but does not (and won't) provide…: D54338: Fix threads build on GNU/Hurd.
Tue, Nov 13, 11:50 PM
kristina added 1 commit(s) for D54338: Fix threads build on GNU/Hurd: rL346763: [libcxx] GNU/Hurd uses BSD-based interfaces, but does not (and won't) provide….
Tue, Nov 13, 11:50 PM
ruiu added inline comments to D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.
Tue, Nov 13, 11:43 PM
jonpa added a comment to D53865: [LoopVectorizer] Improve computation of scalarization overhead..

I have found some more potential use for this:

Tue, Nov 13, 11:31 PM
alexshap added inline comments to D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Tue, Nov 13, 11:28 PM
rengolin accepted D54378: Add Hurd triplet to LLVMSupport.
Tue, Nov 13, 11:26 PM
dblaikie added inline comments to D54483: [ELF] .gdb_index: use lower_bound to compute relative CU index in an object file.
Tue, Nov 13, 11:25 PM
dblaikie committed rL346833: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.
Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`
Tue, Nov 13, 11:22 PM
dblaikie closed D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.
Tue, Nov 13, 11:22 PM
mstorsjo added inline comments to D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.
Tue, Nov 13, 11:22 PM
craig.topper added a dependent revision for D54467: [X86] Disable combineToExtendVectorInReg under -x86-experimental-vector-widening-legalization. Add custom type legalization for extends.: D54512: [X86] Add -x86-experimental-vector-widening support to reduceVMULWidth and combineMulToPMADDWD.
Tue, Nov 13, 11:01 PM
craig.topper added a dependency for D54512: [X86] Add -x86-experimental-vector-widening support to reduceVMULWidth and combineMulToPMADDWD: D54467: [X86] Disable combineToExtendVectorInReg under -x86-experimental-vector-widening-legalization. Add custom type legalization for extends..
Tue, Nov 13, 11:01 PM
craig.topper created D54512: [X86] Add -x86-experimental-vector-widening support to reduceVMULWidth and combineMulToPMADDWD.
Tue, Nov 13, 11:01 PM
craig.topper accepted D54083: [X86][AVX512] Remove constant pool shuffle decoding from SelectionDAG.

LGTM

Tue, Nov 13, 10:50 PM
craig.topper accepted D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions.

LGTM

Tue, Nov 13, 10:48 PM
tbrethou committed rL346832: Add Kruse slides..
Add Kruse slides.
Tue, Nov 13, 10:36 PM
lanza abandoned D54506: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.
Tue, Nov 13, 10:26 PM
ecstatic-morse updated the summary of D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.
Tue, Nov 13, 10:25 PM
lanza added a comment to D54510: Force SHELL to be cmd.exe on Windows for the test suite.

I ran a subset of the test suite (around 350 tests) and found that there are 0 cases where a pass occurred with C:\cygwin\bin\sh.exe but not with C:\windows\system32\cmd.exe. So this should be safe.

Tue, Nov 13, 10:25 PM
lanza added reviewers for D54510: Force SHELL to be cmd.exe on Windows for the test suite: zturner, sas, xiaobai.
Tue, Nov 13, 10:24 PM
vsk added inline comments to D54175: [PGO] context sensitive PGO.
Tue, Nov 13, 10:22 PM
ecstatic-morse added a comment to D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.

I don't have commit rights. Could you commit this for me?

Tue, Nov 13, 10:22 PM
ruiu added inline comments to D39323: [lld] Support dynamic linking in RISC-V.
Tue, Nov 13, 9:56 PM · lld
void updated the diff for D54355: Use is.constant intrinsic for __builtin_constant_p.

ImpCast.

Tue, Nov 13, 9:48 PM
ruiu accepted D54474: [LLD][AArch64] Fix resolution of R_PLT_PAGE RelExpr .

LGTM

Tue, Nov 13, 9:43 PM
ruiu added inline comments to D54495: [LLD] [COFF] Remove empty sections before calculating the size of section headers.
Tue, Nov 13, 9:41 PM
gkistanova committed rL346831: Converted _getClangCMakeBuildFactory to use LLVMBuildFactory..
Converted _getClangCMakeBuildFactory to use LLVMBuildFactory.
Tue, Nov 13, 9:37 PM
ruiu added inline comments to D54483: [ELF] .gdb_index: use lower_bound to compute relative CU index in an object file.
Tue, Nov 13, 9:35 PM
lanza created D54511: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.
Tue, Nov 13, 9:35 PM
gkistanova committed rL346830: Generate better names for automatic schedulers..
Generate better names for automatic schedulers.
Tue, Nov 13, 9:33 PM
gkistanova committed rL346829: Added monitoring changes in lnt and test-suite projects..
Added monitoring changes in lnt and test-suite projects.
Tue, Nov 13, 9:30 PM
EricWF added a comment to D54508: [libcxx] [test] Fix Clang -Wunused-local-typedef, MSVC C4800, missing cassert..

Remind me once this lands to turn on -Wunused-local-typedef so we don't regress.

Tue, Nov 13, 9:22 PM
EricWF added inline comments to D54485: [libcxx] Implement P0318R1: unwrap_ref_decay and unwrap_reference.
Tue, Nov 13, 9:21 PM
lanza created D54510: Force SHELL to be cmd.exe on Windows for the test suite.
Tue, Nov 13, 9:20 PM
EricWF requested changes to D54485: [libcxx] Implement P0318R1: unwrap_ref_decay and unwrap_reference.
Tue, Nov 13, 9:20 PM
EricWF accepted D54508: [libcxx] [test] Fix Clang -Wunused-local-typedef, MSVC C4800, missing cassert..
Tue, Nov 13, 9:16 PM
Higuoxing created D54509: [llvm-objdump] Improve ELF file type checking statements.
Tue, Nov 13, 9:10 PM
dblaikie accepted D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.

Looks good - thanks! Do you need me to commit this for you? (Or do you have commit rights & can commit it yourself)

Tue, Nov 13, 9:02 PM
wuzish added inline comments to D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Tue, Nov 13, 8:52 PM
wuzish updated the diff for D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.

Use return type to distinguish which overload candidate is chosen because different candidate has different pointer return type which can not be converted implicitly without reporting error.

Tue, Nov 13, 8:50 PM
yaxunl committed rL346828: [HIP] Fix device only compilation.
[HIP] Fix device only compilation
Tue, Nov 13, 8:50 PM
yaxunl committed rC346828: [HIP] Fix device only compilation.
[HIP] Fix device only compilation
Tue, Nov 13, 8:50 PM
yaxunl closed D54496: [HIP] Fix device only compilation.
Tue, Nov 13, 8:50 PM
ecstatic-morse added a comment to D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.

I added tests via static_assert and updated the description to mention the bug report.

Tue, Nov 13, 8:14 PM
phosek committed rL346827: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
[CMake] Include clang-apply-replacements in Fuchsia toolchain
Tue, Nov 13, 8:10 PM
phosek committed rC346827: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
[CMake] Include clang-apply-replacements in Fuchsia toolchain
Tue, Nov 13, 8:10 PM
phosek closed D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
Tue, Nov 13, 8:10 PM
ecstatic-morse updated the summary of D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.
Tue, Nov 13, 8:07 PM
ecstatic-morse updated the diff for D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.

Added tests for pointer_iterator and pointee_iterator to ensure that the category of the underlying iterator is forwarded correctly.

Tue, Nov 13, 8:04 PM
juliehockett accepted D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
Tue, Nov 13, 7:53 PM
STL_MSFT created D54508: [libcxx] [test] Fix Clang -Wunused-local-typedef, MSVC C4800, missing cassert..
Tue, Nov 13, 7:35 PM
STL_MSFT committed rL346826: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Tue, Nov 13, 7:09 PM
STL_MSFT committed rCXX346826: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Tue, Nov 13, 7:09 PM
tstellar added inline comments to D53554: [Argument Promotion] Only promote args when function attributes are compatible.
Tue, Nov 13, 7:09 PM
aheejin committed rL346825: [WebAssembly] Add support for the event section.
[WebAssembly] Add support for the event section
Tue, Nov 13, 6:49 PM
aheejin closed D54096: [WebAssembly] Add support for the event section.
Tue, Nov 13, 6:49 PM
aheejin updated the summary of D54096: [WebAssembly] Add support for the event section.
Tue, Nov 13, 6:48 PM
wuzish committed rL346824: [PowerPC] Enhance the selection(ISD::VSELECT) of vector type.
[PowerPC] Enhance the selection(ISD::VSELECT) of vector type
Tue, Nov 13, 6:37 PM
wuzish closed D49531: [PowerPC] Enhance the selection(ISD::VSELECT) of vector type.
Tue, Nov 13, 6:37 PM
wuzish updated the summary of D49531: [PowerPC] Enhance the selection(ISD::VSELECT) of vector type.
Tue, Nov 13, 6:37 PM
manojgupta added a comment to D54487: Implement llvm.commandline named metadata.

Doesn't clang already has -grecord-gcc-switches option (https://clang.llvm.org/docs/ClangCommandLineReference.html#debug-information-flags) ?

Tue, Nov 13, 6:37 PM
sbc100 added inline comments to D54249: [WebAssembly] Initial support for shared objects (-shared).
Tue, Nov 13, 6:27 PM
sbc100 updated the diff for D54249: [WebAssembly] Initial support for shared objects (-shared).
  • feedback
Tue, Nov 13, 6:27 PM
void updated the diff for D54355: Use is.constant intrinsic for __builtin_constant_p.

Fix overflow flag.

Tue, Nov 13, 6:25 PM
tejohnson created D54507: [ThinLTO] Handle chains of aliases.
Tue, Nov 13, 6:18 PM
ronlieb updated the diff for D52846: [AMDGPU] Add FixupVectorISel pass, currently Supports SREGs in GLOBAL LD/ST.

Added additional comments and some code related to subregs.

Tue, Nov 13, 6:14 PM
craig.topper reopened D53876: Preserve loop metadata when splitting exit blocks.

Reopening as this was reverted in r346823

Tue, Nov 13, 6:11 PM
arsenm added a comment to D49097: [RegisterCoalescer] Another fix for subrange join unreachable.

I've reduced this testcase to this, although I think it can go a little further:

Tue, Nov 13, 6:00 PM
lanza created D54506: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.
Tue, Nov 13, 6:00 PM
void added a comment to D54355: Use is.constant intrinsic for __builtin_constant_p.

I think this is ready now. PTAL.

Tue, Nov 13, 5:58 PM
void updated the diff for D54355: Use is.constant intrinsic for __builtin_constant_p.

Updated to address comments.

Tue, Nov 13, 5:56 PM
phosek added a comment to D54461: [CMake] Support cross-compiling with multi-stage builds.

Any other comments?

Tue, Nov 13, 5:51 PM
rnk committed rL346823: Revert r346810 "Preserve loop metadata when splitting exit blocks".
Revert r346810 "Preserve loop metadata when splitting exit blocks"
Tue, Nov 13, 5:50 PM
phosek created D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
Tue, Nov 13, 5:48 PM
rnk added a comment to D53876: Preserve loop metadata when splitting exit blocks.

I think this broke the windows selfhost:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/1457/steps/stage%202%20build/logs/stdio

Tue, Nov 13, 5:46 PM
Quuxplusone added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Tue, Nov 13, 5:44 PM · Restricted Project
dschuff added inline comments to D54249: [WebAssembly] Initial support for shared objects (-shared).
Tue, Nov 13, 5:40 PM
smeenai added a comment to D52674: [AST] Add Obj-C discriminator to MS ABI RTTI.

I'm not worried about the mangler being re-used for multiple declarations, I'm worried about a global flag changing how we mangle all components of a type when we only mean to change it at the top level.

Tue, Nov 13, 5:35 PM
rnk added inline comments to D54499: [codeview] Make "clang -g" emit codeview by default when targetting MSVC.
Tue, Nov 13, 5:27 PM
phosek committed rUNW346820: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
[CMake] Passthrough CFLAGS when checking the compiler-rt path
Tue, Nov 13, 5:19 PM
arphaman committed rC346822: [HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory.
[HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory
Tue, Nov 13, 5:10 PM
arphaman committed rL346822: [HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory.
[HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory
Tue, Nov 13, 5:10 PM
arphaman closed D54503: [HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory.
Tue, Nov 13, 5:10 PM
MaskRay added a comment to D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.

Is this test case consistent with gold's behavior?

Tue, Nov 13, 5:10 PM
NoQ added a comment to D54466: [Analyzer] [WIP] Iterator Checkers - Use the base region of C++ Base Object Regions (recursively) for iterators stored in a region.

I marked this patch as WIP because I could not create a test-case for it. However in real projects this patch seems to reduce false positives significantly.

Tue, Nov 13, 5:09 PM · Restricted Project
MaskRay updated the diff for D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.

Add comment about the missing parts.

Tue, Nov 13, 5:03 PM
bruno accepted D54503: [HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory.

LGTM

Tue, Nov 13, 5:00 PM
rjmccall added a comment to D52674: [AST] Add Obj-C discriminator to MS ABI RTTI.

I'm not worried about the mangler being re-used for multiple declarations, I'm worried about a global flag changing how we mangle all components of a type when we only mean to change it at the top level.

Tue, Nov 13, 4:59 PM
vitalybuka created D54504: [stack-safety] Local analysis implementation.
Tue, Nov 13, 4:54 PM