Feed All Stories

Today

Soindnalinsaf authored Blog Post: прокладка кабелей методом горизонтального направленного бурения.
Wed, Mar 29, 12:20 AM
ctopper committed rL298984: [AVX-512] Remove explicit KMOVWrk/KMOVWKr instructions from patterns where we….
[AVX-512] Remove explicit KMOVWrk/KMOVWKr instructions from patterns where we…
Wed, Mar 29, 12:08 AM
mgorny updated the diff for D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.

Needed to rebase again.

Wed, Mar 29, 12:00 AM

Yesterday

mgorny added inline comments to D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.
Tue, Mar 28, 11:59 PM
ki.stfu requested changes to D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope.

LGTM. Just fix a few minor issues before committing.

Tue, Mar 28, 11:28 PM · Restricted Project
dberris committed rL298983: [XRay] Update FDR log reader to be aware of buffer sizes per thread..
[XRay] Update FDR log reader to be aware of buffer sizes per thread.
Tue, Mar 28, 11:22 PM
dberris closed D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread. by committing rL298983: [XRay] Update FDR log reader to be aware of buffer sizes per thread..
Tue, Mar 28, 11:22 PM
axeldavy added a comment to D31124: AMDGPU/SI: Add lane tracking to SI Scheduler.

Axel, thanks for the update.

If you aren't going to add test for this, can you at least run your change on the debug build (or release with asserts) with sisched turned on by default over all AMDGPU lit tests? They mostly would fail on miscompare, but they should run without asserts.

Tue, Mar 28, 11:17 PM · Restricted Project
dberris committed rL298982: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer..
[XRay] [compiler-rt] Write buffer length to FDR log before writing buffer.
Tue, Mar 28, 11:09 PM
dberris closed D31384: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer. by committing rL298982: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer..
Tue, Mar 28, 11:09 PM
cmatthews committed rL298980: Make sure secret keys are defined in all the tests.
Make sure secret keys are defined in all the tests
Tue, Mar 28, 11:02 PM
cmatthews committed rL298981: Whitespace and import cleanup.
Whitespace and import cleanup
Tue, Mar 28, 11:02 PM
cmatthews committed rL298979: Make flask sessions permanent.
Make flask sessions permanent
Tue, Mar 28, 11:02 PM
echuraev committed rL298978: Reverted r298976 [OpenCL] Added parsing for OpenCL vector types..
Reverted r298976 [OpenCL] Added parsing for OpenCL vector types.
Tue, Mar 28, 10:53 PM
dberris committed rL298977: [XRay][compiler-rt] Add an end-to-end test for FDR Logging.
[XRay][compiler-rt] Add an end-to-end test for FDR Logging
Tue, Mar 28, 10:31 PM
dberris closed D31452: [XRay][compiler-rt] Add an end-to-end test for FDR Logging by committing rL298977: [XRay][compiler-rt] Add an end-to-end test for FDR Logging.
Tue, Mar 28, 10:31 PM
dberris added inline comments to D31452: [XRay][compiler-rt] Add an end-to-end test for FDR Logging.
Tue, Mar 28, 10:30 PM
dberris updated the diff for D31452: [XRay][compiler-rt] Add an end-to-end test for FDR Logging.
  • fixup: address review comments
Tue, Mar 28, 10:30 PM
uabelho added a comment to D31416: [Scalarizer] Handle scalar arguments in vector GEP.

Hi Mikael,

r298620 was temporarily reverted because it exposed some other issues with vector GEP handling, but I plan to recommit it. Would you like for me to wait until after this patch is committed, or does it matter for your work?

Tue, Mar 28, 10:26 PM
gribozavr accepted D31422: Add builder for libunwind docs.
Tue, Mar 28, 10:26 PM
kpw accepted D31452: [XRay][compiler-rt] Add an end-to-end test for FDR Logging.

LGTM with the spruce up specified.

Tue, Mar 28, 10:24 PM
kpw added a comment to D31452: [XRay][compiler-rt] Add an end-to-end test for FDR Logging.

Thanks for the quick fix and for figuring out the lit configuration.

Tue, Mar 28, 10:23 PM
echuraev committed rL298976: [OpenCL] Added parsing for OpenCL vector types..
[OpenCL] Added parsing for OpenCL vector types.
Tue, Mar 28, 10:20 PM
echuraev closed D31183: [OpenCL] Added parsing for OpenCL vector types..
Tue, Mar 28, 10:20 PM
enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Apologies-- forgot to update a comment

Tue, Mar 28, 10:16 PM · Restricted Project
ahmedasadi updated the diff for D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
Tue, Mar 28, 10:16 PM
dberris committed rL298975: [XRay][tools] Handle "no subcommand" case for llvm-xray.
[XRay][tools] Handle "no subcommand" case for llvm-xray
Tue, Mar 28, 10:08 PM
dberris closed D31409: [XRay][tools] Handle "no subcommand" case for llvm-xray by committing rL298975: [XRay][tools] Handle "no subcommand" case for llvm-xray.
Tue, Mar 28, 10:08 PM
hfinkel added a comment to D29966: [SelectionDAG] Try to recompute LiveOutInfo of PHI.

Do you have a test case?

Tue, Mar 28, 10:05 PM
xiangzhai created D31453: [analyzer] Fix SimpleSValBuilder evalBinOpLN elementType might be nullptr issue.
Tue, Mar 28, 10:04 PM
pelikan accepted D31409: [XRay][tools] Handle "no subcommand" case for llvm-xray.

Thumbs up. Like. +1.

Tue, Mar 28, 9:57 PM
dberris updated the diff for D31409: [XRay][tools] Handle "no subcommand" case for llvm-xray.
  • fixup: add a test
Tue, Mar 28, 9:55 PM
dberris created D31452: [XRay][compiler-rt] Add an end-to-end test for FDR Logging.
Tue, Mar 28, 9:37 PM
dberris abandoned D31379: [XRay][compiler-rt] Add a test for -fPIE.

Realized that this isn't the best way to approach this (and that it's not something we actually need to test this way). Closing for further exploration later.

Tue, Mar 28, 9:30 PM
zvi added a comment to D31426: [DAGCombine] Combine shuffle of splat with multiple uses.

I initially tried handling all cases of shuffle of shuffle-splat but the improvements from D27793 regressed, so this is what i came up with.
Should i change this to an X86-specific combine to follow the spirit of D27793?

Tue, Mar 28, 9:29 PM
t-tye added inline comments to D31404: [OpenCL] Allow alloca return non-zero private pointer.
Tue, Mar 28, 9:21 PM
krytarowski added a reviewer for D31450: Battery of NetBSD support improvements: jingham.

Adding Jim as a reviewer, since Pavel is mostly out of the keyboard for longer time.

Tue, Mar 28, 9:02 PM · Restricted Project
weimingz committed rL298974: [Builtin] Unxfail tests for armhf.
[Builtin] Unxfail tests for armhf
Tue, Mar 28, 8:49 PM
weimingz closed D31448: [Builtin] Unxfail tests for armhf by committing rL298974: [Builtin] Unxfail tests for armhf.
Tue, Mar 28, 8:49 PM
vpykhtin added a comment to D31124: AMDGPU/SI: Add lane tracking to SI Scheduler.

Axel, thanks for the update.

Tue, Mar 28, 8:33 PM · Restricted Project
krytarowski added a comment to D31450: Battery of NetBSD support improvements.

Current core(5) file format is a subject to change (AUXV can be shortened)... I'm working on the final nits for the NetBSD-8 interfaces.

Tue, Mar 28, 8:27 PM · Restricted Project
krytarowski created D31450: Battery of NetBSD support improvements.
Tue, Mar 28, 8:22 PM · Restricted Project
cmatthews committed rL298973: Spelling.
Spelling
Tue, Mar 28, 7:56 PM
cmatthews committed rL298972: We are having a problem with zombie LNT processes on Linux.
We are having a problem with zombie LNT processes on Linux
Tue, Mar 28, 7:55 PM
dberris planned changes to D31409: [XRay][tools] Handle "no subcommand" case for llvm-xray.

@pelikan correctly points out that this is missing a test. Will add that in a bit.

Tue, Mar 28, 7:45 PM
enyquist added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Tue, Mar 28, 7:43 PM · Restricted Project
enyquist updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.
Tue, Mar 28, 7:43 PM · Restricted Project
arsenm added a comment to D31446: [GlobalISel]: Target specific MIs like REG_SEQUENCE shouldn't be Regbank selected.

Why shouldn't they be?

Tue, Mar 28, 7:16 PM
kpw added a comment to D31384: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer..

Something in the rebase broke and I'm getting segfaults when instrumenting my test program whether I'm on my branch or master.

Tue, Mar 28, 7:09 PM
kpw updated the diff for D31384: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer..

Rebasing onto master.

Tue, Mar 28, 7:07 PM
kubamracek created D31449: [tsan] Don't report deadlocks when ignore_reads_and_writes > 0.
Tue, Mar 28, 6:53 PM · Restricted Project
ruiu committed rL298971: Attempt to fix buildbot..
Attempt to fix buildbot.
Tue, Mar 28, 6:49 PM
kpw added inline comments to D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread..
Tue, Mar 28, 6:44 PM
kpw updated the diff for D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread..

Few more cleanups for nits and change the freeform space handling to better use DataExtractor.

Tue, Mar 28, 6:43 PM
yaxunl updated the diff for D31404: [OpenCL] Allow alloca return non-zero private pointer.

Revised by Tony's comments.

Tue, Mar 28, 6:41 PM
kamil committed rL298970: Remove dead include <sys/user.h> from the NetBSD code..
Remove dead include <sys/user.h> from the NetBSD code.
Tue, Mar 28, 6:22 PM
xiangzhai added a comment to D23418: [analyzer] Added a reusable constraint system to the CloneDetector.

Hi Raphael,

Tue, Mar 28, 6:21 PM
compnerd accepted D31448: [Builtin] Unxfail tests for armhf.
Tue, Mar 28, 6:21 PM
ruiu committed rL298969: Use uint64_t instead of uintX_t and size_t..
Use uint64_t instead of uintX_t and size_t.
Tue, Mar 28, 6:02 PM
ruiu committed rL298968: Change the order of parameters. NFC..
Change the order of parameters. NFC.
Tue, Mar 28, 6:02 PM
weimingz created D31448: [Builtin] Unxfail tests for armhf.
Tue, Mar 28, 6:01 PM
ributzka committed rL298967: Revert "Added `applyAtomicChanges` function.".
Revert "Added `applyAtomicChanges` function."
Tue, Mar 28, 5:37 PM
ributzka committed rL298966: Revert "Try to unbreak buildbots after r298913.".
Revert "Try to unbreak buildbots after r298913."
Tue, Mar 28, 5:37 PM
ributzka committed rL298965: Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913.".
Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913."
Tue, Mar 28, 5:36 PM
dberris added inline comments to D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread..
Tue, Mar 28, 5:33 PM
dberris accepted D31384: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer..

Please rebase to the tip of trunk / master, and I'll land once that's done. :)

Tue, Mar 28, 5:32 PM
kpw added inline comments to D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread..
Tue, Mar 28, 5:32 PM
clm created D31447: [Driver] Add option to print the resource directory.
Tue, Mar 28, 5:31 PM
anemet added a comment to D31276: Add #pragma clang fp.

(Sorry about updating the title/description back and forth but arcanist is buggy)

Tue, Mar 28, 5:31 PM
anemet retitled D31276: Add #pragma clang fp from Add #pragma clang fast_math to Add #pragma clang fp.
Tue, Mar 28, 5:30 PM
anemet updated the diff for D31276: Add #pragma clang fp.

Rename pragma from #pragma clang fast_math contract_fast(on/off) -> #pragma clang fp contract(on/fast/off)

Tue, Mar 28, 5:29 PM
anemet retitled D31276: Add #pragma clang fp from Add #pragma clang fast_math to Add #pragma clang fp.
Tue, Mar 28, 5:28 PM
dberris added a comment to D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread..

LGTM - Few more nits.

Tue, Mar 28, 5:27 PM
mehdi_amini added inline comments to D31022: Implement P0298R3: `std::byte`.
Tue, Mar 28, 5:27 PM
aditya_nandakumar created D31446: [GlobalISel]: Target specific MIs like REG_SEQUENCE shouldn't be Regbank selected.
Tue, Mar 28, 5:25 PM
anemet added a reviewer for D31167: Use FPContractModeKind universally: spatel.
Tue, Mar 28, 5:25 PM
anemet added a reviewer for D31168: Set FMF for -ffp-contract=fast: spatel.
Tue, Mar 28, 5:25 PM
kpw updated the diff for D31384: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer..

writing the file sizes to the file header rather than a separate piece of data.

Tue, Mar 28, 5:24 PM
anemet added a reviewer for D31276: Add #pragma clang fp: spatel.
Tue, Mar 28, 5:24 PM
ruiu committed rL298964: Remove a comment that is taken from gdb man page..
Remove a comment that is taken from gdb man page.
Tue, Mar 28, 5:22 PM
kpw updated the diff for D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread..

This now expects the buffer size information in the Header rather than in a separate
piece of data.

Tue, Mar 28, 5:22 PM
aleixpol abandoned D31445: Fix build error when using -DLLVM_LINK_LLVM_DYLIB=ON.

Wrong patch, sorry for the noise.

Tue, Mar 28, 5:07 PM
VardenVowly created VardenVowly.
Tue, Mar 28, 5:07 PM
anemet added a comment to D31165: [SDAG] Add AllowContract to SNodeFlags.

@spatel, @arsenm, this is a trivial patch to expose the new FMF to SDAG. Since you guys looked at the rest of the LLVM patches in the set, would you mind reviewing this too?

I actually haven't looked at all of the patches. Can you add me to those?

Tue, Mar 28, 4:59 PM
anemet committed rL298963: [SDAG] Remove -enable-fmf-dag.
[SDAG] Remove -enable-fmf-dag
Tue, Mar 28, 4:58 PM
anemet committed rL298962: [SDAG] Handle VectorReduction in SDNodeFlags::intersectWith.
[SDAG] Handle VectorReduction in SDNodeFlags::intersectWith
Tue, Mar 28, 4:58 PM
anemet committed rL298961: [SDAG] Add AllowContract to SNodeFlags.
[SDAG] Add AllowContract to SNodeFlags
Tue, Mar 28, 4:58 PM
anemet closed D31165: [SDAG] Add AllowContract to SNodeFlags by committing rL298961: [SDAG] Add AllowContract to SNodeFlags.
Tue, Mar 28, 4:58 PM
jroelofs added inline comments to D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.
Tue, Mar 28, 4:58 PM
Meinersbur added a comment to D31386: [Polly] [DependenceInfo] change WAR, WAW generation to correct semantics..

Thanks for this patch. I already mentioned to Tobias was that this code looked incorrect, but he explained to me that this was taken over from something Sven did and I did not investigate further. The new way of computing the dependencies is much more understandable and you explained well why changes are necessary.

Tue, Mar 28, 4:50 PM
pcc committed rL298960: More accurate header inclusions. NFC..
More accurate header inclusions. NFC.
Tue, Mar 28, 4:47 PM
pcc added a comment to D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID.

This seems reasonable for now, with a test case.

Tue, Mar 28, 4:44 PM
ctopper committed rL298959: [AVX-512] Add test case that was supposed to go with r298957..
[AVX-512] Add test case that was supposed to go with r298957.
Tue, Mar 28, 4:42 PM
mehdi_amini added a comment to D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID.

@mehdi_amini, we have other places where we call GlobalValue::getGUID with a name that is not an IR name, e.g. in BitcodeReader.cpp. I wouldn't be opposed to moving to a design where it's harder to pass the wrong kind of name, or even a design where the IR name and the RealLinkageName and the GlobalIdentifier aren't all different things, but that is going to be a larger change. Can we get this fix in in the meantime?

Tue, Mar 28, 4:41 PM
inglorion added a comment to D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID.

@mehdi_amini, we have other places where we call GlobalValue::getGUID with a name that is not an IR name, e.g. in BitcodeReader.cpp. I wouldn't be opposed to moving to a design where it's harder to pass the wrong kind of name, or even a design where the IR name and the RealLinkageName and the GlobalIdentifier aren't all different things, but that is going to be a larger change. Can we get this fix in in the meantime?

Tue, Mar 28, 4:38 PM
jingham committed rL298958: Print the error if dsymForUUID sometimes produces bad plists..
Print the error if dsymForUUID sometimes produces bad plists.
Tue, Mar 28, 4:37 PM
aleixpol added reviewers for D31445: Fix build error when using -DLLVM_LINK_LLVM_DYLIB=ON: beanz, mgorny.
Tue, Mar 28, 4:35 PM
ctopper committed rL298957: [AVX-512] Punt on fast-isel of truncates to i1 when AVX512 is enabled..
[AVX-512] Punt on fast-isel of truncates to i1 when AVX512 is enabled.
Tue, Mar 28, 4:33 PM
aleixpol created D31445: Fix build error when using -DLLVM_LINK_LLVM_DYLIB=ON.
Tue, Mar 28, 4:32 PM
mehdi_amini added a comment to D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID.

Can we get consistently GlobalValue::getGUID taking an IRName and taking care of calling getRealLinkageName? (assuming it is what's expected)

Tue, Mar 28, 4:26 PM