Page MenuHomePhabricator
Feed All Stories

Today

dancgr committed rG1f85dfb2af1a: [AArch64][SVE] Add SVE2 mla indexed intrinsics. (authored by dancgr).
[AArch64][SVE] Add SVE2 mla indexed intrinsics.
Tue, Jan 28, 2:16 PM
xiaobai committed rG5eaf44f99f0a: [lldb] Delete ValueObject::GetBaseClassPath (authored by xiaobai).
[lldb] Delete ValueObject::GetBaseClassPath
Tue, Jan 28, 2:16 PM
xiaobai closed D73517: [lldb] Delete ValueObject::GetBaseClassPath.
Tue, Jan 28, 2:15 PM · Restricted Project
dancgr closed D73576: [AArch64][SVE] Add SVE2 mla indexed intrinsics.
Tue, Jan 28, 2:15 PM · Restricted Project
Eugene.Zelenko created D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section.
Tue, Jan 28, 2:15 PM · Restricted Project, Restricted Project
kazu updated the diff for D70247: [JumpThreading] Thread jumps through two basic blocks.

This patch is work-in-progress, but I am uploading it now so I can
share it with wider audience. I am still working on fixing loose
ends.

Tue, Jan 28, 2:15 PM · Restricted Project
xiaobai closed D69820: [Symbol] Add TypeSystem::GetClassName.

Made obsolete by D73517

Tue, Jan 28, 2:15 PM · Restricted Project
kazu reopened D70247: [JumpThreading] Thread jumps through two basic blocks.

I am re-opening this so that I can check in a revised version.

Tue, Jan 28, 2:15 PM · Restricted Project
abeakkas added a comment to D73579: [mlir] Add elementAttr to TypedArrayAttrBase..

This is a followup commit to https://reviews.llvm.org/D72888 .

Tue, Jan 28, 2:15 PM · Restricted Project
abeakkas added a reviewer for D73579: [mlir] Add elementAttr to TypedArrayAttrBase.: ftynse.
Tue, Jan 28, 2:15 PM · Restricted Project
risa2000 added a comment to D65270: [CMake] Fix source path generation for install in multi-config (MSBuild).

I wonder if someone could explain what happened and if this has been dropped because of the comment from @beanz? I am not using XCode so I cannot comment on its requirements nor fix the code for it.

Tue, Jan 28, 2:15 PM · Restricted Project, Restricted Project, Restricted Project
paquette committed rGdba29f7c3b36: [AArch64][GlobalISel] Fold G_AND into G_BRCOND (authored by paquette).
[AArch64][GlobalISel] Fold G_AND into G_BRCOND
Tue, Jan 28, 2:06 PM
thegameg committed rG4e799ada5860: [CodeGen] Attach no-builtin attributes to function definitions with no Decl (authored by thegameg).
[CodeGen] Attach no-builtin attributes to function definitions with no Decl
Tue, Jan 28, 2:06 PM
abeakkas created D73579: [mlir] Add elementAttr to TypedArrayAttrBase..
Tue, Jan 28, 2:06 PM · Restricted Project
paquette closed D73573: [AArch64][GlobalISel] Fold G_AND into G_BRCOND.
Tue, Jan 28, 2:06 PM · Restricted Project
thegameg closed D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl.
Tue, Jan 28, 2:06 PM · Restricted Project
xiaobai closed D72946: [lldb] Remove ClangASTImporter reference from Target.

Commit c4f6fbe971351273b19a4a819bf6ceae2b70b37e

Tue, Jan 28, 2:06 PM · Restricted Project
merge_guards_bot added a comment to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 2:06 PM · Restricted Project
steven_wu updated the diff for D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

Conditionalize the .private_extern based on VISIBILITY_HIDDEN macro

Tue, Jan 28, 2:06 PM · Restricted Project, Restricted Project
steven_wu added a comment to D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

Should there be a COMPILER_RT_ALIAS and COMPILER_RT_HIDDEN_ALIAS macro? Does this change effect the libcompiler_rt.dylib in the OS. In the dylib, I suspect the aliases should be global.

Tue, Jan 28, 1:56 PM · Restricted Project, Restricted Project
xiaobai committed rGc4f6fbe97135: [lldb] Remove ClangASTImporter from Target (authored by xiaobai).
[lldb] Remove ClangASTImporter from Target
Tue, Jan 28, 1:55 PM
ted reopened D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.
Tue, Jan 28, 1:55 PM · Restricted Project
ted updated the diff for D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.

Removed the code that sets m_constructor_errors when GetLoadAddressPermissions returns False, as requested by @jingham .

Tue, Jan 28, 1:55 PM · Restricted Project
aemerson accepted D73573: [AArch64][GlobalISel] Fold G_AND into G_BRCOND.

LGTM with minor nit.

Tue, Jan 28, 1:55 PM · Restricted Project
efriedma added a comment to D73135: [AArch64][ARM] Always expand ordered vector reductions (PR44600).

That might all be too hypothetical to worry about thought.

Tue, Jan 28, 1:55 PM · Restricted Project
wgml added a comment to D52136: [clang-tidy] Add modernize-concat-nested-namespaces check.

Hi

Thanks a lot for this checker - would it be possible to enhance it to also update stuff in associated header files?

Thanks

Tue, Jan 28, 1:55 PM · Restricted Project, Restricted Project
merge_guards_bot added a comment to D72829: Implement -fsemantic-interposition.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 1:55 PM · Restricted Project, Restricted Project
andreil99 accepted D73578: Execute libc++abi tests on Armv7 devboard by llvm-clang-win-x-armv7l builder..

Thanks, Vlad!

Tue, Jan 28, 1:55 PM · Restricted Project
delcypher added a comment to D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

@steven_wu I'm having difficultly understanding the description.

Tue, Jan 28, 1:45 PM · Restricted Project, Restricted Project
mtrofin committed rG7f434b91a95f: [llvm] Ensure InlineCost-related fields are initialized (authored by mtrofin).
[llvm] Ensure InlineCost-related fields are initialized
Tue, Jan 28, 1:45 PM
mtrofin closed D73420: [llvm] Ensure InlineCost-related fields are initialized.
Tue, Jan 28, 1:45 PM · Restricted Project
aaron.ballman added inline comments to D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto.
Tue, Jan 28, 1:45 PM · Restricted Project, Restricted Project
broadwaylamb accepted D73578: Execute libc++abi tests on Armv7 devboard by llvm-clang-win-x-armv7l builder..

LGTM

Tue, Jan 28, 1:45 PM · Restricted Project
efriedma accepted D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl.

There's maybe some argument that we should be calling getNonClosureContext() or something like that to find the parent function, at least for some attributes. But that seems less critical, and I don't really want to think about which attributes should/should not apply right now.

Tue, Jan 28, 1:45 PM · Restricted Project
vvereschaka created D73578: Execute libc++abi tests on Armv7 devboard by llvm-clang-win-x-armv7l builder..
Tue, Jan 28, 1:45 PM · Restricted Project
kledzik added a comment to D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.

Should there be a COMPILER_RT_ALIAS and COMPILER_RT_HIDDEN_ALIAS macro? Does this change effect the libcompiler_rt.dylib in the OS. In the dylib, I suspect the aliases should be global.

Tue, Jan 28, 1:45 PM · Restricted Project, Restricted Project
spatel added a comment to D73575: [InstCombine] canonicalize splat shuffle after cmp.

LGTM

Does it make sense to extend this for arbitrary shuffles in the future? The mask construction logic in https://github.com/llvm/llvm-project/blob/4aa8cdfeebec115b928e0ccb452551b520d00f0b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp#L1612-L1660 can probably mostly be reused for the icmp case.

Tue, Jan 28, 1:35 PM · Restricted Project
efriedma committed rGa2fb2c0ddca1: [GlobalMerge] Preserve symbol visibility when merging globals (authored by mspang).
[GlobalMerge] Preserve symbol visibility when merging globals
Tue, Jan 28, 1:34 PM
hans committed rGeaabaf7e04fe: Revert "[MS] Overhaul how clang passes overaligned args on x86_32" (authored by hans).
Revert "[MS] Overhaul how clang passes overaligned args on x86_32"
Tue, Jan 28, 1:34 PM
hans added a reverting change for rG2af74e27ed7d: [MS] Overhaul how clang passes overaligned args on x86_32: rGeaabaf7e04fe: Revert "[MS] Overhaul how clang passes overaligned args on x86_32".
Tue, Jan 28, 1:34 PM
efriedma closed D73235: [GlobalMerge] Preserve symbol visibility when merging globals.
Tue, Jan 28, 1:34 PM · Restricted Project
JDevlieghere committed rG8e21d7b9249e: [lldb/Reproducer] Include deserialized value in log statement (authored by JDevlieghere).
[lldb/Reproducer] Include deserialized value in log statement
Tue, Jan 28, 1:34 PM
NoQ accepted D73519: [analyzer] AnalysisDeclContext: Refactor and documentation.

There was a lot of dead code, nothing fancy to mention.

Tue, Jan 28, 1:34 PM · Restricted Project
csigg added inline comments to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..
Tue, Jan 28, 1:34 PM · Restricted Project
mstorsjo added a comment to D73508: [LLD][COFF] Fix dll import for thread_local storage.

Thank you for your very detailed explanation. Do you think it'd be worth updating documentation and cmake then to error if threading is enabled and build shared libs chosen?

Tue, Jan 28, 1:34 PM · Restricted Project
merge_guards_bot added a comment to D73312: [lit] Use canonical None test.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 1:34 PM · Restricted Project
efriedma accepted D71445: [ConstantFold][SVE] Fix constant folding for scalable vector binary operations..

LGTM

Tue, Jan 28, 1:34 PM · Restricted Project
efriedma accepted D73576: [AArch64][SVE] Add SVE2 mla indexed intrinsics.

Err, nevermind, that's not legal.

Tue, Jan 28, 1:34 PM · Restricted Project
dblaikie added a comment to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Thanks for the details! I'd be /OK/ with this, but it doesn't seem ideal to be printing the next/prev when printing the container? Do you think it's worth/there's any nice way to avoid that significant redundancy/verbosity in the printing & just print the payload?

Tue, Jan 28, 1:34 PM · Restricted Project
fghanim added inline comments to D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation.
Tue, Jan 28, 1:34 PM · Restricted Project, Restricted Project
efriedma added a comment to D73576: [AArch64][SVE] Add SVE2 mla indexed intrinsics.

I don't see any testcases for the byte variant? (smlalb z0.h, z1.b, z2.b[0]).

Tue, Jan 28, 1:34 PM · Restricted Project
arsenm added inline comments to D73482: [AMDGPU] Fix lowering a16 image intrinsics.
Tue, Jan 28, 1:34 PM · Restricted Project
mgorny committed rG6dea61215d2e: [lldb] [test] Restrict x86-64-write register test to x86-64 (authored by mgorny).
[lldb] [test] Restrict x86-64-write register test to x86-64
Tue, Jan 28, 1:23 PM
aaron.ballman added a comment to D73464: [clang] Add TagDecl AST matcher.

LGTM! Do you need someone to commit on your behalf?

Yes, please. I don`t know how :)

Tue, Jan 28, 1:22 PM · Restricted Project
csigg updated the diff for D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Add detailed CHECKs.

Tue, Jan 28, 1:22 PM · Restricted Project
Carrot added inline comments to D73387: [MBP] Partial tail duplication into hot predecessors.
Tue, Jan 28, 1:22 PM · Restricted Project
merge_guards_bot added a comment to D73145: [mlir][Linalg] Introduce folding patterns to remove certain MemRefCastOp.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 1:22 PM · Restricted Project
Carrot updated the diff for D73387: [MBP] Partial tail duplication into hot predecessors.
Tue, Jan 28, 1:22 PM · Restricted Project
dancgr retitled D73576: [AArch64][SVE] Add SVE2 mla indexed intrinsics from [AArch64][SVE] Add SVE2 mla indexed intrinsics. to [AArch64][SVE] Add SVE2 mla indexed intrinsics.
Tue, Jan 28, 1:22 PM · Restricted Project
merge_guards_bot added a comment to D73571: [MLIR] Add the sqrt operation to mlir..

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 1:22 PM · Restricted Project
aaron.ballman added a comment to D73457: [Clang] Warn about 'z' printf modifier in old MSVC..

Since we auto-detect -fmsc-version if it's not explicitly installed and since this warning is on by default, it makes the test suite depend on the environment a good bit. Given how old 2015 is by now, I'm not sure this complexity and subtlety is worth the benefit?

Tue, Jan 28, 1:22 PM · Restricted Project
zero9178 abandoned D73508: [LLD][COFF] Fix dll import for thread_local storage.
Tue, Jan 28, 1:22 PM · Restricted Project
steven_wu added a reviewer for D73577: [compiler-rt] Build all alias in builtin as private external on Darwin: kledzik.
Tue, Jan 28, 1:22 PM · Restricted Project, Restricted Project
steven_wu created D73577: [compiler-rt] Build all alias in builtin as private external on Darwin.
Tue, Jan 28, 1:22 PM · Restricted Project, Restricted Project
thakis committed rG776937c3e881: [gn build] (manually) port 90a10f00ff8 (authored by thakis).
[gn build] (manually) port 90a10f00ff8
Tue, Jan 28, 1:11 PM
Harbormaster failed remote builds in B45165: Diff 240958 for D71920: [AST] Refactor propagation of dependency bits. NFC!
Tue, Jan 28, 1:11 PM · Restricted Project
Harbormaster failed remote builds in B45167: Diff 240965 for D73572: [mlir] Expand shape functions in ShapeInference doc!
Tue, Jan 28, 1:11 PM · Restricted Project
merge_guards_bot added a comment to D73572: [mlir] Expand shape functions in ShapeInference doc.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 1:11 PM · Restricted Project
aaron.ballman added inline comments to D73562: [ASTMatchers] Add isPlacement traversal matcher for CXXNewExpr.
Tue, Jan 28, 1:11 PM · Restricted Project
paquette accepted D73564: LLT: Add changeNumElements.

LGTM

Tue, Jan 28, 1:11 PM · Restricted Project
dancgr added a reviewer for D73576: [AArch64][SVE] Add SVE2 mla indexed intrinsics: kmclaughlin.
Tue, Jan 28, 1:11 PM · Restricted Project
paquette accepted D73147: GlobalISel: Fix mask computation in lowerInsert.

LGTM

Tue, Jan 28, 1:11 PM · Restricted Project
dancgr removed a reviewer for D73576: [AArch64][SVE] Add SVE2 mla indexed intrinsics: dancgr.
Tue, Jan 28, 1:11 PM · Restricted Project
dancgr created D73576: [AArch64][SVE] Add SVE2 mla indexed intrinsics.
Tue, Jan 28, 1:11 PM · Restricted Project
nikic accepted D73575: [InstCombine] canonicalize splat shuffle after cmp.

Does it make sense to extend this for arbitrary shuffles in the future? The mask construction logic in https://github.com/llvm/llvm-project/blob/4aa8cdfeebec115b928e0ccb452551b520d00f0b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp#L1612-L1660 can probably mostly be reused for the icmp case.

Tue, Jan 28, 1:11 PM · Restricted Project
Xiangling_L updated the diff for D72454: [AIX] Enable frame pointer for AIX and add related test suite.

Fix the comment

Tue, Jan 28, 1:11 PM · Restricted Project
merge_guards_bot added a comment to D71920: [AST] Refactor propagation of dependency bits. NFC.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 1:11 PM · Restricted Project
ted added a comment to D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo.

Wow @jingham you posted your comment and I landed the patch at the same time!

Tue, Jan 28, 1:11 PM · Restricted Project
nicolasvasilache committed rG1d58a7c82f77: [mlir][Linalg][doc] Add Design Document for the Linalg Dialect (authored by nicolasvasilache).
[mlir][Linalg][doc] Add Design Document for the Linalg Dialect
Tue, Jan 28, 12:59 PM
merge_guards_bot added a comment to D73546: Add a few GDB pretty printers for MLIR..

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 12:58 PM · Restricted Project
rampitec accepted D71717: [MachineScheduler] Ignore artificial edges when forming store chains.

I have realized that BaseMemOpClusterMutation::apply() in fact does not check all control dependencies and just breaks at the first one. I.e. this change just skips some SDeps preferring another one. More or less we are lucky to find a correct SDep which may form a useful chain. We may be not that lucky if order of the SDeps is different and we would somehow use another register (for example data register). We probably need a callback to check if that register belongs to pointer operand and skip it otherwise. Alternatively we may need a full search to find a best SDep in the list.

Tue, Jan 28, 12:58 PM · Restricted Project
huihuiz updated the diff for D71445: [ConstantFold][SVE] Fix constant folding for scalable vector binary operations..

Apologies for the delay, was on vacation, also got caught up with a work project in the past two weeks.

Tue, Jan 28, 12:58 PM · Restricted Project
rampitec added a comment to D73509: [MachineScheduler] relax successor chain on clustering.

After some meditation in gdb I have found that BaseMemOpClusterMutation::apply() in fact does not check all control dependencies and just breaks at the first one. I.e. D71717 just skips some SDeps preferring another one. More or less we are lucky to find a correct SDep which may form a useful chain. We may be not that lucky if order of the SDeps is different and we would somehow use another register (for example data register). We probably need a callback to check if that register belongs to pointer operand and skip it otherwise.

Tue, Jan 28, 12:58 PM · Restricted Project
danalbert accepted D73516: [libcxx] Link against android_support when needed.
Tue, Jan 28, 12:58 PM · Restricted Project
efriedma added a comment to D73235: [GlobalMerge] Preserve symbol visibility when merging globals.

Oh, sorry, I lost track of this; I'll merge it today.

Tue, Jan 28, 12:47 PM · Restricted Project
fpetrogalli added inline comments to D73286: [llvm][VectorUtils] Tweak VFShape for scalable vector functions..
Tue, Jan 28, 12:47 PM · Restricted Project
efriedma accepted D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q).

LGTM

Tue, Jan 28, 12:47 PM · Restricted Project, Restricted Project
Whitney committed rGcd0cff43925a: [NFCI][LoopUnrollAndJam] Minor changes. (authored by Whitney).
[NFCI][LoopUnrollAndJam] Minor changes.
Tue, Jan 28, 12:35 PM
asbirlea committed rG4aa8cdfeebec: [LoopUnrollAndJamPass] Clean unnecessary includes. [NFCI] (authored by asbirlea).
[LoopUnrollAndJamPass] Clean unnecessary includes. [NFCI]
Tue, Jan 28, 12:35 PM
Whitney closed D73204: [NFCI][LoopUnrollAndJam] Minor changes..
Tue, Jan 28, 12:35 PM · Restricted Project
mtrent created D73574: Omit "Contents of" headers when -no-leading-headers is specified..
Tue, Jan 28, 12:35 PM · Restricted Project
spatel created D73575: [InstCombine] canonicalize splat shuffle after cmp.
Tue, Jan 28, 12:35 PM · Restricted Project
knaumov updated the diff for D71501: Cost Annotation Writer for InlineCost.

Changed unnecessarily complicated test

Tue, Jan 28, 12:35 PM · Restricted Project
MaskRay accepted D72829: Implement -fsemantic-interposition.

I suppose you mean whether "SemanticInterposition" should be invalidated when "PIC Level" does not exist or "PIE Level" exists. I am a bit inclined to make it more flexible/orthogonal in the backend, i.e. SemanticInterposition is in affect even if "PIE Level" is set.

OK, looks good as is, then?

Tue, Jan 28, 12:35 PM · Restricted Project, Restricted Project
jdoerfert added a comment to D73286: [llvm][VectorUtils] Tweak VFShape for scalable vector functions..

Sorry for my delay. Some comments below.

Tue, Jan 28, 12:35 PM · Restricted Project
davidxl accepted D73420: [llvm] Ensure InlineCost-related fields are initialized.

lgtm

Tue, Jan 28, 12:35 PM · Restricted Project
serge-sans-paille added a comment to D72829: Implement -fsemantic-interposition.

I suppose you mean whether "SemanticInterposition" should be invalidated when "PIC Level" does not exist or "PIE Level" exists. I am a bit inclined to make it more flexible/orthogonal in the backend, i.e. SemanticInterposition is in affect even if "PIE Level" is set.

Tue, Jan 28, 12:35 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D72829: Implement -fsemantic-interposition.
Tue, Jan 28, 12:23 PM · Restricted Project, Restricted Project
merge_guards_bot added a comment to D73569: [LoopUtils] Make duplicate method a utility. [NFCI].

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Tue, Jan 28, 12:23 PM · Restricted Project
nicolasvasilache updated the diff for D73145: [mlir][Linalg] Introduce folding patterns to remove certain MemRefCastOp.

Address review comments.

Tue, Jan 28, 12:23 PM · Restricted Project