Page MenuHomePhabricator
Feed All Stories

Today

Paul-C-Anagnostopoulos added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Thu, Jan 21, 6:49 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Of course there was another merge conflict in the release notes. Mental note to self: Put release note changes in separate commit.

Thu, Jan 21, 6:46 AM · Restricted Project, Restricted Project
tinloaf accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fixed the last spelling issues in the documentation. If the automated checks pass, this is ready for takeoff from my side. Thanks for your reviews!

Thu, Jan 21, 6:43 AM · Restricted Project, Restricted Project
StephenFan added a comment to D92479: [RISCV] remove redundant instruction when eliminate frame index.

ping...

Thu, Jan 21, 6:42 AM · Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix spelling issues in doc

Thu, Jan 21, 6:41 AM · Restricted Project, Restricted Project
tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Thu, Jan 21, 6:41 AM · Restricted Project, Restricted Project
dmgreen accepted D95039: [SVE] Add support for scalable vectorization of loops with selects and cmps.

The code changes look simple enough, LGTM.

Thu, Jan 21, 6:40 AM · Restricted Project
foad added a comment to D95132: [AMDGPU][GlobalISel] Run SIAddImgInit.

I think it would make more sense to do this during instruction selection, rather than in a separate pass, but for now it seems easiest to just copy what selectiondag does and run the pass.

Thu, Jan 21, 6:35 AM · Restricted Project
dmgreen updated the diff for D93476: [LV][ARM] Inloop reduction cost modelling.

Rename to getExtendedAddReductionCost and adjust some hasOneUse early exits.

Thu, Jan 21, 6:35 AM · Restricted Project
foad added reviewers for D95132: [AMDGPU][GlobalISel] Run SIAddImgInit: arsenm, rampitec, dstuttard, Petar.Avramovic, piotr.
Thu, Jan 21, 6:34 AM · Restricted Project
foad requested review of D95132: [AMDGPU][GlobalISel] Run SIAddImgInit.
Thu, Jan 21, 6:34 AM · Restricted Project
dmgreen added inline comments to D93476: [LV][ARM] Inloop reduction cost modelling.
Thu, Jan 21, 6:33 AM · Restricted Project
martong added a comment to D69726: [analyzer] DynamicSize: Store the dynamic size.

I was referred to this patch from https://reviews.llvm.org/D86743. I pulled this patch under review, brought it up to date and pushed to github at https://github.com/vabridgers/llvm-project-dev.git, branch: vla-fam-fixes. Everything seems ok on this branch (LITs pass, reproducers from https://bugs.llvm.org/show_bug.cgi?id=47272 and https://bugs.llvm.org/show_bug.cgi?id=28450 no longer crash). I can continue and push a change to Phabricator for review, or @Charusso and/or @balazske could finish this? I didn't want to just push an update without asking first :/ Cheers!

Thu, Jan 21, 6:33 AM · Restricted Project
ruiling added inline comments to D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.
Thu, Jan 21, 6:33 AM · Restricted Project
jhuber6 committed rGe4eaf9d82064: [OpenMP] Add support for mapping names in mapper API (authored by jhuber6).
[OpenMP] Add support for mapping names in mapper API
Thu, Jan 21, 6:27 AM
jhuber6 closed D94806: [OpenMP] Add support for mapping names in mapper API.
Thu, Jan 21, 6:27 AM · Restricted Project, Restricted Project, Restricted Project
probinson added a comment to D95114: HowToReleaseLLVM: Add annual release schedule template.

I think "Week number" is too ambiguous to be a guide. If January starts on the last day of the week, does that still count as week#1? What day does the week start on, anyway--much of the world starts the week on Sunday, much of the world starts the week on Monday.
"Fourth Tuesday in January/July" is unambiguous and makes everything easier to plan. Using "Start + N weeks" for the rest of the target dates is fine.

Thu, Jan 21, 6:25 AM · Restricted Project
sameeranjoshi added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Thu, Jan 21, 6:22 AM · Restricted Project, Restricted Project
arsenm closed D94823: AMDGPU: Add occupancy to serialized MachineFunctionInfo.

20566a2ed825c05d56708552d33d95ee12255f46

Thu, Jan 21, 6:21 AM · Restricted Project
arsenm committed rG20566a2ed825: AMDGPU: Add occupancy to serialized MachineFunctionInfo (authored by arsenm).
AMDGPU: Add occupancy to serialized MachineFunctionInfo
Thu, Jan 21, 6:21 AM
jpienaar updated the diff for D94868: [mlir] Enable passing crash reproducer stream factory method.

Exposing simpler API

Thu, Jan 21, 6:18 AM · Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Thu, Jan 21, 6:17 AM · Restricted Project, Restricted Project, Restricted Project
sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Summary of changes:

Thu, Jan 21, 6:14 AM · Restricted Project, Restricted Project
SjoerdMeijer accepted D94457: [AArch64] Add some missing fusion subtarget features.

The existing fusion tests seem a little bit weak—the machine scheduler with the base Cortex-A57 machine models that most of those use seemed to pass the address and literal fusion on its own (by coincidence?) without the explicit features requested. I was unable to make that test case stronger to see the A57 machine model not exploiting those fusion pairs when the feature was disabled. Is that worth worrying about?

Thu, Jan 21, 6:10 AM · Restricted Project
njames93 requested review of D95131: [CodeComplete] Add ranged for loops code pattern..
Thu, Jan 21, 6:07 AM · Restricted Project
teemperor committed rG37510f69b4cb: [lldb][NFC] Fix build with GCC<6 (authored by teemperor).
[lldb][NFC] Fix build with GCC<6
Thu, Jan 21, 6:06 AM
jeroen.dobbelaere updated the diff for D94306: [LoopRotate] Use llvm.experimental.noalias.scope.decl for duplicating noalias metadata as needed.

Adapted to comments

Thu, Jan 21, 6:01 AM · Restricted Project
critson added inline comments to D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.
Thu, Jan 21, 5:57 AM · Restricted Project
critson updated the diff for D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.
  • Address review comments.
Thu, Jan 21, 5:56 AM · Restricted Project
jeroen.dobbelaere updated the diff for D92887: [LoopUnroll] Use llvm.experimental.noalias.scope.decl for duplicating noalias metadata as needed.

Adapted to comments.

Thu, Jan 21, 5:56 AM · Restricted Project
asb accepted D95106: [RISCV] Add isel patterns for SH*ADD(.UW).

These LGTM. This patch should presumably be marked dependent on D94637.

Thu, Jan 21, 5:55 AM · Restricted Project
asb added a comment to D95002: [RISCV] Update B extension version to 0.93..

I don't think any of the other patches in the stack update the comment at the top of RISCVInstrInfoB.td to say "version 0.92" rather than "version 0.93", and this is probably a reasonable patch to do it in.

Thu, Jan 21, 5:51 AM · Restricted Project
antiagainst requested changes to D95120: [mlir][StandardToSPIRV] Add support for lowering uitofp to SPIR-V.
Thu, Jan 21, 5:44 AM · Restricted Project
jrtc27 added inline comments to D94931: [RISCV] Add attribute support for all supported extensions.
Thu, Jan 21, 5:38 AM · Restricted Project
mib updated the summary of D95100: [lldb/Commands] Fix short option collision for `process launch`.
Thu, Jan 21, 5:37 AM · Restricted Project
csigg updated the diff for D94495: [mlir] Set CUDA/ROCm context before creating resources..

Rebase.

Thu, Jan 21, 5:33 AM · Restricted Project
balazske committed rG726de41e2bfb: [clang][AST] Add get functions for CXXFoldExpr paren locations. (authored by balazske).
[clang][AST] Add get functions for CXXFoldExpr paren locations.
Thu, Jan 21, 5:27 AM
jhenderson updated the diff for D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references.

Change to use separate output file to aid debugging.

Thu, Jan 21, 5:27 AM · Restricted Project
balazske closed D94787: [clang][AST] Add get functions for CXXFoldExpr paren locations..
Thu, Jan 21, 5:27 AM · Restricted Project
asb added inline comments to D94931: [RISCV] Add attribute support for all supported extensions.
Thu, Jan 21, 5:24 AM · Restricted Project
SjoerdMeijer added inline comments to D93476: [LV][ARM] Inloop reduction cost modelling.
Thu, Jan 21, 5:24 AM · Restricted Project
asb added a comment to D94403: [RISCV] Implement new architecture extension macros.

@kito-cheng could you please confirm that this patch handles sub-extensions in the same way GCC does. i.e. -march=rv32izbb0p92 defines __riscv_zbb but NOT __riscv_b? That seems logical to me, as otherwise it would be cumbersome to check if the whole extension is supported rather than just a subset, but I just wanted to confirm.

Thu, Jan 21, 5:18 AM · Restricted Project
csigg added inline comments to D94495: [mlir] Set CUDA/ROCm context before creating resources..
Thu, Jan 21, 5:15 AM · Restricted Project
azabaznov updated the diff for D92277: [OpenCL] Refactor of targets OpenCL option settings.

Thanks for feedback. I agree that providing diagnostics for unsupported core features is enough for now (I guess I'll try to come up with something for OpenCL C 3.0 features to set them unconditionally for 2.0, or at least these macros can be defined in header only). So I removed setting of core features (and also addressed all cosmetic concerns).

Thu, Jan 21, 5:15 AM
csigg updated the diff for D94495: [mlir] Set CUDA/ROCm context before creating resources..

Switch to primary context.

Thu, Jan 21, 5:14 AM · Restricted Project
spatel committed rG070af1b7887f: [InstCombine] avoid crashing on attribute propagation (authored by spatel).
[InstCombine] avoid crashing on attribute propagation
Thu, Jan 21, 5:13 AM
spatel closed D95088: [InstCombine] avoid crashing on attribute propagation.
Thu, Jan 21, 5:13 AM · Restricted Project
uabelho committed rG2b4716d6dff1: [MC] Use std::make_tuple to make some toolchains happy again (authored by uabelho).
[MC] Use std::make_tuple to make some toolchains happy again
Thu, Jan 21, 5:13 AM
frgossen committed rG4ef38f9c1255: Add log1p lowering from standard to ROCDL intrinsics (authored by frgossen).
Add log1p lowering from standard to ROCDL intrinsics
Thu, Jan 21, 5:03 AM
frgossen closed D95129: Add log1p lowering from standard to ROCDL intrinsics.
Thu, Jan 21, 5:03 AM · Restricted Project
RKSimon committed rG69bc0990a918: [DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE… (authored by RKSimon).
[DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE…
Thu, Jan 21, 5:02 AM
frgossen committed rG294e2544c992: Add log1p lowering from standard to NVVM intrinsics (authored by frgossen).
Add log1p lowering from standard to NVVM intrinsics
Thu, Jan 21, 5:01 AM
frgossen closed D95130: Add log1p lowering from standard to NVVM intrinsics.
Thu, Jan 21, 5:01 AM · Restricted Project
herhut accepted D95130: Add log1p lowering from standard to NVVM intrinsics.
Thu, Jan 21, 4:59 AM · Restricted Project
herhut accepted D95129: Add log1p lowering from standard to ROCDL intrinsics.

Thanks!

Thu, Jan 21, 4:58 AM · Restricted Project
frgossen requested review of D95130: Add log1p lowering from standard to NVVM intrinsics.
Thu, Jan 21, 4:56 AM · Restricted Project
frgossen requested review of D95129: Add log1p lowering from standard to ROCDL intrinsics.
Thu, Jan 21, 4:55 AM · Restricted Project
vsavchenko updated the diff for D93630: [Attr] Apply GNU-style attributes to expression statements.

Add more tests

Thu, Jan 21, 4:55 AM · Restricted Project
HazardyKnusperkeks requested review of D95128: [clang-format] [NFC] Remove unsued arguments.
Thu, Jan 21, 4:54 AM · Restricted Project, Restricted Project
grimar accepted D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references.

LGTM with a nit, please wait for others.

Thu, Jan 21, 4:54 AM · Restricted Project
spatel added inline comments to D95088: [InstCombine] avoid crashing on attribute propagation.
Thu, Jan 21, 4:54 AM · Restricted Project
jhenderson updated the diff for D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references.

Reupload diff. Previous diff somehow was missing one of the changes.

Thu, Jan 21, 4:43 AM · Restricted Project
grimar added a comment to D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references.

missing check-prefix. Not sure how I didn't spot the latter...

Thu, Jan 21, 4:42 AM · Restricted Project
HazardyKnusperkeks updated the diff for D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix.

Empty lines removed.

Thu, Jan 21, 4:41 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D95127: [flang][driver] Disallow non-existent input files in the frontend driver: FarisRehman, sameeranjoshi, AMDChirag, kiranktp, CarolineConcatto, kiranchandramohan.
Thu, Jan 21, 4:41 AM · Restricted Project, Restricted Project
RKSimon committed rG0ca81b90d19d: [X86][SSE] Add uitofp(trunc(and(lshr(x,c)))) vector test (authored by RKSimon).
[X86][SSE] Add uitofp(trunc(and(lshr(x,c)))) vector test
Thu, Jan 21, 4:40 AM
RKSimon committed rG935bacd3a724: [DAG] SimplifyDemandedBits - correctly adjust truncated shift amount type (authored by RKSimon).
[DAG] SimplifyDemandedBits - correctly adjust truncated shift amount type
Thu, Jan 21, 4:40 AM
teemperor committed rGed2853d2c82d: Reland [lldb] Fix TestThreadStepOut.py after "Flush local value map on every… (authored by teemperor).
Reland [lldb] Fix TestThreadStepOut.py after "Flush local value map on every…
Thu, Jan 21, 4:36 AM
mib added a reviewer for D95100: [lldb/Commands] Fix short option collision for `process launch`: Restricted Project.
Thu, Jan 21, 4:36 AM · Restricted Project
andreadb added inline comments to D86644: [llvm-mca] Initial implementation of output serialization using JSON.
Thu, Jan 21, 4:33 AM · Restricted Project
jhenderson added inline comments to D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references.
Thu, Jan 21, 4:30 AM · Restricted Project
jhenderson updated the diff for D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references.

Fix reference to stale object and missing check-prefix. Not sure how I didn't spot the latter...

Thu, Jan 21, 4:29 AM · Restricted Project
awarzynski requested review of D95127: [flang][driver] Disallow non-existent input files in the frontend driver.
Thu, Jan 21, 4:28 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D95017: [clang-format] add case aware include sorting.

LGTM.

Thu, Jan 21, 4:27 AM · Restricted Project, Restricted Project
andreadb added a comment to D86644: [llvm-mca] Initial implementation of output serialization using JSON.

I can see that InstructionView has been moved outside of View.h into its own file, but I cannot see that new file anywhere in this diff.

Thu, Jan 21, 4:19 AM · Restricted Project
ruiling added a comment to D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.

There is still an issue if the SGPR used to hold the input llvm.amdgcn.init.exec.from.input is spilt; however, this is not a new issue.
From my testing llvm.amdgcn.init.exec.from.input actually only worked in the entry block previous to this change, so we could tighten its description even further.

I am not sure what the problem is. May be we can fix it later. But I don't want to restrict it can only be used in the entry block for now unless we later prove that is really hard to make it correct. We may possibly use it for the second part of the merged shader.

Thu, Jan 21, 4:19 AM · Restricted Project
andrewng added a comment to rGf96ff3c0f8eb: [ELF] --wrap: Produce a dynamic symbol for undefined __wrap_.

This change broke one of our downstream tests and the issue can be reproduced with the following test:

# REQUIRES: x86
Thu, Jan 21, 4:18 AM
grimar added inline comments to D95124: [lld][ELF][test] Add testing for IE/LD TLS weak undef references.
Thu, Jan 21, 4:16 AM · Restricted Project
zatrazz added a comment to D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Ping.

Thu, Jan 21, 4:14 AM · Restricted Project
thopre added a reviewer for D94766: Add lit env variable to disable indirect checks: jdenny.

Ping?

Thu, Jan 21, 4:12 AM · Restricted Project
SjoerdMeijer added inline comments to D93476: [LV][ARM] Inloop reduction cost modelling.
Thu, Jan 21, 4:11 AM · Restricted Project
HazardyKnusperkeks updated the diff for D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix.

Now with assert.

Thu, Jan 21, 4:11 AM · Restricted Project, Restricted Project
teemperor added a comment to D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

Not sure why we even run the DSYM variant if the test disables building DSYM. I just made this a no-debug-info-test in 060b51e0524aed6b6cc452baa8eb6d663a580eee which gets it running again on the bots for now.

Thu, Jan 21, 4:11 AM · Restricted Project
frasercrmck added inline comments to D94999: [RISCV] Add xperm.* instructions to Zbp extension..
Thu, Jan 21, 4:10 AM · Restricted Project
teemperor committed rG060b51e0524a: [lldb] Make TestBSDArchives a no-debug-info-test (authored by teemperor).
[lldb] Make TestBSDArchives a no-debug-info-test
Thu, Jan 21, 4:09 AM
frasercrmck accepted D94736: [RISCV] Change zext.w to be an alias of add.uw rd, rs1, x0 instead of pack..

LGTM, but should we document these "extra" things we're doing on top of the published spec? I'm not sure where, but it might help someone reading the spec as written.

Thu, Jan 21, 4:08 AM · Restricted Project
david-arm added inline comments to D95039: [SVE] Add support for scalable vectorization of loops with selects and cmps.
Thu, Jan 21, 4:07 AM · Restricted Project
david-arm updated the diff for D95039: [SVE] Add support for scalable vectorization of loops with selects and cmps.
  • Added more cost model test cases and optimised existing ones.
  • Renamed vectorisation tests to something more useful. :) I also reduced the number of CHECK lines as it looked too messy and fragile.
Thu, Jan 21, 4:05 AM · Restricted Project
teemperor added a comment to D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

This is breaking the functionalities/archives/TestBSDArchives.py test on macOS. It seems the MAKE_DSYM flag somehow looses its effect when the dsym version of the test is running (and then we fail generating a dsym without input files): http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/27711/testReport/junit/lldb-api/functionalities_archives/TestBSDArchives_py/

Thu, Jan 21, 4:04 AM · Restricted Project
jmorse updated the diff for D94976: [DWARF] Create subprogram's DIE in the unit specified by its DISubprogram.

Replace regression test with David's smaller test

Thu, Jan 21, 4:03 AM · Restricted Project
bsmith updated the diff for D94401: [AArch64][SVE] Allow accesses to SVE stack objects to use frame pointer.
  • Remove duplicate tests
  • Some code cleanups as per review comments
Thu, Jan 21, 4:03 AM · Restricted Project
frasercrmck accepted D94818: [RISCV] Add zext.h instruction to Zbb..

LGTM

Thu, Jan 21, 4:03 AM · Restricted Project
dmgreen updated the diff for D93476: [LV][ARM] Inloop reduction cost modelling.
Thu, Jan 21, 4:00 AM · Restricted Project
dmgreen added inline comments to D93476: [LV][ARM] Inloop reduction cost modelling.
Thu, Jan 21, 4:00 AM · Restricted Project
sdmitriev requested review of D95126: [llvm-link] Fix for an assertion when linking global with appending linkage.
Thu, Jan 21, 4:00 AM · Restricted Project
frasercrmck accepted D94944: [RISCV] Add support for rev8 and orc.b to Zbb..

LGTM

Thu, Jan 21, 4:00 AM · Restricted Project
samparker requested review of D95125: [WebAssembly] Enable loop unrolling.
Thu, Jan 21, 3:57 AM · Restricted Project
frasercrmck accepted D95090: [RISCV] Modify add.uw patterns to put the masked operand in rs1 to match 0.93 bitmanip spec..

LGTM

Thu, Jan 21, 3:52 AM · Restricted Project
frgossen added a comment to D95041: [MLIR][Standard] Add log1p operation to std.
Thu, Jan 21, 3:51 AM · Restricted Project
frasercrmck added a comment to D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec..

My hope is to get the 0.93 move into LLVM 12. Zbb is marked frozen in the 0.93 spec and does not include these. So I'd at least like them out of Zbb. Would it be better to just remove them until they have a home?

Thu, Jan 21, 3:48 AM · Restricted Project