Page MenuHomePhabricator
Feed All Stories

Today

fedor.sergeev added a comment to D54472: Disable invalid isPodLike<> specialization.

I'm sorry to bring bad news, but this fails for our gcc 4.9.2 build, when building llvm/tools/llvm-xray/xray-converter.cpp.
Failures looks like this:

Mon, Jan 21, 3:20 AM
markus created D57010: Fix sign/zero extension in Dwarf expressions (with pseudo ops).
Mon, Jan 21, 3:17 AM
mgorny added a comment to D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.

LGTM to unbreak the tests on *BSD, but could you please leave a comment?
It would probably be best to take argv[0] into account on *BSD systems as well (possibly only if clang could not be found).

At least if that's the behaviour on all other systems.

Mon, Jan 21, 3:04 AM
teemperor resigned from D55424: [analyzer] Supply all checkers with a shouldRegister function.
Mon, Jan 21, 3:02 AM
sam_parker committed rC351740: [AArch64] Use LL for 64-bit intrinsic arguments.
[AArch64] Use LL for 64-bit intrinsic arguments
Mon, Jan 21, 3:01 AM
sam_parker committed rL351740: [AArch64] Use LL for 64-bit intrinsic arguments.
[AArch64] Use LL for 64-bit intrinsic arguments
Mon, Jan 21, 3:01 AM
Diffusion closed D56852: [AArch64] Use LL for 64-bit arguments.
Mon, Jan 21, 3:01 AM
RKSimon added inline comments to D56987: [Intrinsic] Expand vector SMULFIX to MUL on zero scale.
Mon, Jan 21, 2:52 AM
jhenderson added inline comments to D57006: [llvm-objcopy] [COFF] Update symbol indices in weak externals.
Mon, Jan 21, 2:50 AM
jhenderson added a comment to D56873: [llvm-objcopy] [COFF] Implement --only-section.

-EMPTY essentially implies -NEXT, it requires the next line to either be empty, or there to be EOF here. I haven't intended to use them combined but apparently I did do that in the paragraph above this. I'll change that one for consistency with the rest (that's the only one I have with NEXT-EMPTY at all).

For the record, you can't combine FileCheck suffixes (e.g. CHECK-NEXT-NOT is a NOT using a check prefix of CHECK-NEXT). There are some error checks to catch this, but I don't know how comprehensive they are.

Mon, Jan 21, 2:42 AM
jhenderson added a comment to D56840: [llvm-objcopy] [COFF] Implement --only-keep-debug.

Oops, yeah, I forgot for a moment that GNU output style is (currently) ELF-specific.

Mon, Jan 21, 2:35 AM
jhenderson added a comment to D56683: [llvm-objcopy] [COFF] Add support for removing sections.

@jakehehrlich , @jhenderson, @rupprecht - maybe you have some other thoughts / I'm missing something ?

Just a quick drive-by comment to add to what @rupprecht said. Conceptually to me, the Object should be "final" when all of its details are consistent to represent a valid Object. Section indices are a good example, since there are sections within the Object, but until finalize is called, they don't have valid index values. As a result, a finalize method on the Object probably makes sense to achieve this. Writer meanwhile wants to handle the extra information that is specific to the file format, and not really generic in any meaningful sense (e.g. program headers). I agree that it's going to be hard to have a hard-and-fast rule though.

Mon, Jan 21, 2:34 AM
kadircet added inline comments to D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB..
Mon, Jan 21, 2:29 AM
kadircet updated the diff for D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB..

Address comments

Mon, Jan 21, 2:29 AM
abeserminji updated the diff for D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

Updated the patch, so that the extra flags are added only when -static option is used.
Used @atanasyan 's solution for CMakeLists.txt from D56836#1362293.
Made equivalent for the Makefile.

Mon, Jan 21, 2:29 AM
critson added a comment to D56496: [AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs.

Ping

Mon, Jan 21, 2:26 AM
filcab added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
In D56485#1364241, @pcc wrote:

This change would only impact the "diagnostic" (non-production) mode of CFI. In production builds we do not link the runtime library at all. So from a CFI perspective this is fine.

Mon, Jan 21, 2:26 AM
jhenderson accepted D56930: [llvm-objcopy] Return Error from Buffer::allocate(), [ELF]Writer::finalize(), and [ELF]Writer::commit().

LGTM.

Mon, Jan 21, 2:23 AM
RKSimon added reviewers for D57000: [llvm-exegesis] Add throughput mode.: RKSimon, andreadb.
Mon, Jan 21, 2:21 AM
mstorsjo created D57009: [llvm-objcopy] [COFF] Fix handling of aux symbols for big objects.
Mon, Jan 21, 2:18 AM
jhenderson added inline comments to D55839: [elfabi] Add support for writing ELF header for binary stubs.
Mon, Jan 21, 2:17 AM
teemperor committed rL351739: [ASTImporter] Add test for importing anonymous namespaces..
[ASTImporter] Add test for importing anonymous namespaces.
Mon, Jan 21, 2:17 AM
teemperor committed rC351739: [ASTImporter] Add test for importing anonymous namespaces..
[ASTImporter] Add test for importing anonymous namespaces.
Mon, Jan 21, 2:16 AM
teemperor closed D51178: [ASTImporter] Add test for importing anonymous namespaces..
Mon, Jan 21, 2:16 AM
tpr added reviewers for D57008: [AMDGPU] With XNACK, cannot clause a load with result coalesced with operand: rampitec, vpykhtin.
Mon, Jan 21, 2:12 AM
kadircet committed rCTE351738: [clang-tidy] Use getStripPluginsAdjuster.
[clang-tidy] Use getStripPluginsAdjuster
Mon, Jan 21, 2:10 AM
kadircet committed rL351738: [clang-tidy] Use getStripPluginsAdjuster.
[clang-tidy] Use getStripPluginsAdjuster
Mon, Jan 21, 2:10 AM
kadircet closed D56902: [clang-tidy] Use getStripPluginsAdjuster.
Mon, Jan 21, 2:10 AM
aadg committed rL351737: [EuroLLVM'19] Fix PC members list..
[EuroLLVM'19] Fix PC members list.
Mon, Jan 21, 2:10 AM
teemperor updated the diff for D51178: [ASTImporter] Add test for importing anonymous namespaces..
  • Added a comment that the using directives are created by Sema.
Mon, Jan 21, 2:09 AM
tpr created D57008: [AMDGPU] With XNACK, cannot clause a load with result coalesced with operand.
Mon, Jan 21, 2:09 AM
mstorsjo created D57007: [llvm-objcopy] [COFF] Implement --add-gnu-debuglink.
Mon, Jan 21, 2:05 AM
mstorsjo created D57006: [llvm-objcopy] [COFF] Update symbol indices in weak externals.
Mon, Jan 21, 2:04 AM
chandlerc committed rL351736: Add another company that has signed..
Add another company that has signed.
Mon, Jan 21, 2:03 AM
krytarowski added a comment to D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

I'd really prefer to keep the argv[0] code as is. I'm not sure what that test case is supposed to do, but it seems quite questionable as "check" is not a valid language frontend nor a version suffix. It should not work.

Mon, Jan 21, 2:03 AM
Quolyk added a comment to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

@jhenderson thanks a lot for review and remarks. That is very valuable.

Mon, Jan 21, 2:03 AM
Quolyk committed rL351735: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
[llvm-symbolizer] Add -no-demangle as alias for -demangle=false
Mon, Jan 21, 2:01 AM
Quolyk closed D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Mon, Jan 21, 2:01 AM
ilya-biryukov added a comment to D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.

LGTM to unbreak the tests on *BSD, but could you please leave a comment?
It would probably be best to take argv[0] into account on *BSD systems as well (possibly only if clang could not be found).

Mon, Jan 21, 1:59 AM
ilya-biryukov added inline comments to D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.
Mon, Jan 21, 1:59 AM
chandlerc committed rL351734: Move NetBSD to the signed list. I still need to do a major update here to.
Move NetBSD to the signed list. I still need to do a major update here to
Mon, Jan 21, 1:56 AM
chandlerc committed rCXX351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:55 AM
chandlerc committed rPSTL351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:54 AM
steveire committed rL351733: Fix test after AST dump output change.
Fix test after AST dump output change
Mon, Jan 21, 1:54 AM
steveire committed rLLDB351733: Fix test after AST dump output change.
Fix test after AST dump output change
Mon, Jan 21, 1:54 AM
chandlerc committed rCXXA351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:54 AM
chandlerc committed rCTE351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:54 AM
chandlerc committed rC351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:54 AM
chandlerc committed rL351732: Put the new license into place at the top of the website. We now have many.
Put the new license into place at the top of the website. We now have many
Mon, Jan 21, 1:54 AM
chandlerc committed rLLDB351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:53 AM
chandlerc committed rUNW351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:53 AM
chandlerc committed rLLD351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:53 AM
chandlerc committed rL351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:53 AM
chandlerc committed rCRT351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:53 AM
chandlerc committed rOMP351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Mon, Jan 21, 1:52 AM
evgeny777 committed rCRT351730: [HWASAN] Improve tag mismatch diagnostics.
[HWASAN] Improve tag mismatch diagnostics
Mon, Jan 21, 1:51 AM
evgeny777 committed rL351730: [HWASAN] Improve tag mismatch diagnostics.
[HWASAN] Improve tag mismatch diagnostics
Mon, Jan 21, 1:51 AM
evgeny777 closed D56603: [HWASAN] Improve tag-mismatch diagnostics.
Mon, Jan 21, 1:51 AM
dmgreen added a comment to D56008: [ARM] Alter the register allocation order for optsize on Thumb2.

I had not seen that, thanks for pointing to it. Yes, this is a bit simpler, not trying to deal with r12. Just using the default allocation order only gets us so far, but it seems like a simple enough change. I had tried a few different orderings around using r4/r7 before lr, for example, as they are often spilled in pairs, but this seemed to give the best results for the codebases I tried.

Mon, Jan 21, 1:50 AM
Szelethus accepted D35068: [analyzer] Detect usages of unsafe I/O functions.

Yup, I'm sold on that.

Mon, Jan 21, 1:44 AM
jhenderson accepted D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

LGTM.

Mon, Jan 21, 1:42 AM
mstorsjo created D57005: [LLD] [docs] Amend the release notes with more things I've contributed since the last release.
Mon, Jan 21, 1:42 AM
mstorsjo added inline comments to D57004: [docs] Add release notes for notable things I've contributed since last release.
Mon, Jan 21, 1:41 AM
jhenderson added inline comments to D56910: [llvm-readelf]Revert --dyn-symbols behaviour to make it GNU compatible, and add new --hash-symbols switch for old behaviour.
Mon, Jan 21, 1:41 AM
mstorsjo created D57004: [docs] Add release notes for notable things I've contributed since last release.
Mon, Jan 21, 1:38 AM
mstorsjo created D57003: [docs] Add release notes for notable things I've contributed since last release.
Mon, Jan 21, 1:37 AM
joerg added a comment to D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

I'd really prefer to keep the argv[0] code as is. I'm not sure what that test case is supposed to do, but it seems quite questionable as "check" is not a valid language frontend nor a version suffix. It should not work.

Mon, Jan 21, 1:26 AM
craig.topper created D57002: [X86] Change avx512 COMPRESS and EXPAND lowering to use a single masked node instead of expand/compress+select..
Mon, Jan 21, 1:24 AM
hokein accepted D56424: [clang-tidy] Add check for underscores in googletest names..

Sorry for the delay, I was OOO last week. The check looks good.

Mon, Jan 21, 1:19 AM · Restricted Project
xazax.hun added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

To add an analogy, Clang Tidy will not require C++ Core Guidelines related checks to be evaluated on projects that are not following the guidelines as the results are meaningless for those projects.

Mon, Jan 21, 1:07 AM
xazax.hun added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

I've evaluated this checker on LLVM+Clang, there were only a few (about 15) warnings, because of the C11 flag check at the beginning of the checker body. However, if this check was removed, number of the warnings would be increased significantly. I wouldn't say the findings were real security issues, most of the warnings were about usages of deprecated functions, which has not been considered unsecure (but which may cause problems if the code is modified in an improper way in the future).

My problem is that LLVM+Clang isn't really a C (nor a C11) project, and I think judging this checker on it is a little misleading. Could you please test it on some C11 projects? I think tmux uses C11.

Edit: it doesn't, but CMake is mostly a C project and it does!

Mon, Jan 21, 1:05 AM
Szelethus added a comment to D54429: [analyzer] Creating standard Sphinx documentation.

Cheers, this is as good as it gets! IRL we also mentioned making a unipage for each checker which would be awesome (and would require a lot of tedious work), but as a start, I'd much prefer browsing through this doc than the current one. Very much appreciated!

Mon, Jan 21, 12:57 AM · Restricted Project
bjope added a comment to D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic.

Should https://reviews.llvm.org/D56987 be a parent for this? Then you'd need to rebase getExpandedFixedPointMultiplication since that has changed into converting into MUL when scale is zero (that is not valid for saturation).

Mon, Jan 21, 12:54 AM
mstorsjo created D57001: [libunwind] Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__.
Mon, Jan 21, 12:49 AM
MyDeveloperDay added a project to D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️: Restricted Project.
Mon, Jan 21, 12:49 AM · Restricted Project
bjope added a comment to D56987: [Intrinsic] Expand vector SMULFIX to MUL on zero scale.

How common would it be that the scale is zero? Is that really expected in reality or just in this kind of handwritten test cases?

Mon, Jan 21, 12:47 AM
courbet updated the diff for D57000: [llvm-exegesis] Add throughput mode..

fix typo

Mon, Jan 21, 12:36 AM
courbet created D57000: [llvm-exegesis] Add throughput mode..
Mon, Jan 21, 12:36 AM
Szelethus retitled D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments from [analyzer][NFC] Fully initialize CheckerRegistry in by the end of construction to [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments.
Mon, Jan 21, 12:24 AM
balazske added inline comments to D56936: Fix handling of overriden methods during ASTImport.
Mon, Jan 21, 12:20 AM
ctopper committed rL351729: [X86] Remove and autoupgrade vpmovqd/vpmovwb intrinsics using trunc+select..
[X86] Remove and autoupgrade vpmovqd/vpmovwb intrinsics using trunc+select.
Mon, Jan 21, 12:19 AM
courbet added a comment to D54318: [WIP][llvm-exegesis] Add support for memory instructions in latency mode..

Is something like this still planned?
Looks like this 'kinda' stalled.

Mon, Jan 21, 12:12 AM
grimar accepted D56910: [llvm-readelf]Revert --dyn-symbols behaviour to make it GNU compatible, and add new --hash-symbols switch for old behaviour.

Patch looks reasonable to me too.

Mon, Jan 21, 12:06 AM

Yesterday

serge_sans_paille committed rL351728: Tentative fix for r351701 and gcc 6.2 build on ubuntu.
Tentative fix for r351701 and gcc 6.2 build on ubuntu
Sun, Jan 20, 11:45 PM
serge_sans_paille committed rLLD351728: Tentative fix for r351701 and gcc 6.2 build on ubuntu.
Tentative fix for r351701 and gcc 6.2 build on ubuntu
Sun, Jan 20, 11:45 PM
mkazantsev committed rL351727: [NFC] Make getExpressionSize unsigned short.
[NFC] Make getExpressionSize unsigned short
Sun, Jan 20, 11:37 PM
Quolyk added inline comments to D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.
Sun, Jan 20, 11:32 PM
grimar added a comment to D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.

! In D56920#1364896, @MaskRay wrote:
Both ld.bfd and gold have the similar "small_toc_reloc" notation and binutils-gdb/gold/power.cc does similar TOC sorting (ld.bfd has a much more complicated rule).
https://sourceware.org/git/?p=binutils-gdb.git;a=blob;hb=dff021e14a9c72380311c15a90c1a646b179b987;f=gold/powerpc.cc#l8376

Sun, Jan 20, 11:29 PM
mkazantsev committed rL351726: [NFC] Fix warnings in unit test of r351725.
[NFC] Fix warnings in unit test of r351725
Sun, Jan 20, 11:28 PM
Quolyk updated the diff for D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false.

Used clang-format -style='{ReflowComments: true}'.

Sun, Jan 20, 11:27 PM
MaskRay added a comment to D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.

I am not PPC expert, but approach itself seems probably OK to me. At least I do not have good ideas on how to do what you want much simpler/better atm.
Maybe other reviewers will have something.

My comments/suggestions are below.

Also, do you know how this problem is solved by the GNU linkers?

Sun, Jan 20, 11:21 PM
andrewluo added inline comments to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Sun, Jan 20, 11:21 PM
mstorsjo added a comment to D56979: [libcxxabi] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree.

Does libc++ need a similar change?

Sun, Jan 20, 11:17 PM
craig.topper added reviewers for D56990: Bugfix for Replacement of tied operand of inline asm: echristo, efriedma, rnk.
Sun, Jan 20, 11:11 PM · Restricted Project
xiangzhangllvm added a reviewer for D56990: Bugfix for Replacement of tied operand of inline asm: vzakhari.
Sun, Jan 20, 11:10 PM · Restricted Project
MaskRay added inline comments to D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.
Sun, Jan 20, 11:02 PM
craig.topper retitled D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics. from [X86] Custom codegen 512 integer to fp conversion intrinsics. to [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics..
Sun, Jan 20, 10:36 PM
craig.topper created D56999: [X86] Remove GCCBuiltins from 512-bit cvt(u)qqtops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics. Add new variadic uitofp/sitofp with rounding mode intrinsics..
Sun, Jan 20, 10:36 PM
craig.topper added a reviewer for D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics.: spatel.
Sun, Jan 20, 10:36 PM
craig.topper created D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics..
Sun, Jan 20, 10:32 PM