Feed All Stories

Today

sammccall added a comment to D49417: [clangd] Implement trigram generation algorithm for new symbol index.

Addressed all comments submitted by Eric.

As discussed internally, I should also exercise my naming skills and come up with a better for the symbol index to substitute "Noctem" which doesn't point to any project's feature.

Thu, Jul 19, 2:39 AM · Restricted Project
JDevlieghere added inline comments to D49493: [DebugInfo] Reduce debug_str_offsets section size.
Thu, Jul 19, 2:39 AM
RKSimon committed rL337445: [DAGCombiner] Add rotate-extract tests.
[DAGCombiner] Add rotate-extract tests
Thu, Jul 19, 2:32 AM
serge_sans_paille committed rL337444: Use std::reference_wrapper instead of llvm::ReferenceStorage.
Use std::reference_wrapper instead of llvm::ReferenceStorage
Thu, Jul 19, 2:29 AM
Diffusion closed D49298: Use std::reference_wrapper instead of llvm::ReferenceStorage.
Thu, Jul 19, 2:29 AM
dberris committed rCRT337443: [XRay][compiler-rt] Profiling: No files when empty.
[XRay][compiler-rt] Profiling: No files when empty
Thu, Jul 19, 2:25 AM
dberris committed rL337443: [XRay][compiler-rt] Profiling: No files when empty.
[XRay][compiler-rt] Profiling: No files when empty
Thu, Jul 19, 2:25 AM
RKSimon committed rL337442: Fix spelling mistake in comments. NFCI..
Fix spelling mistake in comments. NFCI.
Thu, Jul 19, 2:20 AM
aleksandr.urakov added a comment to D49018: Convert a location information from PDB to a DWARF expression.

Can you explain me, please, why do you think that we should remove these spaces?

Thu, Jul 19, 2:04 AM
fhahn accepted D49408: [SCCP] Don't use markForcedConstant on branch conditions..

LGTM, thanks!

Thu, Jul 19, 2:03 AM
jmorse added a comment to D46866: [EarlyCSE] Avoid a poorly defined instruction comparison.

ping @reames , does the inline comment clear up the question?

Thu, Jul 19, 2:03 AM
jmorse added a comment to D48072: Sema: Fix PR12350 destructor name lookup, addressing (some of) DR244.

Ping

Thu, Jul 19, 2:00 AM
fhahn abandoned D49384: [IPSCCP] Do not zap return if the return value is overdefined at any call site..

Abandoned in favor of D49408

Thu, Jul 19, 1:55 AM
fhahn added a comment to D48327: [IPSCC] Drop ParamState lattice value when marking a value as force constant..

Abandoned in favor of D49408

Thu, Jul 19, 1:55 AM
srhines updated the diff for D49534: Handle the lack of a symbol table correctly..

Ran git-clang-format and added rationale to the test.

Thu, Jul 19, 1:55 AM
srhines created D49534: Handle the lack of a symbol table correctly..
Thu, Jul 19, 1:51 AM
llvm-commits updated subscribers of D49460: Flush counters before forking to avoid counting the execution before fork twice.

Il 18/07/2018 20:52, David Li via Phabricator ha scritto:

Thu, Jul 19, 1:43 AM
ioeric added a comment to D49476: [Index] Set OrigD before D is changed..

Is it possible to add a regression test case ? I assume this is fixing some issue, we should make sure we don't regress again.

This fixes a downstream use case where we use OrigD. AFAICT, c-index-test is used to tests the index library, but it doesn't seem to use OrigD at all. We could probably add a flag to c-index-test to optionally print out OrigD. I didn't go down this path because I thought this change is trivial and doesn't break any existing changes. If you think optionally checking OrigD is reasonable, I'd be happy to add that with a test case.

Thu, Jul 19, 1:25 AM
petpav01 added a comment to D49364: [ARM] Add support for spilling high registers in Thumb1.

This is possibly problematic when the register pressure is high because ThumbRegisterInfo::saveScavengerRegister() currently also tries to make use of high register r12.

Also, the constant islands pass can clobber lr. But given the only way to end up with an "hGPR" register class is inline asm, we could probably work around this issue by excluding ip/lr from allocation order for hGPR.

That said, if we ever want to make the high registers generally allocatable in Thumb1 mode, this patch probably isn't the right solution; instead, we should make the register allocator insert the copy, so we aren't forced to scavenge a register later.

Thu, Jul 19, 12:53 AM
samparker accepted D49444: [DAG] Avoid Node Update assertion due to AND simplification.

LGTM, thanks!

Thu, Jul 19, 12:49 AM
petpav01 updated the diff for D49364: [ARM] Add support for spilling high registers in Thumb1.
Thu, Jul 19, 12:41 AM
atanasyan created D49533: [mips] Move out the WrapperPat declaration from the NotInMicroMips predicate.
Thu, Jul 19, 12:41 AM
grimar added a comment to D49371: [ELF] - Do not produce broken output when amount of sections is > ~65k.

Do you really need this? That the spec says something doesn't always mean that we need it. I'm afraid that all these nitpicky details would accumulate and make the entire program hard to read. Even though I'm not against "doing it right", I really want you to show some examples to convince others that we need it.

Thu, Jul 19, 12:29 AM
tatyana-krasnukha updated the diff for D49017: Replace "nullptr-terminated" C-array with safer llvm::ArrayRef for PropertyDefinition and OptionDefinition..

Thank you for pointing this problem. Though ArrayRef constructor with std::array parameter is declared as constexpr, it is not a constant expression actually because std::array::data() member function is not constexpr until C++17.
So, I reverted using std::array and added constexpr keyword to each static PropertyDefinition and OptionDefinition to ensure that constant initialization requirements remain satisfied.

Thu, Jul 19, 12:28 AM

Yesterday

baloghadamsoftware added a comment to D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option).
In D41938#1167313, @NoQ wrote:

There are still performance regressions coming in, and this time it doesn't look like it's my fault: https://bugs.llvm.org/show_bug.cgi?id=38208

I suspect that this might be because we aren't enforcing complexity thresholds over all the symbols we're constructing, but that's not certain, we need to get to the bottom of it some day.

I suggest reverting the patch or putting it behind an off-by-default flag until we debug these cases.

Wed, Jul 18, 11:57 PM
davidxl added inline comments to D49529: [profile] Add interface to get profile filename.
Wed, Jul 18, 11:55 PM
gaijiading added a comment to D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux.

LGTM.

-eric

Hi Eric, I do not have commit access to trunk. Could you commit the change for me? Thanks.

The binaries make that hard, can you email me a tarball please?

Wed, Jul 18, 11:42 PM · Restricted Project
Hahnfeld accepted D44186: [OpenMP] New clang/libomptarget map interface: remove translation code.

Let's coordinate in order to commit both patches at the same time. The patch is currently blocked by Jonas.

@Hahnfeld: Is there any other issue that needs to be addressed? If not, is this good to go?

Wed, Jul 18, 11:34 PM · Restricted Project
lebedev.ri added a comment to D49508: [CodeGen] VisitMaterializeTemporaryExpr(): don't skip NoOp Casts..

skipRValueSubobjectAdjustments has to match the rules in [class.temporary] in the standard, which includes skipping over certain explicit casts.

I'm this approach because this is what @rsmith suggested. As i said, i don't really know this code,
so maybe i'm missing something obvious that makes this still possible.

Wed, Jul 18, 11:32 PM
lebedev.ri accepted D47681: [DAGCombiner] Bug 31275- Extract a shift from a constant mul or udiv if a rotate can be formed.

It seems everyone else is busy with other differentials, and don't have time to spare to review this :/

Have you run this on a llvm test suite?

I don't have further comments, and i could accept this, if testsuite passes,
but it would be more comfortable if someone else could review this, too.

Sorry about the late response, missed this comment before. I just ran the test-suite and it looks like all 2555 passed without issue.

Wed, Jul 18, 11:15 PM
sbaranga added a comment to D49461: [LV] Fix for PR38110, LV encountered llvm_unreachable() .

Seems reasonable to me.

Ideally we should be handling the phi node case (which is why the unreachable was there), but crashing doesn't seem like the right thing to do.

Personally, I see a value in differentiating explicitly known handling versus just being conservative ----- but I don't mind converting that into a comment instead if that's preferred.

Wed, Jul 18, 11:04 PM
sbaranga added inline comments to D49463: [ARM] Add new feature to enable optimizing the VFD registers.
Wed, Jul 18, 10:59 PM
Chirag added a comment to D49532: [DebugInfoMetadata] Added endianity field in DIBasicType to hold DW_AT_endianity attribute for DW_TAG_basic_type..

Hello All,

Wed, Jul 18, 10:52 PM
Hui added inline comments to D49410: [PDB] Parse UDT symbols and pointers to members.
Wed, Jul 18, 10:49 PM
takuto.ikuta closed D48882: [PDB] Add PDBSourcePath flag to support absolutize source file path.

Landed as
https://reviews.llvm.org/rLLD337439

Wed, Jul 18, 10:46 PM
Hui added inline comments to D49410: [PDB] Parse UDT symbols and pointers to members.
Wed, Jul 18, 10:33 PM
Chirag created D49532: [DebugInfoMetadata] Added endianity field in DIBasicType to hold DW_AT_endianity attribute for DW_TAG_basic_type..
Wed, Jul 18, 10:28 PM
wuzish created D49531: [PowerPC] Enhance the selection(ISD::VSELECT) of vector type.
Wed, Jul 18, 10:25 PM
dberris committed rL337441: [XRay][compiler-rt] FDR Mode: Add extents metadata to buffer.
[XRay][compiler-rt] FDR Mode: Add extents metadata to buffer
Wed, Jul 18, 10:22 PM
dberris committed rCRT337441: [XRay][compiler-rt] FDR Mode: Add extents metadata to buffer.
[XRay][compiler-rt] FDR Mode: Add extents metadata to buffer
Wed, Jul 18, 10:22 PM
devnexen committed rCRT337440: [Xray] Fix allocator build, MAP_NORESERVE flag is not always supported.
[Xray] Fix allocator build, MAP_NORESERVE flag is not always supported
Wed, Jul 18, 10:14 PM
devnexen committed rL337440: [Xray] Fix allocator build, MAP_NORESERVE flag is not always supported.
[Xray] Fix allocator build, MAP_NORESERVE flag is not always supported
Wed, Jul 18, 10:14 PM
Hui added inline comments to D49410: [PDB] Parse UDT symbols and pointers to members.
Wed, Jul 18, 10:07 PM
Meinersbur accepted D49349: [UnJ] Document loop metadata.

LGTM

Wed, Jul 18, 10:04 PM
Quuxplusone updated the diff for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".

Remove some incorrect noexcept from <experimental/memory_resource>.

Wed, Jul 18, 10:03 PM
Hui added inline comments to D49410: [PDB] Parse UDT symbols and pointers to members.
Wed, Jul 18, 10:02 PM
tikuta committed rLLD337439: [PDB] Add PDBSourcePath flag to support absolutize source file path.
[PDB] Add PDBSourcePath flag to support absolutize source file path
Wed, Jul 18, 10:01 PM
tikuta committed rL337439: [PDB] Add PDBSourcePath flag to support absolutize source file path.
[PDB] Add PDBSourcePath flag to support absolutize source file path
Wed, Jul 18, 10:01 PM
Hui added inline comments to D49410: [PDB] Parse UDT symbols and pointers to members.
Wed, Jul 18, 9:57 PM
Hui added inline comments to D49410: [PDB] Parse UDT symbols and pointers to members.
Wed, Jul 18, 9:53 PM
mstorsjo updated the diff for D49351: [LLD] [COFF] Sort .relocs before all other discardable sections.

Applied @pcc's suggestion

Wed, Jul 18, 9:34 PM
mstorsjo committed rLLD337438: [COFF] Don't produce base relocs for discardable sections.
[COFF] Don't produce base relocs for discardable sections
Wed, Jul 18, 9:30 PM
mstorsjo committed rL337438: [COFF] Don't produce base relocs for discardable sections.
[COFF] Don't produce base relocs for discardable sections
Wed, Jul 18, 9:30 PM
mstorsjo closed D49350: [LLD] [COFF] Don't produce base relocs for discardable sections.
Wed, Jul 18, 9:30 PM
EricWF created D49530: [libc++] Implement Directory Entry Caching -- Sort of..
Wed, Jul 18, 9:14 PM
rjmccall added a comment to D49508: [CodeGen] VisitMaterializeTemporaryExpr(): don't skip NoOp Casts..

I think it would be reasonable to set a flag on ImplicitCastExprs that are actually semantically part of an explicit cast. I don't think that would be hard to get Sema to do, either by passing a flag down to the code that builds those casts or just by retroactively setting that flag on all the ICE sub-expressions of an explicit cast when "capping" it with the ExplicitCastExpr.

Wed, Jul 18, 9:11 PM
rjmccall added inline comments to D48661: [Fixed Point Arithmetic] Fixed Point Constant.
Wed, Jul 18, 9:06 PM · Restricted Project
rjmccall added a comment to D49083: [HIP] Register/unregister device fat binary only once.

Thanks for the comment.

Wed, Jul 18, 9:04 PM
kcc committed rCRT337437: [libFuzzer] fix the bot (the no-assert build).
[libFuzzer] fix the bot (the no-assert build)
Wed, Jul 18, 8:21 PM
kcc committed rL337437: [libFuzzer] fix the bot (the no-assert build).
[libFuzzer] fix the bot (the no-assert build)
Wed, Jul 18, 8:21 PM
tejohnson created D49529: [profile] Add interface to get profile filename.
Wed, Jul 18, 8:09 PM
malaperle added a comment to D49523: [clangd] Add support for per-file override compilation command.

Interesting! We also have a need for passing compilation commands in a context where there is no compile_commands.json, but we were thinking of putting this in a "didChangeConfiguration" message so that all the commands would be available even before files are opened. This would be allow Clangd to have the necessary information for background indexing which would include unopened files. Subsequent changes to compilation commands would probably go through a similar didChangeConfiguration and the appropriate (opened) files would get reparsed (not unlike D49267). I'm making a few guesses here: I assume that in the context of XCode, you would not do background indexing in Clangd but let XCode do it as it can also coordinate (and not overlap) with build tasks. Is that correct? In any case, I think the approach in the patch is not incompatible with what we had in mind, i.e. we could also reuse "overrideCompilationCommandForFile" for each file specified in didChangeConfiguration. I'm point this out because if you *do* end up needing all the compilation commands beforehand like I mentioned, then maybe we can skip the approach of specifying them with didOpen and send them all with didChangeConfiguration from start.

Wed, Jul 18, 7:59 PM · Restricted Project
mgrang updated the diff for D49464: [COFF, ARM64] Mark only POD-type returns as SRET.

Moved the check for NonPODStructRet to CGFunctionInfo.

Wed, Jul 18, 7:32 PM
malaperle updated subscribers of D49523: [clangd] Add support for per-file override compilation command.
Wed, Jul 18, 7:26 PM · Restricted Project
dberris accepted D49405: Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte).

LGTM -- +1 to @pcc's suggestion on wording of the comment.

Wed, Jul 18, 7:24 PM
0x8000-0000 added inline comments to D49114: [clang-tidy] Add a check for "magic numbers".
Wed, Jul 18, 7:18 PM
0x8000-0000 added a comment to D45444: [clang-tidy] implement new check for const-correctness.

Any plans for fix-its that will add the suggested 'const' qualifiers?

Wed, Jul 18, 7:16 PM
0x8000-0000 updated the diff for D49114: [clang-tidy] Add a check for "magic numbers".

Significant refactoring to address review comments - mainly to reduce duplication and implement in functional style.

Wed, Jul 18, 7:15 PM
jakehehrlich added a comment to D49515: [llvm-objcopy, tests] Fix several llvm-objcopy tests.

What would the consequence be of just converting the bytes to a string and writing that out? I have neither a windows box nor python 3 installed.

Wed, Jul 18, 7:04 PM
kcc committed rCRT337436: [libFuzzer] quick hack to fix the bot.
[libFuzzer] quick hack to fix the bot
Wed, Jul 18, 6:59 PM
kcc committed rL337436: [libFuzzer] quick hack to fix the bot.
[libFuzzer] quick hack to fix the bot
Wed, Jul 18, 6:59 PM
vsapsai added a comment to D49518: [VFS] Emit an error when a file isn't located in any directory..

Need to double check what tests we have when using relative path names at the root level. I'd like to make the behavior consistent because a file name is a specific case of relative paths. So far there are no assertions and no errors but file lookup doesn't seem to be working.

Wed, Jul 18, 6:59 PM
mkazantsev committed rL337435: [SCEV] Fix buggy behavior in getAddExpr with truncs.
[SCEV] Fix buggy behavior in getAddExpr with truncs
Wed, Jul 18, 6:51 PM
mkazantsev closed D49471: [SCEV] Fix buggy behavior in getAddExpr with truncs.
Wed, Jul 18, 6:51 PM
pcc added inline comments to D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos.
Wed, Jul 18, 6:51 PM
phosek added inline comments to D49502: [CMake] Support statically linking dependencies only to shared or static library.
Wed, Jul 18, 6:49 PM
NoQ added inline comments to D49528: [analyzer] Syntactic matcher for leaks associated with run loop and autoreleasepool.
Wed, Jul 18, 6:48 PM
phosek updated the diff for D49502: [CMake] Support statically linking dependencies only to shared or static library.
Wed, Jul 18, 6:46 PM
davide added inline comments to D49408: [SCCP] Don't use markForcedConstant on branch conditions..
Wed, Jul 18, 6:43 PM
efriedma added inline comments to D49408: [SCCP] Don't use markForcedConstant on branch conditions..
Wed, Jul 18, 6:37 PM
NoQ added inline comments to D49528: [analyzer] Syntactic matcher for leaks associated with run loop and autoreleasepool.
Wed, Jul 18, 6:35 PM
davide accepted D49408: [SCCP] Don't use markForcedConstant on branch conditions..

LGTM modulo minor. Thanks.

Wed, Jul 18, 6:29 PM
kcc committed rCRT337434: [libFuzzer] first experimental attempt at DFT-based mutations (DFT=data-flow….
[libFuzzer] first experimental attempt at DFT-based mutations (DFT=data-flow…
Wed, Jul 18, 6:28 PM
kcc committed rL337434: [libFuzzer] first experimental attempt at DFT-based mutations (DFT=data-flow….
[libFuzzer] first experimental attempt at DFT-based mutations (DFT=data-flow…
Wed, Jul 18, 6:28 PM
sameconrad added a comment to D47681: [DAGCombiner] Bug 31275- Extract a shift from a constant mul or udiv if a rotate can be formed.

It seems everyone else is busy with other differentials, and don't have time to spare to review this :/

Have you run this on a llvm test suite?

I don't have further comments, and i could accept this, if testsuite passes,
but it would be more comfortable if someone else could review this, too.

Wed, Jul 18, 6:16 PM
efriedma updated the diff for D49408: [SCCP] Don't use markForcedConstant on branch conditions..

Cleaned up, added some tests.

Wed, Jul 18, 6:14 PM
george.karpenkov created D49528: [analyzer] Syntactic matcher for leaks associated with run loop and autoreleasepool.
Wed, Jul 18, 5:55 PM
pcc added inline comments to D49526: Updated llvm-proto-fuzzer to execute the compiled code.
Wed, Jul 18, 5:52 PM
smeenai added a comment to D49509: [libc++] Allow running ABI list tests with different ABI versions.

This went out to llvm-commits. You may wanna re-upload with cfe-commits added instead.

Wed, Jul 18, 5:52 PM
thomasanderson updated the diff for D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos.
Wed, Jul 18, 5:50 PM
manojgupta committed rL337433: [clang]: Add support for "-fno-delete-null-pointer-checks".
[clang]: Add support for "-fno-delete-null-pointer-checks"
Wed, Jul 18, 5:50 PM
manojgupta committed rC337433: [clang]: Add support for "-fno-delete-null-pointer-checks".
[clang]: Add support for "-fno-delete-null-pointer-checks"
Wed, Jul 18, 5:50 PM
manojgupta closed D47894: [clang]: Add support for "-fno-delete-null-pointer-checks".
Wed, Jul 18, 5:49 PM
emmettneyman added a comment to D49526: Updated llvm-proto-fuzzer to execute the compiled code.

The files

Wed, Jul 18, 5:48 PM
mattd created D49527: [llvm-mca][docs][WIP] Describe the Timeline View. NFC.
Wed, Jul 18, 5:45 PM
emmettneyman created D49526: Updated llvm-proto-fuzzer to execute the compiled code.
Wed, Jul 18, 5:43 PM
kevinwkt created D49525: [libFuzzer] Handle unstable edges by using minimum hit counts.
Wed, Jul 18, 5:39 PM
ormris committed rL337432: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc.
Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc
Wed, Jul 18, 5:30 PM
ormris committed rCRT337432: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc.
Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc
Wed, Jul 18, 5:30 PM
ormris closed D49501: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc.
Wed, Jul 18, 5:30 PM