Feed All Stories

Today

bjope added a watcher for debug-info: bjope.
Sun, May 27, 2:42 AM
echristo committed rL333354: Tidy some language in the xray documentation..
Tidy some language in the xray documentation.
Sun, May 27, 2:23 AM
teemperor committed rL333353: Fix memory leak in SubsPrimitiveParmItanium.
Fix memory leak in SubsPrimitiveParmItanium
Sun, May 27, 12:35 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, May 27, 12:35 AM
teemperor created D47418: Fix memory leak in SubsPrimitiveParmItanium.
Sun, May 27, 12:33 AM
MaskRay committed rC333352: [DebugInfo] Fix typo. NFC.
[DebugInfo] Fix typo. NFC
Sun, May 27, 12:28 AM
MaskRay committed rL333352: [DebugInfo] Fix typo. NFC.
[DebugInfo] Fix typo. NFC
Sun, May 27, 12:28 AM

Yesterday

Quuxplusone updated the summary of D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..
Sat, May 26, 9:48 PM
Quuxplusone added a dependent revision for D46806: Remove unused code from __functional_base. NFC.: D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..
Sat, May 26, 9:48 PM
Quuxplusone added a dependent revision for D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()": D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..
Sat, May 26, 9:48 PM
Quuxplusone added a dependent revision for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()": D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..
Sat, May 26, 9:48 PM
Quuxplusone added a reviewer for D47360: Implement <memory_resource> as a copy of <experimental/memory_resource>.: mclow.lists.
Sat, May 26, 9:48 PM
Quuxplusone added a dependent revision for D46806: Remove unused code from __functional_base. NFC.: D47358: <experimental/memory_resource>: Implement {un,}synchronized_pool_resource..
Sat, May 26, 9:47 PM
Quuxplusone added a dependent revision for D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()": D47358: <experimental/memory_resource>: Implement {un,}synchronized_pool_resource..
Sat, May 26, 9:47 PM
Quuxplusone updated the summary of D47358: <experimental/memory_resource>: Implement {un,}synchronized_pool_resource..
Sat, May 26, 9:47 PM
Quuxplusone added a dependent revision for D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource.: D47358: <experimental/memory_resource>: Implement {un,}synchronized_pool_resource..
Sat, May 26, 9:47 PM
Quuxplusone added a dependent revision for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()": D47358: <experimental/memory_resource>: Implement {un,}synchronized_pool_resource..
Sat, May 26, 9:47 PM
Quuxplusone added a reviewer for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()": mclow.lists.
Sat, May 26, 9:47 PM
Quuxplusone added a reviewer for D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource.: mclow.lists.
Sat, May 26, 9:46 PM
Quuxplusone added a reviewer for D46806: Remove unused code from __functional_base. NFC.: mclow.lists.
Sat, May 26, 9:46 PM
craig.topper added inline comments to D47401: [X86] Rewrite the max and min reduction intrinsics to make better use of other functions and to reduce width to 256 and 128 bits were possible..
Sat, May 26, 6:03 PM
ki.stfu added a comment to D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h.

šŸ‘

Sat, May 26, 5:15 PM
chandlerc updated the diff for D46706: [PM/LoopUnswitch] Support partial trivial unswitching..

Update to rebase on the patch that adds loop-instsimplify and loop-simplifycfg
to the loop pass pipeline as cleanup passes to minimize the cleanup necessary
in the unswitch pass itself.

Sat, May 26, 4:55 PM
chandlerc added a dependent revision for D47408: [PM/LoopUnswitch] When using the new SimpleLoopUnswitch pass, schedule loop-cleanup passes at the beginning of the loop pass pipeline, and re-enqueue loops after even trivial unswitching.: D46706: [PM/LoopUnswitch] Support partial trivial unswitching..
Sat, May 26, 4:55 PM
tejohnson updated the diff for D46700: [ThinLTO] Add testing of new summary index format to a couple CFI tests.

Update tests so they won't get bot failures (don't try to match path, module
hash).

Sat, May 26, 4:11 PM
chandlerc updated the diff for D47408: [PM/LoopUnswitch] When using the new SimpleLoopUnswitch pass, schedule loop-cleanup passes at the beginning of the loop pass pipeline, and re-enqueue loops after even trivial unswitching..

Rebase and teach the old PM to do this as well when using SimpleLoopUnswitch.

Sat, May 26, 3:38 PM
chandlerc added a dependent revision for D47407: [LoopInstSimplify] Re-implement the core logic of loop-instsimplify to be both simpler and substantially more efficient.: D47408: [PM/LoopUnswitch] When using the new SimpleLoopUnswitch pass, schedule loop-cleanup passes at the beginning of the loop pass pipeline, and re-enqueue loops after even trivial unswitching..
Sat, May 26, 3:38 PM
paulsemel added a comment to D47414: [llvm-objcopy] Fix null symbol handling.

thanks for addressing this (i noticed this isssue too, but didn't have a minute to send a fix).
Regarding the code: to be honest i would prefer to avoid these somewhat "hacky" manipulations with the index (i.e. in getSymbolByIndex etc),
instead, i would keep this special symbol in the symbol table and in llvm-objcopy.cpp I would replace the check !Obj.SymbolTable->empty() with
Obj.SymbolTable->size() >= 2 or smth like this (+ add a comment that we need to take into account that special symbol).
What are your thoughts ?

Sat, May 26, 2:37 PM
xbolva00 added inline comments to D45517: [analyzer] WIP: False positive refutation with Z3.
Sat, May 26, 2:30 PM
alexshap added a comment to D47414: [llvm-objcopy] Fix null symbol handling.

thanks for addressing this (i noticed this isssue too, but didn't have a minute to send a fix).
Regarding the code: to be honest i would prefer to avoid these somewhat "hacky" manipulations with the index (i.e. in getSymbolByIndex etc),
instead, i would keep this special symbol in the symbol table and in llvm-objcopy.cpp I would replace the check !Obj.SymbolTable->empty() with
Obj.SymbolTable->size() >= 2 or smth like this (+ add a comment that we need to take into account that special symbol).
What are your thoughts ?

Sat, May 26, 2:27 PM
ddcc added a comment to D45517: [analyzer] WIP: False positive refutation with Z3.

FYI the fix for the 1-bit APSInt issue is in https://reviews.llvm.org/D35450#change-ifYnQ3IlVso

Sat, May 26, 2:10 PM
RKSimon added inline comments to D47401: [X86] Rewrite the max and min reduction intrinsics to make better use of other functions and to reduce width to 256 and 128 bits were possible..
Sat, May 26, 2:06 PM
xbolva00 added inline comments to D47135: [analyzer] A checker for dangling internal buffer pointers in C++.
Sat, May 26, 2:06 PM
nhaehnle accepted D47027: [AMDGPU] Fixed WWM bug in block otherwise entirely in WQM.

Oops :)
LGTM.

Sat, May 26, 1:35 PM
Ka-Ka added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Ping.

We have added a lit reproducer for this now in clang-tools-extra: https://reviews.llvm.org/D47251.

The above should be rolled into this patch as the test case verifying the behavioral changes.

I guess the intention from @dstenb was to submit both patches together. The reason for a separate patch with the testcase alone is that the reproducer use clang-tidy and as far as I know all clang-tidy tests exist in clang-tools-extra.

.. and both of them exist in the same svn repo, or git monorepo. (granted, not many use that)

Sat, May 26, 1:08 PM
lebedev.ri added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Ping.

We have added a lit reproducer for this now in clang-tools-extra: https://reviews.llvm.org/D47251.

The above should be rolled into this patch as the test case verifying the behavioral changes.

I guess the intention from @dstenb was to submit both patches together. The reason for a separate patch with the testcase alone is that the reproducer use clang-tidy and as far as I know all clang-tidy tests exist in clang-tools-extra.

Sat, May 26, 1:00 PM
Ka-Ka added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Ping.

We have added a lit reproducer for this now in clang-tools-extra: https://reviews.llvm.org/D47251.

The above should be rolled into this patch as the test case verifying the behavioral changes.

Sat, May 26, 12:56 PM
jfb committed rCXX333351: Revert "Add nonnull; use it for atomics".
Revert "Add nonnull; use it for atomics"
Sat, May 26, 12:50 PM
jfb committed rL333351: Revert "Add nonnull; use it for atomics".
Revert "Add nonnull; use it for atomics"
Sat, May 26, 12:50 PM
JDevlieghere committed rL333350: [dwarfdump] Make -c and -p work together.
[dwarfdump] Make -c and -p work together
Sat, May 26, 12:44 PM
JDevlieghere closed D47263: [dwarfdump] Have -c and -p work together.
Sat, May 26, 12:44 PM
aaron.ballman added a comment to D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.
In D47290#1113412, @jfb wrote:

This is relaxing -Wformat and making users instead write -Wformat-pedantic to get the strong guarantees, which is the opposite of what I thought the consensus was. Have I misunderstood something?

From Shoaib's email:

Based on all the discussion so far, I think the consensus is that we don't want to relax -Wformat by default, but an additional relaxed option would be fine. That works for me (where I can just switch my codebases to use the new warning option), but it wouldn't handle JF Bastien's use case, so he would still want to pursue the relaxations specific to Apple platforms.

This patch is specific to the Darwin platform, as proposed in Alex' original patch and as I promised to do in the cfe-dev thread. Shoaib's follow-up would be different and do what I think you're referring to.

Sat, May 26, 12:36 PM
jfb added a comment to D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.

Addressed comments.

Sat, May 26, 12:36 PM
jfb updated the diff for D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.
  • Fix variable capitalization.
Sat, May 26, 12:36 PM
andrew.zhogin updated the diff for D47369: [DebugInfo][ScheduleDAGInstrs] Prevent scheduler from reordering DBG_VALUE instructions through their clobbering MIs.

Small fixes according to the review comments.

Sat, May 26, 12:34 PM Ā· debug-info
aaron.ballman added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Ping.

We have added a lit reproducer for this now in clang-tools-extra: https://reviews.llvm.org/D47251.

Sat, May 26, 12:22 PM
jfb added a comment to D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.

This is relaxing -Wformat and making users instead write -Wformat-pedantic to get the strong guarantees, which is the opposite of what I thought the consensus was. Have I misunderstood something?

Sat, May 26, 12:20 PM
xazax.hun accepted D47417: [analyzer] Add missing state transition in IteratorChecker.
Sat, May 26, 12:17 PM
rnkovacs created D47417: [analyzer] Add missing state transition in IteratorChecker.
Sat, May 26, 12:15 PM
craig.topper reopened D47401: [X86] Rewrite the max and min reduction intrinsics to make better use of other functions and to reduce width to 256 and 128 bits were possible..
Sat, May 26, 12:04 PM
rnkovacs added inline comments to D47135: [analyzer] A checker for dangling internal buffer pointers in C++.
Sat, May 26, 12:03 PM
ctopper committed rC333349: Revert r333347 "[X86] Rewrite the max and min reduction intrinsics to makeā€¦.
Revert r333347 "[X86] Rewrite the max and min reduction intrinsics to makeā€¦
Sat, May 26, 12:01 PM
ctopper committed rL333349: Revert r333347 "[X86] Rewrite the max and min reduction intrinsics to makeā€¦.
Revert r333347 "[X86] Rewrite the max and min reduction intrinsics to makeā€¦
Sat, May 26, 12:01 PM
xazax.hun accepted D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker.

LG!

Sat, May 26, 12:01 PM
ctopper committed rC333348: [X86] Remove mask from avx512ifma builtins. Use a select instruction instead..
[X86] Remove mask from avx512ifma builtins. Use a select instruction instead.
Sat, May 26, 12:00 PM
ctopper committed rC333347: [X86] Rewrite the max and min reduction intrinsics to make better use of otherā€¦.
[X86] Rewrite the max and min reduction intrinsics to make better use of otherā€¦
Sat, May 26, 12:00 PM
ctopper committed rL333348: [X86] Remove mask from avx512ifma builtins. Use a select instruction instead..
[X86] Remove mask from avx512ifma builtins. Use a select instruction instead.
Sat, May 26, 11:59 AM
ctopper committed rL333347: [X86] Rewrite the max and min reduction intrinsics to make better use of otherā€¦.
[X86] Rewrite the max and min reduction intrinsics to make better use of otherā€¦
Sat, May 26, 11:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, May 26, 11:59 AM
ctopper committed rL333346: [X86] Remove masking from avx512ifma intrinsics. Use a select instead..
[X86] Remove masking from avx512ifma intrinsics. Use a select instead.
Sat, May 26, 11:59 AM
xazax.hun accepted D47135: [analyzer] A checker for dangling internal buffer pointers in C++.

LGTM!

Sat, May 26, 11:55 AM
aaron.ballman added a comment to D47157: Warning for framework headers using double quote includes.

See also PR22165.

Nice, seems related to this indeed. Are you aware of any development along those lines in clang-tidy? We would like this to be part of clang and be used as part of the normal compiler workflow, it can surely be as well part of any clang-tidy related include guidelines in the future.

The warning is off by default.

We typically do not add off-by-default warnings because experience has shown the rarely get enabled in practice. Can you explain a bit more about why this one is off by default?

Right. I believe this is going to be used in practice, the reason I'm adding it involves some user demand for such warning. Such quoted include use in frameworks happen often and we would like a smooth transition to happen here (e.g. do not initially affect -Werror users). If it proves worth it, we can migrate to on by default in the future. It wouldn't be a problem if we have it on by default on open source and disable by default downstream, but I rather be consistent.

Sat, May 26, 11:54 AM
rnkovacs added a dependency for D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker: D47135: [analyzer] A checker for dangling internal buffer pointers in C++.
Sat, May 26, 11:54 AM
rnkovacs added a dependent revision for D47135: [analyzer] A checker for dangling internal buffer pointers in C++: D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker.
Sat, May 26, 11:54 AM
rnkovacs created D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker.
Sat, May 26, 11:54 AM
rnkovacs updated the diff for D47135: [analyzer] A checker for dangling internal buffer pointers in C++.

Address (most) comments.

Sat, May 26, 11:50 AM
aaron.ballman added a comment to D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.

This is relaxing -Wformat and making users instead write -Wformat-pedantic to get the strong guarantees, which is the opposite of what I thought the consensus was. Have I misunderstood something?

Sat, May 26, 11:47 AM
MaskRay added inline comments to D47098: [ELF] Make R_GOTONLY_PC_FROM_END R_GOTREL_FROM_END relative to _GLOBAL_OFFSET_TABLE_ instead of end of .got.
Sat, May 26, 11:39 AM
xazax.hun added inline comments to D47135: [analyzer] A checker for dangling internal buffer pointers in C++.
Sat, May 26, 11:32 AM
xazax.hun added inline comments to D47135: [analyzer] A checker for dangling internal buffer pointers in C++.
Sat, May 26, 11:30 AM
aaron.ballman added a comment to D46805: If some platforms do not support an attribute, we should exclude the platform.

@rsmith -- do the object file formats listed look correct to you?

Sat, May 26, 11:28 AM
xazax.hun added a comment to D47135: [analyzer] A checker for dangling internal buffer pointers in C++.

Looks good so far, some comments inline.

Sat, May 26, 11:26 AM
polyakov.alex updated the summary of D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command..
Sat, May 26, 11:23 AM
polyakov.alex created D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command..
Sat, May 26, 11:23 AM
rnkovacs updated the diff for D47135: [analyzer] A checker for dangling internal buffer pointers in C++.
  • All basic_string types are now supported.
  • Mock tests added.
  • New AllocationFamily AF_InternalBuffer introduced.
  • NewDeleteChecker dependency added.
Sat, May 26, 11:13 AM
MaskRay added inline comments to D47098: [ELF] Make R_GOTONLY_PC_FROM_END R_GOTREL_FROM_END relative to _GLOBAL_OFFSET_TABLE_ instead of end of .got.
Sat, May 26, 10:45 AM
MaskRay updated the diff for D47098: [ELF] Make R_GOTONLY_PC_FROM_END R_GOTREL_FROM_END relative to _GLOBAL_OFFSET_TABLE_ instead of end of .got.

Keep lines in old tests

Sat, May 26, 10:41 AM
aprantl added a comment to D47384: Remove dependency from Host to clang.

Generally I'm fine with improving the layering. I just wanted to point out that the Swift language plugin also wants know the clang resource directory (it calls HostInfo::GetLLDBPath(ePathTypeClangDir, clang_dir_spec)) since Swift embeds Clang. That said it makes no sense to build an LLDB that supports Swift and not also support lang, so moving things into the Clang plugin should be fine.

Sat, May 26, 10:26 AM
paulsemel created D47414: [llvm-objcopy] Fix null symbol handling.
Sat, May 26, 10:13 AM
deadalnix created D47413: [ARM] Remove code handling ADDC/ADDE/SUBC/SUBE.
Sat, May 26, 9:15 AM
teemperor committed rL333345: Add missing includes to some LLDB headers..
Add missing includes to some LLDB headers.
Sat, May 26, 8:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, May 26, 8:03 AM
teemperor created D47412: Add missing includes to some LLDB headers..
Sat, May 26, 8:02 AM
teemperor created D47411: Mute some compiler warnings in the generated python wrapper code..
Sat, May 26, 7:58 AM
labath added a reviewer for D47384: Remove dependency from Host to clang: aprantl.

I remember looking at the path computation code a while ago (I think it was in the context of python though) and concluding that something like this would be needed. Overall the patch seems fine to me, but I want to make sure it gets enough visibility, so I've added Adrian as he was working on this code recently.

Sat, May 26, 7:53 AM
deadalnix committed rL333344: Fix comment decribing setcccarry. NFC.
Fix comment decribing setcccarry. NFC
Sat, May 26, 7:45 AM
teemperor committed rL333343: Don't include headers from inside a namespace in MIUtilSingletonHelper.h.
Don't include headers from inside a namespace in MIUtilSingletonHelper.h
Sat, May 26, 7:45 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, May 26, 7:45 AM
teemperor created D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h.
Sat, May 26, 7:41 AM
teemperor committed rL333342: Forward declare DumpValueObjectOptions in ValueObject.h.
Forward declare DumpValueObjectOptions in ValueObject.h
Sat, May 26, 7:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, May 26, 7:38 AM
teemperor created D47409: Forward declare DumpValueObjectOptions in ValueObject.h.
Sat, May 26, 7:36 AM
CarlosAlbertoEnciso added a comment to D44826: Add -Wunused-using, a warning that finds unused using declarations..

Thanks very much for your review. I will address those issues and update the patch.

Sat, May 26, 6:43 AM Ā· Restricted Project
labath accepted D47278: Remove lldb-private headers when building LLDB.framework with CMake.
Sat, May 26, 6:37 AM
deadalnix updated the diff for D46505: [DAGcombine] Teach the combiner about -a = ~a + 1.

Use isBitwiseNot
Merge flipBooleanConstant into flipBoolean
Add more specific test cases.

Sat, May 26, 5:38 AM
deadalnix committed rL333341: Add test case for D46505 . NFC.
Add test case for D46505 . NFC
Sat, May 26, 5:32 AM
lebedev.ri added a comment to D47113: [CVP] Teach CorrelatedValuePropagation to reduce the width of lshr instruction..

%shr.zext = zext i16 %shr to i32
%arrayidx = getelementptr inbounds i16, i16* %AllocationMap, i32 %shr.zext

Hmm, i think here we could avoid zext.

Actually, uhm, https://godbolt.org/g/jtNCSp, is the idx always canonicalized to i64?

Sat, May 26, 5:16 AM
xbolva00 updated the summary of D47397: [SimplifyLibcalls] [NFC] Cleanup, improvements.
Sat, May 26, 5:06 AM
deadalnix added inline comments to D46505: [DAGcombine] Teach the combiner about -a = ~a + 1.
Sat, May 26, 4:57 AM
lebedev.ri added a comment to D46760: [InstCombine] Enhance narrowUDivURem..

You want to narrow multi-use sequences of code because instcombine can't do that profitably using minimal peepholes:

Name: narrow expression
Pre: C1 u< 9945
  %tmp2 = zext i32 C1 to i64
  %lane_id = and i64 %tmp2, 31
  %shr = lshr i64 %tmp2, 2
  %tmp4 = shl nuw nsw i64 %shr, 5
  %r = or i64 %lane_id, %tmp4
=>
  %nlane_id = and i32 C1, 31
  %nshr = lshr i32 C1, 2
  %ntmp4 = shl i32 %nshr, 5
  %ntmp5 = or i32 %nlane_id, %ntmp4
  %r = zext i32 %ntmp5 to i64

The original motivation for -aggressive-instcombine (TruncInstCombine) was something almost like that - see D38313. Can you extend that? Note that the general problem isn't about udiv/urem, lshr, or any particular binop. It's about narrowing a sequence of arbitrary binops (and maybe even more than binops).

Hmm, there already is llvm/lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp.
I'm guessing what you meant is, can that be extended to handle this case, too?
It currently does not https://godbolt.org/g/CMd7sK

Sat, May 26, 4:50 AM