Page MenuHomePhabricator
Feed All Stories

Today

craig.topper committed rGb3bad3dce396: [X86] Use LoadInst->getType() instead of LoadInst->getPointerOperandType()… (authored by craig.topper).
[X86] Use LoadInst->getType() instead of LoadInst->getPointerOperandType()…
Thu, Mar 21, 2:37 PM
lebedev.ri added inline comments to D59650: [NFC] ExceptionEscapeCheck: small refactoring .
Thu, Mar 21, 2:36 PM · Restricted Project, Restricted Project
ctopper committed rL356721: [X86] Use LoadInst->getType() instead of LoadInst->getPointerOperandType()….
[X86] Use LoadInst->getType() instead of LoadInst->getPointerOperandType()…
Thu, Mar 21, 2:36 PM
lebedev.ri updated the diff for D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Keep templated function out of the public interface.

Thu, Mar 21, 2:35 PM · Restricted Project, Restricted Project
lebedev.ri updated the diff for D59466: [clang-tidy] openmp-exception-escape - a new check.

Rebased for D59650 changes, NFC.

Thu, Mar 21, 2:35 PM · Restricted Project, Restricted Project, Restricted Project
erik.pilkington created D59670: [Sema] Fix an assert when a block captures a constexpr local.
Thu, Mar 21, 2:32 PM · Restricted Project
spatel created D59669: [x86] use movmsk when extracting multiple lanes of a vector compare (PR39665).
Thu, Mar 21, 2:32 PM · Restricted Project
tamur added a comment to D59515: Prevent duplicate files in debug line header in dwarf 5..

I moved nfc changes to a separate patch.

Thu, Mar 21, 2:28 PM · debug-info, Restricted Project
ruiu added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Looks like the test files are huge. I order to test this functionality alone, you don't need a small file containing one relocation pointing to a to-be-discarded section. You don't really have to test it against actual data.

Thu, Mar 21, 2:28 PM · lld, Restricted Project
tamur updated the diff for D59515: Prevent duplicate files in debug line header in dwarf 5..
Thu, Mar 21, 2:26 PM · debug-info, Restricted Project
ruiu added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Looks like the test files are huge. I order to test this functionality alone, you don't need a small file containing one relocation pointing to a to-be-discarded section. You don't really have to test it against actual data.

Thu, Mar 21, 2:25 PM · lld, Restricted Project
nikic created D59668: [ValueTracking] Take signedness into account for and/or ranges.
Thu, Mar 21, 2:23 PM · Restricted Project
JonasToth added a comment to D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Looks like pointless code duplication that is easily avoidable.

Thu, Mar 21, 2:23 PM · Restricted Project, Restricted Project
echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Oh, and as far as dwarf aware linking I'd arguably prefer a separate tool ala dsymutil or dwz rather than incorporating it into the linker. I do agree that such a tool is incredibly useful and should be part of our ongoing development plan around debug info.

Thu, Mar 21, 2:20 PM · lld, Restricted Project
echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@jhenderson and I did a prototype of DWARF-unit-per-function last year, and I was not favorably impressed by the numbers. But maybe he still has the actual data kicking around somewhere. We did not solve all the issues to our satisfaction before we ran out of time.
I've also had chats with @bd1976llvm about fragmenting .debug_info per-function without wrapping everything in units; you get into requiring some section-order things but it saves the unit-per-function overhead.

Thu, Mar 21, 2:17 PM · lld, Restricted Project
davide accepted D59667: Regression test to ensure that we handling importing of anonymous enums correctly.

LGTM, just clang format main.cpp before committing.

Thu, Mar 21, 2:17 PM
nikic committed rGb86576a5b945: [InstSimplify] Add tests for signed icmp of and/or; NFC (authored by nikic).
[InstSimplify] Add tests for signed icmp of and/or; NFC
Thu, Mar 21, 2:17 PM
tcwang updated the summary of D59311: [ELF] Dump symbols ordered by profiled guided section layout to file..
Thu, Mar 21, 2:17 PM · Restricted Project
arsenm added a comment to D59666: AMDGPU: HIP compiler option -finstrument-functions flag.

Commit message should also say it's lowering returnaddress, not mention instrument-functions

Thu, Mar 21, 2:12 PM
nikic committed rL356720: [InstSimplify] Add tests for signed icmp of and/or; NFC.
[InstSimplify] Add tests for signed icmp of and/or; NFC
Thu, Mar 21, 2:11 PM
arsenm added inline comments to D59666: AMDGPU: HIP compiler option -finstrument-functions flag.
Thu, Mar 21, 2:11 PM
shafik added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

I was not able to come up with a test that would detect this issue using either clang-import-test nor via any of the methods used in ASTImpoterTest.cpp. I created a regression test on the lldb side, which should pass once this is committed:

Thu, Mar 21, 2:10 PM
aakanksha555 retitled D59666: AMDGPU: HIP compiler option -finstrument-functions flag from HIP compiler option -finstrument-functions flag to AMDGPU: HIP compiler option -finstrument-functions flag.
Thu, Mar 21, 2:10 PM
shafik created D59667: Regression test to ensure that we handling importing of anonymous enums correctly.
Thu, Mar 21, 2:09 PM
ldionne committed rGbea1817e4166: [libc++] Remove too-stringent XFAILs for file_clock tests (authored by ldionne).
[libc++] Remove too-stringent XFAILs for file_clock tests
Thu, Mar 21, 2:07 PM
ldionne committed rL356719: [libc++] Remove too-stringent XFAILs for file_clock tests.
[libc++] Remove too-stringent XFAILs for file_clock tests
Thu, Mar 21, 2:06 PM
ldionne committed rCXX356719: [libc++] Remove too-stringent XFAILs for file_clock tests.
[libc++] Remove too-stringent XFAILs for file_clock tests
Thu, Mar 21, 2:06 PM
efriedma accepted D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants.

LGTM

Thu, Mar 21, 2:05 PM · Restricted Project, Restricted Project
aakanksha555 created D59666: AMDGPU: HIP compiler option -finstrument-functions flag.
Thu, Mar 21, 2:05 PM
steven_wu committed rG5a593547602b: [Object] Fix reading objects created with -fembed-bitcode-marker (authored by steven_wu).
[Object] Fix reading objects created with -fembed-bitcode-marker
Thu, Mar 21, 2:02 PM
steven_wu committed rL356718: [Object] Fix reading objects created with -fembed-bitcode-marker.
[Object] Fix reading objects created with -fembed-bitcode-marker
Thu, Mar 21, 2:00 PM
steven_wu closed D44373: Fix reading objects created with -fembed-bitcode-marker..
Thu, Mar 21, 2:00 PM · Restricted Project
shafik created D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.
Thu, Mar 21, 1:59 PM
arsenm committed rGe811333b2dbb: Mips: Fix typo in assert message (authored by arsenm).
Mips: Fix typo in assert message
Thu, Mar 21, 1:57 PM
arsenm committed rG9a1a1f7bb2f1: Mips: Don't create copy of nothing (authored by arsenm).
Mips: Don't create copy of nothing
Thu, Mar 21, 1:57 PM
arsenm committed rL356717: Mips: Fix typo in assert message.
Mips: Fix typo in assert message
Thu, Mar 21, 1:56 PM
arsenm committed rL356716: Mips: Don't create copy of nothing.
Mips: Don't create copy of nothing
Thu, Mar 21, 1:56 PM
ruiu added inline comments to D59607: libc++/win: Make once_flag have the same size as a pointer.
Thu, Mar 21, 1:56 PM · Restricted Project
arsenm closed D59575: Mips: Don't create copy of nothing.

r356716

Thu, Mar 21, 1:56 PM
ABataev committed rGd2565d2126f3: [OPENMP]Fix a warning about unused variable, NFC. (authored by ABataev).
[OPENMP]Fix a warning about unused variable, NFC.
Thu, Mar 21, 1:51 PM
ABataev committed rL356715: [OPENMP]Fix a warning about unused variable, NFC..
[OPENMP]Fix a warning about unused variable, NFC.
Thu, Mar 21, 1:51 PM
ABataev committed rC356715: [OPENMP]Fix a warning about unused variable, NFC..
[OPENMP]Fix a warning about unused variable, NFC.
Thu, Mar 21, 1:51 PM
arsenm added inline comments to D52010: RegAllocFast: Rewrite and improve.
Thu, Mar 21, 1:50 PM · Restricted Project
tstellar committed rGbf2f5abb8e3c: git-llvm: Update for release_80 branch (authored by tstellar).
git-llvm: Update for release_80 branch
Thu, Mar 21, 1:50 PM
aemerson updated the diff for D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants.

Simplify logic and don't try to upgrade if IR is invalid.

Thu, Mar 21, 1:50 PM · Restricted Project, Restricted Project
steven_wu added a comment to D44373: Fix reading objects created with -fembed-bitcode-marker..

Thanks for fixing this. LGTM.

Looks like this never actually got committed?

Thu, Mar 21, 1:50 PM · Restricted Project
arsenm committed rGb34afa311d25: GlobalISel: Fix RegBankSelect for REG_SEQUENCE (authored by arsenm).
GlobalISel: Fix RegBankSelect for REG_SEQUENCE
Thu, Mar 21, 1:45 PM
tstellar committed rL356714: git-llvm: Update for release_80 branch.
git-llvm: Update for release_80 branch
Thu, Mar 21, 1:44 PM
arsenm closed D58758: GlobalISel: Fix RegBankSelect for REG_SEQUENCE.

r356713

Thu, Mar 21, 1:44 PM
arsenm committed rL356713: GlobalISel: Fix RegBankSelect for REG_SEQUENCE.
GlobalISel: Fix RegBankSelect for REG_SEQUENCE
Thu, Mar 21, 1:44 PM
yamauchi updated the diff for D59514: [PGO] Profile guided code size optimization..

Address comment.

Thu, Mar 21, 1:42 PM · Restricted Project
Richard Smith <richard-llvm@metafoo.co.uk> committed rG6d69fec64516: Improve the diagnostic for #include_next occurring in a file not found in the… (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Improve the diagnostic for #include_next occurring in a file not found in the…
Thu, Mar 21, 1:42 PM
rsmith committed rC356712: Improve the diagnostic for #include_next occurring in a file not found.
Improve the diagnostic for #include_next occurring in a file not found
Thu, Mar 21, 1:42 PM
rsmith committed rL356712: Improve the diagnostic for #include_next occurring in a file not found.
Improve the diagnostic for #include_next occurring in a file not found
Thu, Mar 21, 1:42 PM
lebedev.ri added a comment to D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Why not having normal overloads? The analysis for Stmt is implemented with the private methods. Explicit template specialization is a bit overkill and so easily understood (but not too complex in this case either).l

Thu, Mar 21, 1:38 PM · Restricted Project, Restricted Project
aprantl committed rG74f0e2cc3930: Makefile.rules: Normalize use of trailing slashes in path variables. (authored by aprantl).
Makefile.rules: Normalize use of trailing slashes in path variables.
Thu, Mar 21, 1:36 PM
teemperor updated the diff for D59537: Instantiate 'std' templates explicitly in the expression evaluator.
  • Added more tests (contents from debug info for containers, vectors of vectors)
  • Import -> Import_New
  • Rebased on top of the updated parent commit, which means the StdModuleHandler is now much simpler.
Thu, Mar 21, 1:36 PM · Restricted Project, Restricted Project
ABataev committed rG084b0c2f0378: [OPENMP] Simplify codegen for allocate directive on local variables. (authored by ABataev).
[OPENMP] Simplify codegen for allocate directive on local variables.
Thu, Mar 21, 1:36 PM
hfinkel added a comment to D59657: [LangRef] Clarify codegen expectations for intrinsics with fp/integer-only overloads.

The audience of this are people who are defining new target intrinsics.

Thu, Mar 21, 1:36 PM · Restricted Project
craig.topper committed rG7339e61b8914: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus (authored by craig.topper).
[X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus
Thu, Mar 21, 1:35 PM
adrian committed rL356711: Makefile.rules: Normalize use of trailing slashes in path variables..
Makefile.rules: Normalize use of trailing slashes in path variables.
Thu, Mar 21, 1:35 PM
adrian committed rLLDB356711: Makefile.rules: Normalize use of trailing slashes in path variables..
Makefile.rules: Normalize use of trailing slashes in path variables.
Thu, Mar 21, 1:35 PM
ctopper committed rC356709: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus.
[X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus
Thu, Mar 21, 1:35 PM
ABataev committed rC356710: [OPENMP] Simplify codegen for allocate directive on local variables..
[OPENMP] Simplify codegen for allocate directive on local variables.
Thu, Mar 21, 1:35 PM
ctopper committed rL356709: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus.
[X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus
Thu, Mar 21, 1:35 PM
ABataev committed rL356710: [OPENMP] Simplify codegen for allocate directive on local variables..
[OPENMP] Simplify codegen for allocate directive on local variables.
Thu, Mar 21, 1:35 PM
Diffusion closed D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus.
Thu, Mar 21, 1:35 PM · Restricted Project, Restricted Project
teemperor added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Thu, Mar 21, 1:35 PM · Restricted Project, Restricted Project
tstellar committed rGdb4cf6bdbf2a: Bump version to 8.0.1 (authored by tstellar).
Bump version to 8.0.1
Thu, Mar 21, 1:32 PM
tstellar committed rL356708: Bump version to 8.0.1.
Bump version to 8.0.1
Thu, Mar 21, 1:32 PM
tamur created D59664: [llvm] Non-functional change: declared a couple of local variables as const..
Thu, Mar 21, 1:32 PM · Restricted Project
avl added a comment to D58848: [DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

ping.

Thu, Mar 21, 1:32 PM · Restricted Project
JonasToth added a comment to D59650: [NFC] ExceptionEscapeCheck: small refactoring .

Why not having normal overloads? The analysis for Stmt is implemented with the private methods. Explicit template specialization is a bit overkill and so easily understood (but not too complex in this case either).l

Thu, Mar 21, 1:29 PM · Restricted Project, Restricted Project
mgrang added a comment to D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers.

Following are the assumptions/limitations of this patch:

1. The assumption is that iteration of ordered containers of pointers is not non-deterministic.

Could you please explain which type of non-determinism we are addressing here? If our issue is that iteration order is not consistent across runs, then an unordered set of integers seems just as non-deterministic as an unordered set of pointers. On the other hand, if our issue is that pointer values vary between runs, then an ordered set of pointers seems just as non-deterministic as an unordered set of pointers. Are unordered sets of pointers distinguished because they lie in the intersection of these categories and thus avoid the most false positive cases? If so, for someone debugging non-deterministic behavior in their code, would it be useful to add a strict option that shows other cases too? If not, maybe we could document our reasons somewhere.

Thu, Mar 21, 1:25 PM · Restricted Project
ruiu added a comment to D59594: [ELF] Change GOT*_FROM_END (relative to end(.got)) to GOTPLT* (start(.got.plt)).

I don't remember why we defined _FROM_END relocation types in the first place. That was done by Rafael. It looks to me that this change is looking generally good. I hope there's no hidden reason we did that at that time...

Thu, Mar 21, 1:24 PM · Restricted Project
ahatanak committed rGb576c77a9ead: Don't add a tail keyword to calls to ObjC runtime functions if the calls are… (authored by ahatanak).
Don't add a tail keyword to calls to ObjC runtime functions if the calls are…
Thu, Mar 21, 1:16 PM
ahatanak committed rL356707: Don't add a tail keyword to calls to ObjC runtime functions if the calls.
Don't add a tail keyword to calls to ObjC runtime functions if the calls
Thu, Mar 21, 1:15 PM
teemperor updated the diff for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

So I replaced the whole Strategy/Shim thing with a simple ImportInternal method that we can overwrite and is also no longer public. That also gets rid of all the boilerplate code from the first patches and also makes the follow-up LLDB patch nicer.

Thu, Mar 21, 1:15 PM · Restricted Project
aaronpuchert added inline comments to D59523: Thread Safety: also look at ObjC methods.
Thu, Mar 21, 1:12 PM · Restricted Project
ruiu added inline comments to D59649: [ELF] Improve error message for relocations to symbols defined in discarded COMDAT.
Thu, Mar 21, 1:12 PM · Restricted Project
efriedma added a comment to D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants.

The IR at this

Thu, Mar 21, 1:12 PM · Restricted Project, Restricted Project
rnkovacs added a comment to D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers.

Following are the assumptions/limitations of this patch:

1. The assumption is that iteration of ordered containers of pointers is not non-deterministic.
Thu, Mar 21, 1:09 PM · Restricted Project
craig.topper committed rG3205dbb3f1f9: [Driver] Pass -malign-double from the driver to the cc1 command line (authored by craig.topper).
[Driver] Pass -malign-double from the driver to the cc1 command line
Thu, Mar 21, 1:07 PM
NoQ added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

There seems to be a crash in this code. @koldaniel, would you like to take a look? https://bugs.llvm.org/show_bug.cgi?id=41185

Thu, Mar 21, 1:06 PM · Restricted Project
ctopper committed rC356706: [Driver] Pass -malign-double from the driver to the cc1 command line.
[Driver] Pass -malign-double from the driver to the cc1 command line
Thu, Mar 21, 1:06 PM
ctopper committed rL356706: [Driver] Pass -malign-double from the driver to the cc1 command line.
[Driver] Pass -malign-double from the driver to the cc1 command line
Thu, Mar 21, 1:06 PM
Diffusion closed D59624: [Driver] Pass -malign-double from the driver to the cc1 command line.
Thu, Mar 21, 1:06 PM · Restricted Project
aemerson added inline comments to D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants.
Thu, Mar 21, 1:00 PM · Restricted Project, Restricted Project
ahatanak committed rG65bb3f92bd5f: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with… (authored by ahatanak).
[CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with…
Thu, Mar 21, 1:00 PM
ahatanak committed rL356705: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue.
[CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue
Thu, Mar 21, 1:00 PM
ahatanak committed rC356705: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue.
[CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue
Thu, Mar 21, 1:00 PM
ahatanak closed D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64.
Thu, Mar 21, 1:00 PM · Restricted Project, Restricted Project
ruiu added a comment to D59663: [Support] MemoryBlock size should reflect the requested size.

I'm wondering why it wasn't caught by a Windows bot if I missed it for Windows. Could you write a test that fails currently and passes after this change?

Thu, Mar 21, 1:00 PM
craig.topper added a reviewer for D59662: [X86] Use xmm registers to implement 64-bit popcnt on 32-bit targets if possible if popcnt instruction is not available: andreadb.
Thu, Mar 21, 1:00 PM · Restricted Project
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Thu, Mar 21, 12:56 PM
riccibruno added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

This is causing https://bugs.llvm.org/show_bug.cgi?id=41171.

Thu, Mar 21, 12:48 PM · Restricted Project
Richard Smith <richard-llvm@metafoo.co.uk> committed rG86559dcb8d51: Refactor handling of #include directives to cleanly separate the "skipped… (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Refactor handling of #include directives to cleanly separate the "skipped…
Thu, Mar 21, 12:45 PM
rsmith committed rL356704: Refactor handling of #include directives to cleanly separate the.
Refactor handling of #include directives to cleanly separate the
Thu, Mar 21, 12:43 PM
rsmith committed rC356704: Refactor handling of #include directives to cleanly separate the.
Refactor handling of #include directives to cleanly separate the
Thu, Mar 21, 12:43 PM
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Thu, Mar 21, 12:42 PM