Page MenuHomePhabricator
Differential D44231 Diff 137497 test/clang-tidy/misc-sizeof-expression.cpp

Changeset View

Standalone View

View Options

test/clang-tidy/misc-sizeof-expression.cpp

Context not available.
#pragma pack(1) #pragma pack(1)
struct S { char a, b, c; }; struct S { char a, b, c; };
enum E { E_VALUE = 0 };
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Can you add a C++11 test case using enum class -- I am worried that the isInteger() matcher will return false for that type.

Also, I think you should have a test case for bool; I think the check will diagnose bool types but I'm not certain there's value in diagnosing those. What do you think?

aaron.ballman: Can you add a C++11 test case using `enum class` -- I am worried that the `isInteger()` matcher…
alexfhUnsubmitted
Done
ReplyInline Actions

I think the check will diagnose bool types but I'm not certain there's value in diagnosing those

It will be easier to decide once someone finds a few examples of those in real life code.

alexfh: > I think the check will diagnose bool types but I'm not certain there's value in diagnosing…
int AsInt() { return 0; }
E AsEnum() { return E_VALUE; }
S AsStruct() { return {}; }
struct M {
int AsInt() { return 0; }
E AsEnum() { return E_VALUE; }
S AsStruct() { return {}; }
};
int Test1(const char* ptr) { int Test1(const char* ptr) {
int sum = 0; int sum = 0;
sum += sizeof(LEN); sum += sizeof(LEN);
Context not available.
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(K)' // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(K)'
sum += sizeof(sum, LEN); sum += sizeof(sum, LEN);
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(..., ...)' // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(..., ...)'
sum += sizeof(AsInt());
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(expr)' to an integer
sum += sizeof(AsEnum());
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(expr)' to an integer
sum += sizeof(M{}.AsInt());
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(expr)' to an integer
sum += sizeof(M{}.AsEnum());
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(expr)' to an integer
sum += sizeof(sizeof(X)); sum += sizeof(sizeof(X));
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(sizeof(...))' // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(sizeof(...))'
sum += sizeof(LEN + sizeof(X)); sum += sizeof(LEN + sizeof(X));
Context not available.
if (sizeof(A) < 10) if (sizeof(A) < 10)
sum += sizeof(A); sum += sizeof(A);
sum += sizeof(int); sum += sizeof(int);
sum += sizeof(AsStruct());
sum += sizeof(M{}.AsStruct());
sum += sizeof(A[sizeof(A) / sizeof(int)]); sum += sizeof(A[sizeof(A) / sizeof(int)]);
sum += sizeof(&A[sizeof(A) / sizeof(int)]); sum += sizeof(&A[sizeof(A) / sizeof(int)]);
sum += sizeof(sizeof(0)); // Special case: sizeof size_t. sum += sizeof(sizeof(0)); // Special case: sizeof size_t.
Context not available.