Page MenuHomePhabricator
Differential D44231 Diff 137497 clang-tidy/misc/SizeofExpressionCheck.cpp

Changeset View

Standalone View

View Options

clang-tidy/misc/SizeofExpressionCheck.cpp

Context not available.
ClangTidyContext *Context) ClangTidyContext *Context)
: ClangTidyCheck(Name, Context), : ClangTidyCheck(Name, Context),
WarnOnSizeOfConstant(Options.get("WarnOnSizeOfConstant", 1) != 0), WarnOnSizeOfConstant(Options.get("WarnOnSizeOfConstant", 1) != 0),
WarnOnSizeOfCall(Options.get("WarnOnSizeOfCall", 1) != 0),
WarnOnSizeOfThis(Options.get("WarnOnSizeOfThis", 1) != 0), WarnOnSizeOfThis(Options.get("WarnOnSizeOfThis", 1) != 0),
WarnOnSizeOfCompareToConstant( WarnOnSizeOfCompareToConstant(
Options.get("WarnOnSizeOfCompareToConstant", 1) != 0) {} Options.get("WarnOnSizeOfCompareToConstant", 1) != 0) {}
void SizeofExpressionCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { void SizeofExpressionCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "WarnOnSizeOfConstant", WarnOnSizeOfConstant); Options.store(Opts, "WarnOnSizeOfConstant", WarnOnSizeOfConstant);
Options.store(Opts, "WarnOnSizeOfCall", WarnOnSizeOfCall);
Options.store(Opts, "WarnOnSizeOfThis", WarnOnSizeOfThis); Options.store(Opts, "WarnOnSizeOfThis", WarnOnSizeOfThis);
Options.store(Opts, "WarnOnSizeOfCompareToConstant", Options.store(Opts, "WarnOnSizeOfCompareToConstant",
WarnOnSizeOfCompareToConstant); WarnOnSizeOfCompareToConstant);
Context not available.
const auto ConstantExpr = expr(ignoringParenImpCasts( const auto ConstantExpr = expr(ignoringParenImpCasts(
anyOf(integerLiteral(), unaryOperator(hasUnaryOperand(IntegerExpr)), anyOf(integerLiteral(), unaryOperator(hasUnaryOperand(IntegerExpr)),
binaryOperator(hasLHS(IntegerExpr), hasRHS(IntegerExpr))))); binaryOperator(hasLHS(IntegerExpr), hasRHS(IntegerExpr)))));
const auto IntegerCallExpr =
expr(ignoringParenImpCasts(callExpr(hasType(isInteger()))));
const auto SizeOfExpr = const auto SizeOfExpr =
expr(anyOf(sizeOfExpr(has(type())), sizeOfExpr(has(expr())))); expr(anyOf(sizeOfExpr(has(type())), sizeOfExpr(has(expr()))));
const auto SizeOfZero = expr( const auto SizeOfZero = expr(
Context not available.
this); this);
} }
// Detect sizeof(f())
if (WarnOnSizeOfCall) {
Finder->addMatcher(
expr(sizeOfExpr(ignoringParenImpCasts(has(IntegerCallExpr))))
.bind("sizeof-integer-call"),
this);
}
// Detect expression like: sizeof(this); // Detect expression like: sizeof(this);
if (WarnOnSizeOfThis) { if (WarnOnSizeOfThis) {
Finder->addMatcher( Finder->addMatcher(
Context not available.
if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-constant")) { if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-constant")) {
diag(E->getLocStart(), diag(E->getLocStart(),
"suspicious usage of 'sizeof(K)'; did you mean 'K'?"); "suspicious usage of 'sizeof(K)'; did you mean 'K'?");
} else if (const auto *E =
Result.Nodes.getNodeAs<Expr>("sizeof-integer-call")) {
diag(E->getLocStart(), "suspicious usage of 'sizeof(expr)' to an integer");
alexfhUnsubmitted
Done
ReplyInline Actions

I'm not sure I understand the message "suspicious usage of ... to an integer". Specifically, what does the "to an integer" part mean?

alexfh: I'm not sure I understand the message "suspicious usage of ... to an integer". Specifically…
pfultz2AuthorUnsubmitted
Done
ReplyInline Actions

That could probably be worded better. It means the expr is an integer type. Maybe I should say suspicious usage of 'sizeof() on an expression that results in an integer?

pfultz2: That could probably be worded better. It means the `expr` is an integer type. Maybe I should…
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Missing a terminating quote around sizeof.

aaron.ballman: Missing a terminating quote around `sizeof`.
} else if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-this")) { } else if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-this")) {
diag(E->getLocStart(), diag(E->getLocStart(),
"suspicious usage of 'sizeof(this)'; did you mean 'sizeof(*this)'"); "suspicious usage of 'sizeof(this)'; did you mean 'sizeof(*this)'");
Context not available.