Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D43319 Diff 134438 MicroBenchmarks/LCALS/SubsetCRawLoops/lit.local.cfg

Changeset View

Standalone View

View Options

MicroBenchmarks/LCALS/SubsetCRawLoops/lit.local.cfg

  • This file was added.
test_modules = config.test_modules
if 'run' in test_modules:
# Insert microbenchmark module behind 'run'
test_modules.insert(test_modules.index('run')+1, 'microbenchmark')
# Timeit results are not useful for microbenchmarks
if 'timeit' in test_modules:
test_modules.remove('timeit')
MatzeBUnsubmitted
Not Done
ReplyInline Actions

It's enough to have this at the toplevel /Microbenchmark directory I think, and you shouldn't need to repeat it for each subdirectory, is it not?

MatzeB: It's enough to have this at the toplevel `/Microbenchmark` directory I think, and you shouldn't…
homerdinAuthorUnsubmitted
Not Done
ReplyInline Actions

Tested it and you're right, everything works with it in the /Microbenchmark directory so long as the subdirectory ones are removed.

microbenchmark.py raises an exception if there are both. So I added the lit.local.cfg in /Microbenchmark in https://reviews.llvm.org/D43316 so nothing breaks in the XRay tests. Would be better to commit that change first anyways, cause without it these tests produce 1 big number.

# We need stdout outself to get the benchmark csv data.
if cmd.stdout is not None:
    raise Exception("Rerouting stdout not allowed for microbenchmarks")
homerdin: Tested it and you're right, everything works with it in the `/Microbenchmark` directory so long…