Changeset View
Changeset View
Standalone View
Standalone View
lib/CodeGen/AsmPrinter/DwarfDebug.cpp
| Show First 20 Lines • Show All 284 Lines • ▼ Show 20 Lines | else if (IsDarwin) | ||||
| DebuggerTuning = DebuggerKind::LLDB; | DebuggerTuning = DebuggerKind::LLDB; | ||||
| else if (TT.isPS4CPU()) | else if (TT.isPS4CPU()) | ||||
| DebuggerTuning = DebuggerKind::SCE; | DebuggerTuning = DebuggerKind::SCE; | ||||
| else | else | ||||
| DebuggerTuning = DebuggerKind::GDB; | DebuggerTuning = DebuggerKind::GDB; | ||||
| // Turn on accelerator tables for LLDB by default. | // Turn on accelerator tables for LLDB by default. | ||||
| if (DwarfAccelTables == Default) | if (DwarfAccelTables == Default) | ||||
| HasDwarfAccelTables = tuneForLLDB(); | HasDwarfAccelTables = tuneForLLDB() && IsDarwin; | ||||
aprantl: I'm not sure isDarwin is the right condition for this. Can you check for isMachO instead? I'm… | |||||
| else | else | ||||
| HasDwarfAccelTables = DwarfAccelTables == Enable; | HasDwarfAccelTables = DwarfAccelTables == Enable; | ||||
| HasAppleExtensionAttributes = tuneForLLDB(); | HasAppleExtensionAttributes = tuneForLLDB(); | ||||
| // Handle split DWARF. | // Handle split DWARF. | ||||
| HasSplitDwarf = !Asm->TM.Options.MCOptions.SplitDwarfFile.empty(); | HasSplitDwarf = !Asm->TM.Options.MCOptions.SplitDwarfFile.empty(); | ||||
| ▲ Show 20 Lines • Show All 1,890 Lines • Show Last 20 Lines | |||||
I'm not sure isDarwin is the right condition for this. Can you check for isMachO instead? I'm afraid that this would break LLDB for embedded use-cases otherwise.