Please use GitHub pull requests for new patches. Phabricator shutdown timeline
Changeset View
Standalone View
compiler-rt/test/lit.common.configured.in
| Show All 19 Lines | |||||
| set_default("llvm_shlib_dir", "@LLVM_LIBRARY_OUTPUT_INTDIR@") | set_default("llvm_shlib_dir", "@LLVM_LIBRARY_OUTPUT_INTDIR@") | ||||
| set_default("gold_executable", "@GOLD_EXECUTABLE@") | set_default("gold_executable", "@GOLD_EXECUTABLE@") | ||||
| set_default("clang", "@COMPILER_RT_TEST_COMPILER@") | set_default("clang", "@COMPILER_RT_TEST_COMPILER@") | ||||
| set_default("compiler_id", "@COMPILER_RT_TEST_COMPILER_ID@") | set_default("compiler_id", "@COMPILER_RT_TEST_COMPILER_ID@") | ||||
| set_default("python_executable", "@PYTHON_EXECUTABLE@") | set_default("python_executable", "@PYTHON_EXECUTABLE@") | ||||
| set_default("compiler_rt_debug", @COMPILER_RT_DEBUG_PYBOOL@) | set_default("compiler_rt_debug", @COMPILER_RT_DEBUG_PYBOOL@) | ||||
| set_default("compiler_rt_libdir", "@COMPILER_RT_LIBRARY_OUTPUT_DIR@") | set_default("compiler_rt_libdir", "@COMPILER_RT_LIBRARY_OUTPUT_DIR@") | ||||
| set_default("emulator", "@COMPILER_RT_EMULATOR@") | set_default("emulator", "@COMPILER_RT_EMULATOR@") | ||||
| set_default("asan_shadow_scale", "@COMPILER_RT_ASAN_SHADOW_SCALE@") | |||||
vitalybuka: can you just just use target_cflags and COMPILER_RT_TEST_COMPILER_CFLAGS | |||||
waltlAuthorUnsubmitted Not Done ReplyInline ActionsMaybe? Currently COMPILER_RT_TEST_COMPILER_CFLAGS doesn't get propagated to target_cflags because individual sanitizers have their own definitions of target_cflags that supercede it. Is this intended? If the right thing to do is to append the target_cflags together I can do that and it'd better serve our purpose here. waltl: Maybe? Currently COMPILER_RT_TEST_COMPILER_CFLAGS doesn't get propagated to target_cflags… | |||||
vitalybukaUnsubmitted Not Done ReplyInline ActionsThey append content of COMPILER_RT_TEST_COMPILER_CFLAGS, it's in get_test_cc_for_arch implementation vitalybuka: They append content of COMPILER_RT_TEST_COMPILER_CFLAGS, it's in get_test_cc_for_arch… | |||||
waltlAuthorUnsubmitted Not Done ReplyInline ActionsSorry if I'm missing something, but it looks to me that in get_test_cc_for_arch, COMPILER_RT_TEST_COMPILER_CFLAGS is only used for ANDROID, arm, and aarch64. For others, the target CFLAGS comes from TARGET_${arch}_CFLAGS which is constructed by test_targets(), but I am not seeing COMPILER_RT_TEST_COMPILER_CFLAGS referenced in there. This is also supported by experimentation. waltl: Sorry if I'm missing something, but it looks to me that in get_test_cc_for_arch… | |||||
| set_default("ios", False) | set_default("ios", False) | ||||
| set_default("iossim", False) | set_default("iossim", False) | ||||
| set_default("sanitizer_can_use_cxxabi", @SANITIZER_CAN_USE_CXXABI_PYBOOL@) | set_default("sanitizer_can_use_cxxabi", @SANITIZER_CAN_USE_CXXABI_PYBOOL@) | ||||
| set_default("has_lld", @COMPILER_RT_HAS_LLD_PYBOOL@) | set_default("has_lld", @COMPILER_RT_HAS_LLD_PYBOOL@) | ||||
| set_default("can_symbolize", @CAN_SYMBOLIZE@) | set_default("can_symbolize", @CAN_SYMBOLIZE@) | ||||
| set_default("use_lld", False) | set_default("use_lld", False) | ||||
| set_default("use_thinlto", False) | set_default("use_thinlto", False) | ||||
| set_default("android", @ANDROID_PYBOOL@) | set_default("android", @ANDROID_PYBOOL@) | ||||
| Show All 12 Lines | |||||
can you just just use target_cflags and COMPILER_RT_TEST_COMPILER_CFLAGS