Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D39775 Diff 122017 llvm/test/Instrumentation/AddressSanitizer/test64.ll

Changeset View

Standalone View

View Options

llvm/test/Instrumentation/AddressSanitizer/test64.ll

; RUN: opt < %s -asan -asan-module -S | FileCheck %s ; RUN: %opt_asan < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S%scale %s
vitalybukaUnsubmitted
Done
ReplyInline Actions

Looks to complicated. I'd prefer if you:

  1. don't move files into ShadowScale3
  2. Remove %opt_asan
  3. remove asan_test_shadow_scale and just add additional RUN: in tests where it makes sense. E.g.:

; RUN: %opt < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S3 %s
; RUN: %opt -asan-mapping-scale=5 < %s -asan -asan-module -S | FileCheck --check-prefixes=CHECK,CHECK-S5 %s

vitalybuka: Looks to complicated. I'd prefer if you: 1. don't move files into ShadowScale3 2. Remove…
waltlAuthorUnsubmitted
Not Done
ReplyInline Actions

Done. I selectively enabled some tests; it seems that the stack-poisoning/stack_layout tests are useful as well but they are harder to port, so perhaps I'll do that in a separate commit.

waltl: Done. I selectively enabled some tests; it seems that the stack-poisoning/stack_layout tests…
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
define i32 @read_4_bytes(i32* %a) sanitize_address { define i32 @read_4_bytes(i32* %a) sanitize_address {
entry: entry:
%tmp1 = load i32, i32* %a, align 4 %tmp1 = load i32, i32* %a, align 4
ret i32 %tmp1 ret i32 %tmp1
} }
; CHECK-LABEL: @read_4_bytes ; CHECK-LABEL: @read_4_bytes
; CHECK-NOT: ret ; CHECK-NOT: ret
; CHECK: lshr {{.*}} 3 ; CHECK-S3: lshr {{.*}} 3
; Check for ASAN's Offset for 64-bit (7fff8000) ; CHECK-S5: lshr {{.*}} 5
; CHECK-NEXT: add{{.*}}2147450880 ; Check for ASAN's Offset for 64-bit (7fff8000|7ffe0000)
; CHECK-S3-NEXT: add{{.*}}2147450880
; CHECK-S5-NEXT: add{{.*}}2147352576
; CHECK: ret ; CHECK: ret
define void @example_atomicrmw(i64* %ptr) nounwind uwtable sanitize_address { define void @example_atomicrmw(i64* %ptr) nounwind uwtable sanitize_address {
entry: entry:
%0 = atomicrmw add i64* %ptr, i64 1 seq_cst %0 = atomicrmw add i64* %ptr, i64 1 seq_cst
ret void ret void
} }
; CHECK-LABEL: @example_atomicrmw ; CHECK-LABEL: @example_atomicrmw
; CHECK: lshr {{.*}} 3 ; CHECK-S3: lshr {{.*}} 3
; CHECK-S5: lshr {{.*}} 5
; CHECK: __asan_report_store8 ; CHECK: __asan_report_store8
; CHECK-NOT: __asan_report ; CHECK-NOT: __asan_report
; CHECK: atomicrmw ; CHECK: atomicrmw
; CHECK: ret ; CHECK: ret
define void @example_cmpxchg(i64* %ptr, i64 %compare_to, i64 %new_value) nounwind uwtable sanitize_address { define void @example_cmpxchg(i64* %ptr, i64 %compare_to, i64 %new_value) nounwind uwtable sanitize_address {
entry: entry:
%0 = cmpxchg i64* %ptr, i64 %compare_to, i64 %new_value seq_cst seq_cst %0 = cmpxchg i64* %ptr, i64 %compare_to, i64 %new_value seq_cst seq_cst
ret void ret void
} }
; CHECK-LABEL: @example_cmpxchg ; CHECK-LABEL: @example_cmpxchg
; CHECK: lshr {{.*}} 3 ; CHECK-S3: lshr {{.*}} 3
; CHECK-S5: lshr {{.*}} 5
; CHECK: __asan_report_store8 ; CHECK: __asan_report_store8
; CHECK-NOT: __asan_report ; CHECK-NOT: __asan_report
; CHECK: cmpxchg ; CHECK: cmpxchg
; CHECK: ret ; CHECK: ret