Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
Changeset View
Changeset View
Standalone View
Standalone View
lib/CodeGen/TargetFrameLoweringImpl.cpp
| Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines | unsigned TargetFrameLowering::getStackAlignmentSkew( | ||||
| const MachineFunction &MF) const { | const MachineFunction &MF) const { | ||||
| // When HHVM function is called, the stack is skewed as the return address | // When HHVM function is called, the stack is skewed as the return address | ||||
| // is removed from the stack before we enter the function. | // is removed from the stack before we enter the function. | ||||
| if (LLVM_UNLIKELY(MF.getFunction()->getCallingConv() == CallingConv::HHVM)) | if (LLVM_UNLIKELY(MF.getFunction()->getCallingConv() == CallingConv::HHVM)) | ||||
| return MF.getTarget().getPointerSize(); | return MF.getTarget().getPointerSize(); | ||||
| return 0; | return 0; | ||||
| } | } | ||||
| int TargetFrameLowering::getInitialCFAOffset(const MachineFunction &MF) const { | |||||
| llvm_unreachable("getInitialCFAOffset() not implemented!"); | |||||
| } | |||||
MatzeB: llvm_unreachable never returns so you can leave out the `return` statement behind it. Same in… | |||||
| unsigned TargetFrameLowering::getInitialCFARegister(const MachineFunction &MF) | |||||
I'd simply use llvm_unreachable("getInitialCFAOffset not implemented!"); and don't even bother checking the flag. Same in the next function. MatzeB: I'd simply use `llvm_unreachable("getInitialCFAOffset not implemented!");` and don't even… | |||||
| const { | |||||
| llvm_unreachable("getInitialCFARegister() not implemented!"); | |||||
| } | |||||
| No newline at end of file | |||||
llvm_unreachable never returns so you can leave out the return statement behind it. Same in the next function.