Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D35844 Diff 119589 include/llvm/CodeGen/Passes.h

Changeset View

Standalone View

View Options

include/llvm/CodeGen/Passes.h

Show First 20 Lines • Show All 411 Lines • ▼ Show 20 Lines/// MachineDominanaceFrontier - This pass is a machine dominators analysis pass.
/// This pass performs outlining on machine instructions directly before /// This pass performs outlining on machine instructions directly before
/// printing assembly. /// printing assembly.
ModulePass *createMachineOutlinerPass(bool OutlineFromLinkOnceODRs = false); ModulePass *createMachineOutlinerPass(bool OutlineFromLinkOnceODRs = false);
/// This pass expands the experimental reduction intrinsics into sequences of /// This pass expands the experimental reduction intrinsics into sequences of
/// shuffles. /// shuffles.
FunctionPass *createExpandReductionsPass(); FunctionPass *createExpandReductionsPass();
/// Creates CFI Instruction Inserter pass. \see CFIInstrInserter.cpp
FunctionPass *createCFIInstrInserter();
} // End llvm namespace } // End llvm namespace
MatzeBUnsubmitted
Done
ReplyInline Actions

Even though there is a lot of precedent in this file, I'm starting to wonder how useful it is to have a description of a pass at the beginning of the passes implementation file and another one in front of the corresponding function in Passes.h. Maybe it would be best to shorten this to:

/// Creates CFI Instruction Inserter pass. \see CFIInstrInserter.cpp

so we only have to maintain one description of the passes details.

MatzeB: Even though there is a lot of precedent in this file, I'm starting to wonder how useful it is…
#endif #endif